jfs-components 0.0.85 → 0.0.86

package/src/components/FullscreenModal/FullscreenModal.tsx

@@ -3,17 +3,11 @@ import {
   View,
   Text,
   ScrollView,
+  StyleSheet,
   type StyleProp,
   type ViewStyle,
   type TextStyle,
 } from 'react-native'
-import Animated, {
-  Extrapolation,
-  interpolate,
-  useAnimatedScrollHandler,
-  useAnimatedStyle,
-  useSharedValue,
-} from 'react-native-reanimated'
 import { getVariableByName } from '../../design-tokens/figma-variables-resolver'
 import { useTokens } from '../../design-tokens/JFSThemeProvider'
 import { EMPTY_MODES, cloneChildrenWithModes } from '../../utils/react-utils'
@@ -37,17 +31,6 @@ import Slot from '../Slot/Slot'
 // ---------------------------------------------------------------------------
 const FULLSCREEN_MODAL_FORCED_MODES = Object.freeze({ context5: 'Fullscreen Modal' })
 
-// Reanimated-driven ScrollView so the parallax handler runs on the UI thread.
-// Module scope so the wrapped component identity is stable across renders.
-const AnimatedScrollView = Animated.createAnimatedComponent(ScrollView)
-
-// Parallax tuning. The hero collapses by HEIGHT only as the user scrolls up —
-// its full width is preserved and the media keeps a fixed aspect ratio (it is
-// cropped, never scaled or squished, like a `cover` background). When no
-// explicit `heroMinHeight` is given, the hero collapses to this fraction of
-// its resting height.
-const HERO_MIN_HEIGHT_RATIO = 0.45
-
 export type FullscreenModalProps = {
   /** Small eyebrow line above the headline. */
   eyebrow?: string
@@ -58,23 +41,20 @@ export type FullscreenModalProps = {
   /** Secondary line below the supporting paragraph (e.g. a price / timeline). */
   priceText?: string
   /**
-   * Media rendered full-bleed behind the hero text and driven by the parallax
-   * scroll effect. Bring any renderer — most commonly a `LottiePlayer`, but an
-   * `Image`, `Video`, or `SvgXml` works too. Size it to fill the hero box
-   * (`heroHeight` tall, full modal width) and let it `cover` so that as the
-   * hero collapses in height the art is cropped, never distorted. `modes` are
-   * cascaded into it.
+   * Background media rendered full-bleed behind the hero text. Bring any
+   * renderer — most commonly an `Image`, but a `LottiePlayer`, `Video`, or
+   * `SvgXml` works too. It is laid out at the full modal width; size it with an
+   * aspect ratio (e.g. `<Image ratio={3 / 4} />`) so its height follows the
+   * width naturally. The media scrolls together with the rest of the content
+   * (no parallax). `modes` are cascaded into it.
    */
   heroMedia?: React.ReactNode
-  /** Resting height of the hero region. Defaults to 420. */
-  heroHeight?: number
   /**
-   * Collapsed height the hero shrinks to at full scroll. Defaults to
-   * `heroHeight * 0.45`. Only the height changes — the width is always full.
+   * Fallback height for the hero text region when no `heroMedia` is provided.
+   * When `heroMedia` is present, the hero height is driven entirely by the
+   * media's own aspect ratio and this value is ignored. Defaults to 420.
    */
-  heroMinHeight?: number
-  /** Enable the scroll-driven hero collapse. Defaults to true. */
-  parallax?: boolean
+  heroHeight?: number
   /** Whether to render the floating close button (top-right). Defaults to true. */
   showClose?: boolean
   /** Press handler for the close button. */
@@ -109,7 +89,7 @@ export type FullscreenModalProps = {
 // Hero text — the eyebrow / headline / supporting / price block. Built inline
 // (rather than reusing <PageHero>) so we can render BOTH a supporting
 // paragraph AND a price line with the exact PageHero token gaps, and overlay
-// it on the parallax media without PageHero's media/button scaffolding.
+// it on the hero media without PageHero's media/button scaffolding.
 // ---------------------------------------------------------------------------
 type HeroTextProps = {
   eyebrow?: string
@@ -181,8 +161,9 @@ function HeroText({ eyebrow, headline, supportingText, priceText, modes }: HeroT
 }
 
 /**
- * FullscreenModal — a full-screen takeover surface with a parallax media hero,
- * a scrollable body, a floating close button, and a sticky `ActionFooter`.
+ * FullscreenModal — a full-screen takeover surface with a full-bleed media
+ * hero, a scrollable body, a floating close button, and a sticky
+ * `ActionFooter`.
  *
  * The component always themes itself with `context5: 'Fullscreen Modal'`
  * (non-overridable) so every nested component (Section, ListItem, Button,
@@ -190,14 +171,12 @@ function HeroText({ eyebrow, headline, supportingText, priceText, modes }: HeroT
  * That mode is cascaded into `children`, the footer, and the hero text via
  * `cloneChildrenWithModes` / the merged `modes` object.
  *
- * ### Parallax
- * As the user scrolls up, the hero collapses by **height only** (from
- * `heroHeight` to `heroMinHeight`) — its **full width is always preserved**.
- * The `heroMedia` is pinned to the top at a fixed size and `cover`-cropped by
- * the collapsing clip, so it keeps a perfect aspect ratio the whole time
- * (never scaled or squished). Because it collapses slower than the content
- * scrolls, the media lags behind for the parallax depth cue. Disable with
- * `parallax={false}`.
+ * ### Hero
+ * The `heroMedia` is rendered full modal width inside the scroll body and
+ * takes its height from its own aspect ratio. The hero text (eyebrow /
+ * headline / supporting / price) is overlaid on top, anchored to the bottom.
+ * The whole hero scrolls together with the rest of the content — there is no
+ * parallax effect.
  *
  * @component
  * @example
@@ -207,7 +186,7 @@ function HeroText({ eyebrow, headline, supportingText, priceText, modes }: HeroT
  *   headline="Get more from your money."
  *   supportingText="JioFinance+ is your upgraded financial experience…"
  *   priceText="₹999/year · ₹0 until 2027"
- *   heroMedia={<LottiePlayer source={hero} size={{ width: 360, height: 420 }} />}
+ *   heroMedia={<Image imageSource={hero} ratio={3 / 4} />}
  *   primaryActionLabel="Upgrade for free"
  *   disclaimer="By upgrading, we'll check your eligibility with Experian."
  *   onPrimaryAction={() => upgrade()}
@@ -225,8 +204,6 @@ function FullscreenModal({
   priceText = '₹999/year · ₹0 until 2027',
   heroMedia,
   heroHeight = 420,
-  heroMinHeight,
-  parallax = true,
   showClose = true,
   onClose,
   closeAccessibilityLabel = 'Close',
@@ -252,28 +229,6 @@ function FullscreenModal({
 
   const rootGap = Number(getVariableByName('fullScreenModal/gap', modes)) || 16
 
-  const minHeight = heroMinHeight ?? Math.round(heroHeight * HERO_MIN_HEIGHT_RATIO)
-
-  const scrollY = useSharedValue(0)
-  const onScroll = useAnimatedScrollHandler((event) => {
-    scrollY.value = event.contentOffset.y
-  })
-
-  // Collapse the hero by HEIGHT only as the user scrolls up. The clip's width
-  // never changes and the media inside is pinned full-size at the top, so the
-  // art is cropped (cover) rather than scaled or narrowed — it keeps a perfect
-  // aspect ratio the whole time. Pull-down (negative offset) is clamped, so the
-  // hero never grows past its resting height.
-  const heroAnimatedStyle = useAnimatedStyle(() => {
-    const height = interpolate(
-      scrollY.value,
-      [0, heroHeight],
-      [heroHeight, minHeight],
-      Extrapolation.CLAMP
-    )
-    return { height }
-  })
-
   const processedHeroMedia = useMemo(
     () =>
       heroMedia ? cloneChildrenWithModes(heroMedia, modes, FULLSCREEN_MODAL_FORCED_MODES) : null,
@@ -286,37 +241,11 @@ function FullscreenModal({
     [children, modes]
   )
 
-  // The clip is full-width and top-pinned; its height is what animates. Width
-  // is intentionally never animated.
-  const heroClipBaseStyle = useMemo<ViewStyle>(
-    () => ({
-      position: 'absolute',
-      top: 0,
-      left: 0,
-      right: 0,
-      overflow: 'hidden',
-    }),
-    []
-  )
-
-  // The media sits at a fixed full-size box pinned to the top of the clip, so
-  // the collapsing clip crops it from the bottom (cover) instead of resizing
-  // it. Full width, fixed height — a perfect, constant aspect ratio.
-  const heroMediaWrapStyle = useMemo<ViewStyle>(
+  // No-media fallback: without hero media the text region needs an explicit
+  // resting height (driven by `heroHeight`) so the hero still has presence.
+  const heroTextFallbackStyle = useMemo<ViewStyle>(
     () => ({
-      position: 'absolute',
-      top: 0,
-      left: 0,
-      right: 0,
-      height: heroHeight,
-      alignItems: 'stretch',
-    }),
-    [heroHeight]
-  )
-
-  const heroTextRegionStyle = useMemo<ViewStyle>(
-    () => ({
-      height: heroHeight,
+      minHeight: heroHeight,
       justifyContent: 'flex-end',
       paddingHorizontal: 16,
       paddingBottom: 16,
@@ -337,13 +266,29 @@ function FullscreenModal({
     [backgroundColor, rootGap, contentContainerStyle]
   )
 
-  const heroClip = (
-    <Animated.View
-      style={[heroClipBaseStyle, parallax ? heroAnimatedStyle : { height: heroHeight }]}
-      pointerEvents="none"
-    >
-      <View style={heroMediaWrapStyle}>{processedHeroMedia}</View>
-    </Animated.View>
+  const heroTextNode = (
+    <HeroText
+      eyebrow={eyebrow}
+      headline={headline}
+      supportingText={supportingText}
+      priceText={priceText}
+      modes={modes}
+    />
+  )
+
+  // The hero scrolls inline with the body (no parallax). When media is present
+  // it is laid out full modal width and takes its height from its own aspect
+  // ratio; the hero text is overlaid on top, anchored to the bottom. Without
+  // media the text simply renders in flow at the fallback height.
+  const hero = processedHeroMedia ? (
+    <View style={heroMediaContainerStyle}>
+      {processedHeroMedia}
+      <View style={heroTextOverlayStyle} pointerEvents="box-none">
+        {heroTextNode}
+      </View>
+    </View>
+  ) : (
+    <View style={heroTextFallbackStyle}>{heroTextNode}</View>
   )
 
   // Footer: a fully custom node, or the default Button + Disclaimer column.
@@ -366,29 +311,17 @@ function FullscreenModal({
 
   return (
     <View style={[rootStyle, { backgroundColor }, style]} testID={testID}>
-      {processedHeroMedia ? heroClip : null}
-
-      <AnimatedScrollView
+      <ScrollView
         style={scrollViewStyle}
         contentContainerStyle={scrollContentStyle}
         showsVerticalScrollIndicator={false}
-        onScroll={onScroll}
-        scrollEventThrottle={16}
         // Tap an input in the body and it focuses on the FIRST tap, even when
         // the keyboard is already open (default 'never' eats that tap).
         keyboardShouldPersistTaps="handled"
       >
-        <View style={heroTextRegionStyle}>
-          <HeroText
-            eyebrow={eyebrow}
-            headline={headline}
-            supportingText={supportingText}
-            priceText={priceText}
-            modes={modes}
-          />
-        </View>
+        {hero}
         <View style={bodyStyle}>{processedChildren}</View>
-      </AnimatedScrollView>
+      </ScrollView>
 
       {footerContent ? (
         <ActionFooter modes={modes}>{footerContent}</ActionFooter>
@@ -413,5 +346,14 @@ const scrollViewStyle: ViewStyle = { flex: 1 }
 const scrollContentStyle: ViewStyle = { flexGrow: 1 }
 const fullWidthStyle: ViewStyle = { width: '100%' }
 const closeButtonStyle: ViewStyle = { position: 'absolute', top: 12, right: 12 }
+// Full-width hero wrapper; height comes from the media's own aspect ratio.
+const heroMediaContainerStyle: ViewStyle = { width: '100%', position: 'relative' }
+// Hero text overlaid on the media, anchored to the bottom edge.
+const heroTextOverlayStyle: ViewStyle = {
+  ...StyleSheet.absoluteFillObject,
+  justifyContent: 'flex-end',
+  paddingHorizontal: 16,
+  paddingBottom: 16,
+}
 
 export default FullscreenModal

package/src/components/index.ts

@@ -38,6 +38,7 @@ export { default as CircularProgressBarDoted, type CircularProgressBarDotedProps
 export { default as CircularRating, type CircularRatingProps } from './CircularRating/CircularRating'
 export { default as CoverageRing, type CoverageRingProps } from './CoverageRing/CoverageRing'
 export { default as CoverageBarComparison, type CoverageBarComparisonProps, type CoverageBarComparisonItem } from './CoverageBarComparison/CoverageBarComparison'
+export { default as AllocationComparisonChart, type AllocationComparisonChartProps, type AllocationSegment } from './AllocationComparisonChart/AllocationComparisonChart'
 export { default as MonthlyStatusGrid, CalendarGlyph, type MonthlyStatusGridProps, type MonthlyStatusGridMonth, type MonthlyStatus, type CalendarGlyphProps } from './MonthlyStatusGrid/MonthlyStatusGrid'
 export { default as Gauge, type GaugeProps } from './Gauge/Gauge';
 export { default as HoldingsCard, type HoldingsCardProps } from './HoldingsCard/HoldingsCard';

package/src/icons/registry.ts

@@ -4,7 +4,7 @@
  * Auto-generated from SVG files in src/icons/
  * DO NOT EDIT MANUALLY - Run "npm run icons:generate" to regenerate
  * 
- * Generated: 2026-06-02T15:42:11.888Z
+ * Generated: 2026-06-03T15:59:02.370Z
  */
 
 // Icon name to SVG data mapping