jetbrains-pi-acp 0.1.3 → 0.1.4

package/README.md

@@ -11,7 +11,7 @@ Requires **Node.js 22.19.0+** and a JetBrains IDE with ACP support, such as Inte
 1. Sign in to your model provider from a terminal:
 
    ```bash
-   npx --yes jetbrains-pi-acp@0.1.3 --setup
+   npx --yes jetbrains-pi-acp@0.1.4 --setup
    ```
 
    In pi, run `/login`, complete sign-in, then exit pi and return to the IDE. Credentials are managed by pi.
@@ -23,7 +23,7 @@ Requires **Node.js 22.19.0+** and a JetBrains IDE with ACP support, such as Inte
      "agent_servers": {
        "pi": {
          "command": "npx",
-         "args": ["--yes", "jetbrains-pi-acp@0.1.3"],
+         "args": ["--yes", "jetbrains-pi-acp@0.1.4"],
          "use_idea_mcp": true,
          "use_custom_mcp": true
        }
@@ -52,7 +52,7 @@ The IDE must be able to find `npx`; use its absolute path if needed. Menu locati
 Append pi options after `--` in the agent's `args`, for example:
 
 ```json
-["--yes", "jetbrains-pi-acp@0.1.3", "--", "--model", "provider/model-id", "--thinking", "medium"]
+["--yes", "jetbrains-pi-acp@0.1.4", "--", "--model", "provider/model-id", "--thinking", "medium"]
 ```
 
 Use configuration options here, not initial prompts, interactive mode, or session-selection arguments. The adapter manages RPC mode and sessions.
@@ -67,6 +67,7 @@ Restart the agent connection after updating the adapter or changing startup opti
 
 - Tools execute locally through pi; ACP client-side `fs/*` and `terminal/*` execution is not implemented. Save editor buffers before asking the agent to read or change files.
 - Terminal input uses stdin pipes, not a PTY. Full-screen apps and TTY password prompts are unsupported; background tasks have no stdin input.
+- Only commands the model runs with `interactive: true` accept input. Other commands get an empty stdin (`/dev/null`) like native pi, so commands that read stdin by mistake exit instead of hanging.
 - Diffs have size limits and may be unavailable for binary files or older history. File reports scan at most 20,000 entries or two seconds per snapshot and cannot reliably attribute concurrent external changes.
 - MCP SSE, audio, and binary embedded resources are unsupported. Image support depends on the model.
 - ACP v2 follows a draft schema. Client UI behavior, real provider sign-in, and Windows hardware still need verification.

package/README.zh-CN.md

@@ -11,7 +11,7 @@
 1. 在终端中登录模型提供商：
 
    ```bash
-   npx --yes jetbrains-pi-acp@0.1.3 --setup
+   npx --yes jetbrains-pi-acp@0.1.4 --setup
    ```
 
    在 pi 中运行 `/login`，完成登录后退出 pi 并返回 IDE。凭据由 pi 管理。
@@ -23,7 +23,7 @@
      "agent_servers": {
        "pi": {
          "command": "npx",
-         "args": ["--yes", "jetbrains-pi-acp@0.1.3"],
+         "args": ["--yes", "jetbrains-pi-acp@0.1.4"],
          "use_idea_mcp": true,
          "use_custom_mcp": true
        }
@@ -53,7 +53,7 @@ IDE 必须能找到 `npx`，必要时使用其绝对路径。菜单位置随 IDE
 在 Agent 的 `args` 末尾添加 `--`，随后传递 pi 参数，例如：
 
 ```json
-["--yes", "jetbrains-pi-acp@0.1.3", "--", "--model", "provider/model-id", "--thinking", "medium"]
+["--yes", "jetbrains-pi-acp@0.1.4", "--", "--model", "provider/model-id", "--thinking", "medium"]
 ```
 
 这里只传配置选项，不传初始提示、交互模式或会话选择参数。RPC 模式和会话由适配器管理。
@@ -68,6 +68,7 @@ IDE 必须能找到 `npx`，必要时使用其绝对路径。菜单位置随 IDE
 
 - 工具由本机 pi 执行，尚未接入客户端 `fs/*` 和 `terminal/*` 执行接口。让 Agent 读取或修改文件前，请保存编辑器内容。
 - 终端输入使用 stdin 管道，不提供 PTY，不支持全屏终端应用和 TTY 密码提示；后台任务不支持 stdin 输入。
+- 只有模型以 `interactive: true` 调用的命令可以接收输入；其他命令与 pi 原生一致，stdin 为空（`/dev/null`），误读 stdin 的命令会直接结束，不会卡住。
 - diff 有大小限制，二进制文件或旧历史可能无法展示。每轮文件报告的单次快照最多扫描 20,000 项或两秒，无法准确区分外部并发修改。
 - 不支持 MCP SSE、音频和二进制内嵌资源，图片支持取决于模型。
 - ACP v2 仍为草案，客户端界面展示、真实提供商账号登录及 Windows 实机仍需验证。

package/extensions/acp.ts

@@ -79,13 +79,17 @@ export default function (pi: any) {
       const createTool = name === 'bash' ? createBashToolDefinition : createPowerShellToolDefinition;
       const definition = createTool(process.cwd());
       pi.registerTool({ ...definition,
+        parameters: Type.Object({ ...definition.parameters.properties,
+          interactive: Type.Optional(Type.Boolean({ description: 'Set true only when the command must read input typed by the user on stdin. ' +
+            'Default false: stdin is empty (/dev/null) and no input can be sent while it runs.' })) }),
         execute: async (id: string, args: any, signal: AbortSignal, update: any, ctx: any) => {
+          const interactive = args.interactive === true;
           const settings = SettingsManager.create(ctx.cwd);
           const tool = createTool(ctx.cwd, {
             commandPrefix: settings.getShellCommandPrefix(),
             operations: { exec: (command: string, cwd: string, options: any) => terminals.exec(id,
               name === 'bash' ? getShellConfig(settings.getShellPath()) : getPowerShellConfig(),
-              command, cwd, options, () => ctx.ui.notify(`PI_ACP_TERMINAL_READY:${id}`, 'info')) },
+              command, cwd, { ...options, interactive }, () => ctx.ui.notify(`PI_ACP_TERMINAL_READY:${id}`, 'info')) },
           });
           return tool.execute(id, args, signal, update, ctx);
         },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jetbrains-pi-acp",
-  "version": "0.1.3",
+  "version": "0.1.4",
   "type": "module",
   "description": "连接 JetBrains IDE 与 pi coding agent 的 ACP 适配器",
   "bin": {

package/src/terminal-input.js

@@ -17,7 +17,7 @@ export class TerminalProcesses {
   async input(params) {
     validateTerminalInput(params);
     const child = this.processes.get(params.terminalId);
-    if (!child || child.exitCode !== null || child.signalCode !== null || !child.stdin.writable) {
+    if (!child || child.exitCode !== null || child.signalCode !== null || !child.stdin?.writable) {
       throw new Error(t('terminalUnavailable'));
     }
     await new Promise((resolve, reject) => {
@@ -43,18 +43,19 @@ export class TerminalProcesses {
     for (const child of this.processes.values()) this.kill(child);
   }
 
-  async exec(terminalId, shell, command, cwd, { onData, signal, timeout, env }, ready) {
+  async exec(terminalId, shell, command, cwd, { onData, signal, timeout, env, interactive }, ready) {
     if (signal?.aborted) throw new Error('aborted');
     if (timeout !== undefined && (!Number.isFinite(timeout) || timeout <= 0 || timeout * 1000 > 2147483647)) {
       throw new Error('Invalid timeout');
     }
     // shortcut: stdin 管道不提供 PTY；需要全屏程序、终端尺寸或 tty 密码提示时再接入 PTY。
     if (shell.commandTransport === 'stdin') throw new Error(t('shellStdinTransport'));
+    // 非交互命令的 stdin 用 /dev/null，与 pi 原生一致，避免误读 stdin 的命令一直卡住。
     const child = spawn(shell.shell, [...shell.args, command], {
-      cwd, env, stdio: ['pipe', 'pipe', 'pipe'], detached: process.platform !== 'win32', windowsHide: true,
+      cwd, env, stdio: [interactive ? 'pipe' : 'ignore', 'pipe', 'pipe'], detached: process.platform !== 'win32', windowsHide: true,
     });
     this.processes.set(terminalId, child);
-    child.stdin.on('error', () => {});
+    child.stdin?.on('error', () => {});
     child.stdout.on('data', data => onData(data, 'stdout'));
     child.stderr.on('data', data => onData(data, 'stderr'));
     let timedOut = false;
@@ -70,7 +71,7 @@ export class TerminalProcesses {
           clearTimeout(idleTimer);
           child.stdout.destroy();
           child.stderr.destroy();
-          child.stdin.destroy();
+          child.stdin?.destroy();
           resolve(code ?? 128 + (constants.signals[child.signalCode] ?? 0));
         };
         const drain = () => {
@@ -81,7 +82,7 @@ export class TerminalProcesses {
         child.stdout.on('data', drain);
         child.stderr.on('data', drain);
         child.once('error', reject);
-        child.once('spawn', ready);
+        if (interactive) child.once('spawn', ready);
         child.once('close', finish);
         child.once('exit', () => { exited = true; drain(); });
       });