jest-matcher-http 1.3.0 → 1.4.0

package/integration_tests/axios.int.test.js

@@ -68,7 +68,7 @@ describe('axios', () => {
       }
 
       expect(caughtError.message).toContain(
-        `expected http header "${headerName.toLowerCase()}" with value ""\n`
+        `expected http header "${headerName.toLowerCase()}" to have value ""\n`
               + '\n'
               + 'server responded with body:\n'
               + `${JSON.stringify(resultJson, null, 2)}\n`

package/integration_tests/needle.int.test.js

@@ -67,7 +67,7 @@ describe('needle', () => {
       }
 
       expect(caughtError.message).toContain(
-        `expected http header "${headerName.toLowerCase()}" with value ""\n`
+        `expected http header "${headerName.toLowerCase()}" to have value ""\n`
               + '\n'
               + 'server responded with body:\n'
               + `${JSON.stringify(resultJson, null, 2)}\n`

package/integration_tests/superagent.int.test.js

@@ -67,7 +67,7 @@ describe('superagent', () => {
       }
 
       expect(caughtError.message).toContain(
-        `expected http header "${headerName.toLowerCase()}" with value ""\n`
+        `expected http header "${headerName.toLowerCase()}" to have value ""\n`
               + '\n'
               + 'server responded with body:\n'
               + `${JSON.stringify(resultJson, null, 2)}\n`

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jest-matcher-http",
-  "version": "1.3.0",
+  "version": "1.4.0",
   "description": "Additional Jest matchers for HTTP responses.",
   "main": "src/index.js",
   "scripts": {

package/src/matchers.js

@@ -39,13 +39,10 @@ function toReturnHttpCode(response, expectedHttpStatusCode) {
 
   const pass = status === expectedHttpStatusCode;
 
-  if (pass) {
-    return { pass };
-  }
-
   return {
     pass,
-    message: () => `expected http status code ${status} to equal ${expectedHttpStatusCode}\n\n`
+    message: () => `expected http status code ${status}${pass ? ' not' : ''} `
+      + `to equal ${expectedHttpStatusCode}\n\n`
       + `server responded with body:\n${JSON.stringify(result, null, 2)}\n\n`
       + `server responded with headers:\n${JSON.stringify(headers, null, 2)}`,
   };
@@ -68,13 +65,10 @@ function toReturnHttpHeader(response, headerField, headerValue) {
 
   const pass = headers[headerFieldLowerCase] === headerValue;
 
-  if (pass) {
-    return { pass };
-  }
-
   return {
     pass,
-    message: () => `expected http header "${headerFieldLowerCase}" with value "${headerValue}"\n\n`
+    message: () => `expected http header "${headerFieldLowerCase}"`
+      + `${pass ? ' not' : ''} to have value "${headerValue}"\n\n`
       + `server responded with body:\n${JSON.stringify(result, null, 2)}\n\n`
       + `server responded with headers:\n${JSON.stringify(headers, null, 2)}`,
   };

package/src/matchers.unit.test.js

@@ -67,6 +67,41 @@ describe('matchers', () => {
       );
     });
 
+    it('should succeed if http code is not as expected - negated', async () => {
+      const response = {
+        status: 200,
+        body: {},
+        headers: {},
+      };
+
+      expect(response).not.toReturnHttpCode(1);
+    });
+
+    it('should fail if http code is not as expected - negated', async () => {
+      const response = {
+        status: 200,
+        body: {},
+        headers: {},
+      };
+
+      let caughtError;
+      try {
+        expect(response).not.toReturnHttpCode(response.status);
+      } catch (error) {
+        caughtError = error;
+      }
+
+      expect(caughtError.message).toBe(
+        'expected http status code 200 not to equal 200\n'
+          + '\n'
+          + 'server responded with body:\n'
+          + '{}\n'
+          + '\n'
+          + 'server responded with headers:\n'
+          + '{}',
+      );
+    });
+
     it('should throw if result is not supported', async () => {
       const response = {
         status: 200,
@@ -124,7 +159,7 @@ describe('matchers', () => {
       }
 
       expect(caughtError.message).toBe(
-        'expected http header "request-id" with value "some-uuid"\n'
+        'expected http header "request-id" to have value "some-uuid"\n'
           + '\n'
           + 'server responded with body:\n'
           + '{}\n'
@@ -133,5 +168,44 @@ describe('matchers', () => {
           + '{}',
       );
     });
+
+    it('should succeed if http header is not as expected - negated', async () => {
+      const response = {
+        status: 200,
+        body: {},
+        headers: {},
+      };
+
+      expect(response).not.toReturnHttpHeader('request-id', 'some-uuid');
+    });
+
+    it('should fail if http header is not as expected - negated', async () => {
+      const response = {
+        status: 200,
+        body: {},
+        headers: {
+          'request-id': 'some-uuid',
+        },
+      };
+
+      let caughtError;
+      try {
+        expect(response).not.toReturnHttpHeader('request-id', 'some-uuid');
+      } catch (error) {
+        caughtError = error;
+      }
+
+      expect(caughtError.message).toBe(
+        'expected http header "request-id" not to have value "some-uuid"\n'
+          + '\n'
+          + 'server responded with body:\n'
+          + '{}\n'
+          + '\n'
+          + 'server responded with headers:\n'
+          + '{\n'
+          + '  "request-id": "some-uuid"\n'
+          + '}',
+      );
+    });
   });
 });