jest-image-snapshot 6.1.0 → 6.1.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [6.1.1](https://github.com/americanexpress/jest-image-snapshot/compare/v6.1.0...v6.1.1) (2023-07-25)
+
+
+### Bug Fixes
+
+* only updatePassedSnapshot if updateSnapshot is also true ([#327](https://github.com/americanexpress/jest-image-snapshot/issues/327)) ([b9d9c3f](https://github.com/americanexpress/jest-image-snapshot/commit/b9d9c3f16ab0e10a3e1320d03efb52e81675d2aa)), closes [#320](https://github.com/americanexpress/jest-image-snapshot/issues/320) [#322](https://github.com/americanexpress/jest-image-snapshot/issues/322) [#324](https://github.com/americanexpress/jest-image-snapshot/issues/324)
+
 # [6.1.0](https://github.com/americanexpress/jest-image-snapshot/compare/v6.0.0...v6.1.0) (2022-12-02)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jest-image-snapshot",
-  "version": "6.1.0",
+  "version": "6.1.1",
   "description": "Jest matcher for image comparisons. Most commonly used for visual regression testing.",
   "main": "src/index.js",
   "engines": {
@@ -64,7 +64,6 @@
     "get-stdin": "^5.0.1",
     "glur": "^1.1.2",
     "lodash": "^4.17.4",
-    "mkdirp": "^0.5.1",
     "pixelmatch": "^5.1.0",
     "pngjs": "^3.4.0",
     "rimraf": "^2.6.2",
@@ -73,6 +72,11 @@
   "peerDependencies": {
     "jest": ">=20 <=29"
   },
+  "peerDependenciesMeta": {
+    "jest": {
+      "optional": true
+    }
+  },
   "husky": {
     "hooks": {
       "pre-commit": "npm test",

package/src/diff-snapshot.js

@@ -15,7 +15,6 @@
 const childProcess = require('child_process');
 const fs = require('fs');
 const path = require('path');
-const mkdirp = require('mkdirp');
 const pixelmatch = require('pixelmatch');
 const ssim = require('ssim.js');
 const { PNG } = require('pngjs');
@@ -148,9 +147,8 @@ const alignImagesToSameSize = (firstImage, secondImage) => {
 
 const isFailure = ({ pass, updateSnapshot }) => !pass && !updateSnapshot;
 
-const shouldUpdate = ({ pass, updateSnapshot, updatePassedSnapshot }) => (
-  (!pass && updateSnapshot) || (pass && updatePassedSnapshot)
-);
+const shouldUpdate = ({ pass, updateSnapshot, updatePassedSnapshot }) =>
+  updateSnapshot && (!pass || (pass && updatePassedSnapshot));
 
 const shouldFail = ({
   totalPixels,
@@ -226,7 +224,7 @@ function diffImageToSnapshot(options) {
   let result = {};
   const baselineSnapshotPath = path.join(snapshotsDir, `${snapshotIdentifier}.png`);
   if (!fs.existsSync(baselineSnapshotPath)) {
-    mkdirp.sync(path.dirname(baselineSnapshotPath));
+    fs.mkdirSync(path.dirname(baselineSnapshotPath), { recursive: true });
     fs.writeFileSync(baselineSnapshotPath, receivedImageBuffer);
     result = { added: true };
   } else {
@@ -294,12 +292,12 @@ function diffImageToSnapshot(options) {
 
     if (isFailure({ pass, updateSnapshot })) {
       if (storeReceivedOnFailure) {
-        mkdirp.sync(path.dirname(receivedSnapshotPath));
+        fs.mkdirSync(path.dirname(receivedSnapshotPath), { recursive: true });
         fs.writeFileSync(receivedSnapshotPath, receivedImageBuffer);
         result = { receivedSnapshotPath };
       }
 
-      mkdirp.sync(path.dirname(diffOutputPath));
+      fs.mkdirSync(path.dirname(diffOutputPath), { recursive: true });
       const composer = composeDiff({
         diffDirection, baselineImage, diffImage, receivedImage, imageWidth, imageHeight, onlyDiff,
       });
@@ -334,7 +332,7 @@ function diffImageToSnapshot(options) {
         imgSrcString: `data:image/png;base64,${pngBuffer.toString('base64')}`,
       };
     } else if (shouldUpdate({ pass, updateSnapshot, updatePassedSnapshot })) {
-      mkdirp.sync(path.dirname(baselineSnapshotPath));
+      fs.mkdirSync(path.dirname(baselineSnapshotPath), { recursive: true });
       fs.writeFileSync(baselineSnapshotPath, receivedImageBuffer);
       result = { updated: true };
     } else {