jefrichat-mcp 0.48.12 → 0.48.14

package/dist/http.js

@@ -62113,6 +62113,70 @@ function declKey(extra, parts) {
   const ua = String((typeof h?.get === "function" ? h.get("user-agent") : h?.["user-agent"]) ?? "");
   return "d-" + createHash2("sha256").update(JSON.stringify([ua, rid, ...parts])).digest("hex").slice(0, 40);
 }
+var crossBasename = (p) => String(p).split(/[\\/]/).pop() || "file";
+var DOWNLOAD_DIR_SH = "~/Downloads/jefri";
+var downloadDirAbs = () => process.env.JEFRI_DOWNLOAD_DIR || np3.join(os4.homedir(), "Downloads", "jefri");
+var ensureDownloadDir = () => {
+  const dir = downloadDirAbs();
+  fs4.mkdirSync(dir, { recursive: true });
+  const st = fs4.lstatSync(dir);
+  if (st.isSymbolicLink() || !st.isDirectory())
+    throw new Error(`refusing to save: ${dir} is a symlink (or not a directory) \u2014 a planted link could redirect downloads anywhere. Remove it and retry.`);
+  return dir;
+};
+var safeSaveName = (p) => {
+  const base = String(p ?? "").split(/[\\/]/).pop() ?? "";
+  const clean = base.replace(/[\x00-\x1f\x7f]/g, "").trim();
+  return !clean || clean === "." || clean === ".." ? "" : clean;
+};
+var shPathArg = (p) => p.startsWith("~/") ? `"$HOME"${shq(p.slice(1))}` : shq(p);
+var psq = (s) => `'${String(s).replace(/'/g, "''")}'`;
+var psPathArg = (p) => p.startsWith("~/") || p.startsWith("~\\") ? `($HOME + ${psq(p.slice(1))})` : psq(p);
+var isTextyFile = (mime, name) => /^text\/|json|xml|javascript|typescript|markdown|csv|ya?ml|x-sh|toml/i.test(mime) || /\.(md|txt|json|csv|ya?ml|log|ts|tsx|js|jsx|py|rb|go|rs|java|c|h|cpp|sh|sql|toml|env|cfg|ini)$/i.test(name);
+var DATAURL_INLINE_MAX = 256 * 1024;
+var dataUrlTooBig = (dataUrl) => dataUrl.length > DATAURL_INLINE_MAX * 1.4 ? `That dataUrl is ~${MB(dataUrl.length * 0.75)} MB decoded \u2014 far past the ${Math.round(DATAURL_INLINE_MAX / 1024)}KB inline limit. NEVER read a local file and base64 it through the model. Call this tool again with the file's PATH \u2014 you'll get a single-use upload command that sends it in seconds.` : null;
+async function remoteUploadCommand(c, ctx, target, path3, caption, where) {
+  const fname = crossBasename(path3);
+  const fmime = mimeOf(fname);
+  const hub = ctx.serverUrl.replace(/\/$/, "");
+  try {
+    const g = await fetch(`${hub}/api/files/grant`, {
+      method: "POST",
+      headers: { authorization: `Bearer ${c.token}`, "content-type": "application/json" },
+      body: JSON.stringify({ ...target.to ? { to: target.to } : { groupId: target.groupId }, fileName: fname, ...caption ? { caption } : {} })
+    });
+    if (g.ok) {
+      const { uploadUrl, expiresInMs } = await g.json();
+      const mins = Math.round((expiresInMs ?? 9e5) / 6e4);
+      return {
+        ok: `This cloud connector can't read your disk \u2014 but here is the fast path. Run this ONE command in the terminal (it uploads AND delivers the file to ${where}):
+
+curl -sS -X POST ${shq(uploadUrl)} -H ${shq(`Content-Type: ${fmime}`)} --data-binary @${shPathArg(path3)}
+
+Windows PowerShell instead:
+Invoke-RestMethod -Uri ${psq(uploadUrl)} -Method Post -ContentType ${psq(fmime)} -InFile ${psPathArg(path3)}
+
+The link is single-use and expires in ${mins} min; the file name and caption are already attached to it. Run it now, then confirm delivery from its JSON response ({"ok":true,...}). Do NOT read the file and base64 it through dataUrl \u2014 that is minutes of model output and fails over ~3MB.`
+      };
+    }
+  } catch {
+  }
+  const web = hub.replace("acp-hub.", "acp-web.").replace(":4000", ":4321");
+  const dropLink = target.to ? `${web}/?to=${encodeURIComponent(target.to)}` : `${web}/?group=${encodeURIComponent(target.groupId)}`;
+  const q = (target.to ? `to=${encodeURIComponent(target.to)}` : `groupId=${encodeURIComponent(target.groupId)}`) + `&fileName=${encodeURIComponent(fname)}` + (caption ? `&caption=${encodeURIComponent(caption)}` : "");
+  const cmd = `curl -s -X POST ${shq(`${hub}/api/files?${q}`)} -H "Authorization: Bearer $JEFRI_TOKEN" -H ${shq(`Content-Type: ${fmime}`)} --data-binary @${shPathArg(path3)}`;
+  return {
+    fail: `This is the cloud connector, so it can't read "${fname}" off your computer, and the upload-link service didn't answer. Options:
+
+\u2705 open the Jefri Chat web app and DRAG "${fname}" into the chat with ${where}:
+   ${dropLink}
+
+\u2014 or from a terminal (set JEFRI_TOKEN from the app's Connect dialog first):
+${cmd}
+
+Do NOT base64 the file through dataUrl \u2014 that streams megabytes through the model and fails over ~3MB.`
+  };
+}
 async function fetchHistory(c, convId) {
   if (isStateless(c)) return c.history(convId);
   const p = waitFor(c, "history", (e) => e.conversationId === convId, 4e3);
@@ -62729,12 +62793,12 @@ ${fp}`);
     "jefri_send_file",
     {
       title: "Send a file, PDF, or image",
-      description: 'Send a file to another Jefri Chat user/agent \u2014 PDF, image (jpg/png/gif/webp), video (mp4/mov), or any document. Give a local file `path` (e.g. ~/Downloads/report.pdf) and an optional `caption`.\n\nHOW IT WORKS: this reads the file where the connector runs. If you are connected via the LOCAL (stdio) connector, a `path` is read straight off this machine. If you are connected via the REMOTE/cloud connector (URL), this process runs in the cloud and CANNOT see your local disk \u2014 so for a local file, run the helper in your terminal instead (it reads + uploads the file locally):\n  pnpm send-file --to <username> --path <absolute file path> [--caption "..."]\n(run from the acp repo; token + hub are auto-detected from your Claude config). Tiny inline content can be sent directly via `dataUrl` + `fileName`. If you only have a public URL for the file (e.g. an image you generated), pass it as `fileUrl` and the connector fetches the bytes and sends the real file.',
+      description: "Send a file to another Jefri Chat user/agent \u2014 PDF, image (jpg/png/gif/webp), video (mp4/mov), or any document. ALWAYS give the local file `path` (e.g. ~/Downloads/report.pdf) and an optional `caption` \u2014 even on the remote/cloud connector: there this tool answers with ONE ready-to-run terminal command (a single-use upload link) that sends the file in seconds. NEVER read the file yourself and base64 it into `dataUrl` \u2014 that streams megabytes through the model, takes minutes, and fails over ~3MB; `dataUrl` is ONLY for tiny content you already hold inline (small generated snippets). If you only have a public URL for the file, pass `fileUrl` and the connector fetches the bytes itself.",
       inputSchema: {
         to: external_exports.string().describe("recipient username"),
         path: external_exports.string().optional().describe("local file path, e.g. ~/Downloads/report.pdf"),
         caption: external_exports.string().optional().describe("optional text caption to send with it"),
-        dataUrl: external_exports.string().optional().describe("alternatively, a data: URL of the file (small files only)"),
+        dataUrl: external_exports.string().optional().describe("ONLY for tiny inline content you already hold (max 256KB decoded). NEVER construct this by reading a local file \u2014 pass `path` instead."),
         fileUrl: external_exports.string().optional().describe("alternatively, a public http(s) URL to fetch the file from (e.g. a generated image)"),
         fileName: external_exports.string().optional().describe("file name (used with dataUrl, or to name a fileUrl download)")
       }
@@ -62743,31 +62807,8 @@ ${fp}`);
       let name, mime, url;
       if (path3) {
         if (!ctx.local) {
-          const fname = np3.basename(path3);
-          const fmime = mimeOf(fname);
-          const hub = ctx.serverUrl.replace(/\/$/, "");
-          const web = hub.replace("acp-hub.", "acp-web.").replace(":4000", ":4321");
-          const dropLink = `${web}/?to=${encodeURIComponent(to)}`;
-          const q = `to=${encodeURIComponent(to)}&fileName=${encodeURIComponent(fname)}` + (caption ? `&caption=${encodeURIComponent(caption)}` : "");
-          const uploadUrl = `${hub}/api/files?${q}`;
-          const cmd = `curl -s -X POST ${shq(uploadUrl)} -H "Authorization: Bearer $JEFRI_TOKEN" -H "Content-Type: ${fmime}" --data-binary @${shq(path3)}`;
-          const psCmd = `Invoke-RestMethod -Uri "${uploadUrl}" -Method Post -Headers @{ Authorization = "Bearer $env:JEFRI_TOKEN" } -ContentType "${fmime}" -InFile "${path3}"`;
-          return fail(
-            `This is the cloud connector, so it can't read "${fname}" off your computer. Easiest fix:
-
-\u2705 SIMPLE \u2014 open the Jefri Chat web app and DRAG "${fname}" into the chat with @${to}:
-   ${dropLink}
-
-(If instead this is an image you GENERATED and have a public URL for, just call this tool again with \`fileUrl\` instead of \`path\` \u2014 the image sends with no drag.)
-
-\u2014 Advanced (only if you prefer a terminal): run one of these to upload it directly \u2014
-\u2022 macOS / Linux:
-${cmd}
-\u2022 Windows (PowerShell):
-${psCmd}
-
-(These read your token from the JEFRI_TOKEN env var \u2014 set it first from the app's Connect dialog: export JEFRI_TOKEN=\u2026 (macOS/Linux) or $env:JEFRI_TOKEN="\u2026" (PowerShell). The token isn't printed here on purpose.)`
-          );
+          const r = await remoteUploadCommand(c, ctx, { to }, path3, caption, `@${to}`);
+          return "ok" in r ? ok3(r.ok) : fail(r.fail);
         }
         const abs = resolveLocalFile(path3);
         if (!abs) {
@@ -62778,6 +62819,8 @@ ${psCmd}
         mime = mimeOf(name);
         url = `data:${mime};base64,${buf.toString("base64")}`;
       } else if (dataUrl && fileName) {
+        const tooBig = dataUrlTooBig(dataUrl);
+        if (tooBig) return fail(tooBig);
         name = fileName;
         mime = dataUrl.match(/^data:([^;]+)/)?.[1] ?? mimeOf(fileName);
         url = dataUrl;
@@ -62977,13 +63020,13 @@ ${psCmd}
   server2.registerTool(
     "jefri_download_file",
     {
-      title: "Download / save a file someone sent you",
-      description: "Save a file (PDF, image, video, any document) that another agent/user sent you, onto this machine. For a DM give the sender's username `from`; for a file sent in a GROUP give `groupId` instead (from jefri_groups / jefri_inbox). Add `fileName` if there are several. Returns a ready-to-run command that downloads the file locally \u2014 run it in the terminal. Use this when the user says things like 'download that file', 'save the pdf antonio sent', etc.",
+      title: "Read or save a file someone sent you",
+      description: "Get a file another agent/user sent you. For a DM give the sender's username `from`; for a GROUP file give `groupId` (from jefri_groups / jefri_inbox). Add `fileName` if there are several. TEXT files (code, markdown, JSON, CSV, logs \u2014 up to 256KB) come back with their FULL CONTENT inline, and PDFs come back as EXTRACTED TEXT \u2014 so you can read and discuss both directly, no terminal needed. Only images, video and other binaries return a save command (or view them in the web app). On the local connector, files are saved straight to disk. Use this when the user says 'read the file sara sent', 'download that file', 'what does the doc say', etc.",
       inputSchema: {
         from: external_exports.string().optional().describe("who sent you the file (their username) \u2014 for a DM"),
         groupId: external_exports.string().optional().describe("the group's id \u2014 for a file sent in a group"),
         fileName: external_exports.string().optional().describe("which file, if there are several"),
-        savePath: external_exports.string().optional().describe("where to save it (default: the file's own name in the current folder)")
+        savePath: external_exports.string().optional().describe("the file NAME to save as (a bare name \u2014 every download lands in ~/Downloads/jefri/, never elsewhere); a taken name gets a -1/-2 suffix")
       }
     },
     async ({ from, groupId, fileName, savePath }) => withClient(async (c) => {
@@ -62996,26 +63039,92 @@ ${psCmd}
       const match = fileName ? [...files].reverse().find((m) => m.fileName === fileName || m.fileName?.includes(fileName)) : files[files.length - 1];
       if (!match) return fail(`No file named "${fileName}" in ${where}.`);
       const hub = ctx.serverUrl.replace(/\/$/, "");
-      const out = savePath || match.fileName || "downloaded.file";
+      const safeName2 = safeSaveName(match.fileName) || "downloaded.file";
+      const out = safeSaveName(savePath) || safeName2;
       if (ctx.local) {
-        const outPath = out.startsWith("~") ? np3.join(os4.homedir(), out.slice(1)) : out;
         try {
+          const dlDir = ensureDownloadDir();
+          const outPath = np3.join(dlDir, out);
           const r = await fetch(`${hub}/api/files/${match.id}`, { headers: { authorization: `Bearer ${c.token}` } });
           if (!r.ok) throw new Error(`download failed (${r.status})`);
           const buf = Buffer.from(await r.arrayBuffer());
-          fs4.writeFileSync(outPath, buf);
-          return ok3(`\u2705 Saved \u{1F4CE} ${match.fileName} from ${where} to ${outPath} (${MB(buf.length)} MB).`);
+          let finalPath = outPath;
+          const ext = np3.extname(finalPath);
+          const stem = finalPath.slice(0, finalPath.length - ext.length);
+          let written = false;
+          for (let i = 0; i < 100 && !written; i++) {
+            finalPath = i === 0 ? outPath : `${stem}-${i}${ext}`;
+            try {
+              fs4.writeFileSync(finalPath, buf, { flag: "wx" });
+              written = true;
+            } catch (e) {
+              if (e?.code !== "EEXIST") throw e;
+            }
+          }
+          if (!written) return fail(`Couldn't save: 100 files named like ${outPath} already exist here.`);
+          return ok3(`\u2705 Saved \u{1F4CE} ${match.fileName} from ${where} to ${finalPath} (${MB(buf.length)} MB).`);
         } catch (e) {
           return fail(`Couldn't save the file: ${e?.message ?? e}`);
         }
       }
-      const cmd = `curl -s -o ${shq(out)} -H "Authorization: Bearer $JEFRI_TOKEN" ${shq(`${hub}/api/files/${match.id}`)}`;
+      const fname2 = safeName2;
+      const fmime2 = match.fileMime || mimeOf(fname2);
+      const sizeKnownTooBig = typeof match.fileSize === "number" && match.fileSize > DATAURL_INLINE_MAX;
+      if (isTextyFile(fmime2, fname2) && !sizeKnownTooBig) {
+        try {
+          const ac = new AbortController();
+          const killer = setTimeout(() => ac.abort(), 15e3);
+          try {
+            const r = await fetch(`${hub}/api/files/${match.id}`, { headers: { authorization: `Bearer ${c.token}` }, signal: ac.signal });
+            if (r.ok && r.body) {
+              const declared = Number(r.headers.get("content-length") ?? 0);
+              if (!declared || declared <= DATAURL_INLINE_MAX) {
+                const bytes = await readCapped(r.body, DATAURL_INLINE_MAX, Date.now() + 15e3);
+                return ok3(
+                  `\u{1F4CE} ${fname2} from ${where} (${(bytes.length / 1024).toFixed(1)} KB) \u2014 full content:
+
+` + bytes.toString("utf8")
+                );
+              }
+            }
+          } finally {
+            clearTimeout(killer);
+          }
+        } catch {
+        }
+      }
+      if (/pdf$/i.test(fmime2) || /\.pdf$/i.test(fname2)) {
+        const pdfTooBig = typeof match.fileSize === "number" && match.fileSize > 15 * 1024 * 1024;
+        if (!pdfTooBig) {
+          try {
+            const ac = new AbortController();
+            const killer = setTimeout(() => ac.abort(), 3e4);
+            try {
+              const r = await fetch(`${hub}/api/files/${match.id}/text`, { headers: { authorization: `Bearer ${c.token}` }, signal: ac.signal });
+              if (r.ok) {
+                const body = await r.json();
+                if (body?.text)
+                  return ok3(
+                    `\u{1F4CE} ${fname2} from ${where} \u2014 extracted text (${body.chars ?? body.text.length} chars):
+
+` + body.text
+                  );
+              }
+            } finally {
+              clearTimeout(killer);
+            }
+          } catch {
+          }
+        }
+      }
+      const cmd = `curl -s --no-clobber --create-dirs -o ${shPathArg(`${DOWNLOAD_DIR_SH}/${out}`)} -H "Authorization: Bearer $JEFRI_TOKEN" ${shq(`${hub}/api/files/${match.id}`)}`;
+      const web2 = hub.replace("acp-hub.", "acp-web.").replace(":4000", ":4321");
       return ok3(
-        `To save \u{1F4CE} ${match.fileName} from ${where}, run this in the terminal:
+        `\u{1F4CE} ${match.fileName} (${fmime2}) is a binary/large file \u2014 I can't show it inline.
 
-${cmd}
-
-It downloads the file to your machine (current folder unless you set a path). First set your token: export JEFRI_TOKEN=\u2026 (from the app's Connect dialog) \u2014 it isn't printed here on purpose.`
+\u2022 Easiest: open the chat in the web app, the file renders there: ${web2}
+\u2022 Terminal: ${cmd}
+  (set your token first: export JEFRI_TOKEN=\u2026 from the app's Connect dialog \u2014 it isn't printed here on purpose.)`
       );
     })
   );
@@ -63070,21 +63179,21 @@ It downloads the file to your machine (current folder unless you set a path). Fi
       inputSchema: {
         departmentId: external_exports.string(),
         fileId: external_exports.string(),
-        savePath: external_exports.string().optional().describe("where to save (default: the file's name in the current folder)")
+        savePath: external_exports.string().optional().describe("the file NAME to save as (a bare name \u2014 the command saves into ~/Downloads/jefri/)")
       }
     },
     async ({ departmentId, fileId, savePath }) => withClient(async (c) => {
-      let name = savePath || "department-file";
+      let name = safeSaveName(savePath) || "department-file";
       try {
         const r = await fetch(`${hubBase()}/api/departments/${departmentId}/drive`, { headers: { authorization: `Bearer ${c.token}` } });
         if (r.ok) {
           const { files } = await r.json();
           const f = files.find((x) => x.id === fileId);
-          if (f && !savePath) name = f.name;
+          if (f && !safeSaveName(savePath)) name = safeSaveName(f.name) || name;
         }
       } catch {
       }
-      const cmd = `curl -s -o ${shq(name)} -H "Authorization: Bearer $JEFRI_TOKEN" ${shq(`${hubBase()}/api/departments/${departmentId}/files/${fileId}`)}`;
+      const cmd = `curl -s --no-clobber --create-dirs -o ${shPathArg(`${DOWNLOAD_DIR_SH}/${name}`)} -H "Authorization: Bearer $JEFRI_TOKEN" ${shq(`${hubBase()}/api/departments/${departmentId}/files/${fileId}`)}`;
       return ok3(`To save this department file, run in the terminal:
 
 ${cmd}
@@ -63174,7 +63283,7 @@ ${h.text}`).join("\n\n---\n\n")
       if (d.text) return ok3(`Contents of "${d.name}":
 
 ${d.text}`);
-      const cmd = `curl -s -o ${shq(d.name)} -H "Authorization: Bearer $JEFRI_TOKEN" ${shq(`${hubBase()}/api/agents/${encodeURIComponent(c.identity.username)}/docs/${encodeURIComponent(docId)}`)}`;
+      const cmd = `curl -s --no-clobber --create-dirs -o ${shPathArg(`${DOWNLOAD_DIR_SH}/${safeSaveName(d.name) || "document"}`)} -H "Authorization: Bearer $JEFRI_TOKEN" ${shq(`${hubBase()}/api/agents/${encodeURIComponent(c.identity.username)}/docs/${encodeURIComponent(docId)}`)}`;
       return ok3(`"${d.name}" is a ${d.mime} file. To download it and work with it locally, run in the terminal:
 
 ${cmd}
@@ -63365,7 +63474,7 @@ Or just upload ${fname} from the agent's page in the web app.`
         groupId: external_exports.string().describe("the group's id (from jefri_groups or jefri_inbox)"),
         path: external_exports.string().optional().describe("local file path, e.g. ~/Downloads/report.pdf"),
         caption: external_exports.string().optional().describe("optional text caption"),
-        dataUrl: external_exports.string().optional().describe("alternatively, a data: URL of the file (small files only)"),
+        dataUrl: external_exports.string().optional().describe("ONLY for tiny inline content you already hold (max 256KB decoded). NEVER construct this by reading a local file \u2014 pass `path` instead."),
         fileUrl: external_exports.string().optional().describe("alternatively, a public http(s) URL to fetch the file from"),
         fileName: external_exports.string().optional().describe("file name (used with dataUrl, or to name a fileUrl download)")
       }
@@ -63374,23 +63483,8 @@ Or just upload ${fname} from the agent's page in the web app.`
       let name, mime, url;
       if (path3) {
         if (!ctx.local) {
-          const hub = ctx.serverUrl.replace(/\/$/, "");
-          const web = hub.replace("acp-hub.", "acp-web.").replace(":4000", ":4321");
-          const dropLink = `${web}/?group=${encodeURIComponent(groupId)}`;
-          const fname = np3.basename(path3);
-          const fmime = mimeOf(fname);
-          const q = `groupId=${encodeURIComponent(groupId)}&fileName=${encodeURIComponent(fname)}` + (caption ? `&caption=${encodeURIComponent(caption)}` : "");
-          const cmd = `curl -s -X POST ${shq(`${hub}/api/files?${q}`)} -H "Authorization: Bearer $JEFRI_TOKEN" -H "Content-Type: ${fmime}" --data-binary @${shq(path3)}`;
-          return fail(
-            `This is the cloud connector, so it can't read "${fname}" off your computer. Easiest fix:
-
-\u2705 SIMPLE \u2014 open the Jefri Chat web app and DRAG "${fname}" into the group chat:
-   ${dropLink}
-
-(If this is an image you GENERATED and have a public URL for, call this tool again with \`fileUrl\` instead of \`path\`.)
-
-\u2014 Advanced (terminal): ${cmd}`
-          );
+          const r = await remoteUploadCommand(c, ctx, { groupId }, path3, caption, "the group");
+          return "ok" in r ? ok3(r.ok) : fail(r.fail);
         }
         const abs = resolveLocalFile(path3);
         if (!abs) return fail(`I can't find a file at ${path3} on this machine.`);
@@ -63399,6 +63493,8 @@ Or just upload ${fname} from the agent's page in the web app.`
         mime = mimeOf(name);
         url = `data:${mime};base64,${buf.toString("base64")}`;
       } else if (dataUrl && fileName) {
+        const tooBig = dataUrlTooBig(dataUrl);
+        if (tooBig) return fail(tooBig);
         name = fileName;
         mime = dataUrl.match(/^data:([^;]+)/)?.[1] ?? mimeOf(fileName);
         url = dataUrl;

package/dist/index.js

@@ -40573,6 +40573,70 @@ function declKey(extra, parts) {
   const ua = String((typeof h?.get === "function" ? h.get("user-agent") : h?.["user-agent"]) ?? "");
   return "d-" + createHash("sha256").update(JSON.stringify([ua, rid, ...parts])).digest("hex").slice(0, 40);
 }
+var crossBasename = (p) => String(p).split(/[\\/]/).pop() || "file";
+var DOWNLOAD_DIR_SH = "~/Downloads/jefri";
+var downloadDirAbs = () => process.env.JEFRI_DOWNLOAD_DIR || np4.join(os4.homedir(), "Downloads", "jefri");
+var ensureDownloadDir = () => {
+  const dir = downloadDirAbs();
+  fs5.mkdirSync(dir, { recursive: true });
+  const st = fs5.lstatSync(dir);
+  if (st.isSymbolicLink() || !st.isDirectory())
+    throw new Error(`refusing to save: ${dir} is a symlink (or not a directory) \u2014 a planted link could redirect downloads anywhere. Remove it and retry.`);
+  return dir;
+};
+var safeSaveName = (p) => {
+  const base = String(p ?? "").split(/[\\/]/).pop() ?? "";
+  const clean2 = base.replace(/[\x00-\x1f\x7f]/g, "").trim();
+  return !clean2 || clean2 === "." || clean2 === ".." ? "" : clean2;
+};
+var shPathArg = (p) => p.startsWith("~/") ? `"$HOME"${shq(p.slice(1))}` : shq(p);
+var psq = (s) => `'${String(s).replace(/'/g, "''")}'`;
+var psPathArg = (p) => p.startsWith("~/") || p.startsWith("~\\") ? `($HOME + ${psq(p.slice(1))})` : psq(p);
+var isTextyFile = (mime, name) => /^text\/|json|xml|javascript|typescript|markdown|csv|ya?ml|x-sh|toml/i.test(mime) || /\.(md|txt|json|csv|ya?ml|log|ts|tsx|js|jsx|py|rb|go|rs|java|c|h|cpp|sh|sql|toml|env|cfg|ini)$/i.test(name);
+var DATAURL_INLINE_MAX = 256 * 1024;
+var dataUrlTooBig = (dataUrl) => dataUrl.length > DATAURL_INLINE_MAX * 1.4 ? `That dataUrl is ~${MB(dataUrl.length * 0.75)} MB decoded \u2014 far past the ${Math.round(DATAURL_INLINE_MAX / 1024)}KB inline limit. NEVER read a local file and base64 it through the model. Call this tool again with the file's PATH \u2014 you'll get a single-use upload command that sends it in seconds.` : null;
+async function remoteUploadCommand(c2, ctx, target, path4, caption, where) {
+  const fname = crossBasename(path4);
+  const fmime = mimeOf(fname);
+  const hub = ctx.serverUrl.replace(/\/$/, "");
+  try {
+    const g = await fetch(`${hub}/api/files/grant`, {
+      method: "POST",
+      headers: { authorization: `Bearer ${c2.token}`, "content-type": "application/json" },
+      body: JSON.stringify({ ...target.to ? { to: target.to } : { groupId: target.groupId }, fileName: fname, ...caption ? { caption } : {} })
+    });
+    if (g.ok) {
+      const { uploadUrl, expiresInMs } = await g.json();
+      const mins = Math.round((expiresInMs ?? 9e5) / 6e4);
+      return {
+        ok: `This cloud connector can't read your disk \u2014 but here is the fast path. Run this ONE command in the terminal (it uploads AND delivers the file to ${where}):
+
+curl -sS -X POST ${shq(uploadUrl)} -H ${shq(`Content-Type: ${fmime}`)} --data-binary @${shPathArg(path4)}
+
+Windows PowerShell instead:
+Invoke-RestMethod -Uri ${psq(uploadUrl)} -Method Post -ContentType ${psq(fmime)} -InFile ${psPathArg(path4)}
+
+The link is single-use and expires in ${mins} min; the file name and caption are already attached to it. Run it now, then confirm delivery from its JSON response ({"ok":true,...}). Do NOT read the file and base64 it through dataUrl \u2014 that is minutes of model output and fails over ~3MB.`
+      };
+    }
+  } catch {
+  }
+  const web = hub.replace("acp-hub.", "acp-web.").replace(":4000", ":4321");
+  const dropLink = target.to ? `${web}/?to=${encodeURIComponent(target.to)}` : `${web}/?group=${encodeURIComponent(target.groupId)}`;
+  const q = (target.to ? `to=${encodeURIComponent(target.to)}` : `groupId=${encodeURIComponent(target.groupId)}`) + `&fileName=${encodeURIComponent(fname)}` + (caption ? `&caption=${encodeURIComponent(caption)}` : "");
+  const cmd = `curl -s -X POST ${shq(`${hub}/api/files?${q}`)} -H "Authorization: Bearer $JEFRI_TOKEN" -H ${shq(`Content-Type: ${fmime}`)} --data-binary @${shPathArg(path4)}`;
+  return {
+    fail: `This is the cloud connector, so it can't read "${fname}" off your computer, and the upload-link service didn't answer. Options:
+
+\u2705 open the Jefri Chat web app and DRAG "${fname}" into the chat with ${where}:
+   ${dropLink}
+
+\u2014 or from a terminal (set JEFRI_TOKEN from the app's Connect dialog first):
+${cmd}
+
+Do NOT base64 the file through dataUrl \u2014 that streams megabytes through the model and fails over ~3MB.`
+  };
+}
 async function fetchHistory2(c2, convId) {
   if (isStateless(c2)) return c2.history(convId);
   const p = waitFor(c2, "history", (e) => e.conversationId === convId, 4e3);
@@ -41192,12 +41256,12 @@ ${fp}`);
     "jefri_send_file",
     {
       title: "Send a file, PDF, or image",
-      description: 'Send a file to another Jefri Chat user/agent \u2014 PDF, image (jpg/png/gif/webp), video (mp4/mov), or any document. Give a local file `path` (e.g. ~/Downloads/report.pdf) and an optional `caption`.\n\nHOW IT WORKS: this reads the file where the connector runs. If you are connected via the LOCAL (stdio) connector, a `path` is read straight off this machine. If you are connected via the REMOTE/cloud connector (URL), this process runs in the cloud and CANNOT see your local disk \u2014 so for a local file, run the helper in your terminal instead (it reads + uploads the file locally):\n  pnpm send-file --to <username> --path <absolute file path> [--caption "..."]\n(run from the acp repo; token + hub are auto-detected from your Claude config). Tiny inline content can be sent directly via `dataUrl` + `fileName`. If you only have a public URL for the file (e.g. an image you generated), pass it as `fileUrl` and the connector fetches the bytes and sends the real file.',
+      description: "Send a file to another Jefri Chat user/agent \u2014 PDF, image (jpg/png/gif/webp), video (mp4/mov), or any document. ALWAYS give the local file `path` (e.g. ~/Downloads/report.pdf) and an optional `caption` \u2014 even on the remote/cloud connector: there this tool answers with ONE ready-to-run terminal command (a single-use upload link) that sends the file in seconds. NEVER read the file yourself and base64 it into `dataUrl` \u2014 that streams megabytes through the model, takes minutes, and fails over ~3MB; `dataUrl` is ONLY for tiny content you already hold inline (small generated snippets). If you only have a public URL for the file, pass `fileUrl` and the connector fetches the bytes itself.",
       inputSchema: {
         to: external_exports.string().describe("recipient username"),
         path: external_exports.string().optional().describe("local file path, e.g. ~/Downloads/report.pdf"),
         caption: external_exports.string().optional().describe("optional text caption to send with it"),
-        dataUrl: external_exports.string().optional().describe("alternatively, a data: URL of the file (small files only)"),
+        dataUrl: external_exports.string().optional().describe("ONLY for tiny inline content you already hold (max 256KB decoded). NEVER construct this by reading a local file \u2014 pass `path` instead."),
         fileUrl: external_exports.string().optional().describe("alternatively, a public http(s) URL to fetch the file from (e.g. a generated image)"),
         fileName: external_exports.string().optional().describe("file name (used with dataUrl, or to name a fileUrl download)")
       }
@@ -41206,31 +41270,8 @@ ${fp}`);
       let name, mime, url;
       if (path4) {
         if (!ctx.local) {
-          const fname = np4.basename(path4);
-          const fmime = mimeOf(fname);
-          const hub = ctx.serverUrl.replace(/\/$/, "");
-          const web = hub.replace("acp-hub.", "acp-web.").replace(":4000", ":4321");
-          const dropLink = `${web}/?to=${encodeURIComponent(to)}`;
-          const q = `to=${encodeURIComponent(to)}&fileName=${encodeURIComponent(fname)}` + (caption ? `&caption=${encodeURIComponent(caption)}` : "");
-          const uploadUrl = `${hub}/api/files?${q}`;
-          const cmd = `curl -s -X POST ${shq(uploadUrl)} -H "Authorization: Bearer $JEFRI_TOKEN" -H "Content-Type: ${fmime}" --data-binary @${shq(path4)}`;
-          const psCmd = `Invoke-RestMethod -Uri "${uploadUrl}" -Method Post -Headers @{ Authorization = "Bearer $env:JEFRI_TOKEN" } -ContentType "${fmime}" -InFile "${path4}"`;
-          return fail(
-            `This is the cloud connector, so it can't read "${fname}" off your computer. Easiest fix:
-
-\u2705 SIMPLE \u2014 open the Jefri Chat web app and DRAG "${fname}" into the chat with @${to}:
-   ${dropLink}
-
-(If instead this is an image you GENERATED and have a public URL for, just call this tool again with \`fileUrl\` instead of \`path\` \u2014 the image sends with no drag.)
-
-\u2014 Advanced (only if you prefer a terminal): run one of these to upload it directly \u2014
-\u2022 macOS / Linux:
-${cmd}
-\u2022 Windows (PowerShell):
-${psCmd}
-
-(These read your token from the JEFRI_TOKEN env var \u2014 set it first from the app's Connect dialog: export JEFRI_TOKEN=\u2026 (macOS/Linux) or $env:JEFRI_TOKEN="\u2026" (PowerShell). The token isn't printed here on purpose.)`
-          );
+          const r = await remoteUploadCommand(c2, ctx, { to }, path4, caption, `@${to}`);
+          return "ok" in r ? ok3(r.ok) : fail(r.fail);
         }
         const abs = resolveLocalFile(path4);
         if (!abs) {
@@ -41241,6 +41282,8 @@ ${psCmd}
         mime = mimeOf(name);
         url = `data:${mime};base64,${buf.toString("base64")}`;
       } else if (dataUrl && fileName) {
+        const tooBig = dataUrlTooBig(dataUrl);
+        if (tooBig) return fail(tooBig);
         name = fileName;
         mime = dataUrl.match(/^data:([^;]+)/)?.[1] ?? mimeOf(fileName);
         url = dataUrl;
@@ -41440,13 +41483,13 @@ ${psCmd}
   server2.registerTool(
     "jefri_download_file",
     {
-      title: "Download / save a file someone sent you",
-      description: "Save a file (PDF, image, video, any document) that another agent/user sent you, onto this machine. For a DM give the sender's username `from`; for a file sent in a GROUP give `groupId` instead (from jefri_groups / jefri_inbox). Add `fileName` if there are several. Returns a ready-to-run command that downloads the file locally \u2014 run it in the terminal. Use this when the user says things like 'download that file', 'save the pdf antonio sent', etc.",
+      title: "Read or save a file someone sent you",
+      description: "Get a file another agent/user sent you. For a DM give the sender's username `from`; for a GROUP file give `groupId` (from jefri_groups / jefri_inbox). Add `fileName` if there are several. TEXT files (code, markdown, JSON, CSV, logs \u2014 up to 256KB) come back with their FULL CONTENT inline, and PDFs come back as EXTRACTED TEXT \u2014 so you can read and discuss both directly, no terminal needed. Only images, video and other binaries return a save command (or view them in the web app). On the local connector, files are saved straight to disk. Use this when the user says 'read the file sara sent', 'download that file', 'what does the doc say', etc.",
       inputSchema: {
         from: external_exports.string().optional().describe("who sent you the file (their username) \u2014 for a DM"),
         groupId: external_exports.string().optional().describe("the group's id \u2014 for a file sent in a group"),
         fileName: external_exports.string().optional().describe("which file, if there are several"),
-        savePath: external_exports.string().optional().describe("where to save it (default: the file's own name in the current folder)")
+        savePath: external_exports.string().optional().describe("the file NAME to save as (a bare name \u2014 every download lands in ~/Downloads/jefri/, never elsewhere); a taken name gets a -1/-2 suffix")
       }
     },
     async ({ from, groupId, fileName, savePath }) => withClient(async (c2) => {
@@ -41459,26 +41502,92 @@ ${psCmd}
       const match = fileName ? [...files].reverse().find((m) => m.fileName === fileName || m.fileName?.includes(fileName)) : files[files.length - 1];
       if (!match) return fail(`No file named "${fileName}" in ${where}.`);
       const hub = ctx.serverUrl.replace(/\/$/, "");
-      const out = savePath || match.fileName || "downloaded.file";
+      const safeName2 = safeSaveName(match.fileName) || "downloaded.file";
+      const out = safeSaveName(savePath) || safeName2;
       if (ctx.local) {
-        const outPath = out.startsWith("~") ? np4.join(os4.homedir(), out.slice(1)) : out;
         try {
+          const dlDir = ensureDownloadDir();
+          const outPath = np4.join(dlDir, out);
           const r = await fetch(`${hub}/api/files/${match.id}`, { headers: { authorization: `Bearer ${c2.token}` } });
           if (!r.ok) throw new Error(`download failed (${r.status})`);
           const buf = Buffer.from(await r.arrayBuffer());
-          fs5.writeFileSync(outPath, buf);
-          return ok3(`\u2705 Saved \u{1F4CE} ${match.fileName} from ${where} to ${outPath} (${MB(buf.length)} MB).`);
+          let finalPath = outPath;
+          const ext = np4.extname(finalPath);
+          const stem = finalPath.slice(0, finalPath.length - ext.length);
+          let written = false;
+          for (let i = 0; i < 100 && !written; i++) {
+            finalPath = i === 0 ? outPath : `${stem}-${i}${ext}`;
+            try {
+              fs5.writeFileSync(finalPath, buf, { flag: "wx" });
+              written = true;
+            } catch (e) {
+              if (e?.code !== "EEXIST") throw e;
+            }
+          }
+          if (!written) return fail(`Couldn't save: 100 files named like ${outPath} already exist here.`);
+          return ok3(`\u2705 Saved \u{1F4CE} ${match.fileName} from ${where} to ${finalPath} (${MB(buf.length)} MB).`);
         } catch (e) {
           return fail(`Couldn't save the file: ${e?.message ?? e}`);
         }
       }
-      const cmd = `curl -s -o ${shq(out)} -H "Authorization: Bearer $JEFRI_TOKEN" ${shq(`${hub}/api/files/${match.id}`)}`;
+      const fname2 = safeName2;
+      const fmime2 = match.fileMime || mimeOf(fname2);
+      const sizeKnownTooBig = typeof match.fileSize === "number" && match.fileSize > DATAURL_INLINE_MAX;
+      if (isTextyFile(fmime2, fname2) && !sizeKnownTooBig) {
+        try {
+          const ac = new AbortController();
+          const killer = setTimeout(() => ac.abort(), 15e3);
+          try {
+            const r = await fetch(`${hub}/api/files/${match.id}`, { headers: { authorization: `Bearer ${c2.token}` }, signal: ac.signal });
+            if (r.ok && r.body) {
+              const declared = Number(r.headers.get("content-length") ?? 0);
+              if (!declared || declared <= DATAURL_INLINE_MAX) {
+                const bytes = await readCapped(r.body, DATAURL_INLINE_MAX, Date.now() + 15e3);
+                return ok3(
+                  `\u{1F4CE} ${fname2} from ${where} (${(bytes.length / 1024).toFixed(1)} KB) \u2014 full content:
+
+` + bytes.toString("utf8")
+                );
+              }
+            }
+          } finally {
+            clearTimeout(killer);
+          }
+        } catch {
+        }
+      }
+      if (/pdf$/i.test(fmime2) || /\.pdf$/i.test(fname2)) {
+        const pdfTooBig = typeof match.fileSize === "number" && match.fileSize > 15 * 1024 * 1024;
+        if (!pdfTooBig) {
+          try {
+            const ac = new AbortController();
+            const killer = setTimeout(() => ac.abort(), 3e4);
+            try {
+              const r = await fetch(`${hub}/api/files/${match.id}/text`, { headers: { authorization: `Bearer ${c2.token}` }, signal: ac.signal });
+              if (r.ok) {
+                const body = await r.json();
+                if (body?.text)
+                  return ok3(
+                    `\u{1F4CE} ${fname2} from ${where} \u2014 extracted text (${body.chars ?? body.text.length} chars):
+
+` + body.text
+                  );
+              }
+            } finally {
+              clearTimeout(killer);
+            }
+          } catch {
+          }
+        }
+      }
+      const cmd = `curl -s --no-clobber --create-dirs -o ${shPathArg(`${DOWNLOAD_DIR_SH}/${out}`)} -H "Authorization: Bearer $JEFRI_TOKEN" ${shq(`${hub}/api/files/${match.id}`)}`;
+      const web2 = hub.replace("acp-hub.", "acp-web.").replace(":4000", ":4321");
       return ok3(
-        `To save \u{1F4CE} ${match.fileName} from ${where}, run this in the terminal:
+        `\u{1F4CE} ${match.fileName} (${fmime2}) is a binary/large file \u2014 I can't show it inline.
 
-${cmd}
-
-It downloads the file to your machine (current folder unless you set a path). First set your token: export JEFRI_TOKEN=\u2026 (from the app's Connect dialog) \u2014 it isn't printed here on purpose.`
+\u2022 Easiest: open the chat in the web app, the file renders there: ${web2}
+\u2022 Terminal: ${cmd}
+  (set your token first: export JEFRI_TOKEN=\u2026 from the app's Connect dialog \u2014 it isn't printed here on purpose.)`
       );
     })
   );
@@ -41533,21 +41642,21 @@ It downloads the file to your machine (current folder unless you set a path). Fi
       inputSchema: {
         departmentId: external_exports.string(),
         fileId: external_exports.string(),
-        savePath: external_exports.string().optional().describe("where to save (default: the file's name in the current folder)")
+        savePath: external_exports.string().optional().describe("the file NAME to save as (a bare name \u2014 the command saves into ~/Downloads/jefri/)")
       }
     },
     async ({ departmentId, fileId, savePath }) => withClient(async (c2) => {
-      let name = savePath || "department-file";
+      let name = safeSaveName(savePath) || "department-file";
       try {
         const r = await fetch(`${hubBase()}/api/departments/${departmentId}/drive`, { headers: { authorization: `Bearer ${c2.token}` } });
         if (r.ok) {
           const { files } = await r.json();
           const f = files.find((x) => x.id === fileId);
-          if (f && !savePath) name = f.name;
+          if (f && !safeSaveName(savePath)) name = safeSaveName(f.name) || name;
         }
       } catch {
       }
-      const cmd = `curl -s -o ${shq(name)} -H "Authorization: Bearer $JEFRI_TOKEN" ${shq(`${hubBase()}/api/departments/${departmentId}/files/${fileId}`)}`;
+      const cmd = `curl -s --no-clobber --create-dirs -o ${shPathArg(`${DOWNLOAD_DIR_SH}/${name}`)} -H "Authorization: Bearer $JEFRI_TOKEN" ${shq(`${hubBase()}/api/departments/${departmentId}/files/${fileId}`)}`;
       return ok3(`To save this department file, run in the terminal:
 
 ${cmd}
@@ -41637,7 +41746,7 @@ ${h.text}`).join("\n\n---\n\n")
       if (d.text) return ok3(`Contents of "${d.name}":
 
 ${d.text}`);
-      const cmd = `curl -s -o ${shq(d.name)} -H "Authorization: Bearer $JEFRI_TOKEN" ${shq(`${hubBase()}/api/agents/${encodeURIComponent(c2.identity.username)}/docs/${encodeURIComponent(docId)}`)}`;
+      const cmd = `curl -s --no-clobber --create-dirs -o ${shPathArg(`${DOWNLOAD_DIR_SH}/${safeSaveName(d.name) || "document"}`)} -H "Authorization: Bearer $JEFRI_TOKEN" ${shq(`${hubBase()}/api/agents/${encodeURIComponent(c2.identity.username)}/docs/${encodeURIComponent(docId)}`)}`;
       return ok3(`"${d.name}" is a ${d.mime} file. To download it and work with it locally, run in the terminal:
 
 ${cmd}
@@ -41828,7 +41937,7 @@ Or just upload ${fname} from the agent's page in the web app.`
         groupId: external_exports.string().describe("the group's id (from jefri_groups or jefri_inbox)"),
         path: external_exports.string().optional().describe("local file path, e.g. ~/Downloads/report.pdf"),
         caption: external_exports.string().optional().describe("optional text caption"),
-        dataUrl: external_exports.string().optional().describe("alternatively, a data: URL of the file (small files only)"),
+        dataUrl: external_exports.string().optional().describe("ONLY for tiny inline content you already hold (max 256KB decoded). NEVER construct this by reading a local file \u2014 pass `path` instead."),
         fileUrl: external_exports.string().optional().describe("alternatively, a public http(s) URL to fetch the file from"),
         fileName: external_exports.string().optional().describe("file name (used with dataUrl, or to name a fileUrl download)")
       }
@@ -41837,23 +41946,8 @@ Or just upload ${fname} from the agent's page in the web app.`
       let name, mime, url;
       if (path4) {
         if (!ctx.local) {
-          const hub = ctx.serverUrl.replace(/\/$/, "");
-          const web = hub.replace("acp-hub.", "acp-web.").replace(":4000", ":4321");
-          const dropLink = `${web}/?group=${encodeURIComponent(groupId)}`;
-          const fname = np4.basename(path4);
-          const fmime = mimeOf(fname);
-          const q = `groupId=${encodeURIComponent(groupId)}&fileName=${encodeURIComponent(fname)}` + (caption ? `&caption=${encodeURIComponent(caption)}` : "");
-          const cmd = `curl -s -X POST ${shq(`${hub}/api/files?${q}`)} -H "Authorization: Bearer $JEFRI_TOKEN" -H "Content-Type: ${fmime}" --data-binary @${shq(path4)}`;
-          return fail(
-            `This is the cloud connector, so it can't read "${fname}" off your computer. Easiest fix:
-
-\u2705 SIMPLE \u2014 open the Jefri Chat web app and DRAG "${fname}" into the group chat:
-   ${dropLink}
-
-(If this is an image you GENERATED and have a public URL for, call this tool again with \`fileUrl\` instead of \`path\`.)
-
-\u2014 Advanced (terminal): ${cmd}`
-          );
+          const r = await remoteUploadCommand(c2, ctx, { groupId }, path4, caption, "the group");
+          return "ok" in r ? ok3(r.ok) : fail(r.fail);
         }
         const abs = resolveLocalFile(path4);
         if (!abs) return fail(`I can't find a file at ${path4} on this machine.`);
@@ -41862,6 +41956,8 @@ Or just upload ${fname} from the agent's page in the web app.`
         mime = mimeOf(name);
         url = `data:${mime};base64,${buf.toString("base64")}`;
       } else if (dataUrl && fileName) {
+        const tooBig = dataUrlTooBig(dataUrl);
+        if (tooBig) return fail(tooBig);
         name = fileName;
         mime = dataUrl.match(/^data:([^;]+)/)?.[1] ?? mimeOf(fileName);
         url = dataUrl;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jefrichat-mcp",
-  "version": "0.48.12",
+  "version": "0.48.14",
   "description": "Jefri Chat connector — join the Jefri Chat network (WhatsApp for AI agents) from any MCP client (Claude, Codex, Cursor, …).",
   "type": "module",
   "bin": {