jbrowse-plugin-msaview 2.7.1 → 2.7.3

package/dist/AddHighlightModel/MsaToGenomeHighlight.js

@@ -11,11 +11,12 @@ const MsaToGenomeHighlight = observer(function MsaToGenomeHighlight2({ model, })
     // The persistent click selection always shows. The hover codon is suppressed
     // while hovering the LGV — GenomeMouseoverHighlight handles the single-bp
     // display in that case, so we don't stack a wider codon band on top of it.
-    const clickHighlight = msaView?.connectedClickHighlight;
-    const hoverHighlight = hasHoverPosition(hovered)
-        ? undefined
-        : msaView?.connectedHoverHighlight;
-    const highlights = [clickHighlight, hoverHighlight].filter((r) => r !== undefined);
+    const highlights = [
+        ...(msaView?.connectedClickHighlights ?? []),
+        ...(hasHoverPosition(hovered)
+            ? []
+            : (msaView?.connectedHoverHighlights ?? [])),
+    ];
     return highlights.length ? (React.createElement(MsaToGenomeHighlightRenderer, { model: model, highlights: highlights })) : null;
 });
 // Inner component: handles the scroll-dependent rendering

package/dist/LaunchMsaView/components/NCBIBlastQuery/CachedBlastResults.js

@@ -68,7 +68,7 @@ const CachedBlastResults = observer(function ({ model, handleClose, feature, })
                     catch (e) {
                         setOperationError(e);
                     }
-                } }, "Clear All")),
+                } }, "Clear results for this gene")),
         React.createElement(List, { dense: true, className: classes.resultList }, results.map(result => (React.createElement(ListItem, { key: result.id, disablePadding: true, secondaryAction: React.createElement(IconButton, { edge: "end", size: "small", onClick: async (e) => {
                     e.stopPropagation();
                     try {

package/dist/LaunchMsaView/components/NCBIBlastQuery/NCBIBlastPanel.js

@@ -1,5 +1,4 @@
 import React, { useState } from 'react';
-import { useLocalStorage } from '@jbrowse/core/util';
 import SettingsIcon from '@mui/icons-material/Settings';
 import { IconButton } from '@mui/material';
 import { makeStyles } from 'tss-react/mui';
@@ -9,6 +8,7 @@ import NCBIBlastMethodSelector from './NCBIBlastMethodSelector';
 import NCBIBlastRIDPanel from './NCBIBlastRIDPanel';
 import NCBISettingsDialog from './NCBISettingsDialog';
 import { BASE_BLAST_URL } from './consts';
+import { useLocalStorage } from '../../../utils/useLocalStorage';
 const useStyles = makeStyles()({
     settingsButton: {
         float: 'right',

package/dist/LaunchMsaView/components/NCBIBlastQuery/useCachedBlastResults.d.ts

@@ -1,5 +1,5 @@
 export declare function useCachedBlastResults(geneIds: string[]): {
-    results: any[];
+    results: import("../../../utils/blastCache").CachedBlastResult[];
     error: any;
     isLoading: boolean;
     handleDelete: (id: string) => Promise<void>;

package/dist/LaunchMsaView/components/NCBIBlastQuery/useCachedBlastResults.js

@@ -1,5 +1,5 @@
 import useSWR from 'swr';
-import { clearAllCachedResults, deleteCachedResult, getAllCachedResults, } from '../../../utils/blastCache';
+import { deleteCachedResult, getAllCachedResults, } from '../../../utils/blastCache';
 import { staticSwrConfig } from '../../../utils/swrConfig';
 export function useCachedBlastResults(geneIds) {
     const { data: results, error, isLoading, mutate, } = useSWR(`cached-blast-${geneIds.join(',')}`, async () => {
@@ -10,8 +10,11 @@ export function useCachedBlastResults(geneIds) {
         await deleteCachedResult(id);
         await mutate(results => results?.filter(result => result.id !== id) ?? [], false);
     };
+    // deletes only what this hook listed, i.e. the results for these gene ids.
+    // The list the user is looking at is gene-scoped, so a store-wide clear here
+    // would silently throw away every other gene's cached alignments too
     const handleClearAll = async () => {
-        await clearAllCachedResults();
+        await Promise.all((results ?? []).map(r => deleteCachedResult(r.id)));
         await mutate([], false);
     };
     return {

package/dist/LaunchMsaView/components/calculateProteinSequence.d.ts

@@ -1,14 +1,15 @@
 import type { Feat } from './types';
 import type { Feature } from '@jbrowse/core/util';
-export declare function stitch(subfeats: Feat[], sequence: string): string;
-export declare function calculateProteinSequence({ cds, sequence, }: {
+export declare function calculateProteinSequence({ cds, sequence, geneticCodeId, }: {
     cds: Feat[];
     sequence: string;
+    geneticCodeId?: number;
 }): string;
 export declare function revlist(list: Feat[], seqlen: number): {
     start: number;
     end: number;
     type?: string;
+    phase?: number;
 }[];
 export declare function getProteinSequenceFromFeature({ feature, seq, }: {
     seq: string;

package/dist/LaunchMsaView/components/calculateProteinSequence.js

@@ -1,18 +1,25 @@
-import { dedupe, defaultCodonTable, generateCodonTable, revcom, } from '@jbrowse/core/util';
-// pure constant: the standard codon table never varies, so build it once rather
-// than on every translation (which runs on every panel re-render)
-const codonTable = generateCodonTable(defaultCodonTable);
-export function stitch(subfeats, sequence) {
-    return subfeats.map(sub => sequence.slice(sub.start, sub.end)).join('');
-}
-export function calculateProteinSequence({ cds, sequence, }) {
-    const str = stitch(cds, sequence);
-    let protein = '';
-    for (let i = 0; i < str.length; i += 3) {
-        // use & symbol for undefined codon, or partial slice
-        protein += codonTable[str.slice(i, i + 3)] ?? '&';
-    }
-    return protein;
+import { dedupe, revcom } from '@jbrowse/core/util';
+import { convertCodingSequenceToPeptides } from '@jbrowse/core/util/convertCodingSequenceToPeptides';
+import { getGeneticCode, parseTranslTable } from './geneticCodes';
+// `@jbrowse/core/util/convertCodingSequenceToPeptides` is a deep path, so unlike
+// the `@jbrowse/core/util` barrel it is absent from ReExports and gets bundled
+// rather than resolved out of the host's JBrowseExports. That is what makes
+// reusing core's translation safe across every host a config names: this module
+// previously built its codon table at module scope from the barrel's
+// `defaultCodonTable`, and a core build that dropped that export turned it into
+// `Object.keys(undefined)` while the UMD was still evaluating -- the plugin
+// global was never assigned and PluginLoader error-paged the whole app.
+export function calculateProteinSequence({ cds, sequence, geneticCodeId, }) {
+    // `starts` is deliberately not passed: @jbrowse/core 4.3.0's signature has no
+    // such parameter, so alternative initiators (GTG under table 11, ATA under
+    // table 2) render as their internal residue rather than M. Core main added it;
+    // pass it here when msaview's @jbrowse/core floor reaches that release.
+    const { codonTable } = getGeneticCode(geneticCodeId);
+    return convertCodingSequenceToPeptides({
+        cds,
+        sequence,
+        codonTable,
+    });
 }
 export function revlist(list, seqlen) {
     return list
@@ -33,8 +40,17 @@ export function getProteinSequenceFromFeature({ feature, seq, }) {
         end: sub.end - start,
     }))
         .filter(subfeature => subfeature.type === 'CDS') ?? [], feat => `${feat.start}-${feat.end}`);
+    // a mitochondrial gene declares e.g. transl_table=2, so it translates with
+    // NCBI table 2 rather than the standard code. GFF3 usually carries the
+    // attribute on the CDS rather than the transcript, so check both.
+    const cdsSubfeature = feature
+        .get('subfeatures')
+        ?.find((f) => f.get('type')?.toLowerCase() === 'cds');
+    const geneticCodeId = parseTranslTable(feature.get('transl_table')) ??
+        parseTranslTable(cdsSubfeature?.get('transl_table'));
     return calculateProteinSequence({
         cds: strand === -1 ? revlist(cds, seq.length) : cds,
         sequence: strand === -1 ? revcom(seq) : seq,
+        geneticCodeId,
     });
 }

package/dist/LaunchMsaView/components/geneticCodes.d.ts

@@ -0,0 +1,15 @@
+export interface NcbiGeneticCode {
+    id: number;
+    name: string;
+    ncbieaa: string;
+    sncbieaa: string;
+}
+export declare const ncbiGeneticCodes: NcbiGeneticCode[];
+export interface GeneticCode {
+    id: number;
+    name: string;
+    codonTable: Record<string, string>;
+    starts: string[];
+}
+export declare function getGeneticCode(id?: number): GeneticCode;
+export declare function parseTranslTable(value: unknown): number | undefined;

package/dist/LaunchMsaView/components/geneticCodes.js

@@ -0,0 +1,227 @@
+export const ncbiGeneticCodes = [
+    {
+        id: 1,
+        name: 'Standard',
+        ncbieaa: 'FFLLSSSSYY**CC*WLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '---M------**--*----M---------------M----------------------------',
+    },
+    {
+        id: 2,
+        name: 'Vertebrate Mitochondrial',
+        ncbieaa: 'FFLLSSSSYY**CCWWLLLLPPPPHHQQRRRRIIMMTTTTNNKKSS**VVVVAAAADDEEGGGG',
+        sncbieaa: '----------**--------------------MMMM----------**---M------------',
+    },
+    {
+        id: 3,
+        name: 'Yeast Mitochondrial',
+        ncbieaa: 'FFLLSSSSYY**CCWWTTTTPPPPHHQQRRRRIIMMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '----------**----------------------MM---------------M------------',
+    },
+    {
+        id: 4,
+        name: 'Mold Mitochondrial; Protozoan Mitochondrial; Coelenterate Mitochondrial; Mycoplasma; Spiroplasma',
+        ncbieaa: 'FFLLSSSSYY**CCWWLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '--MM------**-------M------------MMMM---------------M------------',
+    },
+    {
+        id: 5,
+        name: 'Invertebrate Mitochondrial',
+        ncbieaa: 'FFLLSSSSYY**CCWWLLLLPPPPHHQQRRRRIIMMTTTTNNKKSSSSVVVVAAAADDEEGGGG',
+        sncbieaa: '---M------**--------------------MMMM---------------M------------',
+    },
+    {
+        id: 6,
+        name: 'Ciliate Nuclear; Dasycladacean Nuclear; Hexamita Nuclear',
+        ncbieaa: 'FFLLSSSSYYQQCC*WLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '--------------*--------------------M----------------------------',
+    },
+    {
+        id: 9,
+        name: 'Echinoderm Mitochondrial; Flatworm Mitochondrial',
+        ncbieaa: 'FFLLSSSSYY**CCWWLLLLPPPPHHQQRRRRIIIMTTTTNNNKSSSSVVVVAAAADDEEGGGG',
+        sncbieaa: '----------**-----------------------M---------------M------------',
+    },
+    {
+        id: 10,
+        name: 'Euplotid Nuclear',
+        ncbieaa: 'FFLLSSSSYY**CCCWLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '----------**-----------------------M----------------------------',
+    },
+    {
+        id: 11,
+        name: 'Bacterial, Archaeal and Plant Plastid',
+        ncbieaa: 'FFLLSSSSYY**CC*WLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '---M------**--*----M------------MMMM---------------M------------',
+    },
+    {
+        id: 12,
+        name: 'Alternative Yeast Nuclear',
+        ncbieaa: 'FFLLSSSSYY**CC*WLLLSPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '----------**--*----M---------------M----------------------------',
+    },
+    {
+        id: 13,
+        name: 'Ascidian Mitochondrial',
+        ncbieaa: 'FFLLSSSSYY**CCWWLLLLPPPPHHQQRRRRIIMMTTTTNNKKSSGGVVVVAAAADDEEGGGG',
+        sncbieaa: '---M------**----------------------MM---------------M------------',
+    },
+    {
+        id: 14,
+        name: 'Alternative Flatworm Mitochondrial',
+        ncbieaa: 'FFLLSSSSYYY*CCWWLLLLPPPPHHQQRRRRIIIMTTTTNNNKSSSSVVVVAAAADDEEGGGG',
+        sncbieaa: '-----------*-----------------------M----------------------------',
+    },
+    {
+        id: 15,
+        name: 'Blepharisma Macronuclear',
+        ncbieaa: 'FFLLSSSSYY*QCC*WLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '----------*---*--------------------M----------------------------',
+    },
+    {
+        id: 16,
+        name: 'Chlorophycean Mitochondrial',
+        ncbieaa: 'FFLLSSSSYY*LCC*WLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '----------*---*--------------------M----------------------------',
+    },
+    {
+        id: 21,
+        name: 'Trematode Mitochondrial',
+        ncbieaa: 'FFLLSSSSYY**CCWWLLLLPPPPHHQQRRRRIIMMTTTTNNNKSSSSVVVVAAAADDEEGGGG',
+        sncbieaa: '----------**-----------------------M---------------M------------',
+    },
+    {
+        id: 22,
+        name: 'Scenedesmus obliquus Mitochondrial',
+        ncbieaa: 'FFLLSS*SYY*LCC*WLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '------*---*---*--------------------M----------------------------',
+    },
+    {
+        id: 23,
+        name: 'Thraustochytrium Mitochondrial',
+        ncbieaa: 'FF*LSSSSYY**CC*WLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '--*-------**--*-----------------M--M---------------M------------',
+    },
+    {
+        id: 24,
+        name: 'Rhabdopleuridae Mitochondrial',
+        ncbieaa: 'FFLLSSSSYY**CCWWLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSSKVVVVAAAADDEEGGGG',
+        sncbieaa: '---M------**-------M---------------M---------------M------------',
+    },
+    {
+        id: 25,
+        name: 'Candidate Division SR1 and Gracilibacteria',
+        ncbieaa: 'FFLLSSSSYY**CCGWLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '---M------**-----------------------M---------------M------------',
+    },
+    {
+        id: 26,
+        name: 'Pachysolen tannophilus Nuclear',
+        ncbieaa: 'FFLLSSSSYY**CC*WLLLAPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '----------**--*----M---------------M----------------------------',
+    },
+    {
+        id: 27,
+        name: 'Karyorelict Nuclear',
+        ncbieaa: 'FFLLSSSSYYQQCCWWLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '--------------*--------------------M----------------------------',
+    },
+    {
+        id: 28,
+        name: 'Condylostoma Nuclear',
+        ncbieaa: 'FFLLSSSSYYQQCCWWLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '----------**--*--------------------M----------------------------',
+    },
+    {
+        id: 29,
+        name: 'Mesodinium Nuclear',
+        ncbieaa: 'FFLLSSSSYYYYCC*WLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '--------------*--------------------M----------------------------',
+    },
+    {
+        id: 30,
+        name: 'Peritrich Nuclear',
+        ncbieaa: 'FFLLSSSSYYEECC*WLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '--------------*--------------------M----------------------------',
+    },
+    {
+        id: 31,
+        name: 'Blastocrithidia Nuclear',
+        ncbieaa: 'FFLLSSSSYYEECCWWLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '----------**-----------------------M----------------------------',
+    },
+    {
+        id: 32,
+        name: 'Balanophoraceae Plastid',
+        ncbieaa: 'FFLLSSSSYY*WCC*WLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSRRVVVVAAAADDEEGGGG',
+        sncbieaa: '---M------*---*----M------------MMMM---------------M------------',
+    },
+    {
+        id: 33,
+        name: 'Cephalodiscidae Mitochondrial',
+        ncbieaa: 'FFLLSSSSYYY*CCWWLLLLPPPPHHQQRRRRIIIMTTTTNNKKSSSKVVVVAAAADDEEGGGG',
+        sncbieaa: '---M-------*-------M---------------M---------------M------------',
+    },
+];
+// The codon order shared by every NCBI table -- the Base1/Base2/Base3 comment
+// rows in gc.prt. codon i = BASE1[i] + BASE2[i] + BASE3[i].
+const BASE1 = 'TTTTTTTTTTTTTTTTCCCCCCCCCCCCCCCCAAAAAAAAAAAAAAAAGGGGGGGGGGGGGGGG';
+const BASE2 = 'TTTTCCCCAAAAGGGGTTTTCCCCAAAAGGGGTTTTCCCCAAAAGGGGTTTTCCCCAAAAGGGG';
+const BASE3 = 'TCAGTCAGTCAGTCAGTCAGTCAGTCAGTCAGTCAGTCAGTCAGTCAGTCAGTCAGTCAGTCAG';
+const CODONS = Array.from({ length: 64 }, (_, i) => BASE1[i] + BASE2[i] + BASE3[i]);
+const ncbiCodeById = new Map(ncbiGeneticCodes.map(t => [t.id, t]));
+// Expand an uppercase codon map so every case combination of a triplet resolves,
+// which is what callers reading raw sequence need.
+function caseExpand(table) {
+    const out = {};
+    for (const [codon, aa] of Object.entries(table)) {
+        const cases = (i) => {
+            const n = codon.charAt(i);
+            return [n.toUpperCase(), n.toLowerCase()];
+        };
+        for (const n0 of cases(0)) {
+            for (const n1 of cases(1)) {
+                for (const n2 of cases(2)) {
+                    out[n0 + n1 + n2] = aa;
+                }
+            }
+        }
+    }
+    return out;
+}
+function buildGeneticCode(id) {
+    const def = ncbiCodeById.get(id);
+    if (!def && id !== 1) {
+        console.warn(`Unknown genetic code (transl_table=${id}); using standard code`);
+    }
+    const { id: resolvedId, name, ncbieaa, sncbieaa, } = def ?? ncbiCodeById.get(1);
+    const table = {};
+    const starts = [];
+    for (const [i, codon] of CODONS.entries()) {
+        table[codon] = ncbieaa[i];
+        if (sncbieaa[i] === 'M') {
+            starts.push(codon);
+        }
+    }
+    return { id: resolvedId, name, codonTable: caseExpand(table), starts };
+}
+const geneticCodeCache = new Map();
+// Resolves the codon map + start set for an NCBI translation-table id, falling
+// back to the standard code (1) for an unrecognized id. Memoized: there are only
+// ~27 tables and each result is immutable.
+export function getGeneticCode(id = 1) {
+    let code = geneticCodeCache.get(id);
+    if (!code) {
+        code = buildGeneticCode(id);
+        geneticCodeCache.set(id, code);
+    }
+    return code;
+}
+// Parses a GFF/GenBank `transl_table` attribute value into an NCBI table id. The
+// GFF adapter yields a string (or an array if the attribute repeated), so this
+// normalizes both; returns undefined for a missing or non-positive-integer value
+// so callers fall back to their default code.
+export function parseTranslTable(value) {
+    const raw = Array.isArray(value) ? value[0] : value;
+    const n = Number(raw);
+    return Number.isInteger(n) && n > 0 ? n : undefined;
+}

package/dist/LaunchMsaView/components/types.d.ts

@@ -2,6 +2,7 @@ export interface Feat {
     start: number;
     end: number;
     type?: string;
+    phase?: number;
 }
 export interface SeqState {
     seq: string;

package/dist/LaunchMsaView/index.js

@@ -4,6 +4,7 @@ import LaunchMsaViewDialog from './components/LaunchMsaViewDialog';
 function isDisplay(elt) {
     return elt.name === 'LinearBasicDisplay';
 }
+const GENE_LIKE_TYPES = new Set(['gene', 'mRNA', 'transcript']);
 function extendStateModel(stateModel) {
     return stateModel.views((self) => {
         const superContextMenuItems = self.contextMenuItems;
@@ -11,35 +12,40 @@ function extendStateModel(stateModel) {
             contextMenuItems() {
                 const track = getContainingTrack(self);
                 const session = getSession(track);
+                const launch = (feature) => {
+                    session.queueDialog(handleClose => [
+                        LaunchMsaViewDialog,
+                        { model: track, handleClose, feature },
+                    ]);
+                };
                 const info = self.contextMenuInfo;
-                const showMsaMenuItem = info && self.isGeneLike;
+                const fetchFullFeature = self.fetchFullFeature;
+                const legacyFeature = self.contextMenuFeature;
+                const onClick = info && fetchFullFeature && self.isGeneLike
+                    ? () => {
+                        fetchFullFeature(info.item.featureId, info.displayedRegionIndex)
+                            .then(feature => {
+                            if (feature) {
+                                launch(feature);
+                            }
+                            else {
+                                session.notify('Could not load feature for MSA view', 'warning');
+                            }
+                        })
+                            .catch((e) => {
+                            session.notifyError(`${e}`, e);
+                        });
+                    }
+                    : legacyFeature &&
+                        GENE_LIKE_TYPES.has(String(legacyFeature.get('type')))
+                        ? () => {
+                            launch(legacyFeature);
+                        }
+                        : undefined;
                 return [
                     ...superContextMenuItems(),
-                    ...(showMsaMenuItem
-                        ? [
-                            {
-                                label: 'Launch MSA view',
-                                icon: AddIcon,
-                                onClick: () => {
-                                    self
-                                        .fetchFullFeature(info.item.featureId, info.displayedRegionIndex)
-                                        .then(feature => {
-                                        if (feature) {
-                                            session.queueDialog(handleClose => [
-                                                LaunchMsaViewDialog,
-                                                { model: track, handleClose, feature },
-                                            ]);
-                                        }
-                                        else {
-                                            session.notify('Could not load feature for MSA view', 'warning');
-                                        }
-                                    })
-                                        .catch((e) => {
-                                        session.notifyError(`${e}`, e);
-                                    });
-                                },
-                            },
-                        ]
+                    ...(onClick
+                        ? [{ label: 'Launch MSA view', icon: AddIcon, onClick }]
                         : []),
                 ];
             },

package/dist/MsaViewPanel/doLaunchBlast.js

@@ -7,36 +7,26 @@ import { fetchTaxonomyInfo } from '../utils/taxonomyNames';
 export async function doLaunchBlast({ self, }) {
     const { baseUrl, blastDatabase, blastProgram, msaAlgorithm, proteinSequence, selectedTranscript, rid: existingRid, } = self.blastParams;
     const cleanedSeq = cleanProteinSequence(proteinSequence);
-    let hits;
-    let rid;
+    const onProgress = (arg) => {
+        self.setProgress(arg);
+    };
     if (existingRid) {
+        // publish it before the first poll so the view can link out to NCBI while
+        // the job is still running
         self.setRid(existingRid);
-        const result = await queryBlastFromRid({
-            rid: existingRid,
-            baseUrl,
-            onProgress: arg => {
-                self.setProgress(arg);
-            },
-        });
-        hits = result.hits;
-        rid = result.rid;
     }
-    else {
-        const result = await queryBlast({
+    const { hits, rid } = existingRid
+        ? await queryBlastFromRid({ rid: existingRid, baseUrl, onProgress })
+        : await queryBlast({
             query: cleanedSeq,
             blastDatabase,
             blastProgram,
             baseUrl,
-            onProgress: arg => {
-                self.setProgress(arg);
-            },
+            onProgress,
             onRid: r => {
                 self.setRid(r);
             },
         });
-        hits = result.hits;
-        rid = result.rid;
-    }
     self.setProgress('Fetching species taxonomy info...');
     const taxids = hits
         .map(h => h.description[0]?.taxid)
@@ -57,9 +47,7 @@ export async function doLaunchBlast({ self, }) {
     const result = await launchMSA({
         algorithm: msaAlgorithm,
         sequence: [`>QUERY\n${cleanedSeq}`, ...sequences].join('\n'),
-        onProgress: arg => {
-            self.setProgress(arg);
-        },
+        onProgress,
     });
     const treeMetadataJson = JSON.stringify(treeMetadata);
     await saveBlastResult({

package/dist/MsaViewPanel/genomeToMSA.js

@@ -6,18 +6,25 @@ export function genomeToMSA({ model }) {
     if (!connectedView?.initialized || !hasHoverPosition(hovered)) {
         return undefined;
     }
-    const { coord: hoverCoord, refName } = hovered.hoverPosition;
+    const { coord, refName } = hovered.hoverPosition;
+    // hoverPosition.coord is a 1-based display coordinate (core's pxToBp adds the
+    // +1), while g2p and mafRegion are keyed by 0-based genome position
+    const genomePos = coord - 1;
     if (mafRegion) {
         if (refName !== mafRegion.refName ||
             !connectedView.assemblyNames.includes(mafRegion.assemblyName) ||
-            hoverCoord < mafRegion.start ||
-            hoverCoord >= mafRegion.end) {
+            genomePos < mafRegion.start ||
+            genomePos >= mafRegion.end) {
             return undefined;
         }
-        return model.seqPosToVisibleCol(querySeqName, hoverCoord - mafRegion.start);
+        return model.seqPosToVisibleCol(querySeqName, genomePos - mafRegion.start);
     }
-    if (transcriptToMsaMap) {
-        const seqPos = transcriptToMsaMap.g2p[hoverCoord];
+    // session.hovered is global -- set by whichever LinearGenomeView the cursor
+    // was last over, on any assembly -- so the refName gate is load bearing:
+    // without it the same numeric coordinate on an unrelated chromosome matches a
+    // g2p key and lights up a column for a different locus
+    if (refName === transcriptToMsaMap?.refName) {
+        const seqPos = transcriptToMsaMap.g2p[genomePos];
         if (seqPos !== undefined) {
             return model.seqPosToVisibleCol(querySeqName, seqPos);
         }

package/dist/MsaViewPanel/genomeToMSA.test.js

@@ -76,8 +76,9 @@ describe('genomeToMSA', () => {
                 seqPosToVisibleCol: mockSeqPosToVisibleCol,
             };
             const result = genomeToMSA({ model });
-            // coord 1005 - start 1000 = ungapped position 5
-            expect(mockSeqPosToVisibleCol).toHaveBeenCalledWith('hg38.chr1', 5);
+            // hover coord 1005 is 1-based, so the 0-based genome position is 1004,
+            // which is ungapped position 4 of a region starting at 1000
+            expect(mockSeqPosToVisibleCol).toHaveBeenCalledWith('hg38.chr1', 4);
             expect(result).toBe(5);
         });
         test('returns undefined when hover refName does not match mafRegion', () => {
@@ -106,10 +107,11 @@ describe('genomeToMSA', () => {
             expect(result).toBeUndefined();
         });
         test('returns undefined when hover coord is before mafRegion start', () => {
+            // 1-based coord 1000 is the 0-based base 999, one before the region
             mockGetSession.mockReturnValue({
                 hovered: {
                     hoverFeature: {},
-                    hoverPosition: { coord: 999, refName: 'chr1' },
+                    hoverPosition: { coord: 1000, refName: 'chr1' },
                 },
             });
             const model = {
@@ -131,10 +133,11 @@ describe('genomeToMSA', () => {
             expect(result).toBeUndefined();
         });
         test('returns undefined when hover coord is at or after mafRegion end', () => {
+            // 1-based coord 1011 is the 0-based base 1010, one past the region
             mockGetSession.mockReturnValue({
                 hovered: {
                     hoverFeature: {},
-                    hoverPosition: { coord: 1010, refName: 'chr1' },
+                    hoverPosition: { coord: 1011, refName: 'chr1' },
                 },
             });
             const model = {
@@ -193,7 +196,9 @@ describe('genomeToMSA', () => {
             const model = {
                 querySeqName: 'QUERY',
                 transcriptToMsaMap: {
-                    g2p: { 1005: 10 },
+                    refName: 'chr1',
+                    // g2p is keyed by 0-based genome position, the hover coord is 1-based
+                    g2p: { 1004: 10 },
                 },
                 mafRegion: undefined,
                 connectedView: { initialized: true },
@@ -203,6 +208,29 @@ describe('genomeToMSA', () => {
             expect(mockSeqPosToVisibleCol).toHaveBeenCalledWith('QUERY', 10);
             expect(result).toBe(10);
         });
+        test('returns undefined when the hover is on another refName', () => {
+            // session.hovered is global, so a hover on an unrelated chromosome can
+            // carry a coordinate that happens to be a g2p key
+            mockGetSession.mockReturnValue({
+                hovered: {
+                    hoverFeature: {},
+                    hoverPosition: { coord: 1005, refName: 'chr2' },
+                },
+            });
+            const mockSeqPosToVisibleCol = vi.fn();
+            const model = {
+                querySeqName: 'QUERY',
+                transcriptToMsaMap: {
+                    refName: 'chr1',
+                    g2p: { 1004: 10 },
+                },
+                mafRegion: undefined,
+                connectedView: { initialized: true },
+                seqPosToVisibleCol: mockSeqPosToVisibleCol,
+            };
+            expect(genomeToMSA({ model })).toBeUndefined();
+            expect(mockSeqPosToVisibleCol).not.toHaveBeenCalled();
+        });
         test('returns undefined when g2p has no mapping for coord', () => {
             mockGetSession.mockReturnValue({
                 hovered: {
@@ -213,7 +241,8 @@ describe('genomeToMSA', () => {
             const model = {
                 querySeqName: 'QUERY',
                 transcriptToMsaMap: {
-                    g2p: { 1000: 0 }, // No entry for 1005
+                    refName: 'chr1',
+                    g2p: { 1000: 0 }, // No entry for 1004
                 },
                 mafRegion: undefined,
                 connectedView: { initialized: true },