jbrowse-plugin-graphgenomeviewer 4.6.0 → 4.7.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jbrowse-plugin-graphgenomeviewer",
-  "version": "4.6.0",
+  "version": "4.7.0",
   "description": "JBrowse 2 graph genome (pangenome) view: rGFA reference-anchored layouts, the Bandage force-directed engine, and haplotype lanes read from a gbz-base database",
   "license": "GPL-3.0-or-later",
   "repository": {
@@ -76,7 +76,7 @@
     "typescript-eslint": "^8.71.0",
     "typescript7": "npm:typescript@^7.0.2",
     "vitest": "^5.0.3",
-    "@jbrowse/bandage-core": "4.6.0"
+    "@jbrowse/bandage-core": "4.7.0"
   },
   "peerDependencies": {
     "react": ">=18.0.0",

package/src/GraphGenomeView/model.test.ts

@@ -2738,6 +2738,23 @@ describe('walk rows', () => {
     expect(model.figureSpec()?.walkRowSamples).toBeUndefined()
   })
 
+  test('walk rows offer no figure spec, since bandage-figure draws no walk rows', async () => {
+    rpcRespond()
+    mockReadFile.mockResolvedValue(WALKS_GFA)
+    const model = stateModelFactory().create({
+      type: 'GraphGenomeView',
+      gfaLocation: {
+        uri: 'https://example.com/graphs/walks.gfa',
+        locationType: 'UriLocation',
+      },
+      loadedRegion: TEST_REGION,
+      layoutMode: 'walkrows',
+    })
+    await model.load()
+    expect(model.walkRowBars).toBeDefined()
+    expect(model.figureSpecUnavailable).toMatch(/^bandage-figure draws no /)
+  })
+
   test('walks lift together, each keeping the colour it was given', async () => {
     rpcRespond()
     const model = stateModelFactory().create({

package/src/GraphGenomeView/model.ts

@@ -2391,6 +2391,15 @@ export function GraphPaneMixin() {
             ? undefined
             : `${layoutModeByValue(self.chosenLayoutMode).label} draws a picture of its own, which the SVG export does not`
       },
+      // Why bandage-figure can't make this drawing again: it draws only
+      // layouts with nodes, from a graph it can read for itself
+      get figureSpecUnavailable() {
+        return !self.drawsNodes
+          ? `bandage-figure draws no ${layoutModeByValue(self.chosenLayoutMode).label} layout`
+          : this.figureSpec()
+            ? undefined
+            : 'bandage-figure reads a graph cut from a gbz-base track or a GFA url'
+      },
       // The drawing as a standalone SVG, fitted, with its genes, its lifted
       // walks' keys, facet panels and the strip of walk rows; see figureSvg
       figure() {
@@ -4180,9 +4189,8 @@ export function GraphPaneMixin() {
           },
           {
             label: 'Copy figure spec',
-            disabled: !self.figureSpec(),
-            disabledHelpText:
-              'bandage-figure reads a graph cut from a gbz-base track or a GFA url',
+            disabled: self.figureSpecUnavailable !== undefined,
+            disabledHelpText: self.figureSpecUnavailable,
             onClick: () => {
               const spec = self.figureSpec()
               const session = getSession(self)

package/src/version.ts

@@ -1 +1 @@
-export const version = '4.6.0'
+export const version = '4.7.0'