jazz-tools 0.17.5 → 0.17.6

package/src/media/utils.test.ts

@@ -347,7 +347,6 @@ describe("loadImageBySize", async () => {
 
   it("returns the image already loaded", async () => {
     const account = await setupJazzTestSync({ asyncPeers: true });
-    const account2 = await createJazzTestAccount();
 
     setActiveAccount(account);
 
@@ -363,9 +362,11 @@ describe("loadImageBySize", async () => {
       group,
     );
 
+    const account2 = await createJazzTestAccount();
     setActiveAccount(account2);
 
-    const result = await loadImageBySize(imageDef, 1024, 1024);
+    const result = await loadImageBySize(imageDef.id, 1024, 1024);
+    expect(result).not.toBeNull();
     expect(result?.image.id).toBe(imageDef["1024x1024"]!.id);
     expect(result?.image.isBinaryStreamEnded()).toBe(true);
     expect(result?.image.asBase64()).toStrictEqual(expect.any(String));

package/src/media/utils.ts

@@ -185,7 +185,11 @@ export async function loadImageBySize(
   const bestTarget =
     sortedSizes.find((el) => el.match > 0.95) || sortedSizes.at(-1)!;
 
-  const file = image[bestTarget.size[2]];
+  // The image's `wxh` keys reference FileStream.
+  // image[bestTarget.size[2]] returns undefined if FileStream hasn't loaded yet.
+  // Since we only need the file's ID to fetch it later, we check the raw _refs
+  // which contain only the linked covalue's ID.
+  const file = image._refs[bestTarget.size[2]];
 
   if (!file) {
     return null;

package/src/tools/implementation/schema.ts

@@ -171,7 +171,9 @@ export function instantiateRefEncodedWithInit<V extends CoValue>(
       `Cannot automatically create CoValue from value: ${JSON.stringify(init)}. Use the CoValue schema's create() method instead.`,
     );
   }
-  const owner = Group.create();
+  const node = parentOwner._raw.core.node;
+  const rawGroup = node.createGroup();
+  const owner = new Group({ fromRaw: rawGroup });
   owner.addMember(parentOwner.castAs(Group));
   // @ts-expect-error - create is a static method in all CoValue classes
   return schema.ref.create(init, owner);

package/src/tools/testing.ts

@@ -154,6 +154,24 @@ export function setActiveAccount(account: Account) {
   activeAccountContext.set(account);
 }
 
+/**
+ * Run a callback without an active account.
+ *
+ * Takes care of restoring the active account after the callback is run.
+ *
+ * @param callback - The callback to run.
+ * @returns The result of the callback.
+ */
+export function runWithoutActiveAccount<Result>(
+  callback: () => Result,
+): Result {
+  const me = Account.getMe();
+  activeAccountContext.set(null);
+  const result = callback();
+  activeAccountContext.set(me);
+  return result;
+}
+
 export async function createJazzTestGuest() {
   const ctx = await createAnonymousJazzContext({
     crypto: await PureJSCrypto.create(),

package/src/tools/tests/coMap.test.ts

@@ -12,10 +12,15 @@ import {
 } from "vitest";
 import { Group, co, subscribeToCoValue, z } from "../exports.js";
 import { Account } from "../index.js";
-import { Loaded, coValueClassFromCoValueClassOrSchema } from "../internal.js";
+import {
+  Loaded,
+  activeAccountContext,
+  coValueClassFromCoValueClassOrSchema,
+} from "../internal.js";
 import {
   createJazzTestAccount,
   getPeerConnectedToTestSyncServer,
+  runWithoutActiveAccount,
   setupJazzTestSync,
 } from "../testing.js";
 import { setupTwoNodes, waitFor } from "./utils.js";
@@ -214,6 +219,19 @@ describe("CoMap", async () => {
         const map = Schema.create({ text: "" });
         expect(map.text.toString()).toBe("");
       });
+
+      it("creates a group for the new CoValue when there is no active account", () => {
+        const Schema = co.map({ text: co.plainText() });
+
+        const parentGroup = Group.create();
+        runWithoutActiveAccount(() => {
+          const map = Schema.create({ text: "Hello" }, parentGroup);
+
+          expect(
+            map.text._owner.getParentGroups().map((group: Group) => group.id),
+          ).toContain(parentGroup.id);
+        });
+      });
     });
 
     test("CoMap with self reference", () => {