javi-forge 1.6.1 → 1.7.0

package/ci-local/ci-local.sh

@@ -16,17 +16,45 @@ set -e
 SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
 PROJECT_DIR="$(dirname "$SCRIPT_DIR")"
 
-# Source shared library for colors and detect_stack
+# Require realpath: load-bearing for the lib symlink check below.
+if ! command -v realpath >/dev/null 2>&1; then
+    printf 'ERROR: realpath is required (install coreutils).\n' >&2
+    exit 1
+fi
+
+# Source shared library for colors and detect_stack.
 # Look inside ci-local/lib first (self-contained), fallback to project-level lib/
+LIB_CANDIDATE=""
 if [ -f "$SCRIPT_DIR/lib/common.sh" ]; then
-    source "$SCRIPT_DIR/lib/common.sh"
+    LIB_CANDIDATE="$SCRIPT_DIR/lib/common.sh"
 elif [ -f "$SCRIPT_DIR/../lib/common.sh" ]; then
-    source "$SCRIPT_DIR/../lib/common.sh"
+    LIB_CANDIDATE="$SCRIPT_DIR/../lib/common.sh"
 else
     echo "ERROR: lib/common.sh not found"
     exit 1
 fi
 
+# SECURITY: validate lib/common.sh before sourcing. A hostile symlink runs
+# attacker code at user privilege as soon as `source` evaluates the file.
+# Audit round 4 (2026-05-17) PoC verified the same hijack on install.sh.
+_LIB_REAL=$(realpath "$LIB_CANDIDATE")
+_PROJECT_REAL=$(realpath "$PROJECT_DIR")
+case "$_LIB_REAL" in
+    "$_PROJECT_REAL"|"$_PROJECT_REAL"/*) ;;
+    *)
+        printf 'ERROR: lib/common.sh resolves outside the project root:\n' >&2
+        printf '  LIB resolved:     %s\n' "$_LIB_REAL" >&2
+        printf '  PROJECT resolved: %s\n' "$_PROJECT_REAL" >&2
+        exit 1
+        ;;
+esac
+
+# Source the RESOLVED path to close the TOCTOU window between validation
+# and source (round 5 finding). Preserve the variables under temp names
+# in case any downstream caller relies on them.
+source "$_LIB_REAL"
+unset _LIB_REAL _PROJECT_REAL
+
 # =============================================================================
 # CI COMMAND SETUP (extends shared detect_stack with CI-specific commands)
 # =============================================================================
@@ -72,9 +100,13 @@ setup_ci_commands() {
             else
                 COMPILE_CMD=""
             fi
-            # Only set test if test script exists
+            # Only set test if test script exists. If a "test:hooks" script
+            # is present, chain it so the commit-msg hook stays under coverage.
             if grep -q '"test"' "$PROJECT_DIR/package.json" 2>/dev/null; then
                 TEST_CMD="$BUILD_TOOL test"
+                if grep -q '"test:hooks"' "$PROJECT_DIR/package.json" 2>/dev/null; then
+                    TEST_CMD="$TEST_CMD && $BUILD_TOOL run test:hooks"
+                fi
             else
                 TEST_CMD=""
             fi
@@ -122,6 +154,17 @@ create_dockerfile() {
     local docker_dir="$SCRIPT_DIR/docker"
     mkdir -p "$docker_dir"
 
+    # Base image digests are pinned for deterministic CI. Refresh with
+    # `docker pull <img> && docker inspect <img>` and update both
+    # ci-local.sh and ci-local.ps1 in lockstep (the bytes must match for
+    # the dockerfile-hash cache to align across platforms).
+    #
+    # Java is left tag-only because JAVA_VERSION is a build-arg that lets
+    # the user pick a JDK version at runtime; pinning the digest would
+    # break any version other than 21. Default JAVA_VERSION=21 digest
+    # for reference (2026-05-18):
+    #   eclipse-temurin:21-jdk-noble
+    #     @sha256:1f5835564a8c5cee3e9e849a63e9b04ce5c7083070e4cbcaabbcdc36d9147450
     case "$STACK_TYPE" in
         java-gradle|java-maven)
             cat > "$docker_dir/$DOCKERFILE" << 'DOCKERFILE'
@@ -137,7 +180,7 @@ DOCKERFILE
             ;;
         node)
             cat > "$docker_dir/$DOCKERFILE" << 'DOCKERFILE'
-FROM node:22-slim
+FROM node:22-slim@sha256:689c11043dad91472750cd824c97dd5e2318e9dd6f954e492fe7af0135d33ceb
 RUN apt-get update && apt-get install -y git && rm -rf /var/lib/apt/lists/*
 RUN npm install -g pnpm
 RUN useradd -m -s /bin/bash runner
@@ -148,7 +191,7 @@ DOCKERFILE
             ;;
         python)
             cat > "$docker_dir/$DOCKERFILE" << 'DOCKERFILE'
-FROM python:3.12-slim
+FROM python:3.12-slim@sha256:401f6e1a67dad31a1bd78e9ad22d0ee0a3b52154e6bd30e90be696bb6a3d7461
 RUN apt-get update && apt-get install -y git && rm -rf /var/lib/apt/lists/*
 RUN pip install --no-cache-dir pytest ruff pylint poetry
 RUN useradd -m -s /bin/bash runner
@@ -159,7 +202,7 @@ DOCKERFILE
             ;;
         go)
             cat > "$docker_dir/$DOCKERFILE" << 'DOCKERFILE'
-FROM golang:1.23-bookworm
+FROM golang:1.23-bookworm@sha256:167053a2bb901972bf2c1611f8f52c44d5fe7e762e5cab213708d82c421614db
 RUN apt-get update && apt-get install -y git && rm -rf /var/lib/apt/lists/*
 RUN go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.62.0 && \
     mv /root/go/bin/golangci-lint /usr/local/bin/
@@ -171,7 +214,7 @@ DOCKERFILE
             ;;
         rust)
             cat > "$docker_dir/$DOCKERFILE" << 'DOCKERFILE'
-FROM rust:1.83-slim
+FROM rust:1.83-slim@sha256:540c902e99c384163b688bbd8b5b8520e94e7731b27f7bd0eaa56ae1960627ab
 RUN apt-get update && apt-get install -y git pkg-config libssl-dev && rm -rf /var/lib/apt/lists/*
 RUN rustup component add clippy rustfmt
 RUN useradd -m -s /bin/bash runner
@@ -182,7 +225,7 @@ DOCKERFILE
             ;;
         *)
             cat > "$docker_dir/$DOCKERFILE" << 'DOCKERFILE'
-FROM ubuntu:24.04
+FROM ubuntu:24.04@sha256:c4a8d5503dfb2a3eb8ab5f807da5bc69a85730fb49b5cfca2330194ebcc41c7b
 RUN apt-get update && apt-get install -y git curl && rm -rf /var/lib/apt/lists/*
 RUN useradd -m -s /bin/bash runner
 USER runner

package/ci-local/docker/python.Dockerfile

@@ -0,0 +1,7 @@
+FROM python:3.12-slim
+RUN apt-get update && apt-get install -y git && rm -rf /var/lib/apt/lists/*
+RUN pip install --no-cache-dir pytest ruff pylint poetry
+RUN useradd -m -s /bin/bash runner
+USER runner
+WORKDIR /home/runner/work
+ENTRYPOINT ["/bin/bash", "-c"]

package/ci-local/hooks/commit-msg

@@ -1,68 +1,145 @@
 #!/bin/bash
 set -e
 # =============================================================================
-# COMMIT-MSG: Validate commit message
+# COMMIT-MSG: Block accidental AI-attribution in commit messages
 # =============================================================================
-# Bloquea mensajes con atribución a IA
+# Best-effort, NOT an adversarial-grade security control.
+#
+# Diseño:
+#   1. Normalizar el mensaje (Unicode invisibles, combining marks, markdown,
+#      puntuación, emoji, full-width latin via NFKC)
+#   2. Match patrones case-insensitive contra la versión normalizada
+#      Y contra el mensaje crudo (por si normalize sobre-strip-ea)
+#
+# Alcance:
+#   ✅ Defiende contra: copy-paste accidental, whitespace tricks (doble
+#      espacio, NBSP, ZWSP), markdown formatting, full-width latin,
+#      combining diacritics, dashes/underscores en model names, separadores
+#      de puntuación / emoji.
+#   ❌ NO defiende contra: homoglifos cross-script (Cyrillic Сlaude, Greek
+#      Ϲlaude, Cherokee Ꮯlaude), tag characters, variation selectors,
+#      provider names standalone sin verbo o modelo, bypasses creativos
+#      de adversario motivado con tabla Unicode en mano.
+#
+# El test suite (commit-msg.test.sh) documenta qué bypasses están cubiertos
+# y cuáles aceptamos como limitación. Si necesitás defensa adversarial,
+# usá signed commits, no regex.
 # =============================================================================
 
 COMMIT_MSG_FILE="$1"
-COMMIT_MSG=$(cat "$COMMIT_MSG_FILE")
+RAW_MSG=$(cat "$COMMIT_MSG_FILE")
 
 RED='\033[0;31m'
 GREEN='\033[0;32m'
 YELLOW='\033[1;33m'
 NC='\033[0m'
 
-# Patrones prohibidos en mensaje de commit (case insensitive)
+# ─── Normalización ──────────────────────────────────────────────────
+# Si perl falla (no instalado, módulo Unicode::Normalize ausente), el
+# normalize retorna el mensaje crudo. El loop de patrones igual matchea
+# contra RAW_MSG, así que perl roto degrada pero no abre todo.
+normalize_msg() {
+    if ! command -v perl >/dev/null 2>&1; then
+        printf "%s" "$1"
+        return
+    fi
+    # 2>/dev/null suprime warnings de perl. Si el script falla por completo,
+    # || printf "%s" "$1" deja pasar el raw — el match contra RAW_MSG abajo
+    # sigue cubriendo los patrones literales.
+    printf "%s" "$1" | perl -CSAD -pe '
+        # 1. Reemplazar Unicode formatting/invisibles por ESPACIO (no borrarlos).
+        #    Borrarlos junta "by" + "Claude" → "byClaude" y la regex pierde el match.
+        #    ZWSP/ZWNJ/ZWJ/LRM/RLM, NBSP, bidi controls, BOM, word-joiner.
+        s/[\x{00A0}\x{200B}-\x{200F}\x{2028}-\x{202F}\x{2060}-\x{206F}\x{FEFF}]/ /g;
+        # 2. Strip combining diacritics. Esto folds "Ćlaude" (C + U+0301) a "Claude".
+        s/[\x{0300}-\x{036F}]//g;
+        # 3. NFKC normaliza compatibility forms (full-width latin → ascii)
+        use Unicode::Normalize qw(NFKC);
+        $_ = NFKC($_);
+        # 4. Markdown / puntuación / emoji → espacio
+        #    Markdown:   * _ ` ~
+        #    Puntuación: . , : ; ! ? ( ) [ ] { } < > / \ | " '\''
+        #    Emoji:      Misc Symbols (2600-27BF), Pictographs (1F300-1FAFF)
+        s/[*_`~.,:;!?()\[\]{}<>\\\/|"'\''\x{2600}-\x{27BF}\x{1F300}-\x{1FAFF}]/ /g;
+        # 5. Colapsar whitespace (incluye \n, \t, espacios múltiples)
+        s/\s+/ /g;
+    ' 2>/dev/null || printf "%s" "$1"
+}
+
+NORMALIZED_MSG=$(normalize_msg "$RAW_MSG")
+
+# ─── Patrones (case insensitive, grep -iE) ──────────────────────────
+#
+# Notas:
+#   \b           = word boundary (GNU grep ext.)
+#   [[:space:]]+ = uno o más espacios (POSIX, portable)
+#   [-_ ]?       = separador opcional entre proveedor y modelo
+#
+# Limitación conocida y aceptada: homoglifos Unicode (Cyrillic С en lugar
+# de Latin C) requieren transliteración (Text::Unidecode) que es módulo
+# no-core de perl. Documentado, no se intenta defender.
+PROVIDER_PAT='(claude|gpt|chatgpt|openai|anthropic|gemini|copilot|llm|cursor|windsurf|codeium|cody|aider)'
+
 AI_PATTERNS=(
-    "co-authored-by:.*claude"
-    "co-authored-by:.*anthropic"
-    "co-authored-by:.*gpt"
-    "co-authored-by:.*openai"
-    "co-authored-by:.*copilot"
-    "co-authored-by:.*gemini"
-    "co-authored-by:.*\bai\b"
-    "made by claude"
-    "made by gpt"
-    "made by ai"
-    "made with claude"
-    "made with ai"
-    "generated by claude"
-    "generated by gpt"
-    "generated by ai"
-    "generated with claude"
-    "generated with ai"
-    "written by claude"
-    "written by ai"
-    "created by claude"
-    "created by ai"
-    "assisted by claude"
-    "assisted by ai"
-    "with help from claude"
-    "claude code"
-    "claude opus"
-    "claude sonnet"
-    "claude haiku"
-    "gpt-4"
-    "gpt-3"
-    "chatgpt"
-    "@anthropic.com"
-    "@openai.com"
-    "noreply@anthropic"
-    "noreply@openai"
+    # ── Co-authored-by trailer ────────────────────────────────────────
+    # Captura cualquier proveedor en el mismo trailer.
+    "co-authored-by:.*\b${PROVIDER_PAT}\b"
+    # AI en trailer: AI alone OR AIAssistant / AIBot / AIAgent compounds
+    "co-authored-by:.*\bai(assistant|bot|agent|helper)?\b"
+    # Standalone Copilot/Codeium/Cursor en trailer (sin prefix vendor)
+    "co-authored-by:.*\b(copilot|cursor|codeium|cody|aider|chatgpt)\b"
+
+    # ── Verbos de atribución + by/with + proveedor ───────────────────
+    # Ej: "made by Claude", "generated with GPT", "built with OpenAI"
+    # Verbos expandidos en audit-2 para cubrir "I used X", "X helped me",
+    # "wrote by AI", "prompted to write", "asked Claude to".
+    "(made|generated|written|created|assisted|built|developed|authored|produced|coded|crafted|helped|used|wrote|prompted|asked|fixed|refactored)[[:space:]]+(by|with|using|via)[[:space:]]+${PROVIDER_PAT}"
+    "(made|generated|written|created|assisted|built|developed|authored|produced|coded|crafted|helped|used|wrote|prompted|asked|fixed|refactored)[[:space:]]+(by|with|using|via)[[:space:]]+\bai(assistant|bot|agent|helper)?\b"
+
+    # ── "with help from / thanks to / powered by X" ──────────────────
+    "(with[[:space:]]+help[[:space:]]+from|thanks[[:space:]]+to|powered[[:space:]]+by|courtesy[[:space:]]+of)[[:space:]]+${PROVIDER_PAT}"
+    "(with[[:space:]]+help[[:space:]]+from|thanks[[:space:]]+to|powered[[:space:]]+by|courtesy[[:space:]]+of)[[:space:]]+\bai(assistant|bot|agent|helper)?\b"
+
+    # ── "X-assisted" / "X assisted" ──────────────────────────────────
+    # Cubre: anthropic-assisted, openai assisted, ai_assisted, etc.
+    "${PROVIDER_PAT}[-_ ]?assisted"
+    "\bai[-_ ]?assisted"
+
+    # ── Standalone branding / tooling ────────────────────────────────
+    "claude[-_ ]?code"
+    "(github|microsoft)[-_ ]?copilot"
+    "\bchatgpt\b"
+    "\bcursor[-_ ]?(ai|ide)?\b"
+    "\bwindsurf\b"
+    "\bcodeium\b"
+    "\bcody\b"
+    "\baider\b"
+
+    # ── Claude + variante de modelo ──────────────────────────────────
+    # Cubre: "claude opus", "claude-sonnet", "Claude3", "claude4.5", "Claude 4.7"
+    "claude[-_ ]?(opus|sonnet|haiku|[0-9])"
+
+    # ── GPT + versión ────────────────────────────────────────────────
+    # Cubre: gpt-4, gpt 3, gpt_5, gpt4.5
+    "gpt[-_ ]?[0-9]"
+
+    # ── Email domains de los proveedores ─────────────────────────────
+    "@(anthropic|openai|cursor|codeium)\\.(com|sh|ai)"
+    "noreply@(anthropic|openai)"
 )
 
+# Run pattern matching against the NORMALIZED message.
+# Use both raw and normalized — raw catches anything normalization might over-strip.
 for pattern in "${AI_PATTERNS[@]}"; do
-    if echo "$COMMIT_MSG" | grep -iqE "$pattern"; then
+    if printf "%s" "$NORMALIZED_MSG" | grep -iqE "$pattern" \
+       || printf "%s" "$RAW_MSG" | grep -iqE "$pattern"; then
         echo -e ""
         echo -e "${RED}COMMIT BLOCKED: AI Attribution Detected${NC}"
         echo -e ""
-        echo -e "${RED}Found in commit message: ${NC}"
-        echo -e "${YELLOW}  Pattern: $pattern${NC}"
+        echo -e "${RED}Pattern matched:${NC} ${YELLOW}$pattern${NC}"
         echo -e ""
         echo -e "${RED}Your commit message:${NC}"
-        echo -e "${YELLOW}$(cat "$COMMIT_MSG_FILE")${NC}"
+        echo -e "${YELLOW}$RAW_MSG${NC}"
         echo -e ""
         echo -e "${GREEN}Remove AI attribution. You are the sole author.${NC}"
         echo -e ""
@@ -70,5 +147,4 @@ for pattern in "${AI_PATTERNS[@]}"; do
     fi
 done
 
-# Mensaje OK
 exit 0

package/ci-local/hooks/commit-msg.test.sh

@@ -0,0 +1,286 @@
+#!/bin/bash
+# =============================================================================
+# COMMIT-MSG TEST SUITE
+# =============================================================================
+# Valida que el hook commit-msg bloquea AI attribution en TODAS las variantes
+# conocidas, incluyendo bypasses identificados en auditoría 2026-05-17.
+#
+# Uso:
+#   ./commit-msg.test.sh
+#
+# Exit code 0 = todos los tests pasan
+# Exit code 1 = al menos un test falla
+# =============================================================================
+
+set -u
+
+SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
+HOOK="$SCRIPT_DIR/commit-msg"
+
+if [ ! -x "$HOOK" ]; then
+    echo "ERROR: commit-msg hook not found or not executable: $HOOK"
+    exit 1
+fi
+
+PASS=0
+FAIL=0
+FAILED_TESTS=()
+
+# Garantiza limpieza de tmpfiles aún si el hook revienta con set -u, etc.
+TMP_FILES=()
+cleanup() {
+    if [ ${#TMP_FILES[@]} -gt 0 ]; then
+        rm -f "${TMP_FILES[@]}"
+    fi
+}
+trap cleanup EXIT INT TERM
+
+make_tmp() {
+    local f
+    f=$(mktemp)
+    TMP_FILES+=("$f")
+    printf "%s" "$1" > "$f"
+    printf "%s" "$f"
+}
+
+# expect_block <description> <message>
+# El hook debe BLOQUEAR este mensaje (exit != 0)
+expect_block() {
+    local desc="$1"
+    local msg="$2"
+    local tmpfile
+    tmpfile=$(make_tmp "$msg")
+    if "$HOOK" "$tmpfile" >/dev/null 2>&1; then
+        FAIL=$((FAIL + 1))
+        FAILED_TESTS+=("[NOT BLOCKED] $desc | msg: '$msg'")
+        echo "  FAIL: $desc (should block but passed): '$msg'"
+    else
+        PASS=$((PASS + 1))
+    fi
+}
+
+# expect_pass <description> <message>
+# El hook debe PERMITIR este mensaje (exit 0)
+expect_pass() {
+    local desc="$1"
+    local msg="$2"
+    local tmpfile
+    tmpfile=$(make_tmp "$msg")
+    if "$HOOK" "$tmpfile" >/dev/null 2>&1; then
+        PASS=$((PASS + 1))
+    else
+        FAIL=$((FAIL + 1))
+        FAILED_TESTS+=("[FALSE POSITIVE] $desc | msg: '$msg'")
+        echo "  FAIL: $desc (should pass but blocked): '$msg'"
+    fi
+}
+
+echo "=== Running commit-msg hook test suite ==="
+echo ""
+
+# ─── Cases que DEBEN bloquear ────────────────────────────────────────
+
+# Co-authored-by con cada proveedor
+expect_block "Co-authored-by Claude" "feat: add foo
+
+Co-authored-by: Claude <claude@anthropic.com>"
+
+expect_block "Co-authored-by claude lowercase" "feat: bar
+
+co-authored-by: claude <c@a.com>"
+
+expect_block "Co-authored-by double space" "feat: baz
+
+Co-authored-by:  Claude <c@a.com>"
+
+expect_block "Co-authored-by GPT" "feat: x
+
+Co-authored-by: GPT-4 <g@o.com>"
+
+expect_block "Co-authored-by Copilot" "feat: y
+
+Co-authored-by: GitHub Copilot <c@gh.com>"
+
+expect_block "Co-authored-by ai standalone" "feat: z
+
+Co-authored-by: AI Assistant <a@b.com>"
+
+# Made/Generated/Written/Created by/with X — single space
+expect_block "Made by Claude" "feat: add Made by Claude"
+expect_block "Made with Claude" "feat: Made with Claude"
+expect_block "Generated by GPT" "feat: Generated by GPT"
+expect_block "Written with OpenAI" "fix: Written with OpenAI"
+expect_block "Created by Anthropic" "feat: Created by Anthropic"
+expect_block "Assisted by AI" "feat: Assisted by AI"
+expect_block "Built with Gemini" "feat: Built with Gemini"
+expect_block "Developed with Copilot" "feat: Developed with Copilot"
+expect_block "Authored by LLM" "feat: Authored by LLM"
+
+# Made/Generated/etc — DOUBLE space (bypass identificado en audit)
+expect_block "Made by  Claude (double space)" "feat: Made by  Claude"
+expect_block "Generated with  GPT (double space)" "fix: Generated with  GPT"
+expect_block "Made by\tClaude (tab)" "$(printf 'feat: Made by\tClaude')"
+
+# With help from X
+expect_block "With help from Claude" "feat: x
+
+With help from Claude"
+expect_block "with help from GPT-4" "feat: with help from GPT-4"
+
+# X-assisted variants (bypass identificado)
+expect_block "anthropic-assisted" "feat: anthropic-assisted refactor"
+expect_block "openai-assisted" "feat: openai-assisted change"
+expect_block "ai-assisted" "feat: ai-assisted commit"
+expect_block "Claude assisted (space)" "feat: Claude assisted work"
+expect_block "LLM_assisted (underscore)" "feat: llm_assisted feature"
+
+# Tool branding
+expect_block "claude code" "feat: built with claude code"
+expect_block "claude-code" "feat: via claude-code"
+expect_block "claude_code" "feat: claude_code generated"
+expect_block "GitHub Copilot" "feat: GitHub Copilot helped"
+expect_block "Microsoft Copilot" "feat: Microsoft Copilot did this"
+
+# Claude model variants (bypass identificado)
+expect_block "claude opus (space)" "feat: claude opus tested"
+expect_block "claude-sonnet (dash)" "feat: claude-sonnet used"
+expect_block "claude_haiku (underscore)" "feat: claude_haiku approach"
+expect_block "Claude3.5" "feat: Claude3.5 wrote this"
+expect_block "claude4.7" "feat: claude4.7 contributed"
+expect_block "Claude 4" "feat: Claude 4 logic"
+
+# GPT model variants
+expect_block "gpt-4" "feat: gpt-4 reviewed"
+expect_block "gpt 5" "feat: gpt 5 wrote"
+expect_block "gpt_3" "feat: gpt_3 helped"
+expect_block "GPT4" "feat: GPT4 was used"
+
+# ChatGPT
+expect_block "ChatGPT" "feat: ChatGPT generated"
+expect_block "chatgpt" "feat: powered by chatgpt"
+
+# Emails
+expect_block "@anthropic.com" "feat: x
+
+Author: foo@anthropic.com"
+expect_block "@openai.com" "feat: y
+
+Co-authored-by: bot@openai.com"
+expect_block "noreply@anthropic" "feat: noreply@anthropic.example"
+
+# ─── Bypasses identificados en review 2026-05-17 (post-hardening) ─────
+
+# Markdown formatting alrededor del proveedor
+expect_block "Made by **Claude** (markdown bold)" "feat: Made by **Claude**"
+expect_block "Made by __GPT__ (markdown italic)" "feat: Made by __GPT__"
+expect_block "Made by \`OpenAI\` (markdown code)" "feat: Made by \`OpenAI\`"
+expect_block "Made by ~~Gemini~~ (strikethrough)" "feat: Made by ~~Gemini~~"
+
+# Puntuación entre verbo y proveedor (no whitespace)
+expect_block "Made by.Claude" "feat: Made by.Claude"
+expect_block "Made by,Claude" "feat: Made by,Claude"
+expect_block "Made by:Claude" "feat: Made by:Claude"
+expect_block "Made by;Claude" "feat: Made by;Claude"
+
+# Newline entre verbo y proveedor
+expect_block "Made by newline Claude" "$(printf 'feat: Made by\nClaude')"
+
+# Emoji separator
+expect_block "Made by emoji Claude" "feat: Made by 🤖 Claude"
+expect_block "Generated by emoji GPT" "feat: Generated by ✨ GPT"
+
+# Unicode invisible chars (ZWSP, RLM, NBSP)
+expect_block "Made by ZWSP Claude" "$(printf 'feat: Made by​Claude')"
+expect_block "Made by NBSP Claude" "$(printf 'feat: Made by Claude')"
+expect_block "Made by RLM Claude" "$(printf 'feat: Made by‏Claude')"
+
+# "thanks/powered by/courtesy of" alternativas
+expect_block "thanks to Claude" "feat: thanks to Claude for help"
+expect_block "powered by GPT" "feat: powered by GPT"
+expect_block "courtesy of OpenAI" "feat: courtesy of OpenAI"
+
+# AI IDEs / herramientas
+expect_block "Cursor IDE" "feat: built with Cursor"
+expect_block "Windsurf" "feat: written with Windsurf"
+expect_block "Codeium" "feat: codeium suggested this"
+expect_block "Cody" "feat: with Cody help"
+expect_block "Aider" "feat: aider generated"
+
+# Co-authored-by sin espacio antes de AI (bypass del review Sonnet)
+expect_block "Co-authored-by AIAssistant" "feat: x
+
+Co-authored-by: AIAssistant <a@b.com>"
+
+# Co-authored-by Copilot standalone (sin GitHub/Microsoft prefix)
+expect_block "Co-authored-by bare Copilot" "feat: x
+
+Co-authored-by: Copilot <c@gh.com>"
+
+# Verbos alternativos
+expect_block "produced by Claude" "feat: produced by Claude"
+expect_block "coded by GPT" "feat: coded by GPT"
+expect_block "crafted with AI" "feat: crafted with AI"
+
+# Using/via como alternativas a by/with
+expect_block "made using Claude" "feat: made using Claude"
+expect_block "generated via GPT" "feat: generated via GPT"
+
+# Full-width characters (NFKC normalization)
+expect_block "Ｍａｄｅ ｂｙ Claude (fullwidth)" "feat: Ｍａｄｅ ｂｙ Claude"
+
+# ─── Bypasses adicionales identificados en audit-2 (2026-05-17 review B) ──
+
+# Combining diacritics (U+0300-U+036F) — Ćlaude = C + U+0301
+expect_block "Ćlaude (combining acute)" "$(printf 'feat: Made by Ćlaude')"
+expect_block "Cláude (combining grave)" "$(printf 'feat: Made by Clàude')"
+
+# Verbos expandidos — sólo aplican si hay (by|with|using|via) después del verbo.
+# "asked Claude to ..." NO bloquea por diseño: el riesgo de false positive en
+# nombres personales o conversaciones legítimas es alto. Si necesitás defensa
+# adversarial usá signed commits.
+expect_block "helped by Claude" "feat: helped by Claude"
+expect_block "wrote with GPT" "feat: wrote with GPT-4"
+expect_block "prompted via AI" "feat: prompted via AI"
+expect_block "fixed by Copilot" "feat: fixed by Copilot"
+expect_block "refactored with Cursor" "feat: refactored with Cursor"
+
+# Cases que DOCUMENTADAMENTE NO bloqueamos (bare provider sin verb-prepositional):
+# - "asked Claude to refactor"  (FP risk: pidió a una persona llamada Claude)
+# - "I used Claude to write"    (FP risk: usé al usuario Claude para escribir)
+# - "claude helped me debug"    (FP risk: Claude la persona ayudó a debuggear)
+# Estos son límites aceptados; ver header del hook.
+expect_pass "asked Claude (person, not attribution)" "feat: asked Claude to review the PR"
+expect_pass "user Claude in seed" "feat: configure user Claude in fixtures"
+
+# ─── Cases que DEBEN PASAR (false positive checks) ────────────────────
+
+expect_pass "Simple feat" "feat: add user profile endpoint"
+expect_pass "Simple fix" "fix: handle empty array in parser"
+expect_pass "Refactor" "refactor: extract auth into middleware"
+expect_pass "Docs" "docs: clarify install instructions"
+expect_pass "Multi-line valid commit" "feat: add search
+
+Implements full-text search using PostgreSQL FTS.
+Includes integration tests."
+expect_pass "Author named Claude (not attribution)" "feat: add user named Claude in seed data"
+expect_pass "AI as acronym in product name" "feat: integrate with PaiAi API gateway"
+expect_pass "Word 'made' without AI context" "feat: changes I made last week to the parser"
+
+# ─── Summary ──────────────────────────────────────────────────────────
+
+echo ""
+echo "=== Results ==="
+echo "  Passed: $PASS"
+echo "  Failed: $FAIL"
+echo ""
+
+if [ $FAIL -gt 0 ]; then
+    echo "Failed tests:"
+    for t in "${FAILED_TESTS[@]}"; do
+        echo "  - $t"
+    done
+    exit 1
+fi
+
+echo "All tests passed."
+exit 0

package/ci-local/hooks/pre-commit

@@ -4,14 +4,22 @@
 # =============================================================================
 # Requires: npm install -g javi-forge
 # To skip:  git commit --no-verify
+# Target:   ~30s. The hook prints elapsed time so drift can be tracked.
 # =============================================================================
 
 set -e
 
+_start=$SECONDS
 echo "PRE-COMMIT: Running quick check..."
 javi-forge ci --quick --no-docker --no-security --no-ci-ghagga || {
+    _elapsed=$((SECONDS - _start))
     echo ""
-    echo "Quick check FAILED — Fix the issues above before committing."
+    echo "Quick check FAILED after ${_elapsed}s — Fix the issues above before committing."
     echo "To skip: git commit --no-verify"
     exit 1
 }
+_elapsed=$((SECONDS - _start))
+echo "PRE-COMMIT: ${_elapsed}s (target: 30s)"
+if [ "$_elapsed" -gt 60 ]; then
+    echo "  WARNING: pre-commit took ${_elapsed}s, well over the 30s target."
+fi