jasmine-browser-runner 1.1.0 → 1.3.0

package/README.md

@@ -185,11 +185,10 @@ active tunnel.
 ## Want more control?
 
 ```javascript
-var path = require('path'),
-  jasmineBrowser = require('jasmine-browser-runner'),
-  jasmineCore = require('../../lib/jasmine-core.js');
+const path = require('path');
+const jasmineBrowser = require('jasmine-browser-runner');
 
-var config = require(path.resolve('spec/support/jasmine-browser.json'));
+const config = require(path.resolve('spec/support/jasmine-browser.json'));
 config.projectBaseDir = path.resolve('some/path');
 
 jasmineBrowser.startServer(config, { port: 4321 });

package/index.js

@@ -4,12 +4,17 @@ const ConsoleReporter = require('./lib/console_reporter'),
   Runner = require('./lib/runner'),
   ModuleLoader = require('./lib/moduleLoader');
 
-async function createReporters(options) {
+async function createReporters(options, deps) {
   const result = [];
 
   if (options.useConsoleReporter !== false) {
-    const consoleReporter = new ConsoleReporter();
-    consoleReporter.setOptions({ color: options.color });
+    deps = deps || {};
+    const ReporterCtor = deps.ConsoleReporter || ConsoleReporter;
+    const consoleReporter = new ReporterCtor();
+    consoleReporter.setOptions({
+      color: options.color,
+      alwaysListPendingSpecs: options.alwaysListPendingSpecs,
+    });
     result.push(consoleReporter);
   }
 
@@ -74,9 +79,22 @@ module.exports = {
     const setExitCode = deps.setExitCode || (code => (process.exitCode = code));
     const server = new ServerClass(options);
 
-    const reporters = await createReporters(options);
+    const reporters = await createReporters(options, deps);
     const useSauce = options.browser && options.browser.useSauce;
-    const portRequest = useSauce ? 5555 : 0;
+    let portRequest;
+
+    if (useSauce) {
+      if (options.port) {
+        throw new Error("Can't specify a port when browser.useSauce is true");
+      }
+
+      portRequest = 5555;
+    } else if (options.port) {
+      portRequest = options.port;
+    } else {
+      portRequest = 0;
+    }
+
     await server.start({ port: portRequest });
 
     try {

package/lib/console_reporter.js

@@ -22,6 +22,7 @@ function ConsoleReporter() {
     failureCount,
     failedSpecs = [],
     pendingSpecs = [],
+    alwaysListPendingSpecs = true,
     ansi = {
       green: '\x1B[32m',
       red: '\x1B[31m',
@@ -61,6 +62,9 @@ function ConsoleReporter() {
     if (options.stackFilter) {
       stackFilter = options.stackFilter;
     }
+    if (options.alwaysListPendingSpecs !== undefined) {
+      alwaysListPendingSpecs = options.alwaysListPendingSpecs;
+    }
   };
 
   this.jasmineStarted = function(options) {
@@ -101,11 +105,13 @@ function ConsoleReporter() {
       suiteFailureDetails(result);
     }
 
-    if (pendingSpecs.length > 0) {
-      print('Pending:');
-    }
-    for (let i = 0; i < pendingSpecs.length; i++) {
-      pendingSpecDetails(pendingSpecs[i], i + 1);
+    if (alwaysListPendingSpecs || result.overallStatus === 'passed') {
+      if (pendingSpecs.length > 0) {
+        print('Pending:');
+      }
+      for (let i = 0; i < pendingSpecs.length; i++) {
+        pendingSpecDetails(pendingSpecs[i], i + 1);
+      }
     }
 
     if (specCount > 0) {

package/lib/server.js

@@ -1,8 +1,9 @@
-var express = require('express'),
+const express = require('express'),
   glob = require('glob'),
   ejs = require('ejs'),
   path = require('path'),
-  fs = require('fs');
+  fs = require('fs'),
+  os = require('os');
 
 /**
  * @class Server
@@ -29,6 +30,28 @@ class Server {
         return unWindows(path.join('/__jasmine__', fileName));
       })
       .concat(this.bootFiles());
+
+    // Validate globs
+    const isWindows = (options.platform || os.platform)() === 'win32';
+    for (const globs of [
+      options.specFiles,
+      options.srcFiles,
+      options.helpers,
+    ]) {
+      if (globs) {
+        for (const g of globs) {
+          if (isWindows && g.includes('\\')) {
+            const fixed = g.replace(/\\/g, '/');
+            console.warn(
+              'Backslashes in file paths behave inconsistently ' +
+                'between platforms and might not be treated as directory ' +
+                'separators in a future version. Consider changing ' +
+                `${g} to ${fixed}.`
+            );
+          }
+        }
+      }
+    }
   }
 
   bootFiles() {

package/lib/types.js

@@ -104,6 +104,13 @@
  * @type boolean | undefined
  * @default true
  */
+/**
+ * Whether the default reporter should list pending specs even if there are
+ * failures.
+ * @name Configuration#alwaysListPendingSpecs
+ * @type boolean | undefined
+ * @default true
+ */
 
 /**
  * Describes a web browser.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jasmine-browser-runner",
-  "version": "1.1.0",
+  "version": "1.3.0",
   "description": "Serve and run your Jasmine specs in a browser",
   "bin": "bin/jasmine-browser-runner",
   "exports": "./index.js",
@@ -17,10 +17,9 @@
     "lib/examples/default_esm_config.json"
   ],
   "scripts": {
-    "posttest": "eslint bin/* lib spec scripts index.js --ignore-path=.styleIgnore && prettier --check --ignore-path=.styleIgnore \"lib/**/*.js\" \"spec/**/*.js\" \"scripts/*.js\" index.js",
+    "posttest": "eslint bin/* lib spec index.js --ignore-path=.styleIgnore && prettier --check --ignore-path=.styleIgnore \"lib/**/*.js\" \"spec/**/*.js\" index.js",
     "test": "jasmine",
-    "cleanup": "prettier --write --ignore-path=.styleIgnore \"lib/**/*.js\" \"spec/**/*.js\" \"scripts/*.js\" index.js",
-    "release": "node scripts/release.js"
+    "cleanup": "prettier --write --ignore-path=.styleIgnore \"lib/**/*.js\" \"spec/**/*.js\" index.js"
   },
   "repository": {
     "type": "git",
@@ -41,7 +40,7 @@
     "ejs": "^3.1.6",
     "express": "^4.16.4",
     "glob": "^7.1.7",
-    "selenium-webdriver": "^4.1.0"
+    "selenium-webdriver": ">=4.1.0 <4.8.0"
   },
   "peerDependencies": {
     "jasmine-core": "^4.0.0"