jackherd 1.17.0 → 1.18.1

package/src/watch/previews.ts

@@ -1,5 +1,5 @@
 import { isRecord } from '../shared/is-record'
-import { type FeedbackTarget, isReadTime } from './feedback'
+import { isReadTime, type LaneFeedbackTarget } from './feedback'
 import { FEEDBACK_FORM, type FeedbackItem } from './feedback-item'
 
 export const PREVIEW_EVENT = 'preview'
@@ -33,7 +33,7 @@ export type PreviewRecord = { reportedHead: string | null; stamps: Record<string
 /** `since` is the epoch milliseconds of the last read, null before the first. */
 export type PreviewState = { since: number | null; pullRequests: Record<string, PreviewRecord> }
 
-export type PreviewRead = { readAt: number; targets: FeedbackTarget[]; candidates: PreviewCandidate[] }
+export type PreviewRead = { readAt: number; targets: LaneFeedbackTarget[]; candidates: PreviewCandidate[] }
 
 /** Which comments name a preview: their authors' logins, and optionally a pattern whose first group is the URL. */
 export type PreviewSettings = { authors: readonly string[]; urlPattern?: string }
@@ -125,7 +125,7 @@ export const previewDeployments = (deployments: readonly Deployment[], deployEnv
 
 /** A deployment of `target`'s head as a candidate once its latest status succeeded with an https URL. */
 export const deploymentCandidate = (
-  target: FeedbackTarget,
+  target: LaneFeedbackTarget,
   id: number,
   status: DeploymentStatus,
 ): PreviewCandidate | null => {
@@ -144,7 +144,7 @@ export const deploymentCandidate = (
 
 export const previewReadOf = (
   readAt: number,
-  targets: FeedbackTarget[],
+  targets: LaneFeedbackTarget[],
   candidates: readonly PreviewCandidate[],
 ): PreviewRead => {
   const numbers = new Set(targets.map(({ number }) => number))
@@ -152,18 +152,18 @@ export const previewReadOf = (
 }
 
 /** A candidate with a URL that may stand for the target's current head: a comment, or a deployment of that head. */
-const isUsable = (candidate: PreviewCandidate, target: FeedbackTarget): boolean =>
+const isUsable = (candidate: PreviewCandidate, target: LaneFeedbackTarget): boolean =>
   candidate.url !== null && (candidate.headCommit === null || candidate.headCommit === target.headCommit)
 
 /** Deployments before comments: a deployment names its commit, a comment does not. */
 const byDeploymentFirst = (a: PreviewCandidate, b: PreviewCandidate): number =>
   Number(a.source !== PREVIEW_SOURCE.deployment) - Number(b.source !== PREVIEW_SOURCE.deployment)
 
-const candidatesOf = (read: PreviewRead, target: FeedbackTarget): PreviewCandidate[] =>
+const candidatesOf = (read: PreviewRead, target: LaneFeedbackTarget): PreviewCandidate[] =>
   read.candidates.filter(({ pullRequest }) => pullRequest === target.number).sort(byDeploymentFirst)
 
 /** The usable candidate that changed since `record`, when the head has had no preview reported yet. */
-const freshPreview = (record: PreviewRecord, target: FeedbackTarget, candidates: readonly PreviewCandidate[]) =>
+const freshPreview = (record: PreviewRecord, target: LaneFeedbackTarget, candidates: readonly PreviewCandidate[]) =>
   target.headCommit === record.reportedHead
     ? undefined
     : candidates.find((candidate) => record.stamps[candidate.key] !== candidate.stamp && isUsable(candidate, target))
@@ -189,7 +189,7 @@ export const previewEvents = (previous: PreviewState, read: PreviewRead): Previe
       : []
   })
 
-const recordOf = (record: PreviewRecord | undefined, target: FeedbackTarget, candidates: PreviewCandidate[]) => {
+const recordOf = (record: PreviewRecord | undefined, target: LaneFeedbackTarget, candidates: PreviewCandidate[]) => {
   const stamps = Object.fromEntries(candidates.map(({ key, stamp }) => [key, stamp]))
   const shown = record
     ? freshPreview(record, target, candidates)
@@ -211,7 +211,7 @@ export const recordPreviews = (previous: PreviewState, read: PreviewRead): Previ
 })
 
 /** The targets whose current head has no preview reported yet; only they need their deployments read. */
-export const unreportedTargets = (state: PreviewState, targets: readonly FeedbackTarget[]): FeedbackTarget[] =>
+export const unreportedTargets = (state: PreviewState, targets: readonly LaneFeedbackTarget[]): LaneFeedbackTarget[] =>
   targets.filter(({ number, headCommit }) => state.pullRequests[String(number)]?.reportedHead !== headCommit)
 
 const isPreviewRecord = (value: unknown): boolean =>