iterate-plugin 3.5.6 → 3.5.7

package/dist/skill-prompt.js

@@ -84,6 +84,9 @@ const rounds = []           // raw per-round findings
 // round where every reviewer subagent failed (or output stayed schema-invalid
 // after retries) is INCONCLUSIVE — it must never make the run look converged.
 let lastRoundOk = true
+// Slot index of the current round within this run's rounds array. A resumed
+// run starts at startRound > 1, so the round NUMBER is not a valid array index.
+let roundSlot = -1
 
 phase('transcript')
 // Read any steering nudge written (via iterate_transcript nudge) for this run's reviewers.
@@ -96,9 +99,14 @@ const steering = transRead && typeof transRead.nudge === 'string' && transRead.n
 phase('review')
 for (let r = 1; r <= maxRounds; r++) {
   log('round ' + r + ' of ' + maxRounds + ' — finding NEW issues only')
+  roundSlot = rounds.length
   let agg = null
   let schemaInvalid = false
   let attempts = 0
+  // Declared OUTSIDE the do-block: it is read after the retry loop exits, and a
+  // block-scoped const here raised ReferenceError at runtime (crashing both
+  // canonical workflows after the first round).
+  let reviewersOk = true
   do {
     attempts += 1
     // Schema validation retry: on the 2nd+ pass, nudge reviewers toward strict JSON.
@@ -126,7 +134,7 @@ for (let r = 1; r <= maxRounds; r++) {
     // the convergence math would then read "0 new findings". An all-failed
     // round is NOT a clean pass — it is inconclusive, so the convergence gate
     // below refuses it before any "converged" signal fires.
-    const reviewersOk = raw.length > 0 ? raw.some(x => x !== null && typeof x === 'object') : true
+    reviewersOk = raw.length > 0 ? raw.some(x => x !== null && typeof x === 'object') : true
     const thisRound = {
       round: r,
       findings: [].concat(...raw.map(x => x && x.findings ? x.findings : [])),
@@ -134,7 +142,7 @@ for (let r = 1; r <= maxRounds; r++) {
       // gate can compare self-reported reads against the assigned inventory.
       readFiles: [].concat(...raw.map(x => x && Array.isArray(x.readFiles) ? x.readFiles : [])),
     }
-    if (rounds.length >= r) rounds[r - 1] = thisRound; else rounds.push(thisRound)
+    if (roundSlot < rounds.length) rounds[roundSlot] = thisRound; else rounds.push(thisRound)
     // Deterministic aggregate: cross-round dedupe + known_intentional filter + severity sort.
     agg = await agent(
       'Call iterate_review({operation:"aggregate", mode:"dry-run", rounds:' + JSON.stringify(rounds) + ', maxReviewRounds:' + maxRounds + ', knownIntentional:' + JSON.stringify(knownIntentional) + '}) and return the report JSON.',
@@ -299,6 +307,12 @@ let schemaFailed = false        // last round produced no usable reviewer output
 let failedCommands = []
 let configErrors = []          // validation commands NOT in validation.commands (config gap, no rollback)
 const fixRecords = []        // observatory fix records collected round by round
+// Slot index of the current round within this run's rounds array. A resumed
+// run starts at startRound > 1, so the round NUMBER is not a valid array index.
+let roundSlot = -1
+// Highest round number actually executed by THIS run (carried so a resumed run
+// reports its true round, not the count of rounds it happened to run).
+let lastRound = startRound - 1
 
 // Read any steering nudge intended for this run's reviewers.
 const transRead = await agent(
@@ -310,6 +324,8 @@ const steering = transRead && typeof transRead.nudge === 'string' && transRead.n
 phase('loop')
 for (let r = startRound; r <= maxRounds; r++) {
   log('round ' + r + ' of ' + maxRounds + ' — review current state, fix atomics via iterate_fix, validate')
+  roundSlot = rounds.length
+  lastRound = r
   // Audit-trail: record the round start (SKILL.md Phase 4 requires per-round records).
   await agent(
     'Call iterate_decision_log({operation:"append", type:"round_start", round:' + r + ', data:{maxRounds:' + maxRounds + ', fixedSoFar:' + fixedCount + '}})',
@@ -318,6 +334,10 @@ for (let r = startRound; r <= maxRounds; r++) {
   let agg = null
   let schemaInvalid = false
   let attempts = 0
+  // Declared OUTSIDE the do-block: it is read after the retry loop exits, and a
+  // block-scoped const here raised ReferenceError at runtime (crashing both
+  // canonical workflows after the first round).
+  let reviewersOk = true
   do {
     attempts += 1
     // Schema validation retry: on the 2nd+ pass, nudge reviewers toward strict JSON.
@@ -341,13 +361,13 @@ for (let r = startRound; r <= maxRounds; r++) {
     // ALL reviewers returning null (child failures) means this round produced
     // no usable output — an empty aggregate must not read like a clean
     // "nothing to fix" convergence. Gate the loop exit + convergence on it.
-    const reviewersOk = raw.length > 0 ? raw.some(x => x !== null && typeof x === 'object') : true
+    reviewersOk = raw.length > 0 ? raw.some(x => x !== null && typeof x === 'object') : true
     const thisRound = {
       round: r,
       findings: [].concat(...raw.map(x => x && x.findings ? x.findings : [])),
       readFiles: [].concat(...raw.map(x => x && Array.isArray(x.readFiles) ? x.readFiles : [])),
     }
-    if (rounds.length >= r) rounds[r - 1] = thisRound; else rounds.push(thisRound)
+    if (roundSlot < rounds.length) rounds[roundSlot] = thisRound; else rounds.push(thisRound)
 
     // Deterministic dedupe / known_intentional filter / severity sort for this round.
     // \`fixedCount\` is threaded into the report summary so the client dashboard can
@@ -502,7 +522,7 @@ for (let r = startRound; r <= maxRounds; r++) {
 
 phase('report')
 await agent(
-  'Call iterate_decision_log({operation:"append", type:"report", round:' + rounds.length +
+  'Call iterate_decision_log({operation:"append", type:"report", round:' + lastRound +
   ', data:{mode:"normal", fixed:' + fixedCount + ', architectural:' + architectural.length + '}})',
   { label: 'report:log' }
 )
@@ -525,7 +545,7 @@ if (!abortedByValidation && !schemaFailed) {
   // would hide the very thing F5 is meant to resume. Reflect what is on disk.
   const obsCheckpoint = {
     mode: 'normal',
-    round: rounds.length,
+    round: lastRound,
     maxRounds: maxRounds,
     fixedCount: fixedCount,
     resumeCount: effectiveResumeCount,
@@ -536,13 +556,13 @@ if (!abortedByValidation && !schemaFailed) {
       ? (configErrors.length > 0 ? 'aborted_by_config' : 'aborted_by_validation')
       : (converged ? 'converged' : 'max_rounds_reached')
   await agent(
-    'Call iterate_transcript({operation:"capture", mode:"normal", goal:' + JSON.stringify(plan.goal) + ', maxRounds:' + maxRounds + ', roundsExecuted:' + rounds.length + ', findingsByRound:' + JSON.stringify(rounds.map(rr => (rr.findings && rr.findings.length) ? rr.findings.length : 0)) + ', stoppedReason:"' + stopReason + '", fixes:' + JSON.stringify(fixRecords) + ', checkpoint:' + JSON.stringify(obsCheckpoint) + ', rounds:' + JSON.stringify(rounds.map(rr => ({ round: rr.round, findings: rr.findings, readFiles: rr.readFiles }))) + '}). Return {operation:"ok"}.',
+    'Call iterate_transcript({operation:"capture", mode:"normal", goal:' + JSON.stringify(plan.goal) + ', maxRounds:' + maxRounds + ', roundsExecuted:' + lastRound + ', findingsByRound:' + JSON.stringify(rounds.map(rr => (rr.findings && rr.findings.length) ? rr.findings.length : 0)) + ', stoppedReason:"' + stopReason + '", fixes:' + JSON.stringify(fixRecords) + ', checkpoint:' + JSON.stringify(obsCheckpoint) + ', rounds:' + JSON.stringify(rounds.map(rr => ({ round: rr.round, findings: rr.findings, readFiles: rr.readFiles }))) + '}). Return {operation:"ok"}.',
     { label: 'transcript:capture' }
   )
 return {
   mode: 'normal',
   goal: plan.goal,
-  roundsExecuted: rounds.length,
+  roundsExecuted: lastRound,
   maxRounds: maxRounds,
   converged: converged,
   abortedByValidation: abortedByValidation,

package/dist/tools/decision-log.js

@@ -122,6 +122,17 @@ function recountEntries(filePath) {
         return 1;
     }
 }
+/**
+ * Drop the cached entry count for a log file. The cache is keyed by the log
+ * path and assumes "same byte size ⇒ same entry count"; a prune rewrite
+ * (temp + atomic rename) replaces the file with a DIFFERENT number of entries,
+ * so only a stale-cache invalidation keeps the fast path honest. Without it, a
+ * rewrite that lands on the exact same byte size as the previous append would
+ * make the next append report a wrong `count`.
+ */
+export function invalidateLogCountCache(filePath) {
+    entryCountCache.delete(filePath);
+}
 /** All valid DecisionLogEntry `type` values (must stay in sync with Types). */
 const VALID_ENTRY_TYPES = new Set([
     'round_start',

package/dist/tools/prune.js

@@ -28,7 +28,7 @@ import { join } from 'node:path';
 import { defineTool } from '@deepseek-ai/dsh-tools';
 import { resolveProjectRootForExec } from "../config-loader.js";
 import { writeTextAtomic, writeJsonAtomic } from "../atomic-fs.js";
-import { readDecisionEntries, appendDecisionEntry, acquireLogLock } from "./decision-log.js";
+import { readDecisionEntries, appendDecisionEntry, acquireLogLock, invalidateLogCountCache } from "./decision-log.js";
 import { readRegistry, recomputeRoundCounts } from "./fix.js";
 import { readExperienceBank, writeExperienceBank } from "./experience-store.js";
 import { readDefenseEvents, writeDefenseEvents } from "./defense-store.js";
@@ -263,6 +263,12 @@ function rewriteDecisionLogKeepingRecent(projectRoot, cutoff) {
                 if (deleted === 0)
                     return { deleted: 0 };
                 writeTextAtomic(logPath, kept.map((e) => JSON.stringify(e)).join('\n') + '\n');
+                // The append-side entry-count cache is keyed by path and assumes "same
+                // byte size ⇒ same count"; the rename above replaced the file with a
+                // different number of entries, so drop the stale cache or the next
+                // append can report a wrong entryCount when the sizes coincidentally
+                // match.
+                invalidateLogCountCache(logPath);
                 // A concurrent appender (cross-process, lock-unavailable path) may have
                 // landed new lines after our read. If the log grew during the write
                 // window, re-read and prune again instead of accepting a lost audit trail.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "iterate-plugin",
-  "version": "3.5.6",
+  "version": "3.5.7",
   "description": "dsh plugin that turns the iterate skill into an autonomous closed-loop harness with quality command center and experience bank (v3.3). Features: plan -> parallel review xN -> atomic fixes -> validate -> loop -> auto-stop, plus dry-run pure-review mode, quality gate compute/persist, writable experience bank, defense events stream (record + bilingual labels), and native command buttons — with a live quality command center (F8/F9/F10 render real session data), §8 assign-fix instruction, and task_mode indicator wired end to end.",
   "type": "module",
   "license": "MIT",
@@ -42,7 +42,8 @@
         "0.1.6-alpha.2": "compatible",
         "0.1.7-alpha.1": "compatible",
         "0.1.7-alpha.2": "compatible",
-        "0.1.7-rc.1": "compatible"
+        "0.1.7-rc.1": "compatible",
+        "0.1.7-rc.2": "compatible"
       }
     },
     "client": {
@@ -80,14 +81,14 @@
   },
   "dependencies": {
     "@deepseek-ai/cordis": "4.0.4",
-    "@deepseek-ai/dsh-tools": "0.1.7-rc.1",
-    "@deepseek-ai/dsh-util-values": "0.1.7-rc.1",
+    "@deepseek-ai/dsh-tools": "0.1.7-rc.2",
+    "@deepseek-ai/dsh-util-values": "0.1.7-rc.2",
     "js-yaml": "4.3.2"
   },
   "devDependencies": {
-    "@deepseek-ai/dsh-agent": "0.1.7-rc.1",
-    "@deepseek-ai/dsh-jobs": "0.1.7-rc.1",
-    "@deepseek-ai/dsh-session": "0.1.7-rc.1",
+    "@deepseek-ai/dsh-agent": "0.1.7-rc.2",
+    "@deepseek-ai/dsh-jobs": "0.1.7-rc.2",
+    "@deepseek-ai/dsh-session": "0.1.7-rc.2",
     "@types/js-yaml": "4.0.9",
     "@types/node": "22.15.0",
     "@types/react": "19.2.2",

package/src/skill-prompt.ts

@@ -85,6 +85,9 @@ const rounds = []           // raw per-round findings
 // round where every reviewer subagent failed (or output stayed schema-invalid
 // after retries) is INCONCLUSIVE — it must never make the run look converged.
 let lastRoundOk = true
+// Slot index of the current round within this run's rounds array. A resumed
+// run starts at startRound > 1, so the round NUMBER is not a valid array index.
+let roundSlot = -1
 
 phase('transcript')
 // Read any steering nudge written (via iterate_transcript nudge) for this run's reviewers.
@@ -97,9 +100,14 @@ const steering = transRead && typeof transRead.nudge === 'string' && transRead.n
 phase('review')
 for (let r = 1; r <= maxRounds; r++) {
   log('round ' + r + ' of ' + maxRounds + ' — finding NEW issues only')
+  roundSlot = rounds.length
   let agg = null
   let schemaInvalid = false
   let attempts = 0
+  // Declared OUTSIDE the do-block: it is read after the retry loop exits, and a
+  // block-scoped const here raised ReferenceError at runtime (crashing both
+  // canonical workflows after the first round).
+  let reviewersOk = true
   do {
     attempts += 1
     // Schema validation retry: on the 2nd+ pass, nudge reviewers toward strict JSON.
@@ -127,7 +135,7 @@ for (let r = 1; r <= maxRounds; r++) {
     // the convergence math would then read "0 new findings". An all-failed
     // round is NOT a clean pass — it is inconclusive, so the convergence gate
     // below refuses it before any "converged" signal fires.
-    const reviewersOk = raw.length > 0 ? raw.some(x => x !== null && typeof x === 'object') : true
+    reviewersOk = raw.length > 0 ? raw.some(x => x !== null && typeof x === 'object') : true
     const thisRound = {
       round: r,
       findings: [].concat(...raw.map(x => x && x.findings ? x.findings : [])),
@@ -135,7 +143,7 @@ for (let r = 1; r <= maxRounds; r++) {
       // gate can compare self-reported reads against the assigned inventory.
       readFiles: [].concat(...raw.map(x => x && Array.isArray(x.readFiles) ? x.readFiles : [])),
     }
-    if (rounds.length >= r) rounds[r - 1] = thisRound; else rounds.push(thisRound)
+    if (roundSlot < rounds.length) rounds[roundSlot] = thisRound; else rounds.push(thisRound)
     // Deterministic aggregate: cross-round dedupe + known_intentional filter + severity sort.
     agg = await agent(
       'Call iterate_review({operation:"aggregate", mode:"dry-run", rounds:' + JSON.stringify(rounds) + ', maxReviewRounds:' + maxRounds + ', knownIntentional:' + JSON.stringify(knownIntentional) + '}) and return the report JSON.',
@@ -300,6 +308,12 @@ let schemaFailed = false        // last round produced no usable reviewer output
 let failedCommands = []
 let configErrors = []          // validation commands NOT in validation.commands (config gap, no rollback)
 const fixRecords = []        // observatory fix records collected round by round
+// Slot index of the current round within this run's rounds array. A resumed
+// run starts at startRound > 1, so the round NUMBER is not a valid array index.
+let roundSlot = -1
+// Highest round number actually executed by THIS run (carried so a resumed run
+// reports its true round, not the count of rounds it happened to run).
+let lastRound = startRound - 1
 
 // Read any steering nudge intended for this run's reviewers.
 const transRead = await agent(
@@ -311,6 +325,8 @@ const steering = transRead && typeof transRead.nudge === 'string' && transRead.n
 phase('loop')
 for (let r = startRound; r <= maxRounds; r++) {
   log('round ' + r + ' of ' + maxRounds + ' — review current state, fix atomics via iterate_fix, validate')
+  roundSlot = rounds.length
+  lastRound = r
   // Audit-trail: record the round start (SKILL.md Phase 4 requires per-round records).
   await agent(
     'Call iterate_decision_log({operation:"append", type:"round_start", round:' + r + ', data:{maxRounds:' + maxRounds + ', fixedSoFar:' + fixedCount + '}})',
@@ -319,6 +335,10 @@ for (let r = startRound; r <= maxRounds; r++) {
   let agg = null
   let schemaInvalid = false
   let attempts = 0
+  // Declared OUTSIDE the do-block: it is read after the retry loop exits, and a
+  // block-scoped const here raised ReferenceError at runtime (crashing both
+  // canonical workflows after the first round).
+  let reviewersOk = true
   do {
     attempts += 1
     // Schema validation retry: on the 2nd+ pass, nudge reviewers toward strict JSON.
@@ -342,13 +362,13 @@ for (let r = startRound; r <= maxRounds; r++) {
     // ALL reviewers returning null (child failures) means this round produced
     // no usable output — an empty aggregate must not read like a clean
     // "nothing to fix" convergence. Gate the loop exit + convergence on it.
-    const reviewersOk = raw.length > 0 ? raw.some(x => x !== null && typeof x === 'object') : true
+    reviewersOk = raw.length > 0 ? raw.some(x => x !== null && typeof x === 'object') : true
     const thisRound = {
       round: r,
       findings: [].concat(...raw.map(x => x && x.findings ? x.findings : [])),
       readFiles: [].concat(...raw.map(x => x && Array.isArray(x.readFiles) ? x.readFiles : [])),
     }
-    if (rounds.length >= r) rounds[r - 1] = thisRound; else rounds.push(thisRound)
+    if (roundSlot < rounds.length) rounds[roundSlot] = thisRound; else rounds.push(thisRound)
 
     // Deterministic dedupe / known_intentional filter / severity sort for this round.
     // \`fixedCount\` is threaded into the report summary so the client dashboard can
@@ -503,7 +523,7 @@ for (let r = startRound; r <= maxRounds; r++) {
 
 phase('report')
 await agent(
-  'Call iterate_decision_log({operation:"append", type:"report", round:' + rounds.length +
+  'Call iterate_decision_log({operation:"append", type:"report", round:' + lastRound +
   ', data:{mode:"normal", fixed:' + fixedCount + ', architectural:' + architectural.length + '}})',
   { label: 'report:log' }
 )
@@ -526,7 +546,7 @@ if (!abortedByValidation && !schemaFailed) {
   // would hide the very thing F5 is meant to resume. Reflect what is on disk.
   const obsCheckpoint = {
     mode: 'normal',
-    round: rounds.length,
+    round: lastRound,
     maxRounds: maxRounds,
     fixedCount: fixedCount,
     resumeCount: effectiveResumeCount,
@@ -537,13 +557,13 @@ if (!abortedByValidation && !schemaFailed) {
       ? (configErrors.length > 0 ? 'aborted_by_config' : 'aborted_by_validation')
       : (converged ? 'converged' : 'max_rounds_reached')
   await agent(
-    'Call iterate_transcript({operation:"capture", mode:"normal", goal:' + JSON.stringify(plan.goal) + ', maxRounds:' + maxRounds + ', roundsExecuted:' + rounds.length + ', findingsByRound:' + JSON.stringify(rounds.map(rr => (rr.findings && rr.findings.length) ? rr.findings.length : 0)) + ', stoppedReason:"' + stopReason + '", fixes:' + JSON.stringify(fixRecords) + ', checkpoint:' + JSON.stringify(obsCheckpoint) + ', rounds:' + JSON.stringify(rounds.map(rr => ({ round: rr.round, findings: rr.findings, readFiles: rr.readFiles }))) + '}). Return {operation:"ok"}.',
+    'Call iterate_transcript({operation:"capture", mode:"normal", goal:' + JSON.stringify(plan.goal) + ', maxRounds:' + maxRounds + ', roundsExecuted:' + lastRound + ', findingsByRound:' + JSON.stringify(rounds.map(rr => (rr.findings && rr.findings.length) ? rr.findings.length : 0)) + ', stoppedReason:"' + stopReason + '", fixes:' + JSON.stringify(fixRecords) + ', checkpoint:' + JSON.stringify(obsCheckpoint) + ', rounds:' + JSON.stringify(rounds.map(rr => ({ round: rr.round, findings: rr.findings, readFiles: rr.readFiles }))) + '}). Return {operation:"ok"}.',
     { label: 'transcript:capture' }
   )
 return {
   mode: 'normal',
   goal: plan.goal,
-  roundsExecuted: rounds.length,
+  roundsExecuted: lastRound,
   maxRounds: maxRounds,
   converged: converged,
   abortedByValidation: abortedByValidation,

package/src/tools/decision-log.ts

@@ -121,6 +121,18 @@ function recountEntries(filePath: string): number {
   }
 }
 
+/**
+ * Drop the cached entry count for a log file. The cache is keyed by the log
+ * path and assumes "same byte size ⇒ same entry count"; a prune rewrite
+ * (temp + atomic rename) replaces the file with a DIFFERENT number of entries,
+ * so only a stale-cache invalidation keeps the fast path honest. Without it, a
+ * rewrite that lands on the exact same byte size as the previous append would
+ * make the next append report a wrong `count`.
+ */
+export function invalidateLogCountCache(filePath: string): void {
+  entryCountCache.delete(filePath)
+}
+
 /** All valid DecisionLogEntry `type` values (must stay in sync with Types). */
 const VALID_ENTRY_TYPES = new Set<DecisionLogEntry['type']>([
   'round_start',

package/src/tools/prune.ts

@@ -30,7 +30,7 @@ import { defineTool } from '@deepseek-ai/dsh-tools'
 import type { JsonValue } from '@deepseek-ai/dsh-util-values'
 import { resolveProjectRootForExec } from '../config-loader.ts'
 import { writeTextAtomic, writeJsonAtomic } from '../atomic-fs.ts'
-import { readDecisionEntries, appendDecisionEntry, acquireLogLock } from './decision-log.ts'
+import { readDecisionEntries, appendDecisionEntry, acquireLogLock, invalidateLogCountCache } from './decision-log.ts'
 import { readRegistry, removeRecord, recomputeRoundCounts } from './fix.ts'
 import { readExperienceBank, writeExperienceBank } from './experience-store.ts'
 import { readDefenseEvents, writeDefenseEvents } from './defense-store.ts'
@@ -291,6 +291,12 @@ function rewriteDecisionLogKeepingRecent(projectRoot: string, cutoff: string): {
         const deleted = entries.length - kept.length
         if (deleted === 0) return { deleted: 0 }
         writeTextAtomic(logPath, kept.map((e) => JSON.stringify(e)).join('\n') + '\n')
+        // The append-side entry-count cache is keyed by path and assumes "same
+        // byte size ⇒ same count"; the rename above replaced the file with a
+        // different number of entries, so drop the stale cache or the next
+        // append can report a wrong entryCount when the sizes coincidentally
+        // match.
+        invalidateLogCountCache(logPath)
         // A concurrent appender (cross-process, lock-unavailable path) may have
         // landed new lines after our read. If the log grew during the write
         // window, re-read and prune again instead of accepting a lost audit trail.