iterate-plugin 3.5.1 → 3.5.3

package/src/tools/checkpoint.ts

@@ -24,16 +24,41 @@ import type { DefenseEventType, IterationCheckpoint, IterationStatus, QualityGat
 
 // ─── Pure helpers (exported for unit tests) ─────────────────────────────────
 
+/** Max findings persisted in a checkpoint (a model-authored findings payload is
+ *  bounded, mirroring MAX_FIX_CONTENT_CHARS for fix content). */
+export const MAX_CHECKPOINT_FINDINGS = 1000
+
 /** Read the current checkpoint from disk (missing/corrupt → null). */
 export function readCheckpoint(projectRoot: string): IterationCheckpoint | null {
   const file = checkpointPath(projectRoot)
   if (!existsSync(file)) return null
   try {
-    const parsed = JSON.parse(readFileSync(file, 'utf-8')) as IterationCheckpoint
+    const parsed = JSON.parse(readFileSync(file, 'utf-8')) as Partial<IterationCheckpoint>
     if (!parsed || typeof parsed !== 'object') return null
     if (parsed.mode !== 'dry-run' && parsed.mode !== 'normal') return null
-    if (typeof parsed.round !== 'number') return null
-    return parsed
+    // Strict round gate: non-numeric (incl. NaN — `NaN <= 0` is false and
+    // `NaN < 0` also false) round values must not survive into the status.
+    const round =
+      typeof parsed.round === 'number' && Number.isFinite(parsed.round)
+        ? Math.floor(parsed.round)
+        : null
+    if (round === null || round < 0) return null
+    const num = (v: unknown, fallback: number): number =>
+      typeof v === 'number' && Number.isFinite(v) ? v : fallback
+    // Normalize every field so a hand-edited/corrupt checkpoint (string
+    // maxRounds, missing fixedCount, …) can never leak a non-numeric value
+    // into the status output or crash a consumer.
+    return {
+      mode: parsed.mode,
+      round,
+      maxRounds: num(parsed.maxRounds, round),
+      fixedCount: num(parsed.fixedCount, 0),
+      architecturalCount: num(parsed.architecturalCount, 0),
+      resumeCount: num(parsed.resumeCount, 0),
+      findings: Array.isArray(parsed.findings) ? (parsed.findings as IterationCheckpoint['findings']) : [],
+      startedAt: typeof parsed.startedAt === 'string' ? parsed.startedAt : new Date().toISOString(),
+      updatedAt: typeof parsed.updatedAt === 'string' ? parsed.updatedAt : new Date().toISOString(),
+    }
   } catch {
     return null
   }
@@ -82,6 +107,17 @@ export function validateCheckpoint(input: {
   ) {
     return 'resumeCount must be a non-negative integer'
   }
+  // A round that claims to be past the configured cap is an inconsistent save —
+  // the status would render `Round X / Y` with X > Y, which is never legitimate
+  // for a resumed run (resume continues AT the checkpoint, it does not exceed
+  // the cap).
+  if (
+    typeof input.round === 'number' &&
+    typeof input.maxRounds === 'number' &&
+    input.round > input.maxRounds
+  ) {
+    return 'round must not exceed maxRounds'
+  }
   return null
 }
 
@@ -118,8 +154,11 @@ export function computeStatus(input: {
   }
 
   const totalRounds = checkpoint?.maxRounds ?? currentRound
-  const registryFixed = registry.rounds.reduce((sum, r) => sum + r.fixedCount, 0)
-  const failedCount = registry.rounds.reduce((sum, r) => sum + r.failedCount, 0)
+  // Coerce the registry's per-round counts defensively: a hand-edited registry
+  // round missing fixedCount/failedCount would otherwise feed NaN into the
+  // status integer fields.
+  const registryFixed = registry.rounds.reduce((sum, r) => sum + (Number(r.fixedCount) || 0), 0)
+  const failedCount = registry.rounds.reduce((sum, r) => sum + (Number(r.failedCount) || 0), 0)
   // When a checkpoint exists, its snapshot fields are authoritative for resume
   // (fixedCount / architecturalCount / findings); otherwise derive from the
   // live fix registry and decision log.
@@ -258,7 +297,7 @@ export function registerCheckpointTool(ctx: { tools: { register: (def: ReturnTyp
             fixedCount: args.fixedCount as number,
             architecturalCount: args.architecturalCount as number,
             resumeCount: (typeof args.resumeCount === 'number' ? args.resumeCount : 0),
-            findings: (Array.isArray(args.findings) ? args.findings : []) as unknown as IterationCheckpoint['findings'],
+            findings: (Array.isArray(args.findings) ? args.findings.slice(0, MAX_CHECKPOINT_FINDINGS) : []) as unknown as IterationCheckpoint['findings'],
             startedAt: readCheckpoint(projectRoot)?.startedAt ?? new Date().toISOString(),
             updatedAt: new Date().toISOString(),
           }

package/src/tools/config.ts

@@ -1,7 +1,8 @@
 import { join } from 'node:path'
+import { existsSync } from 'node:fs'
 import { defineTool } from '@deepseek-ai/dsh-tools'
 import type { JsonValue } from '@deepseek-ai/dsh-util-values'
-import { loadEffectiveConfig, validateConfig, resolveProjectRootForExec } from '../config-loader.ts'
+import { defaultConfig, loadEffectiveConfig, validateConfig, resolveProjectRootForExec } from '../config-loader.ts'
 import {
   applyConfigUpdates,
   readRawConfig,
@@ -106,7 +107,15 @@ export function registerConfigTool(ctx: { tools: { register: (def: ReturnType<ty
           }
           let base: Record<string, unknown>
           try {
-            base = readRawConfig(join(projectRoot, 'iterate.config.yaml'))
+            // Partial updates must be mergeable on a FRESH project (no config
+            // file yet): otherwise `{max_rounds: 5}` alone fails schema
+            // validation with a misleading "missing goal". Merge against the
+            // built-in defaults when there is no file to read, so the written
+            // config captures the effective config (defaults + update) and the
+            // documented "write a partial update" contract works out of the box.
+            base = existsSync(join(projectRoot, 'iterate.config.yaml'))
+              ? readRawConfig(join(projectRoot, 'iterate.config.yaml'))
+              : (defaultConfig() as unknown as Record<string, unknown>)
           } catch (err) {
             return { operation: 'write', ok: false, found: false, error: `failed to read config: ${String(err)}` }
           }

package/src/tools/context.ts

@@ -1,5 +1,5 @@
-import { readFileSync, existsSync, statSync } from 'node:fs'
-import { join, dirname, resolve } from 'node:path'
+import { readFileSync, existsSync, realpathSync, statSync } from 'node:fs'
+import { join, dirname, resolve, sep } from 'node:path'
 import { fileURLToPath } from 'node:url'
 import { defineTool } from '@deepseek-ai/dsh-tools'
 import { resolveProjectRootForExec } from '../config-loader.ts'
@@ -7,6 +7,33 @@ import { resolveProjectRootForExec } from '../config-loader.ts'
 /** How many ancestor directories we walk up looking for a SKILL.md. */
 const MAX_SKILL_DIR_LOOKUP_DEPTH = 12
 
+/**
+ * Whether a model-supplied `skillDir` may be used as a SKILL.md search root.
+ *
+ * `skillDir` is model-controlled, so it is only honored when it is an existing
+ * directory whose REAL path (symlinks resolved) sits inside one of the allowed
+ * roots (the project root or the plugin directory). Anything else — a path
+ * outside the allowed roots, a nonexistent dir, or a symlink pointing outside
+ * (e.g. at `/etc`) — is rejected so arbitrary file contents can never be
+ * injected wholesale into the review context.
+ */
+export function isAllowedSkillDir(skillDir: string, allowedRoots: readonly string[]): boolean {
+  if (typeof skillDir !== 'string' || skillDir.trim().length === 0) return false
+  try {
+    const dir = resolve(skillDir)
+    if (!existsSync(dir) || !statSync(dir).isDirectory()) return false
+    return allowedRoots.some((root) => {
+      if (typeof root !== 'string' || root.length === 0) return false
+      const rootReal = realpathSync(root)
+      const rootPrefix = rootReal.endsWith(sep) ? rootReal : rootReal + sep
+      const real = realpathSync(dir)
+      return real === rootReal || real.startsWith(rootPrefix)
+    })
+  } catch {
+    return false
+  }
+}
+
 /** Maximum number of image attachments relayed into the context in one call. */
 const MAX_ATTACHMENTS = 8
 
@@ -304,8 +331,13 @@ export function registerContextTool(ctx: { tools: { register: (def: ReturnType<t
           // the auto-detected root / project root.
           if (typeof args.skillDir === 'string' && args.skillDir.trim()) {
             try {
-              const dir = resolve(args.skillDir)
-              if (existsSync(dir) && statSync(dir).isDirectory()) candidates.push(dir)
+              // Model-controlled path: only honor it when its REAL path stays
+              // inside the project root or the plugin directory — never let a
+              // skillDir point at arbitrary filesystem locations (e.g. /etc)
+              // whose contents would be injected wholesale into the context.
+              if (isAllowedSkillDir(args.skillDir, [projectRoot, PLUGIN_SRC_DIR])) {
+                candidates.push(resolve(args.skillDir))
+              }
             } catch {
               // unreadable/invalid skillDir — skip it
             }

package/src/tools/decision-log.ts

@@ -106,7 +106,16 @@ export function readDecisionLogDetailed(projectRoot: string): DecisionLogRead {
     const trimmed = line.trim()
     if (trimmed.length === 0) continue
     try {
-      entries.push(JSON.parse(trimmed) as DecisionLogEntry)
+      const parsed: unknown = JSON.parse(trimmed)
+      if (
+        parsed === null || typeof parsed !== 'object' ||
+        typeof (parsed as { timestamp?: unknown }).timestamp !== 'string' ||
+        typeof (parsed as { type?: unknown }).type !== 'string'
+      ) {
+        invalidLines += 1
+        continue
+      }
+      entries.push(parsed as DecisionLogEntry)
     } catch {
       invalidLines += 1
     }

package/src/tools/defense-events.ts

@@ -12,7 +12,7 @@
 import { defineTool } from '@deepseek-ai/dsh-tools'
 import type { JsonValue } from '@deepseek-ai/dsh-util-values'
 import { resolveProjectRootForExec, loadEffectiveConfig } from '../config-loader.ts'
-import { readDefenseEvents, writeDefenseEvents, addDefenseEvent } from './defense-store.ts'
+import { readDefenseEvents, writeDefenseEvents, addDefenseEvent, clearDefenseEvents } from './defense-store.ts'
 import type { DefenseEvent, DefenseEventType } from '../types.ts'
 
 const DEFAULT_LIMIT = 50
@@ -95,16 +95,18 @@ export function registerDefenseEventsTool(ctx: { tools: { register: (def: Return
       // join a parallel dispatch group.
       isConcurrencySafe: (args) => (args as { operation?: unknown }).operation !== 'record',
       description:
-        'Query or record defense events: precondition failures, rollbacks, invariant violations, ' +
+        'Query, record, or clear defense events: precondition failures, rollbacks, invariant violations, ' +
         'and assumption falsifications. ' +
         'List/counts return events with descriptions, outcomes, and summary counts; ' +
-        '"record" persists a new event to .iterate/defense-events.json. ' +
+        '"record" persists a new event to .iterate/defense-events.json; ' +
+        '"clear" resets the persisted event stream (use it to start a fresh iteration without stale ' +
+        'defense data). ' +
         'Use it to review defensive actions taken, or to log one when a defense fires.',
       parameters: {
         operation: {
           type: 'string',
-          description: 'Operation: list (browse all), counts (summary by type), record (log a new event). Default: list.',
-          enum: ['list', 'counts', 'record'],
+          description: 'Operation: list (browse all), counts (summary by type), record (log a new event), clear (reset the stream). Default: list.',
+          enum: ['list', 'counts', 'record', 'clear'],
         },
         type: {
           type: 'string',
@@ -162,6 +164,7 @@ export function registerDefenseEventsTool(ctx: { tools: { register: (def: Return
             kind: { type: 'string' },
             operation: { type: 'string' },
             count: { type: 'integer' },
+            counted: { type: 'boolean', description: 'clear only: true when a persisted stream was removed.' },
             events: { type: 'json' },
             counts: { type: 'json' },
             event: { type: 'json' },
@@ -174,6 +177,17 @@ export function registerDefenseEventsTool(ctx: { tools: { register: (def: Return
           if (!value.ok) return [{ type: 'text', text: `defense events query failed: ${value.error}` }]
           const language: 'zh' | 'en' = value.language === 'zh' ? 'zh' : 'en'
 
+          if (value.operation === 'clear') {
+            // Fresh stream: counts are all zero and the event list is empty.
+            return [{ type: 'text', text: [
+              value.counted === true
+                ? 'Defense event stream cleared — a fresh iteration starts with an empty stream.'
+                : 'No persisted defense event stream to clear.',
+              'Defense Event Summary:',
+              ...EVENT_TYPES.map((type) => `  ${labelFor(type, language)}: 0`),
+            ].join('\n') }]
+          }
+
           if (value.operation === 'counts' && value.counts) {
             const counts = value.counts as Record<DefenseEventType, number>
             const lines = [
@@ -220,12 +234,35 @@ export function registerDefenseEventsTool(ctx: { tools: { register: (def: Return
         if (!resolved.ok) return { ok: false, kind: 'defense_events', error: resolved.reason }
         const projectRoot = resolved.root
 
-        const configLang = loadEffectiveConfig(projectRoot).config.language
+        // A hand-edited `language` value outside zh/en must not leak out of the
+        // declared 'zh' | 'en' enum (labelFor would return undefined for it) —
+        // normalize any non-'zh' config value to 'en'.
+        const rawConfigLang = loadEffectiveConfig(projectRoot).config.language
+        const configLang: 'zh' | 'en' = rawConfigLang === 'zh' ? 'zh' : 'en'
         const language: 'zh' | 'en' = args.language === 'zh' || args.language === 'en' ? args.language : configLang
 
         const operation = typeof args.operation === 'string' ? args.operation : 'list'
         const limit = clampLimit(args.limit as number | undefined)
 
+        if (operation === 'clear') {
+          // Reset the persisted event stream so a fresh iteration does not carry
+          // stale defensive data (mirrors iterate_quality_gate clear / clearQualityGate).
+          const result = clearDefenseEvents(projectRoot)
+          if (!result.ok) {
+            return { ok: false, kind: 'defense_events', operation: 'clear', error: result.error }
+          }
+          const empty = readDefenseEvents(projectRoot)
+          return {
+            ok: true,
+            kind: 'defense_events',
+            operation: 'clear',
+            counted: result.existed,
+            language,
+            counts: empty.counts as unknown as JsonValue,
+            events: empty.events as unknown as JsonValue,
+          }
+        }
+
         if (operation === 'record') {
           const errors = validateRecordInput(args)
           if (errors.length > 0) {

package/src/tools/defense-store.ts

@@ -46,11 +46,41 @@ function emptyStream(): DefenseEventStream {
   }
 }
 
+/** Valid severity values (kept in sync with DefenseEvent). */
+const VALID_SEVERITIES: ReadonlySet<string> = new Set(['critical', 'high', 'medium', 'low'])
+
+/**
+ * Normalize one persisted event. Hand-edited files can carry events missing
+ * `timestamp`/`round`/`description`/`defense`/`outcome`/`severity` — readers
+ * (list sort by timestamp, render label selection) must never crash or emit
+ * NaN for those. Returns null when the entry is not an object or has no usable
+ * `type`; otherwise fills every required field with a safe default.
+ */
+function normalizeEvent(raw: unknown): DefenseEvent | null {
+  if (!raw || typeof raw !== 'object' || Array.isArray(raw)) return null
+  const e = raw as Record<string, unknown>
+  if (typeof e.type !== 'string' || !VALID_EVENT_TYPES.has(e.type as DefenseEventType)) return null
+  return {
+    id: typeof e.id === 'string' && e.id ? e.id : `def-${Math.random().toString(36).slice(2, 8)}`,
+    timestamp: typeof e.timestamp === 'string' && e.timestamp ? e.timestamp : new Date().toISOString(),
+    round: typeof e.round === 'number' && Number.isFinite(e.round) ? Math.floor(e.round) : 0,
+    type: e.type as DefenseEventType,
+    description: typeof e.description === 'string' ? e.description : '',
+    defense: typeof e.defense === 'string' ? e.defense : '',
+    outcome: typeof e.outcome === 'string' ? e.outcome : '',
+    ...(typeof e.file === 'string' && e.file.length > 0 ? { file: e.file } : {}),
+    ...(typeof e.line === 'number' && Number.isFinite(e.line) && e.line >= 0 ? { line: e.line } : {}),
+    severity: VALID_SEVERITIES.has(String(e.severity)) ? (e.severity as DefenseEvent['severity']) : 'low',
+  }
+}
+
 /**
  * Read the defense events stream from disk.
  * Normalizes the persisted stream so a hand-edited / partial file can never
  * produce NaN counts: `counts` is recomputed from the events when missing or
- * malformed, and every type key is guaranteed present.
+ * malformed, every type key is guaranteed present, and every surviving event is
+ * shape-normalized so consumers (timestamp sort, render label selection) cannot
+ * throw on missing fields.
  */
 export function readDefenseEvents(projectRoot: string): DefenseEventStream {
   const filePath = path.join(projectRoot, '.iterate', DEFENSE_EVENTS_FILE)
@@ -58,10 +88,9 @@ export function readDefenseEvents(projectRoot: string): DefenseEventStream {
     const content = fs.readFileSync(filePath, 'utf-8')
     const parsed = JSON.parse(content) as Partial<DefenseEventStream>
     if (parsed && Array.isArray(parsed.events)) {
-      const events = parsed.events.filter(
-        (e): e is DefenseEvent =>
-          !!e && typeof e === 'object' && typeof (e as DefenseEvent).type === 'string',
-      )
+      const events = parsed.events
+        .map(normalizeEvent)
+        .filter((e): e is DefenseEvent => e !== null)
       const counts = computeCounts(events)
       return {
         events,
@@ -101,6 +130,26 @@ export function writeDefenseEvents(
   return { ok: true }
 }
 
+/**
+ * Clear the persisted defense-event stream (`.iterate/defense-events.json`).
+ * Mirrors `clearQualityGate` in quality-store.ts: a stale event stream from a
+ * previous iteration must be resettable before a fresh run. Returns whether a
+ * file existed and was removed, or a structured error when removal fails.
+ */
+export function clearDefenseEvents(
+  projectRoot: string,
+): { ok: true; existed: boolean } | { ok: false; error: string } {
+  const filePath = path.join(iterateDir(projectRoot), DEFENSE_EVENTS_FILE)
+  const existed = fs.existsSync(filePath)
+  if (!existed) return { ok: true, existed: false }
+  try {
+    fs.rmSync(filePath, { force: true })
+  } catch (err) {
+    return { ok: false, error: `unable to remove ${filePath}: ${String(err)}` }
+  }
+  return { ok: true, existed: true }
+}
+
 /** Add a defense event to the stream. */
 export function addDefenseEvent(
   stream: DefenseEventStream,

package/src/tools/experience-bank.ts

@@ -151,8 +151,8 @@ export function registerExperienceBankTool(ctx: { tools: { register: (def: Retur
               `Dimension: ${entry.dimension}`,
               `Description: ${entry.description}`,
               `Fix: ${entry.verifiedFix}`,
-              `Files: ${entry.files.join(', ')}`,
-              `Tags: ${entry.tags.join(', ')}`,
+              `Files: ${Array.isArray(entry.files) ? entry.files.join(', ') : ''}`,
+              `Tags: ${Array.isArray(entry.tags) ? entry.tags.join(', ') : ''}`,
             ].join('\n') }]
           }
           if (value.operation === 'remove') {
@@ -165,9 +165,9 @@ export function registerExperienceBankTool(ctx: { tools: { register: (def: Retur
               `Pattern: ${entry.pattern}`,
               `Description: ${entry.description}`,
               `Fix: ${entry.verifiedFix}`,
-              `Files: ${entry.files.join(', ')}`,
+              `Files: ${Array.isArray(entry.files) ? entry.files.join(', ') : ''}`,
               `Hits: ${entry.hitCount}`,
-              `Tags: ${entry.tags.join(', ')}`,
+              `Tags: ${Array.isArray(entry.tags) ? entry.tags.join(', ') : ''}`,
             ].join('\n') }]
           }
           const entries = (value.entries as unknown as ExperienceEntry[] | undefined) ?? []
@@ -264,7 +264,7 @@ export function registerExperienceBankTool(ctx: { tools: { register: (def: Retur
             operation: 'get',
             count: 1,
             entry: entry as unknown as JsonValue,
-            totalHits: bank.totalHits,
+            totalHits: bank.totalHits ?? 0,
           }
         }
 
@@ -280,7 +280,7 @@ export function registerExperienceBankTool(ctx: { tools: { register: (def: Retur
             operation: 'search',
             count: entries.length,
             entries: entries as unknown as JsonValue,
-            totalHits: bank.totalHits,
+            totalHits: bank.totalHits ?? 0,
           }
         }
 
@@ -290,7 +290,7 @@ export function registerExperienceBankTool(ctx: { tools: { register: (def: Retur
           entries = entries.filter((e) => e.dimension === args.dimension)
         }
         if (Array.isArray(args.tags) && args.tags.length > 0) {
-          entries = entries.filter((e) => args.tags!.every((t: string) => e.tags.includes(t)))
+          entries = entries.filter((e) => args.tags!.every((t: string) => Array.isArray(e.tags) && e.tags.includes(t)))
         }
 
         return {
@@ -299,7 +299,7 @@ export function registerExperienceBankTool(ctx: { tools: { register: (def: Retur
           operation: 'list',
           count: Math.min(entries.length, limit),
           entries: entries.slice(0, limit) as unknown as JsonValue,
-          totalHits: bank.totalHits,
+          totalHits: bank.totalHits ?? 0,
         }
       },
     }),

package/src/tools/experience-store.ts

@@ -22,14 +22,62 @@ function emptyBank(): ExperienceBank {
   }
 }
 
+/** Valid severity values (kept in sync with ExperienceEntry). */
+const VALID_SEVERITIES: ReadonlySet<string> = new Set(['critical', 'high', 'medium', 'low'])
+
+/** String array guard for fields that must be arrays (`files`, `tags`). */
+function stringArray(v: unknown): string[] {
+  if (!Array.isArray(v)) return []
+  return v.filter((x): x is string => typeof x === 'string')
+}
+
+/**
+ * Normalize one persisted experience entry. A hand-edited bank entry can be
+ * missing `files`/`tags` arrays (or `hitCount`) — consumers rendering/searching
+ * entries (`render` `.join(', ')`, `searchExperienceEntries` spread) must never
+ * throw or emit NaN. Returns null for non-object entries; every required field
+ * gets a safe default.
+ */
+function normalizeEntry(raw: unknown): ExperienceEntry | null {
+  if (!raw || typeof raw !== 'object' || Array.isArray(raw)) return null
+  const e = raw as Record<string, unknown>
+  const pattern = typeof e.pattern === 'string' ? e.pattern : ''
+  const dimension = typeof e.dimension === 'string' ? e.dimension : ''
+  const id = typeof e.id === 'string' && e.id ? e.id : `exp-${Math.random().toString(36).slice(2, 8)}`
+  if (!pattern && !dimension) return null
+  const hitCount = typeof e.hitCount === 'number' && Number.isFinite(e.hitCount) ? e.hitCount : 0
+  return {
+    id,
+    timestamp: typeof e.timestamp === 'string' ? e.timestamp : new Date().toISOString(),
+    dimension,
+    pattern,
+    description: typeof e.description === 'string' ? e.description : '',
+    verifiedFix: typeof e.verifiedFix === 'string' ? e.verifiedFix : '',
+    findingSummary: typeof e.findingSummary === 'string' ? e.findingSummary : '',
+    files: stringArray(e.files),
+    hitCount,
+    ...(typeof e.lastHitAt === 'string' ? { lastHitAt: e.lastHitAt } : {}),
+    tags: stringArray(e.tags),
+    severity: VALID_SEVERITIES.has(String(e.severity)) ? (e.severity as ExperienceEntry['severity']) : 'low',
+  }
+}
+
 /** Read the experience bank from disk. Returns empty bank if not found. */
 export function readExperienceBank(projectRoot: string): ExperienceBank {
   const filePath = path.join(projectRoot, '.iterate', EXPERIENCE_FILE)
   try {
     const content = fs.readFileSync(filePath, 'utf-8')
-    const parsed = JSON.parse(content) as ExperienceBank
+    const parsed = JSON.parse(content) as Partial<ExperienceBank>
     if (parsed && Array.isArray(parsed.entries)) {
-      return parsed
+      const entries = parsed.entries
+        .map(normalizeEntry)
+        .filter((e): e is ExperienceEntry => e !== null)
+      return {
+        entries,
+        lastUpdated: typeof parsed.lastUpdated === 'string' ? parsed.lastUpdated : emptyBank().lastUpdated,
+        totalHits:
+          typeof parsed.totalHits === 'number' && Number.isFinite(parsed.totalHits) ? parsed.totalHits : 0,
+      }
     }
   } catch {
     // File not found or invalid JSON
@@ -72,6 +120,9 @@ export function searchExperienceEntries(
   const lowerQuery = query.toLowerCase()
 
   return entries.filter((entry) => {
+    if (!entry || typeof entry !== 'object') return false
+    const rawEntry = entry as unknown as Record<string, unknown>
+    const tags = stringArray(rawEntry.tags)
     // Dimension filter
     if (opts.dimension && entry.dimension !== opts.dimension) {
       return false
@@ -79,22 +130,24 @@ export function searchExperienceEntries(
 
     // Tags filter (AND logic)
     if (opts.tags && opts.tags.length > 0) {
-      if (!opts.tags.every((t) => entry.tags.includes(t))) {
+      if (!opts.tags.every((t) => tags.includes(t))) {
         return false
       }
     }
 
-    // Text search across multiple fields
-    if (query) {
-      const searchableText = [
-        entry.pattern,
-        entry.description,
-        entry.verifiedFix,
-        entry.findingSummary,
-        entry.dimension,
-        ...entry.files,
-        ...entry.tags,
-      ].join(' ').toLowerCase()
+    // Text search across multiple fields. Guards against a hand-edited bank entry
+  // whose `files`/`tags` are missing or non-array (the spread below would
+  // otherwise throw a TypeError on a non-iterable).
+  if (query) {
+    const searchableText = [
+      entry.pattern,
+      entry.description,
+      entry.verifiedFix,
+      entry.findingSummary,
+      entry.dimension,
+      ...stringArray(entry.files),
+      ...stringArray(entry.tags),
+    ].join(' ').toLowerCase()
 
       if (!searchableText.includes(lowerQuery)) {
         return false