iterate-plugin 3.4.0 → 3.5.0

package/dist/tools/fix.js

@@ -16,7 +16,8 @@
  *   - Backups are written before any write, so a failure never destroys data.
  *   - Atomicity is enforced against `config.atomic.max_lines` unless `force`.
  */
-import { copyFileSync, existsSync, mkdirSync, readFileSync, realpathSync, writeFileSync } from 'node:fs';
+import { copyFileSync, existsSync, mkdirSync, readFileSync, realpathSync } from 'node:fs';
+import { writeJsonAtomic, writeTextAtomic } from "../atomic-fs.js";
 import { join, sep } from 'node:path';
 import { defineTool } from '@deepseek-ai/dsh-tools';
 import { loadEffectiveConfig, resolveProjectRootForExec } from "../config-loader.js";
@@ -276,6 +277,20 @@ function readProjectFile(projectRoot, file) {
 export function registerFixTool(ctx) {
     ctx.tools.register(defineTool({
         name: 'iterate_fix',
+        // Pending-call card: surface the file about to change as an inline diff.
+        // oldText is null — a call-time presenter has no access to the file's
+        // prior content (an overwrite, per the presentation contract).
+        presentCall: (args) => {
+            const a = args;
+            if (typeof a.file !== 'string' || typeof a.content !== 'string')
+                return undefined;
+            return {
+                card: 'diff',
+                title: `Fix ${a.file}`,
+                diffs: [{ path: a.file, oldText: null, newText: a.content }],
+                locations: [{ path: a.file }],
+            };
+        },
         description: 'Apply ONE atomic fix to a file. Pass the target relative `file`, the finding that motivated ' +
             'the fix, the NEW full `content` of that file (after your edit), and the current `round`. ' +
             'The tool backs up the original, enforces the atomic `max_lines` and `max_adjacent_methods` thresholds (unless `force`), ' +
@@ -445,7 +460,7 @@ export function registerFixTool(ctx) {
                     return { ok: false, error: `failed to create backup: ${String(err)}` };
                 }
                 try {
-                    writeFileSync(target.resolved, args.content, 'utf-8');
+                    writeTextAtomic(target.resolved, args.content);
                 }
                 catch (err) {
                     return { ok: false, error: `failed to write file: ${String(err)}` };
@@ -463,7 +478,7 @@ export function registerFixTool(ctx) {
                 };
                 const nextRegistry = upsertRecord(registry, record);
                 try {
-                    writeFileSync(fixRegistryPath(projectRoot), JSON.stringify(nextRegistry, null, 2), 'utf-8');
+                    writeJsonAtomic(fixRegistryPath(projectRoot), nextRegistry);
                 }
                 catch (err) {
                     // Registry write failed → the file was already modified but no record
@@ -511,6 +526,9 @@ export function registerFixTool(ctx) {
 export function registerDiffTool(ctx) {
     ctx.tools.register(defineTool({
         name: 'iterate_diff',
+        // Read-only (never writes project files or plugin state) → safe to join
+        // a parallel dispatch group alongside other read-only sibling calls.
+        isConcurrencySafe: () => true,
         description: 'Show the changes made by iterate fixes. With `file`, returns the unified diff of the current ' +
             'file content vs its original (first backup). Without `file`, returns a summary of every fixed file.',
         parameters: {
@@ -612,6 +630,18 @@ export function registerDiffTool(ctx) {
 export function registerRollbackTool(ctx) {
     ctx.tools.register(defineTool({
         name: 'iterate_rollback',
+        // Pending-call card: which fix is about to be reverted.
+        presentCall: (args) => {
+            const a = args;
+            if (typeof a.id !== 'string' || a.id.length === 0)
+                return undefined;
+            return {
+                card: 'generic',
+                title: `Rollback fix ${a.id}`,
+                kind: 'edit',
+                rawInput: { id: a.id },
+            };
+        },
         description: 'Revert a previously applied fix. Pass the fix `id` (returned by iterate_fix). ' +
             'The file is restored from the fix backup, the fix is removed from the registry, ' +
             'and a `revert` entry is appended to the decision log. Use when a round\'s validation fails.',
@@ -667,7 +697,7 @@ export function registerRollbackTool(ctx) {
             }
             const nextRegistry = removeRecord(registry, id);
             try {
-                writeFileSync(fixRegistryPath(projectRoot), JSON.stringify(nextRegistry, null, 2), 'utf-8');
+                writeJsonAtomic(fixRegistryPath(projectRoot), nextRegistry);
             }
             catch (err) {
                 return { ok: false, error: `failed to update fix registry: ${String(err)}` };

package/dist/tools/history.js

@@ -64,6 +64,9 @@ export function summarizeFixRegistry(registry) {
 export function registerHistoryTool(ctx) {
     ctx.tools.register(defineTool({
         name: 'iterate_history',
+        // Read-only audit view over on-disk state → safe to join a parallel
+        // dispatch group alongside other read-only sibling calls.
+        isConcurrencySafe: () => true,
         description: 'Read the iteration history: decision-log entries (optionally filtered by entry `type`, `since` ' +
             'timestamp, and a `limit`) plus a summary of the fix registry (per-round fixed/failed counts). ' +
             'Read-only — use it to review what the run did, audit a log, or inspect fixes.',

package/dist/tools/prune.js

@@ -11,16 +11,19 @@
  *   - Fix backups left over from old rounds (backups whose fix-id no longer
  *     appears in the registry).
  *   - Empty fix rounds (rounds with 0 records).
+ *   - Stray temp files left behind by a crashed atomic write (see
+ *     `isPrunableTemp` for the recognized naming conventions).
  *
  * Security model:
  *   - Only operates under the resolved project `.iterate/` directory.
  *   - dryRun=true by default — the caller must explicitly opt into deletion.
  *   - Each deletion is logged to the decision log (when not dry-run).
  */
-import { existsSync, readdirSync, renameSync, rmSync, unlinkSync, writeFileSync } from 'node:fs';
+import { existsSync, readdirSync, rmSync, unlinkSync } from 'node:fs';
 import { join } from 'node:path';
 import { defineTool } from '@deepseek-ai/dsh-tools';
 import { resolveProjectRootForExec } from "../config-loader.js";
+import { writeTextAtomic, writeJsonAtomic } from "../atomic-fs.js";
 import { readDecisionEntries, appendDecisionEntry } from "./decision-log.js";
 import { readRegistry, recomputeRoundCounts } from "./fix.js";
 import { iterateDir, fixesDir, checkpointPath, fixRegistryPath } from "../paths.js";
@@ -41,6 +44,28 @@ export function cutoffTimestamp(retainDays) {
     d.setDate(d.getDate() - retainDays);
     return d.toISOString();
 }
+/**
+ * Whether a file name inside `.iterate/` is a prunable leftover temp file.
+ *
+ * Recognized conventions (all written to the SAME directory as their target,
+ * so they can never be confused with real state files):
+ *   - `.<name>.tmp-<pid>-<rand>` — current atomic-fs.ts temp prefix;
+ *   - `.tmp-<pid>-<rand>`        — legacy temp prefix (older plugin builds);
+ *   - `<name>.tmp`               — legacy transcript.ts / live.ts temp suffix.
+ *
+ * Pure and exported for unit tests. A live writer's temp file is only visible
+ * to it (unique name), so deleting any match is always safe.
+ */
+export function isPrunableTemp(name) {
+    if (typeof name !== 'string' || name.length === 0 || name === '.' || name === '..')
+        return false;
+    if (name.startsWith('.tmp-'))
+        return true;
+    if (name.endsWith('.tmp'))
+        return true;
+    // .<basename>.tmp-<pid>-<rand>: starts with a dot and contains ".tmp-" after it.
+    return name.startsWith('.') && name.includes('.tmp-');
+}
 /**
  * Inspect the runtime state and report what would be pruned.
  * Pure (no deletions). Returns a structured report.
@@ -79,10 +104,17 @@ export function inspectPrune(projectRoot, retainDays) {
     const emptyRounds = registry.rounds
         .filter((r) => r.records.length === 0)
         .map((r) => r.round);
+    // 5. Stray atomic-write temp files left behind by a crashed writer. The
+    // unique prefix makes them recognizable and safe to delete — no live writer
+    // ever reads another writer's temp file.
+    const staleTemps = existsSync(iterateDir(projectRoot))
+        ? readdirSync(iterateDir(projectRoot)).filter((f) => isPrunableTemp(f)).sort()
+        : [];
     return {
         oldLogEntries,
         hasCheckpoint,
         staleBackups,
+        staleTemps,
         emptyRounds,
         totalLogEntries: entries.length,
         registryRounds: registry.rounds.length,
@@ -98,6 +130,7 @@ export function executePrune(projectRoot, retainDays, report) {
         deletedLogEntries: 0,
         deletedCheckpoint: false,
         deletedBackups: [],
+        deletedTemps: [],
         trimmedEmptyRounds: 0,
         errors: [],
     };
@@ -109,9 +142,7 @@ export function executePrune(projectRoot, retainDays, report) {
         result.deletedLogEntries = entries.length - kept.length;
         if (result.deletedLogEntries > 0) {
             const logPath = join(iterateDir(projectRoot), 'decision-log.jsonl');
-            const tmpPath = `${logPath}.tmp-${Date.now()}`;
-            writeFileSync(tmpPath, kept.map((e) => JSON.stringify(e)).join('\n') + '\n', 'utf-8');
-            renameSync(tmpPath, logPath);
+            writeTextAtomic(logPath, kept.map((e) => JSON.stringify(e)).join('\n') + '\n');
         }
     }
     catch (err) {
@@ -151,13 +182,23 @@ export function executePrune(projectRoot, retainDays, report) {
                 rounds: registry.rounds.filter((r) => !emptyRoundNos.has(r.round) || (r.records?.length ?? 0) > 0),
             };
             registry = recomputeRoundCounts(registry);
-            writeFileSync(fixRegistryPath(projectRoot), JSON.stringify(registry, null, 2), 'utf-8');
+            writeJsonAtomic(fixRegistryPath(projectRoot), registry);
             result.trimmedEmptyRounds = report.emptyRounds.length;
         }
         catch (err) {
             result.errors.push(`failed to trim empty rounds: ${String(err)}`);
         }
     }
+    // 5. Remove stray atomic-write temp files.
+    for (const tmp of report.staleTemps) {
+        try {
+            rmSync(join(iterateDir(projectRoot), tmp), { force: true });
+            result.deletedTemps.push(tmp);
+        }
+        catch (err) {
+            result.errors.push(`failed to delete temp file ${tmp}: ${String(err)}`);
+        }
+    }
     return result;
 }
 /**
@@ -170,7 +211,8 @@ export function registerPruneTool(ctx) {
         name: 'iterate_prune',
         description: 'Inspect or clean up old iterate runtime artifacts (.iterate/). ' +
             'Defaults to dry-run (report-only, no deletion). Pass `dryRun: false` to actually prune. ' +
-            'Manages: old decision-log entries, stale checkpoints, orphaned fix backups, empty fix rounds. ' +
+            'Manages: old decision-log entries, stale checkpoints, orphaned fix backups, empty fix rounds, ' +
+            'and stray temp files left by crashed atomic writes. ' +
             'Each deletion is logged to the decision log.',
         parameters: {
             dryRun: {
@@ -210,6 +252,7 @@ export function registerPruneTool(ctx) {
                         `  Decision-log entries to remove: ${report?.oldLogEntries ?? '?'} (of ${report?.totalLogEntries ?? '?'})`,
                         `  Checkpoint to delete: ${report?.hasCheckpoint ? 'yes' : 'none'}`,
                         `  Stale backups to delete: ${report?.staleBackups?.length ?? 0}`,
+                        `  Stray temp files to delete: ${report?.staleTemps?.length ?? 0}`,
                         `  Empty rounds to trim: ${report?.emptyRounds?.length ?? 0}`,
                         '',
                         'Pass dryRun:false to execute the prune.',
@@ -221,6 +264,7 @@ export function registerPruneTool(ctx) {
                     `  Deleted ${result?.deletedLogEntries ?? 0} old log entries.`,
                     `  Checkpoint deleted: ${result?.deletedCheckpoint ? 'yes' : 'no'}`,
                     `  Deleted ${result?.deletedBackups?.length ?? 0} stale backups.`,
+                    `  Deleted ${result?.deletedTemps?.length ?? 0} stray temp files.`,
                     `  Trimmed ${result?.trimmedEmptyRounds ?? 0} empty rounds.`,
                 ];
                 const errs = result?.errors ?? [];

package/dist/tools/quality-gate.js

@@ -59,6 +59,9 @@ function sanitizeRoundSeries(raw) {
 export function registerQualityGateTool(ctx) {
     ctx.tools.register(defineTool({
         name: 'iterate_quality_gate',
+        // `read` never writes; `compute` persists the snapshot → only read
+        // joins a parallel dispatch group.
+        isConcurrencySafe: (args) => args.operation === 'read',
         description: 'Query or write the quality gate status: dimension convergence rates, verification pass rates, ' +
             'and overall PASS/FAIL status. ' +
             'Operation "read" (default) returns the persisted machine-readable quality certificate. ' +

package/dist/tools/quality-store.js

@@ -7,6 +7,7 @@
  */
 import * as fs from 'node:fs';
 import * as path from 'node:path';
+import { writeJsonAtomic } from "../atomic-fs.js";
 const QUALITY_GATE_FILE = 'quality-gate.json';
 /** Default empty quality gate snapshot. */
 function emptySnapshot() {
@@ -96,7 +97,7 @@ export function writeQualityGate(projectRoot, snapshot) {
         if (!fs.existsSync(dirPath)) {
             fs.mkdirSync(dirPath, { recursive: true });
         }
-        fs.writeFileSync(filePath, JSON.stringify(snapshot, null, 2), 'utf-8');
+        writeJsonAtomic(filePath, snapshot);
     }
     catch (err) {
         return { ok: false, error: `unable to write ${filePath}: ${String(err)}` };

package/dist/tools/transcript.js

@@ -18,8 +18,9 @@
  * tmp+rename so a crashed writer never leaves a corrupt manifest.
  */
 import { defineTool } from '@deepseek-ai/dsh-tools';
-import { mkdir, readFile, rename, writeFile } from 'node:fs/promises';
+import { mkdir, readFile } from 'node:fs/promises';
 import { existsSync } from 'node:fs';
+import { writeTextAtomicAsync } from "../atomic-fs.js";
 import { dirname } from 'node:path';
 import { loadEffectiveConfig, resolveProjectRootForExec, } from "../config-loader.js";
 import { transcriptPath } from "../paths.js";
@@ -96,6 +97,9 @@ function normalizeFix(input) {
 export function registerTranscriptTool(ctx) {
     ctx.tools.register(defineTool({
         name: 'iterate_transcript',
+        // `read` never writes; `capture`/`nudge` persist transcript state → only
+        // read joins a parallel dispatch group.
+        isConcurrencySafe: (args) => args.operation === 'read',
         description: 'Runtime-observatory transcript for the iterate workflow. ' +
             '`read` returns the current persisted transcript manifest (per-reviewer threads, ' +
             'convergence series, findings, fixes, checkpoint, timeline, and any steering nudge ' +
@@ -322,10 +326,8 @@ function rehydrateBuilder(manifest, approval) {
         builder.finish();
     return builder;
 }
-/** Atomically persist a manifest (tmp + rename) under `.iterate/`. */
+/** Atomically persist a manifest (unique temp + rename) under `.iterate/`. */
 async function persist(file, manifest) {
     await mkdir(dirname(file), { recursive: true });
-    const tmp = `${file}.tmp`;
-    await writeFile(tmp, JSON.stringify(manifest, null, 2), 'utf-8');
-    await rename(tmp, file);
+    await writeTextAtomicAsync(file, JSON.stringify(manifest, null, 2));
 }

package/dist/tools/triage.js

@@ -1,8 +1,9 @@
-import { copyFileSync, existsSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
+import { copyFileSync, existsSync, readFileSync, rmSync } from 'node:fs';
 import { join } from 'node:path';
 import { defineTool } from '@deepseek-ai/dsh-tools';
 import yaml from 'js-yaml';
 import { resolveProjectRootForExec } from "../config-loader.js";
+import { writeTextAtomic } from "../atomic-fs.js";
 const CONFIG_FILE = 'iterate.config.yaml';
 /** Personalization key that holds the known-intentional list. */
 const PERSONALIZATION_KEY = 'personalization';
@@ -191,7 +192,7 @@ function applyEntries(projectRoot, incoming) {
     }
     const yamlText = yaml.dump(nextConfig, { noRefs: true });
     try {
-        writeFileSync(configPath, yamlText, 'utf-8');
+        writeTextAtomic(configPath, yamlText);
     }
     catch (err) {
         // Rollback: restore the backup, or REMOVE the file we just created when
@@ -231,6 +232,9 @@ function applyEntries(projectRoot, incoming) {
 export function registerTriageTool(ctx) {
     ctx.tools.register(defineTool({
         name: 'iterate_triage',
+        // `list` is a pure config read; `apply` rewrites iterate.config.yaml →
+        // only list joins a parallel dispatch group.
+        isConcurrencySafe: (args) => args.operation === 'list',
         description: 'Manage `personalization.known_intentional` entries in iterate.config.yaml. ' +
             'Use `apply` to write back triage verdicts (entries where the reviewer said "known intentional") so ' +
             'future review rounds filter them out. Entries are deduped by file|dimension|line and the config is ' +

package/dist/tools/validate.js

@@ -19,8 +19,14 @@ export function clampTimeout(ms) {
 /**
  * Run a single shell command with timeout and return structured results.
  * Pure function (no side effects beyond the exec call).
+ *
+ * `signal` (the caller's `exec.signal` per the dsh tools contract) is forwarded
+ * to the child process so a cancelled tool call kills the running command
+ * instead of pinning the dispatch open until the timeout elapses. The result
+ * distinguishes "cancelled by the caller" (`canceled: true`) from "ran past
+ * `timeoutMs`" (`timedOut: true`).
  */
-async function runCommand(command, cwd, timeoutMs) {
+export async function runCommand(command, cwd, timeoutMs, signal) {
     const start = performance.now();
     return new Promise((resolve) => {
         exec(command, {
@@ -28,18 +34,23 @@ async function runCommand(command, cwd, timeoutMs) {
             timeout: timeoutMs,
             maxBuffer: 10 * 1024 * 1024, // 10 MB
             env: { ...process.env, PAGER: 'cat' },
+            signal,
         }, (error, stdout, stderr) => {
             const durationMs = Math.round(performance.now() - start);
             // error.code is the exit code when the command ran; when the binary
             // cannot be spawned Node sets error.code to a STRING ('ENOENT' etc).
             // Coerce to a number so the integer output schema is never violated.
             const exitCode = typeof error?.code === 'number' ? error.code : (error ? 1 : 0);
+            const canceled = signal?.aborted === true;
             resolve({
                 command,
                 exitCode,
                 stdout: stdout ?? '',
                 stderr: stderr ?? '',
-                timedOut: error?.killed === true,
+                // A caller cancellation also kills the child (killed === true), but
+                // that is not a timeout — only report timedOut for the deadline path.
+                timedOut: error?.killed === true && !canceled,
+                canceled,
                 durationMs,
             });
         });
@@ -53,6 +64,19 @@ async function runCommand(command, cwd, timeoutMs) {
 export function registerValidateTool(ctx) {
     ctx.tools.register(defineTool({
         name: 'iterate_validate',
+        // Pending-call card: render the pending validation as a terminal card.
+        // Pure — derived from args only; no `cwd` (the UI bridge resolves the
+        // relative command against the session workspace).
+        presentCall: (args) => {
+            const a = args;
+            if (typeof a.command !== 'string' || a.command.length === 0)
+                return undefined;
+            return {
+                card: 'terminal',
+                title: a.command,
+                description: 'Run a preconfigured iterate validation command (exact match on validation.commands).',
+            };
+        },
         description: 'Run a validation command that is PRECONFIGURED in iterate.config.yaml `validation.commands`. ' +
             'The command must exactly match one of the configured commands (they are the only ones the user trusts). ' +
             'Returns exit code, stdout, stderr, and duration. ' +
@@ -83,6 +107,7 @@ export function registerValidateTool(ctx) {
                     stdout: { type: 'string', required: true },
                     stderr: { type: 'string', required: true },
                     timedOut: { type: 'boolean', required: true },
+                    canceled: { type: 'boolean', required: true },
                     durationMs: { type: 'integer', required: true },
                     rejectReason: { type: 'string' },
                 },
@@ -96,6 +121,7 @@ export function registerValidateTool(ctx) {
                             `Exit code: ${value.exitCode}`,
                             `Duration: ${value.durationMs}ms`,
                             value.timedOut ? '⚠ Timed out' : '',
+                            value.canceled ? '⚠ Cancelled before completion' : '',
                             '',
                             value.stdout ? `[stdout]\n${value.stdout}` : '',
                             value.stderr ? `[stderr]\n${value.stderr}` : '',
@@ -116,6 +142,7 @@ export function registerValidateTool(ctx) {
                     stdout: '',
                     stderr: '',
                     timedOut: false,
+                    canceled: false,
                     durationMs: 0,
                     rejectReason: resolved.reason,
                 };
@@ -137,6 +164,7 @@ export function registerValidateTool(ctx) {
                     stdout: '',
                     stderr: '',
                     timedOut: false,
+                    canceled: false,
                     durationMs: 0,
                     rejectReason: (source === 'defaults'
                         ? 'No iterate.config.yaml at project root — running on built-in defaults, which configure NO trusted validation commands. '
@@ -152,12 +180,13 @@ export function registerValidateTool(ctx) {
                     stdout: '',
                     stderr: '',
                     timedOut: false,
+                    canceled: false,
                     durationMs: 0,
                     rejectReason: `Command must exactly match a command predefined in iterate.config.yaml validation.commands. ` +
                         `Allowed commands: ${predefinedCommands.join(' | ')}`,
                 };
             }
-            const result = await runCommand(args.command, projectRoot, timeout);
+            const result = await runCommand(args.command, projectRoot, timeout, exec.signal);
             return {
                 allowed: true,
                 ...result,

package/lib/client.js

@@ -115,10 +115,11 @@ function scanSessionForResume(obj, seen, maxDepth = 20) {
 function countSessionImages(session) {
   if (!session || typeof session !== "object") return 0;
   const ids = /* @__PURE__ */ new Set();
+  const consumed = /* @__PURE__ */ new Set();
   let count = 0;
   const walk = (obj, depth) => {
     if (depth <= 0 || !obj || typeof obj !== "object") return;
-    if (seen.has(obj)) return;
+    if (seen.has(obj) || consumed.has(obj)) return;
     seen.add(obj);
     const o = (
       /** @type {Record<string, unknown>} */
@@ -142,6 +143,7 @@ function countSessionImages(session) {
       } else {
         count += 1;
       }
+      consumed.add(ref);
     }
     if (Array.isArray(obj)) {
       for (const item of obj) walk(item, depth - 1);
@@ -289,16 +291,21 @@ function attachLive(manifest, source) {
   copy.live = live;
   return copy;
 }
-function extractTranscript(obj) {
+function extractTranscript(obj, seen, depth) {
+  if (depth === void 0) depth = 0;
+  if (depth > 20) return null;
   if (typeof obj === "string") {
     try {
       const parsed = JSON.parse(obj);
-      return extractTranscript(parsed);
+      return extractTranscript(parsed, seen, depth + 1);
     } catch {
       return null;
     }
   }
   if (!obj || typeof obj !== "object") return null;
+  if (!seen) seen = /* @__PURE__ */ new Set();
+  if (seen.has(obj)) return null;
+  seen.add(obj);
   if (isTranscriptManifest(obj)) return (
     /** @type {Record<string, unknown>} */
     obj
@@ -322,11 +329,11 @@ function extractTranscript(obj) {
     if (val !== void 0) {
       if (Array.isArray(val)) {
         for (const item of val) {
-          const found = extractTranscript(item);
+          const found = extractTranscript(item, seen, depth + 1);
           if (found) return attachLive(found, o);
         }
       } else {
-        const found = extractTranscript(val);
+        const found = extractTranscript(val, seen, depth + 1);
         if (found) return attachLive(found, o);
       }
     }
@@ -569,6 +576,24 @@ function latestToolResultNode(session, toolName) {
       /** @type {Array<Record<string, unknown>>} */
       messages
     );
+    for (let i = msgs.length - 1; i >= 0; i--) {
+      const msg = msgs[i];
+      if (!msg) continue;
+      const calls = safeGet(msg, "tool_calls");
+      if (!Array.isArray(calls)) continue;
+      const callList = (
+        /** @type {Array<Record<string, unknown>>} */
+        calls
+      );
+      for (let j = callList.length - 1; j >= 0; j--) {
+        const call = callList[j];
+        if (!call) continue;
+        const name2 = String(safeGet(call, "name") ?? safeGet(call, "tool") ?? "");
+        if (name2 !== toolName && !name2.endsWith(toolName)) continue;
+        const result = safeGet(call, "result") ?? safeGet(call, "response") ?? safeGet(call, "message");
+        if (result !== void 0 && result !== null) return result;
+      }
+    }
     for (let i = msgs.length - 1; i >= 0; i--) {
       const msg = msgs[i];
       if (!msg) continue;
@@ -895,6 +920,7 @@ function computeSummaryFromFindings(findings) {
   const counts = { critical: 0, high: 0, medium: 0, low: 0 };
   const byDimension = {};
   for (const f of findings) {
+    if (!f || typeof f !== "object") continue;
     const sev = String(f.severity ?? "low");
     if (sev in counts) counts[sev]++;
     const dim = String(f.dimension ?? "unknown");
@@ -942,6 +968,7 @@ function severityStats(report) {
   );
   const counts = { critical: 0, high: 0, medium: 0, low: 0 };
   for (const f of findings) {
+    if (!f || typeof f !== "object") continue;
     const sev = String(f.severity ?? "low");
     if (sev in counts) counts[sev]++;
   }
@@ -954,6 +981,7 @@ function groupByDimension(report) {
   );
   const groups = {};
   for (const f of findings) {
+    if (!f || typeof f !== "object") continue;
     const dim = String(f.dimension ?? "unknown");
     if (!groups[dim]) groups[dim] = [];
     groups[dim].push(f);
@@ -1048,6 +1076,7 @@ function normalizeFindingFilter(filter) {
   return { severities, dimensions, search };
 }
 function findingMatches(finding, filter) {
+  if (!finding || typeof finding !== "object") return false;
   const f = normalizeFindingFilter(filter);
   const sev = String(finding.severity ?? "low");
   if (f.severities.length > 0 && !f.severities.includes(sev)) return false;
@@ -1118,6 +1147,7 @@ function setAllVerdicts(triageState, verdict, indices) {
 function buildRoundHistory(report) {
   const rounds = Array.isArray(report.rounds) ? report.rounds : [];
   return rounds.map((r) => {
+    if (!r || typeof r !== "object") return { round: 0, count: 0, critical: 0, high: 0, medium: 0, low: 0 };
     const rr = (
       /** @type {Record<string, unknown>} */
       r
@@ -1274,7 +1304,13 @@ function filterTimelineEntries(entries, opts) {
     if (type && String(t.type ?? "") !== type) return false;
     if (round && String(t.round ?? "") !== round) return false;
     if (q) {
-      const hay = [String(t.type ?? ""), String(t.round ?? ""), JSON.stringify(t.data ?? {})].join(" ").toLowerCase();
+      let dataText = "";
+      try {
+        dataText = JSON.stringify(t.data ?? {});
+      } catch {
+        dataText = t.data === void 0 ? "{}" : String(t.data);
+      }
+      const hay = [String(t.type ?? ""), String(t.round ?? ""), dataText].join(" ").toLowerCase();
       if (hay.indexOf(q) < 0) return false;
     }
     return true;
@@ -2078,7 +2114,7 @@ function TriagePanel(props) {
   const ignoredCount = ignored.length;
   const counts = countVerdicts(verdicts);
   const doApproveArchitecturalFix = () => {
-    const cmd = "\u8BF7\u8C03\u7528 `iterate_fix` \u6279\u51C6\u67B6\u6784\u4FEE\u590D\uFF08\u8BBE\u7F6E is_architectural: true\uFF09";
+    const cmd = "\u8BF7\u8C03\u7528 `iterate_fix`\uFF0C\u5BF9\u672C\u9879\u76EE\u5269\u4F59\u67B6\u6784\u578B finding \u751F\u6210\u4FEE\u590D\u5185\u5BB9\u5E76\u8BBE\u7F6E force: true \u5E94\u7528\uFF08\u67B6\u6784\u4FEE\u590D\u5141\u8BB8\u8D85\u8FC7 atomic \u9608\u503C\uFF09";
     copyText(cmd).then((ok) => {
       if (ok) {
         setCmdCopied("approve-arch");
@@ -2096,7 +2132,7 @@ function TriagePanel(props) {
     });
   };
   const doRollbackToCheckpoint = () => {
-    const cmd = "\u8BF7\u8C03\u7528 `iterate_checkpoint` \u56DE\u6EDA\u5230\u4E0A\u4E00\u4E2A\u68C0\u67E5\u70B9";
+    const cmd = "\u8BF7\u56DE\u6EDA\u4E0A\u4E00\u8F6E\u8FED\u4EE3\u7684\u4FEE\u590D\uFF1A\u8C03\u7528 `iterate_history` \u67E5\u770B\u672C\u8F6E fix id\uFF0C\u518D\u7528 `iterate_rollback` \u9010\u4E2A\u64A4\u9500\u8FD9\u4E9B\u4FEE\u590D";
     copyText(cmd).then((ok) => {
       if (ok) {
         setCmdCopied("rollback");
@@ -3180,7 +3216,14 @@ ${JSON.stringify({ operation: "nudge", text: null }, null, 2)}
     const sorted = filtered.slice();
     const rows = sorted.map((t, i) => {
       const k = `f7-${i}`;
-      const dataText = t.data && typeof t.data === "object" ? JSON.stringify(t.data) : "";
+      let dataText = "";
+      if (t.data && typeof t.data === "object") {
+        try {
+          dataText = JSON.stringify(t.data);
+        } catch {
+          dataText = String(t.data);
+        }
+      }
       return React.createElement(
         "div",
         { key: k, className: "iterate-obs-row", style: { flexDirection: "column", alignItems: "flex-start" } },