iterate-plugin 3.2.1 → 3.3.0

package/src/tools/defense-store.ts

@@ -59,8 +59,16 @@ export function readDefenseEvents(projectRoot: string): DefenseEventStream {
   return emptyStream()
 }
 
-/** Write the defense events stream to disk. */
-export function writeDefenseEvents(projectRoot: string, stream: DefenseEventStream): void {
+/**
+ * Write the defense events stream to disk.
+ * Returns `{ ok: true }` on success or `{ ok: false, error }` when the write
+ * fails — a caller must surface the failure instead of reporting success for
+ * an event that was never persisted.
+ */
+export function writeDefenseEvents(
+  projectRoot: string,
+  stream: DefenseEventStream,
+): { ok: true } | { ok: false; error: string } {
   const dirPath = path.join(projectRoot, '.iterate')
   const filePath = path.join(dirPath, DEFENSE_EVENTS_FILE)
 
@@ -69,9 +77,10 @@ export function writeDefenseEvents(projectRoot: string, stream: DefenseEventStre
       fs.mkdirSync(dirPath, { recursive: true })
     }
     fs.writeFileSync(filePath, JSON.stringify(stream, null, 2), 'utf-8')
-  } catch {
-    // Silently fail - defense events are not critical
+  } catch (err) {
+    return { ok: false, error: `unable to write ${filePath}: ${String(err)}` }
   }
+  return { ok: true }
 }
 
 /** Add a defense event to the stream. */

package/src/tools/experience-bank.ts

@@ -195,7 +195,10 @@ export function registerExperienceBankTool(ctx: { tools: { register: (def: Retur
           }
           const bank = readExperienceBank(projectRoot)
           const { bank: next, added, entryId } = upsertExperience(bank, normalizeExperienceInput(raw as Record<string, unknown>))
-          writeExperienceBank(projectRoot, next)
+          const write = writeExperienceBank(projectRoot, next)
+          if (!write.ok) {
+            return { ok: false, kind: 'experience', operation: 'add', error: write.error }
+          }
           const entry = next.entries.find((e) => e.id === entryId)
           return {
             ok: true,

package/src/tools/experience-store.ts

@@ -35,8 +35,16 @@ export function readExperienceBank(projectRoot: string): ExperienceBank {
   return emptyBank()
 }
 
-/** Write the experience bank to disk. */
-export function writeExperienceBank(projectRoot: string, bank: ExperienceBank): void {
+/**
+ * Write the experience bank to disk.
+ * Returns `{ ok: true }` on success or `{ ok: false, error }` when the write
+ * fails — a caller must surface the failure instead of reporting success for
+ * an entry that was never persisted.
+ */
+export function writeExperienceBank(
+  projectRoot: string,
+  bank: ExperienceBank,
+): { ok: true } | { ok: false; error: string } {
   const dirPath = path.join(projectRoot, '.iterate')
   const filePath = path.join(dirPath, EXPERIENCE_FILE)
 
@@ -45,9 +53,10 @@ export function writeExperienceBank(projectRoot: string, bank: ExperienceBank):
       fs.mkdirSync(dirPath, { recursive: true })
     }
     fs.writeFileSync(filePath, JSON.stringify(bank, null, 2), 'utf-8')
-  } catch {
-    // Silently fail - experience bank is not critical
+  } catch (err) {
+    return { ok: false, error: `unable to write ${filePath}: ${String(err)}` }
   }
+  return { ok: true }
 }
 
 /** Search experience entries by query string. */

package/src/tools/quality-gate.ts

@@ -171,7 +171,10 @@ export function registerQualityGateTool(ctx: { tools: { register: (def: ReturnTy
             findingsByRound,
             fixedByDimension,
           })
-          writeQualityGate(projectRoot, snapshot)
+          const write = writeQualityGate(projectRoot, snapshot)
+          if (!write.ok) {
+            return { ok: false, kind: 'quality_gate', operation: 'compute', error: write.error }
+          }
           return {
             ok: true,
             kind: 'quality_gate',

package/src/tools/quality-store.ts

@@ -46,8 +46,16 @@ export function readQualityGate(projectRoot: string): QualityGateSnapshot {
   return emptySnapshot()
 }
 
-/** Write the quality gate snapshot to disk. */
-export function writeQualityGate(projectRoot: string, snapshot: QualityGateSnapshot): void {
+/**
+ * Write the quality gate snapshot to disk.
+ * Returns `{ ok: true }` on success or `{ ok: false, error }` when the write
+ * fails — a caller must surface the failure instead of reporting success for
+ * a snapshot that was never persisted.
+ */
+export function writeQualityGate(
+  projectRoot: string,
+  snapshot: QualityGateSnapshot,
+): { ok: true } | { ok: false; error: string } {
   const dirPath = path.join(projectRoot, '.iterate')
   const filePath = path.join(dirPath, QUALITY_GATE_FILE)
 
@@ -56,9 +64,10 @@ export function writeQualityGate(projectRoot: string, snapshot: QualityGateSnaps
       fs.mkdirSync(dirPath, { recursive: true })
     }
     fs.writeFileSync(filePath, JSON.stringify(snapshot, null, 2), 'utf-8')
-  } catch {
-    // Silently fail - quality gate is not critical
+  } catch (err) {
+    return { ok: false, error: `unable to write ${filePath}: ${String(err)}` }
   }
+  return { ok: true }
 }
 
 /**

package/src/tools/transcript.ts

@@ -136,6 +136,11 @@ export function registerTranscriptTool(ctx: {
           description: 'For `capture`: run mode ("dry-run" | "normal"). Default dry-run.',
           enum: ['dry-run', 'normal'],
         },
+        taskMode: {
+          type: 'string',
+          description: 'For `capture`: harness execution mode ("code" | "iterate"). Default derives from the review loop (iterate).',
+          enum: ['code', 'iterate'],
+        },
         goal: { type: 'string', description: 'For `capture`: run goal.' },
         maxRounds: { type: 'integer', description: 'For `capture`: round cap.' },
         roundsExecuted: { type: 'integer', description: 'For `capture`: number of rounds actually executed.' },
@@ -229,10 +234,11 @@ export function registerTranscriptTool(ctx: {
 
         // capture
         const mode = args.mode === 'normal' ? 'normal' : 'dry-run'
+        const taskMode = args.taskMode === 'code' || args.taskMode === 'iterate' ? args.taskMode : undefined
         const goal = typeof args.goal === 'string' ? args.goal : ''
         const maxRounds =
           typeof args.maxRounds === 'number' ? Math.floor(args.maxRounds) : 0
-        const builder = new ReviewTranscriptBuilder({ project: projectRoot, mode, approval, goal, maxRounds })
+        const builder = new ReviewTranscriptBuilder({ project: projectRoot, mode, taskMode, approval, goal, maxRounds })
         const report = args.report as Record<string, unknown> | null | undefined
         const reportFindings: unknown =
           report && typeof report === 'object' && Array.isArray(report.findings)
@@ -300,6 +306,7 @@ function rehydrateBuilder(manifest: TranscriptManifest, approval: 'ask' | 'deny'
   const builder = new ReviewTranscriptBuilder({
     project: manifest.project,
     mode: manifest.mode ?? null,
+    taskMode: manifest.taskMode ?? null,
     approval,
     goal: manifest.goal,
     maxRounds: manifest.maxRounds,

package/src/transcript.ts

@@ -126,6 +126,7 @@ function mergeReportIntoThread(
 export class ReviewTranscriptBuilder {
   private readonly project: string
   private readonly mode: 'dry-run' | 'normal' | null
+  private readonly taskMode: 'code' | 'iterate' | null
   private readonly approval: 'ask' | 'deny' | 'allow'
   private goal = ''
   private readonly phases: string[] = []
@@ -144,6 +145,7 @@ export class ReviewTranscriptBuilder {
   constructor(input: {
     project: string
     mode?: 'dry-run' | 'normal' | null
+    taskMode?: 'code' | 'iterate' | null
     approval?: 'ask' | 'deny' | 'allow'
     goal?: string
     maxRounds?: number
@@ -152,6 +154,14 @@ export class ReviewTranscriptBuilder {
     this.project = input.project || ''
     this.mode =
       input.mode === 'dry-run' || input.mode === 'normal' ? input.mode : null
+    // v3.0: task_mode indicator. An explicit valid value wins; otherwise a
+    // run that exercises the review loop (any mode) defaults to "iterate".
+    this.taskMode =
+      input.taskMode === 'code' || input.taskMode === 'iterate'
+        ? input.taskMode
+        : input.mode !== null && input.mode !== undefined
+          ? 'iterate'
+          : null
     this.approval =
       input.approval === 'ask' || input.approval === 'deny' || input.approval === 'allow'
         ? input.approval
@@ -393,6 +403,7 @@ export class ReviewTranscriptBuilder {
       updatedAt: this.updatedAt,
       active: this.active,
       mode: this.mode,
+      taskMode: this.taskMode,
       goal: this.goal,
       phases: this.phases,
       round: this.round,