issue-flow 0.18.0 → 0.20.0

package/dist/{chunk-EG2MGDP5.js → chunk-Z6RCKCVB.js}

@@ -3,60 +3,54 @@ import {
   applyAcceptanceToPlan,
   formatVerificationLine,
   runAcceptanceGate
-} from "./chunk-ECU7YO7S.js";
+} from "./chunk-PM5YWJYO.js";
 import {
   issuePlaceholders,
   resolveCommandIssue
-} from "./chunk-SA6HXL4Y.js";
+} from "./chunk-7WBUEBD5.js";
 import {
   publishPhaseMetrics,
   resolvePolicyPlaceholders
-} from "./chunk-KMCS76ZW.js";
+} from "./chunk-KUL64XUF.js";
 import {
   applyPlaceholders,
   loadPrompt
-} from "./chunk-7F7LGMVO.js";
+} from "./chunk-BTBJ5UOO.js";
 import {
   DEFAULT_HEADLESS_TIMEOUT_MS,
   runHeadless
-} from "./chunk-TZYINKCC.js";
-import {
-  resolveIssuePaths
-} from "./chunk-LI35PIIS.js";
+} from "./chunk-UDUUUFQF.js";
 import {
   getGlobalTimeout,
   printError,
   printSuccess,
-  printWarning
-} from "./chunk-XZUEFTUP.js";
+  printWarning,
+  resolveIssuePaths
+} from "./chunk-DBLXLKGU.js";
 import {
   loadTaskPlan,
   saveTaskPlan
-} from "./chunk-SOM4QA6C.js";
+} from "./chunk-JCR5C5A7.js";
 
-// src/commands/review.ts
-function parseReviewResult(output) {
-  const match = output.match(/<review-result>([\s\S]*?)<\/review-result>/);
-  if (!match) {
-    if (/STATUS:\s*PASS/i.test(output)) {
-      return { status: "PASS" };
-    }
-    if (/STATUS:\s*FAIL/i.test(output)) {
-      const findingsMatch2 = output.match(/FINDINGS:([\s\S]*?)(?:$|<\/)/);
-      return { status: "FAIL", findings: findingsMatch2?.[1]?.trim() ?? "Unknown findings" };
-    }
-    return { status: "PASS" };
+// src/verify/review-result.ts
+function parseIssueReviewResult(output) {
+  const blocks = [...output.matchAll(/<review-result>([\s\S]*?)<\/review-result>/g)];
+  if (blocks.length !== 1 || (output.match(/<\/?review-result>/g)?.length ?? 0) !== 2 || !output.trimEnd().endsWith("</review-result>")) {
+    return { ok: false, error: "Expected exactly one final <review-result> block." };
   }
-  const block = match[1];
-  if (/STATUS:\s*PASS/i.test(block)) {
-    return { status: "PASS" };
+  const body = blocks[0][1].trim();
+  if (body === "STATUS: PASS") return { ok: true, status: "PASS" };
+  const failure = body.match(/^STATUS: FAIL\s*\r?\nFINDINGS:\s*\r?\n([\s\S]+)$/);
+  if (failure && !/^STATUS:/m.test(failure[1])) {
+    const lines = failure[1].trim().split(/\r?\n/);
+    if (lines.every((line) => /^-\s+\S/.test(line))) {
+      return { ok: true, status: "FAIL", findings: lines.join("\n") };
+    }
   }
-  const findingsMatch = block.match(/FINDINGS:([\s\S]*)/);
-  return {
-    status: "FAIL",
-    findings: findingsMatch?.[1]?.trim() ?? "Unknown findings"
-  };
+  return { ok: false, error: "Invalid review status or findings; no approval inferred." };
 }
+
+// src/commands/review.ts
 async function runReview(issue, resolvedIssue) {
   const issueNumber = issue.replace(/^#/, "");
   const paths = await resolveIssuePaths(issueNumber);
@@ -84,25 +78,16 @@ async function runReview(issue, resolvedIssue) {
   } else {
     printSuccess(formatVerificationLine(acceptance.verdict, acceptance.level));
   }
-  if (acceptance.review?.status === "failed") {
-    printError("Independent review failed");
-    try {
-      const plan = await loadTaskPlan(tasksPath);
-      plan.pipeline.reviewCompleted = false;
-      plan.lastReviewFindings = acceptance.review.findings.map((finding) => finding.claim).join("\n");
-      await saveTaskPlan(tasksPath, plan);
-    } catch {
-    }
-    return 1;
-  }
   const template = await loadPrompt("review");
   const prompt = applyPlaceholders(template, {
     // The repository's own conventions. Empty when it declares none, which is
     // what keeps the rendered prompt identical to the pre-policy one.
-    ...await resolvePolicyPlaceholders(),
+    ...await resolvePolicyPlaceholders({ phase: "review" }),
     __ISSUE_NUMBER__: issueNumber,
     __TASKS_PATH__: tasksPath,
-    ...issuePlaceholders(resolution.resolved)
+    __PROGRESS_FILE__: paths.progressFile,
+    __VERIFY_PATH__: paths.verifyFile,
+    ...issuePlaceholders(resolution.resolved, paths.issueFile)
   });
   const startedAtMs = Date.now();
   let reviewContext;
@@ -134,10 +119,28 @@ async function runReview(issue, resolvedIssue) {
     printError(`Review failed: ${result.error}`);
     return 1;
   }
-  const review = parseReviewResult(result.result);
+  const review = parseIssueReviewResult(result.result);
+  if (!review.ok) {
+    printError(`Invalid review result: ${review.error}`);
+    try {
+      const plan = await loadTaskPlan(tasksPath);
+      plan.pipeline.reviewCompleted = false;
+      plan.issueStatus = "in_progress";
+      plan.completedAt = null;
+      plan.lastError = {
+        category: "review_protocol",
+        message: review.error,
+        at: (/* @__PURE__ */ new Date()).toISOString()
+      };
+      await saveTaskPlan(tasksPath, plan);
+    } catch {
+    }
+    return 1;
+  }
   if (review.status === "PASS") {
     try {
       const plan = await loadTaskPlan(tasksPath);
+      if (plan.lastError?.category === "review_protocol") plan.lastError = null;
       plan.pipeline.reviewCompleted = true;
       plan.lastReviewFindings = null;
       await saveTaskPlan(tasksPath, plan);
@@ -153,6 +156,9 @@ async function runReview(issue, resolvedIssue) {
   try {
     const plan = await loadTaskPlan(tasksPath);
     plan.pipeline.reviewCompleted = false;
+    if (plan.lastError?.category === "review_protocol") plan.lastError = null;
+    plan.issueStatus = "in_progress";
+    plan.completedAt = null;
     plan.lastReviewFindings = review.findings ?? "Unknown findings";
     await saveTaskPlan(tasksPath, plan);
   } catch {
@@ -163,4 +169,4 @@ async function runReview(issue, resolvedIssue) {
 export {
   runReview
 };
-//# sourceMappingURL=chunk-EG2MGDP5.js.map
+//# sourceMappingURL=chunk-Z6RCKCVB.js.map

package/dist/chunk-Z6RCKCVB.js.map

@@ -0,0 +1 @@
+{"version":3,"sources":["../src/verify/review-result.ts","../src/commands/review.ts"],"sourcesContent":["/** Portable issue-review protocol. No host, filesystem or orchestration dependencies. */\nexport type IssueReviewParse =\n  | { ok: true; status: 'PASS' | 'FAIL'; findings?: string }\n  | { ok: false; error: string };\n\nexport function parseIssueReviewResult(output: string): IssueReviewParse {\n  const blocks = [...output.matchAll(/<review-result>([\\s\\S]*?)<\\/review-result>/g)];\n  if (\n    blocks.length !== 1 ||\n    (output.match(/<\\/?review-result>/g)?.length ?? 0) !== 2 ||\n    !output.trimEnd().endsWith('</review-result>')\n  ) {\n    return { ok: false, error: 'Expected exactly one final <review-result> block.' };\n  }\n  const body = blocks[0][1].trim();\n  if (body === 'STATUS: PASS') return { ok: true, status: 'PASS' };\n  const failure = body.match(/^STATUS: FAIL\\s*\\r?\\nFINDINGS:\\s*\\r?\\n([\\s\\S]+)$/);\n  if (failure && !/^STATUS:/m.test(failure[1])) {\n    const lines = failure[1].trim().split(/\\r?\\n/);\n    if (lines.every((line) => /^-\\s+\\S/.test(line))) {\n      return { ok: true, status: 'FAIL', findings: lines.join('\\n') };\n    }\n  }\n  return { ok: false, error: 'Invalid review status or findings; no approval inferred.' };\n}\n","import { DEFAULT_HEADLESS_TIMEOUT_MS, runHeadless } from '../core/headless.js';\nimport { applyPlaceholders, loadPrompt } from '../core/prompt-resolver.js';\nimport { publishPhaseMetrics } from '../core/session-metrics.js';\nimport { loadTaskPlan, saveTaskPlan } from '../core/state-manager.js';\nimport { getGlobalTimeout } from '../core/verbose.js';\nimport { issuePlaceholders, resolveCommandIssue } from '../issues/context.js';\nimport type { ResolvedIssue } from '../issues/types.js';\nimport { resolvePolicyPlaceholders } from '../policy/placeholders.js';\nimport { resolveIssuePaths } from '../storage/resolve.js';\nimport { printError, printSuccess, printWarning } from '../ui/logger.js';\nimport { applyAcceptanceToPlan, runAcceptanceGate } from '../verify/gate.js';\nimport { formatVerificationLine } from '../verify/present.js';\nimport { parseIssueReviewResult } from '../verify/review-result.js';\n\nexport async function runReview(issue: string, resolvedIssue?: ResolvedIssue): Promise<number> {\n  const issueNumber = issue.replace(/^#/, '');\n  const paths = await resolveIssuePaths(issueNumber);\n  const tasksPath = paths.tasksFile;\n\n  const resolution = await resolveCommandIssue(issueNumber, resolvedIssue);\n  if (!resolution.ok) {\n    return resolution.code;\n  }\n\n  const acceptance = await runAcceptanceGate({\n    issueDir: paths.issueDir,\n    addDirs: [paths.issueDir],\n  });\n  if (acceptance.verdict === 'failed') {\n    try {\n      const plan = await loadTaskPlan(tasksPath);\n      const applied = applyAcceptanceToPlan(plan, acceptance);\n      await saveTaskPlan(tasksPath, applied.plan);\n    } catch {\n      printError(formatVerificationLine(acceptance.verdict, acceptance.level));\n    }\n    return 1;\n  }\n  if (acceptance.verdict === 'unverified') {\n    printWarning(formatVerificationLine(acceptance.verdict, acceptance.level));\n  } else {\n    printSuccess(formatVerificationLine(acceptance.verdict, acceptance.level));\n  }\n  const template = await loadPrompt('review');\n  const prompt = applyPlaceholders(template, {\n    // The repository's own conventions. Empty when it declares none, which is\n    // what keeps the rendered prompt identical to the pre-policy one.\n    ...(await resolvePolicyPlaceholders({ phase: 'review' })),\n    __ISSUE_NUMBER__: issueNumber,\n    __TASKS_PATH__: tasksPath,\n    __PROGRESS_FILE__: paths.progressFile,\n    __VERIFY_PATH__: paths.verifyFile,\n    ...issuePlaceholders(resolution.resolved, paths.issueFile),\n  });\n\n  const startedAtMs = Date.now();\n  let reviewContext: { storyIds: string[]; correctionCycle: number } | undefined;\n  try {\n    const plan = await loadTaskPlan(tasksPath);\n    reviewContext = {\n      storyIds: plan.userStories.map((story) => story.id),\n      correctionCycle: plan.correctionCycle,\n    };\n  } catch {\n    reviewContext = undefined;\n  }\n  const result = await runHeadless({\n    prompt,\n    maxTurns: 25,\n    timeout: getGlobalTimeout() ?? DEFAULT_HEADLESS_TIMEOUT_MS,\n    // json (not text) so the CLI reports usage: the envelope's `result` field\n    // carries the same assistant text parseReviewResult() already consumed.\n    outputFormat: 'json',\n    allowedTools: ['Bash', 'Read', 'Glob', 'Grep'],\n    addDirs: [paths.issueDir],\n    statusMessage: `Reviewing issue #${issueNumber} resolution...`,\n    phase: 'review',\n    permission: 'read-only',\n    ...(reviewContext ?? {}),\n  });\n  // Before the success check: the tokens were spent either way. A correction\n  // cycle calls runReview() again and the reducer sums both invocations.\n  publishPhaseMetrics('review', result.cost, startedAtMs, result.agent?.provider);\n\n  if (!result.success) {\n    printError(`Review failed: ${result.error}`);\n    return 1;\n  }\n\n  const review = parseIssueReviewResult(result.result);\n  if (!review.ok) {\n    printError(`Invalid review result: ${review.error}`);\n    try {\n      const plan = await loadTaskPlan(tasksPath);\n      plan.pipeline.reviewCompleted = false;\n      plan.issueStatus = 'in_progress';\n      plan.completedAt = null;\n      plan.lastError = {\n        category: 'review_protocol',\n        message: review.error,\n        at: new Date().toISOString(),\n      };\n      await saveTaskPlan(tasksPath, plan);\n    } catch {\n      /* Standalone review may have no task plan. */\n    }\n    return 1;\n  }\n\n  if (review.status === 'PASS') {\n    // Update pipeline state\n    try {\n      const plan = await loadTaskPlan(tasksPath);\n      if (plan.lastError?.category === 'review_protocol') plan.lastError = null;\n      plan.pipeline.reviewCompleted = true;\n      plan.lastReviewFindings = null;\n      await saveTaskPlan(tasksPath, plan);\n    } catch {\n      // tasks.json may not exist\n    }\n\n    printSuccess('Review PASSED — implementation meets acceptance criteria');\n    return 0;\n  }\n\n  printError('Review FAILED — issues found:');\n  if (review.findings) {\n    console.log(review.findings);\n  }\n\n  // Persist the findings so a correction cycle can act on them: without this,\n  // a re-run of execute sees every userStories[].passes already true and\n  // exits immediately without attempting any fix (see engine.ts's\n  // \"already complete\" guards).\n  try {\n    const plan = await loadTaskPlan(tasksPath);\n    plan.pipeline.reviewCompleted = false;\n    if (plan.lastError?.category === 'review_protocol') plan.lastError = null;\n    plan.issueStatus = 'in_progress';\n    plan.completedAt = null;\n    plan.lastReviewFindings = review.findings ?? 'Unknown findings';\n    await saveTaskPlan(tasksPath, plan);\n  } catch {\n    // tasks.json may not exist\n  }\n\n  return 1;\n}\n"],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAKO,SAAS,uBAAuB,QAAkC;AACvE,QAAM,SAAS,CAAC,GAAG,OAAO,SAAS,6CAA6C,CAAC;AACjF,MACE,OAAO,WAAW,MACjB,OAAO,MAAM,qBAAqB,GAAG,UAAU,OAAO,KACvD,CAAC,OAAO,QAAQ,EAAE,SAAS,kBAAkB,GAC7C;AACA,WAAO,EAAE,IAAI,OAAO,OAAO,oDAAoD;AAAA,EACjF;AACA,QAAM,OAAO,OAAO,CAAC,EAAE,CAAC,EAAE,KAAK;AAC/B,MAAI,SAAS,eAAgB,QAAO,EAAE,IAAI,MAAM,QAAQ,OAAO;AAC/D,QAAM,UAAU,KAAK,MAAM,kDAAkD;AAC7E,MAAI,WAAW,CAAC,YAAY,KAAK,QAAQ,CAAC,CAAC,GAAG;AAC5C,UAAM,QAAQ,QAAQ,CAAC,EAAE,KAAK,EAAE,MAAM,OAAO;AAC7C,QAAI,MAAM,MAAM,CAAC,SAAS,UAAU,KAAK,IAAI,CAAC,GAAG;AAC/C,aAAO,EAAE,IAAI,MAAM,QAAQ,QAAQ,UAAU,MAAM,KAAK,IAAI,EAAE;AAAA,IAChE;AAAA,EACF;AACA,SAAO,EAAE,IAAI,OAAO,OAAO,2DAA2D;AACxF;;;ACVA,eAAsB,UAAU,OAAe,eAAgD;AAC7F,QAAM,cAAc,MAAM,QAAQ,MAAM,EAAE;AAC1C,QAAM,QAAQ,MAAM,kBAAkB,WAAW;AACjD,QAAM,YAAY,MAAM;AAExB,QAAM,aAAa,MAAM,oBAAoB,aAAa,aAAa;AACvE,MAAI,CAAC,WAAW,IAAI;AAClB,WAAO,WAAW;AAAA,EACpB;AAEA,QAAM,aAAa,MAAM,kBAAkB;AAAA,IACzC,UAAU,MAAM;AAAA,IAChB,SAAS,CAAC,MAAM,QAAQ;AAAA,EAC1B,CAAC;AACD,MAAI,WAAW,YAAY,UAAU;AACnC,QAAI;AACF,YAAM,OAAO,MAAM,aAAa,SAAS;AACzC,YAAM,UAAU,sBAAsB,MAAM,UAAU;AACtD,YAAM,aAAa,WAAW,QAAQ,IAAI;AAAA,IAC5C,QAAQ;AACN,iBAAW,uBAAuB,WAAW,SAAS,WAAW,KAAK,CAAC;AAAA,IACzE;AACA,WAAO;AAAA,EACT;AACA,MAAI,WAAW,YAAY,cAAc;AACvC,iBAAa,uBAAuB,WAAW,SAAS,WAAW,KAAK,CAAC;AAAA,EAC3E,OAAO;AACL,iBAAa,uBAAuB,WAAW,SAAS,WAAW,KAAK,CAAC;AAAA,EAC3E;AACA,QAAM,WAAW,MAAM,WAAW,QAAQ;AAC1C,QAAM,SAAS,kBAAkB,UAAU;AAAA;AAAA;AAAA,IAGzC,GAAI,MAAM,0BAA0B,EAAE,OAAO,SAAS,CAAC;AAAA,IACvD,kBAAkB;AAAA,IAClB,gBAAgB;AAAA,IAChB,mBAAmB,MAAM;AAAA,IACzB,iBAAiB,MAAM;AAAA,IACvB,GAAG,kBAAkB,WAAW,UAAU,MAAM,SAAS;AAAA,EAC3D,CAAC;AAED,QAAM,cAAc,KAAK,IAAI;AAC7B,MAAI;AACJ,MAAI;AACF,UAAM,OAAO,MAAM,aAAa,SAAS;AACzC,oBAAgB;AAAA,MACd,UAAU,KAAK,YAAY,IAAI,CAAC,UAAU,MAAM,EAAE;AAAA,MAClD,iBAAiB,KAAK;AAAA,IACxB;AAAA,EACF,QAAQ;AACN,oBAAgB;AAAA,EAClB;AACA,QAAM,SAAS,MAAM,YAAY;AAAA,IAC/B;AAAA,IACA,UAAU;AAAA,IACV,SAAS,iBAAiB,KAAK;AAAA;AAAA;AAAA,IAG/B,cAAc;AAAA,IACd,cAAc,CAAC,QAAQ,QAAQ,QAAQ,MAAM;AAAA,IAC7C,SAAS,CAAC,MAAM,QAAQ;AAAA,IACxB,eAAe,oBAAoB,WAAW;AAAA,IAC9C,OAAO;AAAA,IACP,YAAY;AAAA,IACZ,GAAI,iBAAiB,CAAC;AAAA,EACxB,CAAC;AAGD,sBAAoB,UAAU,OAAO,MAAM,aAAa,OAAO,OAAO,QAAQ;AAE9E,MAAI,CAAC,OAAO,SAAS;AACnB,eAAW,kBAAkB,OAAO,KAAK,EAAE;AAC3C,WAAO;AAAA,EACT;AAEA,QAAM,SAAS,uBAAuB,OAAO,MAAM;AACnD,MAAI,CAAC,OAAO,IAAI;AACd,eAAW,0BAA0B,OAAO,KAAK,EAAE;AACnD,QAAI;AACF,YAAM,OAAO,MAAM,aAAa,SAAS;AACzC,WAAK,SAAS,kBAAkB;AAChC,WAAK,cAAc;AACnB,WAAK,cAAc;AACnB,WAAK,YAAY;AAAA,QACf,UAAU;AAAA,QACV,SAAS,OAAO;AAAA,QAChB,KAAI,oBAAI,KAAK,GAAE,YAAY;AAAA,MAC7B;AACA,YAAM,aAAa,WAAW,IAAI;AAAA,IACpC,QAAQ;AAAA,IAER;AACA,WAAO;AAAA,EACT;AAEA,MAAI,OAAO,WAAW,QAAQ;AAE5B,QAAI;AACF,YAAM,OAAO,MAAM,aAAa,SAAS;AACzC,UAAI,KAAK,WAAW,aAAa,kBAAmB,MAAK,YAAY;AACrE,WAAK,SAAS,kBAAkB;AAChC,WAAK,qBAAqB;AAC1B,YAAM,aAAa,WAAW,IAAI;AAAA,IACpC,QAAQ;AAAA,IAER;AAEA,iBAAa,+DAA0D;AACvE,WAAO;AAAA,EACT;AAEA,aAAW,oCAA+B;AAC1C,MAAI,OAAO,UAAU;AACnB,YAAQ,IAAI,OAAO,QAAQ;AAAA,EAC7B;AAMA,MAAI;AACF,UAAM,OAAO,MAAM,aAAa,SAAS;AACzC,SAAK,SAAS,kBAAkB;AAChC,QAAI,KAAK,WAAW,aAAa,kBAAmB,MAAK,YAAY;AACrE,SAAK,cAAc;AACnB,SAAK,cAAc;AACnB,SAAK,qBAAqB,OAAO,YAAY;AAC7C,UAAM,aAAa,WAAW,IAAI;AAAA,EACpC,QAAQ;AAAA,EAER;AAEA,SAAO;AACT;","names":[]}

package/dist/{chunk-YUNBOUQH.js → chunk-ZPGNVBWY.js}

@@ -1,4 +1,10 @@
 #!/usr/bin/env node
+import {
+  NullPublisher
+} from "./chunk-DIMDAYZS.js";
+import {
+  isoNow
+} from "./chunk-JCR5C5A7.js";
 import {
   getBaseBranch,
   getCommitsSince,
@@ -9,13 +15,7 @@ import {
   normalizeRemoteUrl,
   run,
   stripRemoteUrlCredentials
-} from "./chunk-YVPZUN6X.js";
-import {
-  NullPublisher
-} from "./chunk-DUS5ZNKL.js";
-import {
-  isoNow
-} from "./chunk-SOM4QA6C.js";
+} from "./chunk-KUA6KBBD.js";
 
 // src/core/session-git.ts
 async function listPullRequests(branch, options = {}) {
@@ -112,4 +112,4 @@ export {
   listPullRequests,
   publishGitState
 };
-//# sourceMappingURL=chunk-YUNBOUQH.js.map
+//# sourceMappingURL=chunk-ZPGNVBWY.js.map