israeli-banks-actual-budget-importer 1.5.3 → 1.6.1

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [1.6.1](https://github.com/tomerh2001/israeli-banks-actual-budget-importer/compare/v1.6.0...v1.6.1) (2025-12-04)
+
+
+### Bug Fixes
+
+* update transaction notes to use memo instead of status ([1483fdb](https://github.com/tomerh2001/israeli-banks-actual-budget-importer/commit/1483fdbd35c2e23106ab561926df79797c5b09f8))
+
+# [1.6.0](https://github.com/tomerh2001/israeli-banks-actual-budget-importer/compare/v1.5.3...v1.6.0) (2025-12-02)
+
+
+### Features
+
+* enhance reconciliation process ([5ebf9a6](https://github.com/tomerh2001/israeli-banks-actual-budget-importer/commit/5ebf9a6453aa8db1e6f23fd81d114fbef5c85e5c))
+
 ## [1.5.3](https://github.com/tomerh2001/israeli-banks-actual-budget-importer/compare/v1.5.2...v1.5.3) (2025-11-24)
 
 

package/package.json

@@ -1,5 +1,5 @@
 {
-  "version": "1.5.3",
+  "version": "1.6.1",
   "name": "israeli-banks-actual-budget-importer",
   "module": "index.ts",
   "type": "module",

package/src/utils.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-argument */
 /* eslint-disable @typescript-eslint/no-unsafe-assignment */
 /* eslint-disable @typescript-eslint/naming-convention */
 /* eslint-disable @typescript-eslint/no-unsafe-call */
@@ -53,10 +54,13 @@ export async function scrapeAndImportTransactions({companyId, bank}: ScrapeTrans
 			amount: actual.utils.amountToInteger(x.chargedAmount),
 			payee: _.find(payees, {name: x.description})?.id ?? (await actual.createPayee({name: x.description})),
 			imported_payee: x.description,
-			notes: x.status,
+			notes: x.memo,
 			imported_id: `${x.identifier}-${moment(x.date).format('YYYY-MM-DD HH:mm:ss')}`,
 		}));
 
+		// Print first 5 mapped transactions for debugging
+		log('MAPPED_TRANSACTIONS_SAMPLE', {sample: await Promise.all(mappedTransactions.slice(0, 5))});
+
 		stdout.mute();
 		const importResult = await actual.importTransactions(bank.actualAccountId, await Promise.all(mappedTransactions), {defaultCleared: true});
 		stdout.unmute();
@@ -74,27 +78,68 @@ export async function scrapeAndImportTransactions({companyId, bank}: ScrapeTrans
 
 		const currentBalance = actual.utils.integerToAmount(await actual.getAccountBalance(bank.actualAccountId));
 		const balanceDiff = accountBalance - currentBalance;
+
+		// Use a stable imported_id per account so we can find and update/delete the same
+		// reconciliation transaction instead of creating a new one every run.
+		const reconciliationImportedId = `reconciliation-${bank.actualAccountId}`;
+
+		// Fetch all transactions for this account and look for an existing reconciliation.
+		// Use a wide date range so we always find it if it exists.
+		const allAccountTxns: TransactionEntity[] = await actual.getTransactions(
+			bank.actualAccountId,
+			'2000-01-01',
+			moment().add(1, 'year').format('YYYY-MM-DD'),
+		);
+
+		const existingReconciliation = allAccountTxns.find(txn => txn.imported_id === reconciliationImportedId);
+
+		// If balances are already in sync, remove any existing reconciliation and exit.
 		if (balanceDiff === 0) {
+			if (existingReconciliation) {
+				stdout.mute();
+				await actual.deleteTransaction(existingReconciliation.id);
+				stdout.unmute();
+				log('RECONCILIATION_REMOVED');
+			}
+
 			return;
 		}
 
-		log('RECONCILIATION', {from: currentBalance, to: accountBalance, diff: balanceDiff});
+		log('RECONCILIATION', {
+			from: currentBalance,
+			to: accountBalance,
+			diff: balanceDiff,
+		});
 
-		stdout.mute();
-		const reconciliationResult = await actual.importTransactions(bank.actualAccountId, [{
+		const reconciliationTxn = {
+			account: bank.actualAccountId,
 			date: moment().format('YYYY-MM-DD'),
 			amount: actual.utils.amountToInteger(balanceDiff),
-			payee: null,
+			payee: undefined,
 			imported_payee: 'Reconciliation',
 			notes: `Reconciliation from ${currentBalance.toLocaleString()} to ${accountBalance.toLocaleString()}`,
-			imported_id: `reconciliation-${moment().format('YYYY-MM-DD HH:mm:ss')}`,
-		}]);
-		stdout.unmute();
+			imported_id: reconciliationImportedId,
+		};
 
-		if (_.isEmpty(reconciliationResult)) {
-			console.error('Reconciliation errors', reconciliationResult.errors);
+		stdout.mute();
+		if (existingReconciliation) {
+			// Update the single reconciliation transaction
+			await actual.updateTransaction(existingReconciliation.id, reconciliationTxn);
+			stdout.unmute();
+			log('RECONCILIATION_UPDATED', {transactionId: existingReconciliation.id});
 		} else {
-			log('RECONCILIATION_ADDED', {transactions: reconciliationResult.added.length});
+			// Create the reconciliation transaction for the first time
+			const reconciliationResult = await actual.importTransactions(
+				bank.actualAccountId,
+				[reconciliationTxn],
+			);
+			stdout.unmute();
+
+			if (!reconciliationResult || _.isEmpty(reconciliationResult.added)) {
+				console.error('Reconciliation errors', reconciliationResult?.errors);
+			} else {
+				log('RECONCILIATION_ADDED', {transactions: reconciliationResult.added.length});
+			}
 		}
 	} catch (error) {
 		console.error('Error', companyId, error);
@@ -102,4 +147,3 @@ export async function scrapeAndImportTransactions({companyId, bank}: ScrapeTrans
 		log('DONE');
 	}
 }
-