israeli-banks-actual-budget-importer 1.5.2 → 1.6.0

package/.yarnrc.yml

@@ -1,3 +1,3 @@
 nodeLinker: node-modules
 
-yarnPath: .yarn/releases/yarn-4.9.2.cjs
+yarnPath: .yarn/releases/yarn-4.12.0.cjs

package/CHANGELOG.md

@@ -1,3 +1,18 @@
+# [1.6.0](https://github.com/tomerh2001/israeli-banks-actual-budget-importer/compare/v1.5.3...v1.6.0) (2025-12-02)
+
+
+### Features
+
+* enhance reconciliation process ([5ebf9a6](https://github.com/tomerh2001/israeli-banks-actual-budget-importer/commit/5ebf9a6453aa8db1e6f23fd81d114fbef5c85e5c))
+
+## [1.5.3](https://github.com/tomerh2001/israeli-banks-actual-budget-importer/compare/v1.5.2...v1.5.3) (2025-11-24)
+
+
+### Bug Fixes
+
+* update Node.js version to 24 and adjust file permissions ([a4a2658](https://github.com/tomerh2001/israeli-banks-actual-budget-importer/commit/a4a2658537057f4a5a8a4c1888791b94ec987577))
+* Updated packages to latest version ([91c3f6b](https://github.com/tomerh2001/israeli-banks-actual-budget-importer/commit/91c3f6bf57cbbc2a9f17925d13a393ebd9746510))
+
 ## [1.5.2](https://github.com/tomerh2001/israeli-banks-actual-budget-importer/compare/v1.5.1...v1.5.2) (2025-06-09)
 
 

package/package.json

@@ -1,5 +1,5 @@
 {
-  "version": "1.5.2",
+  "version": "1.6.0",
   "name": "israeli-banks-actual-budget-importer",
   "module": "index.ts",
   "type": "module",
@@ -12,27 +12,27 @@
     "@semantic-release/changelog": "^6.0.3",
     "@semantic-release/commit-analyzer": "^13.0.1",
     "@semantic-release/git": "^10.0.1",
-    "@semantic-release/github": "^11.0.3",
-    "@semantic-release/npm": "^12.0.1",
-    "@semantic-release/release-notes-generator": "^14.0.3",
-    "@types/lodash": "^4.17.17",
-    "@types/papaparse": "^5.3.16",
+    "@semantic-release/github": "^12.0.2",
+    "@semantic-release/npm": "^13.1.2",
+    "@semantic-release/release-notes-generator": "^14.1.0",
+    "@types/lodash": "^4.17.21",
+    "@types/papaparse": "^5.5.0",
     "bun-types": "latest",
     "papaparse": "^5.5.3",
-    "semantic-release": "^24.2.5",
-    "typescript": "^5.8.3",
-    "xo": "^1.1.0"
+    "semantic-release": "^25.0.2",
+    "typescript": "^5.9.3",
+    "xo": "^1.2.3"
   },
-  "packageManager": "yarn@4.9.2",
+  "packageManager": "yarn@4.12.0",
   "dependencies": {
-    "@actual-app/api": "^25.6.1",
-    "cronstrue": "^2.61.0",
-    "israeli-bank-scrapers": "^6.1.3",
+    "@actual-app/api": "^25.11.0",
+    "cronstrue": "^3.9.0",
+    "israeli-bank-scrapers": "^6.2.5",
     "lodash": "^4.17.21",
     "moment": "^2.30.1",
     "mute-stdout": "^2.0.0",
-    "node-cron": "^4.1.0",
-    "p-queue": "^8.1.0",
-    "tsx": "^4.19.4"
+    "node-cron": "^4.2.1",
+    "p-queue": "^9.0.1",
+    "tsx": "^4.20.6"
   }
 }

package/src/config.d.ts

@@ -16,9 +16,7 @@ export type ConfigActualBudget = {
 	password: string;
 };
 
-export type ConfigBanks = Partial<{
-	[key in CompanyTypes]: ConfigBank;
-}>;
+export type ConfigBanks = Partial<Record<CompanyTypes, ConfigBank>>;
 
 export type ConfigBank = ScraperCredentials & {
 	actualAccountId: string;

package/src/index.ts

@@ -2,7 +2,6 @@
 /* eslint-disable unicorn/no-process-exit */
 
 /* eslint-disable no-await-in-loop */
-/* eslint-disable n/file-extension-in-import */
 
 import process from 'node:process';
 import {type CompanyTypes} from 'israeli-bank-scrapers';

package/src/utils.ts

@@ -1,10 +1,8 @@
+/* eslint-disable @typescript-eslint/no-unsafe-argument */
 /* eslint-disable @typescript-eslint/no-unsafe-assignment */
 /* eslint-disable @typescript-eslint/naming-convention */
 /* eslint-disable @typescript-eslint/no-unsafe-call */
 
-/* eslint-disable import/extensions */
-/* eslint-disable n/file-extension-in-import */
-
 import process from 'node:process';
 import {createScraper, type ScraperCredentials} from 'israeli-bank-scrapers';
 import _ from 'lodash';
@@ -77,27 +75,68 @@ export async function scrapeAndImportTransactions({companyId, bank}: ScrapeTrans
 
 		const currentBalance = actual.utils.integerToAmount(await actual.getAccountBalance(bank.actualAccountId));
 		const balanceDiff = accountBalance - currentBalance;
+
+		// Use a stable imported_id per account so we can find and update/delete the same
+		// reconciliation transaction instead of creating a new one every run.
+		const reconciliationImportedId = `reconciliation-${bank.actualAccountId}`;
+
+		// Fetch all transactions for this account and look for an existing reconciliation.
+		// Use a wide date range so we always find it if it exists.
+		const allAccountTxns: TransactionEntity[] = await actual.getTransactions(
+			bank.actualAccountId,
+			'2000-01-01',
+			moment().add(1, 'year').format('YYYY-MM-DD'),
+		);
+
+		const existingReconciliation = allAccountTxns.find(txn => txn.imported_id === reconciliationImportedId);
+
+		// If balances are already in sync, remove any existing reconciliation and exit.
 		if (balanceDiff === 0) {
+			if (existingReconciliation) {
+				stdout.mute();
+				await actual.deleteTransaction(existingReconciliation.id);
+				stdout.unmute();
+				log('RECONCILIATION_REMOVED');
+			}
+
 			return;
 		}
 
-		log('RECONCILIATION', {from: currentBalance, to: accountBalance, diff: balanceDiff});
+		log('RECONCILIATION', {
+			from: currentBalance,
+			to: accountBalance,
+			diff: balanceDiff,
+		});
 
-		stdout.mute();
-		const reconciliationResult = await actual.importTransactions(bank.actualAccountId, [{
+		const reconciliationTxn = {
+			account: bank.actualAccountId,
 			date: moment().format('YYYY-MM-DD'),
 			amount: actual.utils.amountToInteger(balanceDiff),
-			payee: null,
+			payee: undefined,
 			imported_payee: 'Reconciliation',
 			notes: `Reconciliation from ${currentBalance.toLocaleString()} to ${accountBalance.toLocaleString()}`,
-			imported_id: `reconciliation-${moment().format('YYYY-MM-DD HH:mm:ss')}`,
-		}]);
-		stdout.unmute();
+			imported_id: reconciliationImportedId,
+		};
 
-		if (_.isEmpty(reconciliationResult)) {
-			console.error('Reconciliation errors', reconciliationResult.errors);
+		stdout.mute();
+		if (existingReconciliation) {
+			// Update the single reconciliation transaction
+			await actual.updateTransaction(existingReconciliation.id, reconciliationTxn);
+			stdout.unmute();
+			log('RECONCILIATION_UPDATED', {transactionId: existingReconciliation.id});
 		} else {
-			log('RECONCILIATION_ADDED', {transactions: reconciliationResult.added.length});
+			// Create the reconciliation transaction for the first time
+			const reconciliationResult = await actual.importTransactions(
+				bank.actualAccountId,
+				[reconciliationTxn],
+			);
+			stdout.unmute();
+
+			if (!reconciliationResult || _.isEmpty(reconciliationResult.added)) {
+				console.error('Reconciliation errors', reconciliationResult?.errors);
+			} else {
+				log('RECONCILIATION_ADDED', {transactions: reconciliationResult.added.length});
+			}
 		}
 	} catch (error) {
 		console.error('Error', companyId, error);
@@ -105,4 +144,3 @@ export async function scrapeAndImportTransactions({companyId, bank}: ScrapeTrans
 		log('DONE');
 	}
 }
-