isomorphic-jj 1.8.0 → 1.9.2

package/src/core/merge-driver-registry.js

@@ -6,6 +6,7 @@
  */
 
 import { JJError } from '../utils/errors.js';
+import { isBytes, utf8Encode, utf8Decode } from '../utils/bytes.js';
 
 /**
  * Check if a file path matches a glob pattern
@@ -38,11 +39,11 @@ function matchesPattern(path, pattern) {
 /**
  * Check if a file is likely binary based on content
  *
- * @param {string|Buffer} content - File content
+ * @param {string|Uint8Array} content - File content
  * @returns {boolean} Whether content appears binary
  */
 function isBinaryContent(content) {
-  if (Buffer.isBuffer(content)) return true;
+  if (isBytes(content)) return true;
   if (typeof content !== 'string') return false;
 
   // Check for null bytes (common in binary files)
@@ -357,9 +358,9 @@ export class MergeDriverRegistry {
   /**
    * Prepare content for driver based on binary/text
    *
-   * @param {string|Buffer|null} content - Raw content
-   * @param {boolean} isBinary - Whether to return as Buffer
-   * @returns {string|Buffer|null} Prepared content
+   * @param {string|Uint8Array|null} content - Raw content
+   * @param {boolean} isBinary - Whether to return as bytes
+   * @returns {string|Uint8Array|null} Prepared content
    */
   prepareContent(content, isBinary) {
     if (content === null || content === undefined) {
@@ -367,14 +368,14 @@ export class MergeDriverRegistry {
     }
 
     if (isBinary) {
-      // Convert to Buffer if needed
-      if (Buffer.isBuffer(content)) return content;
-      if (typeof content === 'string') return Buffer.from(content, 'utf-8');
-      return Buffer.from(String(content));
+      // Convert to bytes if needed
+      if (isBytes(content)) return content;
+      if (typeof content === 'string') return utf8Encode(content);
+      return utf8Encode(String(content));
     } else {
       // Convert to string if needed
       if (typeof content === 'string') return content;
-      if (Buffer.isBuffer(content)) return content.toString('utf-8');
+      if (isBytes(content)) return utf8Decode(content);
       return String(content);
     }
   }

package/src/core/revset-engine.js

@@ -539,9 +539,12 @@ export class RevsetEngine {
     const unquote = (/** @type {string} */ s) => s.trim().replace(/^['"]|['"]$/g, '');
 
     switch (name) {
-      case 'all':
+      case 'all': {
         await this.graph.load();
-        return this.graph.getAll().map((c) => c.changeId);
+        const allChanges = this.graph.getAll();
+        const hidden = await this._computeHiddenOrphans(allChanges);
+        return allChanges.filter((c) => !hidden.has(c.changeId)).map((c) => c.changeId);
+      }
 
       // `builtin_log()` (jj v0.44) is the revset the built-in `jj log` uses
       // when no user override is configured. isomorphic-jj's `log()` already
@@ -549,9 +552,12 @@ export class RevsetEngine {
       // `builtin_log()` is a pure alias for that same default — this lets
       // callers compose it (e.g. `builtin_log() & mine()`) instead of
       // duplicating `all()`.
-      case 'builtin_log':
+      case 'builtin_log': {
         await this.graph.load();
-        return this.graph.getAll().map((c) => c.changeId);
+        const allChanges = this.graph.getAll();
+        const hidden = await this._computeHiddenOrphans(allChanges);
+        return allChanges.filter((c) => !hidden.has(c.changeId)).map((c) => c.changeId);
+      }
 
       case 'none':
         return [];
@@ -666,15 +672,27 @@ export class RevsetEngine {
       }
 
       case 'divergent': {
+        // See issue #32 / converge(): a divergent change has more than one
+        // visible commit sharing its changeId (added via
+        // ChangeGraph.addDivergentCopy(), which is why counting `changeId`
+        // occurrences across getAll() actually finds something now —
+        // every other change has exactly one entry here). `c.divergent ===
+        // true` also matches directly, since addDivergentCopy() sets that
+        // flag on the copy it adds; the count check catches the *primary*
+        // copy too (it's never itself flagged, since nothing about IT
+        // changed) so both/all copies of a divergent changeId are
+        // reported, not just the one(s) added after the first.
         await this.graph.load();
         const all = this.graph.getAll();
         const counts = new Map();
         for (const c of all) {
           counts.set(c.changeId, (counts.get(c.changeId) || 0) + 1);
         }
-        return all
-          .filter((c) => c.divergent === true || counts.get(c.changeId) > 1)
-          .map((c) => c.changeId);
+        const matched = all.filter((c) => c.divergent === true || counts.get(c.changeId) > 1);
+        // De-duplicate: multiple copies of the same divergent changeId
+        // would otherwise each contribute their own (identical) changeId
+        // to the result.
+        return Array.from(new Set(matched.map((c) => c.changeId)));
       }
 
       case 'merges':
@@ -1000,6 +1018,108 @@ export class RevsetEngine {
     return ancestors;
   }
 
+  /**
+   * Change IDs that `all()`/`builtin_log()` (and therefore the default
+   * `jj.log()`) should exclude — issue #37(b).
+   *
+   * undo()/redo()/operations.restore() deliberately don't delete a change
+   * record for a `new()`/`squash()` that gets reverted — they only un-ref
+   * it (restore the working-copy pointer/heads that made it reachable),
+   * matching real jj where an unreachable change stays resolvable by its
+   * change id (hidden, not gone) until explicitly gc'd — see
+   * computeGraphReversal's doc comment in repository.js. But that means
+   * the orphaned change record lingers in the graph, and before this fix
+   * `all()` (a flat `graph.getAll()`) surfaced it in `log()` right
+   * alongside everything still actually reachable.
+   *
+   * Real jj hides a commit from the default log when it is BOTH:
+   *   - unreachable from any visible head (not itself a head, and not an
+   *     ancestor of one), AND
+   *   - "discardable": empty (no file diff versus its own parent) and
+   *     undescribed.
+   * Merge commits (2+ parents) are conservatively never treated as
+   * "empty" here — real jj's diff-emptiness rule for merges is more
+   * involved and isn't needed by anything this package creates today.
+   *
+   * "Visible head" here deliberately does NOT mean "any change with no
+   * children" (that's what the `visible_heads()` revset function computes,
+   * structurally, from the raw graph) — an orphan `new()`/`squash()`
+   * change that undo() un-referenced has no children EITHER, so it would
+   * trivially count as its own head under that definition and never be
+   * excludable. Real jj instead tracks an explicit, maintained set of
+   * heads in its View (updated as operations run — abandoning/squashing a
+   * change removes it, rebasing children onto a new parent removes the
+   * old parent, etc.). This package doesn't thread the operation log's
+   * `view.heads` through to the revset engine, but the working-copy
+   * pointer plus every bookmark/tag target is the closest available
+   * proxy for "what's actually still in play" — anything only reachable
+   * from those, not from every dangling graph leaf.
+   *
+   * @param {any[]} allChanges - `graph.getAll()`
+   * @returns {Promise<Set<string>>} change IDs to exclude
+   */
+  async _computeHiddenOrphans(allChanges) {
+    const trackedHeads = new Set();
+    try {
+      const wcId = this.workingCopy && this.workingCopy.getCurrentChangeId();
+      if (wcId) trackedHeads.add(wcId);
+    } catch {
+      // working copy not loaded/available — fine, just no wc-based root.
+    }
+    if (this.bookmarkStore) {
+      await this.bookmarkStore.load();
+      for (const bookmark of await this.bookmarkStore.list()) {
+        if (bookmark && bookmark.changeId) trackedHeads.add(bookmark.changeId);
+      }
+    }
+    if (this.tagStore) {
+      for (const tag of await this.tagStore.list()) {
+        if (tag && tag.changeId) trackedHeads.add(tag.changeId);
+      }
+    }
+
+    const reachable = new Set();
+    for (const headId of trackedHeads) {
+      for (const id of await this.getAncestors(headId)) {
+        reachable.add(id);
+      }
+    }
+
+    // Sentinel "no message given" descriptions this package itself writes
+    // (new()'s '(no description)', squash()'s post-squash working-copy
+    // change '(no description set)') are, for visibility purposes, just
+    // as undescribed as a genuinely empty/missing description field.
+    const UNDESCRIBED = new Set([undefined, null, '', '(no description)', '(no description set)']);
+
+    const byId = new Map(allChanges.map((c) => [c.changeId, c]));
+    const isEmpty = (/** @type {any} */ change) => {
+      const parents = change.parents || [];
+      if (parents.length === 0) {
+        return !change.fileSnapshot || Object.keys(change.fileSnapshot).length === 0;
+      }
+      if (parents.length > 1) return false; // merges: not handled by this rule
+      const parent = byId.get(parents[0]);
+      const parentSnapshot = (parent && parent.fileSnapshot) || {};
+      const ownSnapshot = change.fileSnapshot || {};
+      const parentKeys = Object.keys(parentSnapshot);
+      const ownKeys = Object.keys(ownSnapshot);
+      if (parentKeys.length !== ownKeys.length) return false;
+      return parentKeys.every((k) => parentSnapshot[k] === ownSnapshot[k]);
+    };
+
+    const hidden = new Set();
+    for (const change of allChanges) {
+      if (
+        !reachable.has(change.changeId) &&
+        isEmpty(change) &&
+        UNDESCRIBED.has(change.description)
+      ) {
+        hidden.add(change.changeId);
+      }
+    }
+    return hidden;
+  }
+
   /**
    * Resolve a revset argument to a set of change IDs (v1.5).
    *

package/src/core/storage-manager.js

@@ -6,6 +6,7 @@
 
 import { JJError } from '../utils/errors.js';
 import { KeyedMutex } from '../utils/mutex.js';
+import { mkdirp } from '../utils/mkdirp.js';
 
 export class Storage {
   /**
@@ -40,17 +41,17 @@ export class Storage {
   async init() {
     try {
       // Create main directories
-      await this.fs.promises.mkdir(this.jjDir, { recursive: true });
-      await this.fs.promises.mkdir(this.repoDir, { recursive: true });
-      await this.fs.promises.mkdir(this.workingCopyDir, { recursive: true });
+      await mkdirp(this.fs, this.jjDir);
+      await mkdirp(this.fs, this.repoDir);
+      await mkdirp(this.fs, this.workingCopyDir);
 
       // Create repo subdirectories
-      await this.fs.promises.mkdir(`${this.repoDir}/store`, { recursive: true });
-      await this.fs.promises.mkdir(`${this.repoDir}/op_log`, { recursive: true });
-      await this.fs.promises.mkdir(`${this.repoDir}/conflicts`, { recursive: true });
+      await mkdirp(this.fs, `${this.repoDir}/store`);
+      await mkdirp(this.fs, `${this.repoDir}/op_log`);
+      await mkdirp(this.fs, `${this.repoDir}/conflicts`);
 
       // Create default workspace directory
-      await this.fs.promises.mkdir(`${this.workingCopyDir}/default`, { recursive: true });
+      await mkdirp(this.fs, `${this.workingCopyDir}/default`);
     } catch (error) {
       throw new JJError(
         'STORAGE_INIT_FAILED',
@@ -127,7 +128,7 @@ export class Storage {
     try {
       // Ensure parent directory exists
       const dirPath = fullPath.substring(0, fullPath.lastIndexOf('/'));
-      await this.fs.promises.mkdir(dirPath, { recursive: true });
+      await mkdirp(this.fs, dirPath);
 
       // Write to temp file
       await this.fs.promises.writeFile(tmpPath, jsonData, 'utf8');

package/src/core/tag-store.js

@@ -6,6 +6,7 @@
  */
 
 import { JJError } from '../utils/errors.js';
+import { mkdirp } from '../utils/mkdirp.js';
 
 /**
  * Validates tag name format
@@ -100,11 +101,7 @@ export class TagStore {
   async save(tags) {
     // Ensure the store directory exists
     const storeDir = `${this.jjDir}/store`;
-    try {
-      await this.fs.promises.mkdir(storeDir, { recursive: true });
-    } catch (err) {
-      // Directory might already exist, ignore
-    }
+    await mkdirp(this.fs, storeDir);
     await this.fs.promises.writeFile(
       this.tagsFile,
       JSON.stringify({ tags, tracked: this.tracking || {} }, null, 2)

package/src/core/working-copy.js

@@ -7,6 +7,44 @@
 import { JJError } from '../utils/errors.js';
 import { validateChangeId, validatePath } from '../utils/validation.js';
 
+/**
+ * Normalize an mtime value to a millisecond epoch number so two stat()
+ * results (or a stat() result and a stored value) can be compared by VALUE
+ * instead of by object identity (see issue #41).
+ *
+ * `fs.promises.stat()` returns a fresh `Date` instance on every call, so two
+ * separate stats of the same unchanged file are never `===`/`!==`-equal even
+ * when the underlying timestamp is identical. Additionally, once a tracked
+ * mtime has been through a `JSON.stringify`/`JSON.parse` round-trip (Storage
+ * persists working-copy state as JSON), a `Date` becomes an ISO string, not a
+ * `Date` — so the stored side of the comparison may be a `Date`, a plain
+ * epoch-ms number (this module now stores numbers going forward), or an ISO
+ * string (older/reloaded-from-disk state). This normalizes all three to a
+ * comparable number.
+ *
+ * Deliberately duck-types the Date case (`typeof value.getTime ===
+ * 'function'`) instead of `value instanceof Date`: Node's built-in `fs`
+ * module constructs `Stats.mtime` using its own realm's `Date`, which is not
+ * always the same `Date` constructor as this module's under test runners
+ * that sandbox each test file in its own VM context (observed under Jest
+ * with `--experimental-vm-modules`) — there, a real `Date` instance from
+ * `fs.promises.stat()` fails `instanceof Date` here even though it's a
+ * genuine Date. Duck-typing survives that realm mismatch.
+ *
+ * @param {Date|number|string|undefined} value
+ * @returns {number}
+ */
+function mtimeMs(value) {
+  if (value === null || value === undefined) return NaN;
+  if (typeof value === 'number') return value;
+  if (typeof value === 'string') return new Date(value).getTime();
+  // Per the type contract above, anything left is Date-like -- duck-typed
+  // (see the comment above) rather than `instanceof Date`, so no runtime
+  // check is needed here either; a value outside this contract is a caller
+  // bug, not something to silently coerce.
+  return /** @type {any} */ (value).getTime();
+}
+
 export class WorkingCopy {
   /**
    * @param {Storage} storage - Storage manager instance
@@ -178,8 +216,10 @@ export class WorkingCopy {
       try {
         const stats = await this.fs.promises.stat(fullPath);
 
-        // Fast path: check mtime and size
-        if (stats.mtime !== tracked.mtime || stats.size !== tracked.size) {
+        // Fast path: check mtime and size. Compare by VALUE (see mtimeMs
+        // above) — comparing the raw stat()/stored values with !== is
+        // always "different" even when nothing changed (issue #41).
+        if (mtimeMs(stats.mtime) !== mtimeMs(tracked.mtime) || stats.size !== tracked.size) {
           modified.push(path);
         }
       } catch (error) {
@@ -290,12 +330,19 @@ export class WorkingCopy {
       }
 
       const prev = this.state.fileStates[rel];
-      const next = { mtime: stats.mtime, size: stats.size, mode: stats.mode };
+      // Store mtime as a plain epoch-ms number (not the raw stat() value):
+      // numbers round-trip through JSON exactly, so state reloaded from disk
+      // later compares identically to state still cached in-memory. Goes
+      // through mtimeMs() rather than assuming `.getTime()` exists directly —
+      // some fs implementations (e.g. the in-memory mock used in tests)
+      // return mtime as a plain epoch-ms number already, not a Date (see
+      // mtimeMs above and issue #41).
+      const next = { mtime: mtimeMs(stats.mtime), size: stats.size, mode: stats.mode };
 
       if (!prev) {
         this.state.fileStates[rel] = next;
         added.push(rel);
-      } else if (prev.mtime !== stats.mtime || prev.size !== stats.size) {
+      } else if (mtimeMs(stats.mtime) !== mtimeMs(prev.mtime) || prev.size !== stats.size) {
         this.state.fileStates[rel] = next;
         modified.push(rel);
       }

package/src/core/workspace-manager.js

@@ -10,7 +10,8 @@
 import { JJError } from '../utils/errors.js';
 import { validateChangeId } from '../utils/validation.js';
 import { generateId } from '../utils/id-generation.js';
-import path from 'path';
+import * as path from '../utils/posix-path.js';
+import { mkdirp } from '../utils/mkdirp.js';
 
 export class WorkspaceManager {
   /**
@@ -108,11 +109,11 @@ export class WorkspaceManager {
     };
 
     // Create workspace directory
-    await this.fs.promises.mkdir(args.path, { recursive: true });
+    await mkdirp(this.fs, args.path);
 
     // Create workspace-specific working_copy directory in .jj
     const workspaceCopyDir = path.join(this.repoDir, '.jj', 'working_copy', workspaceId);
-    await this.fs.promises.mkdir(workspaceCopyDir, { recursive: true });
+    await mkdirp(this.fs, workspaceCopyDir);
 
     // Create .git file pointing to main repo's .git directory
     // This allows Git tools to work in the workspace

package/src/protos/local_working_copy.json.js

@@ -0,0 +1,146 @@
+/**
+ * Precompiled protobuf reflection JSON for local_working_copy.proto
+ *
+ * Generated from src/protos/local_working_copy.proto by scripts/build-protos.mjs. This
+ * is bundled directly (instead of loaded from a filesystem path at runtime)
+ * so that protobuf schema loading works identically in Node and in browser
+ * bundles — protobuf.load() requires filesystem/network access that does
+ * not exist in a browser bundle (see issue #28). Regenerate with:
+ *   node scripts/build-protos.mjs
+ */
+
+export default {
+  nested: {
+    local_working_copy: {
+      nested: {
+        FileType: {
+          valuesOptions: {
+            Conflict: {
+              deprecated: true,
+            },
+          },
+          values: {
+            Normal: 0,
+            Symlink: 1,
+            Executable: 2,
+            Conflict: 3,
+            GitSubmodule: 4,
+          },
+        },
+        MaterializedConflictData: {
+          fields: {
+            conflictMarkerLen: {
+              type: 'uint32',
+              id: 1,
+            },
+          },
+        },
+        FileState: {
+          fields: {
+            mtimeMillisSinceEpoch: {
+              type: 'int64',
+              id: 1,
+            },
+            size: {
+              type: 'uint64',
+              id: 2,
+            },
+            fileType: {
+              type: 'FileType',
+              id: 3,
+            },
+            materializedConflictData: {
+              type: 'MaterializedConflictData',
+              id: 5,
+            },
+          },
+          reserved: [[4, 4]],
+        },
+        FileStateEntry: {
+          fields: {
+            path: {
+              type: 'string',
+              id: 1,
+            },
+            state: {
+              type: 'FileState',
+              id: 2,
+            },
+          },
+        },
+        SparsePatterns: {
+          fields: {
+            prefixes: {
+              rule: 'repeated',
+              type: 'string',
+              id: 1,
+            },
+          },
+        },
+        TreeState: {
+          fields: {
+            legacyTreeId: {
+              type: 'bytes',
+              id: 1,
+              options: {
+                deprecated: true,
+              },
+            },
+            treeIds: {
+              rule: 'repeated',
+              type: 'bytes',
+              id: 5,
+            },
+            fileStates: {
+              rule: 'repeated',
+              type: 'FileStateEntry',
+              id: 2,
+            },
+            isFileStatesSorted: {
+              type: 'bool',
+              id: 6,
+            },
+            sparsePatterns: {
+              type: 'SparsePatterns',
+              id: 3,
+            },
+            watchmanClock: {
+              type: 'WatchmanClock',
+              id: 4,
+            },
+          },
+        },
+        WatchmanClock: {
+          oneofs: {
+            watchmanClock: {
+              oneof: ['stringClock', 'unixTimestamp'],
+            },
+          },
+          fields: {
+            stringClock: {
+              type: 'string',
+              id: 1,
+            },
+            unixTimestamp: {
+              type: 'int64',
+              id: 2,
+            },
+          },
+        },
+        Checkout: {
+          fields: {
+            operationId: {
+              type: 'bytes',
+              id: 2,
+            },
+            workspaceName: {
+              type: 'string',
+              id: 3,
+            },
+          },
+          reserved: [[1, 1]],
+        },
+      },
+    },
+  },
+};

package/src/protos/schema.js

@@ -0,0 +1,49 @@
+/**
+ * Protobuf schema loader
+ *
+ * Builds protobuf.js `Root` instances from precompiled reflection JSON
+ * (see local_working_copy.json.js / simple_op_store.json.js, generated from
+ * the .proto files in this directory) instead of calling `protobuf.load()`
+ * against a filesystem path.
+ *
+ * Why: `protobuf.load()` resolves its argument as a file path (Node `fs`) or
+ * URL (XHR/fetch), which requires either a real filesystem or a network
+ * request. In a bundled browser build there is no filesystem path to read
+ * (see issue #28), and shipping the raw .proto text and fetching it at
+ * runtime would require bundler-specific asset handling. Reflection JSON is
+ * plain data, so it can be imported like any other JS module and works
+ * identically under Node, Jest, and any browser bundler (Vite, esbuild,
+ * webpack, Rollup, ...).
+ *
+ * Regenerate the JSON files after editing a .proto with:
+ *   npm run build:protos
+ */
+
+import protobuf from 'protobufjs/light.js';
+import localWorkingCopyJson from './local_working_copy.json.js';
+import simpleOpStoreJson from './simple_op_store.json.js';
+
+/** @type {protobuf.Root|undefined} */
+let localWorkingCopyRoot;
+/** @type {protobuf.Root|undefined} */
+let simpleOpStoreRoot;
+
+/**
+ * @returns {protobuf.Root} Root for local_working_copy.proto (Checkout, TreeState, ...)
+ */
+export function getLocalWorkingCopyRoot() {
+  if (!localWorkingCopyRoot) {
+    localWorkingCopyRoot = protobuf.Root.fromJSON(localWorkingCopyJson);
+  }
+  return localWorkingCopyRoot;
+}
+
+/**
+ * @returns {protobuf.Root} Root for simple_op_store.proto (Operation, View, ...)
+ */
+export function getSimpleOpStoreRoot() {
+  if (!simpleOpStoreRoot) {
+    simpleOpStoreRoot = protobuf.Root.fromJSON(simpleOpStoreJson);
+  }
+  return simpleOpStoreRoot;
+}