isomorphic-git 1.25.8 → 1.25.10

package/README.md

@@ -370,6 +370,7 @@ Thanks goes to these wonderful people ([emoji key](https://github.com/kentcdodds
     <td align="center"><a href="https://github.com/yarikoptic"><img src="https://avatars.githubusercontent.com/u/39889?v=4?s=60" width="60px;" alt=""/><br /><sub><b>Yaroslav Halchenko</b></sub></a><br /><a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=yarikoptic" title="Documentation">📖</a></td>
     <td align="center"><a href="https://alex-v.blog/"><img src="https://avatars.githubusercontent.com/u/716334?v=4?s=60" width="60px;" alt=""/><br /><sub><b>Alex Villarreal</b></sub></a><br /><a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=alexvy86" title="Code">💻</a></td>
     <td align="center"><a href="https://github.com/amrc-benmorrow"><img src="https://avatars.githubusercontent.com/u/120477944?v=4?s=60" width="60px;" alt=""/><br /><sub><b>Ben Morrow</b></sub></a><br /><a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=amrc-benmorrow" title="Code">💻</a></td>
+    <td align="center"><a href="https://github.com/jayree"><img src="https://avatars.githubusercontent.com/u/14836154?v=4?s=60" width="60px;" alt=""/><br /><sub><b>jayree</b></sub></a><br /><a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=jayree" title="Code">💻</a> <a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=jayree" title="Tests">⚠️</a></td>
   </tr>
 </table>
 

package/browser-tests.json

@@ -1,8 +1,10 @@
 [
   "Chrome Headless 79.0.3945.0 (Linux x86_64)",
   "Firefox 125.0 (Ubuntu 0.0.0)",
-  "Chrome 123.0.0.0 (Android 10)",
+  "X Chrome 123.0.0.0 (Android 10)",
   "Edge 79.0.309.65 (Windows 10)",
+  "Safari 13.1 (Mac OS 10.15.4)",
   "Mobile Safari 13.0 (iOS 13.0)",
-  "Safari 13.1 (Mac OS 10.15.4)"
+  "Chrome Headless 79.0.3945.0 (Linux x86_64)",
+  "Chrome 123.0.0.0 (Android 10)"
 ]

package/index.cjs

@@ -2431,6 +2431,10 @@ function getIterator(iterable) {
 // inspired by 'gartal' but lighter-weight and more battle-tested.
 class StreamReader {
   constructor(stream) {
+    // TODO: fix usage in bundlers before Buffer dependency is removed #1855
+    if (typeof Buffer === 'undefined') {
+      throw new Error('Missing Buffer dependency')
+    }
     this.stream = getIterator(stream);
     this.buffer = null;
     this.cursor = 0;
@@ -4182,17 +4186,14 @@ class GitWalkerFs {
         entry._content = undefined;
       } else {
         const config = await GitConfigManager.get({ fs, gitdir });
-        const autocrlf = (await config.get('core.autocrlf')) || false;
-        const content = await fs.read(`${dir}/${entry._fullpath}`, {
-          encoding: 'utf8',
-          autocrlf,
-        });
+        const autocrlf = await config.get('core.autocrlf');
+        const content = await fs.read(`${dir}/${entry._fullpath}`, { autocrlf });
         // workaround for a BrowserFS edge case
         entry._actualSize = content.length;
         if (entry._stat && entry._stat.size === -1) {
           entry._stat.size = entry._actualSize;
         }
-        entry._content = new TextEncoder().encode(content);
+        entry._content = new Uint8Array(content);
       }
     }
     return entry._content
@@ -4563,8 +4564,14 @@ class FileSystem {
   async read(filepath, options = {}) {
     try {
       let buffer = await this._readFile(filepath, options);
-      if (typeof buffer === 'string' && options.autocrlf) {
-        buffer = buffer.replace(/\r\n/g, '\n');
+      if (options.autocrlf === 'true') {
+        try {
+          buffer = new TextDecoder('utf8', { fatal: true }).decode(buffer);
+          buffer = buffer.replace(/\r\n/g, '\n');
+          buffer = new TextEncoder().encode(buffer);
+        } catch (error) {
+          // non utf8 file
+        }
       }
       // Convert plain ArrayBuffers to Buffers
       if (typeof buffer !== 'string') {
@@ -5097,20 +5104,12 @@ async function addToIndex({
       }
     } else {
       const config = await GitConfigManager.get({ fs, gitdir });
-      const autocrlf = (await config.get('core.autocrlf')) || false;
+      const autocrlf = await config.get('core.autocrlf');
       const object = stats.isSymbolicLink()
         ? await fs.readlink(join(dir, currentFilepath)).then(posixifyPathBuffer)
-        : await fs.read(join(dir, currentFilepath), {
-            encoding: 'utf8',
-            autocrlf,
-          });
+        : await fs.read(join(dir, currentFilepath), { autocrlf });
       if (object === null) throw new NotFoundError(currentFilepath)
-      const oid = await _writeObject({
-        fs,
-        gitdir,
-        type: 'blob',
-        object: new TextEncoder().encode(object),
-      });
+      const oid = await _writeObject({ fs, gitdir, type: 'blob', object });
       index.insert({ filepath: currentFilepath, stats, oid });
     }
   });
@@ -7385,8 +7384,8 @@ function filterCapabilities(server, client) {
 
 const pkg = {
   name: 'isomorphic-git',
-  version: '1.25.8',
-  agent: 'git/isomorphic-git@1.25.8',
+  version: '1.25.10',
+  agent: 'git/isomorphic-git@1.25.10',
 };
 
 class FIFO {

package/index.js

@@ -2425,6 +2425,10 @@ function getIterator(iterable) {
 // inspired by 'gartal' but lighter-weight and more battle-tested.
 class StreamReader {
   constructor(stream) {
+    // TODO: fix usage in bundlers before Buffer dependency is removed #1855
+    if (typeof Buffer === 'undefined') {
+      throw new Error('Missing Buffer dependency')
+    }
     this.stream = getIterator(stream);
     this.buffer = null;
     this.cursor = 0;
@@ -4176,17 +4180,14 @@ class GitWalkerFs {
         entry._content = undefined;
       } else {
         const config = await GitConfigManager.get({ fs, gitdir });
-        const autocrlf = (await config.get('core.autocrlf')) || false;
-        const content = await fs.read(`${dir}/${entry._fullpath}`, {
-          encoding: 'utf8',
-          autocrlf,
-        });
+        const autocrlf = await config.get('core.autocrlf');
+        const content = await fs.read(`${dir}/${entry._fullpath}`, { autocrlf });
         // workaround for a BrowserFS edge case
         entry._actualSize = content.length;
         if (entry._stat && entry._stat.size === -1) {
           entry._stat.size = entry._actualSize;
         }
-        entry._content = new TextEncoder().encode(content);
+        entry._content = new Uint8Array(content);
       }
     }
     return entry._content
@@ -4557,8 +4558,14 @@ class FileSystem {
   async read(filepath, options = {}) {
     try {
       let buffer = await this._readFile(filepath, options);
-      if (typeof buffer === 'string' && options.autocrlf) {
-        buffer = buffer.replace(/\r\n/g, '\n');
+      if (options.autocrlf === 'true') {
+        try {
+          buffer = new TextDecoder('utf8', { fatal: true }).decode(buffer);
+          buffer = buffer.replace(/\r\n/g, '\n');
+          buffer = new TextEncoder().encode(buffer);
+        } catch (error) {
+          // non utf8 file
+        }
       }
       // Convert plain ArrayBuffers to Buffers
       if (typeof buffer !== 'string') {
@@ -5091,20 +5098,12 @@ async function addToIndex({
       }
     } else {
       const config = await GitConfigManager.get({ fs, gitdir });
-      const autocrlf = (await config.get('core.autocrlf')) || false;
+      const autocrlf = await config.get('core.autocrlf');
       const object = stats.isSymbolicLink()
         ? await fs.readlink(join(dir, currentFilepath)).then(posixifyPathBuffer)
-        : await fs.read(join(dir, currentFilepath), {
-            encoding: 'utf8',
-            autocrlf,
-          });
+        : await fs.read(join(dir, currentFilepath), { autocrlf });
       if (object === null) throw new NotFoundError(currentFilepath)
-      const oid = await _writeObject({
-        fs,
-        gitdir,
-        type: 'blob',
-        object: new TextEncoder().encode(object),
-      });
+      const oid = await _writeObject({ fs, gitdir, type: 'blob', object });
       index.insert({ filepath: currentFilepath, stats, oid });
     }
   });
@@ -7379,8 +7378,8 @@ function filterCapabilities(server, client) {
 
 const pkg = {
   name: 'isomorphic-git',
-  version: '1.25.8',
-  agent: 'git/isomorphic-git@1.25.8',
+  version: '1.25.10',
+  agent: 'git/isomorphic-git@1.25.10',
 };
 
 class FIFO {