isomorphic-git 1.16.0 → 1.17.2

package/README.md

@@ -343,6 +343,9 @@ Thanks goes to these wonderful people ([emoji key](https://github.com/kentcdodds
     <td align="center"><a href="http://vitorluizc.github.io/"><img src="https://avatars.githubusercontent.com/u/9027363?v=4?s=60" width="60px;" alt=""/><br /><sub><b>Vitor Luiz Cavalcanti</b></sub></a><br /><a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=VitorLuizC" title="Documentation">📖</a></td>
     <td align="center"><a href="https://www.platformdemos.com/"><img src="https://avatars.githubusercontent.com/u/4261788?v=4?s=60" width="60px;" alt=""/><br /><sub><b>Shane McLaughlin</b></sub></a><br /><a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=mshanemc" title="Code">💻</a> <a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=mshanemc" title="Documentation">📖</a> <a href="https://github.com/isomorphic-git/isomorphic-git/commits?author=mshanemc" title="Tests">⚠️</a></td>
   </tr>
+  <tr>
+    <td align="center"><a href="https://github.com/seanpoulter"><img src="https://avatars.githubusercontent.com/u/2585460?v=4?s=60" width="60px;" alt=""/><br /><sub><b>Sean Poulter</b></sub></a><br /><a href="#maintenance-seanpoulter" title="Maintenance">🚧</a></td>
+  </tr>
 </table>
 
 <!-- markdownlint-restore -->

package/browser-tests.json

@@ -1,8 +1,8 @@
 [
-  "HeadlessChrome 0.0.0 (Linux 0.0.0)",
-  "Firefox 98.0.0 (Ubuntu 0.0.0)",
-  "Chrome Mobile 96.0.4664 (Android 0.0.0)",
-  "Chrome 79.0.3945 (Windows 10 0.0.0)",
-  "Safari 13.1.0 (Mac OS X 10.15.4)",
-  "Mobile Safari 13.0.0 (iOS 13.0.0)"
+  "Chrome Headless 79.0.3945.0 (Linux x86_64)",
+  "Firefox 99.0 (Ubuntu 0.0.0)",
+  "Safari 13.1 (Mac OS 10.15.4)",
+  "Mobile Safari 13.0 (iOS 13.0)",
+  "Edge 79.0.309.65 (Windows 10)",
+  "Chrome 96.0.4664.104 (Android 10)"
 ]

package/index.cjs

@@ -1474,6 +1474,21 @@ const getPath = (section, subsection, name) => {
     .join('.')
 };
 
+const normalizePath$1 = path => {
+  const pathSegments = path.split('.');
+  const section = pathSegments.shift();
+  const name = pathSegments.pop();
+  const subsection = pathSegments.length ? pathSegments.join('.') : undefined;
+
+  return {
+    section,
+    subsection,
+    name,
+    path: getPath(section, subsection, name),
+    sectionPath: getPath(section, subsection, null),
+  }
+};
+
 const findLastIndex = (array, callback) => {
   return array.reduce((lastIndex, item, index) => {
     return callback(item) ? index : lastIndex
@@ -1513,8 +1528,9 @@ class GitConfig {
   }
 
   async get(path, getall = false) {
+    const normalizedPath = normalizePath$1(path).path;
     const allValues = this.parsedConfig
-      .filter(config => config.path === path.toLowerCase())
+      .filter(config => config.path === normalizedPath)
       .map(({ section, name, value }) => {
         const fn = schema[section] && schema[section][name];
         return fn ? fn(value) : value
@@ -1544,9 +1560,16 @@ class GitConfig {
   }
 
   async set(path, value, append = false) {
+    const {
+      section,
+      subsection,
+      name,
+      path: normalizedPath,
+      sectionPath,
+    } = normalizePath$1(path);
     const configIndex = findLastIndex(
       this.parsedConfig,
-      config => config.path === path.toLowerCase()
+      config => config.path === normalizedPath
     );
     if (value == null) {
       if (configIndex !== -1) {
@@ -1555,7 +1578,9 @@ class GitConfig {
     } else {
       if (configIndex !== -1) {
         const config = this.parsedConfig[configIndex];
+        // Name should be overwritten in case the casing changed
         const modifiedConfig = Object.assign({}, config, {
+          name,
           value,
           modified: true,
         });
@@ -1565,13 +1590,6 @@ class GitConfig {
           this.parsedConfig[configIndex] = modifiedConfig;
         }
       } else {
-        const pathSegments = path.split('.');
-        const section = pathSegments.shift().toLowerCase();
-        const name = pathSegments.pop();
-        const subsection = pathSegments.length
-          ? pathSegments.join('.').toLowerCase()
-          : undefined;
-        const sectionPath = subsection ? section + '.' + subsection : section;
         const sectionIndex = this.parsedConfig.findIndex(
           config => config.path === sectionPath
         );
@@ -1581,7 +1599,7 @@ class GitConfig {
           name,
           value,
           modified: true,
-          path: getPath(section, subsection, name),
+          path: normalizedPath,
         };
         if (SECTION_REGEX.test(section) && VARIABLE_NAME_REGEX.test(name)) {
           if (sectionIndex >= 0) {
@@ -1593,7 +1611,7 @@ class GitConfig {
               section,
               subsection,
               modified: true,
-              path: getPath(section, subsection, null),
+              path: sectionPath,
             };
             this.parsedConfig.push(newSection, newConfig);
           }
@@ -1609,6 +1627,10 @@ class GitConfig {
           return line
         }
         if (name != null && value != null) {
+          if (typeof value === 'string' && /[#;]/.test(value)) {
+            // A `#` or `;` symbol denotes a comment, so we have to wrap it in double quotes
+            return `\t${name} = "${value}"`
+          }
           return `\t${name} = ${value}`
         }
         if (subsection != null) {
@@ -3210,6 +3232,23 @@ class MissingParameterError extends BaseError {
 /** @type {'MissingParameterError'} */
 MissingParameterError.code = 'MissingParameterError';
 
+class MultipleGitError extends BaseError {
+  /**
+   * @param {Error[]} errors
+   * @param {string} message
+   */
+  constructor(errors) {
+    super(
+      `There are multiple errors that were thrown by the method. Please refer to the "errors" property to see more`
+    );
+    this.code = this.name = MultipleGitError.code;
+    this.data = { errors };
+    this.errors = errors;
+  }
+}
+/** @type {'MultipleGitError'} */
+MultipleGitError.code = 'MultipleGitError';
+
 class ParseError extends BaseError {
   /**
    * @param {string} expected
@@ -3335,6 +3374,7 @@ var Errors = /*#__PURE__*/Object.freeze({
   MergeNotSupportedError: MergeNotSupportedError,
   MissingNameError: MissingNameError,
   MissingParameterError: MissingParameterError,
+  MultipleGitError: MultipleGitError,
   NoRefspecError: NoRefspecError,
   NotFoundError: NotFoundError,
   ObjectTypeError: ObjectTypeError,
@@ -4029,23 +4069,6 @@ function WORKDIR() {
 
 // @ts-check
 
-class MultipleGitError extends BaseError {
-  /**
-   * @param {Error[]} errors
-   * @param {string} message
-   */
-  constructor(errors) {
-    super(
-      `There are multiple errors that were thrown by the method. Please refer to the "errors" property to see more`
-    );
-    this.code = this.name = MultipleGitError.code;
-    this.data = { errors };
-    this.errors = errors;
-  }
-}
-/** @type {'MultipleGitError'} */
-MultipleGitError.code = 'MultipleGitError';
-
 // I'm putting this in a Manager because I reckon it could benefit
 // from a LOT of cacheing.
 class GitIgnoreManager {
@@ -4469,7 +4492,7 @@ async function add({
     assertParameter('fs', _fs);
     assertParameter('dir', dir);
     assertParameter('gitdir', gitdir);
-    assertParameter('filepaths', filepath);
+    assertParameter('filepath', filepath);
 
     const fs = new FileSystem(_fs);
     await GitIndexManager.acquire({ fs, gitdir, cache }, async index => {
@@ -6923,8 +6946,8 @@ function filterCapabilities(server, client) {
 
 const pkg = {
   name: 'isomorphic-git',
-  version: '1.16.0',
-  agent: 'git/isomorphic-git@1.16.0',
+  version: '1.17.2',
+  agent: 'git/isomorphic-git@1.17.2',
 };
 
 class FIFO {

package/index.d.ts

@@ -717,6 +717,7 @@ export var Errors: Readonly<{
     MergeNotSupportedError: typeof MergeNotSupportedError;
     MissingNameError: typeof MissingNameError;
     MissingParameterError: typeof MissingParameterError;
+    MultipleGitError: typeof MultipleGitError;
     NoRefspecError: typeof NoRefspecError;
     NotFoundError: typeof NotFoundError;
     ObjectTypeError: typeof ObjectTypeError;
@@ -3893,6 +3894,23 @@ declare namespace MissingParameterError {
     const code_15: 'MissingParameterError';
     export { code_15 as code };
 }
+declare class MultipleGitError extends BaseError {
+    /**
+     * @param {Error[]} errors
+     * @param {string} message
+     */
+    constructor(errors: Error[]);
+    code: "MultipleGitError";
+    name: "MultipleGitError";
+    data: {
+        errors: Error[];
+    };
+    errors: Error[];
+}
+declare namespace MultipleGitError {
+    const code_16: 'MultipleGitError';
+    export { code_16 as code };
+}
 declare class NoRefspecError extends BaseError {
     /**
      * @param {string} remote
@@ -3905,8 +3923,8 @@ declare class NoRefspecError extends BaseError {
     };
 }
 declare namespace NoRefspecError {
-    const code_16: 'NoRefspecError';
-    export { code_16 as code };
+    const code_17: 'NoRefspecError';
+    export { code_17 as code };
 }
 declare class NotFoundError extends BaseError {
     /**
@@ -3920,8 +3938,8 @@ declare class NotFoundError extends BaseError {
     };
 }
 declare namespace NotFoundError {
-    const code_17: 'NotFoundError';
-    export { code_17 as code };
+    const code_18: 'NotFoundError';
+    export { code_18 as code };
 }
 declare class ObjectTypeError extends BaseError {
     /**
@@ -3941,8 +3959,8 @@ declare class ObjectTypeError extends BaseError {
     };
 }
 declare namespace ObjectTypeError {
-    const code_18: 'ObjectTypeError';
-    export { code_18 as code };
+    const code_19: 'ObjectTypeError';
+    export { code_19 as code };
 }
 declare class ParseError extends BaseError {
     /**
@@ -3958,8 +3976,8 @@ declare class ParseError extends BaseError {
     };
 }
 declare namespace ParseError {
-    const code_19: 'ParseError';
-    export { code_19 as code };
+    const code_20: 'ParseError';
+    export { code_20 as code };
 }
 declare class PushRejectedError extends BaseError {
     /**
@@ -3973,8 +3991,8 @@ declare class PushRejectedError extends BaseError {
     };
 }
 declare namespace PushRejectedError {
-    const code_20: 'PushRejectedError';
-    export { code_20 as code };
+    const code_21: 'PushRejectedError';
+    export { code_21 as code };
 }
 declare class RemoteCapabilityError extends BaseError {
     /**
@@ -3990,8 +4008,8 @@ declare class RemoteCapabilityError extends BaseError {
     };
 }
 declare namespace RemoteCapabilityError {
-    const code_21: 'RemoteCapabilityError';
-    export { code_21 as code };
+    const code_22: 'RemoteCapabilityError';
+    export { code_22 as code };
 }
 declare class SmartHttpError extends BaseError {
     /**
@@ -4007,8 +4025,8 @@ declare class SmartHttpError extends BaseError {
     };
 }
 declare namespace SmartHttpError {
-    const code_22: 'SmartHttpError';
-    export { code_22 as code };
+    const code_23: 'SmartHttpError';
+    export { code_23 as code };
 }
 declare class UnknownTransportError extends BaseError {
     /**
@@ -4026,8 +4044,8 @@ declare class UnknownTransportError extends BaseError {
     };
 }
 declare namespace UnknownTransportError {
-    const code_23: 'UnknownTransportError';
-    export { code_23 as code };
+    const code_24: 'UnknownTransportError';
+    export { code_24 as code };
 }
 declare class UnsafeFilepathError extends BaseError {
     /**
@@ -4041,8 +4059,8 @@ declare class UnsafeFilepathError extends BaseError {
     };
 }
 declare namespace UnsafeFilepathError {
-    const code_24: 'UnsafeFilepathError';
-    export { code_24 as code };
+    const code_25: 'UnsafeFilepathError';
+    export { code_25 as code };
 }
 declare class UrlParseError extends BaseError {
     /**
@@ -4056,8 +4074,8 @@ declare class UrlParseError extends BaseError {
     };
 }
 declare namespace UrlParseError {
-    const code_25: 'UrlParseError';
-    export { code_25 as code };
+    const code_26: 'UrlParseError';
+    export { code_26 as code };
 }
 declare class UserCanceledError extends BaseError {
     code: "UserCanceledError";
@@ -4065,8 +4083,8 @@ declare class UserCanceledError extends BaseError {
     data: {};
 }
 declare namespace UserCanceledError {
-    const code_26: 'UserCanceledError';
-    export { code_26 as code };
+    const code_27: 'UserCanceledError';
+    export { code_27 as code };
 }
 /**
  * @typedef {Object} GitProgressEvent

package/index.js

@@ -1468,6 +1468,21 @@ const getPath = (section, subsection, name) => {
     .join('.')
 };
 
+const normalizePath$1 = path => {
+  const pathSegments = path.split('.');
+  const section = pathSegments.shift();
+  const name = pathSegments.pop();
+  const subsection = pathSegments.length ? pathSegments.join('.') : undefined;
+
+  return {
+    section,
+    subsection,
+    name,
+    path: getPath(section, subsection, name),
+    sectionPath: getPath(section, subsection, null),
+  }
+};
+
 const findLastIndex = (array, callback) => {
   return array.reduce((lastIndex, item, index) => {
     return callback(item) ? index : lastIndex
@@ -1507,8 +1522,9 @@ class GitConfig {
   }
 
   async get(path, getall = false) {
+    const normalizedPath = normalizePath$1(path).path;
     const allValues = this.parsedConfig
-      .filter(config => config.path === path.toLowerCase())
+      .filter(config => config.path === normalizedPath)
       .map(({ section, name, value }) => {
         const fn = schema[section] && schema[section][name];
         return fn ? fn(value) : value
@@ -1538,9 +1554,16 @@ class GitConfig {
   }
 
   async set(path, value, append = false) {
+    const {
+      section,
+      subsection,
+      name,
+      path: normalizedPath,
+      sectionPath,
+    } = normalizePath$1(path);
     const configIndex = findLastIndex(
       this.parsedConfig,
-      config => config.path === path.toLowerCase()
+      config => config.path === normalizedPath
     );
     if (value == null) {
       if (configIndex !== -1) {
@@ -1549,7 +1572,9 @@ class GitConfig {
     } else {
       if (configIndex !== -1) {
         const config = this.parsedConfig[configIndex];
+        // Name should be overwritten in case the casing changed
         const modifiedConfig = Object.assign({}, config, {
+          name,
           value,
           modified: true,
         });
@@ -1559,13 +1584,6 @@ class GitConfig {
           this.parsedConfig[configIndex] = modifiedConfig;
         }
       } else {
-        const pathSegments = path.split('.');
-        const section = pathSegments.shift().toLowerCase();
-        const name = pathSegments.pop();
-        const subsection = pathSegments.length
-          ? pathSegments.join('.').toLowerCase()
-          : undefined;
-        const sectionPath = subsection ? section + '.' + subsection : section;
         const sectionIndex = this.parsedConfig.findIndex(
           config => config.path === sectionPath
         );
@@ -1575,7 +1593,7 @@ class GitConfig {
           name,
           value,
           modified: true,
-          path: getPath(section, subsection, name),
+          path: normalizedPath,
         };
         if (SECTION_REGEX.test(section) && VARIABLE_NAME_REGEX.test(name)) {
           if (sectionIndex >= 0) {
@@ -1587,7 +1605,7 @@ class GitConfig {
               section,
               subsection,
               modified: true,
-              path: getPath(section, subsection, null),
+              path: sectionPath,
             };
             this.parsedConfig.push(newSection, newConfig);
           }
@@ -1603,6 +1621,10 @@ class GitConfig {
           return line
         }
         if (name != null && value != null) {
+          if (typeof value === 'string' && /[#;]/.test(value)) {
+            // A `#` or `;` symbol denotes a comment, so we have to wrap it in double quotes
+            return `\t${name} = "${value}"`
+          }
           return `\t${name} = ${value}`
         }
         if (subsection != null) {
@@ -3204,6 +3226,23 @@ class MissingParameterError extends BaseError {
 /** @type {'MissingParameterError'} */
 MissingParameterError.code = 'MissingParameterError';
 
+class MultipleGitError extends BaseError {
+  /**
+   * @param {Error[]} errors
+   * @param {string} message
+   */
+  constructor(errors) {
+    super(
+      `There are multiple errors that were thrown by the method. Please refer to the "errors" property to see more`
+    );
+    this.code = this.name = MultipleGitError.code;
+    this.data = { errors };
+    this.errors = errors;
+  }
+}
+/** @type {'MultipleGitError'} */
+MultipleGitError.code = 'MultipleGitError';
+
 class ParseError extends BaseError {
   /**
    * @param {string} expected
@@ -3329,6 +3368,7 @@ var Errors = /*#__PURE__*/Object.freeze({
   MergeNotSupportedError: MergeNotSupportedError,
   MissingNameError: MissingNameError,
   MissingParameterError: MissingParameterError,
+  MultipleGitError: MultipleGitError,
   NoRefspecError: NoRefspecError,
   NotFoundError: NotFoundError,
   ObjectTypeError: ObjectTypeError,
@@ -4023,23 +4063,6 @@ function WORKDIR() {
 
 // @ts-check
 
-class MultipleGitError extends BaseError {
-  /**
-   * @param {Error[]} errors
-   * @param {string} message
-   */
-  constructor(errors) {
-    super(
-      `There are multiple errors that were thrown by the method. Please refer to the "errors" property to see more`
-    );
-    this.code = this.name = MultipleGitError.code;
-    this.data = { errors };
-    this.errors = errors;
-  }
-}
-/** @type {'MultipleGitError'} */
-MultipleGitError.code = 'MultipleGitError';
-
 // I'm putting this in a Manager because I reckon it could benefit
 // from a LOT of cacheing.
 class GitIgnoreManager {
@@ -4463,7 +4486,7 @@ async function add({
     assertParameter('fs', _fs);
     assertParameter('dir', dir);
     assertParameter('gitdir', gitdir);
-    assertParameter('filepaths', filepath);
+    assertParameter('filepath', filepath);
 
     const fs = new FileSystem(_fs);
     await GitIndexManager.acquire({ fs, gitdir, cache }, async index => {
@@ -6917,8 +6940,8 @@ function filterCapabilities(server, client) {
 
 const pkg = {
   name: 'isomorphic-git',
-  version: '1.16.0',
-  agent: 'git/isomorphic-git@1.16.0',
+  version: '1.17.2',
+  agent: 'git/isomorphic-git@1.17.2',
 };
 
 class FIFO {

package/index.umd.min.d.ts

@@ -717,6 +717,7 @@ export var Errors: Readonly<{
     MergeNotSupportedError: typeof MergeNotSupportedError;
     MissingNameError: typeof MissingNameError;
     MissingParameterError: typeof MissingParameterError;
+    MultipleGitError: typeof MultipleGitError;
     NoRefspecError: typeof NoRefspecError;
     NotFoundError: typeof NotFoundError;
     ObjectTypeError: typeof ObjectTypeError;
@@ -3893,6 +3894,23 @@ declare namespace MissingParameterError {
     const code_15: 'MissingParameterError';
     export { code_15 as code };
 }
+declare class MultipleGitError extends BaseError {
+    /**
+     * @param {Error[]} errors
+     * @param {string} message
+     */
+    constructor(errors: Error[]);
+    code: "MultipleGitError";
+    name: "MultipleGitError";
+    data: {
+        errors: Error[];
+    };
+    errors: Error[];
+}
+declare namespace MultipleGitError {
+    const code_16: 'MultipleGitError';
+    export { code_16 as code };
+}
 declare class NoRefspecError extends BaseError {
     /**
      * @param {string} remote
@@ -3905,8 +3923,8 @@ declare class NoRefspecError extends BaseError {
     };
 }
 declare namespace NoRefspecError {
-    const code_16: 'NoRefspecError';
-    export { code_16 as code };
+    const code_17: 'NoRefspecError';
+    export { code_17 as code };
 }
 declare class NotFoundError extends BaseError {
     /**
@@ -3920,8 +3938,8 @@ declare class NotFoundError extends BaseError {
     };
 }
 declare namespace NotFoundError {
-    const code_17: 'NotFoundError';
-    export { code_17 as code };
+    const code_18: 'NotFoundError';
+    export { code_18 as code };
 }
 declare class ObjectTypeError extends BaseError {
     /**
@@ -3941,8 +3959,8 @@ declare class ObjectTypeError extends BaseError {
     };
 }
 declare namespace ObjectTypeError {
-    const code_18: 'ObjectTypeError';
-    export { code_18 as code };
+    const code_19: 'ObjectTypeError';
+    export { code_19 as code };
 }
 declare class ParseError extends BaseError {
     /**
@@ -3958,8 +3976,8 @@ declare class ParseError extends BaseError {
     };
 }
 declare namespace ParseError {
-    const code_19: 'ParseError';
-    export { code_19 as code };
+    const code_20: 'ParseError';
+    export { code_20 as code };
 }
 declare class PushRejectedError extends BaseError {
     /**
@@ -3973,8 +3991,8 @@ declare class PushRejectedError extends BaseError {
     };
 }
 declare namespace PushRejectedError {
-    const code_20: 'PushRejectedError';
-    export { code_20 as code };
+    const code_21: 'PushRejectedError';
+    export { code_21 as code };
 }
 declare class RemoteCapabilityError extends BaseError {
     /**
@@ -3990,8 +4008,8 @@ declare class RemoteCapabilityError extends BaseError {
     };
 }
 declare namespace RemoteCapabilityError {
-    const code_21: 'RemoteCapabilityError';
-    export { code_21 as code };
+    const code_22: 'RemoteCapabilityError';
+    export { code_22 as code };
 }
 declare class SmartHttpError extends BaseError {
     /**
@@ -4007,8 +4025,8 @@ declare class SmartHttpError extends BaseError {
     };
 }
 declare namespace SmartHttpError {
-    const code_22: 'SmartHttpError';
-    export { code_22 as code };
+    const code_23: 'SmartHttpError';
+    export { code_23 as code };
 }
 declare class UnknownTransportError extends BaseError {
     /**
@@ -4026,8 +4044,8 @@ declare class UnknownTransportError extends BaseError {
     };
 }
 declare namespace UnknownTransportError {
-    const code_23: 'UnknownTransportError';
-    export { code_23 as code };
+    const code_24: 'UnknownTransportError';
+    export { code_24 as code };
 }
 declare class UnsafeFilepathError extends BaseError {
     /**
@@ -4041,8 +4059,8 @@ declare class UnsafeFilepathError extends BaseError {
     };
 }
 declare namespace UnsafeFilepathError {
-    const code_24: 'UnsafeFilepathError';
-    export { code_24 as code };
+    const code_25: 'UnsafeFilepathError';
+    export { code_25 as code };
 }
 declare class UrlParseError extends BaseError {
     /**
@@ -4056,8 +4074,8 @@ declare class UrlParseError extends BaseError {
     };
 }
 declare namespace UrlParseError {
-    const code_25: 'UrlParseError';
-    export { code_25 as code };
+    const code_26: 'UrlParseError';
+    export { code_26 as code };
 }
 declare class UserCanceledError extends BaseError {
     code: "UserCanceledError";
@@ -4065,8 +4083,8 @@ declare class UserCanceledError extends BaseError {
     data: {};
 }
 declare namespace UserCanceledError {
-    const code_26: 'UserCanceledError';
-    export { code_26 as code };
+    const code_27: 'UserCanceledError';
+    export { code_27 as code };
 }
 /**
  * @typedef {Object} GitProgressEvent