isolate-package 1.24.0 → 1.25.0

package/README.md

@@ -124,13 +124,17 @@ generate part of the packed filename. A personal preference is to set it to
 > NOTE: This step is not required if you use the
 > [internal packages strategy](#the-internal-packages-strategy) but you could
 > set it to `["src"]` instead of `["dist"]`.
+>
+> When using `includeDevDependencies`, packages that are only dev dependencies
+> (like ESLint configs or other build tools) don't require a `files` field since
+> they are not packed for deployment.
 
 The isolate process uses (p)npm `pack` to extract files from package
 directories, just like publishing a package would.
 
-For this to work it is required that you define the `files` property in each
-package manifest, as it declares what files should be included in the published
-output.
+For production dependencies, it is required that you define the `files` property
+in each package manifest, as it declares what files should be included in the
+published output.
 
 Typically, the value contains an array with only the name of the build output
 directory. For example:
@@ -219,6 +223,11 @@ By default devDependencies are ignored and stripped from the isolated output
 `package.json` files. If you enable this the devDependencies will be included
 and isolated just like the production dependencies.
 
+Note: Dev-only internal packages (like ESLint configs) that are included through
+this option don't require a `files` field in their package.json, only a
+`version` field. Production dependencies always require both `version` and
+`files` fields.
+
 ### pickFromScripts
 
 Type: `string[]`, default: `undefined`

package/dist/index.mjs

@@ -1,12 +1,12 @@
 // src/isolate.ts
 import fs15 from "fs-extra";
-import assert6 from "node:assert";
-import path20 from "node:path";
+import assert6 from "assert";
+import path20 from "path";
 import { unique as unique2 } from "remeda";
 
 // src/lib/config.ts
 import fs8 from "fs-extra";
-import path6 from "node:path";
+import path6 from "path";
 import { isEmpty } from "remeda";
 
 // src/lib/logger.ts
@@ -77,14 +77,14 @@ function toErrorWithMessage(maybeError) {
 }
 
 // src/lib/utils/inspect-value.ts
-import { inspect } from "node:util";
+import { inspect } from "util";
 function inspectValue(value) {
   return inspect(value, false, 16, true);
 }
 
 // src/lib/utils/is-rush-workspace.ts
-import fs from "node:fs";
-import path from "node:path";
+import fs from "fs";
+import path from "path";
 function isRushWorkspace(workspaceRootDir) {
   return fs.existsSync(path.join(workspaceRootDir, "rush.json"));
 }
@@ -120,7 +120,7 @@ async function readTypedJson(filePath) {
 }
 
 // src/lib/utils/log-paths.ts
-import { join } from "node:path";
+import { join } from "path";
 function getRootRelativeLogPath(path21, rootPath) {
   const strippedPath = path21.replace(rootPath, "");
   return join("(root)", strippedPath);
@@ -131,18 +131,18 @@ function getIsolateRelativeLogPath(path21, isolatePath) {
 }
 
 // src/lib/utils/pack.ts
-import assert2 from "node:assert";
-import { exec } from "node:child_process";
-import fs5 from "node:fs";
-import path5 from "node:path";
+import assert2 from "assert";
+import { exec } from "child_process";
+import fs5 from "fs";
+import path5 from "path";
 
 // src/lib/package-manager/index.ts
-import path4 from "node:path";
+import path4 from "path";
 
 // src/lib/package-manager/helpers/infer-from-files.ts
 import fs3 from "fs-extra";
-import { execSync } from "node:child_process";
-import path2 from "node:path";
+import { execSync } from "child_process";
+import path2 from "path";
 
 // src/lib/utils/get-major-version.ts
 function getMajorVersion(version) {
@@ -197,8 +197,8 @@ function getVersion(packageManagerName) {
 
 // src/lib/package-manager/helpers/infer-from-manifest.ts
 import fs4 from "fs-extra";
-import assert from "node:assert";
-import path3 from "node:path";
+import assert from "assert";
+import path3 from "path";
 function inferFromManifest(workspaceRoot) {
   const log = useLogger();
   const { packageManager: packageManagerString } = readTypedJsonSync(
@@ -382,7 +382,7 @@ function resolveConfig(initialConfig) {
 // src/lib/lockfile/helpers/generate-npm-lockfile.ts
 import Arborist from "@npmcli/arborist";
 import fs9 from "fs-extra";
-import path7 from "node:path";
+import path7 from "path";
 
 // src/lib/lockfile/helpers/load-npm-config.ts
 import Config from "@npmcli/config";
@@ -427,8 +427,8 @@ async function generateNpmLockfile({
 }
 
 // src/lib/lockfile/helpers/generate-pnpm-lockfile.ts
-import assert3 from "node:assert";
-import path9 from "node:path";
+import assert3 from "assert";
+import path9 from "path";
 import {
   getLockfileImporterId as getLockfileImporterId_v8,
   readWantedLockfile as readWantedLockfile_v8,
@@ -444,7 +444,7 @@ import { pruneLockfile as pruneLockfile_v9 } from "pnpm_prune_lockfile_v9";
 import { pick } from "remeda";
 
 // src/lib/lockfile/helpers/pnpm-map-importer.ts
-import path8 from "node:path";
+import path8 from "path";
 import { mapValues } from "remeda";
 function pnpmMapImporter(importerPath, { dependencies, devDependencies, ...rest }, {
   includeDevDependencies,
@@ -553,7 +553,8 @@ async function generatePnpmLockfile({
         return [
           importerId,
           pnpmMapImporter(importerId, importer, {
-            includeDevDependencies,
+            includeDevDependencies: false,
+            // Only include dev deps for target package
             includePatchedDependencies,
             directoryByPackageName
           })
@@ -582,8 +583,8 @@ async function generatePnpmLockfile({
 
 // src/lib/lockfile/helpers/generate-yarn-lockfile.ts
 import fs10 from "fs-extra";
-import { execSync as execSync2 } from "node:child_process";
-import path10 from "node:path";
+import { execSync as execSync2 } from "child_process";
+import path10 from "path";
 async function generateYarnLockfile({
   workspaceRootDir,
   isolateDir
@@ -694,12 +695,12 @@ async function processLockfile({
 import { omit as omit2, pick as pick2 } from "remeda";
 
 // src/lib/manifest/helpers/adapt-internal-package-manifests.ts
-import path13 from "node:path";
+import path13 from "path";
 import { omit } from "remeda";
 
 // src/lib/manifest/io.ts
 import fs11 from "fs-extra";
-import path11 from "node:path";
+import path11 from "path";
 async function readManifest(packageDir) {
   return readTypedJson(path11.join(packageDir, "package.json"));
 }
@@ -711,7 +712,7 @@ async function writeManifest(outputDir, manifest) {
 }
 
 // src/lib/manifest/helpers/patch-internal-entries.ts
-import path12 from "node:path";
+import path12 from "path";
 function patchInternalEntries(dependencies, packagesRegistry, parentRootRelativeDir) {
   const log = useLogger();
   const allWorkspacePackageNames = Object.keys(packagesRegistry);
@@ -862,17 +863,17 @@ async function adaptTargetPackageManifest({
 }
 
 // src/lib/manifest/validate-manifest.ts
-function validateManifestMandatoryFields(manifest, packagePath) {
+function validateManifestMandatoryFields(manifest, packagePath, requireFilesField = true) {
   const log = useLogger();
   const missingFields = [];
   if (!manifest.version) {
     missingFields.push("version");
   }
-  if (!manifest.files || !Array.isArray(manifest.files) || manifest.files.length === 0) {
+  if (requireFilesField && (!manifest.files || !Array.isArray(manifest.files) || manifest.files.length === 0)) {
     missingFields.push("files");
   }
   if (missingFields.length > 0) {
-    const errorMessage = `Package at ${packagePath} is missing mandatory fields: ${missingFields.join(", ")}. The "version" field is required for pack to execute, and the "files" field is required to declare what files should be included in the output. See the documentation for more details.`;
+    const errorMessage = `Package at ${packagePath} is missing mandatory fields: ${missingFields.join(", ")}. See the documentation for more details.`;
     log.error(errorMessage);
     throw new Error(errorMessage);
   }
@@ -881,7 +882,7 @@ function validateManifestMandatoryFields(manifest, packagePath) {
 
 // src/lib/output/get-build-output-dir.ts
 import { getTsconfig } from "get-tsconfig";
-import path15 from "node:path";
+import path15 from "path";
 import outdent from "outdent";
 async function getBuildOutputDir({
   targetPackageDir,
@@ -914,7 +915,7 @@ async function getBuildOutputDir({
 }
 
 // src/lib/output/pack-dependencies.ts
-import assert4 from "node:assert";
+import assert4 from "assert";
 async function packDependencies({
   /** All packages found in the monorepo by workspaces declaration */
   packagesRegistry,
@@ -945,7 +946,7 @@ async function packDependencies({
 
 // src/lib/output/process-build-output-files.ts
 import fs12 from "fs-extra";
-import path16 from "node:path";
+import path16 from "path";
 var TIMEOUT_MS = 5e3;
 async function processBuildOutputFiles({
   targetPackageDir,
@@ -970,7 +971,7 @@ async function processBuildOutputFiles({
 
 // src/lib/output/unpack-dependencies.ts
 import fs13 from "fs-extra";
-import path17, { join as join2 } from "node:path";
+import path17, { join as join2 } from "path";
 async function unpackDependencies(packedFilesByName, packagesRegistry, tmpDir, isolateDir) {
   const log = useLogger();
   await Promise.all(
@@ -997,11 +998,11 @@ async function unpackDependencies(packedFilesByName, packagesRegistry, tmpDir, i
 // src/lib/registry/create-packages-registry.ts
 import fs14 from "fs-extra";
 import { globSync } from "glob";
-import path19 from "node:path";
+import path19 from "path";
 
 // src/lib/registry/helpers/find-packages-globs.ts
-import assert5 from "node:assert";
-import path18 from "node:path";
+import assert5 from "assert";
+import path18 from "path";
 function findPackagesGlobs(workspaceRootDir) {
   const log = useLogger();
   const packageManager2 = usePackageManager();
@@ -1194,11 +1195,20 @@ function createIsolator(config) {
         includeDevDependencies: config2.includeDevDependencies
       }
     );
+    const productionInternalPackageNames = listInternalPackages(
+      targetPackageManifest,
+      packagesRegistry,
+      {
+        includeDevDependencies: false
+      }
+    );
     for (const packageName of internalPackageNames) {
       const packageDef = packagesRegistry[packageName];
+      const isProductionDependency = productionInternalPackageNames.includes(packageName);
       validateManifestMandatoryFields(
         packageDef.manifest,
-        getRootRelativeLogPath(packageDef.absoluteDir, workspaceRootDir)
+        getRootRelativeLogPath(packageDef.absoluteDir, workspaceRootDir),
+        isProductionDependency
       );
     }
     const packedFilesByName = await packDependencies({