isml-linter 5.39.1 → 5.40.0

package/src/rules/tree/disallow-tags.js

@@ -1,39 +1,39 @@
-const TreeRulePrototype = require('../prototypes/TreeRulePrototype');
-const ConfigUtils       = require('../../../src/util/ConfigUtils');
-
-const ruleId      = require('path').basename(__filename).slice(0, -3);
-const description = 'Tag not allowed';
-
-const Rule = Object.create(TreeRulePrototype);
-
-const config            = ConfigUtils.load();
-const disallowedTagList = config.rules['disallow-tags'] ?
-    config.rules['disallow-tags'].values || [] :
-    [];
-
-Rule.init(ruleId, description);
-
-Rule.isBroken = function(node) {
-    return disallowedTagList.indexOf(node.getType()) >= 0;
-};
-
-Rule.check = function(node, data) {
-    const occurrenceList = this.checkChildren(node, data);
-
-    if (this.isBroken(node)) {
-        const error = this.getError(
-            node.head.trim(),
-            node.lineNumber,
-            node.columnNumber,
-            node.globalPos,
-            node.head.trim().length,
-            `Tag "${node.getType()}" is not allowed.`
-        );
-
-        occurrenceList.push(error);
-    }
-
-    return this.return(node, occurrenceList, config);
-};
-
-module.exports = Rule;
+const TreeRulePrototype = require('../prototypes/TreeRulePrototype');
+const ConfigUtils       = require('../../../src/util/ConfigUtils');
+
+const ruleId      = require('path').basename(__filename).slice(0, -3);
+const description = 'Tag not allowed';
+
+const Rule = Object.create(TreeRulePrototype);
+
+const config            = ConfigUtils.load();
+const disallowedTagList = config.rules['disallow-tags'] ?
+    config.rules['disallow-tags'].values || [] :
+    [];
+
+Rule.init(ruleId, description);
+
+Rule.isBroken = function(node) {
+    return disallowedTagList.indexOf(node.getType()) >= 0;
+};
+
+Rule.check = function(node, data) {
+    const occurrenceList = this.checkChildren(node, data);
+
+    if (this.isBroken(node)) {
+        const error = this.getError(
+            node.head.trim(),
+            node.lineNumber,
+            node.columnNumber,
+            node.globalPos,
+            node.head.trim().length,
+            `Tag "${node.getType()}" is not allowed.`
+        );
+
+        occurrenceList.push(error);
+    }
+
+    return this.return(node, occurrenceList, config);
+};
+
+module.exports = Rule;

package/src/rules/tree/empty-eof.js

@@ -1,66 +1,66 @@
-const TreeRulePrototype = require('../prototypes/TreeRulePrototype');
-const Constants         = require('../../Constants');
-const ParseUtils        = require('../../isml_tree/ParseUtils');
-
-const ruleId      = require('path').basename(__filename).slice(0, -3);
-const description = 'A blank line at the end of the file is required';
-
-const Rule = Object.create(TreeRulePrototype);
-
-Rule.init(ruleId, description);
-
-Rule.isBroken = function(node) {
-    const tempNode = node.isContainer() ? node.getLastChild() : node;
-
-    return !(tempNode.tail ?
-        tempNode.tail.endsWith(Constants.EOL) :
-        tempNode.head.endsWith(Constants.EOL));
-};
-
-Rule.check = function(rootNode, data) {
-
-    const occurrenceList = [];
-
-    const node = rootNode.getLastChild();
-
-    if (this.isBroken(node)) {
-        const lineContent  = node.toString().substring(node.toString().lastIndexOf(Constants.EOL) + 1);
-        const lineBreakQty = ParseUtils.getLineBreakQty(node.toString());
-        const lineNumber   = node.lineNumber + lineBreakQty - 1;
-        let globalPos      = node.globalPos;
-        let length         = node.head.trim().length;
-
-        if (node.tail) {
-            const lastLineBreakPos = node.tail.lastIndexOf(Constants.EOL);
-            const trailingSpaces   = node.tail.substring(lastLineBreakPos + 1);
-
-            if (trailingSpaces.length > 0) {
-                globalPos = node.tailGlobalPos + node.tail.trim().length + 1;
-                length    = trailingSpaces.length;
-
-                if (data.isCrlfLineBreak) {
-                    globalPos += ParseUtils.getLineBreakQty(node.tail.trimStart());
-                }
-            } else {
-                globalPos = node.tailGlobalPos + 1;
-                length    = node.tail.trim().length;
-            }
-        }
-
-        const error = this.getError(
-            lineContent,
-            lineNumber,
-            node.columnNumber,
-            globalPos,
-            length
-        );
-
-        occurrenceList.push(error);
-    }
-
-    return {
-        occurrenceList
-    };
-};
-
-module.exports = Rule;
+const TreeRulePrototype = require('../prototypes/TreeRulePrototype');
+const Constants         = require('../../Constants');
+const ParseUtils        = require('../../isml_tree/ParseUtils');
+
+const ruleId      = require('path').basename(__filename).slice(0, -3);
+const description = 'A blank line at the end of the file is required';
+
+const Rule = Object.create(TreeRulePrototype);
+
+Rule.init(ruleId, description);
+
+Rule.isBroken = function(node) {
+    const tempNode = node.isContainer() ? node.getLastChild() : node;
+
+    return !(tempNode.tail ?
+        tempNode.tail.endsWith(Constants.EOL) :
+        tempNode.head.endsWith(Constants.EOL));
+};
+
+Rule.check = function(rootNode, data) {
+
+    const occurrenceList = [];
+
+    const node = rootNode.getLastChild();
+
+    if (this.isBroken(node)) {
+        const lineContent  = node.toString().substring(node.toString().lastIndexOf(Constants.EOL) + 1);
+        const lineBreakQty = ParseUtils.getLineBreakQty(node.toString());
+        const lineNumber   = node.isContainer() ? node.getLastChild().tailEndLineNumber : node.lineNumber + lineBreakQty - 1;
+        let globalPos      = node.globalPos;
+        let length         = node.head.trim().length;
+
+        if (node.tail) {
+            const lastLineBreakPos = node.tail.lastIndexOf(Constants.EOL);
+            const trailingSpaces   = node.tail.substring(lastLineBreakPos + 1);
+
+            if (trailingSpaces.length > 0) {
+                globalPos = node.tailGlobalPos + node.tail.trim().length + 1;
+                length    = trailingSpaces.length;
+
+                if (data.isCrlfLineBreak) {
+                    globalPos += ParseUtils.getLineBreakQty(node.tail.trimStart());
+                }
+            } else {
+                globalPos = node.tailGlobalPos + 1;
+                length    = node.tail.trim().length;
+            }
+        }
+
+        const error = this.getError(
+            lineContent,
+            lineNumber,
+            node.columnNumber,
+            globalPos,
+            length
+        );
+
+        occurrenceList.push(error);
+    }
+
+    return {
+        occurrenceList
+    };
+};
+
+module.exports = Rule;

package/src/rules/tree/enforce-security.js

@@ -1,85 +1,85 @@
-const TreeRulePrototype = require('../prototypes/TreeRulePrototype');
-const ConfigUtils       = require('../../util/ConfigUtils');
-
-const ruleId      = require('path').basename(__filename).slice(0, -3);
-const description = 'This code introduces a security risk';
-
-const Rule = Object.create(TreeRulePrototype);
-
-// Rule options;
-const REVERSE_TABNABBING = 'prevent-reverse-tabnabbing';
-
-Rule.init(ruleId, description);
-
-Rule.getDefaultAttrs = () => {
-    const result = {};
-
-    result[REVERSE_TABNABBING] = true;
-
-    return result;
-};
-
-Rule.isBroken = function(node) {
-    const config    = this.getConfigs();
-    const errorList = [];
-
-    if (config[REVERSE_TABNABBING]) {
-        const tabNabbingResult = checkReverseTabNabbing(node);
-
-        if (tabNabbingResult) {
-            errorList.push(tabNabbingResult);
-        }
-    }
-
-    return errorList;
-};
-
-Rule.check = function(node, data) {
-
-    const config           = ConfigUtils.load();
-    const occurrenceList   = this.checkChildren(node, data);
-    const errorMessageList = this.isBroken(node);
-
-    for (let i = 0; i < errorMessageList.length; i++) {
-        const error = this.getError(
-            node.head.trim(),
-            node.lineNumber,
-            node.columnNumber,
-            node.globalPos,
-            node.head.trim().length,
-            errorMessageList[i]
-        );
-
-        occurrenceList.push(error);
-    }
-
-    return this.return(node, occurrenceList, config);
-};
-
-const checkReverseTabNabbing = node => {
-    if (node.isOfType('a')) {
-        const attributeList         = node.getAttributeList();
-        let hasTargetBlankAttribute = false;
-        let hasRelNoOpenerAttribute = false;
-
-        for (let i = 0; i < attributeList.length; i++) {
-            const attribute = attributeList[i];
-
-            if (attribute.name === 'target' && attribute.value === '_blank') {
-                hasTargetBlankAttribute = true;
-            }
-
-            if (attribute.name === 'rel' && attribute.value.indexOf('noopener') >= 0) {
-                hasRelNoOpenerAttribute = true;
-            }
-        }
-
-        if (hasTargetBlankAttribute && !hasRelNoOpenerAttribute) {
-            return 'Potential reverse tabnabbing security hole detected. Consider adding \'rel="noopener"\'';
-        }
-    }
-
-    return null;
-};
-
-module.exports = Rule;
+const TreeRulePrototype = require('../prototypes/TreeRulePrototype');
+const ConfigUtils       = require('../../util/ConfigUtils');
+
+const ruleId      = require('path').basename(__filename).slice(0, -3);
+const description = 'This code introduces a security risk';
+
+const Rule = Object.create(TreeRulePrototype);
+
+// Rule options;
+const REVERSE_TABNABBING = 'prevent-reverse-tabnabbing';
+
+Rule.init(ruleId, description);
+
+Rule.getDefaultAttrs = () => {
+    const result = {};
+
+    result[REVERSE_TABNABBING] = true;
+
+    return result;
+};
+
+Rule.isBroken = function(node) {
+    const config    = this.getConfigs();
+    const errorList = [];
+
+    if (config[REVERSE_TABNABBING]) {
+        const tabNabbingResult = checkReverseTabNabbing(node);
+
+        if (tabNabbingResult) {
+            errorList.push(tabNabbingResult);
+        }
+    }
+
+    return errorList;
+};
+
+Rule.check = function(node, data) {
+
+    const config           = ConfigUtils.load();
+    const occurrenceList   = this.checkChildren(node, data);
+    const errorMessageList = this.isBroken(node);
+
+    for (let i = 0; i < errorMessageList.length; i++) {
+        const error = this.getError(
+            node.head.trim(),
+            node.lineNumber,
+            node.columnNumber,
+            node.globalPos,
+            node.head.trim().length,
+            errorMessageList[i]
+        );
+
+        occurrenceList.push(error);
+    }
+
+    return this.return(node, occurrenceList, config);
+};
+
+const checkReverseTabNabbing = node => {
+    if (node.isOfType('a')) {
+        const attributeList         = node.getAttributeList();
+        let hasTargetBlankAttribute = false;
+        let hasRelNoOpenerAttribute = false;
+
+        for (let i = 0; i < attributeList.length; i++) {
+            const attribute = attributeList[i];
+
+            if (attribute.name === 'target' && attribute.value === '_blank') {
+                hasTargetBlankAttribute = true;
+            }
+
+            if (attribute.name === 'rel' && attribute.value.indexOf('noopener') >= 0) {
+                hasRelNoOpenerAttribute = true;
+            }
+        }
+
+        if (hasTargetBlankAttribute && !hasRelNoOpenerAttribute) {
+            return 'Potential reverse tabnabbing security hole detected. Consider adding \'rel="noopener"\'';
+        }
+    }
+
+    return null;
+};
+
+module.exports = Rule;