isaacscript-common 9.13.0 → 9.13.3

package/src/functions/logEntities.ts

@@ -21,7 +21,6 @@ const IGNORE_EFFECT_VARIANTS: ReadonlySet<EffectVariant> = new Set([
 
 /** Helper function for printing out every entity (or filtered entity) in the current room. */
 export function logAllEntities(
-  this: void,
   includeBackgroundEffects: boolean,
   entityTypeFilter?: EntityType,
 ): void {
@@ -69,7 +68,6 @@ export function logAllEntities(
  * Helper function for printing out every grid entity (or filtered grid entity) in the current room.
  */
 export function logAllGridEntities(
-  this: void,
   includeWalls: boolean,
   gridEntityTypeFilter?: GridEntityType,
 ): void {
@@ -120,14 +118,14 @@ export function logAllGridEntities(
 }
 
 /** Helper function for logging an array of specific entities. */
-export function logEntities(this: void, entities: Entity[]): void {
+export function logEntities(entities: Entity[]): void {
   for (const entity of entities) {
     logEntity(entity);
   }
 }
 
 /** Helper function to log information about a specific entity. */
-export function logEntity(this: void, entity: Entity): void {
+export function logEntity(entity: Entity): void {
   const msg = getEntityLogLine(entity);
   log(msg);
 }
@@ -206,14 +204,14 @@ function getEntityLogLine(entity: Entity, num?: int): string {
 }
 
 /** Helper function for logging an array of specific grid entities. */
-export function logGridEntities(this: void, gridEntities: GridEntity[]): void {
+export function logGridEntities(gridEntities: GridEntity[]): void {
   for (const gridEntity of gridEntities) {
     logGridEntity(gridEntity);
   }
 }
 
 /** Helper function for log information about a specific grid entity. */
-export function logGridEntity(this: void, gridEntity: GridEntity): void {
+export function logGridEntity(gridEntity: GridEntity): void {
   const msg = getGridEntityLogLine(gridEntity);
   log(msg);
 }
@@ -279,7 +277,7 @@ function getGridEntityLogLine(gridEntity: GridEntity, num?: int): string {
  * Helper function to log information about the entity that corresponding to a pointer hash. (Only
  * use this when debugging, since retrieving the corresponding entity is expensive.)
  */
-export function logPtrHash(this: void, ptrHash: PtrHash): void {
+export function logPtrHash(ptrHash: PtrHash): void {
   log(`PtrHash: ${ptrHash}`);
   const entity = getEntityFromPtrHash(ptrHash);
   if (entity === undefined) {
@@ -293,7 +291,7 @@ export function logPtrHash(this: void, ptrHash: PtrHash): void {
  * Helper function to log information about the entity that corresponding to one or more pointer
  * hashes. (Only use this when debugging, since retrieving the corresponding entity is expensive.)
  */
-export function logPtrHashes(this: void, ptrHashes: PtrHash[]): void {
+export function logPtrHashes(ptrHashes: PtrHash[]): void {
   for (const ptrHash of ptrHashes) {
     logPtrHash(ptrHash);
   }

package/src/functions/set.ts

@@ -1,5 +1,6 @@
 import { getArrayCombinations, getRandomArrayElement, sumArray } from "./array";
 import { getRandomSeed } from "./rng";
+import { isPrimitive } from "./types";
 
 /**
  * Helper function to add all of the values in one set to another set. The first set passed will be
@@ -118,6 +119,18 @@ export function getSetCombinations<T>(
 export function getSortedSetValues<T>(set: Set<T> | ReadonlySet<T>): T[] {
   const values = set.values();
   const array = [...values];
+
+  // Check for problematic types in order to throw a helpful error message.
+  const firstElement = array[0];
+  if (firstElement !== undefined) {
+    const arrayType = type(firstElement);
+    if (!isPrimitive(arrayType)) {
+      error(
+        `Failed to get the sorted set values because the provided set was of type "${arrayType}". Having sets with non-primitive types doesn't make much sense in general, so you might need to rethink what you are doing.`,
+      );
+    }
+  }
+
   array.sort();
 
   return array;

package/src/lib/jsonLua.d.ts

@@ -4,7 +4,9 @@
  *
  * This parser was measured to be 11.8 times faster than the vanilla parser at decoding a sample
  * "save1.dat" file.
+ *
+ * @noSelfInFile
  */
 
-export function encode(this: void, data: unknown): string;
-export function decode(this: void, data: string): unknown;
+export function encode(data: unknown): string;
+export function decode(data: string): unknown;