isaacscript-common 87.9.3 → 87.9.5

package/dist/classes/features/other/CustomPickups.js

@@ -55,6 +55,7 @@ class CustomPickups extends Feature_1.Feature {
         if (shouldPickup !== undefined) {
             return shouldPickup;
         }
+        customPickupFunctions.collectFunc(pickup, player);
         pickup.Remove();
         const pickupSprite = pickup.GetSprite();
         const fileName = pickupSprite.GetFilename();
@@ -62,7 +63,6 @@ class CustomPickups extends Feature_1.Feature {
         const effectSprite = effect.GetSprite();
         effectSprite.Load(fileName, true);
         effectSprite.Play("Collect", true);
-        customPickupFunctions.collectFunc(pickup, player);
         return undefined;
     };
     // ModCallback.POST_EFFECT_RENDER (56)

package/dist/classes/features/other/CustomPickups.lua

@@ -49,6 +49,7 @@ function CustomPickups.prototype.____constructor(self)
         if shouldPickup ~= nil then
             return shouldPickup
         end
+        customPickupFunctions.collectFunc(pickup, player)
         pickup:Remove()
         local pickupSprite = pickup:GetSprite()
         local fileName = pickupSprite:GetFilename()
@@ -56,7 +57,6 @@ function CustomPickups.prototype.____constructor(self)
         local effectSprite = effect:GetSprite()
         effectSprite:Load(fileName, true)
         effectSprite:Play("Collect", true)
-        customPickupFunctions.collectFunc(pickup, player)
         return nil
     end
     self.postEffectRenderPickupEffect = function(____, effect)

package/dist/functions/rooms.d.ts

@@ -56,8 +56,8 @@ export declare function getRoomDataForTypeVariant(roomType: RoomType, roomVarian
  *
  * Note that `ItemPool.GetPoolForRoom` will return -1 in `RoomType.DEFAULT` (1) rooms, but this
  * function will convert -1 to `ItemPoolType.TREASURE` (0) for convenience purposes (since the game
- * is "supposed" to use the Treasure Room pool for collections spawned in normal rooms). If you need
- * to distinguish between real Treasure Rooms and default rooms, then use the
+ * is "supposed" to use the Treasure Room pool for collectibles spawned in normal rooms). If you
+ * need to distinguish between real Treasure Rooms and default rooms, then use the
  * `ItemPool.GetPoolForRoom` method directly.
  */
 export declare function getRoomItemPoolType(): ItemPoolType;

package/dist/functions/rooms.js

@@ -171,8 +171,8 @@ function getRoomDataForTypeVariant(roomType, roomVariant, cancelRoomTransition =
  *
  * Note that `ItemPool.GetPoolForRoom` will return -1 in `RoomType.DEFAULT` (1) rooms, but this
  * function will convert -1 to `ItemPoolType.TREASURE` (0) for convenience purposes (since the game
- * is "supposed" to use the Treasure Room pool for collections spawned in normal rooms). If you need
- * to distinguish between real Treasure Rooms and default rooms, then use the
+ * is "supposed" to use the Treasure Room pool for collectibles spawned in normal rooms). If you
+ * need to distinguish between real Treasure Rooms and default rooms, then use the
  * `ItemPool.GetPoolForRoom` method directly.
  */
 function getRoomItemPoolType() {

package/dist/functions/rooms.lua

@@ -340,8 +340,8 @@ end
 -- 
 -- Note that `ItemPool.GetPoolForRoom` will return -1 in `RoomType.DEFAULT` (1) rooms, but this
 -- function will convert -1 to `ItemPoolType.TREASURE` (0) for convenience purposes (since the game
--- is "supposed" to use the Treasure Room pool for collections spawned in normal rooms). If you need
--- to distinguish between real Treasure Rooms and default rooms, then use the
+-- is "supposed" to use the Treasure Room pool for collectibles spawned in normal rooms). If you
+-- need to distinguish between real Treasure Rooms and default rooms, then use the
 -- `ItemPool.GetPoolForRoom` method directly.
 function ____exports.getRoomItemPoolType(self)
     local itemPool = game:GetItemPool()

package/dist/index.rollup.d.ts

@@ -7516,8 +7516,8 @@ export declare function getRoomGridIndexesForType(...roomTypes: readonly RoomTyp
  *
  * Note that `ItemPool.GetPoolForRoom` will return -1 in `RoomType.DEFAULT` (1) rooms, but this
  * function will convert -1 to `ItemPoolType.TREASURE` (0) for convenience purposes (since the game
- * is "supposed" to use the Treasure Room pool for collections spawned in normal rooms). If you need
- * to distinguish between real Treasure Rooms and default rooms, then use the
+ * is "supposed" to use the Treasure Room pool for collectibles spawned in normal rooms). If you
+ * need to distinguish between real Treasure Rooms and default rooms, then use the
  * `ItemPool.GetPoolForRoom` method directly.
  */
 export declare function getRoomItemPoolType(): ItemPoolType;

package/dist/isaacscript-common.lua

@@ -1,6 +1,6 @@
 --[[
 
-isaacscript-common 87.9.2
+isaacscript-common 87.9.4
 
 This is the "isaacscript-common" library, which was created with the IsaacScript tool.
 
@@ -33684,8 +33684,8 @@ end
 -- 
 -- Note that `ItemPool.GetPoolForRoom` will return -1 in `RoomType.DEFAULT` (1) rooms, but this
 -- function will convert -1 to `ItemPoolType.TREASURE` (0) for convenience purposes (since the game
--- is "supposed" to use the Treasure Room pool for collections spawned in normal rooms). If you need
--- to distinguish between real Treasure Rooms and default rooms, then use the
+-- is "supposed" to use the Treasure Room pool for collectibles spawned in normal rooms). If you
+-- need to distinguish between real Treasure Rooms and default rooms, then use the
 -- `ItemPool.GetPoolForRoom` method directly.
 function ____exports.getRoomItemPoolType(self)
     local itemPool = game:GetItemPool()
@@ -48186,6 +48186,7 @@ function CustomPickups.prototype.____constructor(self)
         if shouldPickup ~= nil then
             return shouldPickup
         end
+        customPickupFunctions.collectFunc(pickup, player)
         pickup:Remove()
         local pickupSprite = pickup:GetSprite()
         local fileName = pickupSprite:GetFilename()
@@ -48193,7 +48194,6 @@ function CustomPickups.prototype.____constructor(self)
         local effectSprite = effect:GetSprite()
         effectSprite:Load(fileName, true)
         effectSprite:Play("Collect", true)
-        customPickupFunctions.collectFunc(pickup, player)
         return nil
     end
     self.postEffectRenderPickupEffect = function(____, effect)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "isaacscript-common",
-  "version": "87.9.3",
+  "version": "87.9.5",
   "description": "Helper functions and features for IsaacScript mods.",
   "keywords": [
     "isaac",
@@ -38,7 +38,7 @@
   },
   "devDependencies": {
     "@microsoft/api-extractor": "7.57.7",
-    "complete-node": "16.3.0",
+    "complete-node": "16.3.1",
     "eslint-plugin-sort-exports": "0.9.1",
     "typescript-eslint": "8.57.0",
     "typescript-to-lua": "1.34.0"

package/src/classes/features/other/CustomPickups.ts

@@ -78,6 +78,8 @@ export class CustomPickups extends Feature {
       return shouldPickup;
     }
 
+    customPickupFunctions.collectFunc(pickup, player);
+
     pickup.Remove();
 
     const pickupSprite = pickup.GetSprite();
@@ -92,8 +94,6 @@ export class CustomPickups extends Feature {
     effectSprite.Load(fileName, true);
     effectSprite.Play("Collect", true);
 
-    customPickupFunctions.collectFunc(pickup, player);
-
     return undefined;
   };
 

package/src/functions/rooms.ts

@@ -171,8 +171,8 @@ export function getRoomDataForTypeVariant(
  *
  * Note that `ItemPool.GetPoolForRoom` will return -1 in `RoomType.DEFAULT` (1) rooms, but this
  * function will convert -1 to `ItemPoolType.TREASURE` (0) for convenience purposes (since the game
- * is "supposed" to use the Treasure Room pool for collections spawned in normal rooms). If you need
- * to distinguish between real Treasure Rooms and default rooms, then use the
+ * is "supposed" to use the Treasure Room pool for collectibles spawned in normal rooms). If you
+ * need to distinguish between real Treasure Rooms and default rooms, then use the
  * `ItemPool.GetPoolForRoom` method directly.
  */
 export function getRoomItemPoolType(): ItemPoolType {