isaacscript-common 81.0.4 → 81.0.5

package/src/functions/curses.ts

@@ -31,7 +31,7 @@ export function getCurseIDByName(name: string): LevelCurse {
  *
  * Under the hood, this function uses the `Level.GetCurses` method.
  */
-export function hasCurse(...curses: LevelCurse[]): boolean {
+export function hasCurse(...curses: readonly LevelCurse[]): boolean {
   const level = game.GetLevel();
   const levelCurses = level.GetCurses();
 

package/src/functions/deepCopy.ts

@@ -245,7 +245,7 @@ function deepCopyDefaultMap(
   traversalDescription: string,
   classConstructors: LuaMap<string, AnyClass>,
   insideMap: boolean,
-): Readonly<LuaMap<AnyNotNil, unknown>> | ReadonlyMap<AnyNotNil, unknown> {
+): ReadonlyMap<AnyNotNil, unknown> | Readonly<LuaMap<AnyNotNil, unknown>> {
   if (SAVE_DATA_MANAGER_DEBUG) {
     log("deepCopy is copying a DefaultMap.");
   }
@@ -373,12 +373,12 @@ function getNewDefaultMap(
 }
 
 function deepCopyMap(
-  map: Map<AnyNotNil, unknown> | LuaMap<AnyNotNil, unknown>,
+  map: ReadonlyMap<AnyNotNil, unknown> | Readonly<LuaMap<AnyNotNil, unknown>>,
   serializationType: SerializationType,
   traversalDescription: string,
   classConstructors: LuaMap<string, AnyClass>,
   insideMap: boolean,
-): Readonly<LuaMap<AnyNotNil, unknown>> | ReadonlyMap<AnyNotNil, unknown> {
+): ReadonlyMap<AnyNotNil, unknown> | Readonly<LuaMap<AnyNotNil, unknown>> {
   if (SAVE_DATA_MANAGER_DEBUG) {
     log("deepCopy is copying a Map.");
   }
@@ -427,12 +427,12 @@ function deepCopyMap(
 }
 
 function deepCopySet(
-  set: Set<AnyNotNil> | LuaMap<AnyNotNil, unknown>,
+  set: ReadonlySet<AnyNotNil> | Readonly<LuaMap<AnyNotNil, unknown>>,
   serializationType: SerializationType,
   traversalDescription: string,
   classConstructors: LuaMap<string, AnyClass>,
   insideMap: boolean,
-): Readonly<LuaMap<AnyNotNil, string>> | ReadonlySet<AnyNotNil> {
+): ReadonlySet<AnyNotNil> | Readonly<LuaMap<AnyNotNil, string>> {
   if (SAVE_DATA_MANAGER_DEBUG) {
     log("deepCopy is copying a Set.");
   }
@@ -555,7 +555,7 @@ function deepCopyTSTLClass(
 }
 
 function deepCopyArray(
-  array: unknown[],
+  array: readonly unknown[],
   serializationType: SerializationType,
   traversalDescription: string,
   classConstructors: LuaMap<string, AnyClass>,

package/src/functions/doors.ts

@@ -203,7 +203,9 @@ export function getDoorSlotsForRoomShape(
  *
  * @allowEmptyVariadic
  */
-export function getDoors(...roomTypes: RoomType[]): readonly GridEntityDoor[] {
+export function getDoors(
+  ...roomTypes: readonly RoomType[]
+): readonly GridEntityDoor[] {
   const room = game.GetRoom();
   const roomShape = room.GetRoomShape();
   const roomTypesSet = new ReadonlySet(roomTypes);
@@ -240,7 +242,7 @@ export function getDoors(...roomTypes: RoomType[]): readonly GridEntityDoor[] {
  * that match any of the N room grid indexes.
  */
 export function getDoorsToRoomIndex(
-  ...roomGridIndex: int[]
+  ...roomGridIndex: readonly int[]
 ): readonly GridEntityDoor[] {
   const roomGridIndexesSet = new ReadonlySet(roomGridIndex);
   const doors = getDoors();
@@ -351,7 +353,7 @@ export function getVoidDoor(): GridEntityDoor | undefined {
  * This function is variadic, meaning that you can supply as many door types as you want to check
  * for. This function will return true if one or more room types match.
  */
-export function hasDoorType(...roomTypes: RoomType[]): boolean {
+export function hasDoorType(...roomTypes: readonly RoomType[]): boolean {
   const doors = getDoors();
   const doorsOfThisRoomType = doors.filter((door) =>
     roomTypes.some((roomType) => door.IsRoomType(roomType)),
@@ -580,7 +582,7 @@ export function openDoorFast(door: GridEntityDoor): void {
  * @returns The number of doors removed.
  * @allowEmptyVariadic
  */
-export function removeAllDoors(...roomTypes: RoomType[]): int {
+export function removeAllDoors(...roomTypes: readonly RoomType[]): int {
   const doors = getDoors(...roomTypes);
   removeDoors(...doors);
 
@@ -598,7 +600,7 @@ export function removeDoor(door: GridEntityDoor): void {
  *
  * This function is variadic, meaning that you can specify as many doors as you want to remove.
  */
-export function removeDoors(...doors: GridEntityDoor[]): void {
+export function removeDoors(...doors: readonly GridEntityDoor[]): void {
   for (const door of doors) {
     removeDoor(door);
   }

package/src/functions/external.ts

@@ -37,7 +37,7 @@ const REBIRTH_ITEM_TRACKER_WRITE_TO_FILE_COMMAND =
  * @see https://github.com/Rchardon/RebirthItemTracker
  */
 export function rebirthItemTrackerRemoveCollectible(
-  ...collectibleTypes: CollectibleType[]
+  ...collectibleTypes: readonly CollectibleType[]
 ): void {
   for (const collectibleType of collectibleTypes) {
     // This cannot use the "log" function since the prefix will prevent the Rebirth Item Tracker

package/src/functions/flag.ts

@@ -1,4 +1,5 @@
 import { DamageFlag } from "isaac-typescript-definitions";
+import type { ReadonlyRecord } from "../types/ReadonlyRecord";
 
 /**
  * Helper function to add a bit flag to an existing set of bit flags.
@@ -27,7 +28,7 @@ import { DamageFlag } from "isaac-typescript-definitions";
  */
 export function addFlag<T extends BitFlag | BitFlag128>(
   flags: T | BitFlags<T>,
-  ...flagsToAdd: T[]
+  ...flagsToAdd: readonly T[]
 ): BitFlags<T> {
   let flagsAsInt = flags as int;
 
@@ -64,7 +65,7 @@ export function bitFlags<T extends BitFlag | BitFlag128>(flag: T): BitFlags<T> {
  */
 export function getFlagName<T extends BitFlag | BitFlag128>(
   flag: BitFlag,
-  flagEnum: Record<string, T>,
+  flagEnum: ReadonlyRecord<string, T>,
 ): string | undefined {
   for (const [key, value] of Object.entries(flagEnum)) {
     if (value === flag) {
@@ -95,7 +96,7 @@ export function getFlagName<T extends BitFlag | BitFlag128>(
  */
 export function hasFlag<T extends BitFlag | BitFlag128>(
   flags: T | BitFlags<T>,
-  ...flagsToCheck: T[]
+  ...flagsToCheck: readonly T[]
 ): boolean {
   const flagsAsInt = flags as int;
 
@@ -153,7 +154,7 @@ export function isSelfDamage(
  */
 export function removeFlag<T extends BitFlag | BitFlag128>(
   flags: T | BitFlags<T>,
-  ...flagsToRemove: T[]
+  ...flagsToRemove: readonly T[]
 ): BitFlags<T> {
   let flagsAsInt = flags as int;
 

package/src/functions/gridEntities.ts

@@ -227,7 +227,7 @@ export function getConstituentsFromGridEntityID(
  * @allowEmptyVariadic
  */
 export function getGridEntities(
-  ...gridEntityTypes: GridEntityType[]
+  ...gridEntityTypes: readonly GridEntityType[]
 ): readonly GridEntity[] {
   const gridEntities = getAllGridEntities();
 
@@ -249,7 +249,7 @@ export function getGridEntities(
  * exclude.
  */
 export function getGridEntitiesExcept(
-  ...gridEntityTypes: GridEntityType[]
+  ...gridEntityTypes: readonly GridEntityType[]
 ): readonly GridEntity[] {
   const gridEntities = getAllGridEntities();
 
@@ -335,7 +335,7 @@ export function getGridEntitiesInRadius(
  * @allowEmptyVariadic
  */
 export function getGridEntitiesMap(
-  ...gridEntityTypes: GridEntityType[]
+  ...gridEntityTypes: readonly GridEntityType[]
 ): ReadonlyMap<int, GridEntity> {
   const gridEntities = getGridEntities(...gridEntityTypes);
 
@@ -885,7 +885,7 @@ export function isPostBossVoidPortal(gridEntity: GridEntity): boolean {
  * @returns The grid entities that were removed.
  */
 export function removeAllGridEntitiesExcept(
-  ...gridEntityTypes: GridEntityType[]
+  ...gridEntityTypes: readonly GridEntityType[]
 ): readonly GridEntity[] {
   const gridEntityTypeExceptions = new ReadonlySet(gridEntityTypes);
   const gridEntities = getGridEntities();
@@ -925,7 +925,7 @@ export function removeAllGridEntitiesExcept(
  * @returns An array of the grid entities removed.
  */
 export function removeAllMatchingGridEntities(
-  ...gridEntityType: GridEntityType[]
+  ...gridEntityType: readonly GridEntityType[]
 ): readonly GridEntity[] {
   const gridEntities = getGridEntities(...gridEntityType);
   if (gridEntities.length === 0) {

package/src/functions/input.ts

@@ -92,7 +92,7 @@ export function getShootButtonActions(
  */
 export function isActionPressed(
   controllerIndex: ControllerIndex,
-  ...buttonActions: ButtonAction[]
+  ...buttonActions: readonly ButtonAction[]
 ): boolean {
   return buttonActions.some((buttonAction) =>
     Input.IsActionPressed(buttonAction, controllerIndex),
@@ -107,7 +107,7 @@ export function isActionPressed(
  * function will return true if any of the buttons are pressed.
  */
 export function isActionPressedOnAnyInput(
-  ...buttonActions: ButtonAction[]
+  ...buttonActions: readonly ButtonAction[]
 ): boolean {
   return CONTROLLER_INDEX_VALUES.some((controllerIndex) =>
     isActionPressed(controllerIndex, ...buttonActions),
@@ -124,7 +124,7 @@ export function isActionPressedOnAnyInput(
  */
 export function isActionTriggered(
   controllerIndex: ControllerIndex,
-  ...buttonActions: ButtonAction[]
+  ...buttonActions: readonly ButtonAction[]
 ): boolean {
   return buttonActions.some((buttonAction) =>
     Input.IsActionTriggered(buttonAction, controllerIndex),
@@ -139,7 +139,7 @@ export function isActionTriggered(
  * function will return true if any of the buttons are pressed.
  */
 export function isActionTriggeredOnAnyInput(
-  ...buttonActions: ButtonAction[]
+  ...buttonActions: readonly ButtonAction[]
 ): boolean {
   return CONTROLLER_INDEX_VALUES.some((controllerIndex) =>
     isActionTriggered(controllerIndex, ...buttonActions),
@@ -152,7 +152,7 @@ export function isActionTriggeredOnAnyInput(
  * This function is variadic, meaning you can pass as many keyboard values as you want to check for.
  * This function will return true if any of the values are pressed.
  */
-export function isKeyboardPressed(...keys: Keyboard[]): boolean {
+export function isKeyboardPressed(...keys: readonly Keyboard[]): boolean {
   return keys.some((key) =>
     Input.IsButtonPressed(key, ControllerIndex.KEYBOARD),
   );

package/src/functions/itemPool.ts

@@ -128,7 +128,7 @@ export function isCollectibleTypeInDefaultItemPool(
  * This function is variadic, meaning you can pass as many collectible types as you want to remove.
  */
 export function removeCollectibleFromPools(
-  ...collectibleTypes: CollectibleType[]
+  ...collectibleTypes: readonly CollectibleType[]
 ): void {
   const itemPool = game.GetItemPool();
 
@@ -142,7 +142,9 @@ export function removeCollectibleFromPools(
  *
  * This function is variadic, meaning you can pass as many trinket types as you want to remove.
  */
-export function removeTrinketFromPools(...trinketTypes: TrinketType[]): void {
+export function removeTrinketFromPools(
+  ...trinketTypes: readonly TrinketType[]
+): void {
   const itemPool = game.GetItemPool();
 
   for (const trinketType of trinketTypes) {

package/src/functions/jsonRoom.ts

@@ -164,7 +164,7 @@ export function getJSONRoomsOfSubType(
  *                what the function is doing. Default is false.
  */
 export function getRandomJSONEntity(
-  jsonEntities: JSONEntity[],
+  jsonEntities: readonly JSONEntity[],
   seedOrRNG: Seed | RNG | undefined,
   verbose = false,
 ): JSONEntity {

package/src/functions/level.ts

@@ -58,7 +58,7 @@ export function getLevelBossIDs(): readonly BossID[] {
  * This function is variadic, meaning that you can pass as many boss IDs as you want to check for.
  * It will return true if one or more of the boss IDs are matched.
  */
-export function levelHasBossID(...bossIDs: BossID[]): boolean {
+export function levelHasBossID(...bossIDs: readonly BossID[]): boolean {
   const levelBossIDs = getLevelBossIDs();
   const levelBossIDsSet = new Set(levelBossIDs);
 
@@ -72,7 +72,7 @@ export function levelHasBossID(...bossIDs: BossID[]): boolean {
  * This function is variadic, meaning that you can pass as many room types as you want to check for.
  * This function will return true if any of the room types are found.
  */
-export function levelHasRoomType(...roomTypes: RoomType[]): boolean {
+export function levelHasRoomType(...roomTypes: readonly RoomType[]): boolean {
   const roomDescriptors = getRoomDescriptorsForType(...roomTypes);
   return roomDescriptors.length > 0;
 }

package/src/functions/levelGrid.ts

@@ -318,7 +318,7 @@ export function getRoomAdjacentGridIndexes(
  * descriptors for N room types.
  */
 export function getRoomDescriptorsForType(
-  ...roomTypes: RoomType[]
+  ...roomTypes: readonly RoomType[]
 ): readonly RoomDescriptor[] {
   const roomTypesSet = new Set<RoomType>(roomTypes);
 
@@ -340,7 +340,7 @@ export function getRoomDescriptorsForType(
  * indexes for N room types.
  */
 export function getRoomGridIndexesForType(
-  ...roomTypes: RoomType[]
+  ...roomTypes: readonly RoomType[]
 ): readonly int[] {
   const roomDescriptors = getRoomDescriptorsForType(...roomTypes);
   return roomDescriptors.map((roomDescriptor) => roomDescriptor.SafeGridIndex);

package/src/functions/logEntities.ts

@@ -142,7 +142,7 @@ export function logAllGridEntities(
 }
 
 /** Helper function for logging an array of specific entities. */
-export function logEntities(this: void, entities: Entity[]): void {
+export function logEntities(this: void, entities: readonly Entity[]): void {
   for (const entity of entities) {
     logEntity(entity);
   }
@@ -295,7 +295,10 @@ function getTearVariantName(tear: EntityTear) {
 }
 
 /** Helper function for logging an array of specific grid entities. */
-export function logGridEntities(this: void, gridEntities: GridEntity[]): void {
+export function logGridEntities(
+  this: void,
+  gridEntities: readonly GridEntity[],
+): void {
   for (const gridEntity of gridEntities) {
     logGridEntity(gridEntity);
   }
@@ -386,7 +389,7 @@ export function logPtrHash(this: void, ptrHash: PtrHash): void {
  * Helper function to log information about the entity that corresponding to one or more pointer
  * hashes. (Only use this when debugging, since retrieving the corresponding entity is expensive.)
  */
-export function logPtrHashes(this: void, ptrHashes: PtrHash[]): void {
+export function logPtrHashes(this: void, ptrHashes: readonly PtrHash[]): void {
   for (const ptrHash of ptrHashes) {
     logPtrHash(ptrHash);
   }

package/src/functions/logMisc.ts

@@ -20,6 +20,7 @@ import {
 } from "isaac-typescript-definitions";
 import { game, musicManager, sfxManager } from "../core/cachedClasses";
 import type { ReadonlyMap } from "../types/ReadonlyMap";
+import type { ReadonlyRecord } from "../types/ReadonlyRecord";
 import { ReadonlySet } from "../types/ReadonlySet";
 import { arrayToString, isArray } from "./array";
 import { getBossID } from "./bosses";
@@ -140,7 +141,7 @@ export function logEntityID(this: void, entity: Entity): void {
 export function logFlags<T extends BitFlag | BitFlag128>(
   this: void,
   flags: T | BitFlags<T>,
-  flagEnum: Record<string, T>,
+  flagEnum: ReadonlyRecord<string, T>,
   description = "",
 ): void {
   if (description !== "") {

package/src/functions/map.ts

@@ -33,6 +33,7 @@ export function defaultMapGetHash<V, A extends unknown[]>(
  * `mapSetHash` helper function.
  */
 export function defaultMapSetHash<V>(
+  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
   map: Map<PtrHash, V>,
   entity: Entity,
   value: V,
@@ -78,6 +79,7 @@ export function getReversedMap<K, V>(
  * the map uses `PtrHash` as an index.
  */
 export function mapSetHash<V>(
+  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
   map: Map<PtrHash, V>,
   entity: Entity,
   value: V,

package/src/functions/merge.ts

@@ -53,9 +53,9 @@ import { getTraversalDescription } from "./utils";
  */
 export function merge(
   oldObject:
-    | LuaMap<AnyNotNil, unknown>
-    | Map<AnyNotNil, unknown>
-    | Set<AnyNotNil>,
+    | Readonly<LuaMap<AnyNotNil, unknown>>
+    | ReadonlyMap<AnyNotNil, unknown>
+    | ReadonlySet<AnyNotNil>,
   newTable: LuaMap<AnyNotNil, unknown>,
   traversalDescription: string,
   classConstructors = new LuaMap<string, AnyClass>(),
@@ -131,6 +131,7 @@ function mergeSerializedArray(
 }
 
 function mergeSerializedTSTLObject(
+  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
   oldObject: Map<AnyNotNil, unknown> | Set<AnyNotNil>,
   newTable: LuaMap<AnyNotNil, unknown>,
   traversalDescription: string,

package/src/functions/npcDataStructures.ts

@@ -41,6 +41,7 @@ export function defaultMapGetNPC<V, Args extends unknown[]>(
  * `mapSetNPC` helper function.
  */
 export function defaultMapSetNPC<V>(
+  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
   map: Map<PtrHash, V>,
   npc: EntityNPC,
   value: V,
@@ -53,6 +54,7 @@ export function defaultMapSetNPC<V>(
  * `Map.delete` method if you have a set of this type.
  */
 export function mapDeleteNPC(
+  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
   map: Map<PtrHash, unknown>,
   npc: EntityNPC,
 ): boolean {
@@ -81,7 +83,7 @@ export function mapDeleteNPC(
  * ```
  */
 export function mapGetNPC<V>(
-  map: Map<PtrHash, V>,
+  map: ReadonlyMap<PtrHash, V>,
   npc: EntityNPC,
 ): V | undefined {
   const ptrHash = GetPtrHash(npc);
@@ -92,7 +94,10 @@ export function mapGetNPC<V>(
  * Helper function to make using maps with an index of `PtrHash` easier. Use this instead of the
  * `Map.has` method if you have a map of this type.
  */
-export function mapHasNPC<V>(map: Map<PtrHash, V>, npc: EntityNPC): boolean {
+export function mapHasNPC<V>(
+  map: ReadonlyMap<PtrHash, V>,
+  npc: EntityNPC,
+): boolean {
   const ptrHash = GetPtrHash(npc);
   return map.has(ptrHash);
 }
@@ -118,6 +123,7 @@ export function mapHasNPC<V>(map: Map<PtrHash, V>, npc: EntityNPC): boolean {
  * ```
  */
 export function mapSetNPC<V>(
+  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
   map: Map<PtrHash, V>,
   npc: EntityNPC,
   value: V,
@@ -130,6 +136,7 @@ export function mapSetNPC<V>(
  * Helper function to make using sets with an type of `PtrHash` easier. Use this instead of the
  * `Set.add` method if you have a set of this type.
  */
+// eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
 export function setAddNPC(set: Set<PtrHash>, npc: EntityNPC): void {
   const ptrHash = GetPtrHash(npc);
   set.add(ptrHash);
@@ -139,6 +146,7 @@ export function setAddNPC(set: Set<PtrHash>, npc: EntityNPC): void {
  * Helper function to make using sets with an type of `PtrHash` easier. Use this instead of the
  * `Set.delete` method if you have a set of this type.
  */
+// eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
 export function setDeleteNPC(set: Set<PtrHash>, npc: EntityNPC): boolean {
   const ptrHash = GetPtrHash(npc);
   return set.delete(ptrHash);
@@ -148,7 +156,7 @@ export function setDeleteNPC(set: Set<PtrHash>, npc: EntityNPC): boolean {
  * Helper function to make using sets with an type of `PtrHash` easier. Use this instead of the
  * `Set.has` method if you have a set of this type.
  */
-export function setHasNPC(set: Set<PtrHash>, npc: EntityNPC): boolean {
+export function setHasNPC(set: ReadonlySet<PtrHash>, npc: EntityNPC): boolean {
   const ptrHash = GetPtrHash(npc);
   return set.has(ptrHash);
 }

package/src/functions/playerCollectibles.ts

@@ -19,7 +19,7 @@ import { isCharacter } from "./players";
  */
 export function addCollectible(
   player: EntityPlayer,
-  ...collectibleTypes: CollectibleType[]
+  ...collectibleTypes: readonly CollectibleType[]
 ): void {
   for (const collectibleType of collectibleTypes) {
     player.AddCollectible(collectibleType);
@@ -93,7 +93,7 @@ export function getAdjustedPrice(basePrice: int): int {
  */
 export function getPlayerCollectibleCount(
   player: EntityPlayer,
-  ...collectibleTypes: CollectibleType[]
+  ...collectibleTypes: readonly CollectibleType[]
 ): int {
   let numCollectibles = 0;
   for (const collectibleType of collectibleTypes) {
@@ -111,7 +111,7 @@ export function getPlayerCollectibleCount(
  * check for. It only returns the players that have all of the collectibles.
  */
 export function getPlayersWithCollectible(
-  ...collectibleTypes: CollectibleType[]
+  ...collectibleTypes: readonly CollectibleType[]
 ): readonly EntityPlayer[] {
   const players = getPlayers();
 
@@ -150,7 +150,7 @@ export function getTotalPlayerCollectibles(
  */
 export function hasCollectible(
   player: EntityPlayer,
-  ...collectibleTypes: CollectibleType[]
+  ...collectibleTypes: readonly CollectibleType[]
 ): boolean {
   return collectibleTypes.some((collectibleType) =>
     player.HasCollectible(collectibleType),
@@ -168,7 +168,7 @@ export function hasCollectible(
 export function hasCollectibleInActiveSlot(
   player: EntityPlayer,
   collectibleType: CollectibleType,
-  ...activeSlots: ActiveSlot[]
+  ...activeSlots: readonly ActiveSlot[]
 ): boolean {
   const matchingActiveSlotsSet = new ReadonlySet(activeSlots);
   const activeItemSlots = getActiveItemSlots(player, collectibleType);
@@ -245,7 +245,7 @@ export function removeAllActiveItems(player: EntityPlayer): void {
  */
 export function removeCollectible(
   player: EntityPlayer,
-  ...collectibleTypes: CollectibleType[]
+  ...collectibleTypes: readonly CollectibleType[]
 ): void {
   for (const collectibleType of collectibleTypes) {
     player.RemoveCollectible(collectibleType);
@@ -276,7 +276,7 @@ export function removeCollectibleCostume(
  * remove.
  */
 export function removeCollectibleFromAllPlayers(
-  ...collectibleTypes: CollectibleType[]
+  ...collectibleTypes: readonly CollectibleType[]
 ): void {
   for (const player of getAllPlayers()) {
     for (const collectibleType of collectibleTypes) {

package/src/functions/playerDataStructures.ts

@@ -39,6 +39,7 @@ export function defaultMapGetPlayer<V, Args extends unknown[]>(
  * `mapSetPlayer` helper function.
  */
 export function defaultMapSetPlayer<V>(
+  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
   map: Map<PlayerIndex, V>,
   player: EntityPlayer,
   value: V,
@@ -51,6 +52,7 @@ export function defaultMapSetPlayer<V>(
  * `Map.delete` method if you have a set of this type.
  */
 export function mapDeletePlayer(
+  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
   map: Map<PlayerIndex, unknown>,
   player: EntityPlayer,
 ): boolean {
@@ -79,7 +81,7 @@ export function mapDeletePlayer(
  * ```
  */
 export function mapGetPlayer<V>(
-  map: Map<PlayerIndex, V>,
+  map: ReadonlyMap<PlayerIndex, V>,
   player: EntityPlayer,
 ): V | undefined {
   const playerIndex = getPlayerIndex(player);
@@ -91,7 +93,7 @@ export function mapGetPlayer<V>(
  * `Map.has` method if you have a map of this type.
  */
 export function mapHasPlayer<V>(
-  map: Map<PlayerIndex, V>,
+  map: ReadonlyMap<PlayerIndex, V>,
   player: EntityPlayer,
 ): boolean {
   const playerIndex = getPlayerIndex(player);
@@ -119,6 +121,7 @@ export function mapHasPlayer<V>(
  * ```
  */
 export function mapSetPlayer<V>(
+  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
   map: Map<PlayerIndex, V>,
   player: EntityPlayer,
   value: V,
@@ -132,6 +135,7 @@ export function mapSetPlayer<V>(
  * `Set.add` method if you have a set of this type.
  */
 export function setAddPlayer(
+  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
   set: Set<PlayerIndex>,
   player: EntityPlayer,
 ): void {
@@ -144,6 +148,7 @@ export function setAddPlayer(
  * `Set.delete` method if you have a set of this type.
  */
 export function setDeletePlayer(
+  // eslint-disable-next-line isaacscript/prefer-readonly-parameter-types
   set: Set<PlayerIndex>,
   player: EntityPlayer,
 ): boolean {
@@ -156,7 +161,7 @@ export function setDeletePlayer(
  * `Set.has` method if you have a set of this type.
  */
 export function setHasPlayer(
-  set: Set<PlayerIndex>,
+  set: ReadonlySet<PlayerIndex>,
   player: EntityPlayer,
 ): boolean {
   const playerIndex = getPlayerIndex(player);

package/src/functions/playerTrinkets.ts

@@ -98,7 +98,7 @@ export function getPlayerTrinkets(
  * for. It only returns the players that have all of the trinkets.
  */
 export function getPlayersWithTrinket(
-  ...trinketTypes: TrinketType[]
+  ...trinketTypes: readonly TrinketType[]
 ): readonly EntityPlayer[] {
   const players = getPlayers();
 
@@ -143,7 +143,7 @@ export function hasOpenTrinketSlot(player: EntityPlayer): boolean {
  */
 export function hasTrinket(
   player: EntityPlayer,
-  ...trinketTypes: TrinketType[]
+  ...trinketTypes: readonly TrinketType[]
 ): boolean {
   return trinketTypes.some((trinketType) => player.HasTrinket(trinketType));
 }

package/src/functions/players.ts

@@ -34,7 +34,9 @@ export function anyPlayerHoldingItem(): boolean {
  * This function is variadic, meaning that you can supply as many characters as you want to check
  * for. Returns true if any of the characters supplied are present.
  */
-export function anyPlayerIs(...matchingCharacters: PlayerType[]): boolean {
+export function anyPlayerIs(
+  ...matchingCharacters: readonly PlayerType[]
+): boolean {
   const matchingCharacterSet = new ReadonlySet(matchingCharacters);
   const characters = getCharacters();
 
@@ -271,7 +273,7 @@ export function getPlayerNumHitsRemaining(player: EntityPlayer): int {
  * for. Returns true if any of the characters supplied are present.
  */
 export function getPlayersOfType(
-  ...characters: PlayerType[]
+  ...characters: readonly PlayerType[]
 ): readonly EntityPlayer[] {
   const charactersSet = new ReadonlySet(characters);
   const players = getPlayers();
@@ -321,7 +323,7 @@ export function getPlayersWithControllerIndex(
  */
 export function hasForm(
   player: EntityPlayer,
-  ...playerForms: PlayerForm[]
+  ...playerForms: readonly PlayerForm[]
 ): boolean {
   return playerForms.some((playerForm) => player.HasPlayerForm(playerForm));
 }
@@ -379,7 +381,7 @@ export function isBethany(player: EntityPlayer): boolean {
  */
 export function isCharacter(
   player: EntityPlayer,
-  ...characters: PlayerType[]
+  ...characters: readonly PlayerType[]
 ): boolean {
   const characterSet = new ReadonlySet(characters);
   const character = player.GetPlayerType();