isaacscript-common 7.1.0 → 7.2.1

package/src/functions/cacheFlag.ts

@@ -1,5 +1,62 @@
-import { CacheFlag } from "isaac-typescript-definitions";
+import { CacheFlag, CollectibleType } from "isaac-typescript-definitions";
+import { itemConfig } from "../core/cachedClasses";
 import { DEFAULT_PLAYER_STAT_MAP } from "../maps/defaultPlayerStatMap";
+import { getCollectibleArray } from "./collectibleSet";
+import { getEnumValues } from "./enums";
+import { hasFlag } from "./flag";
+import { copySet, getSortedSetValues } from "./set";
+import { repeat } from "./utils";
+
+const CACHE_FLAG_TO_COLLECTIBLES_MAP = new Map<
+  CacheFlag,
+  Set<CollectibleType>
+>();
+
+function initCacheFlagMap() {
+  for (const cacheFlag of getEnumValues(CacheFlag)) {
+    const collectiblesSet = new Set<CollectibleType>();
+
+    for (const collectibleType of getCollectibleArray()) {
+      if (collectibleHasCacheFlag(collectibleType, cacheFlag)) {
+        collectiblesSet.add(collectibleType);
+      }
+    }
+
+    CACHE_FLAG_TO_COLLECTIBLES_MAP.set(cacheFlag, collectiblesSet);
+  }
+}
+
+export function collectibleHasCacheFlag(
+  collectibleType: CollectibleType,
+  cacheFlag: CacheFlag,
+): boolean {
+  const itemConfigItem = itemConfig.GetCollectible(collectibleType);
+  if (itemConfigItem === undefined) {
+    return false;
+  }
+
+  return hasFlag(itemConfigItem.CacheFlags, cacheFlag);
+}
+
+/**
+ * Returns a set containing every collectible type with the given cache flag, including modded
+ * collectibles.
+ */
+export function getCollectiblesForCacheFlag(
+  cacheFlag: CacheFlag,
+): Set<CollectibleType> {
+  // Lazy initialize the map.
+  if (CACHE_FLAG_TO_COLLECTIBLES_MAP.size === 0) {
+    initCacheFlagMap();
+  }
+
+  const collectiblesSet = CACHE_FLAG_TO_COLLECTIBLES_MAP.get(cacheFlag);
+  if (collectiblesSet === undefined) {
+    return new Set();
+  }
+
+  return copySet(collectiblesSet);
+}
 
 /**
  * Returns the starting stat that Isaac (the default character) starts with. For example, if you
@@ -10,3 +67,35 @@ import { DEFAULT_PLAYER_STAT_MAP } from "../maps/defaultPlayerStatMap";
 export function getDefaultPlayerStat(cacheFlag: CacheFlag): number | undefined {
   return DEFAULT_PLAYER_STAT_MAP.get(cacheFlag);
 }
+
+/**
+ * Returns an array containing every collectible type that the player has that matches the provided
+ * CacheFlag.
+ *
+ * For example, if the cache flag is `CacheFlag.FLYING`, and the player has one Lord of the Pit and
+ * two Dead Doves, then this function would return:
+ *
+ * ```ts
+ * [
+ *   CollectibleType.LORD_OF_THE_PIT,
+ *   CollectibleType.DEAD_DOVE,
+ *   CollectibleType.DEAD_DOVE,
+ * ]
+ * ```
+ */
+export function getPlayerCollectiblesForCacheFlag(
+  player: EntityPlayer,
+  cacheFlag: CacheFlag,
+): CollectibleType[] {
+  const collectiblesForCacheFlag = getCollectiblesForCacheFlag(cacheFlag);
+
+  const playerCollectibles: CollectibleType[] = [];
+  for (const collectibleType of getSortedSetValues(collectiblesForCacheFlag)) {
+    const numCollectibles = player.GetCollectibleNum(collectibleType);
+    repeat(numCollectibles, () => {
+      playerCollectibles.push(collectibleType);
+    });
+  }
+
+  return playerCollectibles;
+}

package/src/functions/cards.ts

@@ -59,7 +59,7 @@ function initCardObjects() {
 
 /** Helper function to get an array with every valid card sub-type. This includes modded cards. */
 export function getAllCards(): Card[] {
-  return irange(FIRST_CARD, LAST_CARD) as Card[];
+  return irange(FIRST_CARD, LAST_CARD);
 }
 
 /**
@@ -159,7 +159,7 @@ export function getModdedCards(): Card[] {
     return [];
   }
 
-  return irange(FIRST_MODDED_CARD, LAST_CARD) as Card[];
+  return irange(FIRST_MODDED_CARD, LAST_CARD);
 }
 
 /**
@@ -216,7 +216,7 @@ export function getRandomRune(
 
 /** Helper function to get an array with every valid vanilla card sub-type. */
 export function getVanillaCards(): Card[] {
-  return irange(FIRST_CARD, MAX_VANILLA_CARD) as Card[];
+  return irange(FIRST_CARD, MAX_VANILLA_CARD);
 }
 
 /**

package/src/functions/collectibles.ts

@@ -389,10 +389,7 @@ export function getModdedCollectibleTypes(): CollectibleType[] {
     return [];
   }
 
-  return irange(
-    FIRST_MODDED_COLLECTIBLE_TYPE,
-    LAST_COLLECTIBLE_TYPE,
-  ) as CollectibleType[];
+  return irange(FIRST_MODDED_COLLECTIBLE_TYPE, LAST_COLLECTIBLE_TYPE);
 }
 
 /**
@@ -404,10 +401,7 @@ export function getModdedCollectibleTypes(): CollectibleType[] {
  * should use the `getVanillaCollectibleSet` helper function instead.
  */
 export function getVanillaCollectibleTypeRange(): CollectibleType[] {
-  return irange(
-    FIRST_COLLECTIBLE_TYPE,
-    LAST_VANILLA_COLLECTIBLE_TYPE,
-  ) as CollectibleType[];
+  return irange(FIRST_COLLECTIBLE_TYPE, LAST_VANILLA_COLLECTIBLE_TYPE);
 }
 
 /** Returns true if the item type in the item config is equal to `ItemType.ITEM_ACTIVE`. */

package/src/functions/color.ts

@@ -47,7 +47,7 @@ export function deserializeColor(color: SerializedColor): Color {
   }
 
   const [r, g, b, a, ro, go, bo] = getNumbersFromTable(
-    color as LuaMap<string, unknown>,
+    color,
     OBJECT_NAME,
     ...KEYS,
   );

package/src/functions/deepCopy.ts

@@ -23,7 +23,7 @@ import {
   isUserDefinedTSTLClass,
   newTSTLClass,
 } from "./tstlClass";
-import { isNumber, isPrimitive } from "./types";
+import { asString, isNumber, isPrimitive } from "./types";
 import { getTraversalDescription, twoDimensionalSort } from "./utils";
 
 const COPYABLE_ISAAC_API_CLASS_TYPES_SET = new Set<string>(
@@ -575,7 +575,7 @@ function getCopiedEntries(
   const convertStringKeysToNumbers =
     serializationType === SerializationType.DESERIALIZE &&
     entries.some(
-      ([key]) => key === (SerializationBrand.OBJECT_WITH_NUMBER_KEYS as string),
+      ([key]) => key === asString(SerializationBrand.OBJECT_WITH_NUMBER_KEYS),
     );
 
   const hasNumberKeys = entries.some(([key]) => isNumber(key));

package/src/functions/dimensions.ts

@@ -8,7 +8,7 @@ import { erange } from "./utils";
  * Helper function to get an array with every valid `Dimension` (not including `Dimension.CURRENT`).
  */
 export function getAllDimensions(): Dimension[] {
-  return erange(NUM_DIMENSIONS) as Dimension[];
+  return erange(NUM_DIMENSIONS);
 }
 
 /**

package/src/functions/doors.ts

@@ -22,6 +22,7 @@ import { arrayToBitFlags } from "./bitwise";
 import { directionToVector } from "./direction";
 import { getEnumValues } from "./enums";
 import { isTSTLSet } from "./tstlClass";
+import { asNumber } from "./types";
 
 /**
  * When players enter a room, they do not appear exactly on the location of the door, because then
@@ -341,8 +342,7 @@ export function isHiddenSecretRoomDoor(door: GridEntityDoor): boolean {
  * you to the Repentance floor.
  */
 export function isRepentanceDoor(door: GridEntityDoor): boolean {
-  // eslint-disable-next-line isaacscript/strict-enums
-  return door.TargetRoomIndex === GridRoom.SECRET_EXIT;
+  return door.TargetRoomIndex === asNumber(GridRoom.SECRET_EXIT);
 }
 
 /**

package/src/functions/entities.ts

@@ -6,7 +6,7 @@ import { AnyEntity } from "../types/AnyEntity";
 import { getIsaacAPIClassName } from "./isaacAPIClass";
 import { getRandom } from "./random";
 import { isRNG, newRNG } from "./rng";
-import { isPrimitive } from "./types";
+import { asNumber, isPrimitive } from "./types";
 import { isVector, vectorToString } from "./vector";
 
 /**
@@ -122,7 +122,7 @@ export function getEntities(
   subType = -1,
   ignoreFriendly = false,
 ): Entity[] {
-  if ((entityType as int) === -1) {
+  if (asNumber(entityType) === -1) {
     return Isaac.GetRoomEntities();
   }
 

package/src/functions/flying.ts

@@ -5,7 +5,7 @@ import {
   PlayerType,
   TrinketType,
 } from "isaac-typescript-definitions";
-import { getCollectiblesForCacheFlag } from "./collectibleCacheFlag";
+import { getCollectiblesForCacheFlag } from "./cacheFlag";
 import { copySet, deleteSetsFromSet } from "./set";
 
 const FLYING_CHARACTERS: ReadonlySet<PlayerType> = new Set([

package/src/functions/gridEntities.ts

@@ -19,7 +19,7 @@ import { AnyGridEntity } from "../types/AnyGridEntity";
 import { isCircleIntersectingRectangle } from "./math";
 import { roomUpdateSafe } from "./rooms";
 import { clearSprite } from "./sprites";
-import { isNumber } from "./types";
+import { asNumber, isNumber } from "./types";
 import { erange } from "./utils";
 import { isVector } from "./vector";
 
@@ -136,7 +136,7 @@ export function getCollidingEntitiesWithGridEntity(
 export function getCrawlSpaces(
   crawlSpaceVariant: CrawlSpaceVariant = -1,
 ): GridEntity[] {
-  if ((crawlSpaceVariant as int) === -1) {
+  if (asNumber(crawlSpaceVariant) === -1) {
     return getGridEntities(GridEntityType.CRAWL_SPACE);
   }
 

package/src/functions/gridEntitiesSpecific.ts

@@ -11,6 +11,7 @@ import {
   removeGridEntities,
   spawnGridEntityWithVariant,
 } from "./gridEntities";
+import { asNumber } from "./types";
 
 // The `getDoors` function is not located here because doors are collected via the `Room.GetDoor`
 // method instead, which is faster.
@@ -29,7 +30,7 @@ export function getPits(pitVariant: PitVariant = -1): GridEntityPit[] {
     const pit = gridEntity.ToPit();
     if (pit !== undefined) {
       const gridEntityVariant = pit.GetVariant();
-      if ((pitVariant as int) === -1 || pitVariant === gridEntityVariant) {
+      if (asNumber(pitVariant) === -1 || pitVariant === gridEntityVariant) {
         pits.push(pit);
       }
     }
@@ -54,7 +55,7 @@ export function getPoops(
     const poop = gridEntity.ToPoop();
     if (poop !== undefined) {
       const gridEntityVariant = poop.GetVariant();
-      if ((poopVariant as int) === -1 || poopVariant === gridEntityVariant) {
+      if (asNumber(poopVariant) === -1 || poopVariant === gridEntityVariant) {
         poops.push(poop);
       }
     }
@@ -80,7 +81,7 @@ export function getPressurePlates(
     if (pressurePlate !== undefined) {
       const gridEntityVariant = pressurePlate.GetVariant();
       if (
-        (pressurePlateVariant as int) === -1 ||
+        asNumber(pressurePlateVariant) === -1 ||
         pressurePlateVariant === gridEntityVariant
       ) {
         pressurePlates.push(pressurePlate);

package/src/functions/index.ts

@@ -13,7 +13,6 @@ export * from "./challenges";
 export * from "./characters";
 export * from "./charge";
 export * from "./chargeBar";
-export * from "./collectibleCacheFlag";
 export * from "./collectibles";
 export * from "./collectibleSet";
 export * from "./collectibleTag";

package/src/functions/indexTypeDoc.ts

@@ -13,7 +13,6 @@ export * as Challenges from "./challenges";
 export * as Characters from "./characters";
 export * as Charge from "./charge";
 export * as ChargeBar from "./chargeBar";
-export * as CollectibleCacheFlag from "./collectibleCacheFlag";
 export * as Collectibles from "./collectibles";
 export * as CollectibleSet from "./collectibleSet";
 export * as CollectibleTag from "./collectibleTag";

package/src/functions/input.ts

@@ -4,6 +4,7 @@ import {
   ControllerIndex,
   Keyboard,
 } from "isaac-typescript-definitions";
+import { KEYBOARD_TO_STRING } from "../maps/keyboardToString";
 import { getEnumValues } from "./enums";
 import { copySet } from "./set";
 import { trimPrefix } from "./string";
@@ -42,10 +43,10 @@ const SHOOTING_ACTIONS_SET: ReadonlySet<ButtonAction> = new Set(
 );
 
 /** Helper function to get the enum name for the specified `Controller` value. */
-export function controllerToString(controller: Controller): string {
+export function controllerToString(controller: Controller): string | undefined {
   const key = Controller[controller];
   if (key === undefined) {
-    return "unknown";
+    return undefined;
   }
 
   return trimPrefix(key, "BUTTON_");
@@ -133,6 +134,18 @@ export function isShootActionTriggeredOnAnyInput(): boolean {
   );
 }
 
-export function keyboardToString(keyboard: Keyboard): string {
-  return Keyboard[keyboard] ?? "unknown";
+/**
+ * Helper function to get the string that would be typed if someone pressed the corresponding key.
+ */
+export function keyboardToString(
+  keyboard: Keyboard,
+  uppercase: boolean,
+): string | undefined {
+  const tuple = KEYBOARD_TO_STRING.get(keyboard);
+  if (tuple === undefined) {
+    return undefined;
+  }
+
+  const [lowercaseCharacter, uppercaseCharacter] = tuple;
+  return uppercase ? uppercaseCharacter : lowercaseCharacter;
 }

package/src/functions/jsonHelpers.ts

@@ -2,7 +2,7 @@ import * as jsonLua from "../lib/jsonLua";
 import { logError } from "./log";
 
 function tryDecode(this: void, jsonString: string) {
-  return jsonLua.decode(jsonString) as LuaMap;
+  return jsonLua.decode(jsonString) as LuaMap<AnyNotNil, unknown>;
 }
 
 function tryEncode(this: void, luaTable: unknown) {

package/src/functions/kColor.ts

@@ -34,11 +34,7 @@ export function deserializeKColor(kColor: SerializedKColor): KColor {
     );
   }
 
-  const [r, g, b, a] = getNumbersFromTable(
-    kColor as LuaMap<string, unknown>,
-    OBJECT_NAME,
-    ...KEYS,
-  );
+  const [r, g, b, a] = getNumbersFromTable(kColor, OBJECT_NAME, ...KEYS);
 
   if (r === undefined) {
     error(

package/src/functions/levelGrid.ts

@@ -37,6 +37,7 @@ import {
 } from "./roomData";
 import { getRooms, getRoomsInsideGrid } from "./rooms";
 import { getGridIndexDelta } from "./roomShape";
+import { asNumber } from "./types";
 
 const LEFT = -1;
 const UP = -LEVEL_GRID_ROW_WIDTH;
@@ -177,8 +178,8 @@ export function getNewRoomCandidatesForLevel(): Array<
     (room) =>
       room.Data !== undefined &&
       room.Data.Type === RoomType.DEFAULT &&
-      room.Data.Subtype !== (DownpourRoomSubType.MIRROR as int) &&
-      room.Data.Subtype !== (MinesRoomSubType.MINESHAFT_ENTRANCE as int),
+      room.Data.Subtype !== asNumber(DownpourRoomSubType.MIRROR) &&
+      room.Data.Subtype !== asNumber(MinesRoomSubType.MINESHAFT_ENTRANCE),
   );
 
   const newRoomCandidates: Array<[int, DoorSlot, int]> = [];

package/src/functions/nextStage.ts

@@ -13,6 +13,7 @@ import {
   calculateStageTypeRepentance,
   onRepentanceStage,
 } from "./stage";
+import { asNumber } from "./types";
 
 /**
  * Helper function to get the stage that a trapdoor or heaven door would take the player to, based
@@ -53,7 +54,7 @@ export function getNextStage(): LevelStage {
     case GridRoom.SECRET_EXIT: {
       if (repentanceStage) {
         // e.g. From Downpour 2 to Mines 1, etc.
-        return (stage as int) + 1;
+        return asNumber(stage) + 1;
       }
 
       if (stage === LevelStage.DEPTHS_2) {
@@ -109,7 +110,7 @@ export function getNextStage(): LevelStage {
   }
 
   // By default, go to the next floor.
-  return (stage as int) + 1;
+  return asNumber(stage) + 1;
 }
 
 function getNextStageBackwardsPath(
@@ -118,7 +119,7 @@ function getNextStageBackwardsPath(
 ): LevelStage {
   // If we have no stage history to work with, then default to the previous stage.
   if (!areFeaturesInitialized()) {
-    return (stage as int) - 1;
+    return asNumber(stage) - 1;
   }
 
   const visitedDownpour1 = hasVisitedStage(
@@ -234,7 +235,7 @@ function getNextStageBackwardsPath(
     return LevelStage.DEPTHS_1;
   }
 
-  return (stage as int) - 1;
+  return asNumber(stage) - 1;
 }
 
 /**
@@ -262,7 +263,7 @@ export function getNextStageType(upwards = false): StageType {
   }
 
   // Second, handle the special case of being in a specific off-grid room.
-  if (roomGridIndex === (GridRoom.SECRET_EXIT as int)) {
+  if (roomGridIndex === asNumber(GridRoom.SECRET_EXIT)) {
     return calculateStageTypeRepentance(nextStage);
   }
 

package/src/functions/npcs.ts

@@ -17,6 +17,7 @@ import {
 } from "isaac-typescript-definitions";
 import { EGGY_STATE_FRAME_OF_FINAL_SPIDER } from "../core/constants";
 import { getNPCs } from "./entitiesSpecific";
+import { asNumber } from "./types";
 
 /**
  * Used to filter out certain NPCs when determining of an NPC is "alive" and/or should keep the
@@ -125,7 +126,7 @@ export function isDaddyLongLegsChildStompEntity(npc: EntityNPC): boolean {
 export function isDyingEggyWithNoSpidersLeft(npc: EntityNPC): boolean {
   return (
     npc.Type === EntityType.HOPPER &&
-    npc.Variant === (HopperVariant.EGGY as int) &&
+    npc.Variant === asNumber(HopperVariant.EGGY) &&
     npc.State === NpcState.SUICIDE &&
     npc.StateFrame >= EGGY_STATE_FRAME_OF_FINAL_SPIDER
   );
@@ -140,7 +141,7 @@ export function isDyingEggyWithNoSpidersLeft(npc: EntityNPC): boolean {
 export function isRaglingDeathPatch(npc: EntityNPC): boolean {
   return (
     npc.Type === EntityType.RAGLING &&
-    npc.Variant === (RaglingVariant.RAG_MANS_RAGLING as int) &&
+    npc.Variant === asNumber(RaglingVariant.RAG_MANS_RAGLING) &&
     // They go to `STATE_SPECIAL` when they are patches on the ground.
     npc.State === NpcState.SPECIAL
   );

package/src/functions/pills.ts

@@ -30,6 +30,7 @@ import {
   PILL_EFFECT_TYPES,
 } from "../objects/pillEffectTypes";
 import { getEnumValues } from "./enums";
+import { asNumber, asPillColor } from "./types";
 import { irange } from "./utils";
 
 /**
@@ -55,7 +56,7 @@ export function getAllPillColors(): PillColor[] {
  * Helper function to get an array with every valid pill effect. This includes modded pill effects.
  */
 export function getAllPillEffects(): PillEffect[] {
-  return irange(FIRST_PILL_EFFECT, LAST_PILL_EFFECT) as PillEffect[];
+  return irange(FIRST_PILL_EFFECT, LAST_PILL_EFFECT);
 }
 
 /**
@@ -74,12 +75,12 @@ export function getFalsePHDPillEffect(pillEffect: PillEffect): PillEffect {
  * corresponds to the horse pill color for blue/blue.
  */
 export function getHorsePillColor(pillColor: PillColor): PillColor {
-  return pillColor + HORSE_PILL_ADJUSTMENT; // eslint-disable-line isaacscript/strict-enums
+  return asNumber(pillColor) + HORSE_PILL_ADJUSTMENT;
 }
 
 /** Helper function to get an array with every non-gold horse pill color. */
 export function getHorsePillColors(): PillColor[] {
-  return irange(FIRST_HORSE_PILL_COLOR, LAST_HORSE_PILL_COLOR) as PillColor[];
+  return irange(FIRST_HORSE_PILL_COLOR, LAST_HORSE_PILL_COLOR);
 }
 
 /**
@@ -92,7 +93,7 @@ export function getModdedPillEffects(): PillEffect[] {
     return [];
   }
 
-  return irange(FIRST_MODDED_PILL_EFFECT, LAST_PILL_EFFECT) as PillEffect[];
+  return irange(FIRST_MODDED_PILL_EFFECT, LAST_PILL_EFFECT);
 }
 
 /**
@@ -103,15 +104,16 @@ export function getModdedPillEffects(): PillEffect[] {
  * If called with a non-horse pill color, this function will return back the same color.
  */
 export function getNormalPillColorFromHorse(pillColor: PillColor): PillColor {
-  // eslint-disable-next-line isaacscript/strict-enums
-  const normalPillColor = (pillColor - HORSE_PILL_ADJUSTMENT) as PillColor;
+  const normalPillColor = asPillColor(
+    asNumber(pillColor) - HORSE_PILL_ADJUSTMENT,
+  );
 
   return normalPillColor > PillColor.NULL ? normalPillColor : pillColor;
 }
 
 /** Helper function to get an array with every non-gold and non-horse pill color. */
 export function getNormalPillColors(): PillColor[] {
-  return irange(FIRST_PILL_COLOR, LAST_NORMAL_PILL_COLOR) as PillColor[];
+  return irange(FIRST_PILL_COLOR, LAST_NORMAL_PILL_COLOR);
 }
 
 /**
@@ -197,9 +199,9 @@ export function getPillEffectType(
 
 /** Helper function to get an array with every vanilla pill effect. */
 export function getVanillaPillEffects(): PillEffect[] {
-  return irange(FIRST_PILL_EFFECT, LAST_VANILLA_PILL_EFFECT) as PillEffect[];
+  return irange(FIRST_PILL_EFFECT, LAST_VANILLA_PILL_EFFECT);
 }
 
 export function isHorsePill(pillColor: PillColor): boolean {
-  return pillColor > (HORSE_PILL_ADJUSTMENT as PillColor);
+  return asNumber(pillColor) > HORSE_PILL_ADJUSTMENT;
 }

package/src/functions/playerIndex.ts

@@ -96,9 +96,11 @@ export function getPlayerIndex(
   let playerToUse = player;
   const isSubPlayer = player.IsSubPlayer();
   if (isSubPlayer) {
+    const subPlayer = player as EntitySubPlayer;
+
     // The "getSubPlayerParent" function will return undefined in the situation where we are on Dead
     // Tainted Lazarus in the `POST_PLAYER_INIT` callback.
-    const playerParent = getSubPlayerParent(player as EntitySubPlayer);
+    const playerParent = getSubPlayerParent(subPlayer);
     if (playerParent !== undefined) {
       playerToUse = playerParent;
     }

package/src/functions/playerStats.ts

@@ -21,6 +21,5 @@ export function getPlayerStat<T extends StatType>(
     [StatType.TEAR_COLOR]: player.TearColor, // 1 << 6
     [StatType.FLYING]: player.CanFly, // 1 << 7
     [StatType.LUCK]: player.Luck, // 1 << 10
-    [StatType.SIZE]: player.SizeMulti, // 1 << 11
   }[statType];
 }

package/src/functions/players.ts

@@ -23,6 +23,7 @@ import { getCollectibleArray } from "./collectibleSet";
 import { getEnumValues } from "./enums";
 import { getPlayerIndexVanilla, getPlayers } from "./playerIndex";
 import { addTearsStat } from "./tears";
+import { isNumber } from "./types";
 import { repeat } from "./utils";
 
 const STAT_CACHE_FLAGS_SET: ReadonlySet<CacheFlag> = new Set([
@@ -225,16 +226,14 @@ export function getActiveItemSlot(
  * Helper function to get how long Azazel's Brimstone laser should be. You can pass either an
  * `EntityPlayer` object or a tear height stat.
  *
- * The formula for calculating it is: 32 - 2.5 * player.TearHeight
+ * The formula for calculating it is: 32 - 2.5 * tearHeight
  */
 export function getAzazelBrimstoneDistance(
   playerOrTearHeight: EntityPlayer | float,
 ): float {
-  let tearHeight = tonumber(playerOrTearHeight);
-  if (tearHeight === undefined) {
-    const player = playerOrTearHeight as EntityPlayer;
-    tearHeight = player.TearHeight;
-  }
+  const tearHeight = isNumber(playerOrTearHeight)
+    ? playerOrTearHeight
+    : playerOrTearHeight.TearHeight;
 
   return 32 - 2.5 * tearHeight;
 }

package/src/functions/pocketItems.ts

@@ -10,6 +10,7 @@ import { PocketItemType } from "../enums/PocketItemType";
 import { PocketItemDescription } from "../interfaces/PocketItemDescription";
 import { getEnumValues } from "./enums";
 import { isCharacter } from "./players";
+import { asNumber } from "./types";
 
 /**
  * Helper function to get the `PocketItemSlot` that the player's pocket active collectible item is
@@ -63,8 +64,8 @@ export function getPocketItems(player: EntityPlayer): PocketItemDescription[] {
   let pocketItemIdentified = false;
   let pocketItem2Identified = false;
   for (const slot of pocketItemSlots) {
-    const card = player.GetCard(slot as PocketItemSlot);
-    const pillColor = player.GetPill(slot as PocketItemSlot);
+    const card = player.GetCard(slot);
+    const pillColor = player.GetPill(slot);
 
     if (card !== Card.NULL) {
       pocketItems.push({
@@ -106,8 +107,7 @@ export function getPocketItems(player: EntityPlayer): PocketItemDescription[] {
       });
     }
 
-    // eslint-disable-next-line isaacscript/strict-enums
-    if (slot + 1 === maxPocketItems) {
+    if (asNumber(slot) + 1 === maxPocketItems) {
       break;
     }
   }

package/src/functions/rng.ts

@@ -41,11 +41,14 @@ export function deserializeRNG(rng: SerializedRNG): RNG {
     );
   }
 
-  const [seed] = getNumbersFromTable(
-    rng as LuaMap<string, unknown>,
-    OBJECT_NAME,
-    ...KEYS,
-  );
+  const [seed] = getNumbersFromTable(rng, OBJECT_NAME, ...KEYS);
+
+  if (seed === undefined) {
+    error(
+      `Failed to deserialize a ${OBJECT_NAME} object since the provided object did not have a value for: seed`,
+    );
+  }
+
   return newRNG(seed as Seed);
 }