isaacscript-common 39.4.1 → 39.4.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "isaacscript-common",
-  "version": "39.4.1",
+  "version": "39.4.3",
   "description": "Helper functions and features for IsaacScript mods.",
   "keywords": [
     "isaac",
@@ -25,6 +25,6 @@
   "main": "dist/src/index",
   "types": "dist/index.rollup.d.ts",
   "dependencies": {
-    "isaac-typescript-definitions": "^17.0.2"
+    "isaac-typescript-definitions": "^17.0.3"
   }
 }

package/src/classes/callbacks/InputActionFilter.ts

@@ -20,7 +20,7 @@ export class InputActionFilter extends CustomCallback<T> {
     fireArgs: FireArgs<T>,
     optionalArgs: OptionalArgs<T>,
   ): boolean => {
-    const [_, inputHook, buttonAction] = fireArgs;
+    const [_entity, inputHook, buttonAction] = fireArgs;
     const [callbackInputHook, callbackButtonAction] = optionalArgs;
 
     return (

package/src/classes/private/CustomCallback.ts

@@ -75,8 +75,19 @@ export abstract class CustomCallback<
       const { callbackFunc, optionalArgs } = subscription;
 
       if (this.shouldFire(fireArgs, optionalArgs)) {
-        // TypeScript is not smart enough to know that the arguments match the function.
-        const value = (callbackFunc as AnyFunction)(...fireArgs);
+        // - TypeScript is not smart enough to know that the arguments match the function, so we
+        //   must cast it to `AnyFunction`.
+        // - We cannot use `...fireArgs` here because it would fail to pass any arguments that exist
+        //   beyond `nil` elements.
+        const value = (callbackFunc as AnyFunction)(
+          fireArgs[0],
+          fireArgs[1],
+          fireArgs[2],
+          fireArgs[3],
+          fireArgs[4],
+          fireArgs[5],
+          fireArgs[6],
+        );
         if (value !== undefined) {
           return value as ReturnType<AddCallbackParametersCustom[T][0]>;
         }