isaacscript-common 30.12.3 → 30.12.5

package/src/classes/features/callbackLogic/SlotDestroyedDetection.ts

@@ -20,9 +20,9 @@ import { ISCFeature } from "../../../enums/ISCFeature";
 import { ModCallbackCustom } from "../../../enums/ModCallbackCustom";
 import { SlotDestructionType } from "../../../enums/SlotDestructionType";
 import { isSlotMachine } from "../../../functions/slots";
-import { PostSlotDestroyed } from "../../callbacks/PostSlotDestroyed";
+import type { PostSlotDestroyed } from "../../callbacks/PostSlotDestroyed";
 import { Feature } from "../../private/Feature";
-import { RoomHistory } from "../other/RoomHistory";
+import type { RoomHistory } from "../other/RoomHistory";
 
 const v = {
   room: {
@@ -33,8 +33,8 @@ const v = {
 export class SlotDestroyedDetection extends Feature {
   public override v = v;
 
-  private postSlotDestroyed: PostSlotDestroyed;
-  private roomHistory: RoomHistory;
+  private readonly postSlotDestroyed: PostSlotDestroyed;
+  private readonly roomHistory: RoomHistory;
 
   constructor(postSlotDestroyed: PostSlotDestroyed, roomHistory: RoomHistory) {
     super();
@@ -60,7 +60,7 @@ export class SlotDestroyedDetection extends Feature {
 
   // ModCallback.POST_ENTITY_REMOVE (67)
   // EntityType.SLOT (6)
-  private postEntityRemoveSlot = (entity: Entity) => {
+  private readonly postEntityRemoveSlot = (entity: Entity) => {
     const slot = entity as EntitySlot;
 
     // The `POST_ENTITY_REMOVE` callback will fire for slots that are naturally despawning as a
@@ -91,7 +91,7 @@ export class SlotDestroyedDetection extends Feature {
   }
 
   // ModCallbackCustom.POST_SLOT_UPDATE
-  private postSlotUpdate = (slot: EntitySlot) => {
+  private readonly postSlotUpdate = (slot: EntitySlot) => {
     const ptrHash = GetPtrHash(slot);
 
     const alreadyDestroyed = v.room.destroyedSlotSet.has(ptrHash);

package/src/classes/features/callbackLogic/SlotRenderDetection.ts

@@ -1,8 +1,8 @@
 import { ModCallback } from "isaac-typescript-definitions";
 import { getSlots } from "../../../functions/entitiesSpecific";
 import { DefaultMap } from "../../DefaultMap";
-import { PostSlotAnimationChanged } from "../../callbacks/PostSlotAnimationChanged";
-import { PostSlotRender } from "../../callbacks/PostSlotRender";
+import type { PostSlotAnimationChanged } from "../../callbacks/PostSlotAnimationChanged";
+import type { PostSlotRender } from "../../callbacks/PostSlotRender";
 import { Feature } from "../../private/Feature";
 
 const v = {
@@ -20,8 +20,8 @@ const v = {
 export class SlotRenderDetection extends Feature {
   public override v = v;
 
-  private postSlotRender: PostSlotRender;
-  private postSlotAnimationChanged: PostSlotAnimationChanged;
+  private readonly postSlotRender: PostSlotRender;
+  private readonly postSlotAnimationChanged: PostSlotAnimationChanged;
 
   constructor(
     postSlotRender: PostSlotRender,
@@ -39,7 +39,7 @@ export class SlotRenderDetection extends Feature {
   }
 
   // ModCallback.POST_RENDER (2)
-  private postRender = () => {
+  private readonly postRender = () => {
     for (const slot of getSlots()) {
       this.postSlotRender.fire(slot);
       this.checkSlotAnimationChanged(slot);

package/src/classes/features/callbackLogic/SlotUpdateDetection.ts

@@ -1,8 +1,8 @@
 import { ModCallback } from "isaac-typescript-definitions";
 import { ModCallbackCustom } from "../../../enums/ModCallbackCustom";
 import { getSlots } from "../../../functions/entitiesSpecific";
-import { PostSlotInit } from "../../callbacks/PostSlotInit";
-import { PostSlotUpdate } from "../../callbacks/PostSlotUpdate";
+import type { PostSlotInit } from "../../callbacks/PostSlotInit";
+import type { PostSlotUpdate } from "../../callbacks/PostSlotUpdate";
 import { Feature } from "../../private/Feature";
 
 const v = {
@@ -14,8 +14,8 @@ const v = {
 export class SlotUpdateDetection extends Feature {
   public override v = v;
 
-  private postSlotInit: PostSlotInit;
-  private postSlotUpdate: PostSlotUpdate;
+  private readonly postSlotInit: PostSlotInit;
+  private readonly postSlotUpdate: PostSlotUpdate;
 
   constructor(postSlotInit: PostSlotInit, postSlotUpdate: PostSlotUpdate) {
     super();
@@ -36,7 +36,7 @@ export class SlotUpdateDetection extends Feature {
   }
 
   // ModCallback.POST_UPDATE (1)
-  private postUpdate = () => {
+  private readonly postUpdate = () => {
     for (const slot of getSlots()) {
       this.checkNewEntity(slot);
       this.postSlotUpdate.fire(slot);
@@ -44,7 +44,7 @@ export class SlotUpdateDetection extends Feature {
   };
 
   // ModCallbackCustom.POST_NEW_ROOM_REORDERED
-  private postNewRoomReordered = () => {
+  private readonly postNewRoomReordered = () => {
     for (const slot of getSlots()) {
       this.checkNewEntity(slot);
     }

package/src/classes/features/other/CharacterHealthConversion.ts

@@ -1,17 +1,17 @@
+import type { PlayerType } from "isaac-typescript-definitions";
 import {
   HeartSubType,
   ModCallback,
   PickupVariant,
-  PlayerType,
 } from "isaac-typescript-definitions";
 import { Exported } from "../../../decorators";
 import { ModCallbackCustom } from "../../../enums/ModCallbackCustom";
 import { isRedHeart } from "../../../functions/pickups";
-import { ConversionHeartSubType } from "../../../types/ConversionHeartSubType";
+import type { ConversionHeartSubType } from "../../../types/ConversionHeartSubType";
 import { Feature } from "../../private/Feature";
 
 export class CharacterHealthConversion extends Feature {
-  private characterHealthReplacementMap = new Map<
+  private readonly characterHealthReplacementMap = new Map<
     PlayerType,
     ConversionHeartSubType
   >();
@@ -39,7 +39,7 @@ export class CharacterHealthConversion extends Feature {
 
   // ModCallback.PRE_PICKUP_COLLISION (38)
   // PickupVariant.HEART (10)
-  private prePickupCollisionHeart = (
+  private readonly prePickupCollisionHeart = (
     pickup: EntityPickup,
     collider: Entity,
   ) => {
@@ -65,7 +65,7 @@ export class CharacterHealthConversion extends Feature {
   };
 
   // ModCallbackCustom.POST_PEFFECT_UPDATE_REORDERED
-  private postPEffectUpdateReordered = (player: EntityPlayer) => {
+  private readonly postPEffectUpdateReordered = (player: EntityPlayer) => {
     const character = player.GetPlayerType();
     const conversionHeartSubType =
       this.characterHealthReplacementMap.get(character);

package/src/classes/features/other/CharacterStats.ts

@@ -1,8 +1,5 @@
-import {
-  CacheFlag,
-  ModCallback,
-  PlayerType,
-} from "isaac-typescript-definitions";
+import type { CacheFlag, PlayerType } from "isaac-typescript-definitions";
+import { ModCallback } from "isaac-typescript-definitions";
 import { Exported } from "../../../decorators";
 import { addStat, getDefaultPlayerStat } from "../../../functions/stats";
 import { Feature } from "../../private/Feature";
@@ -11,7 +8,7 @@ type StatMap = Map<CacheFlag, number> | ReadonlyMap<CacheFlag, number>;
 
 /** Easily create custom characters that have base stats different from that of Isaac. */
 export class CharacterStats extends Feature {
-  private charactersStatMap = new Map<PlayerType, StatMap>();
+  private readonly charactersStatMap = new Map<PlayerType, StatMap>();
 
   /** @internal */
   constructor() {
@@ -24,7 +21,10 @@ export class CharacterStats extends Feature {
   }
 
   // ModCallback.EVALUATE_CACHE (8)
-  private evaluateCache = (player: EntityPlayer, cacheFlag: CacheFlag) => {
+  private readonly evaluateCache = (
+    player: EntityPlayer,
+    cacheFlag: CacheFlag,
+  ) => {
     const character = player.GetPlayerType();
     const statMap = this.charactersStatMap.get(character);
     if (statMap === undefined) {

package/src/classes/features/other/CollectibleItemPoolType.ts

@@ -1,17 +1,14 @@
-import {
-  ItemPoolType,
-  ModCallback,
-  PickupVariant,
-} from "isaac-typescript-definitions";
+import type { ItemPoolType } from "isaac-typescript-definitions";
+import { ModCallback, PickupVariant } from "isaac-typescript-definitions";
 import { game } from "../../../core/cachedClasses";
 import { Exported } from "../../../decorators";
 import { ISCFeature } from "../../../enums/ISCFeature";
 import { getEntityID } from "../../../functions/entities";
 import { isCollectible } from "../../../functions/pickupVariants";
 import { getRoomItemPoolType } from "../../../functions/rooms";
-import { PickupIndex } from "../../../types/PickupIndex";
+import type { PickupIndex } from "../../../types/PickupIndex";
 import { Feature } from "../../private/Feature";
-import { PickupIndexCreation } from "./PickupIndexCreation";
+import type { PickupIndexCreation } from "./PickupIndexCreation";
 
 const v = {
   run: {
@@ -23,7 +20,7 @@ export class CollectibleItemPoolType extends Feature {
   /** @internal */
   public override v = v;
 
-  private pickupIndexCreation: PickupIndexCreation;
+  private readonly pickupIndexCreation: PickupIndexCreation;
 
   /** @internal */
   constructor(pickupIndexCreation: PickupIndexCreation) {
@@ -45,7 +42,7 @@ export class CollectibleItemPoolType extends Feature {
 
   // ModCallback.POST_PICKUP_INIT (34)
   // PickupVariant.COLLECTIBLE (100)
-  private postPickupInitCollectible = (collectible: EntityPickup) => {
+  private readonly postPickupInitCollectible = (collectible: EntityPickup) => {
     const pickupIndex = this.pickupIndexCreation.getPickupIndex(collectible);
 
     if (!v.run.collectibleItemPoolTypeMap.has(pickupIndex)) {
@@ -76,6 +73,6 @@ export class CollectibleItemPoolType extends Feature {
 
     const pickupIndex = this.pickupIndexCreation.getPickupIndex(collectible);
     const itemPoolType = v.run.collectibleItemPoolTypeMap.get(pickupIndex);
-    return itemPoolType === undefined ? getRoomItemPoolType() : itemPoolType;
+    return itemPoolType ?? getRoomItemPoolType();
   }
 }

package/src/classes/features/other/CustomHotkeys.ts

@@ -9,18 +9,18 @@ export class CustomHotkeys extends Feature {
    * The keys are the keyboard keys that trigger the hotkey. The values are the functions that
    * contain the arbitrary code to run.
    */
-  private staticHotkeyFunctionMap = new Map<Keyboard, () => void>();
+  private readonly staticHotkeyFunctionMap = new Map<Keyboard, () => void>();
 
   /**
    * The keys are the functions that determine what the hotkey key is. The values are the functions
    * that contain the arbitrary code to run.
    */
-  private dynamicHotkeyFunctionMap = new Map<
+  private readonly dynamicHotkeyFunctionMap = new Map<
     () => Keyboard | undefined,
     () => void
   >();
 
-  private keyPressedMap = new DefaultMap<Keyboard, boolean>(false);
+  private readonly keyPressedMap = new DefaultMap<Keyboard, boolean>(false);
 
   /** @internal */
   constructor() {
@@ -33,7 +33,7 @@ export class CustomHotkeys extends Feature {
   }
 
   // ModCallback.POST_RENDER (2)
-  private postRender = () => {
+  private readonly postRender = () => {
     for (const [keyboard, triggerFunc] of this.staticHotkeyFunctionMap) {
       this.checkIfTriggered(keyboard, triggerFunc);
     }

package/src/classes/features/other/CustomItemPools.ts

@@ -1,11 +1,12 @@
-import { CollectibleType, ItemPoolType } from "isaac-typescript-definitions";
+import type { ItemPoolType } from "isaac-typescript-definitions";
+import { CollectibleType } from "isaac-typescript-definitions";
 import { Exported } from "../../../decorators";
 import { ModCallbackCustom } from "../../../enums/ModCallbackCustom";
 import { arrayRemoveIndexInPlace } from "../../../functions/array";
 import { copyMap } from "../../../functions/map";
 import { getRandomSeed } from "../../../functions/rng";
 import { getRandomIndexFromWeightedArray } from "../../../functions/weighted";
-import { WeightedArray } from "../../../types/WeightedArray";
+import type { WeightedArray } from "../../../types/WeightedArray";
 import { Feature } from "../../private/Feature";
 
 const v = {
@@ -38,7 +39,7 @@ export class CustomItemPools extends Feature {
 
   // ModCallbackCustom.POST_GAME_STARTED_REORDERED
   // false
-  private postGameStartedReorderedFalse = () => {
+  private readonly postGameStartedReorderedFalse = () => {
     v.run.customItemPools = copyMap(customItemPoolMap);
   };
 

package/src/classes/features/other/CustomPickups.ts

@@ -1,8 +1,8 @@
+import type { PickupVariant } from "isaac-typescript-definitions";
 import {
   EffectVariant,
   EntityType,
   ModCallback,
-  PickupVariant,
 } from "isaac-typescript-definitions";
 import { Exported } from "../../../decorators";
 import { LadderSubTypeCustom } from "../../../enums/LadderSubTypeCustom";
@@ -32,7 +32,10 @@ const PICKUP_EFFECT_SUB_TYPE = LadderSubTypeCustom.CUSTOM_PICKUP;
 
 export class CustomPickups extends Feature {
   /** Indexed by entity ID. */
-  private customPickupFunctionsMap = new Map<string, CustomPickupFunctions>();
+  private readonly customPickupFunctionsMap = new Map<
+    string,
+    CustomPickupFunctions
+  >();
 
   /** @internal */
   constructor() {
@@ -52,7 +55,7 @@ export class CustomPickups extends Feature {
   }
 
   // ModCallback.PRE_PICKUP_COLLISION (38)
-  private prePickupCollision = (
+  private readonly prePickupCollision = (
     pickup: EntityPickup,
     collider: Entity,
   ): boolean | undefined => {
@@ -93,7 +96,7 @@ export class CustomPickups extends Feature {
 
   // ModCallback.POST_EFFECT_RENDER (56)
   // PICKUP_EFFECT_VARIANT
-  private postEffectRenderPickupEffect = (effect: EntityEffect) => {
+  private readonly postEffectRenderPickupEffect = (effect: EntityEffect) => {
     if (effect.SubType !== asNumber(PICKUP_EFFECT_SUB_TYPE)) {
       return;
     }

package/src/classes/features/other/CustomStages.ts

@@ -1,10 +1,9 @@
+import type { DoorSlotFlag, Music } from "isaac-typescript-definitions";
 import {
-  DoorSlotFlag,
   GridEntityType,
   LevelCurse,
   LevelStage,
   ModCallback,
-  Music,
   RoomShape,
   RoomType,
   StageType,
@@ -31,21 +30,21 @@ import {
 import { getMusicForStage } from "../../../functions/sound";
 import { setStage } from "../../../functions/stage";
 import { asNumber } from "../../../functions/types";
-import {
+import type {
   CustomStageLua,
   CustomStageRoomMetadata,
 } from "../../../interfaces/CustomStageTSConfig";
-import {
+import type {
   CustomStage,
   RoomTypeMap,
 } from "../../../interfaces/private/CustomStage";
 import { Feature } from "../../private/Feature";
-import { CustomGridEntities } from "../callbackLogic/CustomGridEntities";
-import { GameReorderedCallbacks } from "../callbackLogic/GameReorderedCallbacks";
-import { CustomTrapdoors } from "./CustomTrapdoors";
-import { DisableAllSound } from "./DisableAllSound";
-import { Pause } from "./Pause";
-import { RunInNFrames } from "./RunInNFrames";
+import type { CustomGridEntities } from "../callbackLogic/CustomGridEntities";
+import type { GameReorderedCallbacks } from "../callbackLogic/GameReorderedCallbacks";
+import type { CustomTrapdoors } from "./CustomTrapdoors";
+import type { DisableAllSound } from "./DisableAllSound";
+import type { Pause } from "./Pause";
+import type { RunInNFrames } from "./RunInNFrames";
 import { setCustomStageBackdrop } from "./customStages/backdrop";
 import {
   CUSTOM_FLOOR_STAGE,
@@ -87,17 +86,17 @@ export class CustomStages extends Feature {
   public override v = v;
 
   /** Indexed by custom stage name. */
-  private customStagesMap = new Map<string, CustomStage>();
+  private readonly customStagesMap = new Map<string, CustomStage>();
 
   /** Indexed by room variant. */
-  private customStageCachedRoomData = new Map<int, RoomConfig>();
+  private readonly customStageCachedRoomData = new Map<int, RoomConfig>();
 
-  private customGridEntities: CustomGridEntities;
-  private customTrapdoors: CustomTrapdoors;
-  private disableAllSound: DisableAllSound;
-  private gameReorderedCallbacks: GameReorderedCallbacks;
-  private pause: Pause;
-  private runInNFrames: RunInNFrames;
+  private readonly customGridEntities: CustomGridEntities;
+  private readonly customTrapdoors: CustomTrapdoors;
+  private readonly disableAllSound: DisableAllSound;
+  private readonly gameReorderedCallbacks: GameReorderedCallbacks;
+  private readonly pause: Pause;
+  private readonly runInNFrames: RunInNFrames;
 
   /** @internal */
   constructor(
@@ -180,7 +179,7 @@ export class CustomStages extends Feature {
     );
   }
 
-  private goToCustomStage = (
+  private readonly goToCustomStage = (
     destinationName: string | undefined,
     destinationStage: LevelStage,
     _destinationStageType: StageType,
@@ -196,7 +195,7 @@ export class CustomStages extends Feature {
   };
 
   // ModCallback.POST_RENDER (2)
-  private postRender = () => {
+  private readonly postRender = () => {
     const customStage = v.run.currentCustomStage;
     if (customStage === null) {
       return;
@@ -218,7 +217,7 @@ export class CustomStages extends Feature {
   };
 
   // ModCallback.POST_CURSE_EVAL (12)
-  private postCurseEval = (
+  private readonly postCurseEval = (
     curses: BitFlags<LevelCurse>,
   ): BitFlags<LevelCurse> | undefined => {
     const customStage = v.run.currentCustomStage;
@@ -235,7 +234,7 @@ export class CustomStages extends Feature {
   };
 
   // ModCallback.GET_SHADER_PARAMS (22)
-  private getShaderParams = (
+  private readonly getShaderParams = (
     shaderName: string,
   ): Record<string, unknown> | undefined => {
     const customStage = v.run.currentCustomStage;
@@ -249,7 +248,7 @@ export class CustomStages extends Feature {
 
   // ModCallbackCustom.POST_GRID_ENTITY_BROKEN
   // GridEntityType.ROCK_ALT
-  private postGridEntityBrokenRockAlt = (gridEntity: GridEntity) => {
+  private readonly postGridEntityBrokenRockAlt = (gridEntity: GridEntity) => {
     const customStage = v.run.currentCustomStage;
     if (customStage === null) {
       return;
@@ -267,7 +266,7 @@ export class CustomStages extends Feature {
   };
 
   // ModCallbackCustom.POST_GRID_ENTITY_INIT
-  private postGridEntityInit = (gridEntity: GridEntity) => {
+  private readonly postGridEntityInit = (gridEntity: GridEntity) => {
     const customStage = v.run.currentCustomStage;
     if (customStage === null) {
       return;
@@ -291,7 +290,7 @@ export class CustomStages extends Feature {
   };
 
   // ModCallbackCustom.POST_NEW_ROOM_REORDERED
-  private postNewRoomReordered = () => {
+  private readonly postNewRoomReordered = () => {
     const customStage = v.run.currentCustomStage;
     if (customStage === null) {
       return;
@@ -473,7 +472,7 @@ export class CustomStages extends Feature {
         ? DEFAULT_BASE_STAGE_TYPE
         : (customStage.baseStageType as StageType);
 
-    // eslint-disable-next-line isaacscript/strict-enums
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
     const reseed = asNumber(stage) >= baseStage;
 
     setStage(baseStage, baseStageType, reseed);

package/src/classes/features/other/CustomTrapdoors.ts

@@ -38,17 +38,17 @@ import { teleport } from "../../../functions/roomTransition";
 import { setStage } from "../../../functions/stage";
 import { getTSTLClassName } from "../../../functions/tstlClass";
 import { isVector } from "../../../functions/vector";
-import { CustomTrapdoorDescription } from "../../../interfaces/private/CustomTrapdoorDescription";
+import type { CustomTrapdoorDescription } from "../../../interfaces/private/CustomTrapdoorDescription";
 import { ReadonlySet } from "../../../types/ReadonlySet";
 import { DefaultMap } from "../../DefaultMap";
 import { Feature } from "../../private/Feature";
-import { CustomGridEntities } from "../callbackLogic/CustomGridEntities";
-import { DisableInputs } from "./DisableInputs";
-import { PonyDetection } from "./PonyDetection";
-import { RoomClearFrame } from "./RoomClearFrame";
-import { RunInNFrames } from "./RunInNFrames";
-import { RunNextRoom } from "./RunNextRoom";
-import { StageHistory } from "./StageHistory";
+import type { CustomGridEntities } from "../callbackLogic/CustomGridEntities";
+import type { DisableInputs } from "./DisableInputs";
+import type { PonyDetection } from "./PonyDetection";
+import type { RoomClearFrame } from "./RoomClearFrame";
+import type { RunInNFrames } from "./RunInNFrames";
+import type { RunNextRoom } from "./RunNextRoom";
+import type { StageHistory } from "./StageHistory";
 import { CUSTOM_FLOOR_STAGE } from "./customStages/constants";
 
 const DEBUG = false as boolean;
@@ -93,7 +93,7 @@ const v = {
 
 export class CustomTrapdoors extends Feature {
   /** Indexed by custom trapdoor ID. */
-  private destinationFuncMap = new Map<
+  private readonly destinationFuncMap = new Map<
     string,
     (
       destinationName: string | undefined,
@@ -111,15 +111,15 @@ export class CustomTrapdoors extends Feature {
    * replace the vanilla files. (For some reason, loading the sprites will cause the overwrite to no
    * longer apply on the second and subsequent runs.)
    */
-  private blackSprite = Sprite();
+  private readonly blackSprite = Sprite();
 
-  private customGridEntities: CustomGridEntities;
-  private disableInputs: DisableInputs;
-  private ponyDetection: PonyDetection;
-  private roomClearFrame: RoomClearFrame;
-  private runInNFrames: RunInNFrames;
-  private runNextRoom: RunNextRoom;
-  private stageHistory: StageHistory;
+  private readonly customGridEntities: CustomGridEntities;
+  private readonly disableInputs: DisableInputs;
+  private readonly ponyDetection: PonyDetection;
+  private readonly roomClearFrame: RoomClearFrame;
+  private readonly runInNFrames: RunInNFrames;
+  private readonly runNextRoom: RunNextRoom;
+  private readonly stageHistory: StageHistory;
 
   /** @internal */
   constructor(
@@ -170,7 +170,7 @@ export class CustomTrapdoors extends Feature {
   }
 
   // ModCallback.POST_RENDER (2)
-  private postRender = () => {
+  private readonly postRender = () => {
     this.checkAllPlayersJumpComplete();
     this.checkPixelationToBlackComplete();
     this.checkSecondPixelationHalfWay();
@@ -394,7 +394,9 @@ export class CustomTrapdoors extends Feature {
 
   // ModCallbackCustom.POST_GRID_ENTITY_CUSTOM_UPDATE
   // GridEntityTypeCustom.TRAPDOOR_CUSTOM
-  private postGridEntityCustomUpdateTrapdoor = (gridEntity: GridEntity) => {
+  private readonly postGridEntityCustomUpdateTrapdoor = (
+    gridEntity: GridEntity,
+  ) => {
     const roomListIndex = getRoomListIndex();
     const gridIndex = gridEntity.GetGridIndex();
 
@@ -521,14 +523,14 @@ export class CustomTrapdoors extends Feature {
     player.PlayExtraAnimation("Trapdoor");
 
     const otherPlayers = getOtherPlayers(player);
-    otherPlayers.forEach((otherPlayer, i) => {
+    for (const [i, otherPlayer] of otherPlayers.entries()) {
       const gameFramesToWaitBeforeJumping =
         OTHER_PLAYER_TRAPDOOR_JUMP_DELAY_GAME_FRAMES * (i + 1);
       const otherPlayerPtr = EntityPtr(otherPlayer);
       this.runInNFrames.runInNGameFrames(() => {
         this.startDelayedJump(otherPlayerPtr, gridEntity.Position);
       }, gameFramesToWaitBeforeJumping);
-    });
+    }
   }
 
   private startDelayedJump(entityPtr: EntityPtr, trapdoorPosition: Vector) {
@@ -602,7 +604,7 @@ export class CustomTrapdoors extends Feature {
   }
 
   // ModCallbackCustom.POST_PEFFECT_UPDATE_REORDERED
-  private postPEffectUpdateReordered = (player: EntityPlayer) => {
+  private readonly postPEffectUpdateReordered = (player: EntityPlayer) => {
     this.checkJumpComplete(player);
   };
 
@@ -777,9 +779,7 @@ export class CustomTrapdoors extends Feature {
 
     const firstSpawn = roomFrameCount !== 0;
     const open =
-      spawnOpen === undefined
-        ? this.shouldTrapdoorSpawnOpen(gridEntity, firstSpawn)
-        : spawnOpen;
+      spawnOpen ?? this.shouldTrapdoorSpawnOpen(gridEntity, firstSpawn);
 
     const roomTrapdoorMap = v.level.trapdoors.getAndSetDefault(roomListIndex);
     const customTrapdoorDescription: CustomTrapdoorDescription = {

package/src/classes/features/other/DebugDisplay.ts

@@ -1,6 +1,6 @@
 import { Exported } from "../../../decorators";
 import { printEnabled } from "../../../functions/console";
-import { ModUpgradedInterface } from "../../../interfaces/private/ModUpgradedInterface";
+import type { ModUpgradedInterface } from "../../../interfaces/private/ModUpgradedInterface";
 import { Feature } from "../../private/Feature";
 import { DebugDisplayBomb } from "./debugDisplay/DebugDisplayBomb";
 import { DebugDisplayDoor } from "./debugDisplay/DebugDisplayDoor";
@@ -22,27 +22,27 @@ import { DebugDisplayTear } from "./debugDisplay/DebugDisplayTear";
 import { DebugDisplayTNT } from "./debugDisplay/DebugDisplayTNT";
 
 export class DebugDisplay extends Feature {
-  private mod: ModUpgradedInterface;
-
-  private player = new DebugDisplayPlayer(); // 1
-  private tear = new DebugDisplayTear(); // 2
-  private familiar = new DebugDisplayFamiliar(); // 3
-  private bomb = new DebugDisplayBomb(); // 4
-  private pickup = new DebugDisplayPickup(); // 5
-  private slot = new DebugDisplaySlot(); // 6
-  private laser = new DebugDisplayLaser(); // 7
-  private knife = new DebugDisplayKnife(); // 8
-  private projectile = new DebugDisplayProjectile(); // 9
-  private effect = new DebugDisplayEffect(); // 1000
-  private npc = new DebugDisplayNPC();
-
-  private rock = new DebugDisplayRock(); // 2, 3, 4, 5, 6, 22, 24, 25, 26, 27
-  private pit = new DebugDisplayPit(); // 7
-  private spikes = new DebugDisplaySpikes(); // 8, 9
-  private tnt = new DebugDisplayTNT(); // 12
-  private poop = new DebugDisplayPoop(); // 14
-  private door = new DebugDisplayDoor(); // 16
-  private pressurePlate = new DebugDisplayPressurePlate(); // 20
+  private readonly mod: ModUpgradedInterface;
+
+  private readonly player = new DebugDisplayPlayer(); // 1
+  private readonly tear = new DebugDisplayTear(); // 2
+  private readonly familiar = new DebugDisplayFamiliar(); // 3
+  private readonly bomb = new DebugDisplayBomb(); // 4
+  private readonly pickup = new DebugDisplayPickup(); // 5
+  private readonly slot = new DebugDisplaySlot(); // 6
+  private readonly laser = new DebugDisplayLaser(); // 7
+  private readonly knife = new DebugDisplayKnife(); // 8
+  private readonly projectile = new DebugDisplayProjectile(); // 9
+  private readonly effect = new DebugDisplayEffect(); // 1000
+  private readonly npc = new DebugDisplayNPC();
+
+  private readonly rock = new DebugDisplayRock(); // 2, 3, 4, 5, 6, 22, 24, 25, 26, 27
+  private readonly pit = new DebugDisplayPit(); // 7
+  private readonly spikes = new DebugDisplaySpikes(); // 8, 9
+  private readonly tnt = new DebugDisplayTNT(); // 12
+  private readonly poop = new DebugDisplayPoop(); // 14
+  private readonly door = new DebugDisplayDoor(); // 16
+  private readonly pressurePlate = new DebugDisplayPressurePlate(); // 20
 
   /** @internal */
   constructor(mod: ModUpgradedInterface) {