iotagent-node-lib 4.9.0 → 4.10.0

package/lib/services/devices/deviceRegistryMongoDB.js

@@ -59,7 +59,9 @@ const attributeList = [
     'subscriptions',
     'payloadType',
     'useCBflowControl',
-    'storeLastMeasure'
+    'storeLastMeasure',
+    'cmdMode',
+    'subscriptionId'
 ];
 
 /**
@@ -324,6 +326,8 @@ function update(previousDevice, device, callback) {
             data.useCBflowControl = device.useCBflowControl;
             data.storeLastMeasure = device.storeLastMeasure;
             data.lastMeasure = device.lastMeasure;
+            data.cmdMode = device.cmdMode;
+            data.subscriptionId = device.subscriptionId;
 
             /* eslint-disable-next-line  new-cap */
             const deviceObj = new Device.model(data);

package/lib/services/devices/deviceService.js

@@ -66,6 +66,17 @@ function init() {
     }
 }
 
+/**
+ * Creates the initial entity representing the device in the Context Broker. This is important mainly to allow the
+ * rest of the updateContext operations to be performed using an UPDATE action instead of an APPEND one.
+ *
+ * @param {Object} deviceData       Object containing all the deviceData needed to send the registration.
+ * @param {Object} newDevice        Device object that will be stored in the database.
+ */
+function createInitialEntity(deviceData, newDevice, callback) {
+    deviceHandler.createInitialEntity(deviceData, newDevice, callback);
+}
+
 /**
  * If the object_id or the name of the attribute is missing, complete it with the other piece of data.
  *
@@ -187,6 +198,9 @@ function mergeDeviceWithConfiguration(fields, defaults, deviceData, configuratio
     if (configuration && configuration.storeLastMeasure !== undefined && deviceData.storeLastMeasure === undefined) {
         deviceData.storeLastMeasure = configuration.storeLastMeasure;
     }
+    if (configuration && configuration.cmdMode !== undefined && deviceData.cmdMode === undefined) {
+        deviceData.cmdMode = configuration.cmdMode;
+    }
     logger.debug(context, 'deviceData after merge with conf: %j', deviceData);
     callback(null, deviceData);
 }
@@ -361,13 +375,15 @@ function registerDevice(deviceObj, callback) {
         async.waterfall(
             [
                 apply(registrationUtils.sendRegistrations, false, deviceData),
-                apply(registrationUtils.processContextRegistration, deviceData)
+                apply(registrationUtils.processContextRegistration, deviceData),
+                apply(createInitialEntity, deviceData)
             ],
             function (error, results) {
                 if (error) {
                     callback(error);
                 } else {
                     deviceObj.registrationId = results.registrationId;
+                    deviceObj.subscriptionId = results.subscriptionId;
                     deviceObj.name = deviceData.name;
                     deviceObj.service = deviceData.service;
                     deviceObj.subservice = deviceData.subservice;

package/lib/services/devices/devices-NGSI-LD.js

@@ -106,7 +106,7 @@ function updateEntityHandlerNgsiLD(deviceData, updatedDevice, callback) {
  * @param {Object} deviceData       Object containing all the deviceData needed to send the registration.
  * @param {Object} newDevice        Device object that will be stored in the database.
  */
-function createInitialEntityNgsiLDFake(deviceData, newDevice, callback) {
+function createInitialEntityNgsiLD(deviceData, newDevice, callback) {
     callback(null, newDevice);
 }
 
@@ -284,7 +284,7 @@ function updateRegisterDeviceNgsiLD(deviceObj, previousDevice, entityInfoUpdated
                     deviceObj.subservice
                 ),
                 apply(extractDeviceDifference, deviceObj),
-                createInitialEntityNgsiLDFake,
+                createInitialEntityNgsiLD,
                 apply(combineWithNewDevice, deviceObj),
                 apply(registrationUtils.sendRegistrations, false),
                 apply(registrationUtils.processContextRegistration, deviceObj),
@@ -314,4 +314,5 @@ function updateRegisterDeviceNgsiLD(deviceObj, previousDevice, entityInfoUpdated
     }
 }
 
+exports.createInitialEntity = createInitialEntityNgsiLD;
 exports.updateRegisterDevice = updateRegisterDeviceNgsiLD;

package/lib/services/devices/devices-NGSI-mixed.js

@@ -27,6 +27,21 @@ const config = require('../../commonConfig');
 const deviceHandlerLD = require('./devices-NGSI-LD');
 const deviceHandlerV2 = require('./devices-NGSI-v2');
 
+/**
+ * Creates the initial entity representing the device in the Context Broker using both NGSI-LD and NGSI-v2
+ * This is important mainly to allow the rest of the updateContext operations to be performed.
+ *
+ * @param {Object} deviceData       Object containing all the deviceData needed to send the registration.
+ * @param {Object} newDevice        Device object that will be stored in the database.
+ */
+function createInitialEntityNgsiMixed(deviceData, newDevice, callback) {
+    if (config.checkNgsiLD(deviceData)) {
+        deviceHandlerLD.createInitialEntity(deviceData, newDevice, callback);
+    } else {
+        deviceHandlerV2.createInitialEntity(deviceData, newDevice, callback);
+    }
+}
+
 /**
  * Updates the register of an existing device identified by the Id and Type in the Context Broker, and the internal
  * registry. It uses both NGSI-LD and NGSI-v2
@@ -46,4 +61,5 @@ function updateRegisterDeviceNgsiMixed(deviceObj, previousDevice, entityInfoUpda
     }
 }
 
+exports.createInitialEntity = createInitialEntityNgsiMixed;
 exports.updateRegisterDevice = updateRegisterDeviceNgsiMixed;

package/lib/services/devices/devices-NGSI-v2.js

@@ -1,5 +1,5 @@
 /*
- * Copyright 2020 Telefonica Investigación y Desarrollo, S.A.U
+ * Copyright 2020 Telefonica Investigación y Desarrollo, S.A.U
  *
  * This file is part of fiware-iotagent-lib
  *
@@ -164,12 +164,102 @@ function formatCommandsNgsi2(originalVector) {
     return attributeList;
 }
 
+function formatCommandsBySubsNgsi2(originalVector) {
+    const attributeList = {};
+
+    if (originalVector && originalVector.length) {
+        for (let i = 0; i < originalVector.length; i++) {
+            attributeList[originalVector[i].name] = {
+                type: 'command',
+                value: null
+            };
+        }
+    }
+
+    return attributeList;
+}
+
+function createInitialEntityHandlerNgsi2(deviceData, newDevice, callback) {
+    return function handleInitialEntityResponse(error, response, body) {
+        if (error) {
+            logger.error(
+                context,
+                'ORION-001: Connection error creating inital entity in the Context Broker: %s',
+                error
+            );
+
+            alarms.raise(constants.ORION_ALARM, error);
+
+            callback(error);
+        } else if (response && response.statusCode === 204) {
+            alarms.release(constants.ORION_ALARM);
+            logger.debug(context, 'Initial entity created successfully.');
+            callback(null, newDevice);
+        } else {
+            logger.error(
+                context,
+                'Protocol error connecting to the Context Broker [%d]: %s',
+                response.statusCode,
+                body
+            );
+
+            const errorObj = new errors.EntityGenericError(newDevice.id, newDevice.type, body, response.statusCode);
+
+            callback(errorObj);
+        }
+    };
+}
+
 /*
  * This methods makes a bypass in updateRegisterDeviceNgsi2 to allow not change
  * extractDeviceDifference and combineWithNewDevice methods
  */
-function createInitialEntityNgsi2Fake(deviceData, newDevice, callback) {
-    callback(null, newDevice);
+function createInitialEntityNgsi2(newDevice, deviceObj, callback) {
+    logger.debug(context, 'createInitialEntityNgsiv2 called with newDevice: %j', newDevice);
+
+    const cmdModeConfig = config.getConfig().cmdMode;
+
+    const isLegacy =
+        (!newDevice.cmdMode && (!cmdModeConfig || cmdModeConfig === 'legacy')) || newDevice.cmdMode === 'legacy';
+    if (isLegacy) {
+        logger.debug(context, 'Old cmdMode with newDevice: %j', deviceObj);
+        return callback(null, deviceObj);
+    }
+
+    if (!Array.isArray(newDevice.commands) || newDevice.commands.length === 0) {
+        logger.debug(context, 'No initial entity due to no commands by subs in newDevice: %j', newDevice);
+        return callback(null, deviceObj);
+    }
+
+    const entityPayload = {
+        id: String(newDevice.name),
+        type: newDevice.type
+    };
+    jsonConcat(entityPayload, formatCommandsBySubsNgsi2(newDevice.commands));
+
+    let url = config.getConfig().contextBroker.url + '/v2/entities?options=upsert';
+    if (newDevice.cbHost) {
+        url = newDevice.cbHost.includes('://')
+            ? newDevice.cbHost + '/v2/entities?options=upsert'
+            : 'http://' + newDevice.cbHost + '/v2/entities?options=upsert';
+    }
+
+    const headers = {
+        'fiware-correlator': (domain.active && domain.active.corr) || uuid.v4()
+    };
+    if (newDevice.service) headers['fiware-service'] = newDevice.service;
+    if (newDevice.subservice) headers['fiware-servicepath'] = newDevice.subservice;
+
+    const options = { url, method: 'POST', json: entityPayload, headers };
+
+    logger.debug(context, 'Creating initial entity due to commands by subs with newDevice: %j', newDevice);
+    logger.debug(context, 'Creating initial entity in the Context Broker:\n %s', JSON.stringify(options, null, 4));
+
+    return utils.executeWithSecurity(
+        options,
+        newDevice,
+        createInitialEntityHandlerNgsi2(newDevice, deviceObj, callback)
+    );
 }
 
 /**
@@ -179,6 +269,7 @@ function createInitialEntityNgsi2Fake(deviceData, newDevice, callback) {
  * @param {Object} updatedDevice    Device object that will be stored in the database.
  */
 function updateEntityNgsi2(deviceData, updatedDevice, callback) {
+    logger.debug(context, 'updateEntityNgsi2 called with deviceData: %j updatedDevice: %j', deviceData, updatedDevice);
     const options = {
         url: config.getConfig().contextBroker.url + '/v2/entities/' + String(deviceData.name) + '/attrs',
         method: 'POST',
@@ -202,7 +293,14 @@ function updateEntityNgsi2(deviceData, updatedDevice, callback) {
 
     jsonConcat(options.json, formatAttributesNgsi2(deviceData.active, false));
     jsonConcat(options.json, formatAttributesNgsi2(deviceData.staticAttributes, true));
-    jsonConcat(options.json, formatCommandsNgsi2(deviceData.commands));
+    if (
+        (!updatedDevice.cmdMode && (!config.getConfig().cmdMode || config.getConfig().cmdMode === 'legacy')) ||
+        (updatedDevice && updatedDevice.cmdMode === 'legacy')
+    ) {
+        jsonConcat(options.json, formatCommandsNgsi2(deviceData.commands));
+    } else {
+        jsonConcat(options.json, formatCommandsBySubsNgsi2(deviceData.commands));
+    }
 
     for (const att in options.json) {
         try {
@@ -252,7 +350,13 @@ function updateRegisterDeviceNgsi2(deviceObj, previousDevice, entityInfoUpdated,
         return;
     }
 
-    logger.debug(context, 'Update provisioned v2 device in Device Service %j %j', deviceObj, entityInfoUpdated);
+    logger.debug(
+        context,
+        'Update provisioned v2 device %j with Device %j entityInfoUpdated %j',
+        previousDevice,
+        deviceObj,
+        entityInfoUpdated
+    );
 
     function combineWithNewDevice(newDevice, oldDevice, callback) {
         logger.debug(context, 'combineWithNewDevice %j %j', newDevice, oldDevice);
@@ -290,6 +394,9 @@ function updateRegisterDeviceNgsi2(deviceObj, previousDevice, entityInfoUpdated,
             if ('storeLastMeasure' in newDevice && newDevice.storeLastMeasure !== undefined) {
                 oldDevice.storeLastMeasure = newDevice.storeLastMeasure;
             }
+            if ('cmdMode' in newDevice && newDevice.cmdMode !== undefined) {
+                oldDevice.cmdMode = newDevice.cmdMode;
+            }
             callback(null, oldDevice);
         } else {
             callback(new errors.DeviceNotFound(newDevice.id, newDevice));
@@ -337,7 +444,7 @@ function updateRegisterDeviceNgsi2(deviceObj, previousDevice, entityInfoUpdated,
         if (entityInfoUpdated) {
             jsonConcat(deviceData.active, oldDevice.active);
             jsonConcat(deviceData.lazy, oldDevice.lazy);
-            jsonConcat(deviceData.commands, oldDevice.commands);
+            deviceData.commands = deviceData.commands.concat(oldDevice.commands);
             jsonConcat(deviceData.staticAttributes, oldDevice.staticAttributes);
             if (oldDevice.name !== newDevice.name) {
                 deviceData.name = newDevice.name;
@@ -346,7 +453,13 @@ function updateRegisterDeviceNgsi2(deviceObj, previousDevice, entityInfoUpdated,
                 deviceData.type = newDevice.type;
             }
         }
-
+        logger.debug(
+            context,
+            'extractDeviceDifference newDevice %j oldDevice %j difference %j',
+            newDevice,
+            oldDevice,
+            deviceData
+        );
         callback(null, deviceData, oldDevice);
     }
 
@@ -361,7 +474,7 @@ function updateRegisterDeviceNgsi2(deviceObj, previousDevice, entityInfoUpdated,
                     deviceObj.subservice
                 ),
                 apply(extractDeviceDifference, deviceObj),
-                createInitialEntityNgsi2Fake,
+                createInitialEntityNgsi2,
                 apply(combineWithNewDevice, deviceObj),
                 apply(registrationUtils.sendRegistrations, false),
                 apply(registrationUtils.processContextRegistration, deviceObj),
@@ -391,6 +504,7 @@ function updateRegisterDeviceNgsi2(deviceObj, previousDevice, entityInfoUpdated,
     }
 }
 
+exports.createInitialEntity = createInitialEntityNgsi2;
 exports.updateRegisterDevice = updateRegisterDeviceNgsi2;
 exports.formatCommands = formatCommandsNgsi2;
 exports.formatAttributes = formatAttributesNgsi2;

package/lib/services/devices/registrationUtils.js

@@ -36,6 +36,7 @@ const context = {
 };
 const async = require('async');
 const utils = require('../northBound/restUtils');
+const subscriptionService = require('../ngsi/subscriptionService');
 
 const NGSI_LD_URN = 'urn:ngsi-ld:';
 
@@ -203,6 +204,23 @@ function sendUnregistrationsNgsiLD(deviceData, callback) {
     return callback(null, deviceData);
 }
 
+function formatAttributes(originalVector) {
+    const attributeList = [];
+    if (originalVector && originalVector.length) {
+        for (let i = 0; i < originalVector.length; i++) {
+            attributeList.push(originalVector[i].name);
+        }
+    }
+    return attributeList;
+}
+
+function mergeWithSameName(old, current) {
+    if (old.indexOf(current) < 0) {
+        old.push(current);
+    }
+    return old;
+}
+
 /**
  * Sends a Context Provider registration or unregistration request to the Context Broker using NGSIv2.
  *
@@ -210,26 +228,6 @@ function sendUnregistrationsNgsiLD(deviceData, callback) {
  * @param {Object} deviceData       Object containing all the deviceData needed to send the registration.
  */
 function sendRegistrationsNgsi2(unregister, deviceData, callback) {
-    function formatAttributes(originalVector) {
-        const attributeList = [];
-
-        if (originalVector && originalVector.length) {
-            for (let i = 0; i < originalVector.length; i++) {
-                attributeList.push(originalVector[i].name);
-            }
-        }
-
-        return attributeList;
-    }
-
-    function mergeWithSameName(old, current) {
-        if (old.indexOf(current) < 0) {
-            old.push(current);
-        }
-
-        return old;
-    }
-
     // FIXME: When https://github.com/telefonicaid/fiware-orion/issues/3007 is merged into master branch,
     // this function should use the new API. This is just a temporary solution which implies deleting the
     // registration and creating a new one.
@@ -299,6 +297,61 @@ function sendRegistrationsNgsi2(unregister, deviceData, callback) {
     utils.executeWithSecurity(options, deviceData, createRegistrationHandlerNgsi2(unregister, deviceData, callback));
 }
 
+function sendUnsubscriptionsNgsi2(deviceData, callback) {
+    if (deviceData.subscriptionId) {
+        logger.debug(
+            context,
+            'Sending v2 device unsubscriptions to Context Broker at [%s]',
+            config.getConfig().contextBroker.url
+        );
+        logger.debug(context, 'Using the following subscriptionId %j', deviceData.subscriptionId);
+        subscriptionService.unsubscribe(deviceData, deviceData.subscriptionId, callback);
+    } else {
+        logger.debug(context, 'No subscription found for unregister');
+        return callback(null, deviceData);
+    }
+}
+
+function sendSubscriptionsNgsi2(unregister, deviceData, callback) {
+    function updateSubscriptionNgsi2(deviceData, callback) {
+        const functions = [];
+
+        function removeSubscriptionId(deviceData, unregistrationResult, callback) {
+            delete deviceData.subscriptionId;
+            return callback(null, deviceData);
+        }
+
+        functions.push(async.apply(sendSubscriptionsNgsi2, true, deviceData));
+        functions.push(async.apply(removeSubscriptionId, deviceData));
+        functions.push(async.apply(sendSubscriptionsNgsi2, false));
+        async.waterfall(functions, callback);
+    }
+
+    if (unregister) {
+        return sendUnsubscriptionsNgsi2(deviceData, callback);
+    }
+    if (deviceData.subscriptionId) {
+        return updateSubscriptionNgsi2(deviceData, callback);
+    }
+    const attrs = [].concat(formatAttributes(deviceData.commands)).reduce(mergeWithSameName, []);
+
+    if (attrs.length === 0) {
+        logger.debug(context, 'Subscription is not needed. Device without commands');
+        return callback(null, deviceData);
+    }
+    const trigger = attrs; // one subscription for all commands
+    const content = attrs;
+    const attrsFormat = 'simplifiedNormalized';
+
+    logger.debug(
+        context,
+        'Sending v2 device subscriptions to Context Broker at [%s]',
+        config.getConfig().contextBroker.url
+    );
+    logger.debug(context, 'Using the following trigger %j and content %j', trigger, content);
+    subscriptionService.subscribe(deviceData, trigger, content, attrsFormat, callback);
+}
+
 /**
  * Sends a Context Provider registration or unregistration request to the Context Broker using NGSI-LD.
  *
@@ -323,14 +376,14 @@ function sendRegistrationsNgsiLD(unregister, deviceData, callback) {
         properties.push(element.name);
     });
 
-    if (lazy.length > 0){
-        operations.push('retrieveOps');  
+    if (lazy.length > 0) {
+        operations.push('retrieveOps');
     }
-    if (commands.length > 0){
-         operations.push('updateOps'); 
+    if (commands.length > 0) {
+        operations.push('updateOps');
     }
-    if (supportMerge){
-        operations.push('mergeEntity'); 
+    if (supportMerge) {
+        operations.push('mergeEntity');
     }
 
     if (properties.length === 0) {
@@ -368,8 +421,8 @@ function sendRegistrationsNgsiLD(unregister, deviceData, callback) {
             endpoint: config.getConfig().providerUrl,
             contextSourceInfo: [
                 {
-                    'key': 'jsonldContext',
-                    'value': config.getConfig().contextBroker.jsonLdContext
+                    key: 'jsonldContext',
+                    value: config.getConfig().contextBroker.jsonLdContext
                 }
             ],
             '@context': config.getConfig().contextBroker.jsonLdContext
@@ -405,7 +458,14 @@ function sendRegistrations(unregister, deviceData, callback) {
             sendRegistrationsNgsiLD(unregister, deviceData, callback);
             break;
         default:
-            sendRegistrationsNgsi2(unregister, deviceData, callback);
+            if (
+                (!deviceData.cmdMode && (!config.getConfig().cmdMode || config.getConfig().cmdMode === 'legacy')) ||
+                (deviceData && deviceData.cmdMode === 'legacy')
+            ) {
+                sendRegistrationsNgsi2(unregister, deviceData, callback);
+            } else {
+                sendSubscriptionsNgsi2(unregister, deviceData, callback);
+            }
             break;
     }
 }
@@ -421,7 +481,14 @@ function processContextRegistration(deviceData, body, callback) {
     const newDevice = _.clone(deviceData);
 
     if (body) {
-        newDevice.registrationId = body.registrationId;
+        if (
+            (!deviceData.cmdMode && (!config.getConfig().cmdMode || config.getConfig().cmdMode === 'legacy')) ||
+            (deviceData && deviceData.cmdMode === 'legacy')
+        ) {
+            newDevice.registrationId = body.registrationId;
+        } else {
+            newDevice.subscriptionId = body.subscriptionId;
+        }
     }
 
     callback(null, newDevice);

package/lib/services/groups/groupRegistryMongoDB.js

@@ -63,7 +63,8 @@ const attributeList = [
     'entityNameExp',
     'payloadType',
     'useCBflowControl',
-    'storeLastMeasure'
+    'storeLastMeasure',
+    'cmdMode'
 ];
 
 function createGroup(group, callback) {

package/lib/services/ngsi/subscription-NGSI-LD.js

@@ -105,7 +105,7 @@ function createSubscriptionHandlerNgsiLD(device, triggers, store, callback) {
  * @param {Object} triggers     Array with the names of the attributes that would trigger the subscription
  * @param {Object} content      Array with the names of the attributes to retrieve in the notification.
  */
-function subscribeNgsiLD(device, triggers, content, callback) {
+function subscribeNgsiLD(device, triggers, content, attrsFormat, callback) {
     const options = {
         method: 'POST',
         headers: {
@@ -132,7 +132,7 @@ function subscribeNgsiLD(device, triggers, content, callback) {
                     accept: 'application/json'
                 },
                 attributes: content || [],
-                format: 'normalized'
+                format: attrsFormat
             }
         }
     };

package/lib/services/ngsi/subscription-NGSI-mixed.js

@@ -36,11 +36,11 @@ const subscriptionHandlerV2 = require('./subscription-NGSI-v2');
  * @param {Object} triggers     Array with the names of the attributes that would trigger the subscription
  * @param {Object} content      Array with the names of the attributes to retrieve in the notification.
  */
-function subscribeNgsiMixed(device, triggers, content, callback) {
+function subscribeNgsiMixed(device, triggers, content, attrsFormat, callback) {
     if (config.checkNgsiLD(device)) {
-        subscriptionHandlerLD.subscribe(device, triggers, content, callback);
+        subscriptionHandlerLD.subscribe(device, triggers, content, attrsFormat, callback);
     } else {
-        subscriptionHandlerV2.subscribe(device, triggers, content, callback);
+        subscriptionHandlerV2.subscribe(device, triggers, content, attrsFormat, callback);
     }
 }
 

package/lib/services/ngsi/subscription-NGSI-v2.js

@@ -93,7 +93,9 @@ function createSubscriptionHandlerNgsi2(device, triggers, store, callback) {
 
             config.getRegistry().update(device, device, callback);
         } else {
-            callback(null, response.headers.location);
+            callback(null, {
+                subscriptionId: response.headers.location.substr(response.headers.location.lastIndexOf('/') + 1)
+            });
         }
     };
 }
@@ -107,7 +109,7 @@ function createSubscriptionHandlerNgsi2(device, triggers, store, callback) {
  * @param {Object} triggers     Array with the names of the attributes that would trigger the subscription
  * @param {Object} content      Array with the names of the attributes to retrieve in the notification.
  */
-function subscribeNgsi2(device, triggers, content, callback) {
+function subscribeNgsi2(device, triggers, content, attrsFormat, callback) {
     const options = {
         method: 'POST',
         headers: {
@@ -115,6 +117,7 @@ function subscribeNgsi2(device, triggers, content, callback) {
             'fiware-servicepath': device.subservice
         },
         json: {
+            description: 'Managed by IOTA: ' + device.name + ' ' + device.type + ' ' + triggers.join(','),
             subject: {
                 entities: [
                     {
@@ -132,7 +135,8 @@ function subscribeNgsi2(device, triggers, content, callback) {
                     url: config.getConfig().providerUrl + '/notify'
                 },
                 attrs: content || [],
-                attrsFormat: 'normalized'
+                attrsFormat: attrsFormat,
+                onlyChangedAttrs: true
             }
         }
     };
@@ -167,7 +171,7 @@ function createUnsubscribeHandlerNgsi2(device, id, callback) {
         if (error) {
             logger.debug(
                 context,
-                'Transport error found subscribing device with id [%s] to entity [%s]',
+                'Transport error found unsubscribing device with id [%s] to entity [%s]',
                 device.id,
                 device.name
             );
@@ -176,7 +180,9 @@ function createUnsubscribeHandlerNgsi2(device, id, callback) {
         } else if (response.statusCode !== 204) {
             logger.debug(
                 context,
-                'Unknown error subscribing device with id [%s] to entity [%s]: $s',
+                'Unknown error unsubscribing device with id [%s] to entity [%s]: %s',
+                device.id,
+                device.name,
                 response.statusCode
             );
 
@@ -202,7 +208,15 @@ function createUnsubscribeHandlerNgsi2(device, id, callback) {
 
             callback(new errors.BadRequest(body.orionError.details));
         } else {
-            device.subscriptions.splice(device.subscriptions.indexOf(id), 1);
+            logger.debug(context, 'removing subscription %s from device %j', id, device);
+            if (device.subscriptions) {
+                // check before try to eliminates
+                const index = device.subscriptions.indexOf(id);
+                if (index !== -1) {
+                    // only eliminates if exits
+                    device.subscriptions.splice(index, 1);
+                }
+            }
             config.getRegistry().update(device, device, callback);
         }
     };

package/lib/services/ngsi/subscriptionService.js

@@ -57,8 +57,8 @@ function init() {
  * @param {Object} triggers     Array with the names of the attributes that would trigger the subscription
  * @param {Object} content      Array with the names of the attributes to retrieve in the notification.
  */
-function subscribe(device, triggers, content, callback) {
-    subscriptionHandler.subscribe(device, triggers, content, callback);
+function subscribe(device, triggers, content, attrsFormat, callback) {
+    subscriptionHandler.subscribe(device, triggers, content, attrsFormat, callback);
 }
 
 /**

package/lib/services/northBound/deviceProvisioningServer.js

@@ -67,7 +67,8 @@ const provisioningAPITranslation = {
     payloadType: 'payloadType',
     useCBflowControl: 'useCBflowControl',
     storeLastMeasure: 'storeLastMeasure',
-    lastMeasure: 'lastMeasure'
+    lastMeasure: 'lastMeasure',
+    cmdMode: 'cmdMode'
 };
 
 /**
@@ -149,7 +150,8 @@ function handleProvision(req, res, next) {
             payloadType: body.payloadType,
             useCBflowControl: body.useCBflowControl,
             storeLastMeasure: body.storeLastMeasure,
-            lastMeasure: body.lastMeasure
+            lastMeasure: body.lastMeasure,
+            cmdMode: body.cmdMode
         });
     }
 
@@ -229,7 +231,8 @@ function toProvisioningAPIFormat(device) {
         payloadType: device.payloadType,
         useCBflowControl: device.useCBflowControl,
         storeLastMeasure: device.storeLastMeasure,
-        lastMeasure: device.lastMeasure
+        lastMeasure: device.lastMeasure,
+        cmdMode: device.cmdMode
     };
 }