iotagent-node-lib 4.4.0 → 4.6.0

package/test/unit/ngsiv2/provisioning/device-update-registration_test.js

@@ -197,7 +197,7 @@ describe('NGSI-v2 - IoT Agent Device Update Registration', function () {
         });
 
         it('should register as ContextProvider of its lazy attributes', function (done) {
-            iotAgentLib.updateRegister(deviceUpdated, false, function (error) {
+            iotAgentLib.updateRegister(deviceUpdated, device1, false, function (error) {
                 should.not.exist(error);
                 contextBrokerMock.done();
                 done();
@@ -205,7 +205,7 @@ describe('NGSI-v2 - IoT Agent Device Update Registration', function () {
         });
 
         it('should store the new values in the registry', function (done) {
-            iotAgentLib.updateRegister(deviceUpdated, false, function (error, data) {
+            iotAgentLib.updateRegister(deviceUpdated, device1, false, function (error, data) {
                 iotAgentLib.getDevice(deviceUpdated.id, null, 'smartgondor', 'gardens', function (error, deviceResult) {
                     should.not.exist(error);
                     should.exist(deviceResult);
@@ -253,7 +253,7 @@ describe('NGSI-v2 - IoT Agent Device Update Registration', function () {
         });
 
         it('should register as ContextProvider of its commands and create the additional attributes', function (done) {
-            iotAgentLib.updateRegister(deviceCommandUpdated, false, function (error) {
+            iotAgentLib.updateRegister(deviceCommandUpdated, device1, false, function (error) {
                 should.not.exist(error);
                 contextBrokerMock.done();
                 done();
@@ -261,7 +261,7 @@ describe('NGSI-v2 - IoT Agent Device Update Registration', function () {
         });
 
         it('should store the new values in the registry', function (done) {
-            iotAgentLib.updateRegister(deviceCommandUpdated, false, function (error, data) {
+            iotAgentLib.updateRegister(deviceCommandUpdated, device1, false, function (error, data) {
                 iotAgentLib.getDevice(
                     deviceCommandUpdated.id,
                     null,
@@ -282,7 +282,7 @@ describe('NGSI-v2 - IoT Agent Device Update Registration', function () {
 
     describe('When a update action is executed in a non registered device', function () {
         it('should return a DEVICE_NOT_FOUND error', function (done) {
-            iotAgentLib.updateRegister(unknownDevice, false, function (error) {
+            iotAgentLib.updateRegister(unknownDevice, device1, false, function (error) {
                 should.exist(error);
                 error.name.should.equal('DEVICE_NOT_FOUND');
                 done();
@@ -304,7 +304,7 @@ describe('NGSI-v2 - IoT Agent Device Update Registration', function () {
         });
 
         it('should return a REGISTRATION_ERROR error in the update action', function (done) {
-            iotAgentLib.updateRegister(deviceUpdated, false, function (error) {
+            iotAgentLib.updateRegister(deviceUpdated, device1, false, function (error) {
                 should.exist(error);
                 error.name.should.equal('UNREGISTRATION_ERROR');
                 done();

package/test/unit/ngsiv2/provisioning/listProvisionedDevices-test.js

@@ -183,11 +183,9 @@ describe('NGSI-v2 - Device provisioning API: List provisioned devices', function
                 should.exist(body.devices[2].attributes[0].entity_name);
                 should.exist(body.devices[2].attributes[0].entity_type);
                 should.exist(body.devices[2].attributes[1].expression);
-                should.exist(body.devices[2].attributes[2].reverse);
                 body.devices[2].attributes[0].entity_name.should.equal('Higro2000');
                 body.devices[2].attributes[0].entity_type.should.equal('Higrometer');
                 body.devices[2].attributes[1].expression.should.equal('${@humidity * 20}');
-                body.devices[2].attributes[2].reverse.length.should.equal(2);
                 done();
             });
         });
@@ -242,11 +240,9 @@ describe('NGSI-v2 - Device provisioning API: List provisioned devices', function
                 should.exist(body.attributes[0].entity_name);
                 should.exist(body.attributes[0].entity_type);
                 should.exist(body.attributes[1].expression);
-                should.exist(body.attributes[2].reverse);
                 body.attributes[0].entity_name.should.equal('Higro2000');
                 body.attributes[0].entity_type.should.equal('Higrometer');
                 body.attributes[1].expression.should.equal('${@humidity * 20}');
-                body.attributes[2].reverse.length.should.equal(2);
                 done();
             });
         });

package/test/unit/ngsiv2/provisioning/updateProvisionedDevices-test.js

@@ -289,6 +289,41 @@ describe('NGSI-v2 - Device provisioning API: Update provisioned devices', functi
             });
         });
     });
+    describe('When an update request arrives with a new Apikey', function () {
+        const optionsUpdate = {
+            url: 'http://localhost:' + iotAgentConfig.server.port + '/iot/devices/Light1',
+            method: 'PUT',
+            headers: {
+                'fiware-service': 'smartgondor',
+                'fiware-servicepath': '/gardens'
+            },
+            json: utils.readExampleFile(
+                './test/unit/examples/deviceProvisioningRequests/updateProvisionDeviceWithApikey.json'
+            )
+        };
+
+        beforeEach(function () {
+            contextBrokerMock
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', '/gardens')
+                .delete('/v2/registrations/6319a7f5254b05844116584d', '')
+                .reply(204);
+
+            contextBrokerMock
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', '/gardens')
+                .post('/v2/registrations')
+                .reply(201, null, { Location: '/v2/registrations/4419a7f5254b058441165849' });
+        });
+
+        it('should raise a 204 error', function (done) {
+            request(optionsUpdate, function (error, response, body) {
+                should.not.exist(error);
+                response.statusCode.should.equal(204);
+                done();
+            });
+        });
+    });
     describe('When a wrong update request payload arrives', function () {
         const optionsUpdate = {
             url: 'http://localhost:' + iotAgentConfig.server.port + '/iot/devices/Light1',

package/test/unit/statsRegistry/openmetrics-test.js

@@ -0,0 +1,167 @@
+/*
+ * Copyright 2024 Telefonica Investigación y Desarrollo, S.A.U
+ *
+ * This file is part of fiware-iotagent-lib
+ *
+ * fiware-iotagent-lib is free software: you can redistribute it and/or
+ * modify it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the License,
+ * or (at your option) any later version.
+ *
+ * fiware-iotagent-lib is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+ * See the GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public
+ * License along with fiware-iotagent-lib.
+ * If not, see http://www.gnu.org/licenses/.
+ *
+ * For those usages not covered by the GNU Affero General Public License
+ * please contact with::daniel.moranjimenez@telefonica.com
+ */
+
+/* eslint-disable no-unused-vars */
+
+const statsRegistry = require('../../../lib/services/stats/statsRegistry');
+const should = require('should');
+
+describe('statsRegistry - openmetrics endpoint', function () {
+
+    const testCases = [
+        {
+            description: 'Should accept standard openmetrics 0.0.1 header',
+            accept: 'application/openmetrics-text; version=0.0.1; charset=utf-8',
+            contentType: {
+                mediaType: 'application/openmetrics-text',
+                version: '0.0.1',
+                charset: 'utf-8'
+            }
+        },
+        {
+            description: 'Should accept standard openmetrics 1.0.0 header',
+            accept: 'application/openmetrics-text; version=1.0.0; charset=utf-8',
+            contentType: {
+                mediaType: 'application/openmetrics-text',
+                version: '1.0.0',
+                charset: 'utf-8'
+            }
+        },
+        {
+            description: 'Should accept openmetrics with no version',
+            accept: 'application/openmetrics-text',
+            contentType: {
+                mediaType: 'application/openmetrics-text',
+                version: '1.0.0',
+                charset: 'utf-8'
+            }
+        },
+        {
+            description: 'Should accept text/plain header with version',
+            accept: 'text/plain; version=0.0.4',
+            contentType: {
+                mediaType: 'text/plain',
+                version: '0.0.4',
+                charset: 'utf-8'
+            }
+        },
+        {
+            description: 'Should accept wildcard header',
+            accept: '*/*',
+            contentType: {
+                mediaType: 'text/plain',
+                version: '0.0.4',
+                charset: 'utf-8'
+            }
+        },
+        {
+            description: 'Should accept both openmetrics and text/plain, prefer openmetrics',
+            accept: 'application/openmetrics-text; version=0.0.1; charset=utf-8,text/plain;version=0.0.4',
+            contentType: {
+                mediaType: 'application/openmetrics-text',
+                version: '0.0.1',
+                charset: 'utf-8'
+            }
+        },
+        {
+            description: 'Should accept both text/plain and openmetrics, prefer openmetrics',
+            accept: 'text/plain,application/openmetrics-text; version=0.0.1; charset=utf-8',
+            contentType: {
+                mediaType: 'application/openmetrics-text',
+                version: '0.0.1',
+                charset: 'utf-8'
+            }
+        },
+        {
+            description: 'Should accept both openmetrics and text/plain, prefer text if preference set',
+            accept: 'application/openmetrics-text; version=0.0.1; charset=utf-8;q=0.5,text/plain;q=0.7',
+            contentType: {
+                mediaType: 'text/plain',
+                version: '0.0.4',
+                charset: 'utf-8'
+            }
+        },
+        {
+            description: 'Should match version to content-type',
+            accept: 'application/openmetrics-text; version=0.0.1; charset=utf-8, text/plain;version=1.0.0',
+            contentType: {
+                mediaType: 'application/openmetrics-text',
+                version: '0.0.1',
+                charset: 'utf-8'
+            }
+        },
+        {
+            description: 'Should set default q to 1.0',
+            accept: 'application/openmetrics-text; version=0.0.1; q=0.5,text/plain;version=0.0.4',
+            contentType: {
+                mediaType: 'text/plain',
+                version: '0.0.4',
+                charset: 'utf-8'
+            }
+        },
+        {
+            description: 'Should accept mixture of content-types and q',
+            accept: 'application/openmetrics-text; version=0.0.1,text/plain;version=0.0.4;q=0.5,*/*;q=0.1',
+            contentType: {
+                mediaType: 'application/openmetrics-text',
+                version: '0.0.1',
+                charset: 'utf-8'
+            }
+        },
+        {
+            description: 'Should reject Invalid charset',
+            accept: '*/*; charset=utf-16',
+            contentType: null
+        },
+        {
+            description: 'Should reject Invalid openmetrics version',
+            accept: 'application/openmetrics-text; version=0.0.5',
+            contentType: null
+        },
+        {
+            description: 'Should reject Invalid text/plain',
+            accept: 'text/plain; version=0.0.2',
+            contentType: null
+        }
+    ]
+
+    for (const testCase of testCases) {
+        describe(testCase.description, function () {
+            const result = statsRegistry.matchContentType(testCase.accept);
+            if (testCase.contentType) {
+                it('should match', function (done) {
+                    should.exist(result);
+                    result.mediaType.should.equal(testCase.contentType.mediaType);
+                    result.version.should.equal(testCase.contentType.version);
+                    result.charset.should.equal(testCase.contentType.charset);
+                    done();
+                });
+            } else {
+                it('should not match', function (done) {
+                    should.not.exist(result);
+                    done();
+                });
+            }
+        });
+    }
+});

package/lib/templates/queryContext.json

@@ -1,25 +0,0 @@
-{
-  "properties": {
-    "entities": {
-      "description": "The objects the request is applied to.",
-      "type": "array",
-      "items": {
-        "type": "object",
-        "properties": {
-          "type": {
-            "type": "string",
-            "required": true
-          },
-          "isPattern": {
-            "type": "string"
-          },
-          "id": {
-            "type": "string",
-            "required": true
-          }
-        }
-      },
-      "required": true
-    }
-  }
-}

package/test/unit/examples/deviceProvisioningRequests/provisionBidirectionalDevice.json

@@ -1,35 +0,0 @@
-{
-  "devices": [
-    {
-      "device_id": "Light1",
-      "protocol": "GENERIC_PROTO",
-      "entity_name": "TheFirstLight",
-      "entity_type": "TheLightType",
-      "timezone": "America/Santiago",
-      "endpoint": "http://fakedEndpoint:1234",
-      "transport": "MQTT",
-      "attributes": [
-        {
-          "name":"location",
-          "type":"geo:point",
-          "expression": "latitude,longitude",
-          "reverse": [
-            {
-              "object_id":"latitude",
-              "type": "Number",
-              "expression": "location | split(', ')[1] | parsefloat()"
-            },
-            {
-              "object_id":"longitude",
-              "type": "Number",
-              "expression": "location | split(', ')[0] | parsefloat()"
-            }
-          ]
-        }
-      ],
-      "lazy": [],
-      "static_attributes": [],
-      "commands": []
-    }
-  ]
-}

package/test/unit/examples/deviceProvisioningRequests/provisionDeviceBidirectionalGroup.json

@@ -1,17 +0,0 @@
-{
-  "devices": [
-    {
-      "device_id": "Light1",
-      "protocol": "GENERIC_PROTO",
-      "entity_name": "TheFirstLight",
-      "entity_type": "TheLightType",
-      "timezone": "America/Santiago",
-      "endpoint": "http://fakedEndpoint:1234",
-      "transport": "MQTT",
-      "attributes": [],
-      "lazy": [],
-      "static_attributes": [],
-      "commands": []
-    }
-  ]
-}

package/test/unit/examples/groupProvisioningRequests/bidirectionalGroup.json

@@ -1,31 +0,0 @@
-{
-  "services": [
-    {
-      "resource": "/deviceTest",
-      "apikey": "801230BJKL23Y9090DSFL123HJK09H324HV8732",
-      "entity_type": "TheLightType",
-      "commands": [],
-      "lazy": [],
-      "attributes": [
-        {
-          "name":"location",
-          "type":"geo:point",
-          "expression": "${latitude}, ${longitude}",
-          "reverse": [
-            {
-              "object_id":"latitude",
-              "type": "Number",
-              "expression": "location | split(', ')[1] | parsefloat()"
-            },
-            {
-              "object_id":"longitude",
-              "type": "Number",
-              "expression": "location | split(', ')[0] | parsefloat()"
-            }
-          ]
-        }
-      ],
-      "static_attributes": []
-    }
-  ]
-}

package/test/unit/general/statistics-persistence_test.js

@@ -1,121 +0,0 @@
-/*
- * Copyright 2014 Telefonica Investigación y Desarrollo, S.A.U
- *
- * This file is part of fiware-iotagent-lib
- *
- * fiware-iotagent-lib is free software: you can redistribute it and/or
- * modify it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the License,
- * or (at your option) any later version.
- *
- * fiware-iotagent-lib is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
- * See the GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public
- * License along with fiware-iotagent-lib.
- * If not, see http://www.gnu.org/licenses/.
- *
- * For those usages not covered by the GNU Affero General Public License
- * please contact with::[contacto@tid.es]
- */
-
-/* eslint-disable no-unused-vars */
-
-const statsService = require('../../../lib/services/stats/statsRegistry');
-const commonConfig = require('../../../lib/commonConfig');
-const iotAgentLib = require('../../../lib/fiware-iotagent-lib');
-const should = require('should');
-const async = require('async');
-const mongoUtils = require('../mongodb/mongoDBUtils');
-const iotAgentConfig = {
-    logLevel: 'FATAL',
-    contextBroker: {
-        host: '192.168.1.1',
-        port: '1026'
-    },
-    server: {
-        port: 4041,
-        host: 'localhost',
-        baseRoot: '/'
-    },
-    stats: {
-        interval: 50,
-        persistence: true
-    },
-    mongodb: {
-        host: 'localhost',
-        port: '27017',
-        db: 'iotagent'
-    },
-    types: {},
-    service: 'smartgondor',
-    subservice: 'gardens',
-    providerUrl: 'http://smartgondor.com',
-    deviceRegistrationDuration: 'P1M'
-};
-let iotAgentDb;
-let oldConfig;
-
-describe('Statistics persistence service', function () {
-    function insertDummy(n, callback) {
-        iotAgentDb.collection('tests').insertOne({ test: 'test' }, function () {
-            callback();
-        });
-    }
-
-    beforeEach(function (done) {
-        oldConfig = commonConfig.getConfig();
-
-        iotAgentLib.activate(iotAgentConfig, function (error) {
-            statsService.globalLoad({}, function () {
-                iotAgentDb = require('../../../lib/model/dbConn').db;
-
-                async.times(10, insertDummy, function () {
-                    done();
-                });
-            });
-        });
-    });
-
-    afterEach(function (done) {
-        iotAgentLib.deactivate(function (error) {
-            commonConfig.setConfig(oldConfig);
-            statsService.globalLoad({}, function () {
-                mongoUtils.cleanDbs(done);
-            });
-        });
-    });
-
-    describe('When a periodic persitence action is set', function () {
-        beforeEach(function (done) {
-            statsService.globalLoad(
-                {
-                    stat1: 10
-                },
-                function () {
-                    statsService.add('stat1', 5, done);
-                }
-            );
-        });
-
-        it('should store all the records in the database', function (done) {
-            statsService.addTimerAction(statsService.mongodbPersistence, function () {
-                setTimeout(function () {
-                    statsService.clearTimers(function () {
-                        iotAgentDb
-                            .collection('kpis')
-                            .find({})
-                            .toArray(function (err, docs) {
-                                should.not.exist(err);
-                                should.exist(docs);
-                                docs.length.should.be.above(2);
-                                done();
-                            });
-                    });
-                }, 200);
-            });
-        });
-    });
-});

package/test/unit/ngsi-ld/examples/contextRequests/createBidirectionalDevice.json

@@ -1,17 +0,0 @@
-[
-    {
-        "@context": "http://context.json-ld",
-        "id": "urn:ngsi-ld:TheLightType:TheFirstLight",
-        "location": {
-            "type": "GeoProperty",
-            "value": {
-                "coordinates": [
-                    0,
-                    0
-                ],
-                "type": "Point"
-            }
-        },
-        "type": "TheLightType"
-    }
-]

package/test/unit/ngsi-ld/examples/contextRequests/updateContextProcessTimestamp.json

@@ -1,12 +0,0 @@
-[
-    {
-        "@context": "http://context.json-ld",
-        "id": "urn:ngsi-ld:Light:light1",
-        "type": "Light",
-        "state": {
-            "type": "Property",
-            "value": true,
-            "observedAt": "2016-05-30T16:25:22.304Z"
-        }
-    }
-]

package/test/unit/ngsi-ld/examples/subscriptionRequests/bidirectionalNotification.json

@@ -1,13 +0,0 @@
-{
-    "data": [
-        {
-            "id": "TheFirstLight",
-            "location": {
-                "type": "geo:point",
-                "value": "12.4, -9.6"
-            },
-            "type": "TheLightType"
-        }
-    ],
-    "subscriptionId": "51c0ac9ed714fb3b37d7d5a8"
-}

package/test/unit/ngsi-ld/examples/subscriptionRequests/bidirectionalNotificationWithDatasetId.json

@@ -1,21 +0,0 @@
-{
-    "data": [
-        {
-            "id": "TheFirstLight",
-            "location": [
-              {
-                    "type": "GeoProperty",
-                    "value": "12.4, -9.6",
-                    "datasetId": "urn:ngsi-ld:Property:do-this"
-              },
-              {
-                    "type": "GeoProperty",
-                    "value": "6, 10",
-                    "datasetId": "urn:ngsi-ld:Property:then-do-this"
-              }
-            ],
-            "type": "TheLightType"
-        }
-    ],
-    "subscriptionId": "51c0ac9ed714fb3b37d7d5a8"
-}

package/test/unit/ngsi-ld/examples/subscriptionRequests/bidirectionalNotificationWithMetadata.json

@@ -1,17 +0,0 @@
-{
-    "data": [
-        {
-            "id": "TheFirstLight",
-            "location": {
-                "type": "GeoProperty",
-                "value": "12.4, -9.6",
-                "qos": {
-                  "type": "Property",
-                  "value": 1
-                }
-            },
-            "type": "TheLightType"
-        }
-    ],
-    "subscriptionId": "51c0ac9ed714fb3b37d7d5a8"
-}

package/test/unit/ngsi-ld/examples/subscriptionRequests/bidirectionalSubscriptionRequest.json

@@ -1,23 +0,0 @@
-{
-  "@context": "http://context.json-ld",
-  "type": "Subscription",
-  "entities": [
-    {
-      "id": "TheFirstLight",
-      "type": "TheLightType"
-    }
-  ],
-  "watchedAttributes": [
-    "location"
-  ],
-  "notification": {
-    "endpoint": {
-      "uri": "http://smartgondor.com/notify",
-      "accept": "application/json"
-    },
-    "attributes": [
-      "location"
-    ],
-    "format": "normalized"
-  }
-}