iotagent-node-lib 3.2.0 → 3.4.0

package/doc/{northboundinteractions.md → devel/northboundinteractions.md}

@@ -145,7 +145,7 @@ This **NGSI-v2** payload is associated to an update operation (POST `/v2/op/upda
             }
         }
     ],
-    "actionType": "update"
+    "actionType": "append"
 }
 ```
 
@@ -155,9 +155,8 @@ As it can be seen in the example, the payload is a JSON Object with the followin
     with the information needed to identify the target entity `id` and `type` attributes. The `entities` attribute is an
     array, so a single update context batch operation can be used to update multiple devices
 
--   An `actionType` indicating the type of update: if this attribute has the value `"append"` the appropriate entity and
-    attributes will be created if the don't exist; if the value is `"update"`, an error will be thrown if the target
-    resources don't exist.
+-   An `actionType` indicating the type of update. It has the value `"append"` the appropriate entity and attributes
+    will be created if the don't exist.
 
 The equivalent **NGSI-LD** payload is associated to an update operation (PATCH `/ngsi-ld/v1/entities/<entity>/attrs/`).
 
@@ -427,7 +426,7 @@ Be sure to understand how each scenario works (as shown in the theory section) b
 Along this document, IP addresses and passwords will be concealed. Substitute the concealed passwords by your own.
 
 A postman collection is available alongside this document to help in reproducing this examples. It can be found
-[here](./doc/NorthboundInteractions.postman_collection).
+[here](NorthboundInteractions.postman_collection).
 
 ### Retrieving a token
 
@@ -507,8 +506,8 @@ curl -X POST -H "Content-Type: application/json" -H "Accept: application/json" -
             }
         }
     ],
-    "actionType": "update"
-} ' "https://<platform-ip>:10027/v2/op/update"
+    "actionType": "append"
+} ' "https://<platform-ip>:1026/v2/op/update"
 ```
 
 If the request is correct, the Context Broker will reply with the following R1 response (200 OK):
@@ -554,7 +553,7 @@ curl -X POST -H "Content-Type: application/json" -H "Accept: application/json" -
         }
     ],
     "attrs": ["temperature","pressure"]
-}' "https://<platform-ip>:10027/v2/op/query"
+}' "https://<platform-ip>:1026/v2/op/query"
 ```
 
 The Context Broker will reply with the updated data values in R2 format (200 OK):
@@ -600,20 +599,6 @@ It is worth mentioning that the Context Broker will reply with a 200 OK status c
 refer to transport protocol level errors, while the status codes inside of a payload give information about the
 application level protocol.
 
-The example shows an error updating an non-existent attribute (due to the use of UPDATE instead of APPEND).
-
-The following error payload is also valid in standard NGSI:
-
-```json
-{
-    "error": "NotFound",
-    "description": "The requested entity has not been found. Check type and id"
-}
-```
-
-Different kinds of errors can return their information in different formats, so NGSI implementations should check for
-the existence of both.
-
 ### Scenario 2: lazy attributes (happy path)
 
 Scenario 2 relies on the Context Provider mechanism of the Context Broker. For this scenario to work, the IoTAgent must
@@ -639,7 +624,7 @@ curl -X POST -H "Content-Type: application/json" -H "Accept: application/json" -
         }
     }
 }
-' "https://<platform-ip>:10027/v2/registrations"
+' "https://<platform-ip>:1026/v2/registrations"
 ```
 
 If everything has gone OK, the Context Broker will return the following payload:
@@ -669,7 +654,7 @@ curl -X POST -H "Content-Type: application/json" -H "Accept: application/json" -
         }
     ],
     "attrs": ["batteryLevel"]
-}' "https://<platform-ip>:10027/v2/op/query"
+}' "https://<platform-ip>:1026/v2/op/query"
 ```
 
 The Context Broker receives this request and detects that it can be served by a Context Provider (the IoT Agent), so it
@@ -772,7 +757,7 @@ curl -X POST -H "Content-Type: application/json" -H "Accept: application/json" -
         }
     ],
     "duration": "P1M"
-}' "https://<platform-ip>:10027/v2/registrations"
+}' "https://<platform-ip>:1026/v2/registrations"
 ```
 
 If everything has gone OK, the Context Broker will return the following payload:
@@ -806,8 +791,8 @@ curl -X POST -H "Content-Type: application/json" -H "Accept: application/json" -
             }
         }
     ],
-    "updateAction": "update"
-} ' "https://<platform-ip>:10027/v2/op/update"
+    "updateAction": "append"
+} ' "https://<platform-ip>:1026/v2/op/update"
 ```
 
 The Context Broker receives this command and detects that it can be served by a Context Provider (the IoT Agent), so it
@@ -836,7 +821,7 @@ Fiware-Correlator: 9cae9496-8ec7-11e6-80fc-fa163e734aab
       }
     }
   ],
-  "updateAction" : "update"
+  "updateAction" : "append"
 }
 ```
 
@@ -900,8 +885,8 @@ curl -X POST -H "Content-Type: application/json" -H "Accept: application/json" -
             }
         }
     ],
-    "actionType": "update"
-} ' "https://<platform-ip>:10027/v2/op/update"
+    "actionType": "append"
+} ' "https://<platform-ip>:1026/v2/op/update"
 ```
 
 This update does not modify the original command attribute, but two auxiliary attributes, that are not provided by the
@@ -948,7 +933,7 @@ curl -X POST -H "Content-Type: application/json" -H "Accept: application/json" -
         "switch_info",
         "switch_status"
     ]
-}' "https://<platform-ip>:10027/v2/op/query"
+}' "https://<platform-ip>:1026/v2/op/query"
 ```
 
 The Context Broker replies with all the desired data, in R2 format (200 OK):
@@ -994,8 +979,8 @@ curl -X POST -H "Content-Type: application/json" -H "Accept: application/json" -
             }
         }
     ],
-    "actionType": "update"
-} ' "https://<platform-ip>:10027/v2/op/update"
+    "actionType": "append"
+} ' "https://<platform-ip>:1026/v2/op/update"
 ```
 
 In this case, the Context Broker reply with the following response (200 OK):

package/doc/index.md

@@ -11,8 +11,8 @@ Broker using their own native protocols. IoT Agents should also be able to deal
 platform (authentication and authorization of the channel) and provide other common services to the device programmer.
 
 Github's [README.md](https://github.com/telefonicaid/iotagent-node-lib/blob/master/README.md) provides a good
-documentation summary. The [User Manual](usermanual.md) and the [Admin Guide](installationguide.md) cover more advanced
-topics.
+documentation summary. The [API reference](doc/api.md) and the [Development documentation](devel/development.md) cover
+more advanced topics.
 
 ## Background
 
@@ -26,8 +26,6 @@ functions.
     communications are left to the library.
 -   Standardized OAuth2-based security is available to enable each IoT Agent to connect to several common Identity
     Managers (e.g. Keystone and Keyrock) so that communications can be restricted to trusted components.
--   A series of additional plugins are offered where necessary to allow for expression parsing, attribute aliasing and
-    the processing of timestamp metadata.
 
 Each individual IoT Agent offers is driven by a `config.js` configuration file contains explicit custom settings based
 on the protocol and payload the IoT Agent is translating. It will also contain some common flags for common
@@ -51,5 +49,5 @@ IoT Agent
 In order to use the library within your own IoT Agent, you must first you require it before use:
 
 ```javascript
-const iotagentLib = require("iotagent-node-lib");
+const iotagentLib = require('iotagent-node-lib');
 ```

package/doc/requirements.txt

@@ -1,4 +1,4 @@
 mkdocs==1.2.3
-Pygments==2.9.0
+Pygments==2.15.0
 Markdown==3.3.4
 jinja2==3.0.0

package/docker/Mosquitto/Dockerfile

@@ -1,4 +1,4 @@
-ARG  IMAGE_TAG=11.3-slim
+ARG  IMAGE_TAG=12.1-slim
 FROM debian:${IMAGE_TAG}
 
 ARG CLEAN_DEV_TOOLS

package/docker/Mosquitto/README.md

@@ -2,6 +2,7 @@ Thi directory containts the Dockerfile (and associated files) for a container of
 This container is provide as a help for users to test with MQTT, but it is just an auxiliary material in this repository.
 
 The following releases matches with eclipse-mosquitto version:
+- 2.1.0 uses mosquitto-2.0.11 from Debian 12
 - 2.0.0 uses mosquitto-2.0.11 from Debian 11
 - 1.6.0 uses mosquitto-1.6.10-1.el7.x86_64 (from Centos7)
 - 1.5.0 uses mosquitto-1.6.10-1.el7.x86_64 (from Centos7)

package/lib/commonConfig.js

@@ -149,7 +149,6 @@ function processEnvironmentVariables() {
         'IOTA_MONGO_USER',
         'IOTA_MONGO_RETRY_TIME',
         'IOTA_SINGLE_MODE',
-        'IOTA_APPEND_MODE',
         'IOTA_POLLING_EXPIRATION',
         'IOTA_POLLING_DAEMON_FREQ',
         'IOTA_MULTI_CORE',
@@ -450,10 +449,6 @@ function processEnvironmentVariables() {
         config.singleConfigurationMode = process.env.IOTA_SINGLE_MODE === 'true';
     }
 
-    if (process.env.IOTA_APPEND_MODE) {
-        config.appendMode = process.env.IOTA_APPEND_MODE === 'true';
-    }
-
     if (process.env.IOTA_POLLING_EXPIRATION) {
         config.pollingExpiration = process.env.IOTA_POLLING_EXPIRATION;
     }

package/lib/fiware-iotagent-lib.js

@@ -302,6 +302,7 @@ exports.update = ngsi.update;
 exports.setCommandResult = ngsi.setCommandResult;
 exports.listDevices = deviceService.listDevices;
 exports.getDevice = deviceService.getDevice;
+exports.updateDevice = deviceService.updateDevice;
 exports.getDeviceSilently = deviceService.getDeviceSilently;
 exports.getDeviceByName = deviceService.getDeviceByName;
 exports.getDeviceByNameAndType = deviceService.getDeviceByNameAndType;
@@ -349,7 +350,6 @@ exports.middlewares = middlewares;
 
 exports.dataPlugins = {
     expressionTransformation: require('./plugins/expressionPlugin'),
-    bidirectionalData: require('./plugins/bidirectionalData'),
     utils: require('./plugins/pluginUtils')
 };
 

package/lib/jexlTranformsMap.js

@@ -79,7 +79,8 @@ const map = {
     // https://developer.mozilla.org/es/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleString
     localestring: (d, timezone, options) => new Date(d).toLocaleString(timezone, options),
     now: () => Date.now(),
-    hextostring: (val) => new TextDecoder().decode(new Uint8Array(val.match(/.{1,2}/g).map(byte => parseInt(byte, 16))))
+    hextostring: (val) =>
+        new TextDecoder().decode(new Uint8Array(val.match(/.{1,2}/g).map((byte) => parseInt(byte, 16))))
 };
 
 exports.map = map;

package/lib/model/Device.js

@@ -51,7 +51,6 @@ const Device = new Schema({
     creationDate: { type: Date, default: Date.now },
     internalAttributes: Object,
     autoprovision: Boolean,
-    expressionLanguage: String,
     explicitAttrs: Group.ExplicitAttrsType,
     ngsiVersion: String
 });

package/lib/model/Group.js

@@ -59,7 +59,6 @@ const Group = new Schema({
     attributes: Array,
     internalAttributes: Array,
     autoprovision: Boolean,
-    expressionLanguage: String,
     explicitAttrs: ExplicitAttrsType,
     defaultEntityNameConjunction: String,
     ngsiVersion: String,

package/lib/model/dbConn.js

@@ -106,13 +106,7 @@ function init(host, db, port, options, callback) {
     }
 
     function connectionAttempt(url, options, callback) {
-        logger.info(
-            context,
-            'Attempting to connect to MongoDB instance with url %j and options %j. Attempt %d',
-            url,
-            options,
-            retries
-        );
+        logger.info(context, 'Attempting to connect to MongoDB instance with url %j. Attempt %d', url, retries);
         // FIXME: useNewUrlParser is no longer used in underlying mongodb driver 4.x
         // (see https://github.com/mongodb/node-mongodb-native/blob/HEAD/etc/notes/CHANGES_4.0.0.md)
         // but not sure if current mongoose version is still using mongodb 3.x internally

package/lib/plugins/jexlParser.js

@@ -77,7 +77,7 @@ function extractVariables(expression) {
         variables = tokens.filter(function (token, index, array) {
             return (
                 (token.type === ' ' && array[index - 1].type !== 'dot') ||
-                (token.type === 'identifier' && array[index + 1].type !== 'openParen')
+                (token.type === 'identifier' && array[index + 1] && array[index + 1].type !== 'openParen')
             );
         });
 

package/lib/request-shim.js

@@ -59,7 +59,7 @@ function getOptions(options) {
     // got library is not properly documented, so it is not clear which takes precedence
     // among body, json and form (see https://stackoverflow.com/q/70754880/1485926).
     // Thus, we are enforcing our own precedence with the "else if" chain below.
-    // Behaviour is consistent with the one described at usermanual.md#iotagentlibrequest
+    // Behaviour is consistent with the one described at development.md#iotagentlibrequest
 
     if (options.method === 'GET' || options.method === 'HEAD' || options.method === 'OPTIONS') {
         // Do nothing - Never add a body
@@ -70,7 +70,7 @@ function getOptions(options) {
         // json takes precedence over form
         httpOptions.json = options.json;
     } else if (options.form) {
-        // Note that we don't consider 'form' part of the function API (check usermanual.md#iotagentlibrequest)
+        // Note that we don't consider 'form' part of the function API (check development.md#iotagentlibrequest)
         // but we are preparing the code anyway as a safe measure
         httpOptions.form = options.form;
     }

package/lib/services/commands/commandService.js

@@ -120,7 +120,7 @@ function markAsExpired(command) {
 
     async.waterfall(
         [
-            apply(deviceService.getDevice, command.deviceId, command.service, command.subservice),
+            apply(deviceService.getDevice, command.deviceId, null, command.service, command.subservice),
             getGroup,
             calculateTypeInformation,
             updateExpiredCommand

package/lib/services/common/genericMiddleware.js

@@ -56,7 +56,7 @@ function handleError(error, req, res, next) {
  *  Express middleware for tracing the complete request arriving to the IoTA in debug mode.
  */
 function traceRequest(req, res, next) {
-    logger.debug(context, 'Request for path [%s] from [%s]', req.path, req.get('host'));
+    logger.debug(context, 'Request for path [%s] query [%j] from [%s]', req.path, req.query, req.get('host'));
 
     if (req.is('json') || req.is('application/ld+json')) {
         logger.debug(context, 'Body:\n\n%s\n\n', JSON.stringify(req.body, null, 4));

package/lib/services/common/iotManagerService.js

@@ -58,7 +58,6 @@ function register(callback) {
             timestamp: service.timestamp,
             autoprovision: service.autoprovision,
             explicitAttrs: service.explicitAttrs,
-            expressionLanguage: service.expressionLanguage,
             defaultEntityNameConjunction: service.defaultEntityNameConjunction,
             ngsiVersion: service.ngsiVersion,
             entityNameExp: service.entityNameExp

package/lib/services/devices/deviceRegistryMemory.js

@@ -71,7 +71,7 @@ function storeDevice(newDevice, callback) {
  * @param {String} service      Service of the device to remove.
  * @param {String} subservice   Subservice inside the service for the removed device.
  */
-function removeDevice(id, service, subservice, callback) {
+function removeDevice(id, apikey, service, subservice, callback) {
     const services = Object.keys(registeredDevices);
 
     for (let i = 0; i < services.length; i++) {
@@ -141,7 +141,7 @@ function listDevices(type, service, subservice, limit, offset, callback) {
     });
 }
 
-function getDevice(id, service, subservice, callback) {
+function getDevice(id, apikey, service, subservice, callback) {
     if (registeredDevices[service] && registeredDevices[service][id]) {
         callback(null, registeredDevices[service][id]);
     } else {

package/lib/services/devices/deviceRegistryMongoDB.js

@@ -55,7 +55,6 @@ const attributeList = [
     'polling',
     'timestamp',
     'explicitAttrs',
-    'expressionLanguage',
     'ngsiVersion'
 ];
 
@@ -120,13 +119,15 @@ function storeDevice(newDevice, callback) {
  * @param {String} service      Service of the device to remove.
  * @param {String} subservice   Subservice inside the service for the removed device.
  */
-function removeDevice(id, service, subservice, callback) {
+function removeDevice(id, apikey, service, subservice, callback) {
     const condition = {
         id,
         service,
         subservice
     };
-
+    if (apikey) {
+        condition.apikey = apikey;
+    }
     logger.debug(context, 'Removing device with id [%s]', id);
 
     Device.model.deleteOne(condition, function (error) {
@@ -176,15 +177,15 @@ function listDevices(type, service, subservice, limit, offset, callback) {
         query.skip(parseInt(offset, 10));
     }
 
-    async.series([query.exec.bind(query), Device.model.countDocuments.bind(Device.model, condition)], function (
-        error,
-        results
-    ) {
-        callback(error, {
-            count: results[1],
-            devices: results[0]
-        });
-    });
+    async.series(
+        [query.exec.bind(query), Device.model.countDocuments.bind(Device.model, condition)],
+        function (error, results) {
+            callback(error, {
+                count: results[1],
+                devices: results[0]
+            });
+        }
+    );
 }
 
 function findOneInMongoDB(queryParams, id, callback) {
@@ -212,17 +213,21 @@ function findOneInMongoDB(queryParams, id, callback) {
  * Internal function used to find a device in the DB.
  *
  * @param {String} id           ID of the Device to find.
+ * @param {String} Apikey       Apikey of the Device to find.
  * @param {String} service      Service the device belongs to (optional).
  * @param {String} subservice   Division inside the service (optional).
  */
-function getDeviceById(id, service, subservice, callback) {
-    const queryParams = {
+function getDeviceById(id, apikey, service, subservice, callback) {
+    let queryParams = {
         id,
         service,
         subservice
     };
+    if (apikey) {
+        queryParams.apikey = apikey;
+    }
     context = fillService(context, queryParams);
-    logger.debug(context, 'Looking for device with id [%s].', id);
+    logger.debug(context, 'Looking for device with id [%s] and queryParams [%j].', id, queryParams);
     findOneInMongoDB(queryParams, id, callback);
 }
 
@@ -233,10 +238,17 @@ function getDeviceById(id, service, subservice, callback) {
  * @param {String} service      Service the device belongs to.
  * @param {String} subservice   Division inside the service.
  */
-function getDevice(id, service, subservice, callback) {
-    getDeviceById(id, service, subservice, function (error, data) {
+function getDevice(id, apikey, service, subservice, callback) {
+    getDeviceById(id, apikey, service, subservice, function (error, data) {
         if (error) {
-            callback(error);
+            // Try without apikey: apikey will be added to device later
+            getDeviceById(id, null, service, subservice, function (error, data) {
+                if (error) {
+                    callback(error);
+                } else {
+                    callback(null, data);
+                }
+            });
         } else {
             callback(null, data);
         }
@@ -285,7 +297,7 @@ function getByName(name, service, servicepath, callback) {
  */
 function update(device, callback) {
     logger.debug(context, 'Storing updated values for device [%s]:\n%s', device.id, JSON.stringify(device, null, 4));
-    getDeviceById(device.id, device.service, device.subservice, function (error, data) {
+    getDevice(device.id, device.apikey, device.service, device.subservice, function (error, data) {
         if (error) {
             callback(error);
         } else {
@@ -303,6 +315,7 @@ function update(device, callback) {
             data.registrationId = device.registrationId;
             data.explicitAttrs = device.explicitAttrs;
             data.ngsiVersion = device.ngsiVersion;
+            data.timestamp = device.timestamp;
 
             /* eslint-disable-next-line  new-cap */
             const deviceObj = new Device.model(data);