iotagent-node-lib 2.24.0 → 2.26.0

package/test/unit/ngsi-ld/ngsiService/unsupported-endpoints-test.js

@@ -29,6 +29,7 @@ const iotAgentLib = require('../../../../lib/fiware-iotagent-lib');
 const utils = require('../../../tools/utils');
 const request = utils.request;
 const should = require('should');
+const nock = require('nock');
 
 let contextBrokerMock;
 const iotAgentConfig = {
@@ -47,6 +48,50 @@ const iotAgentConfig = {
     providerUrl: 'http://smartgondor.com'
 };
 
+
+const iotAgentConfigWithLimitedSupport = {
+    contextBroker: {
+        host: '192.168.1.1',
+        port: '1026',
+        ngsiVersion: 'ld',
+        jsonLdContext: 'http://context.json-ld'
+    },
+    server: {
+        port: 4041,
+        ldSupport : {
+           null: false,
+           datasetId: false
+       }
+    },
+    types: {
+        Robot: {
+            commands: [
+                {
+                    name: 'position',
+                    type: 'Array'
+                },
+                {
+                    name: 'orientation',
+                    type: 'Array'
+                }
+            ],
+            lazy: [],
+            staticAttributes: [],
+            active: []
+        }
+    },
+    service: 'smartgondor',
+    subservice: 'gardens',
+    providerUrl: 'http://smartgondor.com'
+};
+
+const device = {
+    id: 'r2d2',
+    type: 'Robot',
+    service: 'smartgondor'
+};
+
+
 describe('NGSI-LD - Unsupported Endpoints', function () {
     beforeEach(function (done) {
         iotAgentLib.activate(iotAgentConfig, function () {
@@ -107,5 +152,131 @@ describe('NGSI-LD - Unsupported Endpoints', function () {
                 done();
             });
         });
+
+
+        it('PUT /entities/<entity-id> includes an NGSI-LD Null should return a valid NSGI-LD error message', function (done) {
+            const options = {
+                url:
+                    'http://localhost:' +
+                    iotAgentConfig.server.port +
+                    '/ngsi-ld/v1/entities/urn:ngsi-ld:entity/attrs/att',
+                method: 'PUT',
+                json: {
+                    "value":  "urn:ngsi-ld:null"
+                },
+                headers: {
+                    'fiware-service': 'smartgondor',
+                    'content-type': 'application/ld+json'
+                }
+            };
+            request(options, function (error, response, body) {
+                response.statusCode.should.equal(400);
+                done();
+            });
+        });
+    });
+});
+
+describe('NGSI-LD - Limiting Support', function () {
+    beforeEach(function (done) {
+        contextBrokerMock = nock('http://192.168.1.1:1026')
+            .matchHeader('fiware-service', 'smartgondor')
+            .post(
+                '/ngsi-ld/v1/csourceRegistrations/',
+                utils.readExampleFile(
+                    './test/unit/ngsi-ld/examples/contextAvailabilityRequests/registerIoTAgentCommands.json'
+                )
+            )
+            .reply(201, null, { Location: '/ngsi-ld/v1/csourceRegistrations/6319a7f5254b05844116584d' });
+
+        contextBrokerMock
+            .matchHeader('fiware-service', 'smartgondor')
+            .post('/ngsi-ld/v1/entityOperations/upsert/')
+            .reply(204);
+
+
+        iotAgentLib.activate(iotAgentConfigWithLimitedSupport, function () {
+            iotAgentLib.clearAll(function () {
+                done();
+            });
+        });
+    });
+
+    afterEach(function (done) {
+        iotAgentLib.clearAll(function () {
+            iotAgentLib.deactivate(done);
+        });
     });
+
+    describe('When sending sending an NGSI-LD Null when nulls are unsupported', function () {
+        it('should return a valid NSGI-LD error message', function (done) {
+            const options = {
+                url:
+                    'http://localhost:' +
+                    iotAgentConfig.server.port +
+                    '/ngsi-ld/v1/entities/urn:ngsi-ld:Robot:r2d2/attrs/position',
+                method: 'PATCH',
+                json: {
+                    "value":  "urn:ngsi-ld:null"
+                },
+                headers: {
+                    'fiware-service': 'smartgondor',
+                    'content-type': 'application/ld+json'
+                }
+            };
+
+            iotAgentLib.setCommandHandler(function (id, type, service, subservice, attributes, callback) {
+                callback(null, {});
+            });
+
+            iotAgentLib.register(device, function (error) {
+                request(options, function (error, response, body) {
+                    response.statusCode.should.equal(400);
+                    done();
+                });
+            });
+
+        });
+    });   
+    describe('When sending a payload including a datasetId when datasetIds are unsupported ', function () {
+        it('should return a valid NSGI-LD error message', function (done) {
+            const options = {
+                url:
+                    'http://localhost:' +
+                    iotAgentConfig.server.port +
+                    '/ngsi-ld/v1/entities/urn:ngsi-ld:Robot:r2d2/attrs/',
+                method: 'PATCH',
+                json: {
+                    position: [
+                        {
+                            type: 'Property',
+                            value: [1, 2, 3],
+                            datasetId: 'urn:ngsi-ld:this'
+                        },
+                        {
+                            type: 'Property',
+                            value: [28, -104, 23],
+                            datasetId: 'urn:ngsi-ld:that'
+                        }
+                    ]
+                },
+                headers: {
+                    'fiware-service': 'smartgondor',
+                    'content-type': 'application/ld+json'
+                }
+            };
+
+            iotAgentLib.setCommandHandler(function (id, type, service, subservice, attributes, callback) {
+                callback(null, {});
+            });
+
+            iotAgentLib.register(device, function (error) {
+                request(options, function (error, response, body) {
+                    response.statusCode.should.equal(400);
+                    done();
+                });
+            });
+
+        });
+    });    
 });

package/test/unit/ngsi-mixed/provisioning/ngsi-versioning-test.js

@@ -65,7 +65,6 @@ const optionsCreationDefault = {
         services: [
             {
                 apikey: 'default-test',
-                cbroker: 'http://orion:1026',
                 entity_type: 'Device',
                 resource: '/iot/default',
                 attributes: [
@@ -90,7 +89,6 @@ const optionsCreationV2 = {
         services: [
             {
                 apikey: 'v2-test',
-                cbroker: 'http://orion:1026',
                 ngsiVersion: 'v2',
                 entity_type: 'Device',
                 resource: '/iot/v2',
@@ -117,7 +115,6 @@ const optionsCreationLD = {
         services: [
             {
                 apikey: 'ld-test',
-                cbroker: 'http://orion:1026',
                 entity_type: 'Device',
                 ngsiVersion: 'ld',
                 resource: '/iot/ld',

package/test/unit/ngsiv2/examples/contextRequests/updateContextMultientityJexlExpressionPlugin1.json

@@ -0,0 +1,22 @@
+{
+  "actionType":"update",
+  "entities":[
+    {
+    "id":"lightPseudo:id",
+    "type":"Light",
+    "pressure":{
+      "type":"Number",
+      "value":60
+      }
+    },
+    {
+      "id":"Ligth:mymulti",
+      "type":"myType",
+      "pressure":{
+          "type":"Number",
+          "value":90
+        }
+
+    }
+  ]
+}

package/test/unit/ngsiv2/expressions/jexlBasedTransformations-test.js

@@ -437,16 +437,31 @@ describe('Java expression language (JEXL) based transformations plugin', functio
         const values = [
             {
                 name: 'p',
-                type: 'centigrades',
-                value: '52'
+                type: 'Number',
+                value: 1040
             }
         ];
 
-        it('should apply the expression before sending the values', function (done) {
+        beforeEach(function () {
+            nock.cleanAll();
+
+            contextBrokerMock = nock('http://192.168.1.1:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .patch(
+                    '/v2/entities/light1/attrs',
+                    utils.readExampleFile(
+                        './test/unit/ngsiv2/examples/contextRequests/updateContextExpressionPlugin30.json'
+                    )
+                )
+                .query({ type: 'Light' })
+                .reply(204);
+        });
+
+        it('should ignore the expression and send the values', function (done) {
             iotAgentLib.update('light1', 'LightError', '', values, function (error) {
-                should.exist(error);
-                error.name.should.equal('INVALID_EXPRESSION');
-                error.code.should.equal(400);
+                should.not.exist(error);
+                contextBrokerMock.done();
                 done();
             });
         });

package/test/unit/ngsiv2/general/deviceService-test.js

@@ -137,7 +137,7 @@ const groupCreation = {
                 apikey: '801230BJKL23Y9090DSFL123HJK09H324HV8732',
                 entity_type: 'TheLightType',
                 trust: '8970A9078A803H3BL98PINEQRW8342HBAMS',
-                cbHost: 'http://unexistentHost:1026',
+                cbHost: 'http://192.168.1.1:1026',
                 commands: [],
                 lazy: [],
                 attributes: [
@@ -187,7 +187,7 @@ describe('NGSI-v2 - Device Service: utils', function () {
             // This mock does not check the payload since the aim of the test is not to verify
             // device provisioning functionality. Appropriate verification is done in tests under
             // provisioning folder
-            contextBrokerMock = nock('http://unexistenthost:1026')
+            contextBrokerMock = nock('http://192.168.1.1:1026')
                 .matchHeader('fiware-service', 'testservice')
                 .matchHeader('fiware-servicepath', '/testingPath')
                 .post('/v2/entities?options=upsert')
@@ -217,7 +217,7 @@ describe('NGSI-v2 - Device Service: utils', function () {
             // This mock does not check the payload since the aim of the test is not to verify
             // device provisioning functionality. Appropriate verification is done in tests under
             // provisioning folder
-            contextBrokerMock = nock('http://unexistenthost:1026')
+            contextBrokerMock = nock('http://192.168.1.1:1026')
                 .matchHeader('fiware-service', 'testservice')
                 .matchHeader('fiware-servicepath', '/testingPath')
                 .post('/v2/entities?options=upsert')
@@ -229,32 +229,34 @@ describe('NGSI-v2 - Device Service: utils', function () {
         });
 
         it('should register the device and return it', function (done) {
-            iotAgentLib.retrieveDevice('UNEXISTENT_DEV', '801230BJKL23Y9090DSFL123HJK09H324HV8732', function (
-                error,
-                device
-            ) {
-                should.not.exist(error);
-                should.exist(device);
+            iotAgentLib.retrieveDevice(
+                'UNEXISTENT_DEV',
+                '801230BJKL23Y9090DSFL123HJK09H324HV8732',
+                function (error, device) {
+                    should.not.exist(error);
+                    should.exist(device);
 
-                device.id.should.equal('UNEXISTENT_DEV');
-                should.exist(device.protocol);
-                device.protocol.should.equal('MQTT_UL');
-                done();
-            });
+                    device.id.should.equal('UNEXISTENT_DEV');
+                    should.exist(device.protocol);
+                    device.protocol.should.equal('MQTT_UL');
+                    done();
+                }
+            );
         });
     });
 
     describe('When an unexisting device tries to be retrieved for an unexisting APIKey', function () {
         it('should raise an error', function (done) {
-            iotAgentLib.retrieveDevice('UNEXISTENT_DEV_AND_GROUP', 'H2332Y909DSF3H346yh20JK092', function (
-                error,
-                device
-            ) {
-                should.exist(error);
-                error.name.should.equal('DEVICE_GROUP_NOT_FOUND');
-                should.not.exist(device);
-                done();
-            });
+            iotAgentLib.retrieveDevice(
+                'UNEXISTENT_DEV_AND_GROUP',
+                'H2332Y909DSF3H346yh20JK092',
+                function (error, device) {
+                    should.exist(error);
+                    error.name.should.equal('DEVICE_GROUP_NOT_FOUND');
+                    should.not.exist(device);
+                    done();
+                }
+            );
         });
     });
 });

package/test/unit/ngsiv2/plugins/multientity-plugin_test.js

@@ -540,6 +540,26 @@ const iotAgentConfig = {
                 }
             ],
             explicitAttrs: '[ "attr1", "attr2" ]'
+        },
+        LightMultiDefault: {
+            commands: [],
+            type: 'Light',
+            lazy: [],
+            active: [
+                {
+                    object_id: 'p',
+                    name: 'pressure',
+                    type: 'Number',
+                    entity_type: 'myType',
+                    entity_name: 'Ligth:mymulti'
+                },
+                {
+                    object_id: 'q',
+                    name: 'pressure',
+                    type: 'Number'
+                }
+            ],
+            expressionLanguage: 'jexl'
         }
     },
     service: 'smartgondor',
@@ -1356,6 +1376,44 @@ describe('NGSI-v2 - Multi-entity plugin', function () {
             });
         }
     );
+
+    describe('When pseudo-multientity device is provisioned (entity_type and default entity_id)', function () {
+        // Case: Expression which results is sent as a new attribute
+        const values = [
+            {
+                name: 'p',
+                type: 'Number',
+                value: 90
+            },
+            {
+                name: 'q',
+                type: 'Number',
+                value: 60
+            }
+        ];
+
+        beforeEach(function () {
+            nock.cleanAll();
+            contextBrokerMock = nock('http://192.168.1.1:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post(
+                    '/v2/op/update',
+                    utils.readExampleFile(
+                        './test/unit/ngsiv2/examples/contextRequests/updateContextMultientityJexlExpressionPlugin1.json'
+                    )
+                )
+                .reply(204);
+        });
+
+        it('should work without invalid expression error', function (done) {
+            iotAgentLib.update('lightPseudo:id', 'LightMultiDefault', '', values, function (error) {
+                should.not.exist(error);
+                contextBrokerMock.done();
+                done();
+            });
+        });
+    });
 });
 
 describe('NGSI-v2 - Multi-entity plugin is executed before timestamp process plugin', function () {

package/test/unit/ngsiv2/provisioning/device-provisioning-api_test.js

@@ -450,7 +450,7 @@ describe('NGSI-v2 - Device provisioning API: Provision devices', function () {
                             apikey: '801230BJKL23Y9090DSFL123HJK09H324HV8732',
                             /*jshint camelcase: false */
                             entity_type: 'MicroLights',
-                            cbroker: 'http://192.168.1.1:1026',
+                            cbHost: 'http://192.168.1.1:1026',
                             explicitAttrs: true
                         }
                     ]
@@ -516,7 +516,7 @@ describe('NGSI-v2 - Device provisioning API: Provision devices', function () {
                             apikey: '801230BJKL23Y9090DSFL123HJK09H324HV8732',
                             /*jshint camelcase: false */
                             entity_type: 'MicroLights',
-                            cbroker: 'http://192.168.1.1:1026',
+                            cbHost: 'http://192.168.1.1:1026',
                             explicitAttrs: true,
                             static_attributes: [
                                 {
@@ -589,7 +589,7 @@ describe('NGSI-v2 - Device provisioning API: Provision devices', function () {
                             apikey: '801230BJKL23Y9090DSFL123HJK09H324HV8732',
                             /*jshint camelcase: false */
                             entity_type: 'MicroLights',
-                            cbroker: 'http://192.168.1.1:1026',
+                            cbHost: 'http://192.168.1.1:1026',
                             explicitAttrs: true
                         }
                     ]
@@ -656,7 +656,7 @@ describe('NGSI-v2 - Device provisioning API: Provision devices', function () {
                             apikey: '801230BJKL23Y9090DSFL123HJK09H324HV8732',
                             /*jshint camelcase: false */
                             entity_type: 'MicroLights',
-                            cbroker: 'http://192.168.1.1:1026',
+                            cbHost: 'http://192.168.1.1:1026',
                             explicitAttrs: true,
                             static_attributes: [
                                 {
@@ -726,7 +726,7 @@ describe('NGSI-v2 - Device provisioning API: Provision devices', function () {
                         /*jshint camelcase: false */
                         entity_type: 'MicroLights',
                         entityNameExp: 'EntityNameByExp',
-                        cbroker: 'http://192.168.1.1:1026'
+                        cbHost: 'http://192.168.1.1:1026'
                     }
                 ]
             },
@@ -790,7 +790,7 @@ describe('NGSI-v2 - Device provisioning API: Provision devices', function () {
                             apikey: '801230BJKL23Y9090DSFL123HJK09H324HV8732',
                             /*jshint camelcase: false */
                             entity_type: 'MicroLights',
-                            cbroker: 'http://192.168.1.1:1026',
+                            cbHost: 'http://192.168.1.1:1026',
                             explicitAttrs: true,
                             static_attributes: [
                                 {
@@ -1385,4 +1385,23 @@ describe('NGSI-v2 - Device provisioning API: Provision devices', function () {
             });
         });
     });
+    describe('When a device provisioning request arrives to the Agent without device_id', function () {
+        const options = {
+            url: 'http://localhost:' + iotAgentConfig.server.port + '/iot/devices',
+            headers: {
+                'fiware-service': 'smartgondor',
+                'fiware-servicepath': '/gardens'
+            },
+            method: 'POST',
+            json: utils.readExampleFile('./test/unit/examples/deviceProvisioningRequests/provisionNewDeviceEmpty.json')
+        };
+
+        it('should return a 400 error', function (done) {
+            request(options, function (error, response, body) {
+                should.not.exist(error);
+                response.statusCode.should.equal(400);
+                done();
+            });
+        });
+    });
 });