iotagent-node-lib 2.23.0 → 2.25.0

package/test/unit/ngsiv2/plugins/bidirectional-plugin_test.js

@@ -237,6 +237,120 @@ describe('NGSI-v2 - Bidirectional data plugin', function () {
             });
         });
 
+        it('should return the transformed values', function (done) {
+            let transformedHandler = false;
+
+            function mockedHandler(device, values, callback) {
+
+                let latitudeFound = false;
+                let longitudeFound = false;
+
+                for (let i = 0; i < values.length; i++) {
+                    if (values[i].name === 'latitude' && values[i].type === 'string' && values[i].value === '-9.6') {
+                        latitudeFound = true;
+                    }
+
+                    if (values[i].name === 'longitude' && values[i].type === 'string' && values[i].value === '12.4') {
+                        longitudeFound = true;
+                    }
+                }
+
+                transformedHandler = values.length >= 2 && longitudeFound && latitudeFound;
+                callback();
+            }
+
+            iotAgentLib.setNotificationHandler(mockedHandler);
+
+            request(options, function (error, response, body) {
+                request(notificationOptions, function (error, response, body) {
+                    contextBrokerMock.done();
+                    transformedHandler.should.equal(true);
+                    done();
+                });
+            });
+        });
+    });
+
+
+    describe('When a notification with metadata arrives for a bidirectional attribute', function () {
+        const notificationOptions = {
+            url: 'http://localhost:' + iotAgentConfig.server.port + '/notify',
+            method: 'POST',
+            json: utils.readExampleFile(
+                './test/unit/ngsiv2/examples/subscriptionRequests/bidirectionalNotificationWithMetadata.json'
+            ),
+            headers: {
+                'fiware-service': 'smartgondor',
+                'fiware-servicepath': '/gardens'
+            }
+        };
+        let executedHandler = false;
+
+        beforeEach(function () {
+            contextBrokerMock
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', '/gardens')
+                .post(
+                    '/v2/subscriptions',
+                    utils.readExampleFile(
+                        './test/unit/ngsiv2/examples/subscriptionRequests/bidirectionalSubscriptionRequest.json'
+                    )
+                )
+                .reply(201, null, { Location: '/v2/subscriptions/51c0ac9ed714fb3b37d7d5a8' });
+
+            contextBrokerMock
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', '/gardens')
+                .post(
+                    '/v2/entities?options=upsert',
+                    utils.readExampleFile('./test/unit/ngsiv2/examples/contextRequests/createBidirectionalDevice.json')
+                )
+                .reply(204);
+        });
+
+        afterEach(function () {
+            iotAgentLib.setNotificationHandler();
+        });
+
+        it('should execute the original handler', function (done) {
+            function mockedHandler(device, notification, callback) {
+
+                notification[0].name.should.equal('location');
+                notification[0].value.should.equal('12.4, -9.6');
+                notification[0].metadata.qos.value.should.equal(1);
+
+                executedHandler = true;
+                callback();
+            }
+
+            iotAgentLib.setNotificationHandler(mockedHandler);
+
+            request(options, function (error, response, body) {
+                request(notificationOptions, function (error, response, body) {
+                    executedHandler.should.equal(true);
+                    contextBrokerMock.done();
+                    done();
+                });
+            });
+        });
+
+        it('should return a 200 OK', function (done) {
+            function mockedHandler(device, notification, callback) {
+                executedHandler = true;
+                callback();
+            }
+
+            iotAgentLib.setNotificationHandler(mockedHandler);
+
+            request(options, function (error, response, body) {
+                request(notificationOptions, function (error, response, body) {
+                    response.statusCode.should.equal(200);
+                    contextBrokerMock.done();
+                    done();
+                });
+            });
+        });
+
         it('should return the transformed values', function (done) {
             let transformedHandler = false;
 
@@ -270,6 +384,7 @@ describe('NGSI-v2 - Bidirectional data plugin', function () {
         });
     });
 
+
     describe('When a new Group provisioning request arrives with bidirectional attributes', function () {
         const provisionGroup = {
             url: 'http://localhost:' + iotAgentConfig.server.port + '/iot/services',

package/test/unit/ngsiv2/plugins/multientity-plugin_test.js

@@ -540,6 +540,26 @@ const iotAgentConfig = {
                 }
             ],
             explicitAttrs: '[ "attr1", "attr2" ]'
+        },
+        LightMultiDefault: {
+            commands: [],
+            type: 'Light',
+            lazy: [],
+            active: [
+                {
+                    object_id: 'p',
+                    name: 'pressure',
+                    type: 'Number',
+                    entity_type: 'myType',
+                    entity_name: 'Ligth:mymulti'
+                },
+                {
+                    object_id: 'q',
+                    name: 'pressure',
+                    type: 'Number'
+                }
+            ],
+            expressionLanguage: 'jexl'
         }
     },
     service: 'smartgondor',
@@ -1356,6 +1376,44 @@ describe('NGSI-v2 - Multi-entity plugin', function () {
             });
         }
     );
+
+    describe('When pseudo-multientity device is provisioned (entity_type and default entity_id)', function () {
+        // Case: Expression which results is sent as a new attribute
+        const values = [
+            {
+                name: 'p',
+                type: 'Number',
+                value: 90
+            },
+            {
+                name: 'q',
+                type: 'Number',
+                value: 60
+            }
+        ];
+
+        beforeEach(function () {
+            nock.cleanAll();
+            contextBrokerMock = nock('http://192.168.1.1:1026')
+                .matchHeader('fiware-service', 'smartgondor')
+                .matchHeader('fiware-servicepath', 'gardens')
+                .post(
+                    '/v2/op/update',
+                    utils.readExampleFile(
+                        './test/unit/ngsiv2/examples/contextRequests/updateContextMultientityJexlExpressionPlugin1.json'
+                    )
+                )
+                .reply(204);
+        });
+
+        it('should work without invalid expression error', function (done) {
+            iotAgentLib.update('lightPseudo:id', 'LightMultiDefault', '', values, function (error) {
+                should.not.exist(error);
+                contextBrokerMock.done();
+                done();
+            });
+        });
+    });
 });
 
 describe('NGSI-v2 - Multi-entity plugin is executed before timestamp process plugin', function () {

package/test/unit/ngsiv2/provisioning/device-provisioning-api_test.js

@@ -450,7 +450,7 @@ describe('NGSI-v2 - Device provisioning API: Provision devices', function () {
                             apikey: '801230BJKL23Y9090DSFL123HJK09H324HV8732',
                             /*jshint camelcase: false */
                             entity_type: 'MicroLights',
-                            cbroker: 'http://192.168.1.1:1026',
+                            cbHost: 'http://192.168.1.1:1026',
                             explicitAttrs: true
                         }
                     ]
@@ -516,7 +516,7 @@ describe('NGSI-v2 - Device provisioning API: Provision devices', function () {
                             apikey: '801230BJKL23Y9090DSFL123HJK09H324HV8732',
                             /*jshint camelcase: false */
                             entity_type: 'MicroLights',
-                            cbroker: 'http://192.168.1.1:1026',
+                            cbHost: 'http://192.168.1.1:1026',
                             explicitAttrs: true,
                             static_attributes: [
                                 {
@@ -589,7 +589,7 @@ describe('NGSI-v2 - Device provisioning API: Provision devices', function () {
                             apikey: '801230BJKL23Y9090DSFL123HJK09H324HV8732',
                             /*jshint camelcase: false */
                             entity_type: 'MicroLights',
-                            cbroker: 'http://192.168.1.1:1026',
+                            cbHost: 'http://192.168.1.1:1026',
                             explicitAttrs: true
                         }
                     ]
@@ -656,7 +656,7 @@ describe('NGSI-v2 - Device provisioning API: Provision devices', function () {
                             apikey: '801230BJKL23Y9090DSFL123HJK09H324HV8732',
                             /*jshint camelcase: false */
                             entity_type: 'MicroLights',
-                            cbroker: 'http://192.168.1.1:1026',
+                            cbHost: 'http://192.168.1.1:1026',
                             explicitAttrs: true,
                             static_attributes: [
                                 {
@@ -726,7 +726,7 @@ describe('NGSI-v2 - Device provisioning API: Provision devices', function () {
                         /*jshint camelcase: false */
                         entity_type: 'MicroLights',
                         entityNameExp: 'EntityNameByExp',
-                        cbroker: 'http://192.168.1.1:1026'
+                        cbHost: 'http://192.168.1.1:1026'
                     }
                 ]
             },
@@ -790,7 +790,7 @@ describe('NGSI-v2 - Device provisioning API: Provision devices', function () {
                             apikey: '801230BJKL23Y9090DSFL123HJK09H324HV8732',
                             /*jshint camelcase: false */
                             entity_type: 'MicroLights',
-                            cbroker: 'http://192.168.1.1:1026',
+                            cbHost: 'http://192.168.1.1:1026',
                             explicitAttrs: true,
                             static_attributes: [
                                 {
@@ -1385,4 +1385,23 @@ describe('NGSI-v2 - Device provisioning API: Provision devices', function () {
             });
         });
     });
+    describe('When a device provisioning request arrives to the Agent without device_id', function () {
+        const options = {
+            url: 'http://localhost:' + iotAgentConfig.server.port + '/iot/devices',
+            headers: {
+                'fiware-service': 'smartgondor',
+                'fiware-servicepath': '/gardens'
+            },
+            method: 'POST',
+            json: utils.readExampleFile('./test/unit/examples/deviceProvisioningRequests/provisionNewDeviceEmpty.json')
+        };
+
+        it('should return a 400 error', function (done) {
+            request(options, function (error, response, body) {
+                should.not.exist(error);
+                response.statusCode.should.equal(400);
+                done();
+            });
+        });
+    });
 });