ioredis 4.28.1 → 4.28.2

package/Changelog.md

@@ -1,3 +1,12 @@
+## [4.28.2](https://github.com/luin/ioredis/compare/v4.28.1...v4.28.2) (2021-12-01)
+
+
+### Bug Fixes
+
+* add Redis campaign ([#1475](https://github.com/luin/ioredis/issues/1475)) ([3f3d8e9](https://github.com/luin/ioredis/commit/3f3d8e9eb868f4e58bb63926d3b683d9892835f2))
+* fix a memory leak with autopipelining. ([#1470](https://github.com/luin/ioredis/issues/1470)) ([f5d8b73](https://github.com/luin/ioredis/commit/f5d8b73c747a0db5cb36e83e6fe022a19a544bd2))
+* unhandled Promise rejections in pipeline.exec [skip ci] ([#1466](https://github.com/luin/ioredis/issues/1466)) ([e5615da](https://github.com/luin/ioredis/commit/e5615da8786956df08a9b33b6cd4dd31e6eaa759))
+
 ## [4.28.1](https://github.com/luin/ioredis/compare/v4.28.0...v4.28.1) (2021-11-23)
 
 

package/README.md

@@ -45,15 +45,23 @@ used in the world's biggest online commerce company [Alibaba](http://www.alibaba
 
 # Sponsors
 
-<a href="https://github.com/sponsors/luin">Become a sponsor!</a>
-
 ### Upstash: Serverless Database for Redis
 
 <a href="https://upstash.com/?utm_source=ioredis"><img align="right" width="320" src="resources/upstash.png" alt="Upstash"></a>
 
 Upstash is a Serverless Database with Redis/REST API and durable storage. It is the perfect database for your applications thanks to its per request pricing and low latency data.
 
-[Start for free in 30 seconds! ](https://upstash.com/?utm_source=ioredis)
+[Start for free in 30 seconds!](https://upstash.com/?utm_source=ioredis)
+
+<br clear="both"/>
+
+### Redis Cloud: From the creators of Redis
+
+<a href="https://redis.info/ioredis-tryfree"><img align="right" width="320" src="resources/redis-tryfree.png" alt="redis-tryfree"></a>
+
+Experience the best Redis. For a limited time, sign up to Redis Enterprise Cloud and use **MATRIX200** to get $200 credits, and a chance to win a Tesla!
+
+[Sign Up Now!](https://redis.info/ioredis-tryfree)
 
 <br clear="both"/>
 
@@ -74,9 +82,7 @@ Medis starts with all the basic features you need:
 
 [Medis 1 is open sourced on GitHub](https://github.com/luin/medis)
 
-### Kuber: Kubernetes Dashboard for iOS
-
-<a href="http://bit.ly/kuber-ios"><img src="resources/kuber.png" alt="Download on the App Store"></a>
+<br clear="both"/>
 
 <hr>
 

package/built/autoPipelining.js

@@ -42,6 +42,10 @@ function executeAutoPipeline(client, slotKey) {
     const pipeline = client._autoPipelines.get(slotKey);
     client._autoPipelines.delete(slotKey);
     const callbacks = pipeline[exports.kCallbacks];
+    // Stop keeping a reference to callbacks immediately after the callbacks stop being used.
+    // This allows the GC to reclaim objects referenced by callbacks, especially with 16384 slots
+    // in Redis.Cluster
+    pipeline[exports.kCallbacks] = null;
     // Perform the call
     pipeline.exec(function (err, results) {
         client._runningAutoPipelines.delete(slotKey);
@@ -139,7 +143,7 @@ function executeWithAutoPipelining(client, functionName, commandName, args, call
         */
         setImmediate(executeAutoPipeline, client, slotKey);
     }
-    // Create the promise which will execute the
+    // Create the promise which will execute the command in the pipeline.
     const autoPipelinePromise = new CustomPromise(function (resolve, reject) {
         pipeline[exports.kCallbacks].push(function (err, value) {
             if (err) {

package/built/pipeline.js

@@ -213,6 +213,12 @@ Pipeline.prototype.execBuffer = util_1.deprecate(function () {
     }
     return execBuffer.apply(this, arguments);
 }, "Pipeline#execBuffer: Use Pipeline#exec instead");
+// NOTE: To avoid an unhandled promise rejection, this will unconditionally always return this.promise,
+// which always has the rejection handled by standard-as-callback
+// adding the provided rejection callback.
+//
+// If a different promise instance were returned, that promise would cause its own unhandled promise rejection
+// errors, even if that promise unconditionally resolved to **the resolved value of** this.promise.
 Pipeline.prototype.exec = function (callback) {
     // Wait for the cluster to be connected, since we need nodes information before continuing
     if (this.isCluster && !this.redis.slots.length) {
@@ -286,16 +292,18 @@ Pipeline.prototype.exec = function (callback) {
     }
     // In cluster mode, always load scripts before running the pipeline
     if (this.isCluster) {
-        return pMap(scripts, (script) => _this.redis.script("load", script.lua), {
+        pMap(scripts, (script) => _this.redis.script("load", script.lua), {
             concurrency: 10,
-        }).then(function () {
+        })
+            .then(function () {
             for (let i = 0; i < scripts.length; i++) {
                 _this.redis._addedScriptHashes[scripts[i].sha] = true;
             }
-            return execPipeline();
-        });
+        })
+            .then(execPipeline, this.reject);
+        return this.promise;
     }
-    return this.redis
+    this.redis
         .script("exists", scripts.map(({ sha }) => sha))
         .then(function (results) {
         const pending = [];
@@ -313,8 +321,9 @@ Pipeline.prototype.exec = function (callback) {
         for (let i = 0; i < scripts.length; i++) {
             _this.redis._addedScriptHashes[scripts[i].sha] = true;
         }
-        return execPipeline();
-    });
+    })
+        .then(execPipeline, this.reject);
+    return this.promise;
     function execPipeline() {
         let data = "";
         let buffers;

package/built/utils/index.js

@@ -97,7 +97,7 @@ function wrapMultiResult(arr) {
 }
 exports.wrapMultiResult = wrapMultiResult;
 /**
- * Detect the argument is a int
+ * Detect if the argument is a int
  *
  * @param {string} value
  * @return {boolean} Whether the value is a int
@@ -174,7 +174,7 @@ exports.timeout = timeout;
  */
 function convertObjectToArray(obj) {
     const result = [];
-    const keys = Object.keys(obj);
+    const keys = Object.keys(obj); // Object.entries requires node 7+
     for (let i = 0, l = keys.length; i < l; i++) {
         result.push(keys[i], obj[keys[i]]);
     }
@@ -188,7 +188,7 @@ exports.convertObjectToArray = convertObjectToArray;
  * @return {array}
  * @example
  * ```js
- * > convertObjectToArray(new Map([[1, '2']]))
+ * > convertMapToArray(new Map([[1, '2']]))
  * [1, '2']
  * ```
  */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ioredis",
-  "version": "4.28.1",
+  "version": "4.28.2",
   "description": "A robust, performance-focused and full-featured Redis client for Node.js.",
   "main": "built/index.js",
   "files": [