ioredis 4.27.7 → 4.27.11

package/Changelog.md

@@ -1,3 +1,32 @@
+## [4.27.11](https://github.com/luin/ioredis/compare/v4.27.10...v4.27.11) (2021-10-11)
+
+
+### Bug Fixes
+
+* make export interface compatible with jest ([#1445](https://github.com/luin/ioredis/issues/1445)) ([2728dbe](https://github.com/luin/ioredis/commit/2728dbe5289ebc8603484bc85c01632cfab98204))
+
+## [4.27.10](https://github.com/luin/ioredis/compare/v4.27.9...v4.27.10) (2021-10-04)
+
+
+### Bug Fixes
+
+* **cluster:** lazyConnect with pipeline ([#1408](https://github.com/luin/ioredis/issues/1408)) ([b798107](https://github.com/luin/ioredis/commit/b798107e4123d0027ef1bdb3319cd00516221f3b))
+
+## [4.27.9](https://github.com/luin/ioredis/compare/v4.27.8...v4.27.9) (2021-08-30)
+
+
+### Bug Fixes
+
+* Fix undefined property warning in executeAutoPipeline ([#1425](https://github.com/luin/ioredis/issues/1425)) ([f898672](https://github.com/luin/ioredis/commit/f898672a29753774eeb6e166c28ed6f548533517))
+* improve proto checking for hgetall [skip ci] ([#1418](https://github.com/luin/ioredis/issues/1418)) ([cba83cb](https://github.com/luin/ioredis/commit/cba83cba2dba25e59ad87c85d740f15f78e45e14))
+
+## [4.27.8](https://github.com/luin/ioredis/compare/v4.27.7...v4.27.8) (2021-08-18)
+
+
+### Bug Fixes
+
+* handle malicious keys for hgetall ([#1416](https://github.com/luin/ioredis/issues/1416)) ([7d73b9d](https://github.com/luin/ioredis/commit/7d73b9d07b52ec077f235292aa15c7aca203bba9)), closes [#1267](https://github.com/luin/ioredis/issues/1267)
+
 ## [4.27.7](https://github.com/luin/ioredis/compare/v4.27.6...v4.27.7) (2021-08-01)
 
 

package/README.md

@@ -578,7 +578,7 @@ redis.get("k3", (err, result) => {
 });
 ```
 
-Another useful example of a reply transformer is one that changes `hgetall` to return array of arrays instead of objects which avoids a unwanted conversation of hash keys to strings when dealing with binary hash keys:
+Another useful example of a reply transformer is one that changes `hgetall` to return array of arrays instead of objects which avoids an unwanted conversation of hash keys to strings when dealing with binary hash keys:
 
 ```javascript
 Redis.Command.setReplyTransformer("hgetall", (result) => {

package/built/autoPipelining.js

@@ -27,6 +27,16 @@ function executeAutoPipeline(client, slotKey) {
     if (client._runningAutoPipelines.has(slotKey)) {
         return;
     }
+    if (!client._autoPipelines.has(slotKey)) {
+        /*
+          Rare edge case. Somehow, something has deleted this running autopipeline in an immediate
+          call to executeAutoPipeline.
+         
+          Maybe the callback in the pipeline.exec is sometimes called in the same tick,
+          e.g. if redis is disconnected?
+        */
+        return;
+    }
     client._runningAutoPipelines.add(slotKey);
     // Get the pipeline and immediately delete it so that new commands are queued on a new pipeline
     const pipeline = client._autoPipelines.get(slotKey);
@@ -90,6 +100,8 @@ function executeWithAutoPipelining(client, functionName, commandName, args, call
     const CustomPromise = PromiseContainer.get();
     // On cluster mode let's wait for slots to be available
     if (client.isCluster && !client.slots.length) {
+        if (client.status === "wait")
+            client.connect().catch(lodash_1.noop);
         return new CustomPromise(function (resolve, reject) {
             client.delayUntilReady((err) => {
                 if (err) {

package/built/command.js

@@ -313,7 +313,21 @@ Command.setReplyTransformer("hgetall", function (result) {
     if (Array.isArray(result)) {
         const obj = {};
         for (let i = 0; i < result.length; i += 2) {
-            obj[result[i]] = result[i + 1];
+            const key = result[i];
+            const value = result[i + 1];
+            if (key in obj) {
+                // can only be truthy if the property is special somehow, like '__proto__' or 'constructor'
+                // https://github.com/luin/ioredis/issues/1267
+                Object.defineProperty(obj, key, {
+                    value,
+                    configurable: true,
+                    enumerable: true,
+                    writable: true,
+                });
+            }
+            else {
+                obj[key] = value;
+            }
         }
         return obj;
     }

package/built/pipeline.js

@@ -8,6 +8,7 @@ const calculateSlot = require("cluster-key-slot");
 const pMap = require("p-map");
 const PromiseContainer = require("./promiseContainer");
 const commander_1 = require("./commander");
+const utils_1 = require("./utils");
 /*
   This function derives from the cluster-key-slot implementation.
   Instead of checking that all keys have the same slot, it checks that all slots are served by the same set of nodes.
@@ -140,7 +141,8 @@ Pipeline.prototype.fillResult = function (value, position) {
                 moved: function (slot, key) {
                     _this.preferKey = key;
                     _this.redis.slots[errv[1]] = [key];
-                    _this.redis._groupsBySlot[errv[1]] = _this.redis._groupsIds[_this.redis.slots[errv[1]].join(";")];
+                    _this.redis._groupsBySlot[errv[1]] =
+                        _this.redis._groupsIds[_this.redis.slots[errv[1]].join(";")];
                     _this.redis.refreshSlotsCache();
                     _this.exec();
                 },
@@ -214,6 +216,8 @@ Pipeline.prototype.execBuffer = util_1.deprecate(function () {
 Pipeline.prototype.exec = function (callback) {
     // Wait for the cluster to be connected, since we need nodes information before continuing
     if (this.isCluster && !this.redis.slots.length) {
+        if (this.redis.status === "wait")
+            this.redis.connect().catch(utils_1.noop);
         this.redis.delayUntilReady((err) => {
             if (err) {
                 callback(err);

package/built/transaction.js

@@ -29,6 +29,8 @@ function addTransactionSupport(redis) {
         pipeline.exec = function (callback) {
             // Wait for the cluster to be connected, since we need nodes information before continuing
             if (this.isCluster && !this.redis.slots.length) {
+                if (this.redis.status === "wait")
+                    this.redis.connect().catch(utils_1.noop);
                 return standard_as_callback_1.default(new Promise((resolve, reject) => {
                     this.redis.delayUntilReady((err) => {
                         if (err) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ioredis",
-  "version": "4.27.7",
+  "version": "4.27.11",
   "description": "A robust, performance-focused and full-featured Redis client for Node.js.",
   "main": "built/index.js",
   "files": [
@@ -76,7 +76,7 @@
     "server-destroy": "^1.0.1",
     "sinon": "^9.0.1",
     "ts-node": "^8.8.1",
-    "typescript": "^3.8.3",
+    "typescript": "3.8.3",
     "uuid": "^8.3.0"
   },
   "engines": {