iobroker.zigbee 3.0.0 → 3.0.1

package/lib/statescontroller.js

@@ -57,23 +57,6 @@ class StatesController extends EventEmitter {
         this.adapter.sendError(error, message);
     }
 
-    TriggerUpload(delay) {
-        if (this.timeoutHandleUpload) return;
-        this.warn('triggering upload')
-        this.timeoutHandleUpload = this.adapter.setTimeout(() => {
-            try {
-                this.warn('executing upload')
-                exec('iobroker upload zigbee', (error, stdout, stderr) => {
-                    if (error) this.error('exec error: ' + JSON.stringify(error));
-                    this.warn('upload done');
-                });
-            }
-            catch (error) {
-                this.error('error on upload exec');
-            }
-        }, delay);
-    }
-
     getStashedErrors() {
         const rv = [];
         try {
@@ -99,7 +82,7 @@ class StatesController extends EventEmitter {
 
     async AddModelFromHerdsman(device, model) {
         // this.warn('addModelFromHerdsman ' + JSON.stringify(model) + ' ' + JSON.stringify(this.localConfig.getOverrideWithKey(model, 'legacy', true)));
-        if (this.localConfig.getOverrideWithKey(model, 'legacy', true)) {
+        if (this.localConfig.getOverrideWithTargetAndKey(model, 'legacy', true)) {
             this.debug('Applying legacy definition for ' + model);
             await this.addLegacyDevice(model);
         }
@@ -296,48 +279,60 @@ class StatesController extends EventEmitter {
                         }
 
                     }
-                    this.collectOptions(id.split('.')[2], model, options =>
+                    this.collectOptions(id.split('.')[2], model, true,  options =>
                         this.publishFromState(deviceId, model, stateKey, state, options, debugId));
                 }
             });
         }
     }
 
-    async collectOptions(devId, model, callback) {
-        const result = {};
-        // find model states for options and get it values. No options for groups !!!
-        const devStates = await this.getDevStates('0x' + devId, model);
-        if (devStates == null || devStates == undefined || devStates.states == null || devStates.states == undefined) {
-            callback(result);
-            return;
-        }
-
-        const states = devStates.states.filter(statedesc => statedesc.isOption || statedesc.inOptions);
-        if (states == null || states == undefined) {
-            callback(result);
-            return;
-        }
-        let cnt = 0;
+    async collectOptions(devId, model, getOptionStates, callback) {
         try {
-            const len = states.length;
-            states.forEach(statedesc => {
-                const id = `${this.adapter.namespace}.${devId}.${statedesc.id}`;
-                this.adapter.getState(id, (err, state) => {
-                    cnt = cnt + 1;
-                    if (!err && state) {
-                        result[statedesc.id] = state.val;
-                    }
-                    if (cnt === len) {
-                        callback(result);
-                    }
-                });
-            });
-            if (!len) {
+            const result = this.localConfig.getOptions(devId);
+            if (!getOptionStates) {
                 callback(result);
+                return;
+            }
+            // find model states for options and get it values. No options for groups !!!
+            const devStates = await this.getDevStates('0x' + devId, model);
+            if (devStates == null || devStates == undefined || devStates.states == null || devStates.states == undefined) {
+                callback(result);
+                return;
+            }
+
+            const states = devStates.states.filter(statedesc => statedesc.isOption || statedesc.inOptions);
+            if (states == null || states == undefined) {
+                callback(result);
+                return;
+            }
+            let cnt = 0;
+            try {
+                const len = states.length;
+                states.forEach(statedesc => {
+                    const id = `${this.adapter.namespace}.${devId}.${statedesc.id}`;
+                    this.adapter.getState(id, (err, state) => {
+                        cnt = cnt + 1;
+                        if (!err && state) {
+                            this.debug(`collect options for ${devId}:  ${JSON.stringify(result)}`);
+                            result[statedesc.id] = state.val;
+                        }
+                        if (cnt === len) {
+                            callback(result);
+                        }
+                    });
+                });
+                if (!len) {
+                    callback(result);
+                }
+            } catch (error) {
+                this.sendError(error);
+                this.error(`Error collectOptions for ${devId}. Error: ${error.stack}`);
             }
-        } catch (error) {
-            this.sendError(error);
-            this.error(`Error collectOptions for ${devId}. Error: ${error.stack}`);
+        }
+        catch (error) {
+            this.error(`Error in collectOptions for ${devId} , ${model} : ${error && error.message ? error.message : 'no message given'}`);
+            callback({});
+
         }
     }
 
@@ -1047,7 +1042,7 @@ class StatesController extends EventEmitter {
 
                         } else {
                             if (statedesc.prepublish) {
-                                this.collectOptions(devId, model, options =>
+                                this.collectOptions(devId, model, false, options =>
                                     statedesc.prepublish(devId, value, newvalue => {
                                         this.updateState(devId, stateID, newvalue, common) }, options)
                                 );
@@ -1088,7 +1083,7 @@ class StatesController extends EventEmitter {
             };
 
             const options = await new Promise((resolve, reject) => {
-                this.collectOptions(devId, model, (options) => {
+                this.collectOptions(devId, model, false, (options) => {
                     resolve(options);
                 });
             });
@@ -1220,10 +1215,15 @@ class StatesController extends EventEmitter {
                 if (cluster !== '64529') {
                     if (has_elevated_debug) this.emit('device_debug', { ID:debugId, data: { error:'EPROC', IO:true }});
                     this.error(`Error while processing converters DEVICE_ID: '${devId}' cluster '${cluster}' type '${type}'`);
+                    this.error(`error message: ${error && error.message ? error.message : ''}`);
                 }
             });
     }
 
+    async stop() {
+        this.localConfig.retainData();
+    }
+
 
 
 }

package/lib/zbDeviceConfigure.js

@@ -155,7 +155,7 @@ class DeviceConfigure extends BaseExtension {
                 if (mappedDevice.configure === undefined) return `No configure available for ${device.ieeeAddr} ${mappedDevice.model}.`;
                 this.info(`Configuring ${device.ieeeAddr} ${mappedDevice.model}`);
                 this.configuring.add(device.ieeeAddr);
-                if (typeof mappedDevice.configure === 'function') await mappedDevice.configure(device, coordinatorEndpoint, this);
+                if (typeof mappedDevice.configure === 'function') await mappedDevice.configure(device, coordinatorEndpoint, mappedDevice);
                 else {
                     const promises = [];
                     promises.push(...mappedDevice.configure);

package/lib/zigbeecontroller.js

@@ -669,6 +669,7 @@ class ZigbeeController extends EventEmitter {
             if (this.HerdsmanStarted) await this.permitJoin(0);
             await this.herdsman.stop();
             this.HerdsmanStarted = false;
+            this.info('zigbecontroller stopped successfully');
         } catch (error) {
             this.sendError(error);
             if (this.herdsmanStarted) {

package/main.js

@@ -809,7 +809,7 @@ class Zigbee extends utils.Adapter {
                         this.emit('device_debug', { ID:debugID, data: { error: 'NOCONV',states:[{id:stateDesc.id, value:value, payload:'no converter'}] , IO:false }, message:message});
                     }
                     else {
-                        this.log.warn(message);
+                        this.log.info(message);
                     }
                     return;
                 }
@@ -1084,12 +1084,13 @@ class Zigbee extends utils.Adapter {
                 debug.log = originalLogMethod;
             }
 
-            this.log.info('cleaned everything up...');
-            if (this.reconnectTimer) clearTimeout(this.reconnectTimer);
+            this.log.info('cleaning everything up...');
             await this.callPluginMethod('stop');
+            await this.stController.stop();
             if (this.zbController) {
                 await this.zbController.stop();
             }
+            this.log.info('cleanup successful');
             callback();
         } catch (error) {
             if (error) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "iobroker.zigbee",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "author": {
     "name": "Kirov Ilya",
     "email": "kirovilya@gmail.com"
@@ -28,8 +28,8 @@
     "ajv": "^8.17.1",
     "uri-js": "^4.4.1",
     "typescript": "^5.6.3",
-    "zigbee-herdsman": "^3.3.2",
-    "zigbee-herdsman-converters": "^23.13.0"
+    "zigbee-herdsman": "3.3.2",
+    "zigbee-herdsman-converters": "23.13.0"
   },
   "description": "Zigbee devices",
   "devDependencies": {