iobroker.telegram-menu 0.6.10 → 0.7.1

package/README.md

@@ -33,6 +33,16 @@ You can create different groups with separate menus, and then assign users to th
 	Placeholder for the next version (at the beginning of the line):
 	### **WORK IN PROGRESS**
 -->
+### 0.7.1 (2023-10-02)
+
+-   bugfix, Error read UserListTypeError: Cannot read properties of undefined
+
+### 0.7.0 (2023-10-01)
+
+-   #53 feature: sendPicture von server-path
+-   #52 icons are missing, copy data
+-   #51 by creating a new Menu, the Users are not shown
+
 ### 0.6.10 (2023-09-23)
 
 -   bug fix

package/admin/index_m.html

@@ -168,9 +168,10 @@
 					addNewGroup(menus, newMenu, _onChange)
 					activeMenu = newMenu
 					showUser(newMenu, showHideUserCheckbox)
-					userListWithChatID = buildUserSelection(valUserFromTelegram, newMenu, usersInMenus)
+					userListWithChatID = buildUserSelection(valUserFromTelegram, [newMenu], usersInMenus)
 					translateAll()
 				}
+
 			})
 			// Delete Btn, open popup		
 			$("#group_menu").on("click", "#deleteUser", function () {
@@ -590,9 +591,13 @@
 				rowToCopy.find("a").parent().remove()
 				const buttonsNav = `<td><a class="deleteRow btn-floating btn-small waves-effect waves-light red"><i	class="material-icons">delete</i></a></td>
     								<td><a class="btn-floating btn-small waves-effect waves-light blue btn_down"><i	class="material-icons" name="down">arrow_downward</i></a></td>
-   									<td><a class="btn-floating btn-small waves-effect waves-light blue btn_up"><i	class="material-icons" name="up">arrow_upward</i></a></td>`
+   									<td><a class="btn-floating btn-small waves-effect waves-light blue btn_up"><i	class="material-icons" name="up">arrow_upward</i></a></td>
+									   <td><a class="btn-floating btn-small waves-effect waves-light green btn_add_row"><i class="material-icons">add</i></a></td>`
 				const buttonsAction = `<td><a class="deleteEveryRow btn-floating btn-small waves-effect waves-light red"><i	class="material-icons">delete</i></a></td>
-										   <td><a data-target="tab_action" class="editEntry modal-trigger btn-floating btn-small waves-effect waves-light green"><i class="material-icons">edit</i></a></td>`;
+										   <td><a data-target="tab_action" class="editEntry modal-trigger btn-floating btn-small waves-effect waves-light green"><i class="material-icons">edit</i></a></td>
+										   <td><a class="btn-floating btn-small waves-effect waves-light blue btn_down"><i	class="material-icons" name="down">arrow_downward</i></a></td>
+										   <td><a class="btn-floating btn-small waves-effect waves-light blue btn_up"><i	class="material-icons" name="up">arrow_upward</i></a></td>							   `;
+
 				if (action == "nav") {
 					rowToCopy.append(buttonsNav)
 					$(`#${activeMenu}`).append(rowToCopy)

package/io-package.json

@@ -1,8 +1,34 @@
 {
   "common": {
     "name": "telegram-menu",
-    "version": "0.6.10",
+    "version": "0.7.1",
     "news": {
+      "0.7.1": {
+        "en": "bugfix, Error read UserListTypeError: Cannot read properties of undefined",
+        "de": "bugfix, Fehler lesen UserListType Fehler: Nicht zu lesen Eigenschaften von undefiniert",
+        "ru": "bugfix, Ошибка читать UserListType Ошибка: Не смогите прочитать свойства неопределенного",
+        "pt": "bugfix, Erro lido UserListType Erro: Não é possível ler propriedades indefinidas",
+        "nl": "error las UserListType Error: Kan niet onbepaalde eigenschappen lezen",
+        "fr": "bugfix, Erreur lire UserListType Erreur: Cannot read properties of undefined",
+        "it": "bugfix, Error read UserListType Errore: Proprietà di lettura non definite",
+        "es": "bugfix, Error leer UserListType Error: No se pueden leer propiedades indefinidas",
+        "pl": "error przeczytał UserListType Error: Cannot czytał właściwości nieokreślone",
+        "uk": "javaScript licenses API Веб-сайт Go1.13.8 Помилка: Не можна прочитати властивості невизначених",
+        "zh-cn": "bugfix, Error读者 rror: 评 注"
+      },
+      "0.7.0": {
+        "en": "#53 feature: sendPicture von server-path\n#52 icons are missing, copy data\n#51 by creating a new Menu, the Users are not shown",
+        "de": "#53 Feature: sendPicture von server-path\n#52 symbole fehlen, kopierdaten\n#51 durch Erstellen eines neuen Menüs, die Benutzer werden nicht angezeigt",
+        "ru": "#53 функция: sendPicture von server-path\n#52 иконки отсутствуют, копирование данных\n#51, создавая новое меню, Пользователи не отображаются",
+        "pt": "Característica #53: sendPicture von server-path\n#52 ícones estão faltando, copiar dados\n#51 criando um novo Menu, os Usuários não são mostrados",
+        "nl": "Vertaling:\n52 iconen ontbreken\nQuality over Quantity (QoQ) Releases Vertaling:",
+        "fr": "#53 fonction: sendPicture von server-path\n#52 icônes sont manquantes, données de copie\n#51 en créant un nouveau menu, les Utilisateurs ne sont pas affichés",
+        "it": "#53 caratteristica: sendPicture von server-path\n#52 icone mancanti, copia dati\n#51 creando un nuovo menu, gli utenti non vengono mostrati",
+        "es": "función #53: sendPicture von server-path\n#52 iconos faltan, copiar datos\n#51 mediante la creación de un nuevo Menú, los Usuarios no se muestran",
+        "pl": "#53: Wysyłanie serwera\nzaginęło 52 ikony\n#51 poprzez stworzenie nowego Menu, Użytkownicy nie zostali przedstawieni",
+        "uk": "#53 Функція: sendPicture фон сервер-path\n#52 іконки відсутні, копіювання даних\n#51 шляхом створення нового меню Користувачі не показані",
+        "zh-cn": "#53 特色:寄电器\n第52条 遗漏,复印数据\n第51号活动是创建一个新的男子,用户没有证明。"
+      },
       "0.6.10": {
         "en": "bug fix",
         "de": "fehlerbehebung",
@@ -67,32 +93,6 @@
         "pl": "info-big.png",
         "uk": "javascript licenses api веб-сайт go1.13.8",
         "zh-cn": "增 编"
-      },
-      "0.6.5": {
-        "en": "get user by chatID and send back to this chatID",
-        "de": "benutzer per chatID ermitteln und  zurück senden an diese chatID",
-        "ru": "получить пользователя по чатID и отправить обратно в этот чатID",
-        "pt": "obter usuário por chatID e enviar de volta para este chatID",
-        "nl": "haal gebruiker van chatID en stuur terug naar dit chatID",
-        "fr": "obtenir utilisateur par chatID et renvoyer à ce chatID",
-        "it": "ottenere l'utente da chatID e tornare a questo chatID",
-        "es": "obtener usuario por chatID y enviar de nuevo a este chatID",
-        "pl": "użytkowanie przez czat i wysyłane do tego czatID",
-        "uk": "отримати користувач по chatID і відправити назад в цей чатID",
-        "zh-cn": "被混乱者利用,然后再送给这一混乱的裁研所。"
-      },
-      "0.6.4": {
-        "en": "Trigger check, used triggers are no longer available in action, in nav it is visualized that the trigger is already in use",
-        "de": "Trigger-Check, verwendete Trigger sind nicht mehr in Aktion, in nav wird visualisiert, dass der Trigger bereits im Einsatz ist",
-        "ru": "Проверка Trigger, используемые триггеры больше не доступны в действии, в nav визуализируется, что триггер уже используется",
-        "pt": "Verificação de gatilho, gatilhos usados não estão mais disponíveis em ação, nav é visualizado que o gatilho já está em uso",
-        "nl": "Trigger controle, gebruikte triggers zijn niet meer beschikbaar in actie, in Nav is het gevisualiseerd dat de trekker al gebruikt is",
-        "fr": "Trigger check, triggers utilisés ne sont plus disponibles en action, dans nav il est visualisé que le trigger est déjà en service",
-        "it": "Controllo del trigger, i trigger utilizzati non sono più disponibili in azione, in nav è visualizzato che il trigger è già in uso",
-        "es": "Comprobación del desencadenante, los disparadores usados ya no están disponibles en acción, en nav se visualiza que el gatillo ya está en uso",
-        "pl": "Kontrola Triggera nie jest już dostępna w akcji, w nav jest wizualizowana, że wyzwalanie jest już w użyciu",
-        "uk": "Перевірка тригера, використовувані тригери більше не доступні в дії, в нав він візуалізований, що тригер вже в використанні",
-        "zh-cn": "突然的检查不再可供采取行动,在无知的情况下,触发者已经使用。"
       }
     },
     "titleLang": {

package/lib/js/action.js

@@ -1,8 +1,10 @@
 const sendToTelegram = require("./telegram").sendToTelegram;
+const Utils = require("./global");
 /**
- *
- * @param {string} textToSend
- * @param {string} val
+ * Calculates Value with the Value in {math:} from textToSend
+ * @param {string} textToSend Text to send to user
+ * @param {string} val Value to calculate with
+ * @returns {object} textToSend and val
  */
 function calcValue(_this, textToSend, val) {
 	const startindex = textToSend.indexOf("{math");
@@ -19,33 +21,29 @@ function calcValue(_this, textToSend, val) {
 }
 
 /**
- *
+ * Exchange Value with other Value
  * @param {String} textToSend Text which should be send to user
+ * @param {String} stateVal Value to exchange
+ * @param {*} _this
+ * @returns {object} valueChange and textToSend
  */
 function exchangeValue(textToSend, stateVal, _this) {
 	const startindex = textToSend.indexOf("change{");
 	const match = textToSend.substring(startindex + "change".length + 1, textToSend.indexOf("}", startindex));
 	let objChangeValue;
-	if (isJSON("{" + match + "}")) objChangeValue = JSON.parse("{" + match + "}");
+	if (Utils.isJSON("{" + match + "}")) objChangeValue = JSON.parse("{" + match + "}");
 	else {
-		_this.log.error(`There is a error in your input: ` + JSON.stringify(match.replace(/"/g, "'")));
+		_this.log.error(`There is a error in your input: ` + JSON.stringify(Utils.replaceAll(match, '"', "'")));
 		return false;
 	}
 	return { valueChange: objChangeValue[String(stateVal)], textToSend: textToSend.substring(0, startindex) };
 }
-function isJSON(str) {
-	try {
-		JSON.parse(str);
-		return true;
-	} catch (error) {
-		return false;
-	}
-}
+
 /**
  * Generate Array
- * @param {*} val
+ * @param {object[]} val
  * @param {*} _this
- * @returns
+ * @returns  Arrays with Buttons
  */
 async function editArrayButtons(val, _this) {
 	try {
@@ -76,10 +74,10 @@ async function editArrayButtons(val, _this) {
 /**
  *
  * @param {*} _this
- * @param {string} selector
- * @param {*} text
- * @param {*} userToSend
- * @param {*} newline
+ * @param {string} selector Selector
+ * @param {string} text Text to send
+ * @param {string} userToSend User to send
+ * @param {string} newline Newline
  */
 const idBySelector = async (
 	_this,
@@ -122,7 +120,7 @@ const idBySelector = async (
 								text2Send += " " + value.val;
 							}
 						}
-						if (newline == "true" || newline == true) text2Send += "\n";
+						if (newline == "true") text2Send += "\n";
 						else text2Send += " ";
 						_this.log.debug("text2send " + JSON.stringify(text2Send));
 					});
@@ -156,7 +154,8 @@ const idBySelector = async (
 /**
  *
  * @param {*} _this
- * @param {array} val
+ * @param {array} val Array with Objects
+ * @returns Object with new Structure
  */
 async function generateNewObjectStructure(_this, val) {
 	try {
@@ -176,9 +175,10 @@ async function generateNewObjectStructure(_this, val) {
 }
 
 /**
- *
+ *	Generate Actions
  * @param {object} action Object with Actions
- * @param {*} userObject Object from User with generated Navigation
+ * @param {object} userObject Object from User with generated Navigation
+ * @returns {object} Object with Actions and IDs
  */
 function generateActions(_this, action, userObject) {
 	try {
@@ -223,7 +223,6 @@ function generateActions(_this, action, userObject) {
 			});
 		});
 		action.pic.forEach(function (element, key) {
-			_this.log.debug("Pic ");
 			userObject[element.trigger] = { sendPic: [] };
 			if (key == 0) userObject[element.trigger] = { sendPic: [] };
 			element.IDs.forEach(function (id, key) {

package/lib/js/getstate.js

@@ -3,6 +3,16 @@ const idBySelector = require("./action").idBySelector;
 const exchangeValue = require("./action").exchangeValue;
 const calcValue = require("./action").calcValue;
 
+/**
+ * 	Get the state of the id and send it to the user
+ * @param {*} _this
+ * @param {object} part Part of the Menu
+ * @param {string} userToSend User to send the message to
+ * @param {string} telegramInstance Instance to send the message to
+ * @param {boolean} one_time_keyboard
+ * @param {boolean} resize_keyboard
+ * @param {object} userListWithChatID Userlist with ChatID
+ */
 function getstate(_this, part, userToSend, telegramInstance, one_time_keyboard, resize_keyboard, userListWithChatID) {
 	try {
 		let text = "";

package/lib/js/global.js

@@ -0,0 +1,34 @@
+/**
+ * Removes duplicate entries and saves the result
+ * @param {string[]} arr Array
+ * @returns Array with unique entrys
+ */
+function deleteDoubleEntrysInArray(arr, _this) {
+	return arr.filter((item, index) => arr.indexOf(item) === index);
+}
+
+/**
+ * Replaces all searchValue with replaceValue in text
+ * @param {string} text Text to replace the searchValue with replaceValue
+ * @param {string} searchValue Value to search for
+ * @param {string} replaceValue Value to replace the searchValue with
+ * @returns
+ */
+function replaceAll(text, searchValue, replaceValue) {
+	return text.replace(new RegExp(searchValue, "g"), replaceValue);
+}
+/**
+ * Checks if _string is JSON
+ * @param {string} _string
+ * @returns {boolean} Returns True if _string is JSON else False
+ */
+function isJSON(_string) {
+	try {
+		JSON.parse(_string);
+		return true;
+	} catch (error) {
+		return false;
+	}
+}
+
+module.exports = { deleteDoubleEntrysInArray, replaceAll, isJSON };

package/lib/js/setstate.js

@@ -1,3 +1,12 @@
+/**
+ * Sets the state
+ * @param {*} _this
+ * @param {object} part Part of the menu
+ * @param {string} userToSend User to send the message to
+ * @param {number} valueFromSubmenu Value from the submenu
+ * @param {boolean} SubmenuValuePriority If true the value from the submenu will be used else the value from the switch
+ * @returns Returns an array with the ids to set
+ */
 function setstate(_this, part, userToSend, valueFromSubmenu, SubmenuValuePriority) {
 	try {
 		const setStateIds = [];

package/lib/js/subMenu.js

@@ -7,14 +7,14 @@ const backMenu = {};
 /**
  *
  * @param {*} _this
- * @param {string} text
- * @param {*} groupData
- * @param {string} userToSend
- * @returns
+ * @param {string} part
+ * @param {{}} groupData - Data of the group
+ * @param {string} userToSend - user to send the message to
+ * @returns []
  */
 function subMenu(
 	_this,
-	text,
+	part,
 	groupData,
 	userToSend,
 	instanceTelegram,
@@ -22,13 +22,13 @@ function subMenu(
 	one_time_keyboard,
 	userListWithChatID,
 ) {
-	const splittetText = JSON.stringify(text).split(`"`)[1].split(":");
+	const splittetText = part.split(`"`)[1].split(":");
 	const callbackData = splittetText[1];
 	let device2Switch = splittetText[2];
 	_this.log.debug("callbackData: 	" + JSON.stringify(callbackData));
 	_this.log.debug("splittet Data of callbackData " + JSON.stringify(splittetText[1]));
 	_this.log.debug("devicetoswitch: 	" + JSON.stringify(device2Switch));
-	_this.log.debug("text: 	" + JSON.stringify(text));
+	_this.log.debug("text: 	" + JSON.stringify(part));
 
 	//ANCHOR -  Switch
 
@@ -77,7 +77,7 @@ function subMenu(
 	}
 
 	//ANCHOR - Percent
-	else if (!text.includes("submenu") && callbackData.includes("percent")) {
+	else if (!part.includes("submenu") && callbackData.includes("percent")) {
 		step = parseInt(callbackData.replace("percent", ""));
 		let rowEntrys = 0;
 		let menu = [];
@@ -106,15 +106,15 @@ function subMenu(
 		if (rowEntrys != 0) keyboard.inline_keyboard.push(menu);
 
 		return ["Welcher Wert soll gesetzt werden?", JSON.stringify(keyboard), device2Switch];
-	} else if (text.includes(`submenu:percent${step}`)) {
-		const value = parseInt(text.split(":")[1].split(",")[1]);
+	} else if (part.includes(`submenu:percent${step}`)) {
+		const value = parseInt(part.split(":")[1].split(",")[1]);
 
 		const result = setstate(_this, groupData[device2Switch], userToSend, value, true);
 		if (Array.isArray(result)) returnIDToListenTo = result;
 		return [null, null, null, returnIDToListenTo];
 
 		//ANCHOR - Number
-	} else if (!text.includes("submenu") && callbackData.includes("number")) {
+	} else if (!part.includes("submenu") && callbackData.includes("number")) {
 		const splittedData = callbackData.replace("number", "").split("-");
 		let rowEntrys = 0;
 		let menu = [];
@@ -157,9 +157,9 @@ function subMenu(
 		if (rowEntrys != 0) keyboard.inline_keyboard.push(menu);
 		_this.log.debug("keyboard " + JSON.stringify(keyboard.inline_keyboard));
 		return ["Welcher Wert soll gesetzt werden?", JSON.stringify(keyboard), device2Switch];
-	} else if (text.includes(`submenu:${callbackData}`)) {
-		const value = parseInt(text.split(":")[2]);
-		device2Switch = text.split(":")[3];
+	} else if (part.includes(`submenu:${callbackData}`)) {
+		const value = parseInt(part.split(":")[2]);
+		device2Switch = part.split(":")[3];
 		_this.log.debug(
 			JSON.stringify({ device2Switch: device2Switch, data: groupData, user: userToSend, value: value }),
 		);

package/lib/js/telegram.js

@@ -18,44 +18,57 @@ function sendToTelegram(
 	one_time_keyboard = true,
 	userListWithChatID,
 ) {
-	_this.log.debug("Send this Value : " + JSON.stringify(value));
-	_this.log.debug("Send this to : " + JSON.stringify(user));
-	_this.log.debug("Instance : " + JSON.stringify(instance));
-	let chatId = "";
-	userListWithChatID.forEach((element) => {
-		if (element.name === user) chatId = element.chatID;
-	});
-	if (keyboard.length == 0) {
-		_this.sendTo(
-			instance,
-			"send",
-			{
-				text: value,
-				chatId: chatId,
-			},
-			function (res) {
-				console.log("Sent Value to " + res + " users!");
-			},
-		);
-	} else {
-		_this.sendTo(
-			instance,
-			"send",
-			{
-				chatId: chatId,
-				text: value,
-				reply_markup: {
-					keyboard: keyboard,
-					resize_keyboard: resize_keyboard,
-					one_time_keyboard: one_time_keyboard,
+	try {
+		_this.log.debug("Send this Value : " + JSON.stringify(value));
+		_this.log.debug("Send this to : " + JSON.stringify(user));
+		_this.log.debug("Instance : " + JSON.stringify(instance));
+		let chatId = "";
+		userListWithChatID.forEach((element) => {
+			if (element.name === user) chatId = element.chatID;
+		});
+		if (keyboard.length == 0) {
+			_this.sendTo(
+				instance,
+				"send",
+				{
+					text: value,
+					chatId: chatId,
+				},
+				function (res) {
+					console.log("Sent Value to " + res + " users!");
+				},
+			);
+		} else {
+			_this.sendTo(
+				instance,
+				"send",
+				{
+					chatId: chatId,
+					text: value,
+					reply_markup: {
+						keyboard: keyboard,
+						resize_keyboard: resize_keyboard,
+						one_time_keyboard: one_time_keyboard,
+					},
 				},
-			},
-			function (res) {
-				console.log("Sent to " + res + " users");
-			},
-		);
+				function (res) {
+					console.log("Sent to " + res + " users");
+				},
+			);
+		}
+	} catch (e) {
+		_this.log.error("Error sendToTelegram: " + JSON.stringify(e));
 	}
 }
+/**
+ *
+ * @param {*} _this
+ * @param {string} user Username
+ * @param {string} text Text to send
+ * @param {*} keyboard
+ * @param {*} instance
+ * @param {*} userListWithChatID
+ */
 function sendToTelegramSubmenu(_this, user, text, keyboard, instance = "telegram.0", userListWithChatID) {
 	try {
 		let chatId = "";

package/main.js

@@ -19,6 +19,7 @@ const getstate = require("./lib/js/getstate").getstate;
 const subMenu = require("./lib/js/subMenu").subMenu;
 const backMenuFuc = require("./lib/js/subMenu").backMenuFuc;
 const sendToTelegramSubmenu = require("./lib/js/telegram").sendToTelegramSubmenu;
+const Utils = require("./lib/js/global");
 
 let timeouts = [];
 let timeoutKey = 0;
@@ -58,21 +59,20 @@ class TelegramMenu extends utils.Adapter {
 		const one_time_keyboard = checkbox["oneTiKey"];
 		const resize_keyboard = checkbox["resKey"];
 		const checkboxNoEntryFound = checkbox["checkboxNoValueFound"];
-		const listofGroups = this.config.users;
+		const listofMenus = this.config.users;
 		const startsides = this.config.startsides;
-		let token = this.config.tokenGrafana;
+		const token = this.config.tokenGrafana;
 		const directoryPicture = this.config.directory;
 		const userActiveCheckbox = this.config.userActiveCheckbox;
 		const groupsWithUsers = this.config.usersInGroup;
 		const textNoEntryFound = this.config.textNoEntry;
 		const userListWithChatID = this.config.userListWithChatID;
-		const menu = {
+		const menuData = {
 			data: {},
 		};
 		const _this = this;
 		this.getForeignObject(datapoint, async (err, obj) => {
 			if (err || obj == null) {
-				// Error
 				this.log.error(JSON.stringify(err));
 				this.log.error(`The State ${datapoint} was not found!`);
 			} else {
@@ -80,7 +80,7 @@ class TelegramMenu extends utils.Adapter {
 				try {
 					telegramState = await this.getForeignStateAsync(datapoint);
 				} catch (e) {
-					this.log.debug("Error " + JSON.stringify(e));
+					this.log.error("Error getForeignState: " + JSON.stringify(e));
 				}
 				telegramAktiv = telegramState?.val;
 				if (!telegramAktiv) {
@@ -99,17 +99,18 @@ class TelegramMenu extends utils.Adapter {
 					try {
 						for (const name in nav) {
 							const value = await editArrayButtons(nav[name], this);
-							menu.data[name] = await generateNewObjectStructure(_this, value);
-							this.log.debug("New Structure: " + JSON.stringify(menu.data[name]));
-							const returnValue = generateActions(_this, action[name], menu.data[name]);
-							menu.data[name] = returnValue?.obj;
+							if (value) menuData.data[name] = await generateNewObjectStructure(_this, value);
+							this.log.debug("New Structure: " + JSON.stringify(menuData.data[name]));
+							const returnValue = generateActions(_this, action[name], menuData.data[name]);
+							menuData.data[name] = returnValue?.obj;
 							subscribeForeignStateIds = returnValue?.ids;
-							if (subscribeForeignStateIds && subscribeForeignStateIds?.length > 0)
-								_subscribeForeignStatesAsync(subscribeForeignStateIds, _this);
 							this.log.debug("SubscribeForeignStates: " + JSON.stringify(subscribeForeignStateIds));
+							if (subscribeForeignStateIds && subscribeForeignStateIds?.length > 0) {
+								_subscribeForeignStatesAsync(subscribeForeignStateIds, _this);
+							} else this.log.debug("Nothing to Subscribe!");
 							this.log.debug("Menu: " + JSON.stringify(name));
 							this.log.debug("Array Buttons: " + JSON.stringify(value));
-							this.log.debug("Gen. Actions: " + JSON.stringify(menu.data[name]));
+							this.log.debug("Gen. Actions: " + JSON.stringify(menuData.data[name]));
 						}
 					} catch (err) {
 						this.log.error("Error generateNav: " + JSON.stringify(err));
@@ -117,27 +118,32 @@ class TelegramMenu extends utils.Adapter {
 					this.log.debug("Checkbox " + JSON.stringify(checkbox));
 
 					try {
-						this.log.debug("MenuList: " + JSON.stringify(listofGroups));
-						listofGroups.forEach((group) => {
-							this.log.debug("Menu: " + JSON.stringify(group));
-							const startside = [startsides[group]].toString();
-							if (userActiveCheckbox[group] && startside != "-") {
+						this.log.debug("MenuList: " + JSON.stringify(listofMenus));
+						listofMenus.forEach((menu) => {
+							this.log.debug("Menu: " + JSON.stringify(menu));
+							const startside = [startsides[menu]].toString();
+							if (userActiveCheckbox[menu] && startside != "-") {
 								this.log.debug("Startseite: " + JSON.stringify(startside));
-								groupsWithUsers[group].forEach((user) => {
+								groupsWithUsers[menu].forEach((user) => {
 									backMenuFuc(this, startside, null, user);
 									this.log.debug("User List " + JSON.stringify(userListWithChatID));
+
 									sendToTelegram(
 										_this,
 										user,
-										menu.data[group][startside].text,
-										menu.data[group][startside].nav,
+										menuData.data[menu][startside].text,
+										menuData.data[menu][startside].nav,
 										instanceTelegram,
 										resize_keyboard,
 										one_time_keyboard,
 										userListWithChatID,
 									);
 								});
-							}
+							} else
+								this.log.debug(
+									"Menu inactive or is Submenu. " +
+										JSON.stringify({ active: userActiveCheckbox[menu], startside: startside }),
+								);
 						});
 					} catch (error) {
 						this.log.error("Error read UserList" + error);
@@ -183,9 +189,9 @@ class TelegramMenu extends utils.Adapter {
 								this.log.debug("Groups with searched User " + JSON.stringify(groups));
 								let dataFound = false;
 								for (const group of groups) {
-									const groupData = menu.data[group];
+									const groupData = menuData.data[group];
 									this.log.debug("Nav: " + JSON.stringify(groupData));
-									this.log.debug("Menu: " + JSON.stringify(menu.data));
+									this.log.debug("Menu: " + JSON.stringify(menuData.data));
 									this.log.debug("Group: " + JSON.stringify(group));
 
 									if (processData(this, groupData, calledValue, userToSend, group)) {
@@ -293,7 +299,7 @@ class TelegramMenu extends utils.Adapter {
 					_this.log.debug("Menu to Send: " + JSON.stringify(part.nav));
 					backMenuFuc(_this, calledValue, part.nav, userToSend);
 					if (JSON.stringify(part.nav).includes("menu")) {
-						callSubMenu(_this, part.nav, groupData, userToSend);
+						callSubMenu(_this, JSON.stringify(part.nav), groupData, userToSend);
 						return true;
 					} else {
 						if (userToSend) {
@@ -314,7 +320,7 @@ class TelegramMenu extends utils.Adapter {
 				}
 				// Schalten
 				else if (part.switch) {
-					setStateIdsToListenTo = setstate(_this, part, userToSend);
+					setStateIdsToListenTo = setstate(_this, part, userToSend, 0, false);
 
 					_this.log.debug("SubmenuData3" + JSON.stringify(setStateIdsToListenTo));
 					if (Array.isArray(setStateIdsToListenTo))
@@ -332,36 +338,40 @@ class TelegramMenu extends utils.Adapter {
 					);
 					return true;
 				} else if (part.sendPic) {
-					try {
-						_this.log.debug("Send Picture");
+					_this.log.debug("Send Picture");
 
-						part.sendPic.forEach((element) => {
-							// this.log.debug("Element " + JSON.stringify(element));
-							token = token.trim();
+					part.sendPic.forEach((element) => {
+						let path = "";
+						if (element.id != "-") {
 							const url = element.id;
-							const newUrl = url.replace(/&/g, "&");
-							exec(
-								`curl -H "Authorisation: Bearer ${token}" "${newUrl}" > ${directoryPicture}${element.fileName}`,
-								(error, stdout, stderr) => {
-									if (stdout) {
-										_this.log.debug("Stdout: " + JSON.stringify(stdout));
-									}
-									if (stderr) {
-										_this.log.debug("Stderr: " + JSON.stringify(stderr));
-									}
-									if (error) {
-										_this.log.error("Ein Fehler ist aufgetreten: " + JSON.stringify(error));
-										return;
-									}
-								},
-							);
+							const newUrl = Utils.replaceAll(url, "&", "&");
+							try {
+								exec(
+									`curl -H "Authorisation: Bearer ${token.trim()}" "${newUrl}" > ${directoryPicture}${
+										element.fileName
+									}`,
+									(error, stdout, stderr) => {
+										if (stdout) {
+											_this.log.debug("Stdout: " + JSON.stringify(stdout));
+										}
+										if (stderr) {
+											_this.log.debug("Stderr: " + JSON.stringify(stderr));
+										}
+										if (error) {
+											_this.log.error("Ein Fehler ist aufgetreten: " + JSON.stringify(error));
+											return;
+										}
+									},
+								);
+							} catch (e) {
+								_this.log.error("Error :" + JSON.stringify(e));
+							}
 
-							_this.log.debug(
-								"url " +
-									`curl -H "Authorisation: Bearer ${token}" "${newUrl}" > ${directoryPicture}${element.fileName}`,
-							);
+							_this.log.debug("Delay Time " + JSON.stringify(element.delay));
 							timeoutKey += 1;
-							const path = `${directoryPicture}${element.fileName}`;
+							path = `${directoryPicture}${element.fileName}`;
+						} else path = element.fileName;
+						try {
 							const timeout = _this.setTimeout(async () => {
 								_this.log.debug("Send Pic to Telegram");
 								sendToTelegram(
@@ -379,13 +389,17 @@ class TelegramMenu extends utils.Adapter {
 								timeoutToClear = timeouts.filter((item) => item.key == timeoutKey);
 								clearTimeout(timeoutToClear.timeout);
 								timeouts = timeouts.filter((item) => item.key !== timeoutKey);
-							}, element.delay);
+							}, parseInt(element.delay));
+							_this.log.debug("Timeout add");
 							timeouts.push({ key: timeoutKey, timeout: timeout });
-						});
-						return true;
-					} catch (e) {
-						_this.log.error("Error :" + JSON.stringify(e));
-					}
+						} catch (e) {
+							_this.log.error("Error: " + JSON.stringify(e));
+						}
+					});
+
+					_this.log.debug("Picture sended");
+
+					return true;
 				}
 			} else if (calledValue.startsWith("menu") || calledValue.startsWith("submenu")) {
 				callSubMenu(_this, calledValue, groupData, userToSend);
@@ -397,8 +411,8 @@ class TelegramMenu extends utils.Adapter {
 		/**
 		 *
 		 * @param {*} _this
-		 * @param {*} part
-		 * @param {*} groupData
+		 * @param {string} part
+		 * @param {{}} groupData
 		 * @param {string} userToSend
 		 */
 		function callSubMenu(_this, part, groupData, userToSend) {
@@ -419,7 +433,7 @@ class TelegramMenu extends utils.Adapter {
 				if (subMenuData[3]) setStateIdsToListenTo = subMenuData[3];
 				_subscribeAndUnSubscribeForeignStatesAsync(setStateIdsToListenTo, _this, true);
 			}
-			if (subMenuData && subMenuData[0]) {
+			if (subMenuData && typeof subMenuData[0] == "string") {
 				sendToTelegramSubmenu(
 					_this,
 					userToSend,
@@ -433,25 +447,17 @@ class TelegramMenu extends utils.Adapter {
 
 		/**
 		 *
-		 * @param {*} array
+		 * @param {string[]} array
 		 * @param {*} _this
 		 */
 		function _subscribeForeignStatesAsync(array, _this) {
-			array = deleteDoubleEntrysInArray(array);
-			_this.log.debug("array " + JSON.stringify(array));
+			array = Utils.deleteDoubleEntrysInArray(array, _this);
+			_this.log.debug("Subscribe all States of: " + JSON.stringify(array));
 			array.forEach((element) => {
-				_this.log.debug("Subscribe State: " + JSON.stringify(element));
 				_this.subscribeForeignStatesAsync(element);
 			});
 		}
-		/**
-		 * Removes duplicate entries and saves the result
-		 * @param {[]} arr Array
-		 * @returns Array with unique entrys
-		 */
-		function deleteDoubleEntrysInArray(arr) {
-			return arr.filter((item, index) => arr.indexOf(item) === index);
-		}
+
 		/**
 		 *
 		 * @param {any[]} array

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "iobroker.telegram-menu",
-  "version": "0.6.10",
+  "version": "0.7.1",
   "description": "Easily create Telegram Menus",
   "author": {
     "name": "MiRo1310",
@@ -34,22 +34,24 @@
     "@types/chai": "^4.3.5",
     "@types/chai-as-promised": "^7.1.5",
     "@types/jquery": "^3.5.16",
-    "@types/mocha": "^10.0.1",
+    "@types/mocha": "^10.0.2",
     "@types/node": "^20.3.3",
-    "@types/proxyquire": "^1.3.28",
+    "@types/proxyquire": "^1.3.29",
     "@types/sinon": "^10.0.15",
-    "@types/sinon-chai": "^3.2.9",
+    "@types/sinon-chai": "^3.2.10",
     "chai": "^4.3.7",
     "chai-as-promised": "^7.1.1",
-    "eslint": "^8.48.0",
+    "eslint": "^8.50.0",
     "eslint-config-prettier": "^9.0.0",
-    "eslint-plugin-prettier": "^4.2.1",
+    "eslint-plugin-prettier": "^5.0.0",
     "mocha": "^10.2.0",
     "prettier": "^3.0.3",
     "proxyquire": "^2.1.3",
     "sinon": "^15.2.0",
     "sinon-chai": "^3.7.0",
-    "typescript": "~5.2.2"
+    "typescript": "~5.2.2",
+    "chalk": "^5.3.0",
+    "inquirer": "^9.2.11"
   },
   "main": "main.js",
   "files": [
@@ -70,7 +72,8 @@
     "lint": "eslint .",
     "translate": "translate-adapter",
     "release": "release-script",
-    "lint:fix": "eslint . --fix"
+    "lint:fix": "eslint . --fix",
+    "checker": "node skript.mjs"
   },
   "bugs": {
     "url": "https://github.com/MiRo1310/ioBroker.telegram-menu/issues"