iobroker.sun2000 2.3.2 → 2.3.3

package/README.md

@@ -65,6 +65,11 @@ browse in the [wiki](https://github.com/bolliy/ioBroker.sun2000/wiki)
 	Placeholder for the next version (at the beginning of the line):
 	### **WORK IN PROGRESS**
 -->
+### 2.3.3 (2025-10-31)
+* Improved verification of the adapter configuration
+* new state `inverter.x.derived.dailyActiveEnergy` Inverter daily active energy, which is determined via the Riemann sum of `inverter.x.activePower`
+* state `collected.dailyInputYield` was redisigned based on inverter.[0..n-1].derived.dailyActiveEnergy
+
 ### 2.3.2 (2025-10-24)
 * allows again `control.battery.chargeFromGridFunction` when using the Emma
 

package/admin/jsonConfig.json5

@@ -263,8 +263,20 @@
                 },
                 "chipsTxt1": {
                     "type": "staticText",
-                    "text": "This control is set in the opject path `sun2000.0.inverter.x.control.battery`",
+                    "text": "This control states are set in the object path `sun2000.0.inverter.x.control.battery`",
+                    "newLine": true,
+                    "hidden": "data.integration === 2",
+                    "xs": 12,
+                    "sm": 12,
+                    "md": 6,
+                    "lg": 4,
+                    "xl": 4
+                },
+                "chipsTxt1_1": {
+                    "type": "staticText",
+                    "text": "This control states are set in the object path `sun2000.0.emma.control.battery`",
                     "newLine": true,
+                    "hidden": "data.integration !== 2",
                     "xs": 12,
                     "sm": 12,
                     "md": 6,
@@ -275,7 +287,7 @@
                     "type": "checkbox",
                     "label": "Create default TOU setting",
                     "newLine": true,
-                    "help": "The `default TOU settings` is interesting for the `force battery charging from the grid` function, which is required for variable energy prices.",
+                    "help": "The `default TOU settings` is interesting for the `charge from the grid` function, which is required for variable energy prices.",
                     "xs": 12,
                     "sm": 12,
                     "md": 6,
@@ -287,6 +299,7 @@
                     "text": "Description with examples",
                     "href": "https://github.com/bolliy/ioBroker.sun2000/wiki/Battery-control",
                     "button": true,
+                    "hidden": "data.integration === 2",
                     "icon": "info",
                     "newLine": true,
                     "xs": 12,
@@ -295,6 +308,20 @@
                     "lg": 3,
                     "xl": 3
                 },
+                "staticLink1_1": {
+                    "type": "staticLink",
+                    "text": "Description with examples",
+                    "href": "https://github.com/bolliy/ioBroker.sun2000/wiki/Emma:-Battery-control",
+                    "button": true,
+                    "hidden": "data.integration !== 2",
+                    "icon": "info",
+                    "newLine": true,
+                    "xs": 12,
+                    "sm": 12,
+                    "md": 6,
+                    "lg": 3,
+                    "xl": 3
+                },          
                 "mainHdr2": {
                     "newLine": true,
                     "type": "header",
@@ -328,12 +355,14 @@
                     "newLine": true,
                     "type": "header",
                     "text": "Export control",
+                    "hidden": "data.integration === 2",
                     "size": 2
                 },
                 "chipsTxt3": {
                     "type": "staticText",
                     "text": "This control is set in the opject path `sun2000.0.inverter.0.control.grid`",
                     "newLine": true,
+                    "hidden": "data.integration === 2",
                     "xs": 12,
                     "sm": 12,
                     "md": 6,
@@ -344,6 +373,7 @@
                     "type": "staticLink",
                     "text": "Description with examples",
                     "href": "https://github.com/bolliy/ioBroker.sun2000/wiki/Begrenzung-Netzeinspeisung-(Export-Control)",
+                    "hidden": "data.integration === 2",
                     "button": true,
                     "icon": "info",
                     "newLine": true,

package/io-package.json

@@ -1,8 +1,21 @@
 {
   "common": {
     "name": "sun2000",
-    "version": "2.3.2",
+    "version": "2.3.3",
     "news": {
+      "2.3.3": {
+        "en": "Improved verification of the adapter configuration\nnew state `inverter.x.derived.dailyActiveEnergy` Inverter daily active energy, which is determined via the Riemann sum of `inverter.x.activePower`\nstate `collected.dailyInputYield` was redisigned based on inverter.[0..n-1].derived.dailyActiveEnergy",
+        "de": "Verbesserte Überprüfung der Adapterkonfiguration\n`inverter.x.derived.dailyActiveEnergy` Inverter tägliche aktive Energie, die über die Riemann Summe von `inverter.x.activePower bestimmt wird `\nstate `collected.dailyInputYield` wurde basierend auf Inverter zurückgeteilt. [0.n-1].derived.dailyActiveEnergy",
+        "ru": "Улучшенная проверка конфигурации адаптера\nновое состояние «inverter.x.derived.dailyActiveEnergy» Инверторная ежедневная активная энергия, которая определяется через сумму Римана 'inverter.x.activePower пункт\nstate 'collected.dailyInputYield' была переопределена на основе инвертора. [0..n-1].derived.dailyActiveEnergy",
+        "pt": "Verificação melhorada da configuração do adaptador\nnovo estado «inverter.x.derived.dailyActiveEnergy» Energia ativa diária do inversor, que é determinada através da soma Riemann de `inverter.x.activePower `\nestado `colleted.dailyInputYield` foi reassinado com base no inversor. [0..n-1].derivado.diárioAtividadeEnergia",
+        "nl": "Verbeterde verificatie van de configuratie van de adapter\nnieuwe staat  Inverter dagelijkse actieve energie, die wordt bepaald via de Riemann som van  Wat\nstaat  [0..n-1].afgeleid.dailyActiveEnergy",
+        "fr": "Amélioration de la vérification de la configuration de l'adaptateur\nnouvel état `inverter.x.derived.dailyActiveEnergy` Inverter l'énergie active quotidienne, qui est déterminée par la somme Riemann de `inverter.x.activePower \"\nl'état `collected.dailyInputYield` a été résigné sur la base de l'onduleur. Énergie active",
+        "it": "Verifica migliorata della configurazione dell'adattatore\nnuovo stato `inverter.x.derived.dailyActiveEnergy` Inverter energia attiva quotidiana, che è determinata tramite la somma Riemann di `inverter.x.activePower #\nstato `collect.dailyInputYield` è stato ridisegnato sulla base di inverter. [0.n-1]",
+        "es": "Mejor verificación de la configuración del adaptador\nnuevo estado `inverter.x.derived.dailyActiveEnergy` Inverter energía activa diaria, que se determina a través de la suma Riemann de `inverter.x.activePower `\nestado `colected.dailyInputYield` fue redisigned basado en inverter. [0.n-1].derived.dailyActiveEnergy",
+        "pl": "Ulepszona weryfikacja konfiguracji adaptera\nnowy stan 'inverter.x.derived.dailyActiveEnergy' Inwerter dzienna aktywna energia, która jest określana za pomocą sumy Riemann 'inverter.x.activePower'\nstan 'collected.dailyInputYield' został wycofany na podstawie inwertera. [0.. n-1] .derived.dailyActiveEnergy",
+        "uk": "Покращена перевірка конфігурації адаптера\nновий стан `inverter.x.derived.dailyActiveEnergy` Інверторна щоденна активна енергія, яка визначається за рахунок `inverter.x.activePower й\n`collected.dailyInputYield` був перерахований на основі інвертора. [0..n-1].derived.dailyActiveEnergy",
+        "zh-cn": "改进适配器配置的核查\n新州`反转器.x.衍生的每日能源 ' 每日反转活性能量,通过`反转器.x.activePower的Riemann总和确定 `\ndaily InputYield)根据反差重新签名。 [0.n-1]. 衍生的每日能源"
+      },
       "2.3.2": {
         "en": "allows again `control.battery.chargeFromGridFunction` when using the Emma",
         "de": "erlaubt wieder `control.battery.chargeFromGridFunction` bei Verwendung der Emma",
@@ -80,19 +93,6 @@
         "pl": "aktualizacje zależności i konfiguracji\nfix: dostosować wartości graniczne dla zdarzeń w oparciu o wartość użytkową Parametry nadwyżki\nfix: wartości rejestru swap dla zużycia energii w sterowniku Emma # 190\nemma: ulepszenie obliczania mocy przy zastosowaniu wykładniczej średniej ruchomej w EmmaCharger\naktualizacja definicji nadwyżek energii elektrycznej i deprecjacja starych identyfikatorów",
         "uk": "оновлення залежності та конфігурації\nвиправити: регулювати ліміти значення події на основі Параметри Surplus\nвиправити: значення swap для споживання енергії в машині Емма #190\nемма: поліпшення розрахунку потужності з постійним рухомим середнім в ЕммаКхаргер\nоновлення надлишок визначення стану живлення та депресувати старі ідентифікатори",
         "zh-cn": "依赖和配置更新\n固定:根据可用值调整事件值限制 盈余参数\n修补: Emma 驱动器中用电量的交换记录值 # 190\nemma: 改进电量计算, 以 Emmacourer 中的指数移动平均值\n更新剩余电源状态定义并折旧旧标识符"
-      },
-      "2.1.0": {
-        "en": "emma: system time is being determined [#179](https://github.com/bolliy/ioBroker.sun2000/issues/179)\ncontrol: add grid power scheduling functionality to inverter driver [#176](https://github.com/bolliy/ioBroker.sun2000/issues/176)",
-        "de": "emma: Die Systemzeit wird bestimmt [#179](https://github.com/bolliy/ioBroker.sun2000/issues/179)\nsteuerung: Netz-Leistungs-Scheduling-Funktionalität zum Wechselrichtertreiber hinzufügen [#176](https://github.com/bolliy/ioBroker.sun2000/issues/176)",
-        "ru": "emma: системное время определяется [#179] (https://github.com/bolliy/ioBroker.sun2000/issues/179)\nуправление: добавьте функцию планирования мощности сети к драйверу инвертора [#176] (https://github.com/bolliy/ioBroker.sun2000/issues/176)",
-        "pt": "emma: tempo do sistema está sendo determinado [#179](https://github.com/bolliy/ioBroker.sun2000/issues/179)\ncontrol: add grid power screaming functionality to inverter driver [#176](https://github.com/bolliy/ioBroker.sun2000/issues/176)",
-        "nl": "emma: de systeemtijd wordt bepaald [#179](https://github.com/bolliy/ioBroker.sun2000/issues/179)\ncontrole: voeg net stroom planning functionaliteit aan omvormer driver [#176](https://github.com/bolliy/ioBroker.sun2000/issues/176)",
-        "fr": "emma: le temps du système est déterminé [#179](https://github.com/bolliy/ioBroker.sun2000/issues/179)\ncontrôle: ajouter la fonctionnalité de programmation du réseau au pilote d'onduleur [#176](https://github.com/bolliy/ioBroker.sun2000/issues/176)",
-        "it": "emma: il tempo di sistema viene determinato [#179](https://github.com/bolliy/ioBroker.sun2000/issues/179)\ncontrollo: aggiungere funzionalità di programmazione della griglia al driver inverter [#176](https://github.com/bolliy/ioBroker.sun2000/issues/176)",
-        "es": "emma: El tiempo del sistema se determina [#179](https://github.com/bolliy/ioBroker.sun2000/issues/179)\ncontrol: añadir funcionalidad de programación de energía de red al controlador inverter [#176](https://github.com/bolliy/ioBroker.sun2000/issues/176)",
-        "pl": "emma: ustala się czas systemowy [# 179] (https: / / github.com / bolliy / ioBroker.sun2000 / issues / 179)\ncontrol: add grid Power Scheduling Functional to inverter driver [# 176] (https: / / github.com / bolliy / ioBroker.sun2000 / issues / 176)",
-        "uk": "emma: час системи визначається [#179](https://github.com/bolliy/ioBroker.sun2000/products/179)\ncontrol: add power scheduling features to inverter драйвер [#176](https://github.com/bolliy/ioBroker.sun2000/issues/176)",
-        "zh-cn": "emma:系统时间正在确定 [# 179] (https://github.com/bolliy/ioBroker.sun2000/issues/179)\n控制:向反向驱动器添加电网电源调度功能[#176](https://github.com/bolliy/ioBroker.sun2000/issues/1976)"
       }
     },
     "titleLang": {

package/lib/drivers/driver_inverter.js

@@ -100,6 +100,14 @@ class InverterSun2000 extends DriverBase {
 			}
 		});
 
+		//
+		this.activePowerSum = new RiemannSum();
+		this.adapter.getState(`${this.deviceInfo.path}.derived.dailyActiveEnergy`, (err, state) => {
+			if (!err && state) {
+				this.activePowerSum.setStart(state.val, state.ts);
+			}
+		});
+
 		this.control = new ServiceQueueMap(this.adapter, this.deviceInfo);
 
 		//https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md
@@ -149,7 +157,7 @@ class InverterSun2000 extends DriverBase {
 				postHook: () => {
 					if (!this._testMode) return;
 
-					this.log.debug('### PostHook for InverterSun2000');
+					this.log.debug('### TEST MODE - PostHook for InverterSun2000 ####');
 					this.identifySubdevices('sun2000', this.modbusId)
 						.then(ret => {
 							this.log.debug(`### PostHook for InverterSun2000 - ret: ${JSON.stringify(ret)}`);
@@ -190,6 +198,11 @@ class InverterSun2000 extends DriverBase {
 						store: storeType.always,
 					},
 				],
+				postHook: path => {
+					//calculate daily active energy
+					const activePower = this.stateCache.get(`${path}activePower`)?.value ?? 0;
+					this.activePowerSum.add(activePower); //riemann Sum
+				},
 			},
 			{
 				address: 37765,
@@ -1489,14 +1502,7 @@ class InverterSun2000 extends DriverBase {
 					const activePower = this.stateCache.get(`${path}activePower`)?.value ?? 0;
 					if (Math.abs(activePower - inputPower + chargePower) > 0) {
 						this.log.debug(`activePower ${activePower} !== inputPower ${inputPower}-chargePower ${chargePower}`);
-						this.stateCache.set(`${path}activePower`, inputPower - chargePower, { type: 'number' });
-						/*
-						if (chargePower === 0) {
-							this.stateCache.set(`${path}activePower`, inputPower - chargePower, { type: 'number' });
-						} else {
-							this.stateCache.set(`${path}battery.chargeDischargePower`, inputPower - activePower, { type: 'number' });
-						}
-						*/
+						//this.stateCache.set(`${path}activePower`, inputPower - chargePower, { type: 'number' });
 					}
 				},
 			},
@@ -1508,17 +1514,18 @@ class InverterSun2000 extends DriverBase {
 					type: 'number',
 					unit: 'kWh',
 					role: 'value.power.consumption',
-					desc: 'Try to recreate the yield from the portal',
+					desc: 'yield from the portal',
 				},
 				fn: path => {
-					const disCharge = this.stateCache.get(`${path}battery.currentDayDischargeCapacity`)?.value;
-					const charge = this.stateCache.get(`${path}battery.currentDayChargeCapacity`)?.value;
-					let inputYield = this.stateCache.get(`${path}dailyEnergyYield`)?.value * 0.97 + charge - disCharge;
-
-					if (inputYield < 0 || isNaN(inputYield)) {
-						inputYield = 0;
+					const disCharge = this.stateCache.get(`${path}battery.currentDayDischargeCapacity`)?.value ?? 0;
+					const charge = this.stateCache.get(`${path}battery.currentDayChargeCapacity`)?.value ?? 0;
+					//let inputYield = this.stateCache.get(`${path}dailyEnergyYield`)?.value ?? 0 * 0.97 + charge - disCharge;
+					const activeEnergy = this.stateCache.get(`${path}derived.dailyActiveEnergy`)?.value ?? 0;
+					let inYield = activeEnergy + (charge - disCharge) * 0.97; //efficiency loss of battery 3%
+					if (inYield < 0) {
+						inYield = 0;
 					}
-					this.stateCache.set(`${path}derived.dailyInputYield`, inputYield, { type: 'number' });
+					this.stateCache.set(`${path}derived.dailyInputYield`, inYield, { type: 'number' });
 				},
 			},
 			{
@@ -1535,6 +1542,20 @@ class InverterSun2000 extends DriverBase {
 					this.stateCache.set(`${path}derived.dailySolarYield`, this.solarSum.sum, { type: 'number' });
 				},
 			},
+			{
+				refresh: dataRefreshRate.low,
+				state: {
+					id: 'derived.dailyActiveEnergy',
+					name: 'Active Energy today',
+					type: 'number',
+					unit: 'kWh',
+					role: 'value.power.consumption',
+					desc: 'Amount of Riemann sum of sum of active power',
+				},
+				fn: path => {
+					this.stateCache.set(`${path}derived.dailyActiveEnergy`, this.activePowerSum.sum, { type: 'number' });
+				},
+			},
 		];
 		this.postUpdateHooks.push.apply(this.postUpdateHooks, newHooks);
 	}
@@ -1638,6 +1659,7 @@ class InverterSun2000 extends DriverBase {
 
 	async mitnightProcess() {
 		this.solarSum.reset();
+		this.activePowerSum.reset();
 	}
 }
 

package/lib/register.js

@@ -31,7 +31,7 @@ class Registers {
 						type: 'number',
 						unit: 'kW',
 						role: 'value.power',
-						desc: '',
+						desc: 'Power from solar with efficiency loss',
 					},
 					{
 						id: 'collected.chargeDischargePower',
@@ -66,7 +66,6 @@ class Registers {
 						desc: 'Power from solar minus house consumption and usable battery power',
 					},
 					{ id: 'collected.externalPower', name: 'external power', type: 'number', unit: 'kW', role: 'value.power' },
-					//{ id: 'collected.ratedPower', name: 'rated power', type: 'number', unit: 'kW', role: 'value.power' },
 				],
 				fn: inverters => {
 					let actPower = 0;
@@ -99,7 +98,7 @@ class Registers {
 							}
 
 							if (soc > minSoc) {
-								// charge power is positive
+								// charge power is positive - Battery is charging
 								if (chargeDischarge > 0) surplusPower += chargeDischarge;
 
 								if (bufferSoc === 0 || soc < bufferSoc + threshold) {
@@ -149,13 +148,11 @@ class Registers {
 						inPowerEff += this.stateCache.get(`${inverter.path}.derived.inputPowerWithEfficiencyLoss`)?.value ?? 0;
 						chargeDischarge += this.stateCache.get(`${inverter.path}.battery.chargeDischargePower`)?.value ?? 0;
 						ratedPower += this.stateCache.get(`${inverter.path}.info.ratedPower`)?.value ?? 0;
-						//maxChargePower = this.stateCache.get(`${inverter.path}.battery.maximumChargingPower`)?.value ?? 0;
 					}
 
 					const feedinPower = this.stateCache.get('meter.derived.feed-inPower')?.value ?? 0;
 
 					const extPower = this.adapter.control.get('externalPower')?.value ?? 0;
-					//extPower = extPower / 1000;
 
 					//Zu geringe Erzeugerenegie
 					let houseConsum = actPower - feedinPower + extPower;
@@ -192,15 +189,15 @@ class Registers {
 						type: 'number',
 						unit: 'kWh',
 						role: 'value.power.consumption',
-						desc: 'daily output yield of the inverters',
+						desc: 'daily energy yield of the inverters',
 					},
 					{
 						id: 'collected.dailyInputYield',
-						name: 'Daily portal yield',
+						name: 'Daily input yield',
 						type: 'number',
 						unit: 'kWh',
 						role: 'value.power.consumption',
-						desc: 'Try to recreate the yield from the portal',
+						desc: 'yield from the portal',
 					},
 					{
 						id: 'collected.dailySolarYield',
@@ -237,12 +234,23 @@ class Registers {
 					},
 					{ id: 'collected.SOC', name: 'State of battery capacity', type: 'number', unit: '%', role: 'value.battery', desc: 'SOC' },
 					{ id: 'collected.ratedCapacity', name: 'Rated of battery capacity', type: 'number', unit: 'Wh', role: 'value.capacity' },
+					/*
+					{
+						id: 'collected.dailyActiveEnergy',
+						name: 'Active Energy today',
+						type: 'number',
+						unit: 'kWh',
+						role: 'value.power.consumption',
+						desc: 'Amount of Riemann sum of sum of active power',
+					},
+					*/
 				],
 				fn: inverters => {
 					let inYield = 0;
 					let solarYield = 0;
 					let outYield = 0;
 					let enYield = 0;
+					let activeEnergy = 0;
 					let charge = 0;
 					let disCharge = 0;
 					let totalDisCharge = 0;
@@ -256,10 +264,11 @@ class Registers {
 						if (inverter.driverClass != driverClasses.inverter) {
 							continue;
 						}
-						outYield += this.stateCache.get(`${inverter.path}.dailyEnergyYield`)?.value;
+						outYield += this.stateCache.get(`${inverter.path}.dailyEnergyYield`)?.value ?? 0;
 						inYield += this.stateCache.get(`${inverter.path}.derived.dailyInputYield`)?.value;
 						solarYield += this.stateCache.get(`${inverter.path}.derived.dailySolarYield`)?.value;
 						enYield += this.stateCache.get(`${inverter.path}.accumulatedEnergyYield`)?.value;
+						activeEnergy += this.stateCache.get(`${inverter.path}.derived.dailyActiveEnergy`)?.value ?? 0;
 						if (this.stateCache.get(`${inverter.path}.battery.ratedCapacity`)?.value > 0) {
 							charge += this.stateCache.get(`${inverter.path}.battery.currentDayChargeCapacity`)?.value ?? 0;
 							disCharge += this.stateCache.get(`${inverter.path}.battery.currentDayDischargeCapacity`)?.value ?? 0;
@@ -271,7 +280,7 @@ class Registers {
 							ratedCap += this.stateCache.get(`${inverter.path}.battery.ratedCapacity`)?.value;
 						}
 					}
-
+					//this.stateCache.set('collected.dailyActiveEnergy', activeEnergy, { type: 'number' });
 					this.stateCache.set('collected.dailyEnergyYield', outYield, { type: 'number' });
 					this.stateCache.set('collected.dailyInputYield', inYield, { type: 'number' }); //deprecated
 					this.stateCache.set('collected.dailySolarYield', solarYield, { type: 'number' });
@@ -286,6 +295,7 @@ class Registers {
 						feedinEnergy = this.stateCache.get('meter.positiveActiveEnergy')?.value ?? 0;
 						supplyFromGrid = this.stateCache.get('meter.reverseActiveEnergy')?.value ?? 0;
 					}
+					//stimmt leider nicht genau - bleibt aber erstmal bestehen
 					const conSum = enYield + supplyFromGrid - feedinEnergy;
 					this.stateCache.set('collected.consumptionSum', conSum, { type: 'number' });
 					// compute export and import today
@@ -295,11 +305,19 @@ class Registers {
 					this.stateCache.set('collected.gridImportToday', supplyFromGrid - this.stateCache.get('collected.gridImportStart')?.value, {
 						type: 'number',
 					});
+					/* old computation of consumption today
 					this.stateCache.set(
 						'collected.consumptionToday',
 						this.stateCache.get('collected.consumptionSum')?.value - this.stateCache.get('collected.consumptionStart')?.value,
 						{ type: 'number' },
 					);
+					*/
+					//new computation of consumption today
+					this.stateCache.set(
+						'collected.consumptionToday',
+						activeEnergy + this.stateCache.get('collected.gridImportToday')?.value - this.stateCache.get('collected.gridExportToday')?.value,
+						{ type: 'number' },
+					);
 					//compute battery
 					this.stateCache.set('collected.totalCharge', totalCharge, { type: 'number' });
 					this.stateCache.set('collected.totalDischarge', totalDisCharge, { type: 'number' });
@@ -415,6 +433,7 @@ class Registers {
 		this.stateCache.set('collected.gridImportStart', state?.val, { type: 'number', stored: true });
 		state = await this.adapter.getState('collected.consumptionStart');
 		this.stateCache.set('collected.consumptionStart', state?.val, { type: 'number', stored: true });
+		//this.stateCache.set('collected.consumptionStart', 100000, { type: 'number', stored: true });
 	}
 
 	//state

package/main.js

@@ -379,7 +379,7 @@ class Sun2000 extends utils.Adapter {
 		await this.setState('info.modbusDelay', { val: this.config.delay, ack: true });
 		await this.setState('info.modbusTcpServer', { val: this.config.ms_active, ack: true });
 		// Load user settings
-		if (this.config.address != '' && this.config.port > 0 && this.config.modbusIds != '' && this.config.updateInterval > 0) {
+		if (this.config.address != '' && this.config.port > 0 && this.config.updateInterval > 0) {
 			this.settings.address = this.config.address;
 			this.settings.port = this.config.port;
 			this.settings.modbusTimeout = this.config.timeout; //ms
@@ -421,67 +421,72 @@ class Sun2000 extends utils.Adapter {
 			} else {
 				await this.setState('info.JSONhealth', { val: '{message : "Information is collected"}', ack: true });
 			}
-
-			if (this.settings.modbusIds.length > 0 && this.settings.modbusIds.length < 6) {
-				//ES6 use a for (const [index, item] of array.entries()) of loop
-				for (const [i, id] of this.settings.modbusIds.entries()) {
-					this.devices.push({
-						index: i,
-						duration: 5000,
-						modbusId: id,
-						driverClass: driverClasses.inverter,
-						meter: i == 0 && this.settings.integration === 0,
-					});
-				}
-
-				//SDongle
-				if (this.settings.integration === 0 && this.settings.sd.active) {
-					this.devices.push({
-						index: 0,
-						duration: 0,
-						modbusId: this.settings.sd.sDongleId,
-						driverClass: driverClasses.sdongle,
-					});
+			//future: if (this.settings.integration !== 2 && (this.settings.modbusIds.length === 0 || this.settings.modbusIds.length > 5)) {
+			if (this.settings.modbusIds.length === 0 || this.settings.modbusIds.length > 5) {
+				this.adapterDisable(`*** Adapter deactivated, inverter modbus Ids is invalid! ***`);
+				return;
+			}
+			//ES6 use a for (const [index, item] of array.entries()) of loop
+			for (const [i, id] of this.settings.modbusIds.entries()) {
+				//Inverter
+				if (id < 1 || id >= 250) {
+					this.adapterDisable(`*** Adapter deactivated, inverter modbus Id ${id} is not permitted! ***`);
+					return;
 				}
+				this.devices.push({
+					index: i,
+					duration: 5000,
+					modbusId: id,
+					driverClass: driverClasses.inverter,
+					meter: i == 0 && this.settings.integration === 0,
+				});
+			}
 
-				//SmartLogger
-				if (this.settings.integration === 1) {
-					this.devices.push({
-						index: 0,
-						duration: 0,
-						modbusId: 0,
-						driverClass: driverClasses.logger,
-					});
-					if (this.settings.sl.meterId > 0) {
-						this.devices.push({
-							index: 0,
-							duration: 0,
-							meter: true,
-							modbusId: this.settings.sl.meterId,
-							driverClass: driverClasses.loggerMeter,
-						});
-					}
-				}
+			//SDongle
+			if (this.settings.integration === 0 && this.settings.sd.active) {
+				this.devices.push({
+					index: 0,
+					duration: 0,
+					modbusId: this.settings.sd.sDongleId,
+					driverClass: driverClasses.sdongle,
+				});
+			}
 
-				//EMMA
-				if (this.settings.integration === 2) {
+			//SmartLogger
+			if (this.settings.integration === 1) {
+				this.devices.push({
+					index: 0,
+					duration: 0,
+					modbusId: 0,
+					driverClass: driverClasses.logger,
+				});
+				if (this.settings.sl.meterId > 0) {
 					this.devices.push({
 						index: 0,
 						duration: 0,
-						//modbusId: 1, --> testMode
-						modbusId: 0,
 						meter: true,
-						driverClass: driverClasses.emma,
+						modbusId: this.settings.sl.meterId,
+						driverClass: driverClasses.loggerMeter,
 					});
 				}
+			}
 
-				await this.adjustInverval();
-				await this.StartProcess();
-			} else {
-				this.adapterDisable("*** Adapter deactivated, can't parse modbusIds! ***");
+			//EMMA with TestMode
+			if (this.settings.integration === 2) {
+				this.devices.push({
+					index: 0,
+					duration: 0,
+					//modbusId: 1, --> testMode
+					modbusId: 0,
+					meter: true,
+					driverClass: driverClasses.emma,
+				});
 			}
+
+			await this.adjustInverval();
+			await this.StartProcess();
 		} else {
-			this.adapterDisable('*** Adapter deactivated, Adapter Settings incomplete! ***');
+			this.adapterDisable(`*** Adapter deactivated, Adapter Settings incomplete! ***`);
 		}
 	}
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "iobroker.sun2000",
-  "version": "2.3.2",
+  "version": "2.3.3",
   "description": "sun2000",
   "author": {
     "name": "bolliy",