iobroker.sigenergy 2.3.3 → 2.3.4

package/README.md

@@ -153,6 +153,9 @@ Status and power readings for the DC charger.
 
 ## Changelog
 
+### 2.3.4 (2026-06-12)
+- (ssbingo) fix: correct protocol level detection — use proper register quantities for probes, descend from V2.9 to V2.6, distinguish transport errors from device exceptions to avoid false pre-V2.6 report
+
 ### 2.3.3 (2026-06-11)
 - (ssbingo) fix: suppress repeated register read warnings after first occurrence for plant/inverter/acCharger/dcCharger/pss/pid; subsequent failures log at debug level only
 

package/io-package.json

@@ -1,20 +1,20 @@
 {
     "common": {
         "name": "sigenergy",
-        "version": "2.3.3",
+        "version": "2.3.4",
         "news": {
-            "2.3.3": {
-                "en": "(ssbingo) fix: suppress repeated register read warnings after first occurrence for plant/inverter/acCharger/dcCharger/pss/pid; subsequent failures log at debug level only",
-                "de": "(ssbingo) fix: wiederholte Register-Lesewarnungen nach erstem Auftreten für plant/inverter/acCharger/dcCharger/pss/pid unterdrückt; weitere Fehler nur noch auf Debug-Ebene protokolliert",
-                "ru": "(ssbingo) fix: подавление повторяющихся предупреждений о чтении регистров после первого возникновения для plant/inverter/acCharger/dcCharger/pss/pid; последующие ошибки логируются только на уровне debug",
-                "pt": "(ssbingo) fix: suprimir avisos repetidos de leitura de registos após primeira ocorrência para plant/inverter/acCharger/dcCharger/pss/pid; falhas subsequentes registadas apenas ao nível debug",
-                "nl": "(ssbingo) fix: herhaalde register-leeswaarschuwingen na eerste voorkomen onderdrukken voor plant/inverter/acCharger/dcCharger/pss/pid; volgende fouten alleen op debug-niveau gelogd",
-                "fr": "(ssbingo) fix: supprimer les avertissements répétés de lecture de registres après la première occurrence pour plant/inverter/acCharger/dcCharger/pss/pid ; les échecs suivants sont journalisés au niveau debug uniquement",
-                "it": "(ssbingo) fix: sopprimere gli avvisi ripetuti di lettura registro dopo la prima occorrenza per plant/inverter/acCharger/dcCharger/pss/pid; i guasti successivi vengono registrati solo a livello debug",
-                "es": "(ssbingo) fix: suprimir advertencias repetidas de lectura de registros tras la primera aparición para plant/inverter/acCharger/dcCharger/pss/pid; los fallos posteriores solo se registran a nivel debug",
-                "pl": "(ssbingo) fix: tłumienie powtarzających się ostrzeżeń o odczycie rejestrów po pierwszym wystąpieniu dla plant/inverter/acCharger/dcCharger/pss/pid; kolejne błędy rejestrowane tylko na poziomie debug",
-                "uk": "(ssbingo) fix: придушення повторюваних попереджень про зчитування регістрів після першого виникнення для plant/inverter/acCharger/dcCharger/pss/pid; наступні помилки журналюються лише на рівні debug",
-                "zh-cn": "(ssbingo) fix: 对 plant/inverter/acCharger/dcCharger/pss/pid 寄存器读取警告在首次出现后不再重复；后续失败仅在 debug 级别记录"
+            "2.3.4": {
+                "en": "(ssbingo) fix: correct protocol level detection — use proper register quantities for probes, descend from V2.9 to V2.6, distinguish transport errors from device exceptions to avoid false pre-V2.6 report",
+                "de": "(ssbingo) fix: Protokollversionserkennung korrigiert — korrekte Registermengen für Probes, absteigende Reihenfolge V2.9→V2.6, Transportfehler von Geräteantworten unterschieden um fehlerhafte pre-V2.6-Meldung zu vermeiden",
+                "ru": "(ssbingo) fix: исправлено определение уровня протокола — правильное количество регистров для проб, порядок убывания V2.9→V2.6, разграничение транспортных ошибок и ответов устройства для исключения ложного сообщения pre-V2.6",
+                "pt": "(ssbingo) fix: correção da deteção do nível de protocolo — quantidades corretas de registos para sondas, ordem decrescente V2.9→V2.6, distinção entre erros de transporte e exceções do dispositivo para evitar falso relatório pre-V2.6",
+                "nl": "(ssbingo) fix: correcte protocolniveaudetectie — juiste registerhoeveelheden voor probes, aflopende volgorde V2.9→V2.6, onderscheid transportfouten van apparaatreacties om vals pre-V2.6-rapport te voorkomen",
+                "fr": "(ssbingo) fix: correction de la détection du niveau de protocole — quantités de registres correctes pour les sondes, ordre décroissant V2.9→V2.6, distinction des erreurs de transport des exceptions du périphérique pour éviter un rapport pre-V2.6 erroné",
+                "it": "(ssbingo) fix: correzione del rilevamento del livello di protocollo — quantità di registri corrette per le probe, ordine decrescente V2.9→V2.6, distinzione errori di trasporto da eccezioni del dispositivo per evitare falso rapporto pre-V2.6",
+                "es": "(ssbingo) fix: corrección de la detección del nivel de protocolo — cantidades correctas de registros para sondas, orden descendente V2.9→V2.6, distinción de errores de transporte de excepciones del dispositivo para evitar informe falso pre-V2.6",
+                "pl": "(ssbingo) fix: poprawka wykrywania poziomu protokołu — właściwe ilości rejestrów dla sond, kolejność malejąca V2.9→V2.6, rozróżnienie błędów transportu od wyjątków urządzenia w celu uniknięcia fałszywego raportu pre-V2.6",
+                "uk": "(ssbingo) fix: виправлення визначення рівня протоколу — правильна кількість регістрів для проб, порядок спадання V2.9→V2.6, розрізнення транспортних помилок від винятків пристрою для уникнення хибного звіту pre-V2.6",
+                "zh-cn": "(ssbingo) fix: 修正协议版本检测 — 使用正确的寄存器数量探测，从 V2.9 降序到 V2.6，区分传输错误和设备异常，避免误报 pre-V2.6"
             }
         },
         "titleLang": {

package/lib/registers.js

@@ -1252,7 +1252,7 @@ const PLANT_READ_REGISTERS = [
         desc: 'Total oil generator energy (V2.8)',
         feature: 'enableCumulativeEnergy',
     },
-    // V2.8 — separate FC04 group (gap > 4 from 30087)
+    // V2.9 — separate FC04 group (gap > 4 from 30087)
     {
         addr: 30272,
         qty: 2,
@@ -1261,7 +1261,7 @@ const PLANT_READ_REGISTERS = [
         gain: 100,
         unit: 'kWh',
         role: 'value.energy',
-        desc: 'PV total daily generation (V2.8)',
+        desc: 'PV total daily generation (V2.9)',
     },
     {
         addr: 30274,
@@ -1271,9 +1271,9 @@ const PLANT_READ_REGISTERS = [
         gain: 100,
         unit: 'kWh',
         role: 'value.energy',
-        desc: 'PV total generation previous day (V2.8)',
+        desc: 'PV total generation previous day (V2.9)',
     },
-    // V2.9
+    // V2.8
     {
         addr: 30276,
         qty: 1,
@@ -1282,7 +1282,7 @@ const PLANT_READ_REGISTERS = [
         gain: 100,
         unit: 'Hz',
         role: 'value.frequency',
-        desc: 'Grid code rated frequency (V2.9)',
+        desc: 'Grid code rated frequency (V2.8)',
     },
     {
         addr: 30277,
@@ -1292,7 +1292,7 @@ const PLANT_READ_REGISTERS = [
         gain: 100,
         unit: 'V',
         role: 'value.voltage',
-        desc: 'Grid code rated voltage (V2.9)',
+        desc: 'Grid code rated voltage (V2.8)',
     },
     {
         addr: 30279,
@@ -1312,7 +1312,7 @@ const PLANT_READ_REGISTERS = [
         gain: null,
         unit: '',
         role: 'value',
-        desc: 'Merged alarm 6 (V2.9)',
+        desc: 'Merged alarm 6 (V2.8)',
     },
     {
         addr: 30281,
@@ -1322,7 +1322,7 @@ const PLANT_READ_REGISTERS = [
         gain: null,
         unit: '',
         role: 'value',
-        desc: 'Merged alarm 7 (V2.9)',
+        desc: 'Merged alarm 7 (V2.8)',
     },
     {
         addr: 30282,
@@ -1332,7 +1332,7 @@ const PLANT_READ_REGISTERS = [
         gain: 1000,
         unit: 'kW',
         role: 'value.power',
-        desc: 'General load power (V2.9)',
+        desc: 'General load power (V2.8)',
     },
     {
         addr: 30284,
@@ -1342,7 +1342,7 @@ const PLANT_READ_REGISTERS = [
         gain: 1000,
         unit: 'kW',
         role: 'value.power',
-        desc: 'Total load power (V2.9)',
+        desc: 'Total load power (V2.8)',
     },
     {
         addr: 30286,

package/main.js

@@ -255,8 +255,9 @@ class Sigenergy extends utils.Adapter {
                 this._controlRegistersRead = true;
             }
             if (!this._protocolDetected) {
-                await this._detectProtocolLevel();
-                this._protocolDetected = true;
+                // Only latch the flag if detection was conclusive (no transport
+                // errors). Otherwise retry on the next poll cycle.
+                this._protocolDetected = await this._detectProtocolLevel();
             }
 
             const _t0 = Date.now();
@@ -311,13 +312,13 @@ class Sigenergy extends utils.Adapter {
             await this._updatePvStringPowers();
 
             await this.setStateAsync('info.connection', { val: true, ack: true });
-            // Successful cycle → reset dedup flags so next outage logs at ERROR level again.
+            // Successful cycle — reset dedup flags so next outage logs at ERROR level again.
             this._pollErrorKey = null;
             this._pollWarnLogged = false;
             this.log.debug(`[poll] cycle completed in ${Date.now() - _pollStart} ms`);
         } catch (err) {
-            // Deduplicate: first occurrence → ERROR (visible + Sentry-worthy).
-            // Identical subsequent errors → DEBUG, so a broken network does not flood the log.
+            // Deduplicate: first occurrence — ERROR (visible + Sentry-worthy).
+            // Identical subsequent errors — DEBUG, so a broken network does not flood the log.
             const key = `poll:${err.code || err.message}`;
             if (this._pollErrorKey !== key) {
                 this.log.error(`Poll error: ${err.message}`);
@@ -542,26 +543,61 @@ class Sigenergy extends utils.Adapter {
         }
     }
 
+    /**
+     * Detect the Modbus protocol level supported by the device.
+     *
+     * Design notes (root cause of the former "pre-V2.6" misdetection):
+     * 1. Sigenergy firmware rejects reads that do not cover a complete data
+     *    point. Probing addr 30088 (U64, qty 4) with qty=1 returns Modbus
+     *    exception 0x02 (ILLEGAL DATA ADDRESS, "combination of reference
+     *    number and transfer length is invalid"). Every probe therefore
+     *    reads the FULL quantity of its data point.
+     * 2. Probes run in DESCENDING order and stop at the first success, so a
+     *    single optional/legacy register can no longer cap the result.
+     * 3. Probe registers are valid for both "Hybrid Inv." and "PV Inv."
+     *    (per protocol doc V2.9, table 5-1) and match the official version
+     *    history: 30272 added in V2.9, 30276 in V2.8, 30194 in V2.7,
+     *    30088 in V2.6.
+     * 4. A Modbus exception (1/2) means "register not implemented" — that is
+     *    a conclusive "no". A transport error/timeout is INCONCLUSIVE: it is
+     *    retried once, and if detection stays inconclusive the whole run is
+     *    repeated on the next poll cycle instead of reporting pre-V2.6.
+     *
+     * @returns {Promise<boolean>} true if detection was conclusive
+     */
     async _detectProtocolLevel() {
         const plantId = this.config.plantId || 247;
         const inverterId = this.config.inverterId || 1;
 
         const probes = [
-            { addr: 30088, level: 'V2.6' },
-            { addr: 30200, level: 'V2.7' },
-            { addr: 30228, level: 'V2.8' },
-            { addr: 30286, level: 'V2.9' },
+            { addr: 30272, qty: 2, level: 'V2.9' }, // PV total daily generation (U32)
+            { addr: 30276, qty: 1, level: 'V2.8' }, // [Grid code] Rated frequency (U16)
+            { addr: 30194, qty: 2, level: 'V2.7' }, // Third party inverter active power (S32)
+            { addr: 30088, qty: 4, level: 'V2.6' }, // Plant PV total generation (U64)
         ];
 
         let detectedLevel = null;
+        let inconclusive = false;
         for (const probe of probes) {
-            try {
-                await this.modbus.readInputRegisters(plantId, probe.addr, 1);
+            if (this._stopped) {
+                return false;
+            }
+            const result = await this._probeRegister(plantId, probe);
+            if (result === 'supported') {
                 detectedLevel = probe.level;
-            } catch (err) {
-                this.log.debug(`[protocolProbe] addr=${probe.addr} (${probe.level}): ${err.message}`);
                 break;
             }
+            if (result === 'error') {
+                inconclusive = true;
+            }
+            await this._sleep(100);
+        }
+
+        if (!detectedLevel && inconclusive) {
+            this.log.warn(
+                'Protocol level detection inconclusive (communication errors during probing) — will retry on next poll cycle',
+            );
+            return false;
         }
 
         let firmwareVersion = 'unknown';
@@ -575,6 +611,48 @@ class Sigenergy extends utils.Adapter {
         const levelStr = detectedLevel ? `>=${detectedLevel}` : 'pre-V2.6';
         this.log.info(`Detected protocol level: ${levelStr} (firmware: ${firmwareVersion})`);
         await this.setStateAsync('info.protocolLevel', { val: levelStr, ack: true });
+        return true;
+    }
+
+    /**
+     * Probe a single register (full data point) on the device.
+     *
+     * @param {number} slaveId - Modbus slave id
+     * @param {{addr: number, qty: number, level: string}} probe - probe definition
+     * @returns {Promise<'supported'|'unsupported'|'error'>} probe result
+     */
+    async _probeRegister(slaveId, probe) {
+        for (let attempt = 1; attempt <= 2; attempt++) {
+            if (this._stopped) {
+                return 'error';
+            }
+            try {
+                await this.modbus.readInputRegisters(slaveId, probe.addr, probe.qty);
+                this.log.debug(`[protocolProbe] addr=${probe.addr} qty=${probe.qty} (${probe.level}): supported`);
+                return 'supported';
+            } catch (err) {
+                // modbus-serial sets err.modbusCode on Modbus exception responses
+                // (1 = ILLEGAL FUNCTION, 2 = ILLEGAL DATA ADDRESS, ...). An
+                // exception is an answer FROM the device => register not
+                // implemented on this firmware. Anything else (timeout, socket
+                // error) is a transport problem and proves nothing.
+                if (err && err.modbusCode !== undefined) {
+                    this.log.debug(
+                        `[protocolProbe] addr=${probe.addr} qty=${probe.qty} (${probe.level}): ` +
+                            `not supported (Modbus exception ${err.modbusCode})`,
+                    );
+                    return 'unsupported';
+                }
+                this.log.debug(
+                    `[protocolProbe] addr=${probe.addr} qty=${probe.qty} (${probe.level}): ` +
+                        `transport error on attempt ${attempt}/2: ${err.message}`,
+                );
+                if (attempt < 2) {
+                    await this._sleep(300);
+                }
+            }
+        }
+        return 'error';
     }
 
     async _readControlRegisters() {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "iobroker.sigenergy",
-  "version": "2.3.3",
+  "version": "2.3.4",
   "description": "ioBroker adapter for Sigenergy solar energy systems via Modbus TCP/RTU",
   "author": {
     "name": "ssbingo",