iobroker.renault 0.0.24 → 0.0.25

package/README.md

@@ -9,6 +9,8 @@
 
 **Tests:** ![Test and Release](https://github.com/TA2k/ioBroker.renault/workflows/Test%20and%20Release/badge.svg)
 
+**This adapter uses Sentry libraries to automatically report exceptions and code errors to the developers.** For more details and for information how to disable the error reporting see [Sentry-Plugin Documentation](https://github.com/ioBroker/plugin-sentry#plugin-sentry)! Sentry reporting is used starting with js-controller 3.0.
+
 ## Renault / Dacia / Alpine adapter for ioBroker
 
 This adapter connects ioBroker to the My Renault / My Dacia / My Alpine cloud and exposes vehicle status data (battery, charging, HVAC, mileage, ...) as well as remote commands (HVAC start, charging start/stop, force refresh) for compatible Renault, Dacia and Alpine models such as the Renault Zoe, Megane E-Tech, Kangoo E-Tech, the Dacia Spring and the Alpine A290.
@@ -48,6 +50,16 @@ ioBroker forum: <https://forum.iobroker.net/topic/48074/test-adapter-renault-v0-
   ### **WORK IN PROGRESS**
 -->
 
+### 0.0.25
+
+- (typhosj) retry the connection with growing delay (5 to 60 minutes) when login or vehicle list fail at startup; a login rejected by the account service is not retried
+- (typhosj) `info.connection` is true only after the account was found and turns false when the token refresh fails
+- (typhosj) a temporary server error (5xx) on the first poll no longer disables that endpoint until restart
+- (typhosj) fix crash for vehicles without vehicle details and for the refresh button before login
+- (typhosj) no longer write password, session cookie, id token or account data into the log
+- (typhosj) add missing admin translations, remove unused dependencies
+- (typhosj) require Node.js 22 or newer, test with Node.js 26, update dependencies
+
 ### 0.0.24
 
 - (TA2k) add Alpine support: brand selection (Alpine accounts use the same Renault Gigya/Kamereon tenant, only product/account type MYALPINE differs)

package/admin/i18n/de/translations.json

@@ -12,5 +12,7 @@
   "API Key": "API-Schlüssel",
   "API Key (leave empty for auto-detect)": "API-Schlüssel (leer lassen für automatische Erkennung)",
   "If empty, the API key will be set automatically": "Wenn leer, wird der API-Schlüssel automatisch gesetzt",
-  "Click here for current API Key": "Hier klicken für aktuellen API-Schlüssel"
+  "Click here for current API Key": "Hier klicken für aktuellen API-Schlüssel",
+  "Charge history entries to keep": "Aufzubewahrende Einträge der Ladehistorie",
+  "Number of most recent entries kept per charge-history endpoint (0 = unlimited)": "Anzahl der neuesten Einträge, die je Ladehistorie-Endpunkt behalten werden (0 = unbegrenzt)"
 }

package/admin/i18n/en/translations.json

@@ -12,5 +12,7 @@
   "API Key": "API Key",
   "API Key (leave empty for auto-detect)": "API Key (leave empty for auto-detect)",
   "If empty, the API key will be set automatically": "If empty, the API key will be set automatically",
-  "Click here for current API Key": "Click here for current API Key"
+  "Click here for current API Key": "Click here for current API Key",
+  "Charge history entries to keep": "Charge history entries to keep",
+  "Number of most recent entries kept per charge-history endpoint (0 = unlimited)": "Number of most recent entries kept per charge-history endpoint (0 = unlimited)"
 }

package/admin/i18n/es/translations.json

@@ -3,6 +3,8 @@
   "App Email": "Correo electrónico de la app",
   "App Password": "Contraseña de la app",
   "Country": "País",
+  "Brand": "Marca",
+  "Renault/Dacia and Alpine use different accounts and API keys": "Renault/Dacia y Alpine usan cuentas y claves API diferentes",
   "Two-letter country code, e.g. de, fr, it, es": "Código de país de dos letras, p. ej. de, fr, it, es",
   "Polling": "Sondeo",
   "Update interval in minutes": "Intervalo de actualización en minutos",
@@ -10,5 +12,7 @@
   "API Key": "Clave API",
   "API Key (leave empty for auto-detect)": "Clave API (déjelo vacío para detección automática)",
   "If empty, the API key will be set automatically": "Si está vacío, la clave API se establecerá automáticamente",
-  "Click here for current API Key": "Haga clic aquí para la clave API actual"
+  "Click here for current API Key": "Haga clic aquí para la clave API actual",
+  "Charge history entries to keep": "Entradas del historial de carga a conservar",
+  "Number of most recent entries kept per charge-history endpoint (0 = unlimited)": "Número de entradas más recientes que se conservan por endpoint del historial de carga (0 = ilimitado)"
 }

package/admin/i18n/fr/translations.json

@@ -3,6 +3,8 @@
   "App Email": "Email de l'application",
   "App Password": "Mot de passe de l'application",
   "Country": "Pays",
+  "Brand": "Marque",
+  "Renault/Dacia and Alpine use different accounts and API keys": "Renault/Dacia et Alpine utilisent des comptes et des clés API différents",
   "Two-letter country code, e.g. de, fr, it, es": "Code pays à deux lettres, par exemple de, fr, it, es",
   "Polling": "Interrogation",
   "Update interval in minutes": "Intervalle de mise à jour en minutes",
@@ -10,5 +12,7 @@
   "API Key": "Clé API",
   "API Key (leave empty for auto-detect)": "Clé API (laisser vide pour détection automatique)",
   "If empty, the API key will be set automatically": "Si vide, la clé API sera définie automatiquement",
-  "Click here for current API Key": "Cliquez ici pour la clé API actuelle"
+  "Click here for current API Key": "Cliquez ici pour la clé API actuelle",
+  "Charge history entries to keep": "Entrées de l'historique de charge à conserver",
+  "Number of most recent entries kept per charge-history endpoint (0 = unlimited)": "Nombre d'entrées les plus récentes conservées par point d'accès de l'historique de charge (0 = illimité)"
 }

package/admin/i18n/it/translations.json

@@ -3,6 +3,8 @@
   "App Email": "Email dell'app",
   "App Password": "Password dell'app",
   "Country": "Paese",
+  "Brand": "Marchio",
+  "Renault/Dacia and Alpine use different accounts and API keys": "Renault/Dacia e Alpine usano account e chiavi API diversi",
   "Two-letter country code, e.g. de, fr, it, es": "Codice paese di due lettere, ad esempio de, fr, it, es",
   "Polling": "Polling",
   "Update interval in minutes": "Intervallo di aggiornamento in minuti",
@@ -10,5 +12,7 @@
   "API Key": "Chiave API",
   "API Key (leave empty for auto-detect)": "Chiave API (lascia vuoto per il rilevamento automatico)",
   "If empty, the API key will be set automatically": "Se vuoto, la chiave API verrà impostata automaticamente",
-  "Click here for current API Key": "Fai clic qui per la chiave API attuale"
+  "Click here for current API Key": "Fai clic qui per la chiave API attuale",
+  "Charge history entries to keep": "Voci della cronologia di ricarica da conservare",
+  "Number of most recent entries kept per charge-history endpoint (0 = unlimited)": "Numero di voci più recenti conservate per ogni endpoint della cronologia di ricarica (0 = illimitato)"
 }

package/admin/i18n/nl/translations.json

@@ -3,6 +3,8 @@
   "App Email": "App E-mail",
   "App Password": "App Wachtwoord",
   "Country": "Land",
+  "Brand": "Merk",
+  "Renault/Dacia and Alpine use different accounts and API keys": "Renault/Dacia en Alpine gebruiken verschillende accounts en API-sleutels",
   "Two-letter country code, e.g. de, fr, it, es": "Tweeletterige landcode, bijv. de, fr, it, es",
   "Polling": "Polling",
   "Update interval in minutes": "Update interval in minuten",
@@ -10,5 +12,7 @@
   "API Key": "API-sleutel",
   "API Key (leave empty for auto-detect)": "API-sleutel (laat leeg voor auto-detectie)",
   "If empty, the API key will be set automatically": "Indien leeg, wordt de API-sleutel automatisch ingesteld",
-  "Click here for current API Key": "Klik hier voor de huidige API-sleutel"
+  "Click here for current API Key": "Klik hier voor de huidige API-sleutel",
+  "Charge history entries to keep": "Te bewaren items van de laadgeschiedenis",
+  "Number of most recent entries kept per charge-history endpoint (0 = unlimited)": "Aantal meest recente items dat per laadgeschiedenis-endpoint wordt bewaard (0 = onbeperkt)"
 }

package/admin/i18n/pl/translations.json

@@ -3,6 +3,8 @@
   "App Email": "Email aplikacji",
   "App Password": "Hasło aplikacji",
   "Country": "Kraj",
+  "Brand": "Marka",
+  "Renault/Dacia and Alpine use different accounts and API keys": "Renault/Dacia i Alpine używają różnych kont i kluczy API",
   "Two-letter country code, e.g. de, fr, it, es": "Dwuliterowy kod kraju, np. de, fr, it, es",
   "Polling": "Odpytywanie",
   "Update interval in minutes": "Interwał aktualizacji w minutach",
@@ -10,5 +12,7 @@
   "API Key": "Klucz API",
   "API Key (leave empty for auto-detect)": "Klucz API (pozostaw puste, aby wykryć automatycznie)",
   "If empty, the API key will be set automatically": "Jeśli puste, klucz API zostanie ustawiony automatycznie",
-  "Click here for current API Key": "Kliknij tutaj, aby uzyskać aktualny klucz API"
+  "Click here for current API Key": "Kliknij tutaj, aby uzyskać aktualny klucz API",
+  "Charge history entries to keep": "Liczba zachowywanych wpisów historii ładowania",
+  "Number of most recent entries kept per charge-history endpoint (0 = unlimited)": "Liczba najnowszych wpisów zachowywanych dla każdego endpointu historii ładowania (0 = bez limitu)"
 }

package/admin/i18n/pt/translations.json

@@ -3,6 +3,8 @@
   "App Email": "Email do aplicativo",
   "App Password": "Senha do aplicativo",
   "Country": "País",
+  "Brand": "Marca",
+  "Renault/Dacia and Alpine use different accounts and API keys": "Renault/Dacia e Alpine utilizam contas e chaves de API diferentes",
   "Two-letter country code, e.g. de, fr, it, es": "Código de país de duas letras, por exemplo de, fr, it, es",
   "Polling": "Sondagem",
   "Update interval in minutes": "Intervalo de atualização em minutos",
@@ -10,5 +12,7 @@
   "API Key": "Chave API",
   "API Key (leave empty for auto-detect)": "Chave API (deixe em branco para detecção automática)",
   "If empty, the API key will be set automatically": "Se vazio, a chave API será definida automaticamente",
-  "Click here for current API Key": "Clique aqui para a chave API atual"
+  "Click here for current API Key": "Clique aqui para a chave API atual",
+  "Charge history entries to keep": "Entradas do histórico de carregamento a manter",
+  "Number of most recent entries kept per charge-history endpoint (0 = unlimited)": "Número de entradas mais recentes mantidas por endpoint do histórico de carregamento (0 = ilimitado)"
 }

package/admin/i18n/ru/translations.json

@@ -3,6 +3,8 @@
   "App Email": "Электронная почта приложения",
   "App Password": "Пароль приложения",
   "Country": "Страна",
+  "Brand": "Марка",
+  "Renault/Dacia and Alpine use different accounts and API keys": "Renault/Dacia и Alpine используют разные учётные записи и API-ключи",
   "Two-letter country code, e.g. de, fr, it, es": "Двухбуквенный код страны, например de, fr, it, es",
   "Polling": "Опрос",
   "Update interval in minutes": "Интервал обновления в минутах",
@@ -10,5 +12,7 @@
   "API Key": "API ключ",
   "API Key (leave empty for auto-detect)": "API ключ (оставьте пустым для автоопределения)",
   "If empty, the API key will be set automatically": "Если пусто, API ключ будет установлен автоматически",
-  "Click here for current API Key": "Нажмите здесь для получения текущего API ключа"
+  "Click here for current API Key": "Нажмите здесь для получения текущего API ключа",
+  "Charge history entries to keep": "Сохраняемые записи истории зарядки",
+  "Number of most recent entries kept per charge-history endpoint (0 = unlimited)": "Количество последних записей, сохраняемых для каждого эндпоинта истории зарядки (0 = без ограничений)"
 }

package/admin/i18n/uk/translations.json

@@ -3,6 +3,8 @@
   "App Email": "Електронна пошта застосунку",
   "App Password": "Пароль застосунку",
   "Country": "Країна",
+  "Brand": "Марка",
+  "Renault/Dacia and Alpine use different accounts and API keys": "Renault/Dacia та Alpine використовують різні облікові записи та API-ключі",
   "Two-letter country code, e.g. de, fr, it, es": "Дволітерний код країни, наприклад de, fr, it, es",
   "Polling": "Опитування",
   "Update interval in minutes": "Інтервал оновлення в хвилинах",
@@ -10,5 +12,7 @@
   "API Key": "API ключ",
   "API Key (leave empty for auto-detect)": "API ключ (залиште порожнім для автовизначення)",
   "If empty, the API key will be set automatically": "Якщо порожньо, API ключ буде встановлено автоматично",
-  "Click here for current API Key": "Натисніть тут для отримання поточного API ключа"
+  "Click here for current API Key": "Натисніть тут для отримання поточного API ключа",
+  "Charge history entries to keep": "Записи історії заряджання, що зберігаються",
+  "Number of most recent entries kept per charge-history endpoint (0 = unlimited)": "Кількість останніх записів, що зберігаються для кожного ендпоінта історії заряджання (0 = без обмежень)"
 }

package/admin/i18n/zh-cn/translations.json

@@ -3,6 +3,8 @@
   "App Email": "应用邮箱",
   "App Password": "应用密码",
   "Country": "国家",
+  "Brand": "品牌",
+  "Renault/Dacia and Alpine use different accounts and API keys": "Renault/Dacia 和 Alpine 使用不同的账户和 API 密钥",
   "Two-letter country code, e.g. de, fr, it, es": "两位字母的国家代码，例如 de, fr, it, es",
   "Polling": "轮询",
   "Update interval in minutes": "更新间隔（分钟）",
@@ -10,5 +12,7 @@
   "API Key": "API 密钥",
   "API Key (leave empty for auto-detect)": "API 密钥（留空自动检测）",
   "If empty, the API key will be set automatically": "如果为空，API 密钥将自动设置",
-  "Click here for current API Key": "点击此处获取当前 API 密钥"
+  "Click here for current API Key": "点击此处获取当前 API 密钥",
+  "Charge history entries to keep": "保留的充电历史记录条数",
+  "Number of most recent entries kept per charge-history endpoint (0 = unlimited)": "每个充电历史接口保留的最新记录条数（0 = 不限制）"
 }

package/io-package.json

@@ -1,8 +1,21 @@
 {
   "common": {
     "name": "renault",
-    "version": "0.0.24",
+    "version": "0.0.25",
     "news": {
+      "0.0.25": {
+        "en": "more robust startup with retry, truthful connection state, no secrets in the log, require Node.js 22+",
+        "de": "robusterer Start mit Wiederholung, ehrlicher Verbindungsstatus, keine Geheimnisse im Log, benötigt Node.js 22+",
+        "ru": "более надёжный запуск с повтором, честный статус соединения, без секретов в логе, требуется Node.js 22+",
+        "pt": "arranque mais robusto com nova tentativa, estado de ligação fiável, sem segredos no registo, requer Node.js 22+",
+        "nl": "robuustere start met herhaling, eerlijke verbindingsstatus, geen geheimen in het logboek, vereist Node.js 22+",
+        "fr": "démarrage plus robuste avec nouvelle tentative, état de connexion fiable, aucun secret dans le journal, nécessite Node.js 22+",
+        "it": "avvio più robusto con ripetizione, stato di connessione affidabile, nessun segreto nel log, richiede Node.js 22+",
+        "es": "inicio más robusto con reintento, estado de conexión fiable, sin secretos en el registro, requiere Node.js 22+",
+        "pl": "solidniejszy start z ponawianiem, prawdziwy status połączenia, bez sekretów w logu, wymaga Node.js 22+",
+        "uk": "надійніший запуск із повтором, чесний статус з'єднання, без секретів у журналі, потрібен Node.js 22+",
+        "zh-cn": "启动更稳健并带重试、连接状态真实、日志中不含密钥、需要 Node.js 22+"
+      },
       "0.0.24": {
         "en": "add Alpine support (select brand Alpine in the settings)",
         "de": "Alpine-Unterstützung hinzugefügt (Marke Alpine in den Einstellungen wählen)",
@@ -80,32 +93,6 @@
         "pl": "Naprawiono start ładowania i zmniejszono logi błędów",
         "uk": "Виправлено старт зарядки та зменшено журнали помилок",
         "zh-cn": "修复充电启动并减少错误日志"
-      },
-      "0.0.14": {
-        "en": "add charging stop",
-        "de": "Ladestopp hinzugefügt",
-        "ru": "Добавлена остановка зарядки",
-        "pt": "Adicionada paragem de carga",
-        "nl": "Stoppen van het laden toegevoegd",
-        "fr": "Ajout de l'arrêt de la charge",
-        "it": "Aggiunto stop della carica",
-        "es": "Añadida parada de carga",
-        "pl": "Dodano zatrzymanie ładowania",
-        "uk": "Додано зупинку зарядки",
-        "zh-cn": "添加充电停止"
-      },
-      "0.0.13": {
-        "en": "add remote object for force refresh",
-        "de": "Remote-Objekt für erzwungene Aktualisierung hinzugefügt",
-        "ru": "Добавлен удалённый объект для принудительного обновления",
-        "pt": "Adicionado objeto remoto para forçar atualização",
-        "nl": "Remote-object voor geforceerde verversing toegevoegd",
-        "fr": "Ajout d'un objet distant pour le rafraîchissement forcé",
-        "it": "Aggiunto oggetto remoto per il refresh forzato",
-        "es": "Añadido objeto remoto para actualización forzada",
-        "pl": "Dodano obiekt zdalny do wymuszonego odświeżenia",
-        "uk": "Додано віддалений об'єкт для примусового оновлення",
-        "zh-cn": "添加用于强制刷新的 remote 对象"
       }
     },
     "titleLang": {

package/main.js

@@ -29,6 +29,14 @@ class Renault extends utils.Adapter {
     this.firstUpdate = true;
     this.requestClient = axios.create();
     this.userAgent = 'okhttp/5.3.0';
+    /** @type {string} */
+    this.brand = 'renault';
+    /** @type {string[]} */
+    this.accountTypes = [];
+    this.updateInterval = null;
+    this.refreshTokenInterval = null;
+    this.startAttempt = 0;
+    this.loginRejected = false;
   }
 
   /** APK rI2.smali (WiredHeaderAppVersionInterceptor): build={brand}-android-{version};trId={uuid} on wired Kamereon host */
@@ -38,7 +46,7 @@ class Renault extends utils.Adapter {
       const v = c === 'x' ? r : (r & 0x3) | 0x8;
       return v.toString(16);
     });
-    const brand = this.brand || 'renault';
+    const brand = this.brand;
     const version = brand === 'alpine' ? '6.10.1' : '6.11.2';
     return 'build=' + brand + '-android-' + version + ';trId=' + uuid;
   }
@@ -53,7 +61,6 @@ class Renault extends utils.Adapter {
       this.log.info('Set interval to minimum 0.5');
       this.config.interval = 0.5;
     }
-    this.updateInterval = null;
     this.reLoginTimeout = null;
     this.refreshTokenTimeout = null;
     this.country = this.config.country || 'de';
@@ -76,17 +83,15 @@ class Renault extends utils.Adapter {
       })
 
         .then((res) => {
-          this.log.debug(JSON.stringify(res.data));
-
           if (res.data.split('KAMEREON_APIKEY = "')[2] && res.data.split('KAMEREON_APIKEY = "')[2].split('"')[0]) {
             this.apiKeyUpdate = res.data.split('KAMEREON_APIKEY = "')[2].split('"')[0];
           }
         })
         .catch((error) => {
-          this.log.debug(error);
+          this.log.debug('API key lookup failed: ' + error);
         });
     } catch (error) {
-      this.log.debug(error);
+      this.log.debug('API key lookup failed: ' + error);
     }
     if (this.config.apiKeyUpdate) {
       this.apiKeyUpdate = this.config.apiKeyUpdate;
@@ -94,10 +99,16 @@ class Renault extends utils.Adapter {
 
     this.subscribeStates('*');
 
-    await this.login();
+    await this.connectAndPoll();
+  }
 
-    if (this.session.id_token && this.session_data && this.account) {
-      await this.getDeviceList();
+  /**
+   * Log in, load the vehicles and start polling. A network or server failure is retried with
+   * growing delay (5 min doubling up to 60 min). A login the account service rejected is not
+   * retried, so wrong credentials cannot lock the account.
+   */
+  async connectAndPoll() {
+    if ((await this.login()) && (await this.getDeviceList())) {
       await this.migrateChargeHistoryV1();
       await this.updateDevices();
       this.updateInterval = setInterval(
@@ -109,9 +120,33 @@ class Renault extends utils.Adapter {
       this.refreshTokenInterval = setInterval(() => {
         this.refreshToken();
       }, 3500 * 1000);
+      return;
     }
+    if (this.loginRejected) {
+      this.log.error('Login rejected. Check email and password in the adapter settings, then restart the instance.');
+      return;
+    }
+    const delayMinutes = Math.min(5 * 2 ** this.startAttempt, 60);
+    this.startAttempt++;
+    this.log.warn('Connection to the Renault cloud failed. Next attempt in ' + delayMinutes + ' minutes');
+    this.setTimeout(
+      () => this.connectAndPoll().catch((error) => this.log.error('Connection attempt failed: ' + error)),
+      delayMinutes * 60 * 1000,
+    );
   }
+
+  /**
+   * Log in and look up the account. Sets info.connection accordingly.
+   *
+   * @returns {Promise<boolean>} true when session, id token and account are available
+   */
   async login() {
+    const ok = await this.loginSteps();
+    this.setState('info.connection', ok, true);
+    return ok;
+  }
+
+  async loginSteps() {
     this.session_data = await this.requestClient({
       method: 'post',
       url: 'https://accounts.eu1.gigya.com/accounts.login',
@@ -131,23 +166,24 @@ class Renault extends utils.Adapter {
       }),
     })
       .then((res) => {
-        this.log.debug(JSON.stringify(res.data));
         if (res.data.errorMessage) {
+          this.loginRejected = true;
           this.log.error(JSON.stringify(res.data));
           return;
         }
         return res.data.sessionInfo;
       })
       .catch((error) => {
-        this.log.error(error);
+        this.log.error('Login failed: ' + error);
         if (error.response) {
           this.log.error(JSON.stringify(error.response.data));
         }
       });
     if (!this.session_data) {
       this.log.error('No session found for this account. Please login in the app. Maybe a new password is needed.');
-      return;
+      return false;
     }
+    this.session = {};
     await this.requestClient({
       method: 'post',
       url: 'https://accounts.eu1.gigya.com/accounts.getJWT',
@@ -168,17 +204,18 @@ class Renault extends utils.Adapter {
       }),
     })
       .then((res) => {
-        this.log.debug(JSON.stringify(res.data));
         this.session = res.data;
-        this.setState('info.connection', true, true);
       })
       .catch((error) => {
-        this.log.error(error);
+        this.log.error('Getting the id token failed: ' + error);
         if (error.response) {
           this.log.error(JSON.stringify(error.response.data));
         }
       });
-    await this.requestClient({
+    if (!this.session.id_token) {
+      return false;
+    }
+    return await this.requestClient({
       method: 'post',
       url:
         'https://apis.renault.com/myr/api/v1/connection?&country=DE&product=' +
@@ -195,34 +232,41 @@ class Renault extends utils.Adapter {
       },
     })
       .then((res) => {
-        this.log.debug(JSON.stringify(res.data));
-
         const accountTypes = this.accountTypes;
         const filteredAccounts = res.data.currentUser.accounts.filter(function (el) {
           return accountTypes.includes(el.accountType) && el.accountStatus === 'ACTIVE';
         });
         if (filteredAccounts.length === 0) {
           this.log.error('No Account found');
-          this.log.error('All accounts: ' + res.data.currentUser.accounts);
-          this.log.error('Filtered accounts: ' + filteredAccounts);
-          return;
+          this.log.error(
+            'Accounts of this login: ' +
+              JSON.stringify(res.data.currentUser.accounts.map((el) => el.accountType + ' ' + el.accountStatus)),
+          );
+          return false;
         }
 
         this.account = filteredAccounts[0];
+        return true;
       })
       .catch((error) => {
-        this.log.error('Error while getting account');
-        this.log.error(error);
+        this.log.error('Error while getting account: ' + error);
         if (error.response) {
           this.log.error(JSON.stringify(error.response.data));
           if (error.response.data && JSON.stringify(error.response.data).indexOf('apikey') !== -1) {
             this.log.error('Wrong API Key. Please update API Key in adapter settings');
           }
         }
+        return false;
       });
   }
+
+  /**
+   * Load the vehicles of the account and create their objects.
+   *
+   * @returns {Promise<boolean>} true when the vehicle list was loaded
+   */
   async getDeviceList() {
-    await this.requestClient({
+    return await this.requestClient({
       method: 'get',
       url:
         'https://api-wired-prod-1-euw1.wrd-aws.com/commerce/v1/accounts/' +
@@ -243,10 +287,11 @@ class Renault extends utils.Adapter {
       .then(async (res) => {
         this.log.debug(JSON.stringify(res.data));
 
+        this.deviceArray = [];
         for (const device of res.data.vehicleLinks) {
           this.deviceArray.push(device.vin);
           let name = device.vehicleDetails?.modelSCR || device.brand;
-          if (device.vehicleDetails.model && device.vehicleDetails.model.label) {
+          if (device.vehicleDetails?.model?.label) {
             name += device.vehicleDetails.model.label;
           }
 
@@ -302,11 +347,12 @@ class Renault extends utils.Adapter {
           delete device.mileage;
           this.json2iob.parse(device.vin + '.general', device);
         }
+        return true;
       })
       .catch((error) => {
-        this.log.error('Error while getting vehicle list');
-        this.log.error(error);
+        this.log.error('Error while getting vehicle list: ' + error);
         error.response && this.log.error(JSON.stringify(error.response.data));
+        return false;
       });
   }
 
@@ -336,7 +382,7 @@ class Renault extends utils.Adapter {
   }
 
   async updateDevices() {
-    if (!this.account.accountId) {
+    if (!this.account?.accountId) {
       this.log.error('No accountId found');
       return;
     }
@@ -546,20 +592,13 @@ class Renault extends utils.Adapter {
                 return;
               }
               if (this.firstUpdate) {
-                if (
-                  error.response.status === 403 ||
-                  error.response.status === 404 ||
-                  error.response.status === 500 ||
-                  error.response.status === 501 ||
-                  error.response.status === 502 ||
-                  error.response.status === 400
-                ) {
+                if (error.response.status === 400 || error.response.status === 403 || error.response.status === 404) {
                   if (!this.ignoreState[vin]) {
                     this.ignoreState[vin] = [];
                   }
                   this.ignoreState[vin].push(element.path);
                   this.log.info('Feature not found for ' + vin + '. Ignore ' + element.path + ' for updates.');
-                  this.log.debug(error);
+                  this.log.debug(String(error));
                   error.response && this.log.debug(JSON.stringify(error.response.data));
                   return;
                 }
@@ -570,7 +609,7 @@ class Renault extends utils.Adapter {
               return;
             }
             this.log.error(url);
-            this.log.error(error);
+            this.log.error(String(error));
             error.response && this.log.error(JSON.stringify(error.response.data));
           });
       }
@@ -603,13 +642,12 @@ class Renault extends utils.Adapter {
       }),
     })
       .then((res) => {
-        this.log.debug(JSON.stringify(res.data));
         this.session = res.data;
         this.setState('info.connection', true, true);
       })
       .catch((error) => {
-        this.log.error('refresh token failed');
-        this.log.error(error);
+        this.setState('info.connection', false, true);
+        this.log.error('refresh token failed: ' + error);
         error.response && this.log.error(JSON.stringify(error.response.data));
         this.log.error('Start relogin in 1min');
         this.reLoginTimeout = setTimeout(
@@ -620,9 +658,6 @@ class Renault extends utils.Adapter {
         );
       });
   }
-  sleep(ms) {
-    return new Promise((resolve) => setTimeout(resolve, ms));
-  }
   toCamelCase(string) {
     if (!string) {
       return;
@@ -645,7 +680,7 @@ class Renault extends utils.Adapter {
       this.reLoginTimeout && clearTimeout(this.reLoginTimeout);
       this.refreshTokenTimeout && clearTimeout(this.refreshTokenTimeout);
       this.updateInterval && clearInterval(this.updateInterval);
-      clearInterval(this.refreshTokenInterval);
+      this.refreshTokenInterval && clearInterval(this.refreshTokenInterval);
       callback();
     } catch (e) {
       this.log.error('Error onUnload: ' + e);
@@ -666,15 +701,15 @@ class Renault extends utils.Adapter {
         if (path === 'hvac-temperature') {
           return;
         }
+        if (!this.account) {
+          this.log.error('No account found');
+          return;
+        }
         if (path === 'refresh') {
           this.log.info('Force refresh');
           this.updateDevices();
           return;
         }
-        if (!this.account) {
-          this.log.error('No account found');
-          return;
-        }
         const command = path.split('/')[1];
         let action = state.val ? 'start' : 'cancel';
         let midPart = 'kca/car-adapter/v1/cars/';
@@ -722,7 +757,7 @@ class Renault extends utils.Adapter {
             return res.data;
           })
           .catch((error) => {
-            this.log.error(error);
+            this.log.error('Command ' + path + ' failed: ' + error);
             if (error.response) {
               this.log.error(JSON.stringify(error.response.data));
             }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "iobroker.renault",
-  "version": "0.0.24",
-  "description": "Adapter for Renault and Renault",
+  "version": "0.0.25",
+  "description": "Adapter for Renault, Dacia and Alpine",
   "author": {
     "name": "TA2k",
     "email": "tombox2020@gmail.com"
@@ -26,32 +26,29 @@
   },
   "dependencies": {
     "@iobroker/adapter-core": "^3.4.3",
-    "axios": "^1.20.0",
-    "json-bigint": "^1.0.0",
-    "json2iob": "^2.6.26",
-    "qs": "^6.16.0"
+    "axios": "^1.16.1",
+    "json2iob": "^2.6.22",
+    "qs": "^6.15.2"
   },
   "devDependencies": {
     "@alcalzone/release-script": "^5.2.1",
     "@alcalzone/release-script-plugin-iobroker": "^5.2.0",
     "@alcalzone/release-script-plugin-license": "^5.2.2",
     "@alcalzone/release-script-plugin-manual-review": "^5.2.0",
-    "@eslint/eslintrc": "^3.3.7",
+    "@eslint/eslintrc": "^3.3.5",
     "@eslint/js": "^10.0.1",
-    "@iobroker/testing": "^5.3.0",
-    "@tsconfig/node18": "^18.2.7",
-    "@types/mocha": "^10.0.10",
-    "@types/node": "^25.9.6",
-    "eslint": "^10.10.0",
+    "@iobroker/testing": "^6.2.2",
+    "@types/node": "^22.20.3",
+    "eslint": "^10.4.0",
     "eslint-config-prettier": "^10.1.8",
-    "eslint-plugin-prettier": "^5.5.6",
-    "globals": "^17.12.0",
-    "prettier": "^3.9.6",
+    "eslint-plugin-prettier": "^5.5.5",
+    "globals": "^17.6.0",
+    "prettier": "^3.8.3",
     "typescript": "~6.0.3"
   },
   "main": "main.js",
   "engines": {
-    "node": ">=20"
+    "node": ">=22"
   },
   "files": [
     "admin{,/!(src)/**}/!(tsconfig|tsconfig.*).json",

package/lib/descriptions.js

@@ -1 +0,0 @@
-module.exports = {};