iobroker.poolcontrol 1.2.20 → 1.2.21

package/README.md

@@ -186,8 +186,11 @@ New features are added regularly – please refer to the changelog.
 - [help.md (detailed description and notes)](./help.md)
 
 ---
+### 1.2.21 (2026-04-15)
 
-## Changelog
+- Fixed photovoltaic afterrun timer restarting on every recalculation without PV surplus
+- Afterrun now starts only once and runs reliably to completion
+- Proper cleanup when surplus becomes active again during afterrun
 
 ### 1.2.20
 Release: 11.04.2026
@@ -210,241 +213,6 @@ Release: 07.04.2026
 Release: 07.04.2026
 - Fix: Resolved an issue where the pressure learning reset button did not trigger reliably. The pumpHelper4 now explicitly subscribes to its relevant internal states to ensure proper event handling.
 
-### 1.2.15
-Release: 22.03.2026
-- Fix i18n usage (replace I18n.t with I18n.translate) to resolve adapter startup crash and restart loop on certain systems.
-
-### 1.2.14
-Release: 22.03.2026
-- ### add i18n support for chemistry help texts
-
-### 1.2.13
-Release: 22.03.2026
-- Added multilingual state names and descriptions (DE/EN)
-- Improved consistency of all state texts
-- Minor text and structure refinements
-
-### 1.2.12
-Release: 21.03.2026
-- Repository cleanup and fixes for ioBroker repository checker
-- Restored required native object in io-package.json
-- Removed invalid properties and outdated entries
-- Updated README
-
-### 1.2.11
-- Repository cleanup (ioBroker checker issues resolved)
-- Removed invalid properties from io-package.json
-- README updated
-
-### 1.2.10 (2026-03-20)
-- Improved German translations in the admin UI (jsonConfig)
-- Fixed incorrect and misleading terminology (e.g. flow vs. temperature sensors)
-- Improved consistency and wording across all configuration options
-
-### 1.2.9
-Release: 19.03.2026
-- fix: correct invalid common object in runtime channel.
-
-### 1.2.7
-Released: 16.03.2026
-- Corrected role definitions for writable states according to ioBroker guidelines
-- Several internal learning and diagnostic states set to read-only
-- Removed obsolete files from repository
-
-### 1.2.6
-Released: 12.03.2026
-- Fixed remaining adapter checker issues
-- Updated release-script plugins to latest versions
-- Converted remaining log messages to English
-- Updated dependabot configuration (added github-actions ecosystem)
-- Reduced `common.news` entries in io-package.json to comply with repository requirements
-
-### 1.2.5
-Released: 07.03.2026
-- Fixed an issue in `actuatorsHelper` where state changes were not handled correctly in certain situations
-- Minor internal improvements and stability fixes
-
-### 1.2.4
-Release: 07.03.2026
-- Fix: actuatorsHelper did not synchronize instance configuration with internal states (active/name). Additional actuators could not be activated.
-
-### 1.2.3
-Released: 06.03.2026
-- Replaced native timers (setTimeout / setInterval) with adapter timers (adapter.setTimeout / adapter.setInterval)
-- Added proper cleanup of timers on adapter unload
-- Internal code cleanup and maintenance improvements
-
-### 1.2.2
-Released: 06.03.2026
-- Raised required admin version to >=7.6.20
-- Updated translations after jsonConfig i18n refactoring
-- Maintenance update (no functional changes)
-
-### 1.2.1
-Released: 06.03.2026
-- Migration of admin configuration to i18n translation environment
-- jsonConfig now uses English labels with translations managed in admin/i18n
-- Translations generated using `npm run translate`
-
-### 1.2.0
-Released: 15.02.2026
-- Activation of multilingual support (i18n) in jsonConfig
-- Bilingual labeling (German/English) of instance configuration
-- No functional changes to the adapter
-
-
-## v1.1.0 Pump Power Recommendation (23.01.2026)
-- **Pump Power Recommendation (from v1.1.0)**
-  - New passive section `pump.speed`
-  - Derives a clear logical performance state of the running pump:
-    - `off`, `frost`, `low`, `normal`, `high`, `boost`
-  - Performance state is based exclusively on:
-    - existing pump logic
-    - active helper (e.g., frost, solar, maintenance)
-    - current pump status
-  - Additionally provides a **recommended pump power in percent (0–100%)**
-  - Percentage values are **freely configurable** and **protected against overinstallation**
-  - **No active speed control**
-  - **No interference with existing pump control**
-  - Intended for connection to external systems such as:
-    - Shelly 0–10 V
-    - Frequency converters
-    - Blockly / scripts
-
-
-## v1.0.0 Additional Actuators (Lighting & Auxiliary Pumps) (02.01.2026)
-- Control of optional pool actuators:
-  - Pool lighting (up to 3 channels)
-  - Auxiliary pumps / attractions (up to 3 channels)
-- Full configuration via the Admin interface:
-  - Activation per actuator via checkbox
-  - Assignment of an **external object ID**
-    (e.g., switchable socket or boolean control state)
-- Supported operating modes:
-  - On / Off
-  - Timed operation (runtime in minutes)
-  - Continuous operation
-- Internal status and control states:
-  - current operating state
-  - remaining runtime
-  - switching status and operating mode
-- Clear system separation:
-  - Additional actuators do **not**
-    affect pump, solar, heating, or AI logic
-  - Purely optional system extension
-
-
-## v0.9.0
-- Introduction of heating / heat pump control (`heatHelper`)
-- Automatic heating request based on pool temperature
-- Target and maximum temperature configurable
-- Support for:
-  - switchable sockets
-  - boolean control states
-- Pump overrun time after heating ends
-- Priority system:
-  - Maintenance mode blocks heating control
-  - Active only in automatic mode
-  - Considers season status
-- Ownership protection for pump control
-- New internal state `heat.heating_request` for external evaluation
-
-
-## v0.8.2 (2025-12-25)
-- New AI module **Chemistry Help** (`aiChemistryHelpHelper`)
-- Purely informative support system for pool water chemistry
-- Selection of typical pool problems (e.g., pH too high/low, chlorine ineffective, green/cloudy water)
-- Clear cause and solution hints as text output
-- No automatic dosing
-- No product recommendations
-- No device or pump control
-- No speech output (purely visual information)
-- New data points under `ai.chemistry_help.*`
-
-
-## v0.8.0 (2025-12-08)
-- Modules: Weather hints (Open-Meteo), pool tips, daily summary, weekend report
-- Automatic text outputs with optional speech output
-- Hourly weather updates for continuous refresh
-- Anti-spam system to avoid duplicate hints
-- New AI forecast system `aiForecastHelper` integrated
-- Creates a daily automatic “Forecast for Tomorrow” including:
-  - temperature range
-  - weather description
-  - rain probability
-  - wind analysis (light / moderate / strong)
-  - pool recommendations for the following day
-- New switches, schedules and outputs under `ai.weather.*`
-- Immediate initial execution after instance start added
-- Extended Admin overview under “Help & Info” with important AI notes
-- Improved internal structure of the AI system (aiHelper + aiForecastHelper)
-
-
-## v0.7.4 (2025-12-03)
-- Fixed bug in ControlHelper. Persistent protection for control.circulation.mode
-
-
-## v0.7.0 (2025-11-29)
-- Introduction of a new pressure sensor system under `pump.pressure.*`
-- Support for external pressure sensor object ID (bar value from ioBroker)
-- Trend detection (rising/falling/stable) and moving pressure average
-- Self-learning min/max pressure values with manual reset state
-- New diagnostic text (`status_text_diagnostic`) with extended analysis information
-- Extended pump monitoring without automatic control logic (purely informational)
-
-
-## v0.6.2 (2025-11-07)
-- Revision of instance overview with new header structures for clearer operation
-- New start page image “Egon in Workwear” integrated into the Admin interface
-- Extension of speech system with configurable Alexa output times
-- Adjustments and cleanup in jsonConfig, speechHelper and speechStates
-
-
-## v0.6.0 (2025-11-03)
-- Introduction of full photovoltaic control with automatic pump logic  
-  (new pump mode `Automatic (PV)` under `pump.mode`)
-- Adapter reacts to PV surplus based on configurable household consumption and generation power
-- Start logic: pump ON when surplus ≥ (rated power + threshold)
-- Considers season status, overrun time and optional “circulation reached” protection
-- Automatic migration adds new mode `auto_pv` to existing installations
-- Improved internal logic, persistence and debug logging
-
-## v0.5.5 (2025-11-01)
-- Fixed endless loop in weekly and monthly statistics
-
-## v0.5.3 (2025-10-30)
-- Added Telegram user selection
-
-## v0.5.2 (2025-10-30)
-
-## v0.5.0 (2025-10-28)
-
-### **0.4.0 (26.10.2025)**
-
-**New Features**
-- Introduction of the new statistics system under `analytics.statistics.temperature.today`
-- Automatic collection of **min, max and average values** of all active temperature sensors
-- Per sensor: JSON and HTML summaries with continuous updates
-- Overall output of all sensors (table) under  
-  `analytics.statistics.temperature.today.outputs.summary_all_html`
-- Fully **persistent data points** with overinstall protection
-- **Automatic midnight reset** for daily reset including timestamp
-- Preparation for future weekly, monthly and seasonal statistics
-
-**Improvements**
-- Unified structure through new main folder `analytics`
-- No permanent loops or timer load – pure event processing
-- Improved performance and memory stability
-- Revised initialization of all statistics states at startup
-
-**Note**
-This version forms the stable basis for all following statistics and analysis functions  
-(e.g., weekly and monthly statistics, history and efficiency evaluations).
-
-*(older versions see [io-package.json](./io-package.json))*  
-
----
-
 ## Support
 - [ioBroker Forum](https://forum.iobroker.net/)  
 - [GitHub Issues](https://github.com/DasBo1975/ioBroker.poolcontrol/issues)

package/io-package.json

@@ -1,8 +1,21 @@
 {
   "common": {
     "name": "poolcontrol",
-    "version": "1.2.20",
+    "version": "1.2.21",
     "news": {
+      "1.2.21": {
+        "en": "Bugfix: Fixed an issue in the photovoltaic helper where the afterrun timer was unintentionally restarted on every recalculation without PV surplus. This could delay the pump shutdown significantly. The afterrun now starts only once when surplus ends and runs reliably to completion. Also ensures proper cleanup when surplus becomes active again during afterrun.",
+        "de": "Bugfix: Fehler im Photovoltaik-Helper behoben, bei dem der Nachlauf-Timer bei jedem Recalc ohne PV-Überschuss erneut gestartet wurde. Dadurch konnte sich das Abschalten der Pumpe stark verzögern. Der Nachlauf startet jetzt nur noch einmal beim Wegfall des Überschusses und läuft zuverlässig zu Ende. Zusätzlich wird der Nachlauf sauber beendet, wenn währenddessen wieder Überschuss vorhanden ist.",
+        "ru": "Исправление: исправлена ​​проблема в фотоэлектрическом помощнике, из-за которой таймер выключения непреднамеренно перезапускался при каждом перерасчете без избытка фотоэлектрической энергии. Это может значительно задержать остановку насоса. Последующий запуск теперь запускается только один раз, когда заканчивается избыток, и надежно выполняется до завершения. Также обеспечивает правильную очистку, когда излишки снова становятся активными во время выбега.",
+        "pt": "Correção de bug: Corrigido um problema no auxiliar fotovoltaico em que o temporizador pós-execução era reiniciado involuntariamente em cada recálculo sem excedente de PV. Isto pode atrasar significativamente o encerramento da bomba. A pós-execução agora começa apenas uma vez quando o excedente termina e funciona de forma confiável até a conclusão. Também garante a limpeza adequada quando o excedente fica ativo novamente durante o pós-execução.",
+        "nl": "Bugfix: Probleem opgelost in de fotovoltaïsche helper waarbij de nalooptimer onbedoeld opnieuw werd gestart bij elke herberekening zonder PV-overschot. Dit kan het uitschakelen van de pomp aanzienlijk vertragen. De afterrun start nu slechts één keer als het overschot op is en loopt betrouwbaar door tot voltooiing. Zorgt ook voor een goede opruiming wanneer het overschot weer actief wordt tijdens de afterrun.",
+        "fr": "Correction d'un bug : correction d'un problème dans l'assistant photovoltaïque où la minuterie de post-exécution était involontairement redémarrée à chaque recalcul sans excédent PV. Cela pourrait retarder considérablement l’arrêt de la pompe. L'afterrun ne démarre désormais qu'une seule fois lorsque l'excédent se termine et se déroule de manière fiable jusqu'à son terme. Assure également un nettoyage approprié lorsque le surplus redevient actif pendant la post-exécution.",
+        "it": "Bugfix: risolto un problema nell'helper fotovoltaico per cui il timer di postesecuzione veniva riavviato involontariamente ad ogni ricalcolo senza surplus fotovoltaico. Ciò potrebbe ritardare notevolmente l'arresto della pompa. L'afterrun ora inizia solo una volta quando termina il surplus e viene eseguito in modo affidabile fino al completamento. Garantisce inoltre una corretta pulizia quando il surplus diventa nuovamente attivo durante l'afterrun.",
+        "es": "Corrección de errores: se solucionó un problema en el asistente fotovoltaico por el cual el temporizador de retardo se reiniciaba involuntariamente en cada recálculo sin excedente de fotovoltaico. Esto podría retrasar significativamente el apagado de la bomba. La ejecución posterior ahora comienza solo una vez cuando termina el excedente y se ejecuta de manera confiable hasta su finalización. También garantiza una limpieza adecuada cuando el excedente se vuelve a activar durante la ejecución posterior.",
+        "pl": "Poprawka błędu: Naprawiono problem w pomocniku fotowoltaicznym polegający na niezamierzonym ponownym uruchomieniu licznika czasu dobiegu przy każdym ponownym obliczeniu bez nadwyżki PV. Może to znacznie opóźnić wyłączenie pompy. Dobieg rozpoczyna się teraz tylko raz, gdy kończy się nadwyżka i przebiega niezawodnie do końca. Zapewnia również właściwe czyszczenie, gdy nadwyżka stanie się ponownie aktywna podczas dobiegu.",
+        "uk": "Виправлення помилки: виправлено проблему у фотоелектричному помічнику, через яку таймер післязапуску ненавмисно перезапускався під час кожного перерахунку без надлишку PV. Це може значно затримати зупинку насоса. Післязапуск тепер починається лише один раз, коли закінчується надлишок і працює надійно до кінця. Також забезпечує належне очищення, коли надлишки знову стають активними під час повторного циклу.",
+        "zh-cn": "错误修复：修复了光伏助手中的一个问题，即每次重新计算时没有光伏剩余时，后运行计时器会无意中重新启动。这可能会显着延迟泵的关闭。现在，后运行仅在盈余结束时启动一次，并可靠地运行直至完成。还确保在后运行期间剩余物再次活跃时进行适当的清理。"
+      },
       "1.2.20": {
         "en": "Bugfix release. Reduced unnecessary state writes in the status and photovoltaic helpers. Summary timestamps and PV update timestamps are now only written when the related functional result actually changes. This makes the adapter noticeably quieter and avoids needless state updates without changing the existing control logic.",
         "de": "Bugfix-Release. Reduziert unnötige State-Schreibvorgänge im Status- und Photovoltaik-Helper. Summary-Zeitstempel und PV-Aktualisierungszeitstempel werden jetzt nur noch dann geschrieben, wenn sich das zugehörige fachliche Ergebnis tatsächlich ändert. Dadurch arbeitet der Adapter spürbar ruhiger und vermeidet unnötige State-Updates, ohne die bestehende Steuerlogik zu verändern.",
@@ -54,19 +67,6 @@
         "pl": "Poprawka: rozwiązano problem polegający na tym, że przycisk resetowania uczenia się ciśnienia nie uruchamiał się niezawodnie. PumpHelper4 teraz jawnie subskrybuje swoje odpowiednie stany wewnętrzne (np. wartości resetowania i konfiguracji), zapewniając prawidłową obsługę zdarzeń i natychmiastowe wykonanie logiki resetowania.",
         "uk": "Виправлення: вирішено проблему, через яку кнопка скидання навчання тиску не спрацьовувала надійно. PumpHelper4 тепер явно підписується на свої відповідні внутрішні стани (наприклад, значення скидання та конфігурації), забезпечуючи правильну обробку подій і негайне виконання логіки скидання.",
         "zh-cn": "修复：解决了压力学习重置按钮无法可靠触发的问题。 PumpHelper4 现在显式订阅其相关的内部状态（例如重置和配置值），确保正确的事件处理和立即执行重置逻辑。"
-      },
-      "1.2.15": {
-        "en": "Fix i18n usage (replace I18n.t with I18n.translate) to resolve adapter startup crash and restart loop on certain systems.",
-        "de": "i18n-Nutzung korrigiert (I18n.t durch I18n.translate ersetzt), um Absturz beim Adapterstart und Restart-Loop auf bestimmten Systemen zu beheben.",
-        "ru": "Исправьте использование i18n (замените I18n.t на I18n.translate), чтобы устранить сбой при запуске адаптера и цикл перезапуска в определенных системах.",
-        "pt": "Corrija o uso do i18n (substitua I18n.t por I18n.translate) para resolver falha na inicialização do adaptador e loop de reinicialização em determinados sistemas.",
-        "nl": "I18n-gebruik repareren (vervang I18n.t door I18n.translate) om de opstartcrash van de adapter en de herstartlus op bepaalde systemen op te lossen.",
-        "fr": "Correction de l'utilisation de i18n (remplacez I18n.t par I18n.translate) pour résoudre le crash de démarrage de l'adaptateur et la boucle de redémarrage sur certains systèmes.",
-        "it": "Correggere l'utilizzo di i18n (sostituire I18n.t con I18n.translate) per risolvere il crash di avvio dell'adattatore e riavviare il ciclo su alcuni sistemi.",
-        "es": "Corrija el uso de i18n (reemplace I18n.t con I18n.translate) para resolver el bloqueo de inicio del adaptador y el ciclo de reinicio en ciertos sistemas.",
-        "pl": "Napraw użycie i18n (zamień I18n.t na I18n.translate), aby rozwiązać awarię uruchamiania adaptera i pętlę restartu w niektórych systemach.",
-        "uk": "Виправте використання i18n (замініть I18n.t на I18n.translate), щоб усунути збій запуску адаптера та цикл перезапуску в певних системах.",
-        "zh-cn": "修复 i18n 使用情况（将 I18n.t 替换为 I18n.translate），以解决某些系统上的适配器启动崩溃和重新启动循环问题。"
       }
     },
     "titleLang": {

package/lib/helpers/photovoltaicHelper.js

@@ -239,15 +239,19 @@ const photovoltaicHelper = {
     },
 
     async _maybeStartPump(reason) {
-        if (this._desiredPump === true) {
-            return;
-        }
-        this._desiredPump = true;
+        // FIX: Wenn während eines laufenden Nachlaufs wieder Überschuss kommt,
+        // muss der Nachlauf-Timer immer beendet werden
         if (this.afterrunTimer) {
             clearTimeout(this.afterrunTimer);
             this.afterrunTimer = null;
         }
         this._pvPumpHoldUntil = 0;
+
+        if (this._desiredPump === true) {
+            return;
+        }
+
+        this._desiredPump = true;
         this.adapter.log.info(`[photovoltaicHelper] Pump ON (reason: ${reason})`);
         await this._setPumpSwitch(true);
     },
@@ -267,9 +271,17 @@ const photovoltaicHelper = {
         }
 
         if (immediate || !afterrunMin || afterrunMin <= 0) {
+            // FIX: Laufenden Nachlauf-Timer bei Sofort-Aus immer sauber beenden
+            if (this.afterrunTimer) {
+                clearTimeout(this.afterrunTimer);
+                this.afterrunTimer = null;
+            }
+            this._pvPumpHoldUntil = 0;
+
             if (this._desiredPump === false) {
                 return;
             }
+
             this._desiredPump = false;
             this.adapter.log.info(`[photovoltaicHelper] Pump OFF (${tag}, no afterrun)`);
             await this._setPumpSwitch(false);
@@ -277,11 +289,19 @@ const photovoltaicHelper = {
         }
 
         const holdMs = Math.round(afterrunMin * 60 * 1000);
-        this._pvPumpHoldUntil = Date.now() + holdMs;
+
+        // FIX: Nachlauf nur einmal starten, nicht bei jedem Recalc neu setzen
         if (this.afterrunTimer) {
-            clearTimeout(this.afterrunTimer);
+            this.adapter.log.debug(`[photovoltaicHelper] Afterrun already active, timer not restarted (${tag})`);
+            return;
         }
+
+        this._pvPumpHoldUntil = Date.now() + holdMs;
         this.afterrunTimer = setTimeout(async () => {
+            // FIX: Timer-Handle direkt freigeben, damit der Zustand sauber ist
+            this.afterrunTimer = null;
+            this._pvPumpHoldUntil = 0;
+
             if (await this._isControlHelperPriorityActive()) {
                 this.adapter.log.debug(
                     '[photovoltaicHelper] Afterrun stop suppressed because controlHelper currently has priority.',
@@ -295,10 +315,12 @@ const photovoltaicHelper = {
                 this.adapter.log.debug('[photovoltaicHelper] Afterrun canceled – surplus active again.');
                 return;
             }
+
             this._desiredPump = false;
             this.adapter.log.info('[photovoltaicHelper] Pump OFF (afterrun finished)');
             await this._setPumpSwitch(false);
         }, holdMs);
+
         this.adapter.log.debug(`[photovoltaicHelper] Afterrun started: ${afterrunMin} min (${tag})`);
     },
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "iobroker.poolcontrol",
-  "version": "1.2.20",
+  "version": "1.2.21",
   "description": "Steuerung & Automatisierung für den Pool (Pumpe, Heizung, Ventile, Sensoren).",
   "author": "DasBo1975 <dasbo1975@outlook.de>",
   "homepage": "https://github.com/DasBo1975/ioBroker.poolcontrol",