npm - iobroker.panasonic-comfort-cloud - Versions diffs - 1.2.5 → 2.0.0 - Mend

iobroker.panasonic-comfort-cloud 1.2.5 → 2.0.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (8) hide show

package/LICENSE +1 -1
package/README.md +43 -72
package/build/lib/tools.js +6 -5
package/build/main.js +154 -95
package/io-package.json +61 -5
package/package.json +6 -8
package/.github/ISSUE_TEMPLATE/bug_report.md +0 -32
package/iob_npm.done +0 -1

package/LICENSE CHANGED Viewed

@@ -1,6 +1,6 @@
 MIT License
-Copyright (c) 2019 marc <lammers.marc@gmail.com>
+Copyright (c) 2021 marc <marc@lammers.dev>
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

package/README.md CHANGED Viewed

@@ -12,85 +12,56 @@
 ## panasonic-comfort-cloud adapter for ioBroker
-Adapter for Panasonic Comfort Cloud
-## Developer manual
-This section is intended for the developer. It can be deleted later
-### Getting started
-You are almost done, only a few steps left:
-1. Create a new repository on GitHub with the name `ioBroker.panasonic-comfort-cloud`
-1. Initialize the current folder as a new git repository:
-    ```bash
-    git init
-    git add .
-    git commit -m "Initial commit"
-    ```
-1. Link your local repository with the one on GitHub:
-    ```bash
-    git remote add origin https://github.com/marc2016/ioBroker.panasonic-comfort-cloud
-    ```
-1. Push all files to the GitHub repo:
-    ```bash
-    git push origin master
-    ```
-1. Head over to [src/main.ts](src/main.ts) and start programming!
-### Scripts in `package.json`
-Several npm scripts are predefined for your convenience. You can run them using `npm run <scriptname>`
-| Script name | Description                                              |
-|-------------|----------------------------------------------------------|
-| `build`    | Re-compile the TypeScript sources.                       |
-| `watch`     | Re-compile the TypeScript sources and watch for changes. |
-| `test:ts`   | Executes the tests you defined in `*.test.ts` files.     |
-| `test:package`    | Ensures your `package.json` and `io-package.json` are valid. |
-| `test:unit`       | Tests the adapter startup with unit tests (fast, but might require module mocks to work). |
-| `test:integration`| Tests the adapter startup with an actual instance of ioBroker. |
-| `test` | Performs a minimal test run on package files and your tests. |
-| `coverage` | Generates code coverage using your test files. |
-### Writing tests
-When done right, testing code is invaluable, because it gives you the
-confidence to change your code while knowing exactly if and when
-something breaks. A good read on the topic of test-driven development
-is https://hackernoon.com/introduction-to-test-driven-development-tdd-61a13bc92d92.
-Although writing tests before the code might seem strange at first, but it has very
-clear upsides.
-The template provides you with basic tests for the adapter startup and package files.
-It is recommended that you add your own tests into the mix.
-### Publishing the adapter
-See the documentation of [ioBroker.repositories](https://github.com/ioBroker/ioBroker.repositories#requirements-for-adapter-to-get-added-to-the-latest-repository).
-### Test the adapter manually on a local ioBroker installation
-In order to install the adapter locally without publishing, the following steps are recommended:
-1. Create a tarball from your dev directory:
-    ```bash
-    npm pack
-    ```
-1. Upload the resulting file to your ioBroker host
-1. Install it locally (The paths are different on Windows):
-    ```bash
-    cd /opt/iobroker
-    npm i /path/to/tarball.tgz
-    ```
-For later updates, the above procedure is not necessary. Just do the following:
-1. Overwrite the changed files in the adapter directory (`/opt/iobroker/node_modules/iobroker.panasonic-comfort-cloud`)
-1. Execute `iobroker upload panasonic-comfort-cloud` on the ioBroker host
+Adapter to control devices in the Panasonic Comfort Cloud. It uses REST calls which are extracetd from the official Comfort Cloud app.
+To use the a adpter you need to enter your username and password in the configuration. They are used to authenticate access to the Comfort Cloud. Information of all devices is automatically retrieved and inserted as an object. The adpter polls the device information cyclically (see interval in the settings) and sends commands directly to the cloud.
+With the method used, only one client can be logged on with the account at a time.
+It is recommended that a second account, for which the devices have been shared, is used.
 ## Changelog
-### 0.0.1
-* (marc) initial release
+### 2.0.0
+* Added js-controller 3 dependency.
+* Added username and password to protectedNative and password to encryptedNative.
+* Added connection info.
+* Changed schdule to timeout for refresh.
+* Fixes for async await pattern.
+### 1.2.9
+* Error handling for get device added.
+### 1.2.8
+* Fixed bug in Comfort Cloud client.
+### 1.2.7
+* Comfort Cloud client updated.
+### 1.2.6
+* Fixed bug that guid is null in device creation.
+### 1.2.5
+* *Comfort Cloud client updated.
+### 1.2.4
+* Fixed bug with undefined guid. Log messages added.
+### 1.2.3
+* Set parameters only for writable states.
+### 1.2.2
+* *Fixed error handling and added stack info.
+### 1.2.1
+* Fixed bug in refesh device method.
+### 1.2.0
+* States insideTemperature, outTemperature and Nanoe added.
 ## License
 MIT License
-Copyright (c) 2019 marc <lammers.marc@gmail.com>
+Copyright (c) 2021 marc <marc@lammers.dev>
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

package/build/lib/tools.js CHANGED Viewed

@@ -9,6 +9,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
     });
 };
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.translateText = exports.isArray = exports.isObject = void 0;
 const axios_1 = require("axios");
 /**
  * Tests whether the given variable is a real object and not an Array
@@ -19,7 +20,7 @@ function isObject(it) {
     // typeof null === 'object'
     // typeof [] === 'object'
     // [] instanceof Object === true
-    return Object.prototype.toString.call(it) === "[object Object]";
+    return Object.prototype.toString.call(it) === '[object Object]';
 }
 exports.isObject = isObject;
 /**
@@ -29,7 +30,7 @@ exports.isObject = isObject;
 function isArray(it) {
     if (Array.isArray != null)
         return Array.isArray(it);
-    return Object.prototype.toString.call(it) === "[object Array]";
+    return Object.prototype.toString.call(it) === '[object Array]';
 }
 exports.isArray = isArray;
 /**
@@ -39,16 +40,16 @@ exports.isArray = isArray;
  */
 function translateText(text, targetLang) {
     return __awaiter(this, void 0, void 0, function* () {
-        if (targetLang === "en")
+        if (targetLang === 'en')
             return text;
         try {
             const url = `http://translate.googleapis.com/translate_a/single?client=gtx&sl=en&tl=${targetLang}&dt=t&q=${encodeURIComponent(text)}&ie=UTF-8&oe=UTF-8`;
-            const response = yield axios_1.default({ url, timeout: 5000 });
+            const response = yield (0, axios_1.default)({ url, timeout: 5000 });
             if (isArray(response.data)) {
                 // we got a valid response
                 return response.data[0][0][0];
             }
-            throw new Error("Invalid response for translate request");
+            throw new Error('Invalid response for translate request');
         }
         catch (e) {
             throw new Error(`Could not translate to "${targetLang}": ${e}`);

package/build/main.js CHANGED Viewed

@@ -16,67 +16,77 @@ Object.defineProperty(exports, "__esModule", { value: true });
 // you need to create an adapter
 const utils = require("@iobroker/adapter-core");
 const panasonic_comfort_cloud_client_1 = require("panasonic-comfort-cloud-client");
-const node_schedule_1 = require("node-schedule");
 const _ = require("lodash");
+const REFRESH_INTERVAL_IN_MINUTES_DEFAULT = 5;
 const comfortCloudClient = new panasonic_comfort_cloud_client_1.ComfortCloudClient();
 class PanasonicComfortCloud extends utils.Adapter {
     constructor(options = {}) {
-        super(Object.assign(Object.assign({}, options), { name: "panasonic-comfort-cloud" }));
-        this.on("ready", this.onReady.bind(this));
-        this.on("objectChange", this.onObjectChange.bind(this));
-        this.on("stateChange", this.onStateChange.bind(this));
+        super(Object.assign(Object.assign({}, options), { name: 'panasonic-comfort-cloud' }));
+        this.refreshIntervalInMinutes = REFRESH_INTERVAL_IN_MINUTES_DEFAULT;
+        this.readonlyStateNames = [];
+        this.on('ready', this.onReady.bind(this));
+        this.on('objectChange', this.onObjectChange.bind(this));
+        this.on('stateChange', this.onStateChange.bind(this));
         // this.on('message', this.onMessage.bind(this));
-        this.on("unload", this.onUnload.bind(this));
+        this.on('unload', this.onUnload.bind(this));
     }
     /**
      * Is called when databases are connected and adapter received configuration.
      */
     onReady() {
-        var _a;
+        var _a, _b, _c, _d;
         return __awaiter(this, void 0, void 0, function* () {
-            const refreshInterval = (_a = this.config.refreshInterval) !== null && _a !== void 0 ? _a : 5;
-            this.refreshJob = node_schedule_1.scheduleJob(`*/${refreshInterval} * * * *`, this.refreshDevices.bind(this));
-            this.subscribeStates("*");
-            try {
-                this.log.debug(`Try to login with username ${this.config.username}.`);
-                yield comfortCloudClient.login(this.config.username, this.config.password);
-                this.log.info("Login successful.");
-                this.log.debug("Create devices.");
-                const groups = yield comfortCloudClient.getGroups();
-                this.createDevices(groups);
+            this.refreshIntervalInMinutes = (_b = (_a = this.config) === null || _a === void 0 ? void 0 : _a.refreshInterval) !== null && _b !== void 0 ? _b : REFRESH_INTERVAL_IN_MINUTES_DEFAULT;
+            this.subscribeStates('*');
+            this.setState('info.connection', false, true);
+            if (!((_c = this.config) === null || _c === void 0 ? void 0 : _c.username) || !((_d = this.config) === null || _d === void 0 ? void 0 : _d.password)) {
+                this.log.error('Can not start without username or password. Please open config.');
             }
-            catch (error) {
-                this.handleClientError(error);
+            else {
+                try {
+                    this.log.debug(`Try to login with username ${this.config.username}.`);
+                    yield comfortCloudClient.login(this.config.username, this.config.password);
+                    this.log.info('Login successful.');
+                    this.setState('info.connection', true, true);
+                    this.log.debug('Create devices.');
+                    const groups = yield comfortCloudClient.getGroups();
+                    yield this.createDevices(groups);
+                    this.setupRefreshTimeout();
+                }
+                catch (error) {
+                    yield this.handleClientError(error);
+                }
             }
         });
     }
     refreshDeviceStates(device) {
-        this.log.debug(`Refresh device ${device.name} (${device.guid}).`);
-        this.log.debug(`${device.name}: guid => ${device.guid}.`);
-        this.setStateChangedAsync(`${device.name}.guid`, device.guid, true);
-        this.log.debug(`${device.name}: operate => ${device.operate}.`);
-        this.setStateChangedAsync(`${device.name}.operate`, device.operate, true);
-        this.log.debug(`${device.name}: temperatureSet => ${device.temperatureSet}.`);
-        this.setStateChangedAsync(`${device.name}.temperatureSet`, device.temperatureSet, true);
-        this.log.debug(`${device.name}: insideTemperature => ${device.insideTemperature}.`);
-        this.setStateChangedAsync(`${device.name}.insideTemperature`, device.insideTemperature, true);
-        this.log.debug(`${device.name}: outTemperature => ${device.outTemperature}.`);
-        this.setStateChangedAsync(`${device.name}.outTemperature`, device.outTemperature, true);
-        this.log.debug(`${device.name}: airSwingLR => ${device.airSwingLR}.`);
-        this.setStateChangedAsync(`${device.name}.airSwingLR`, device.airSwingLR, true);
-        this.log.debug(`${device.name}: airSwingUD => ${device.airSwingUD}.`);
-        this.setStateChangedAsync(`${device.name}.airSwingUD`, device.airSwingUD, true);
-        this.log.debug(`${device.name}: fanAutoMode => ${device.fanAutoMode}.`);
-        this.setStateChangedAsync(`${device.name}.fanAutoMode`, device.fanAutoMode, true);
-        this.log.debug(`${device.name}: ecoMode => ${device.ecoMode}.`);
-        this.setStateChangedAsync(`${device.name}.ecoMode`, device.ecoMode, true);
-        this.log.debug(`${device.name}: operationMode => ${device.operationMode}.`);
-        this.setStateChangedAsync(`${device.name}.operationMode`, device.operationMode, true);
-        this.log.debug(`${device.name}: fanSpeed => ${device.fanSpeed}.`);
-        this.setStateChangedAsync(`${device.name}.fanSpeed`, device.fanSpeed, true);
-        this.log.debug(`${device.name}: actualNanoe => ${device.actualNanoe}.`);
-        this.setStateChangedAsync(`${device.name}.actualNanoe`, device.actualNanoe, true);
-        this.log.debug(`Refresh device ${device.name} finished.`);
+        return __awaiter(this, void 0, void 0, function* () {
+            this.log.debug(`Refresh device ${device.name} (${device.guid}).`);
+            this.log.debug(`${device.name}: guid => ${device.guid}.`);
+            this.log.debug(`${device.name}: operate => ${device.operate}.`);
+            yield this.setStateChangedAsync(`${device.name}.operate`, device.operate, true);
+            this.log.debug(`${device.name}: temperatureSet => ${device.temperatureSet}.`);
+            yield this.setStateChangedAsync(`${device.name}.temperatureSet`, device.temperatureSet, true);
+            this.log.debug(`${device.name}: insideTemperature => ${device.insideTemperature}.`);
+            yield this.setStateChangedAsync(`${device.name}.insideTemperature`, device.insideTemperature, true);
+            this.log.debug(`${device.name}: outTemperature => ${device.outTemperature}.`);
+            yield this.setStateChangedAsync(`${device.name}.outTemperature`, device.outTemperature, true);
+            this.log.debug(`${device.name}: airSwingLR => ${device.airSwingLR}.`);
+            yield this.setStateChangedAsync(`${device.name}.airSwingLR`, device.airSwingLR, true);
+            this.log.debug(`${device.name}: airSwingUD => ${device.airSwingUD}.`);
+            yield this.setStateChangedAsync(`${device.name}.airSwingUD`, device.airSwingUD, true);
+            this.log.debug(`${device.name}: fanAutoMode => ${device.fanAutoMode}.`);
+            yield this.setStateChangedAsync(`${device.name}.fanAutoMode`, device.fanAutoMode, true);
+            this.log.debug(`${device.name}: ecoMode => ${device.ecoMode}.`);
+            yield this.setStateChangedAsync(`${device.name}.ecoMode`, device.ecoMode, true);
+            this.log.debug(`${device.name}: operationMode => ${device.operationMode}.`);
+            yield this.setStateChangedAsync(`${device.name}.operationMode`, device.operationMode, true);
+            this.log.debug(`${device.name}: fanSpeed => ${device.fanSpeed}.`);
+            yield this.setStateChangedAsync(`${device.name}.fanSpeed`, device.fanSpeed, true);
+            this.log.debug(`${device.name}: actualNanoe => ${device.actualNanoe}.`);
+            yield this.setStateChangedAsync(`${device.name}.actualNanoe`, device.actualNanoe, true);
+            this.log.debug(`Refresh device ${device.name} finished.`);
+        });
     }
     refreshDevice(guid, deviceName) {
         return __awaiter(this, void 0, void 0, function* () {
@@ -88,18 +98,19 @@ class PanasonicComfortCloud extends utils.Adapter {
                 if (!device.name) {
                     device.name = deviceName;
                 }
-                this.refreshDeviceStates(device);
+                yield this.refreshDeviceStates(device);
             }
             catch (error) {
-                this.handleClientError(error);
+                yield this.handleClientError(error);
             }
         });
     }
     refreshDevices() {
         return __awaiter(this, void 0, void 0, function* () {
             try {
-                this.log.debug("Refresh all devices.");
+                this.log.debug('Refresh all devices.');
                 const groups = yield comfortCloudClient.getGroups();
+                this.setState('info.connection', true, true);
                 const devices = _.flatMap(groups, g => g.devices);
                 const deviceInfos = _.map(devices, d => { return { guid: d.guid, name: d.name }; });
                 yield Promise.all(deviceInfos.map((deviceInfo) => __awaiter(this, void 0, void 0, function* () {
@@ -107,12 +118,12 @@ class PanasonicComfortCloud extends utils.Adapter {
                     if (device != null) {
                         device.name = deviceInfo.name;
                         device.guid = deviceInfo.guid;
-                        this.refreshDeviceStates(device);
+                        yield this.refreshDeviceStates(device);
                     }
                 })));
             }
             catch (error) {
-                this.handleClientError(error);
+                yield this.handleClientError(error);
             }
         });
     }
@@ -126,36 +137,49 @@ class PanasonicComfortCloud extends utils.Adapter {
             const deviceInfos = _.map(devicesFromService, d => { return { guid: d.guid, name: d.name }; });
             yield Promise.all(deviceInfos.map((deviceInfo) => __awaiter(this, void 0, void 0, function* () {
                 this.log.debug(`Device info from group ${deviceInfo.guid}, ${deviceInfo.name}.`);
-                const device = yield comfortCloudClient.getDevice(deviceInfo.guid);
+                let device = null;
+                try {
+                    device = yield comfortCloudClient.getDevice(deviceInfo.guid);
+                }
+                catch (error) {
+                    yield this.handleClientError(error);
+                }
                 if (device != null) {
                     if (_.includes(names, deviceInfo.name)) {
                         return;
                     }
                     this.createDevice(deviceInfo.name);
-                    this.createState(deviceInfo.name, "", "guid", { role: "text", write: false, def: device.guid }, undefined);
-                    this.createState(deviceInfo.name, "", "operate", {
-                        role: "state",
+                    this.createState(deviceInfo.name, '', 'guid', { role: 'info.address', write: false, def: deviceInfo.guid, type: 'string' }, undefined);
+                    this.readonlyStateNames.push('guid');
+                    this.createState(deviceInfo.name, '', 'operate', {
+                        role: 'switch.power',
                         states: { 0: panasonic_comfort_cloud_client_1.Power[0], 1: panasonic_comfort_cloud_client_1.Power[1] },
                         write: true,
                         def: device.operate,
+                        type: 'string',
                     }, undefined);
-                    this.createState(deviceInfo.name, "", "temperatureSet", {
-                        role: "level.temperature",
+                    this.createState(deviceInfo.name, '', 'temperatureSet', {
+                        role: 'level.temperature',
                         write: true,
                         def: device.temperatureSet,
+                        type: 'number',
                     }, undefined);
-                    this.createState(deviceInfo.name, "", "insideTemperature", {
-                        role: "state",
+                    this.createState(deviceInfo.name, '', 'insideTemperature', {
+                        role: 'level.temperature',
                         write: false,
                         def: device.insideTemperature,
+                        type: 'number',
                     }, undefined);
-                    this.createState(deviceInfo.name, "", "outTemperature", {
-                        role: "state",
+                    this.readonlyStateNames.push('insideTemperature');
+                    this.createState(deviceInfo.name, '', 'outTemperature', {
+                        role: 'level.temperature',
                         write: false,
                         def: device.outTemperature,
+                        type: 'number',
                     }, undefined);
-                    this.createState(deviceInfo.name, "", "airSwingLR", {
-                        role: "state",
+                    this.readonlyStateNames.push('outTemperature');
+                    this.createState(deviceInfo.name, '', 'airSwingLR', {
+                        role: 'state',
                         states: {
                             0: panasonic_comfort_cloud_client_1.AirSwingLR[0],
                             1: panasonic_comfort_cloud_client_1.AirSwingLR[1],
@@ -165,9 +189,10 @@ class PanasonicComfortCloud extends utils.Adapter {
                         },
                         write: true,
                         def: device.airSwingLR,
+                        type: 'string',
                     }, undefined);
-                    this.createState(deviceInfo.name, "", "airSwingUD", {
-                        role: "state",
+                    this.createState(deviceInfo.name, '', 'airSwingUD', {
+                        role: 'state',
                         states: {
                             0: panasonic_comfort_cloud_client_1.AirSwingUD[0],
                             1: panasonic_comfort_cloud_client_1.AirSwingUD[1],
@@ -177,9 +202,10 @@ class PanasonicComfortCloud extends utils.Adapter {
                         },
                         write: true,
                         def: device.airSwingUD,
+                        type: 'string',
                     }, undefined);
-                    this.createState(deviceInfo.name, "", "fanAutoMode", {
-                        role: "state",
+                    this.createState(deviceInfo.name, '', 'fanAutoMode', {
+                        role: 'state',
                         states: {
                             0: panasonic_comfort_cloud_client_1.FanAutoMode[0],
                             1: panasonic_comfort_cloud_client_1.FanAutoMode[1],
@@ -188,15 +214,17 @@ class PanasonicComfortCloud extends utils.Adapter {
                         },
                         write: true,
                         def: device.fanAutoMode,
+                        type: 'string',
                     }, undefined);
-                    this.createState(deviceInfo.name, "", "ecoMode", {
-                        role: "state",
+                    this.createState(deviceInfo.name, '', 'ecoMode', {
+                        role: 'state',
                         states: { 0: panasonic_comfort_cloud_client_1.EcoMode[0], 1: panasonic_comfort_cloud_client_1.EcoMode[1], 2: panasonic_comfort_cloud_client_1.EcoMode[2] },
                         write: true,
                         def: device.ecoMode,
+                        type: 'string',
                     }, undefined);
-                    this.createState(deviceInfo.name, "", "operationMode", {
-                        role: "state",
+                    this.createState(deviceInfo.name, '', 'operationMode', {
+                        role: 'state',
                         states: {
                             0: panasonic_comfort_cloud_client_1.OperationMode[0],
                             1: panasonic_comfort_cloud_client_1.OperationMode[1],
@@ -206,9 +234,10 @@ class PanasonicComfortCloud extends utils.Adapter {
                         },
                         write: true,
                         def: device.operationMode,
+                        type: 'string',
                     }, undefined);
-                    this.createState(deviceInfo.name, "", "fanSpeed", {
-                        role: "state",
+                    this.createState(deviceInfo.name, '', 'fanSpeed', {
+                        role: 'state',
                         states: {
                             0: panasonic_comfort_cloud_client_1.FanSpeed[0],
                             1: panasonic_comfort_cloud_client_1.FanSpeed[1],
@@ -219,9 +248,10 @@ class PanasonicComfortCloud extends utils.Adapter {
                         },
                         write: true,
                         def: device.fanSpeed,
+                        type: 'string',
                     }, undefined);
-                    this.createState(deviceInfo.name, "", "actualNanoe", {
-                        role: "state",
+                    this.createState(deviceInfo.name, '', 'actualNanoe', {
+                        role: 'state',
                         states: {
                             0: panasonic_comfort_cloud_client_1.NanoeMode[0],
                             1: panasonic_comfort_cloud_client_1.NanoeMode[1],
@@ -231,16 +261,17 @@ class PanasonicComfortCloud extends utils.Adapter {
                         },
                         write: true,
                         def: device.actualNanoe,
+                        type: 'string',
                     }, undefined);
                     this.log.info(`Device ${deviceInfo.name} created.`);
                 }
             })));
-            this.log.debug("Device creation completed.");
+            this.log.debug('Device creation completed.');
         });
     }
     updateDevice(deviceName, stateName, state) {
         return __awaiter(this, void 0, void 0, function* () {
-            if (stateName == 'guid') {
+            if (this.readonlyStateNames.includes(stateName)) {
                 return;
             }
             if (!state.ack) {
@@ -263,7 +294,7 @@ class PanasonicComfortCloud extends utils.Adapter {
                     yield this.refreshDevice(guidState === null || guidState === void 0 ? void 0 : guidState.val, deviceName);
                 }
                 catch (error) {
-                    this.handleClientError(error);
+                    yield this.handleClientError(error);
                 }
             }
         });
@@ -272,10 +303,10 @@ class PanasonicComfortCloud extends utils.Adapter {
      * Is called when adapter shuts down - callback has to be called under any circumstances!
      */
     onUnload(callback) {
-        var _a;
         try {
-            this.log.info("cleaned everything up...");
-            (_a = this.refreshJob) === null || _a === void 0 ? void 0 : _a.cancel();
+            if (this.refreshTimeout)
+                clearTimeout(this.refreshTimeout);
+            this.log.info('cleaned everything up...');
             callback();
         }
         catch (e) {
@@ -299,35 +330,63 @@ class PanasonicComfortCloud extends utils.Adapter {
      * Is called if a subscribed state changes
      */
     onStateChange(id, state) {
-        if (state) {
-            const elements = id.split(".");
-            const deviceName = elements[elements.length - 2];
-            const stateName = elements[elements.length - 1];
-            this.updateDevice(deviceName, stateName, state);
-            // The state was changed
-            this.log.info(`state ${id} changed: ${state.val} (ack = ${state.ack})`);
-        }
-        else {
-            // The state was deleted
-            this.log.info(`state ${id} deleted`);
-        }
+        return __awaiter(this, void 0, void 0, function* () {
+            if (state) {
+                const elements = id.split('.');
+                const deviceName = elements[elements.length - 2];
+                const stateName = elements[elements.length - 1];
+                try {
+                    yield this.updateDevice(deviceName, stateName, state);
+                }
+                catch (error) {
+                    yield this.handleClientError(error);
+                }
+                // The state was changed
+                this.log.info(`state ${id} changed: ${state.val} (ack = ${state.ack})`);
+            }
+            else {
+                // The state was deleted
+                this.log.info(`state ${id} deleted`);
+            }
+        });
     }
     handleClientError(error) {
         return __awaiter(this, void 0, void 0, function* () {
-            this.log.debug("Try to handle error.");
+            this.log.debug('Try to handle error.');
             if (error instanceof panasonic_comfort_cloud_client_1.TokenExpiredError) {
                 this.log.info(`Token of comfort cloud client expired. Trying to login again. Code=${error.code}. Stack: ${error.stack}`);
+                this.setState('info.connection', false, true);
                 yield comfortCloudClient.login(this.config.username, this.config.password);
-                this.log.info("Login successful.");
+                this.setState('info.connection', true, true);
+                this.log.info('Login successful.');
             }
             else if (error instanceof panasonic_comfort_cloud_client_1.ServiceError) {
+                this.setState('info.connection', false, true);
                 this.log.error(`Service error: ${error.message}. Code=${error.code}. Stack: ${error.stack}`);
             }
-            else {
+            else if (error instanceof Error) {
                 this.log.error(`Unknown error: ${error}. Stack: ${error.stack}`);
             }
         });
     }
+    setupRefreshTimeout() {
+        this.log.debug('setupRefreshTimeout');
+        const refreshIntervalInMilliseconds = this.refreshIntervalInMinutes * 60 * 1000;
+        this.log.debug(`refreshIntervalInMilliseconds=${refreshIntervalInMilliseconds}`);
+        this.refreshTimeout = setTimeout(this.refreshTimeoutFunc.bind(this), refreshIntervalInMilliseconds);
+    }
+    refreshTimeoutFunc() {
+        return __awaiter(this, void 0, void 0, function* () {
+            this.log.debug(`refreshTimeoutFunc started.`);
+            try {
+                yield this.refreshDevices();
+                this.setupRefreshTimeout();
+            }
+            catch (error) {
+                yield this.handleClientError(error);
+            }
+        });
+    }
 }
 if (module.parent) {
     // Export the constructor in compact mode

package/io-package.json CHANGED Viewed

@@ -1,8 +1,28 @@
 {
     "common": {
         "name": "panasonic-comfort-cloud",
-        "version": "1.2.5",
+        "version": "2.0.0",
         "news": {
+            "2.0.0": {
+                "en": "Added js-controller 3 dependency.\nAdded username and password to protectedNative and password to encryptedNative.\nAdded connection info.\nChanged schdule to timeout for refresh.\nFixes for async await pattern.",
+                "de": "js-controller 3 als Abhängigkeit eingefügt.\nusername und password zu protectedNative und password zu encryptedNative hinzugefügt.\nconnection info als Status eingefügt.\nSchudle durch timeout für die Geräteaktualisierung erstezt.\nAsync und await überall korrekt berücksichtig."
+            },
+            "1.2.9": {
+                "en": "Error handling for get device added.",
+                "de": "Fehlerbehandlung beim Abrufen des Geräts hinzugefügt."
+            },
+            "1.2.8": {
+                "en": "Fixed bug in Comfort Cloud client.",
+                "de": "Fehler in Comfort Cloud client behoben."
+            },
+            "1.2.7": {
+                "en": "Comfort Cloud client updated.",
+                "de": "Comfort Cloud client aktualisiert."
+            },
+            "1.2.6": {
+                "en": "Fixed bug that guid is null in device creation.",
+                "de": "Fehler behoben, dass die GUID bei der Geräteerstellung null ist."
+            },
             "1.2.5": {
                 "en": "Comfort Cloud client updated.",
                 "de": "Comfort Cloud client aktualisiert."
@@ -85,6 +105,8 @@
         "keywords": ["air condition"],
         "license": "MIT",
         "platform": "Javascript/Node.js",
+        "connectionType": "cloud",
+        "dataSource": "poll",
         "main": "build/main.js",
         "icon": "panasonic-comfort-cloud.png",
         "enabled": true,
@@ -95,17 +117,51 @@
         "type": "climate-control",
         "compact": true,
         "materialize": true,
+        "globalDependencies": [
+            {
+                "admin": ">=4.0.9"
+            }
+        ],
         "dependencies": [
             {
-                "js-controller": ">=1.4.2"
+                "js-controller": ">=3.0.0"
             }
         ]
     },
     "native": {
         "username": "",
-        "password": ""
+        "password": "",
+        "refreshInterval": 5
     },
-    "protectedNative": ["password"],
+    "protectedNative": [
+        "username",
+        "password"
+    ],
+    "encryptedNative": [
+        "password"
+    ],
     "objects": [],
-    "instanceObjects": []
+    "instanceObjects": [
+        {
+            "_id": "info",
+            "type": "channel",
+            "common": {
+                "name": "Information"
+            },
+            "native": {}
+        },
+        {
+            "_id": "info.connection",
+            "type": "state",
+            "common": {
+                "role": "indicator.connected",
+                "name": "Device or service connected",
+                "type": "boolean",
+                "read": true,
+                "write": false,
+                "def": false
+            },
+            "native": {}
+        }
+    ]
 }

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
     "name": "iobroker.panasonic-comfort-cloud",
-    "version": "1.2.5",
+    "version": "2.0.0",
     "description": "Adapter for Panasonic Comfort Cloud",
     "author": {
         "name": "marc",
@@ -16,16 +16,14 @@
         "url": "https://github.com/marc2016/ioBroker.panasonic-comfort-cloud"
     },
     "dependencies": {
-        "@iobroker/adapter-core": "^2.3.1",
+        "@iobroker/adapter-core": "^2.5.1",
         "@types/lodash": "^4.14.149",
-        "@types/node-schedule": "^1.3.0",
         "lodash": "^4.17.15",
-        "node-schedule": "^1.3.2",
-        "panasonic-comfort-cloud-client": "^1.1.2",
+        "panasonic-comfort-cloud-client": "^1.1.4",
         "ts-enum-util": "^4.0.1"
     },
     "devDependencies": {
-        "@iobroker/testing": "^1.3.0",
+        "@iobroker/testing": "^2.5.4",
         "@types/chai": "^4.2.4",
         "@types/chai-as-promised": "^7.1.2",
         "@types/gulp": "^4.0.6",
@@ -48,7 +46,7 @@
         "sinon-chai": "^3.3.0",
         "source-map-support": "^0.5.16",
         "ts-node": "^8.4.1",
-        "typescript": "^3.8.3"
+        "typescript": "^4.5.4"
     },
     "main": "build/main.js",
     "scripts": {
@@ -60,7 +58,7 @@
         "test:ts": "mocha --opts test/mocha.custom.opts",
         "test:package": "mocha test/package --exit",
         "test:unit": "mocha test/unit --exit",
-        "test:integration": "mocha test/integration --exit",
+        "test:integration": "mocha test/integration --timeout 120000 --exit",
         "test": "npm run test:ts && npm run test:package",
         "lint": "eslint --ext .ts src"
     },

package/.github/ISSUE_TEMPLATE/bug_report.md DELETED Viewed

@@ -1,32 +0,0 @@
----
-name: Bug report
-about: Something is not working as it should
-title: ''
-labels: ''
-assignees: ''
----
-**Describe the bug**
-A clear and concise description of what the bug is.
-**To Reproduce**
-Steps to reproduce the behavior:
-1. Go to '...'
-2. Click on '...'
-3. Scroll down to '....'
-4. See error
-**Expected behavior**
-A clear and concise description of what you expected to happen.
-**Screenshots & Logfiles**
-If applicable, add screenshots and logfiles to help explain your problem.
-**Versions:**
- - Adapter version: <adapter-version>
- - JS-Controller version: <js-controller-version> <!-- determine this with `iobroker -v` on the console -->
- - Node version: <node-version> <!-- determine this with `node -v` on the console -->
- - Operating system: <os-name>
-**Additional context**
-Add any other context about the problem here.

package/iob_npm.done DELETED Viewed

	@@ -1 +0,0 @@
1	-