iobroker.openknx 0.4.4 → 0.5.0

package/README.md

@@ -50,14 +50,22 @@ This settings protects the KNX bus from data flooding by limiting data frames to
 Not sent frames are delay until the delay time since last send on bus is elapsed. If more send requests are waiting, send order is random.
 If you experience disconnects from your KNX IP Gateway in the log then increase this number.
 
+### use common.type boolean for 1 bit enum instead of number
+
+Use in IOB Object common.type boolean for 1 bit enum instead of number.
+
 ### readout values of autoread iob objects on startup
 
 All IOB objects that are configured with the autoread flag are requested on the bus to be synchronized with IOB.
 
-### Add only new Objects
+### import only GAs that do not exist in IOB objects
 
 If checked, the import will skip overwriting existing communication objects.
 
+### remove existing IOB objects thtat are not in import file
+
+To clean up object tree
+
 ### Import XML from ETS
 
 ![ETS export](docs/pictures/exportGA.png)
@@ -162,12 +170,14 @@ The whole name including path is used to check for similarity.
 
 # howto use the adapter & basic concept
 
-### ACK flags
+### ACK flags with tunneling connections
 
-Applications shall never set ack flags, application is notified from this adapter by the ack flag if data is updated.
+Applications shall not set the ack flag, application is notified from this adapter by the ack flag if data is updated.
 KNX Stack sets the ack flag of the corresponding IoBroker object on receiption of a group address if another knx host writes to the bus.
-Sent frames on KNX triggered by application writing to a object does not result into an immediate acknowledgement message to that object.
-If the write is coming from this adapter, the the ack flag is generated on postivive confirmance in tunneling mode.
+
+|GA is | connected to device with a R flag | connected to devices with no R flag | unconnected
+|Application issues GroupValue_Write | ack | ack | no ack
+|Application issues GroupValue_Read | ack | no ack | no ack
 
 ### Node Red complex datatype example
 
@@ -211,7 +221,7 @@ Autoread is set to false where it is clear from the DPT that this is a trigger s
         "bitlength": 1, // size ob knx data, derived from dpt
         "dpt": "DPT1.001", // DPT
         "encoding": {
-            // informative
+            // values of the interface if it is an enum DPT type
             "0": "Off",
             "1": "On"
         },
@@ -267,7 +277,7 @@ GroupValue_Read comment does not work for javascript adapter. Use qualityAsNumbe
 
 | KNX DPT   | javascript datatype    | special values                                                                                       | value range                               | remark                                                |
 | --------- | ---------------------- | ---------------------------------------------------------------------------------------------------- | ----------------------------------------- | ----------------------------------------------------- |
-| DPT-1     | boolean                |                                                                                                      | false, true                               |                                                       |
+| DPT-1     | number enum            |                                                                                                      | false, true                               |                                                       |
 | DPT-2     | object                 | {"priority":1 bit,"data":1 bit}                                                                      | -                                         |                                                       |
 | DPT-3     | object                 | {"decr_incr":1 bit,"data":2 bit}                                                                     | -                                         |                                                       |
 | DPT-18    | object                 | {"save_recall":0,"scenenumber":0}                                                                    | -                                         | Datapoint Type DPT_SceneControl removed from autoread |
@@ -359,16 +369,17 @@ Data is sent to Iobroker Sentry server hosted in Germany. If you have allowed io
 -   create joint alias objects that react on status inputs
 -   supports project of all possible group address styles
 
-# Known Problems
-
--   none
-
 # Limitations
 
 -   ETS 4 export file format is not supported
 -   KNX secure is not supported
 -   only IPv4 supported
 
+# FAQ
+
+-   Autoread trigger actors on the bus to react
+    Check in ETS if group objects of certain devices that are connected to the suspicious GA have the R/L flag configured. This should not be the case if te device is a consumer of the signal. If the signal has an event character, a groupValueRead would trigger that event. Change configuration in ETS or disable autoread for this object.
+
 ## Changelog
 
 <!--
@@ -377,7 +388,13 @@ Data is sent to Iobroker Sentry server hosted in Germany. If you have allowed io
   * .... -> this is used by script to generate a new entry, copy after a new release
   * npm run release major/minor/patch major.minor.patch
 -->
-### 0.4.4 (2022-12-18)
+### 0.5.0 (2022-12-30)
+
+-   feature: use common.type boolean for 1 bit enum instead of number
+    import enum with one bit as common.type mixed and not strict as number
+-   handling of iob ack improved for tunneling connections, see description
+
+### 0.4.5 (2022-12-19)
 
 -   bugfix in knx lib: make dpt2 not an enum datatype
 

package/admin/index_m.html

@@ -66,6 +66,7 @@
                     if (isAlive && !window.isProcessingRequest) {
                         $("#onlyAddNewObjects").removeClass("disabled");
                         $("#autoreadEnabled").removeClass("disabled");
+                        $("#useBoolean").removeClass("disabled");
                         $("#removeUnusedObjects").removeClass("disabled");
                         $("#setAckOnWrite").removeClass("disabled");
                         $(".file-field .btn").removeClass("disabled");
@@ -83,6 +84,7 @@
             if (settings.minimumDelay === undefined) settings.minimumDelay = 50;
             if (settings.onlyAddNewObjects === undefined) settings.onlyAddNewObjects = false;
             if (settings.autoreadEnabled === undefined) settings.autoreadEnabled = false;
+            if (settings.useBoolean === undefined) settings.useBoolean = false;
             if (settings.removeUnusedObjects === undefined) settings.removeUnusedObjects = false;
             if (settings.localInterface === undefined) settings.localInterface = "";
             if (settings.setAckOnWrite === undefined) settings.setAckOnWrite = false;
@@ -382,12 +384,16 @@
                     <div class="row">
                         <div class="col s12 input-field">
                             <input class="value" id="onlyAddNewObjects" type="checkbox" />
-                            <label class="translate" for="onlyAddNewObjects">import only GAs that do not exist already in IOB objects</label>
+                            <label class="translate" for="onlyAddNewObjects">import only GAs that do not exist in IOB objects</label>
                         </div>
                         <div class="col s12 input-field">
                             <input class="value" id="removeUnusedObjects" type="checkbox" />
                             <label class="translate" for="removeUnusedObjects">remove existing IOB objects that are not in import file</label>
                         </div>
+                        <div class="col s12 input-field">
+                            <input class="value" id="useBoolean" type="checkbox" />
+                            <label class="translate" for="useBoolean">use common.type boolean for 1 bit enum instead of number</label>
+                        </div>
 
                         <div class="col s12 m12 l6 file-field input-field">
                             <div class="btn" id="fileUploadButton"><i class="material-icons right">input</i>

package/io-package.json

@@ -1,8 +1,34 @@
 {
   "common": {
     "name": "openknx",
-    "version": "0.4.4",
+    "version": "0.5.0",
     "news": {
+      "0.5.0": {
+        "en": "-   feature: use common.type boolean for 1 bit enum instead of number\n    import enum with one bit as common.type mixed and not strict as number\n-   handling of iob ack improved for tunneling connections, see description",
+        "de": "- feature: verwenden sie gemeinsam. typ boolean für 1 bit enum statt anzahl\nimport enum mit ein bisschen wie üblich. typ gemischt und nicht streng als zahl\n- handhabung von iob ack verbessert für tunnelverbindungen, siehe beschreibung",
+        "ru": "- функция: использовать общий. тип boolean для 1 бит enum вместо номера\nимпорт enum с одним битом как общий. тип смешанный и не строгий как номер\n- обработка iob ack улучшена для туннелирования соединения, см. описание",
+        "pt": "- recurso: use comum. tipo booleano para 1 bit enum em vez de número\nimportação enum com um pouco como comum. tipo misturado e não estrito como número\n- manipulação de iob ack melhorado para conexões de túnel, ver descrição",
+        "nl": "gebruik gewoon. typ boolean voor 1 cent in plaats van nummer\nimporteer met een beetje zoals gewoonlijk. gemengd en niet strikt als nummer\n- behandelen met iob ack verbeterd voor tunnelverbindingen",
+        "fr": "- caractéristique: utilisation commune. type booléen pour 1 bit enum au lieu du nombre\nimporter enum avec un peu comme commun. type mélangé et non strict\n- le traitement de l'iob ack amélioré pour les connexions de tunnel, voir la description",
+        "it": "- caratteristica: utilizzare comune. tipo boolean per 1 bit enum invece del numero\nimportare enum con un bit come comune. tipo misto e non rigoroso come numero\n- la gestione dell'attacco iob migliorata per i collegamenti di tunneling, vedi descrizione",
+        "es": "- función: usar común. tipo booleano por 1 bit enum en lugar de número\nimporta enum con un poco como común. tipo mixto y no estricto como número\n- manejo de iob ack mejorado para conexiones de túnel, ver descripción",
+        "pl": "wykorzystywanie: wspólne. bulean na 1 bit enum zamiast numeru\nzawartość z jednym bitem jako powszechna. mieszany i nie ścisły\n- obsługa iob udoskonalona dla połączeń tunelowych, zobacz opis iob",
+        "uk": "- функція: використання загального. тип булеан для 1 біт енму замість кількості\nімпортувати енму з одним бітом, як поширений. тип змішаних і не строгий як номер\n- обробка iob ack поліпшена для зв'язків з тунелями, див. опис",
+        "zh-cn": "- 特征:共同使用。 第1条的诱惑而不是数量\n进口有一处是普通的。 类型混杂不清\n- 对隧道的处理改良了碘包,见说明"
+      },
+      "0.4.5": {
+        "en": "bugfix in knx lib: make dpt2 not an enum datatype",
+        "de": "bugfix in knx lib: dpt2 nicht enum datatype",
+        "ru": "bugfix в knx lib: сделать dpt2 не enum datatype",
+        "pt": "bugfix em knx lib: fazer dpt2 não um tipo de dados enum",
+        "nl": "maak dpt2 geen enum datat",
+        "fr": "bugfix in knx lib: make dpt2 not an enum datatype",
+        "it": "bugfix in knx lib: make dpt2 not an enum datatype",
+        "es": "bugfix en knx lib: make dpt2 not an enum datatype",
+        "pl": "uszkodzenia w knx lib: czynić dpt2 nie enum datatype",
+        "uk": "виправлення помилок в knx lib: зробити dpt2 нетипові дані",
+        "zh-cn": "b knx lib的ugfix:d2不含一种全局数据。"
+      },
       "0.4.4": {
         "en": "bugfix in knx lib: make dpt2 not an enum datatype",
         "de": "bugfix in knx lib: dpt2 nicht enum datatype",
@@ -67,19 +93,6 @@
         "pl": "wygląd: wspieranie Free and Two Level Group Address Style, oprócz istniejącego Trzech poziomów, 320\ncechą charakterystyczną mapy knx jest konsekracja obiektu wspólnego. #313\ndebug message",
         "uk": "функція: підтримка безкоштовного та дворівневого групового стилю, крім існуючої трирівневої підтримки #320\nфункція: кодування типу кнкс для об'єкта спільного. стани #313\ndebug повідомлення для відправки розміру черги",
         "zh-cn": "特点:除了现有三级支助第320号行动之外,支持自由和二级组处理Style。\n特征:图千x数据点类型与目标一致。 第313号声明\nd. 发出呼吁规模的信息"
-      },
-      "0.3.2": {
-        "en": "feature: sync knx library\nfeature: sync with create adapter 0.2.3\nfeature: update to newer versions of dependant packages\nfeature: setting autoreadEnabled autoread\nbugfix: allow alias generation with missing gateway configuration\nbugfix in knx lib: keep correct order of send datagrams in case of burst write",
-        "de": "feature: sync knx bibliothek\nfeature: sync mit adapter erstellen 0.2.3\nfeature: update auf neuere versionen von abhängigen paketen\nfunktion: autoread einstellen Autoread aktivieren\nbugfix: alias-generation mit fehlender gateway-konfiguration erlauben\nbugfix in knx lib: korrekte reihenfolge des sendens von datengrammen bei burst-schreiben",
-        "ru": "функция: синхронизация knx библиотека\nособенность: синхронизация с созданием адаптера 0.2.3\nфункция: обновление до новых версий зависящих пакетов\nфункция: настройка autoread Включенный автопрочитан\nbugfix: позвольте псевдониму генерации с недостающей конфигурацией шлюза\nbugfix в knx lib: держите правильный порядок отправки данных в случае захоронения напишите",
-        "pt": "característica: biblioteca de sincronização knx\ncaracterística: sincronização com criar adaptador 0.2.3\nrecurso: atualização para versões mais recentes de pacotes dependentes\ncaracterística: definição de autoread Autoread habilitado\nbugfix: permitir a geração de alias com configuração de gateway ausente\nbugfix em knx lib: manter a ordem correta de enviar datagramas em caso de explosão escrever",
-        "nl": "vertaling:\nvertaling:\nvertaling:\nvertaling: Geautoread\nvertaling:\nbewaar de juiste volgorde van het versturen van gegevens in geval van ontploffing",
-        "fr": "fonction: bibliothèque sync knx\nfonction: synchronisation avec adaptateur de création 0.2.3\nfonction: mise à jour de nouvelles versions de paquets dépendants\nfonction: réglage automatique Autoread activé\nbugfix: permettre la génération d'alias avec la configuration de passerelle manquante\nbugfix in knx lib: garder l'ordre correct d'envoyer des datagrammes en cas d'éclatement écrire",
-        "it": "caratteristica: sync knx library\nfunzione: sincronizzare con creare adattatore 0.2.3\nfunzione: aggiornamento alle versioni più recenti dei pacchetti dipendenti\ncaratteristica: impostazione autoread Abilitato autoread\nbugfix: consentire la generazione di alias con la configurazione di gateway mancante\nbugfix in knx lib: mantenere l'ordine corretto di inviare i datagrams in caso di esplosione di scrittura",
-        "es": "función: biblioteca de knx de sincronización\nfunción: sincronización con el adaptador 0,2.3\nfunción: actualización a nuevas versiones de paquetes dependientes\nfunción: ajuste automático Autoread habilitado\nbugfix: permitir la generación de alias con configuración de entrada perdida\nbugfix en knx lib: mantener el orden correcto de enviar datagramas en caso de explosión escribir",
-        "pl": "funkcja: sync knx library\nfunkcja: synchronizacja z tworzeniem adaptatora 0.2.3\ndostępne są nowe wersje pakietów zależnych\nustawa Autoready\ntrąbka: pozwalać aliasowi pokolenie z brakami konfiguracji bramy\nuszkodzenia w knx lib: zachować poprawny porządek wysyłania danych w przypadku rozbłysku",
-        "uk": "русскийукраїнськабеларускаяoʻzbek tilienglish\nфункція: синхронізація з створення адаптера 0.2.3\nфункція: оновлення до нових версій пакетів залежностей\nфункція: налаштування автопродавця Увімкнути автоматичний\nвиправлення помилок: генерація псевдонімів з відсутністю конфігурації шлюзу\nвиправлення помилок в knx lib: зберегти правильний порядок відправки графіків у разі лопу писати",
-        "zh-cn": "特色:复合克日图书馆\n特征:与创造适应力的结合\n特点:更新依赖一揽子计划的新版本\n特征:建立汽车 便携式汽车\nb ugfix:允许产生离散的门户组合\nb knx lib的ugfix:在开火时保持正确的发送数据图。"
       }
     },
     "title": "Open KNX",
@@ -153,11 +166,12 @@
   },
   "native": {
     "autoreadEnabled": true,
+    "useBoolean": true,
     "gwip": "",
     "gwipport": "3671",
     "localInterface": "",
     "minimumDelay": 50,
-    "aliassRegexp": "stat(e|us)(\\.|$)|rm(\\.|$)|r(ü|ue)ckmeldung(\\.|$)|\\svalue(\\.|$)",
+    "aliassRegexp": "stat(e|us)(\\.|$)|rm(\\.|$)|r(ü|ue)ckmeldung(\\.|$)",
     "aliasSimilarity": 0.9,
     "aliasPath": "alias.0",
     "aliasRange": false

package/lib/knx/src/Connection.js

@@ -195,6 +195,7 @@ FSM.prototype.write = function(grpaddr, value, dptid, callback) {
     KnxLog.get().warn('write: You must supply both grpaddr and value!');
     return;
   }
+  sendConfNotification(callback, grpaddr, this);
   try {
     // outbound request onto the state machine
     const serviceType = this.useTunneling ?
@@ -203,7 +204,7 @@ FSM.prototype.write = function(grpaddr, value, dptid, callback) {
     this.Request(serviceType, function(datagram) {
       DPTLib.populateAPDU(value, datagram.cemi.apdu, dptid);
       datagram.cemi.dest_addr = grpaddr;
-    }, callback);
+    });
   } catch (e) {
     KnxLog.get().warn(e);
   }
@@ -235,6 +236,7 @@ FSM.prototype.writeRaw = function(grpaddr, value, bitlength, callback) {
     KnxLog.get().warn('Value must be a buffer!');
     return;
   }
+  sendConfNotification(callback, grpaddr, this);
   // outbound request onto the state machine
   const serviceType = this.useTunneling ?
     KnxConstants.SERVICE_TYPE.TUNNELING_REQUEST :
@@ -243,7 +245,7 @@ FSM.prototype.writeRaw = function(grpaddr, value, bitlength, callback) {
     datagram.cemi.apdu.data = value;
     datagram.cemi.apdu.bitlength = bitlength ? bitlength : (value.byteLength * 8);
     datagram.cemi.dest_addr = grpaddr;
-  }, callback);
+  });
 }
 
 // send a READ request to the bus
@@ -365,4 +367,27 @@ function Connection(options) {
   return conn;
 };
 
+//notify sending application if timeout or if confirmation received
+function sendConfNotification(callback, grpaddr, fsm) {
+  if (typeof callback == 'function') {
+    // when the confirmation arrives:
+    const responseEvent = 'GroupValue_Write_confirmed_' + grpaddr;
+    KnxLog.get().trace('Binding connection to ' + responseEvent);
+    const binding = (confirmed) => {
+        // unbind the event handler
+        fsm.off(responseEvent, binding);
+        // fire the callback
+        callback(grpaddr, confirmed);
+        clearTimeout(fsm.confirmtimer);
+      }
+      // prepare for the response
+      fsm.on(responseEvent, binding);
+    // clean up after 3 seconds just in case no one confirms
+    fsm.confirmtimer = setTimeout( () => {
+      fsm.off(responseEvent, binding);
+      callback(grpaddr, false);
+    }, 3000);
+  }
+}
+
 module.exports = Connection;

package/lib/knx/src/FSM.js

@@ -377,10 +377,17 @@ module.exports = machina.Fsm.extend({
       ['inbound_TUNNELING_REQUEST_L_Data.con'](datagram) {
         if (this.useTunneling) {
           const confirmed = this.sentTunnRequests[datagram.cemi.dest_addr] && ! /*cofirmation error*/ datagram.cemi.ctrl.confirm;
+          const evtName = datagram.cemi.apdu.apci;
 
           delete this.sentTunnRequests[datagram.cemi.dest_addr];
           this.emit('confirmed', datagram.cemi.dest_addr, confirmed);
 
+          // event name for example GroupValue_Write_1/2/3
+          this.emit(
+            util.format('%s_confirmed_%s', evtName, datagram.cemi.dest_addr), 
+            confirmed
+          );
+
           KnxLog.get().trace(
             '(%s): %s %s',
             this.compositeState(),

package/lib/knx/src/dptlib/dpt1.js

@@ -8,7 +8,7 @@ const log = require('log-driver').logger;
 const custom_truthiness = (value) => {
   const f = parseFloat(value);
   return !isNaN(f) && isFinite(f) ? 
-    f == 1.0 :                        // numeric values (in native and string form) are truthy if NOT zero 
+    f != 0.0 :                        // numeric values (in native and string form) are truthy if NOT zero 
     value === true || value === 'true';// non-numeric value truthiness is Boolean true or the string 'true'.
 };
 
@@ -36,6 +36,7 @@ exports.subtypes = {
     use: 'G',
     name: 'DPT_Switch',
     desc: 'switch',
+    range: [0, 1],
     enc: { 0: 'Off', 1: 'On' },
   },
 
@@ -43,6 +44,7 @@ exports.subtypes = {
     use: 'G',
     name: 'DPT_Bool',
     desc: 'bool',
+    range: [0, 1],
     enc: { 0: 'False', 1: 'True' },
   },
 
@@ -50,6 +52,7 @@ exports.subtypes = {
     use: 'G',
     name: 'DPT_Enable',
     desc: 'enable',
+    range: [0, 1],
     enc: { 0: 'Disable', 1: 'Enable' },
   },
 
@@ -57,6 +60,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_Ramp',
     desc: 'ramp',
+    range: [0, 1],
     enc: { 0: 'No ramp', 1: 'Ramp' },
   },
 
@@ -64,6 +68,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_Alarm',
     desc: 'alarm',
+    range: [0, 1],
     enc: { 0: 'No alarm', 1: 'Alarm' },
   },
 
@@ -71,6 +76,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_BinaryValue',
     desc: 'binary value',
+    range: [0, 1],
     enc: { 0: 'Low', 1: 'High' },
   },
 
@@ -78,6 +84,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_Step',
     desc: 'step',
+    range: [0, 1],
     enc: { 0: 'Decrease', 1: 'Increase' },
   },
 
@@ -85,6 +92,7 @@ exports.subtypes = {
     use: 'G',
     name: 'DPT_UpDown',
     desc: 'up/down',
+    range: [0, 1],
     enc: { 0: 'Up', 1: 'Down' },
   },
 
@@ -92,6 +100,7 @@ exports.subtypes = {
     use: 'G',
     name: 'DPT_OpenClose',
     desc: 'open/close',
+    range: [0, 1],
     enc: { 0: 'Open', 1: 'Close' },
   },
 
@@ -99,6 +108,7 @@ exports.subtypes = {
     use: 'G',
     name: 'DPT_Start',
     desc: 'start/stop',
+    range: [0, 1],
     enc: { 0: 'Stop', 1: 'Start' },
   },
 
@@ -113,6 +123,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_Invert',
     desc: 'invert',
+    range: [0, 1],
     enc: { 0: 'Not inverted', 1: 'Inverted' },
   },
 
@@ -120,6 +131,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_DimSendStyle',
     desc: 'dim send style',
+    range: [0, 1],
     enc: { 0: 'Start/stop', 1: 'Cyclically' },
   },
 
@@ -127,6 +139,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_InputSource',
     desc: 'input source',
+    range: [0, 1],
     enc: { 0: 'Fixed', 1: 'Calculated' },
   },
 
@@ -134,55 +147,83 @@ exports.subtypes = {
     use: 'G',
     name: 'DPT_Reset',
     desc: 'reset',
-    enc: { 0: 'no action(dummy)', 1: 'reset command(trigger)' },
+    range: [0, 1],
+    enc: {
+      0: 'no action(dummy)',
+      1: 'reset command(trigger)'
+    },
   },
 
   '016': {
     use: 'G',
     name: 'DPT_Ack',
     desc: 'ack',
-    enc: { 0: 'no action(dummy)', 1: 'acknowledge command(trigger)' },
+    range: [0, 1],
+    enc: { 
+      0: 'no action(dummy)',
+      1: 'acknowledge command(trigger)' },
   },
 
   '017': {
     use: 'G',
     name: 'DPT_Trigger',
     desc: 'trigger',
-    enc: { 0: 'trigger', 1: 'trigger' },
+    range: [0, 1],
+    enc: { 
+      0: 'trigger',
+      1: 'trigger' 
+    },
   },
 
   '018': {
     use: 'G',
     name: 'DPT_Occupancy',
     desc: 'occupancy',
-    enc: { 0: 'not occupied', 1: 'occupied' },
+    range: [0, 1],
+    enc: { 
+      0: 'not occupied', 
+      1: 'occupied'
+    },
   },
 
   '019': {
     use: 'G',
     name: 'DPT_WindowDoor',
     desc: 'open window/door',
-    enc: { 0: 'closed', 1: 'open' },
+    range: [0, 1],
+    enc: {
+      0: 'closed',
+      1: 'open'
+    },
   },
 
   '021': {
     use: 'FB',
     name: 'DPT_LogicalFunction',
     desc: 'and/or',
-    enc: { 0: 'logical function OR', 1: 'logical function AND' },
+    range: [0, 1],
+    enc: { 
+      0: 'logical function OR',
+      1: 'logical function AND'
+    },
   },
 
   '022': {
     use: 'FB',
     name: 'DPT_Scene_AB',
     desc: 'scene A/B',
-    enc: { 0: 'scene A', 1: 'scene B' },
+    range: [0, 1],
+    enc: {
+      0: 'scene A',
+      1: 'scene B'
+    },
   },
 
   '023': {
     use: 'FB',
     name: 'DPT_ShutterBlinds_Mode',
     desc: 'shutter/blinds mode',
+    range: [0, 1],
     enc: {
       0: 'only move Up/Down mode (shutter)',
       1: 'move Up/Down + StepStop mode (blind)',
@@ -193,6 +234,7 @@ exports.subtypes = {
     use: 'G',
     name: 'DPT_DayNight',
     desc: 'Day Night',
+    range: [0, 1],
     enc: {
       0: 'Day',
       1: 'Night',

package/lib/knx/src/dptlib/dpt12.js

@@ -13,7 +13,8 @@ exports.basetype = {
   bitlength: 32,
   signedness: "unsigned",
   valuetype: "basic",
-  desc: "4-byte unsigned value"
+  desc: "4-byte unsigned value",
+  "range" : [0, Math.pow(2, 32)-1]
 }
 
 // DPT12 subtype info

package/lib/knx/src/dptlib/dpt17.js

@@ -13,7 +13,8 @@
 exports.basetype = {
   bitlength : 8,
   valuetype : 'basic',
-  desc : "scene number"
+  desc : "scene number",
+  "range" : [0, 255]
 }
 
 // DPT17 subtypes

package/lib/knx/src/dptlib/dpt2.js

@@ -47,6 +47,7 @@ exports.subtypes = {
     use: 'G',
     name: 'DPT_Switch_Control',
     desc: 'switch with priority',
+    range: [0, 3],
     //enc: { 0: 'Off', 1: 'On' }, binary datatype, not enum
   },
   // 2.002 boolean control
@@ -54,6 +55,7 @@ exports.subtypes = {
     use: 'G',
     name: 'DPT_Bool_Control',
     desc: 'boolean with priority',
+    range: [0, 3],
     //enc: { 0: 'false', 1: 'true' },
   },
   // 2.003 enable control
@@ -61,6 +63,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_Emable_Control',
     desc: 'enable with priority',
+    range: [0, 3],
     //enc: { 0: 'Disabled', 1: 'Enabled' },
   },
 
@@ -69,6 +72,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_Ramp_Control',
     desc: 'ramp with priority',
+    range: [0, 3],
     //enc: { 0: 'No ramp', 1: 'Ramp' },
   },
 
@@ -77,6 +81,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_Alarm_Control',
     desc: 'alarm with priority',
+    range: [0, 3],
     //enc: { 0: 'No alarm', 1: 'Alarm' },
   },
 
@@ -85,6 +90,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_BinaryValue_Control',
     desc: 'binary value with priority',
+    range: [0, 3],
     //enc: { 0: 'Off', 1: 'On' },
   },
 
@@ -93,6 +99,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_Step_Control',
     desc: 'step with priority',
+    range: [0, 3],
     //enc: { 0: 'Off', 1: 'On' },
   },
 
@@ -101,6 +108,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_Direction1_Control',
     desc: 'direction 1 with priority',
+    range: [0, 3],
     //enc: { 0: 'Off', 1: 'On' },
   },
 
@@ -109,6 +117,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_Direction2_Control',
     desc: 'direction 2 with priority',
+    range: [0, 3],
     //enc: { 0: 'Off', 1: 'On' },
   },
 
@@ -117,6 +126,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_Start_Control',
     desc: 'start with priority',
+    range: [0, 3],
     //enc: { 0: 'Off', 1: 'On' },
   },
 
@@ -125,6 +135,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_State_Control',
     desc: 'switch',
+    range: [0, 3],
     //enc: { 0: 'Off', 1: 'On' },
   },
 
@@ -133,6 +144,7 @@ exports.subtypes = {
     use: 'FB',
     name: 'DPT_Invert_Control',
     desc: 'switch',
+    range: [0, 3],
     //enc: { 0: 'Off', 1: 'On' },
   },
 };

package/lib/knx/src/dptlib/dpt21.js

@@ -63,18 +63,18 @@ exports.basetype = {
 exports.subtypes = {
     // 21.001 status - 5 bits
     "001" : {
-        "name" : "DPT_StatusGen",
+    "name" : "DPT_StatusGen",
 	"desc" : "General Status",
-        "unit" : "",
+    "unit" : "",
 	"scalar_range" : [ , ],
-        "range" : [ , ]
-    },
+    "range" : [ , ]
+  },
     // 21.002 control - 3 bits
     "002" : {
-        "name" : "DPT_Device_Control",
-	"desc" : "Device Control",
-        "unit" : "",
+    "name" : "DPT_Device_Control",
+    "desc" : "Device Control",
+    "unit" : "",
 	"scalar_range" : [ , ],
-        "range" : [ , ]
-    }
+    "range" : [ , ]
+  }
 }

package/lib/knx/src/dptlib/dpt232.js

@@ -41,7 +41,7 @@ exports.basetype = {
 };
 
 exports.subtypes = {
-  600: {
+  '600': {
     name: 'RGB',
     desc: 'RGB color triplet',
     unit: '',

package/lib/knx/src/dptlib/dpt3.js

@@ -43,11 +43,13 @@ exports.subtypes = {
   '007': {
     name: 'DPT_Control_Dimming',
     desc: 'dimming control',
+    range: [0, 15],
   },
 
   // 3.008 blind control
   '008': {
     name: 'DPT_Control_Blinds',
     desc: 'blinds control',
+    range: [0, 15],
   },
 };

package/lib/knx/src/dptlib/dpt4.js

@@ -44,6 +44,7 @@ exports.subtypes = {
   '002': {
     name: 'DPT_Char_8859_1',
     desc: 'ISO-8859-1 character (0..255)',
+    range: [0, 255],
     use: 'G',
   },
 };

package/lib/knx/src/dptlib/dpt5.js

@@ -19,13 +19,15 @@ exports.subtypes = {
     // 5.001 percentage (0=0..ff=100%)
     "001" : {
         "name" : "DPT_Scaling", "desc" : "percent",
-        "unit" : "%", "scalar_range" : [0, 100]
+        "unit" : "%",
+        "scalar_range" : [0, 100]
     },
 
     // 5.003 angle (degrees 0=0, ff=360)
     "003" : {
         "name" : "DPT_Angle", "desc" : "angle degrees",
-        "unit" : "°", "scalar_range" : [0, 360]
+        "unit" : "°",
+        "scalar_range" : [0, 360]
     },
 
     // 5.004 percentage (0..255%)

package/lib/knx/src/dptlib/dpt7.js

@@ -10,7 +10,8 @@ exports.basetype = {
   "bitlength" : 16,
   "signedness": "unsigned",
   "valuetype" : "basic",
-  "desc" : "16-bit unsigned value"
+  "desc" : "16-bit unsigned value",
+  "range" : [0, 65535]
 }
 
 // DPT subtypes info

package/lib/projectImport.js

@@ -10,6 +10,7 @@ const select = require("xpath");
 const dom = require("xmldom").DOMParser;
 const tools = require("./tools.js");
 const similarity = require("similarity");
+const { basetype } = require("./knx/src/dptlib/dpt1.js");
 
 module.exports = {
     // get xml Files from index.html via adapter.on 'message' and put it into file Obj
@@ -82,7 +83,7 @@ module.exports = {
                     //allowed state, unresolveable dpt means raw interface
                 }
 
-                ({ range, type, role } = identifyRangeRoleType(dptObj, range, dpt, type, role));
+                ({ range, type, role } = identifyRangeRoleType(adapter, dptObj, range, dpt, type, role));
 
                 //if dpt is for sure not a status, remove from autoread
                 autoread = !tools.isTriggerDPT(dpt);
@@ -165,7 +166,7 @@ module.exports = {
             return fullPath + tools.formatGaNameForIob(gaName);
         }
 
-        function identifyRangeRoleType(dptObj, range, dpt, type, role) {
+        function identifyRangeRoleType(ad, dptObj, range, dpt, type, role) {
             // is there a scalar range? eg. DPT5.003 angle degrees (0=0, ff=360)
             if (dptObj?.subtype?.scalar_range) {
                 range = dptObj.subtype.scalar_range;
@@ -184,7 +185,15 @@ module.exports = {
                 //unknown dpt, range unknown
                 range = [];
             }
-            if (dptObj?.subtype?.enc) type = "enum";
+
+            if (dptObj?.subtype?.enc) {
+                if (basetype.bitlength == 1) {
+                    //treat enum with one bit as mixed
+                    if (ad.config.useBoolean) {
+                        type = "boolean";
+                    } else type = "mixed";
+                } else type = "number";
+            }
 
             //correct range, set type and role based on dpt
             //obj.common.min is only allowed on obj.common.type "number" or "mixed"
@@ -204,7 +213,7 @@ module.exports = {
                 console.assert(type == "", "object " + type);
                 type = "object";
             } else if (!!dptObj && !tools.isEmptyObject(dptObj) && dptObj.basetype && dptObj.basetype.bitlength == 1) {
-                if (type != "enum") type = "boolean";
+                if (type != "number") type = "boolean";
                 role = "switch";
                 range[0] = false;
                 range[1] = true;

package/lib/tools.js

@@ -103,7 +103,7 @@ async function translateGoogle(text, targetLang) {
 }
 
 /*
- * convert dpt into DPT1 or DPT1.001 format, input format is like DPT-275 or DPST-275-100
+ * convert dpt into DPT1 or DPT1.001 notation when input is like DPT-1 or DPST-1-001
  */
 function formatDpt(dpt) {
     if (dpt.indexOf("-") != -1) {
@@ -177,6 +177,10 @@ function isDateDPT(dpt) {
     );
 }
 
+function isBitDPT(dpt) {
+    return dpt == "DPT1" || dpt.startsWith("DPT1.");
+}
+
 function isFloatDPT(dpt) {
     return dpt == "DPT9" || dpt.startsWith("DPT9.") || dpt == "DPT14" || dpt.startsWith("DPT14.");
 }
@@ -227,6 +231,7 @@ module.exports = {
     formatGaNameForIob,
     isStringDPT,
     isDateDPT,
+    isBitDPT,
     isUnknownDPT,
     isFloatDPT,
     isTriggerDPT,

package/main.js

@@ -19,6 +19,7 @@ const DoubleKeyedMap = require("./lib/doubleKeyedMap.js");
 const detect = require("./lib/openknx.js");
 const os = require("os");
 const exitHook = require("async-exit-hook");
+const { dpt1_control_ga } = require("./lib/knx/test/wiredtests/wiredtest-options.js");
 
 class openknx extends utils.Adapter {
     /**
@@ -336,6 +337,7 @@ class openknx extends utils.Adapter {
             //keep string, boolean and number
             ret = val;
         }
+
         return ret;
     }
 
@@ -426,24 +428,39 @@ class openknx extends utils.Adapter {
 
         // @ts-ignore
         if (state.c == "GroupValue_Read" || state.q == 0x10) {
-            //interface to trigger GrouValue_Read is this comment or null
-            this.log.debug("Outbound GroupValue_Read to " + ga);
-            this.knxConnection.read(ga);
+            //interface to trigger GrouValue_Read is this object comment or StateQuality 16
+            this.log.debug("Outbound GroupValue_Read to GA " + ga);
+            this.knxConnection.read(ga, () => {
+                //ack is generated with GroupValue_Response
+            });
             return "read";
         } else if (this.gaList.getDataById(id).common.write) {
             this.log.debug(
-                "Outbound GroupValue_Write to " +
-                    ga +
-                    " val: " +
-                    (isRaw ? rawVal : JSON.stringify(knxVal)) +
-                    " from " +
-                    id,
+                `Outbound GroupValue_Write to " ${ga} val: ${isRaw ? rawVal : JSON.stringify(knxVal)} from ${id}`,
             );
             if (isRaw) {
-                this.knxConnection.writeRaw(ga, rawVal, () => {});
+                this.knxConnection.writeRaw(ga, rawVal, (grpaddr, confirmed) => {
+                    //l_data.con confirmation set by any receiver connected to the ga
+                    if (confirmed) {
+                        //set iob ack when value sent successful on the bus otherwise keep unset
+                        this.setState(id, {
+                            ack: true,
+                        });
+                        this.log.debug(`GroupValue_Write confirmation ${confirmed} received for ${grpaddr} ${id}`);
+                    } else this.log.info(`GroupValue_Write confirmation ${confirmed} received for ${grpaddr} ${id}`);
+                });
                 return "write raw";
             } else {
-                this.knxConnection.write(ga, knxVal, dpt, () => {});
+                this.knxConnection.write(ga, knxVal, dpt, (grpaddr, confirmed) => {
+                    //l_data.con confirmation set by any receiver connected to the ga
+                    if (confirmed) {
+                        //set iob ack when value sent successful on the bus otherwise keep unset
+                        this.setState(id, {
+                            ack: true,
+                        });
+                        this.log.debug(`GroupValue_Write confirmation ${confirmed} received for ${grpaddr} ${id}`);
+                    } else this.log.info(`GroupValue_Write confirmation ${confirmed} received for ${grpaddr} ${id}`);
+                });
                 return "write";
             }
         } else {
@@ -493,11 +510,11 @@ class openknx extends utils.Adapter {
                                 this.gaList.setDpById(key, datapoint);
                                 cnt_withDPT++;
                                 this.log.debug(
-                                    `Datapoint ${
-                                        this.gaList.getDataById(key).native.autoread ? "autoread " : ""
-                                    }created and GroupValueWrite sent: ${
-                                        this.gaList.getDataById(key).native.address
-                                    } ${key}`,
+                                    `Datapoint  ${
+                                        this.gaList.getDataById(key).native.autoread
+                                            ? "autoread created and GroupValueRead sent"
+                                            : "created"
+                                    } ${this.gaList.getDataById(key).native.address} ${key}`,
                                 );
                             } catch (e) {
                                 this.log.error("could not create KNX Datapoint for " + key + " with error: " + e);
@@ -522,21 +539,21 @@ class openknx extends utils.Adapter {
                     this.log.warn(connstatus);
                 },
 
-                //l_data.con, confirmation set receiver with set ga s flag
+                //l_data.con, confirmation set by a receiver which has the sending flag
                 confirmed: (dest, confirmed) => {
                     for (const id of this.gaList.getIdsByGa(dest)) {
-                        if (confirmed)
-                            //if unconfirmed keep ack at false
-                            this.setState(id, {
-                                ack: true,
-                            });
-                        if (confirmed) this.log.debug(`confirmation true received for ${dest} ${id}`);
-                        else this.log.info(`confirmation false received for ${dest} ${id}`);
+                        if (confirmed) {
+                            this.log.debug(`confirmation true received for ${dest} ${id}`);
+                        } else {
+                            //otherwise keep unset
+                            this.log.info(`confirmation false received for ${dest} ${id}`);
+                        }
                     }
                 },
 
                 //KNX Bus event received
-                //src: KnxDeviceAddress, dest: KnxGroupAddress, val: raw value not used, using dp interface instead
+                //src: KnxDeviceAddress, dest: KnxGroupAddress,
+                //val: raw value not used, using dp interface instead
                 // @ts-ignore
                 event: (
                     /** @type {string} */ evt,
@@ -624,17 +641,7 @@ class openknx extends utils.Adapter {
                                 break;
 
                             default:
-                                this.log.debug(
-                                    "received unhandeled event " +
-                                        " " +
-                                        evt +
-                                        " " +
-                                        src +
-                                        " " +
-                                        dest +
-                                        " " +
-                                        convertedVal,
-                                );
+                                this.log.debug(`received unhandeled event " ${evt} ${src} ${dest} ${convertedVal}`);
                                 ret = "unhandeled";
                         }
                     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "iobroker.openknx",
-  "version": "0.4.4",
+  "version": "0.5.0",
   "description": "ioBroker knx Adapter",
   "author": "boellner",
   "homepage": "https://github.com/iobroker-community-adapters/ioBroker.openknx.git",