iobroker.openknx 0.0.15 → 0.0.16

package/README.md

@@ -18,12 +18,12 @@ Please do not test in critical environments
 
 install in shell
     cd /opt/iobroker/node_modules  
-    npm i iobroker.openknx@latestversion  
+    npm i iobroker.openknx  
     iobroker add openknx  
     npm i knx  
 
 updates:
-    npm i iobroker.openknx@latestversion  
+    npm i iobroker.openknx  
     iobroker upload openknx  
 
 # GA import
@@ -68,7 +68,7 @@ Leave setting empty to use the adapters own namespace.
         },
         "force_encoding": "",       
         "signedness": "",
-        "valuetype": "basic"
+        "valuetype": "basic"        //composite means set via a specific object
     },
     "from": "system.adapter.openknx.0",
     "user": "system.user.admin",
@@ -79,12 +79,40 @@ Leave setting empty to use the adapters own namespace.
 # Adapter communication Interface Description
 handeled DPTs 1-21,232,237,238  
 
-Unhandeled DPTs are written as raw buffers, the iterface is a hexadecimal number.
+Unhandeled DPTs are written as raw buffers, the iterface is a sequencial string of hexadecimal number. For example write '0102feff' to send values 0x01 0x02 0xfe 0xff on the bus. 
 Where number, see scaling.
 
 Description of handeled DPTs
 
-tbd
+	javascript datatype	special values	range
+DPT-1	boolean		false, true
+DPT-2	object	{"priority":1 bit,"data":1 bit}	-
+DPT-3	object	{"decr_incr":1 bit,"data":2 bit}	-
+DPT-18	object	{"save_recall":0,"scenenumber":0}	
+DPT-21	object	{"outofservice":0,"fault":0,"overridden":0,"inalarm":0,"alarmunack":0}	-
+DPT-232	object	{red:0..255, green:0.255, blue:0.255}	-
+DPT-237	object	{"address":0,"addresstype":0,"readresponse":0,"lampfailure":0,"ballastfailure":0,"convertorerror":0}	-
+DPT-4	string		one character sent as 8-bit character
+DPT-16	string		one character sent as 16-character string
+DPT-5	number		8-bit unsigned value
+DPT-5.001	number		0..100 [%] scaled to 1-byte
+DPT-5.003	number		0..360 [°] scaled to 1-byte
+DPT-6	number		8-bit signed -128..127
+DPT-7	number		16-bit unsigned value
+DPT-8	number		2-byte signed value -32768..32767
+DPT-9	number		2-byte floating point value
+DPT-14	number		4-byte floating point value
+DPT-12	number		4-byte unsigned value
+DPT-13	number		4-byte signed value
+DPT-15	number		4-byte
+DPT-17	number		1-byte
+DPT-20	number		1-byte
+DPT-238	number		1-byte
+DPT-10	number for Date Object		-
+DPT-11	number for Date Object		-
+DPT-19	number for Date Object		-
+rest	object	{0 .. }	-
+
 
 Only time and date information is exchanged with KNX time based datatypes, e.g. DPT-19 has unsupported fields for signal quality  
 
@@ -130,6 +158,7 @@ Select XML Output Format
 After the successful import a message shows how much objects where recognized.
 Press "save & close" or "save" to restart the adapter and take over the changes.
 When starting, the adapter tries to read all GroupAdresses with have the autoread flag (default setting). This could take a while and can produce a higher load on your KNX-bus. This ensures that the adapter operates with up-to-date values from the start.
+Autoread is done on the first connection with the knx bus after an adapter start or restart, not on every knx reconnection.
 
 ## Objects
 In Objects the group adress tree like in your ETS project.
@@ -155,8 +184,10 @@ Wide DPT (datapoint type) support (DPT1 - DPT21, DPT232, DPT237, DPT238 supporte
 - only three level group address are supported
 
 ## Changelog
+### 0.0.16
+* raw value handling
+
 ### 0.0.14
-* initial raw value handling added
 * import ga xml
 
 ### 0.0.12

package/io-package.json

@@ -1,7 +1,7 @@
 {
   "common": {
         "name": "openknx",
-        "version": "0.0.15",
+        "version": "0.0.16",
         "news": {
             "0.0.1": {
                 "en": "initial release",

package/lib/generateGAS.js

@@ -130,17 +130,17 @@ module.exports = {
                 }
 
                 // is there a scalar range? eg. DPT5.003 angle degrees (0=0, ff=360)
-                if (dptObj.hasOwnProperty('subtype') && dptObj.subtype.hasOwnProperty('scalar_range')) {
+                if (!!(dptObj) && dptObj.hasOwnProperty('subtype') && dptObj.subtype.hasOwnProperty('scalar_range')) {
                     range = dptObj.subtype.scalar_range;
-                } else if (dptObj.hasOwnProperty('scalar_range')) {
+                } else if (!!(dptObj) && dptObj.hasOwnProperty('scalar_range')) {
                     range = dptObj.scalar_range;
-                } else if (dptObj.hasOwnProperty('subtype') && dptObj.subtype.hasOwnProperty('range')) {
+                } else if (!!(dptObj) && dptObj.hasOwnProperty('subtype') && dptObj.subtype.hasOwnProperty('range')) {
                     // just a plain numeric value, only check if within bounds 
                     range = dptObj.subtype.range;
-                } else if (!tools.isEmptyObject(dptObj) && dptObj.basetype.hasOwnProperty('range')) {
+                } else if (!!(dptObj) && dptObj.basetype.hasOwnProperty('range')) {
                     // just a plain numeric value, only check if within bounds 
                     range = dptObj.basetype.range;
-                } else if (!tools.isEmptyObject(dptObj)) {
+                } else if (!!(dptObj) && !tools.isEmptyObject(dptObj)) {
                     //extracted from basetype
                     range = [0, Math.pow(2, dptObj.basetype.bitlength) - 1];
                 } else {
@@ -148,21 +148,28 @@ module.exports = {
                 }
 
                 if (tools.isDateDPT(dpt)) {
+                    // we convert knx date types in javascript Date with different size
+                    range[0] = undefined;
+                    range[1] = undefined;
                     type = 'number';
-                } else if (!tools.isEmptyObject(dptObj) && dptObj.basetype.valuetype == 'composite') {
+                } else if (!!(dptObj) && !tools.isEmptyObject(dptObj) && dptObj.basetype.valuetype == 'composite') {
                     range[0] = undefined;
                     range[1] = undefined;
                     type = 'object';
-                } else if (!tools.isEmptyObject(dptObj) && dptObj.basetype.bitlength == 1) {
+                } else if (!!(dptObj) && !tools.isEmptyObject(dptObj) && dptObj.basetype.bitlength == 1) {
                     type = 'boolean';
                 } else if (tools.isStringDPT(dpt)) {
                     range[0] = undefined;
                     range[1] = undefined;
                     type = 'string';
-                } else if (tools.isUnknownDPT(dpt)) {
+                } else if (tools.isFloatDPT(dpt)) {
                     range[0] = undefined;
                     range[1] = undefined;
                     type = 'number';
+                } else if (tools.isUnknownDPT(dpt)) {
+                    range[0] = undefined;
+                    range[1] = undefined;
+                    type = 'string'; //raw
                 } else {
                     type = 'number';
                 }
@@ -171,26 +178,32 @@ module.exports = {
                     _id: fullPath,
                     type: 'state',
                     common: {
-                        desc: 'Basetype: ' + tools.isEmptyObject(dptObj) ? 'raw value' : dptObj.basetype.desc +
-                            ((dptObj.hasOwnProperty('subtype') && dptObj.subtype.hasOwnProperty('desc')) ? ', Subtype: ' + dptObj.subtype.desc : ''),
+                        desc: 'Basetype: ' +
+                            (!(dptObj) || tools.isEmptyObject(dptObj) ? 'raw value' :
+                                (
+                                    dptObj.basetype.desc +
+                                    ((dptObj.hasOwnProperty('subtype') && dptObj.subtype.hasOwnProperty('desc')) ? (', Subtype: ' + dptObj.subtype.desc) : '')
+                                )
+                            ),
                         min: range[0],
                         max: range[1],
                         name: gaName,
                         read: true,
                         role: '', // todo add default role
                         type: type, //default is mixed==any type) (possible values: number, string, boolean, array, object, mixed, file). As exception the objects with type meta could have common.type=meta.user or meta.folder. It is important to note that array, object, mixed and file must be serialized using JSON.stringify().
-                        unit: (dptObj.hasOwnProperty('subtype') && dptObj.subtype.hasOwnProperty('unit')) ? dptObj.subtype.unit : '',
+                        unit: (!!(dptObj) && dptObj.hasOwnProperty('subtype') && dptObj.subtype.hasOwnProperty('unit')) ? dptObj.subtype.unit : undefined,
                         write: true,
                     },
                     native: {
                         address: adr2ga(groupAddress.getAttribute('Address')),
+                        answer_groupValueResponse: false, //overwrite manually
                         autoread: true,
-                        bitlength: tools.isEmptyObject(dptObj) ? 'unknown' : dptObj.basetype.bitlength, //informative
+                        bitlength: !(dptObj) || tools.isEmptyObject(dptObj) ? undefined : dptObj.basetype.bitlength, //informative
                         dpt: dpt,
-                        encoding: dptObj.hasOwnProperty('subtype') ? (dptObj.subtype.hasOwnProperty('enc') ? dptObj.subtype.enc : dptObj.basetype.enc) : '', //informative ,todo matcht zu common.states`? hat basetype enc?
-                        force_encoding: (dptObj.hasOwnProperty('subtype') && dptObj.subtype.hasOwnProperty('force_encoding')) ? dptObj.subtype.force_encoding : '', //DPT16
-                        signedness: !tools.isEmptyObject(dptObj) ? (dptObj.basetype.hasOwnProperty('signedness') ? dptObj.basetype.signedness : '') : '', //signed or unsigned or empty
-                        valuetype: tools.isEmptyObject(dptObj) ? '' : dptObj.basetype.valuetype, //informative: composite or basic                        
+                        encoding: !!(dptObj) && dptObj.hasOwnProperty('subtype') ? (dptObj.subtype.hasOwnProperty('enc') ? dptObj.subtype.enc : dptObj.basetype.enc) : undefined, //informative ,todo matcht zu common.states`? hat basetype enc?
+                        force_encoding: (!!(dptObj) && dptObj.hasOwnProperty('subtype') && dptObj.subtype.hasOwnProperty('force_encoding')) ? dptObj.subtype.force_encoding : undefined, //DPT16
+                        signedness: !!(dptObj) && !tools.isEmptyObject(dptObj) ? (dptObj.basetype.hasOwnProperty('signedness') ? dptObj.basetype.signedness : undefined) : undefined, //signed or unsigned or empty
+                        valuetype: !(dptObj) || tools.isEmptyObject(dptObj) ? undefined : dptObj.basetype.valuetype, //informative: composite or basic                        
                     }
                 };
 

package/lib/tools.js

@@ -119,6 +119,21 @@ function convertDPTtype(dpt) {
     return dpt;
 }
 
+    /* for testing, forward msg from one to another test address
+    better approach: send all test values via ets, send received value back from iobroker, compare in ets
+    */
+   function interfaceTest(id, state) {
+        const inpath = this.mynamespace + '.test.testin';
+        const outpath = this.mynamespace + '.test.testout';
+        if (id.startsWith(inpath)) {
+            var out = outpath + id.replace(inpath, '');
+            this.setForeignState(out, {
+                val: state.val,
+                ack: true,
+            });
+        }
+    }
+
 function isEmptyObject(obj) {
     return (obj 
     && Object.keys(obj).length === 0
@@ -138,7 +153,15 @@ function isStringDPT(dpt) {
 }
 
 function isDateDPT(dpt) {
-    return (dpt == 'DPT19' || dpt == 'DPT19' || dpt.startsWith('DPT19.') || dpt.startsWith('DPT19.'));
+    return (dpt == 'DPT19' || dpt.startsWith('DPT19.') 
+    || dpt == 'DPT10'  || dpt.startsWith('DPT10.') 
+    );
+}
+
+function isFloatDPT(dpt) {
+    return (dpt == 'DPT9' || dpt.startsWith('DPT9.') 
+    || dpt == 'DPT14'  || dpt.startsWith('DPT14.')
+    );
 }
 
 function isUnknownDPT(dpt) {
@@ -147,7 +170,7 @@ function isUnknownDPT(dpt) {
     } catch (e) {
         return true;
     }
-    return false;
+    return dptObj == null;
 }
 
 module.exports = {
@@ -159,5 +182,8 @@ module.exports = {
     isStringDPT,
     isDateDPT,
     isUnknownDPT,
+ isFloatDPT,
     isEmptyObject,
+    interfaceTest,
+    
 };

package/main.js

@@ -19,10 +19,8 @@ const tools = require('./lib/tools.js');
 
 class openknx extends utils.Adapter {
 
-    mapping = {}; //todo join with states
-    states = {};
-    knxDatapoints = {}; //key array of knx.Datapoint known from mapping todo join
     gaList = new DoubleKeyedMap();
+    autoreaddone = false;
 
     knxConnection;
     mynamespace;
@@ -44,7 +42,6 @@ class openknx extends utils.Adapter {
         this.mynamespace = this.namespace;
     }
 
-
     /**
      * Is called when databases are connected and adapter received configuration.
      */
@@ -83,72 +80,6 @@ class openknx extends utils.Adapter {
         }
     }
 
-    /**
-     * Is called if a subscribed state changes
-     * state.ack is coming in false if set by user (nodered, script...), here we set it.
-     * https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/adapterdev.md
-     * @param {string} id
-     * @param {ioBroker.State | null | undefined} state
-     */
-    onStateChange(id, state) {
-
-        var isRaw = false;
-
-        if (!id) return;
-        if (!state /*obj deleted*/ || typeof state !== 'object') return;
-        //not a KNX object
-        if (!this.states[id] || !this.states[id].native || this.states[id].native.address === undefined) return;
-        if (!this.knxConnection) { //!knxConnection.connected != 'connected' todo check connection knxConncetion.initialState == initialized?? 
-            this.log.warn('stateChange: not ready');
-            return;
-        }
-
-        if (state.c == 'self') {
-            //called by self, avoid loop
-            //console.log('state change self id: ' + id);
-            //this.interfaceTest(id, state);
-            return;
-        }
-
-        var dpt = this.states[id].native.dpt;
-        var ga = this.states[id].native.address;
-        var val = state.val;
-
-        //convert val into object for certain dpts
-        if (tools.isDateDPT(dpt)) {
-            val = new Date(val);
-        } else if (!tools.isStringDPT(dpt)) {
-            val = this.convertType(val);
-        } else if (tools.isUnknownDPT(dpt)) {
-            //write raw buffers for unknown dpts, iterface is a hex value
-            //bitlength is the buffers bytelength * 8.
-            val = Buffer.from(val, 'hex');
-            isRaw = true;
-        } else {
-            this.log.warn('Missing implementation for unhandeled DPT, assuming number');
-        }
-
-        if (state.c == 'GroupValue_Read') {
-            //interface to trigger GrouValue_Read is this comment
-            this.log.debug('Outgoing GroupValue_Read to ' + ga + ' value ' + val);
-            this.knxConnection.read(ga);
-            if (!state.ack) this.setForeignState(id, {
-                ack: true,
-                c: 'self'
-            });
-        } else if (this.states[id].common.write) {
-            this.log.debug('Outgoing GroupValue_Write to ' + ga + ' value ' + val + ' from ' + id);
-            if (isRaw) ; //connection.writeRaw('1/0/0', val); //todo TEST
-            else this.knxConnection.write(ga, val, dpt);
-            if (!state.ack) this.setForeignState(id, {
-                ack: true,
-                c: 'self'
-            });
-        } else {
-            this.log.warn('not configured write to ga: ' + val);
-        }
-    }
-
     // New message arrived. obj is array with current messages
     // triggered from admin page read in knx project
     onMessage(obj) {
@@ -217,7 +148,7 @@ class openknx extends utils.Adapter {
      * IOBroker Object tree cannot store 2 objects of same name, warn
      */
     warnDuplicates(objects) {
-        //todo remove unallowed characted, global function
+        //todo remove unallowed character, lib function
         let arr = [];
         let duplicates = [];
         for (const object of objects) {
@@ -242,14 +173,13 @@ class openknx extends utils.Adapter {
         if (val instanceof Date) {
             //convert Date to number
             ret = Number(new Date(val));
+        } else if (Buffer.isBuffer(val)) {
+            //before object check
+            ret = val.toString('hex');
         } else if (typeof val === 'object') {
             ret = JSON.stringify(val);
         } else if (typeof val === 'string') {
-            try {
-                ret = JSON.parse(val); //string to object, the string types have to be filtered out before call
-            } catch (e) {
-                this.log.warn('write Object error, wrong format for dpt type ' + val);
-            }
+            //use as is
         } else {
             //both can handle number and boolean
             ret = val;
@@ -257,47 +187,126 @@ class openknx extends utils.Adapter {
         return ret;
     }
 
-    //interface to knx stack
-    startKnxServer() {
+    /**
+     * Is called if a subscribed state changes
+     * state.ack is coming in false if set by user (nodered, script...), here we set it.
+     * https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/adapterdev.md
+     * @param {string} id
+     * @param {ioBroker.State | null | undefined} state
+     */
+    onStateChange(id, state) {
+        var isRaw = false;
+
+        if (!id) return;
+        if (!state /*obj deleted*/ || typeof state !== 'object') return;
+        //not a KNX object
+        if (!this.gaList.getDataById(id) || !this.gaList.getDataById(id).native || !this.gaList.getDataById(id).native.address) return;
+        if (!this.knxConnection) { //!knxConnection.connected != 'connected' todo check connection knxConncetion.initialState == initialized?? 
+            this.log.warn('stateChange: not ready');
+            return;
+        }
+
+        if (state.c == 'self') {
+            //called by self, avoid loop
+            //console.log('state change self id: ' + id);
+            //tools.interfaceTest(id, state);
+            return;
+        }
+
+        var dpt = this.gaList.getDataById(id).native.dpt;
+        var ga = this.gaList.getDataById(id).native.address;
+        var val = state.val;
 
-        var cnt_complete = 0;
-        var cnt_withDPT = 0;
+        //convert val into object for certain dpts
+        if (tools.isDateDPT(dpt)) {
+            //before composite check, date is also composite
+            val = new Date(val);
+        } else if (this.gaList.getDataById(id).native.valuetype == 'composite') {
+            try {
+                val = JSON.parse(val);
+            } catch (e) {
+                this.log.warn('stateChange: unsupported value format ' + val + ' for ' + ga);
+                return;
+            }
+        } else if (tools.isStringDPT(dpt)) {
+            ; //val = this.convertType(val);
+        } else if (tools.isUnknownDPT(dpt)) {
+            //write raw buffers for unknown dpts, iterface is a hex value
+            //bitlength is the buffers bytelength * 8.
+            val = Buffer.from(val, 'hex');
+            isRaw = true;
+            this.log.warn('Missing implementation for unhandeled DPT ' + dpt + ', assuming raw values');
+        } else {}
+
+        if (state.c == 'GroupValue_Read') {
+            //interface to trigger GrouValue_Read is this comment
+            this.log.debug('Outgoing GroupValue_Read to ' + ga + ' value ' + val);
+            this.knxConnection.read(ga);
+            if (!state.ack) this.setForeignState(id, {
+                ack: true,
+                c: 'self'
+            });
+        } else if (this.gaList.getDataById(id).common.write) {
+            this.log.debug('Outgoing GroupValue_Write to ' + ga + ' value ' + val + ' from ' + id);
+            if (isRaw) this.knxConnection.writeRaw(ga, val);
+            else this.knxConnection.write(ga, val, dpt);
+            if (!state.ack) this.setForeignState(id, {
+                ack: true,
+                c: 'self'
+            });
+        } else {
+            this.log.warn('not configured write to ga: ' + val);
+        }
+    }
 
+    //interface to knx stack
+    startKnxServer() {
         this.knxConnection = knx.Connection({
             ipAddr: this.config.gwip,
             ipPort: this.config.gwipport,
             physAddr: this.config.eibadr,
             minimumDelay: this.config.frameInterval,
             //map set the log level for messsages printed on the console. This can be 'error', 'warn', 'info' (default), 'debug', or 'trace'.
-            //loglevel: this.log.level == 'silly' ? 'trace' : this.log.level,
+            loglevel: this.log.level == 'silly' ? 'trace' : this.log.level,
             //debug:
             handlers: {
                 connected: () => {
-                    if (tools.isEmptyObject(this.knxDatapoints)) {
-
+                    //create new knx datapoint and bind to connection
+                    //in connected in order to have autoread work
+                    var cnt_complete = 0;
+                    var cnt_withDPT = 0;
+                    if (!this.autoreaddone) {
+                        //do autoread on start of adapter and not every connection
                         for (const key of this.gaList) {
-                            if (this.gaList.getById(key).native.address.match(/\d*\/\d*\/\d*/) && this.gaList.getById(key).native.dpt) {
+                            if (this.gaList.getDataById(key).native.address.match(/\d*\/\d*\/\d*/) && this.gaList.getDataById(key).native.dpt) {
                                 try {
-                                    // act AND state datapoint
-                                    this.knxDatapoints[this.gaList.getById(key).native.address] = new knx.Datapoint({
-                                        ga: this.gaList.getById(key).native.address,
-                                        dpt: this.gaList.getById(key).native.dpt,
-                                        autoread: this.gaList.getById(key).native.autoread // issue a GroupValue_Read request to try to get the initial state from the bus (if any)
+                                    var dp = new knx.Datapoint({
+                                        ga: this.gaList.getDataById(key).native.address,
+                                        dpt: this.gaList.getDataById(key).native.dpt,
+                                        autoread: this.gaList.getDataById(key).native.autoread // issue a GroupValue_Read request to try to get the initial state from the bus (if any)
                                     }, this.knxConnection);
+                                    this.gaList.setDpById(key, dp);
                                     cnt_withDPT++;
-                                    this.log.debug('Datapoint autoread created and GroupValueWrite sent: ' + this.gaList.getById(key).native.address + ' ' + key);
+                                    this.log.debug('Datapoint ' + (this.gaList.getDataById(key).native.autoread ? 'autoread ' : '') +
+                                        'created and GroupValueWrite sent: ' + this.gaList.getDataById(key).native.address + ' ' + key);
                                 } catch (e) {
                                     this.log.warn('could not create KNX Datapoint for ' + key + ' with error: ' + e);
                                 }
                             } else {
-                                this.log.debug('no match for ' + key);
+                                this.log.warn('no match for ' + key);
                             }
                             cnt_complete++;
                         }
+                        this.autoreaddone = true;
+                        this.log.info('Registered with ' + cnt_withDPT + ' KNX datapoints of ' + cnt_complete + ' datapoints in adapter.');
                     }
-
                     this.setState('info.connection', true, true);
-                    this.log.info('Connected! Registered with ' + cnt_withDPT + ' KNX datapoints of ' + cnt_complete + ' datapoints in adapter.');
+                    this.log.info('Connected!');
+                },
+
+                disconnected: () => {
+                    this.setState('info.connection', false, true);
+                    this.log.info('Connection lost');
                 },
 
                 event: (evt, src, dest, val) => {
@@ -308,43 +317,45 @@ class openknx extends utils.Adapter {
                     }
 
                     /* some checks */
-                    if (!this.mapping[dest]) {
+                    if (!this.gaList.getDpByAddress(dest)) {
                         this.log.warn('Ignoring ' + evt + ' received on unknown GA: ' + dest);
                         return;
                     }
 
-                    var val = tools.isStringDPT(this.knxDatapoints[dest].dptid) ? this.knxDatapoints[dest].current_value : this.convertType(this.knxDatapoints[dest].current_value);
+                    var val = tools.isStringDPT(this.gaList.getDataByAddress(dest).native.dpt) ?
+                        this.gaList.getDpByAddress(dest).current_value :
+                        this.convertType(this.gaList.getDpByAddress(dest).current_value);
 
                     switch (evt) {
                         case 'GroupValue_Read':
                             //fetch val from addressed object and write on bus if configured to answer
-                            this.getForeignState(this.mapping[dest]._id, (err, state) => {
-                                this.log.debug('Incoming GroupValue_Read from ' + src + ' to ' + '(' + dest + ') ' + this.mapping[dest].common.name);
-                                if (this.mapping[dest].native.answer_groupValueResponse) {
+                            this.getForeignState(this.gaList.getIdByAddress(dest), (err, state) => {
+                                this.log.debug('Incoming GroupValue_Read from ' + src + ' to ' + '(' + dest + ') ' + this.gaList.getDataByAddress(dest).common.name);
+                                if (this.gaList.getDataByAddress(dest).native.answer_groupValueResponse) {
                                     //https://bitbucket.org/ekarak/knx.js/issues/83/send-groupvalue_response
                                     //workaround, send out a write instead response
-                                    this.knxConnection.write(dest, state.val, this.mapping[dest].native.dpt);
+                                    this.knxConnection.write(dest, state.val, this.gaList.getDataByAddress(dest).native.dpt);
                                     this.log.debug('responding with value ' + state.val);
                                 }
                             });
                             break;
 
                         case 'GroupValue_Response':
-                            this.setForeignState(mapping[dest]._id, {
+                            this.setForeignState(this.gaList.getIdByAddress(dest), {
                                 val: val,
                                 ack: true,
                                 c: 'self'
                             });
-                            this.log.debug('Incoming GroupValue_Response from ' + src + ' to ' + '(' + dest + ') ' + this.mapping[dest].common.name + ': ' + this.knxDatapoints[dest].current_value);
+                            this.log.debug('Incoming GroupValue_Response from ' + src + ' to ' + '(' + dest + ') ' + this.gaList.getDataByAddress(dest).common.name + ': ' + val);
                             break;
 
                         case 'GroupValue_Write':
-                            this.setForeignState(this.mapping[dest]._id, {
+                            this.setForeignState(this.gaList.getIdByAddress(dest), {
                                 val: val,
                                 ack: true,
                                 c: 'self'
                             });
-                            this.log.debug('Incoming GroupValue_Write ga: ' + dest + '  val: ' + this.knxDatapoints[dest].current_value + ' dpt: ' + this.knxDatapoints[dest].dptid + ' to Object: ' + this.mapping[dest]._id);
+                            this.log.debug('Incoming GroupValue_Write ga: ' + dest + '  val: ' + val + ' dpt: ' + this.gaList.getDataByAddress(dest).native.dpt + ' to Object: ' + this.gaList.getIdByAddress(dest));
                             break;
 
                         default:
@@ -355,24 +366,13 @@ class openknx extends utils.Adapter {
         });
     }
 
-    /* for testing, forward msg from one to another test address*/
-    interfaceTest(id, state) {
-        const inpath = this.mynamespace + '.test.testin';
-        const outpath = this.mynamespace + '.test.testout';
-        if (id.startsWith(inpath)) {
-            var out = outpath + id.replace(inpath, '');
-            this.setForeignState(out, {
-                val: state.val,
-                ack: true,
-            });
-        }
-    }
-
     //todo: after override object path settings change load states again
     main() {
         this.log.info('Connecting to knx gateway:  ' + this.config.gwip + ":" + this.config.gwipport + '   with phy. Adr:  ' + this.config.eibadr + ' minimum send delay: ' + this.config.frameInterval);
         this.log.info(utils.controllerDir);
         this.setState('info.connection', false, true);
+
+        //fill gaList object from iobroker objects 
         this.getObjectView('system', 'state', {
             startkey: this.mynamespace + '.',
             endkey: this.mynamespace + '.\u9999',
@@ -381,42 +381,58 @@ class openknx extends utils.Adapter {
             if (err) {
                 this.log.error('Cannot get objects: ' + err);
             } else {
-                this.states = {};
                 for (var i = res.rows.length - 1; i >= 0; i--) {
                     var id = res.rows[i].id;
-                    this.states[id] = res.rows[i].value; //list by object name todo remove
-                    this.mapping[res.rows[i].value.native.address] = res.rows[i].value; //list by ga todo remove
                     this.gaList.set(id, res.rows[i].value.native.address, res.rows[i].value);
                 }
                 this.startKnxServer();
             }
         });
+
     }
 }
 
-
 class DoubleKeyedMap {
     constructor() {
+        //id, ga
         this.keymap = new Map();
+        //id,  iobroker object
         this.data = new Map();
+        //id, knx dp
+        this.dp = new Map();
     }
+    //update or add
     set(id, address, data) {
-        this.keymap.set(id, address);
+        this.keymap.set(address, id);
         this.data.set(id, data);
     }
-    getById(id) {
+    //only dp returns transformed value, hold a reference to it
+    setDpById(id, dp) {
+        this.dp.set(id, dp);
+    }
+    getDpById(id) {
+        return this.dp.get(id);
+    }
+    getDpByAddress(address) {
+        return this.dp.get(this.keymap.get(address));
+    }
+    getDataById(id) {
         return this.data.get(id);
     }
-    getByAddress(address) {
+    getDataByAddress(address) {
         return this.data.get(this.keymap.get(address));
     }
+    getIdByAddress(address) {
+        return this.keymap.get(address);
+    }
 
+    //key value is id
     [Symbol.iterator] = function () {
         return {
             index: -1,
             data: this.data,
             next() {
-                return (this.index++ < this.data.size) ? {
+                return (++this.index < this.data.size) ? {
                     done: false,
                     value: Array.from(this.data.keys())[this.index]
                 } : {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "iobroker.openknx",
-  "version": "0.0.15",
+  "version": "0.0.16",
   "dependencies": {
     "@iobroker/adapter-core": "^2.5.1",
     "binary-parser": "^1.1.5",