iobroker.lorawan 1.16.5 → 1.16.6

package/README.md

@@ -23,6 +23,9 @@ For now there is documentation in English here: https://wiki.hafenmeister.de
 	Placeholder for the next version (at the beginning of the line):
 	### **WORK IN PROGRESS**
 -->
+### 1.16.6 (2025-09-17)
+* (BenAhrdt) Change detection of new Discovery from LoRaWAN devices
+
 ### 1.16.5 (2025-09-17)
 * (BenAhrdt) Bugfix in notifications to Bridge (new device dicovered) => namespace not set
 

package/io-package.json

@@ -1,8 +1,21 @@
 {
   "common": {
     "name": "lorawan",
-    "version": "1.16.5",
+    "version": "1.16.6",
     "news": {
+      "1.16.6": {
+        "en": "Change detection of new Discovery from LoRaWAN devices",
+        "de": "Änderung der Erkennung neuer Entdeckungen von LoRaWAN-Geräten",
+        "ru": "Обнаружение изменений новых устройств LoRaWAN",
+        "pt": "Detecção de novos dispositivos LoRaWAN na Descoberta",
+        "nl": "Wijziging in detectie van nieuwe Discovery van LoRaWAN apparaten",
+        "fr": "Détection des nouvelles découvertes des dispositifs LoRaWAN",
+        "it": "Rilevamento delle nuove scoperte dei dispositivi LoRaWAN",
+        "es": "Detección de cambios de nuevos dispositivos de descubrimiento de LoRaWAN",
+        "pl": "Wykrywanie zmian w nowym Discovery urządzeń LoRaWAN",
+        "uk": "Виявлення нових пристроїв Discovery з LoRaWAN",
+        "zh-cn": "更改LoRaWAN设备的新发现检测"
+      },
       "1.16.5": {
         "en": "Bugfix in notifications to Bridge (new device dicovered) => namespace not set",
         "de": "Fehlerbehebung bei Benachrichtigungen an Bridge (neues Gerät erkannt) => Namespace nicht festgelegt",
@@ -80,19 +93,6 @@
         "pl": "możliwość wstawienia stanów zewnętrznych do mostka za pomocą enum.functions.bridge",
         "uk": "Можливість додавання зовнішніх станів до моста за допомогою enum.functions.bridge",
         "zh-cn": "通过使用enum.functions.bridge功能，可以将外部状态插入到桥接器中。"
-      },
-      "1.15.8": {
-        "en": "remove await from some callings",
-        "de": "Entferne das „await“ aus einigen Aufrufen.",
-        "ru": "Удалите ожидание (await) из некоторых вызовов",
-        "pt": "remover await de algumas chamadas",
-        "nl": "Verwijder 'await' uit enkele aanroepen.",
-        "fr": "supprimer l'attente de certains appels",
-        "it": "Rimuovere l'attesa da alcune chiamate.",
-        "es": "eliminar await de algunas llamadas",
-        "pl": "Usuń oczekiwanie (await) z niektórych wywołań.",
-        "uk": "видаліть await із деяких викликів",
-        "zh-cn": "从部分调用中删除 await"
       }
     },
     "titleLang": {

package/lib/modules/bridge.js

@@ -234,12 +234,9 @@ class bridgeClass {
         this.adapter.log.debug(`Function ${activeFunction} started.`);
         try {
             if (this.bridgeMqttClient.internalConnectionstate) {
-                const countBefore = Object.keys(this.Notifications).length;
-                await this.discovery(id, options);
-                // notify new discovered Devices (Notification count changed)
-                // On startup this ist mostly true, but the genereal notification id will set later.
-                // So there is no notificaton published to Bridge
-                if (countBefore !== Object.keys(this.Notifications).length) {
+                const newNotification = await this.discovery(id, options);
+                // notify new discovered Devices (new notification)
+                if (newNotification) {
                     const device = this.DiscoveredIds[id].informations.usedDeviceId;
                     const application = this.DiscoveredIds[id].informations.usedApplicationName;
                     const message = `${this.adapter.i18nTranslation['new device discovered']}.\n${this.adapter.i18nTranslation['Device']}: ${device}\n${this.adapter.i18nTranslation['Application']}: ${application}`;
@@ -280,10 +277,10 @@ class bridgeClass {
             if (!this.CheckedIds[id] || (options && options.forceDiscovery)) {
                 this.CheckedIds[id] = {};
                 this.adapter.log.debug(`discover the id ${id}`);
-                await this.buildDiscovery(id, options);
-            } else {
-                this.adapter.log.debug(`${id} allready checked for discovery`);
+                return await this.buildDiscovery(id, options);
             }
+            this.adapter.log.debug(`${id} allready checked for discovery`);
+            return false;
         } catch (error) {
             this.adapter.log.error(`error at ${activeFunction}:  ${error}`);
         }
@@ -398,7 +395,9 @@ class bridgeClass {
                         usedDeviceId: changeInfo.usedDeviceId,
                     },
                 });
+                return true;
             }
+            return false;
         } catch (error) {
             this.adapter.log.error(`error at ${activeFunction}:  ${error}`);
         }
@@ -817,6 +816,8 @@ class bridgeClass {
         const activeFunction = 'bridge.js - buildDiscovery';
         this.adapter.log.debug(`Function ${activeFunction} started.`);
         try {
+            // Defaultvalue for discover
+            let newNotification = false;
             // Query for decoded Folder
             if (id.includes(`${this.adapter.messagehandler.directoryhandler.reachableSubfolders.uplinkDecoded}.`)) {
                 const changeInfo = await this.adapter.getChangeInfo(id);
@@ -876,7 +877,11 @@ class bridgeClass {
                                 usedDeviceId: changeInfo.usedDeviceId,
                             },
                         });
-                        await this.discoverDeviceNotifications(changeInfo);
+                        if (await this.discoverDeviceNotifications(changeInfo)) {
+                            newNotification = true;
+                        } else {
+                            newNotification = false;
+                        }
                     }
                 }
 
@@ -950,10 +955,15 @@ class bridgeClass {
                                 usedDeviceId: changeInfo.usedDeviceId,
                             },
                         });
-                        await this.discoverDeviceNotifications(changeInfo);
+                        if (await this.discoverDeviceNotifications(changeInfo)) {
+                            newNotification = true;
+                        } else {
+                            newNotification = false;
+                        }
                     }
                 }
             }
+            return newNotification;
         } catch (error) {
             this.adapter.log.error(`error at ${activeFunction}:  ${error}`);
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "iobroker.lorawan",
-  "version": "1.16.5",
+  "version": "1.16.6",
   "description": "converts the desired lora gateway data to a ioBroker structure",
   "author": {
     "name": "BenAhrdt",