iobroker.javascript 9.2.3 → 9.2.4

package/build/lib/sandbox.js

@@ -33,6 +33,8 @@ var __importStar = (this && this.__importStar) || (function () {
     };
 })();
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.isExactId = isExactId;
+exports.removeFromDispatchIndex = removeFromDispatchIndex;
 exports.sandBox = sandBox;
 const jsonataMod = __importStar(require("jsonata"));
 const adapter_core_1 = require("@iobroker/adapter-core");
@@ -43,6 +45,61 @@ const eventObjMod = __importStar(require("./eventObj"));
 const patternCompareFunctions_1 = require("./patternCompareFunctions");
 const SCRIPT_CODE_MARKER = 'script.js.';
 const pattern2RegEx = adapter_core_1.commonTools.pattern2RegEx;
+// Pre-compiled RegExp constants for formatTimeDiff – avoids recompiling on every call
+const FTD_TEST_D = /(?<!\\)[DTД]/;
+const FTD_REPL_DD = /(?<!\\)(?:DD|TT|ДД)/g;
+const FTD_REPL_D = /(?<!\\)[DTД]/g;
+const FTD_TEST_H = /(?<!\\)[hSч]/;
+const FTD_REPL_HH = /(?<!\\)(?:hh|SS|чч)/g;
+const FTD_REPL_H = /(?<!\\)[hSч]/g;
+const FTD_TEST_M = /(?<!\\)[mм]/;
+const FTD_REPL_MM = /(?<!\\)(?:mm|мм)/g;
+const FTD_REPL_M = /(?<!\\)[mм]/g;
+const FTD_TEST_S = /(?<!\\)[sс]/;
+const FTD_REPL_SS = /(?<!\\)(?:ss|сс)/g;
+const FTD_REPL_S = /(?<!\\)[sс]/g;
+const FTD_UNESCAPE = [
+    [/\\([DTД])/g, '$1'],
+    [/\\([hSч])/g, '$1'],
+    [/\\([mм])/g, '$1'],
+    [/\\([sс])/g, '$1'],
+];
+/** Maximum number of cached selector RegExps before FIFO eviction kicks in */
+const _SELECTOR_REGEXP_CACHE_MAX = 1000;
+/** Cache for selector-string → RegExp to avoid recompiling identical patterns (FIFO-bounded) */
+const _selectorRegExpCache = new Map();
+/** Monotonically increasing handler-ID counter – avoids Date.now()+random collisions */
+let _handlerIdCounter = 1;
+/** Returns true when patId is a plain exact state-ID (no wildcards, no RegExp notation). */
+function isExactId(patId) {
+    return (!!patId && typeof patId === 'string' && !patId.includes('*') && !patId.includes('?') && !patId.startsWith('/'));
+}
+/**
+ * Removes a subscription from the O(1) dispatch index (subscriptionsMap / subscriptionsWildcard).
+ * Must use the same exact-id classification as the subscribe side (isExactId),
+ * otherwise entries leak in the structure that was not searched.
+ */
+function removeFromDispatchIndex(ctx, sub) {
+    const patId = sub.pattern?.id;
+    if (isExactId(patId)) {
+        const bucket = ctx.subscriptionsMap.get(patId);
+        if (bucket) {
+            const pos = bucket.indexOf(sub);
+            if (pos !== -1) {
+                bucket.splice(pos, 1);
+            }
+            if (bucket.length === 0) {
+                ctx.subscriptionsMap.delete(patId);
+            }
+        }
+    }
+    else {
+        const wPos = ctx.subscriptionsWildcard.indexOf(sub);
+        if (wPos !== -1) {
+            ctx.subscriptionsWildcard.splice(wPos, 1);
+        }
+    }
+}
 function sandBox(script, name, verbose, debug, context) {
     const consts = constsMod;
     const words = wordsMod;
@@ -211,14 +268,24 @@ function sandBox(script, name, verbose, debug, context) {
      * @param str The selector string to transform into a regular expression
      */
     function selectorStringToRegExp(str) {
+        const cached = _selectorRegExpCache.get(str);
+        if (cached) {
+            return cached;
+        }
         const startsWithWildcard = str[0] === '*';
         const endsWithWildcard = str[str.length - 1] === '*';
-        // Sanitize the selector, so it is safe to use in a RegEx
-        // Taken from https://stackoverflow.com/a/3561711/10179833 but modified
-        // since * has a special meaning in our selector and should not be escaped
         // eslint-disable-next-line no-useless-escape
-        str = str.replace(/[-\/\\^$+?.()|[\]{}]/g, '\\$&').replace(/\*/g, '.*');
-        return new RegExp((startsWithWildcard ? '' : '^') + str + (endsWithWildcard ? '' : '$'));
+        const escaped = str.replace(/[-\/\\^$+?.()|[\]{}]/g, '\\$&').replace(/\*/g, '.*');
+        const re = new RegExp((startsWithWildcard ? '' : '^') + escaped + (endsWithWildcard ? '' : '$'));
+        // FIFO eviction: drop the oldest entry once the cache exceeds its limit
+        if (_selectorRegExpCache.size >= _SELECTOR_REGEXP_CACHE_MAX) {
+            const oldestKey = _selectorRegExpCache.keys().next().value;
+            if (oldestKey !== undefined) {
+                _selectorRegExpCache.delete(oldestKey);
+            }
+        }
+        _selectorRegExpCache.set(str, re);
+        return re;
     }
     /**
      * Adds a regular expression for selectors targeting the state ID
@@ -741,8 +808,8 @@ function sandBox(script, name, verbose, debug, context) {
                 if (!context.channels || !context.devices) {
                     context.channels = {};
                     context.devices = {};
-                    for (const _id in objects) {
-                        if (Object.prototype.hasOwnProperty.call(objects, _id) && objects[_id].type === 'state') {
+                    for (const _id of Object.keys(objects)) {
+                        if (objects[_id].type === 'state') {
                             const parts = _id.split('.');
                             parts.pop();
                             const chn = parts.join('.');
@@ -759,8 +826,8 @@ function sandBox(script, name, verbose, debug, context) {
             if (name === 'schedule') {
                 if (!context.schedules) {
                     context.schedules = [];
-                    for (const _id in objects) {
-                        if (Object.prototype.hasOwnProperty.call(objects, _id) && objects[_id].type === 'schedule') {
+                    for (const _id of Object.keys(objects)) {
+                        if (objects[_id].type === 'schedule') {
                             context.schedules.push(_id);
                         }
                     }
@@ -1087,7 +1154,7 @@ function sandBox(script, name, verbose, debug, context) {
                 sandbox.log(`Invalid callback for onLog`, 'warn');
                 return 0;
             }
-            const handler = { id: Date.now() + Math.floor(Math.random() * 10000), cb: callback, sandbox, severity };
+            const handler = { id: _handlerIdCounter++, cb: callback, sandbox, severity };
             context.logSubscriptions[sandbox.scriptName] = context.logSubscriptions[sandbox.scriptName] || [];
             context.logSubscriptions[sandbox.scriptName].push(handler);
             context.updateLogSubscriptions();
@@ -1455,6 +1522,16 @@ function sandBox(script, name, verbose, debug, context) {
             subscribePattern(script, oPattern.id);
             subs.patternCompareFunctions = getPatternCompareFunctions(oPattern);
             context.subscriptions.push(subs);
+            // O(1) dispatch index: exact string IDs go into the map, everything else into the wildcard array
+            if (isExactId(oPattern.id)) {
+                if (!context.subscriptionsMap.has(oPattern.id)) {
+                    context.subscriptionsMap.set(oPattern.id, []);
+                }
+                context.subscriptionsMap.get(oPattern.id).push(subs);
+            }
+            else {
+                context.subscriptionsWildcard.push(subs);
+            }
             if (oPattern.enumName || oPattern.enumId) {
                 context.isEnums = true;
             }
@@ -1462,13 +1539,13 @@ function sandBox(script, name, verbose, debug, context) {
         },
         getSubscriptions: function () {
             const result = {};
-            for (let s = 0; s < context.subscriptions.length; s++) {
-                result[context.subscriptions[s].pattern.id] =
-                    result[context.subscriptions[s].pattern.id] || [];
-                result[context.subscriptions[s].pattern.id].push({
-                    name: context.subscriptions[s].name,
-                    pattern: context.subscriptions[s].pattern,
-                });
+            // Iterate over the O(1) dispatch index instead of the flat array
+            for (const [id, bucket] of context.subscriptionsMap) {
+                result[id] = bucket.map(s => ({ name: s.name, pattern: s.pattern }));
+            }
+            for (const s of context.subscriptionsWildcard) {
+                const key = s.pattern.id;
+                (result[key] ??= []).push({ name: s.name, pattern: s.pattern });
             }
             if (sandbox.verbose) {
                 sandbox.log(`getSubscriptions() => ${JSON.stringify(result)}`, 'info');
@@ -1527,8 +1604,11 @@ function sandBox(script, name, verbose, debug, context) {
             if ((0, tools_1.isObject)(idOrObject)) {
                 for (let i = context.subscriptions.length - 1; i >= 0; i--) {
                     if (context.subscriptions[i] === idOrObject) {
-                        unsubscribePattern(script, context.subscriptions[i].pattern.id);
+                        const sub = context.subscriptions[i];
+                        unsubscribePattern(script, sub.pattern.id);
                         context.subscriptions.splice(i, 1);
+                        // Remove from O(1) dispatch structures
+                        removeFromDispatchIndex(context, sub);
                         sandbox.__engine.__subscriptions--;
                         return true;
                     }
@@ -1539,8 +1619,11 @@ function sandBox(script, name, verbose, debug, context) {
             for (let i = context.subscriptions.length - 1; i >= 0; i--) {
                 if (context.subscriptions[i].name === name && context.subscriptions[i].pattern.id === idOrObject) {
                     deleted++;
-                    unsubscribePattern(script, context.subscriptions[i].pattern.id);
+                    const sub = context.subscriptions[i];
+                    unsubscribePattern(script, sub.pattern.id);
                     context.subscriptions.splice(i, 1);
+                    // Remove from O(1) dispatch structures
+                    removeFromDispatchIndex(context, sub);
                     sandbox.__engine.__subscriptions--;
                 }
             }
@@ -2459,7 +2542,7 @@ function sandBox(script, name, verbose, debug, context) {
                     }
                     let result;
                     try {
-                        result = JSON.parse(JSON.stringify(objects[id]));
+                        result = objects[id] ? structuredClone(objects[id]) : undefined;
                     }
                     catch (err) {
                         void adapter.setState(`scriptProblem.${name.substring(SCRIPT_CODE_MARKER.length)}`, {
@@ -2484,9 +2567,9 @@ function sandBox(script, name, verbose, debug, context) {
                 }
                 if (enumName) {
                     const e = eventObj.getObjectEnumsSync(context, id);
-                    const obj = JSON.parse(JSON.stringify(objects[id]));
-                    obj.enumIds = JSON.parse(JSON.stringify(e.enumIds));
-                    obj.enumNames = JSON.parse(JSON.stringify(e.enumNames));
+                    const obj = structuredClone(objects[id]);
+                    obj.enumIds = structuredClone(e.enumIds);
+                    obj.enumNames = structuredClone(e.enumNames);
                     if (typeof enumName === 'string') {
                         const r = new RegExp(`^enum\\.${enumName}\\.`);
                         for (let i = obj.enumIds.length - 1; i >= 0; i--) {
@@ -2502,7 +2585,7 @@ function sandBox(script, name, verbose, debug, context) {
                 }
                 let result;
                 try {
-                    result = JSON.parse(JSON.stringify(objects[id]));
+                    result = structuredClone(objects[id]);
                 }
                 catch (err) {
                     void adapter.setState(`scriptProblem.${name.substring(SCRIPT_CODE_MARKER.length)}`, {
@@ -2573,7 +2656,7 @@ function sandBox(script, name, verbose, debug, context) {
             if (sandbox.verbose) {
                 sandbox.log(`getEnums(enumName=${enumName}) => ${JSON.stringify(result)}`, 'info');
             }
-            return JSON.parse(JSON.stringify(result));
+            return structuredClone(result);
         },
         createAlias: function (name, alias, forceCreation, common, native, callback) {
             if (typeof native === 'function') {
@@ -3242,7 +3325,14 @@ function sandBox(script, name, verbose, debug, context) {
                             return;
                         }
                         const instances = res.rows.map(item => item.id.substring('system.adapter.'.length));
-                        // Store in cache for subsequent calls (invalidated on system.adapter.* object change)
+                        // Store in cache for subsequent calls (invalidated on system.adapter.* object change).
+                        // LRU eviction: keep the map bounded to avoid unbounded memory growth.
+                        if (context.sendToInstanceCache.size >= 200) {
+                            const firstKey = context.sendToInstanceCache.keys().next().value;
+                            if (firstKey !== undefined) {
+                                context.sendToInstanceCache.delete(firstKey);
+                            }
+                        }
                         context.sendToInstanceCache.set(_adapter, instances);
                         instances.forEach(instance => {
                             sandbox.verbose &&
@@ -3715,50 +3805,45 @@ function sandBox(script, name, verbose, debug, context) {
             const day = 24 * hour;
             const neg = diff < 0;
             diff = Math.abs(diff);
-            if (/(?<!\\)(D|T|Д)/.test(text)) {
+            if (FTD_TEST_D.test(text)) {
                 const days = Math.floor(diff / day);
-                text = text
-                    .replace(/(?<!\\)(DD|TT|ДД)/g, days.toString().padStart(2, '0'))
-                    .replace(/(?<!\\)(D|T|Д)/g, days.toString());
+                text = text.replace(FTD_REPL_DD, days.toString().padStart(2, '0')).replace(FTD_REPL_D, days.toString());
                 if (sandbox.verbose) {
                     sandbox.log(`formatTimeDiff(format=${format}, text=${text}, days=${days})`, 'debug');
                 }
                 diff -= days * day;
             }
-            if (/(?<!\\)(h|S|ч)/.test(text)) {
+            if (FTD_TEST_H.test(text)) {
                 const hours = Math.floor(diff / hour);
                 text = text
-                    .replace(/(?<!\\)(hh|SS|чч)/g, hours.toString().padStart(2, '0'))
-                    .replace(/(?<!\\)(h|S|ч)/g, hours.toString());
+                    .replace(FTD_REPL_HH, hours.toString().padStart(2, '0'))
+                    .replace(FTD_REPL_H, hours.toString());
                 if (sandbox.verbose) {
                     sandbox.log(`formatTimeDiff(format=${format}, text=${text}, hours=${hours})`, 'debug');
                 }
                 diff -= hours * hour;
             }
-            if (/(?<!\\)(m|м)/.test(text)) {
+            if (FTD_TEST_M.test(text)) {
                 const minutes = Math.floor(diff / minute);
                 text = text
-                    .replace(/(?<!\\)(mm|мм)/g, minutes.toString().padStart(2, '0'))
-                    .replace(/(?<!\\)(m|м)/g, minutes.toString());
+                    .replace(FTD_REPL_MM, minutes.toString().padStart(2, '0'))
+                    .replace(FTD_REPL_M, minutes.toString());
                 if (sandbox.verbose) {
                     sandbox.log(`formatTimeDiff(format=${format}, text=${text}, minutes=${minutes})`, 'debug');
                 }
                 diff -= minutes * minute;
             }
-            if (/(?<!\\)(s|с)/.test(text)) {
+            if (FTD_TEST_S.test(text)) {
                 const seconds = Math.floor(diff / second);
                 text = text
-                    .replace(/(?<!\\)(ss|сс)/g, seconds.toString().padStart(2, '0'))
-                    .replace(/(?<!\\)(s|с)/g, seconds.toString());
+                    .replace(FTD_REPL_SS, seconds.toString().padStart(2, '0'))
+                    .replace(FTD_REPL_S, seconds.toString());
                 sandbox.verbose &&
                     sandbox.log(`formatTimeDiff(format=${format}, text=${text}, seconds=${seconds})`, 'debug');
-                // diff -= seconds * second; // no milliseconds
             }
-            text = text
-                .replace(/\\(D|T|Д)/g, '$1')
-                .replace(/\\(h|S|ч)/g, '$1')
-                .replace(/\\(m|м)/g, '$1')
-                .replace(/\\(s|с)/g, '$1');
+            for (const [pattern, replacement] of FTD_UNESCAPE) {
+                text = text.replace(pattern, replacement);
+            }
             if (sandbox.verbose) {
                 sandbox.log(`formatTimeDiff(format=${format}, text=${text})`, 'debug');
             }
@@ -4382,7 +4467,7 @@ function sandBox(script, name, verbose, debug, context) {
             context.messageBusHandlers[sandbox.scriptName] = context.messageBusHandlers[sandbox.scriptName] || {};
             context.messageBusHandlers[sandbox.scriptName][messageName] =
                 context.messageBusHandlers[sandbox.scriptName][messageName] || [];
-            const handler = { id: Date.now() + Math.floor(Math.random() * 10000), cb: callback, sandbox };
+            const handler = { id: _handlerIdCounter++, cb: callback, sandbox };
             context.messageBusHandlers[sandbox.scriptName][messageName].push(handler);
             sandbox.__engine.__subscriptionsMessage += 1;
             if (sandbox.__engine.__subscriptionsMessage %
@@ -4397,23 +4482,18 @@ function sandBox(script, name, verbose, debug, context) {
             let found = false;
             if (ctx) {
                 if (typeof idOrName === 'number') {
-                    for (const messageName in ctx) {
-                        if (Object.prototype.hasOwnProperty.call(ctx, messageName)) {
-                            for (let i = 0; i < ctx[messageName].length; i++) {
-                                if (ctx[messageName][i].id === idOrName) {
-                                    ctx[messageName].splice(i, 1);
-                                    if (!ctx[messageName].length) {
-                                        delete ctx[messageName];
-                                        sandbox.__engine.__subscriptionsMessage--;
-                                    }
-                                    found = true;
-                                    break;
+                    outer: for (const messageName of Object.keys(ctx)) {
+                        for (let i = 0; i < ctx[messageName].length; i++) {
+                            if (ctx[messageName][i].id === idOrName) {
+                                ctx[messageName].splice(i, 1);
+                                if (!ctx[messageName].length) {
+                                    delete ctx[messageName];
+                                    sandbox.__engine.__subscriptionsMessage--;
                                 }
+                                found = true;
+                                break outer;
                             }
                         }
-                        if (found) {
-                            break;
-                        }
                     }
                 }
                 else if (idOrName && ctx[idOrName]) {
@@ -4662,11 +4742,33 @@ function sandBox(script, name, verbose, debug, context) {
                 if (sandbox.verbose) {
                     sandbox.log(`extendObject(id=${id}, obj=${JSON.stringify(obj)})`, 'info');
                 }
+                let objClone;
+                try {
+                    objClone = structuredClone(obj);
+                }
+                catch (err) {
+                    // e.g. DataCloneError when the object contains functions
+                    void adapter.setState(`scriptProblem.${name.substring(SCRIPT_CODE_MARKER.length)}`, {
+                        val: true,
+                        ack: true,
+                        c: 'extendObject',
+                    });
+                    sandbox.log(`Object "${id}" can't be copied: ${JSON.stringify(err)}`, 'error');
+                    if (typeof callback === 'function') {
+                        try {
+                            callback.call(sandbox, new Error(`Object "${id}" can't be copied`));
+                        }
+                        catch (err) {
+                            errorInCallback(err);
+                        }
+                    }
+                    return;
+                }
                 if (callback) {
-                    adapter.extendForeignObject(id, JSON.parse(JSON.stringify(obj)), callback);
+                    adapter.extendForeignObject(id, objClone, callback);
                 }
                 else {
-                    void adapter.extendForeignObject(id, JSON.parse(JSON.stringify(obj)));
+                    void adapter.extendForeignObject(id, objClone);
                 }
             }
         };
@@ -4722,6 +4824,11 @@ function sandBox(script, name, verbose, debug, context) {
             writable: false,
         });
     }
+    // Shallow-freeze the console object exposed to scripts to prevent its methods from being overwritten
+    // Note: __engine must NOT be frozen because its counter properties are mutated at runtime
+    if (sandbox.console && typeof sandbox.console === 'object') {
+        Object.freeze(sandbox.console);
+    }
     return sandbox;
 }
 //# sourceMappingURL=sandbox.js.map