iobroker.iot 5.0.13 → 6.0.3

package/build/lib/AlexaSmartHomeV3/Helpers/DiscoveryValidator.js

@@ -0,0 +1,283 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.validateDiscoveryResponse = validateDiscoveryResponse;
+// Alexa limits: https://developer.amazon.com/en-US/docs/alexa/device-apis/alexa-discovery.html
+const MAX_ENDPOINTS = 300;
+const MAX_ENDPOINT_ID_LENGTH = 256;
+const MAX_FRIENDLY_NAME_LENGTH = 128;
+const MAX_DESCRIPTION_LENGTH = 128;
+const MAX_MANUFACTURER_NAME_LENGTH = 128;
+const MAX_CAPABILITIES_PER_ENDPOINT = 100;
+// AWS IoT MQTT message size limit (128 KB minus overhead)
+const MAX_RESPONSE_SIZE_BYTES = 127 * 1024;
+const RESPONSE_SIZE_WARNING_BYTES = 100 * 1024;
+// https://developer.amazon.com/en-US/docs/alexa/device-apis/alexa-discovery.html#display-categories
+const VALID_DISPLAY_CATEGORIES = new Set([
+    'ACTIVITY_TRIGGER',
+    'AIR_CONDITIONER',
+    'AIR_FRESHENER',
+    'AIR_PURIFIER',
+    'AIR_QUALITY_MONITOR',
+    'ALEXA_VOICE_ENABLED',
+    'AUTO_ACCESSORY',
+    'BLUETOOTH_SPEAKER',
+    'CAMERA',
+    'CHRISTMAS_TREE',
+    'COFFEE_MAKER',
+    'COMPUTER',
+    'CONTACT_SENSOR',
+    'DISHWASHER',
+    'DOOR',
+    'DOORBELL',
+    'DRYER',
+    'EXTERIOR_BLIND',
+    'FAN',
+    'GAME_CONSOLE',
+    'GARAGE_DOOR',
+    'HEADPHONES',
+    'HUB',
+    'INTERIOR_BLIND',
+    'LAPTOP',
+    'LIGHT',
+    'MICROWAVE',
+    'MOBILE_PHONE',
+    'MOTION_SENSOR',
+    'MUSIC_SYSTEM',
+    'NETWORK_HARDWARE',
+    'OTHER',
+    'OVEN',
+    'PHONE',
+    'PRINTER',
+    'REMOTE',
+    'ROUTER',
+    'SCENE_TRIGGER',
+    'SCREEN',
+    'SECURITY_PANEL',
+    'SECURITY_SYSTEM',
+    'SLOW_COOKER',
+    'SMARTLOCK',
+    'SMARTPLUG',
+    'SPEAKER',
+    'STREAMING_DEVICE',
+    'SWITCH',
+    'TABLET',
+    'TEMPERATURE_SENSOR',
+    'THERMOSTAT',
+    'TV',
+    'VACUUM_CLEANER',
+    'VACUUM',
+    'VEHICLE',
+    'WASHER',
+    'WATER_HEATER',
+    'WEARABLE',
+]);
+const VALID_NAMESPACES = new Set([
+    'Alexa',
+    'Alexa.BrightnessController',
+    'Alexa.ColorController',
+    'Alexa.ColorTemperatureController',
+    'Alexa.ContactSensor',
+    'Alexa.EndpointHealth',
+    'Alexa.HumiditySensor',
+    'Alexa.LockController',
+    'Alexa.ModeController',
+    'Alexa.MotionSensor',
+    'Alexa.PercentageController',
+    'Alexa.PowerController',
+    'Alexa.RangeController',
+    'Alexa.SceneController',
+    'Alexa.Speaker',
+    'Alexa.TemperatureSensor',
+    'Alexa.ThermostatController',
+]);
+// Multi-instance capabilities that require an instance property
+const REQUIRES_INSTANCE = new Set(['Alexa.ModeController', 'Alexa.RangeController', 'Alexa.ToggleController']);
+// Alexa wake words — devices named like this can't be controlled
+const WAKE_WORDS = ['alexa', 'echo', 'amazon', 'computer', 'ziggy'];
+/**
+ * Validates the Alexa Discovery response and removes invalid endpoints.
+ * Returns the sanitized response.
+ */
+function validateDiscoveryResponse(response, log) {
+    // Validate response header structure
+    const header = response?.event?.header;
+    if (!header) {
+        log.error('Discovery: response has no event.header');
+        return response;
+    }
+    // @ts-expect-error
+    if (header.namespace !== 'Alexa.Discovery') {
+        log.error(`Discovery: unexpected namespace "${header.namespace}", expected "Alexa.Discovery"`);
+    }
+    if (header.name !== 'Discover.Response') {
+        log.error(`Discovery: unexpected name "${header.name}", expected "Discover.Response"`);
+    }
+    if (header.payloadVersion !== '3') {
+        log.error(`Discovery: unexpected payloadVersion "${header.payloadVersion}", expected "3"`);
+    }
+    const endpoints = response?.event?.payload?.endpoints;
+    if (!endpoints || !Array.isArray(endpoints)) {
+        return response;
+    }
+    const errors = [];
+    const warnings = [];
+    const seenIds = new Set();
+    const seenNames = new Set();
+    // Validate and filter endpoints in place (backwards to safely splice)
+    for (let i = endpoints.length - 1; i >= 0; i--) {
+        const ep = endpoints[i];
+        const epIssues = validateEndpoint(ep, seenIds, seenNames);
+        const epErrors = epIssues.filter(e => e.severity === 'error');
+        const epWarnings = epIssues.filter(e => e.severity === 'warning');
+        warnings.push(...epWarnings);
+        if (epErrors.length) {
+            errors.push(...epErrors);
+            endpoints.splice(i, 1);
+        }
+    }
+    // Enforce 300 endpoint limit
+    if (endpoints.length > MAX_ENDPOINTS) {
+        log.warn(`Discovery: ${endpoints.length} endpoints exceeds Alexa limit of ${MAX_ENDPOINTS}, truncating`);
+        endpoints.length = MAX_ENDPOINTS;
+    }
+    // Check total response size against AWS IoT MQTT limit
+    const responseSize = JSON.stringify(response).length;
+    if (responseSize > MAX_RESPONSE_SIZE_BYTES) {
+        const originalCount = endpoints.length;
+        while (endpoints.length > 1 && JSON.stringify(response).length > MAX_RESPONSE_SIZE_BYTES) {
+            const removed = endpoints.pop();
+            log.warn(`Discovery: removed "${removed.friendlyName}" to fit AWS IoT message size limit`);
+        }
+        log.warn(`Discovery: response was ${Math.round(responseSize / 1024)} KB (limit: ${Math.round(MAX_RESPONSE_SIZE_BYTES / 1024)} KB), reduced from ${originalCount} to ${endpoints.length} endpoints`);
+    }
+    else if (responseSize > RESPONSE_SIZE_WARNING_BYTES) {
+        log.warn(`Discovery: response is ${Math.round(responseSize / 1024)} KB with ${endpoints.length} endpoints — approaching AWS IoT limit of ${Math.round(MAX_RESPONSE_SIZE_BYTES / 1024)} KB`);
+    }
+    // Log warnings (non-fatal)
+    for (const w of warnings) {
+        log.warn(`Discovery: "${w.friendlyName}" (${w.endpointId}): ${w.field} — ${w.message}`);
+    }
+    // Log errors (endpoint was removed)
+    for (const err of errors) {
+        log.warn(`Discovery: removed "${err.friendlyName}" (${err.endpointId}): ${err.field} — ${err.message}`);
+    }
+    if (errors.length || warnings.length) {
+        log.info(`Discovery: ${endpoints.length} endpoint(s) valid, ${errors.length} removed, ${warnings.length} warning(s)`);
+    }
+    return response;
+}
+function validateEndpoint(ep, seenIds, seenNames) {
+    const issues = [];
+    const id = ep.endpointId || '(empty)';
+    const name = ep.friendlyName || '(empty)';
+    const error = (field, message) => ({
+        endpointId: id,
+        friendlyName: name,
+        field,
+        message,
+        severity: 'error',
+    });
+    const warning = (field, message) => ({
+        endpointId: id,
+        friendlyName: name,
+        field,
+        message,
+        severity: 'warning',
+    });
+    // --- endpointId ---
+    if (!ep.endpointId) {
+        issues.push(error('endpointId', 'missing'));
+    }
+    else if (ep.endpointId.length > MAX_ENDPOINT_ID_LENGTH) {
+        issues.push(error('endpointId', `exceeds ${MAX_ENDPOINT_ID_LENGTH} chars`));
+    }
+    else if (!/^[\w#;:!@"$%&'()*+,\-./>=<?[\\\]^`{|}~ ]+$/.test(ep.endpointId)) {
+        issues.push(error('endpointId', 'contains invalid characters'));
+    }
+    else if (seenIds.has(ep.endpointId)) {
+        issues.push(error('endpointId', 'duplicate'));
+    }
+    seenIds.add(ep.endpointId);
+    // --- friendlyName ---
+    if (!ep.friendlyName || !ep.friendlyName.trim()) {
+        issues.push(error('friendlyName', 'missing or empty'));
+    }
+    else if (ep.friendlyName.length > MAX_FRIENDLY_NAME_LENGTH) {
+        issues.push(error('friendlyName', `exceeds ${MAX_FRIENDLY_NAME_LENGTH} chars`));
+    }
+    else {
+        // Alexa rejects names that are only digits
+        if (/^\d+$/.test(ep.friendlyName.trim())) {
+            issues.push(error('friendlyName', 'must not be only digits'));
+        }
+        // Wake words as device name make the device unusable
+        const lower = ep.friendlyName.toLowerCase().trim();
+        if (WAKE_WORDS.includes(lower)) {
+            issues.push(warning('friendlyName', `"${ep.friendlyName}" is an Alexa wake word — device may not be controllable`));
+        }
+        // Duplicate names confuse Alexa ("which one did you mean?")
+        if (seenNames.has(lower)) {
+            issues.push(warning('friendlyName', 'duplicate name — Alexa will ask "which one did you mean?"'));
+        }
+        seenNames.add(lower);
+    }
+    // --- description ---
+    if (ep.description && ep.description.length > MAX_DESCRIPTION_LENGTH) {
+        issues.push(warning('description', `exceeds ${MAX_DESCRIPTION_LENGTH} chars, will be truncated`));
+    }
+    // --- manufacturerName ---
+    if (ep.manufacturerName && ep.manufacturerName.length > MAX_MANUFACTURER_NAME_LENGTH) {
+        issues.push(warning('manufacturerName', `exceeds ${MAX_MANUFACTURER_NAME_LENGTH} chars`));
+    }
+    // --- displayCategories ---
+    if (!ep.displayCategories || !ep.displayCategories.length) {
+        issues.push(error('displayCategories', 'missing or empty'));
+    }
+    else {
+        for (const cat of ep.displayCategories) {
+            if (!VALID_DISPLAY_CATEGORIES.has(cat)) {
+                issues.push(error('displayCategories', `unknown category "${cat}"`));
+            }
+        }
+    }
+    // --- capabilities ---
+    if (!ep.capabilities || !ep.capabilities.length) {
+        issues.push(error('capabilities', 'missing or empty'));
+    }
+    else {
+        if (ep.capabilities.length > MAX_CAPABILITIES_PER_ENDPOINT) {
+            issues.push(error('capabilities', `exceeds ${MAX_CAPABILITIES_PER_ENDPOINT} capabilities`));
+        }
+        // Alexa interface is required on every endpoint
+        const hasAlexa = ep.capabilities.some(c => c.interface === 'Alexa');
+        if (!hasAlexa) {
+            issues.push(error('capabilities', 'missing required Alexa interface'));
+        }
+        // Check for duplicate capabilities (same interface+instance)
+        const capKeys = new Set();
+        for (const cap of ep.capabilities) {
+            const capKey = `${cap.interface || ''}::${cap.instance || ''}`;
+            if (cap.interface !== 'Alexa' && capKeys.has(capKey)) {
+                issues.push(error('capabilities', `duplicate capability ${cap.interface}${cap.instance ? ` (${cap.instance})` : ''}`));
+            }
+            capKeys.add(capKey);
+            // Validate individual capability
+            if (cap.interface && !VALID_NAMESPACES.has(cap.interface)) {
+                issues.push(warning('capabilities', `unknown interface "${cap.interface}"`));
+            }
+            if (cap.version && cap.version !== '3' && cap.version !== '3.2') {
+                issues.push(error('capabilities', `unexpected version "${cap.version}" for ${cap.interface}`));
+            }
+            // ModeController and RangeController require instance
+            if (cap.interface && REQUIRES_INSTANCE.has(cap.interface) && !cap.instance) {
+                issues.push(error('capabilities', `${cap.interface} requires an instance property`));
+            }
+            // properties.supported must not be empty if defined
+            if (cap.properties && Array.isArray(cap.properties.supported) && cap.properties.supported.length === 0) {
+                issues.push(warning('capabilities', `${cap.interface} has empty properties.supported array`));
+            }
+        }
+    }
+    return issues;
+}
+//# sourceMappingURL=DiscoveryValidator.js.map

package/build/lib/AlexaSmartHomeV3/Helpers/DiscoveryValidator.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"DiscoveryValidator.js","sourceRoot":"","sources":["../../../../src/lib/AlexaSmartHomeV3/Helpers/DiscoveryValidator.ts"],"names":[],"mappings":";;AAqIA,8DAiFC;AAnND,+FAA+F;AAC/F,MAAM,aAAa,GAAG,GAAG,CAAC;AAC1B,MAAM,sBAAsB,GAAG,GAAG,CAAC;AACnC,MAAM,wBAAwB,GAAG,GAAG,CAAC;AACrC,MAAM,sBAAsB,GAAG,GAAG,CAAC;AACnC,MAAM,4BAA4B,GAAG,GAAG,CAAC;AACzC,MAAM,6BAA6B,GAAG,GAAG,CAAC;AAE1C,0DAA0D;AAC1D,MAAM,uBAAuB,GAAG,GAAG,GAAG,IAAI,CAAC;AAC3C,MAAM,2BAA2B,GAAG,GAAG,GAAG,IAAI,CAAC;AAE/C,oGAAoG;AACpG,MAAM,wBAAwB,GAAG,IAAI,GAAG,CAAC;IACrC,kBAAkB;IAClB,iBAAiB;IACjB,eAAe;IACf,cAAc;IACd,qBAAqB;IACrB,qBAAqB;IACrB,gBAAgB;IAChB,mBAAmB;IACnB,QAAQ;IACR,gBAAgB;IAChB,cAAc;IACd,UAAU;IACV,gBAAgB;IAChB,YAAY;IACZ,MAAM;IACN,UAAU;IACV,OAAO;IACP,gBAAgB;IAChB,KAAK;IACL,cAAc;IACd,aAAa;IACb,YAAY;IACZ,KAAK;IACL,gBAAgB;IAChB,QAAQ;IACR,OAAO;IACP,WAAW;IACX,cAAc;IACd,eAAe;IACf,cAAc;IACd,kBAAkB;IAClB,OAAO;IACP,MAAM;IACN,OAAO;IACP,SAAS;IACT,QAAQ;IACR,QAAQ;IACR,eAAe;IACf,QAAQ;IACR,gBAAgB;IAChB,iBAAiB;IACjB,aAAa;IACb,WAAW;IACX,WAAW;IACX,SAAS;IACT,kBAAkB;IAClB,QAAQ;IACR,QAAQ;IACR,oBAAoB;IACpB,YAAY;IACZ,IAAI;IACJ,gBAAgB;IAChB,QAAQ;IACR,SAAS;IACT,QAAQ;IACR,cAAc;IACd,UAAU;CACb,CAAC,CAAC;AAEH,MAAM,gBAAgB,GAAG,IAAI,GAAG,CAAC;IAC7B,OAAO;IACP,4BAA4B;IAC5B,uBAAuB;IACvB,kCAAkC;IAClC,qBAAqB;IACrB,sBAAsB;IACtB,sBAAsB;IACtB,sBAAsB;IACtB,sBAAsB;IACtB,oBAAoB;IACpB,4BAA4B;IAC5B,uBAAuB;IACvB,uBAAuB;IACvB,uBAAuB;IACvB,eAAe;IACf,yBAAyB;IACzB,4BAA4B;CAC/B,CAAC,CAAC;AAEH,gEAAgE;AAChE,MAAM,iBAAiB,GAAG,IAAI,GAAG,CAAC,CAAC,sBAAsB,EAAE,uBAAuB,EAAE,wBAAwB,CAAC,CAAC,CAAC;AAE/G,iEAAiE;AACjE,MAAM,UAAU,GAAG,CAAC,OAAO,EAAE,MAAM,EAAE,QAAQ,EAAE,UAAU,EAAE,OAAO,CAAC,CAAC;AA6BpE;;;GAGG;AACH,SAAgB,yBAAyB,CAAC,QAAuB,EAAE,GAAW;IAC1E,qCAAqC;IACrC,MAAM,MAAM,GAAG,QAAQ,EAAE,KAAK,EAAE,MAAM,CAAC;IACvC,IAAI,CAAC,MAAM,EAAE,CAAC;QACV,GAAG,CAAC,KAAK,CAAC,yCAAyC,CAAC,CAAC;QACrD,OAAO,QAAQ,CAAC;IACpB,CAAC;IACD,mBAAmB;IACnB,IAAI,MAAM,CAAC,SAAS,KAAK,iBAAiB,EAAE,CAAC;QACzC,GAAG,CAAC,KAAK,CAAC,oCAAoC,MAAM,CAAC,SAAS,+BAA+B,CAAC,CAAC;IACnG,CAAC;IACD,IAAI,MAAM,CAAC,IAAI,KAAK,mBAAmB,EAAE,CAAC;QACtC,GAAG,CAAC,KAAK,CAAC,+BAA+B,MAAM,CAAC,IAAI,iCAAiC,CAAC,CAAC;IAC3F,CAAC;IACD,IAAI,MAAM,CAAC,cAAc,KAAK,GAAG,EAAE,CAAC;QAChC,GAAG,CAAC,KAAK,CAAC,yCAAyC,MAAM,CAAC,cAAmC,iBAAiB,CAAC,CAAC;IACpH,CAAC;IAED,MAAM,SAAS,GAAoC,QAAQ,EAAE,KAAK,EAAE,OAAO,EAAE,SAAS,CAAC;IACvF,IAAI,CAAC,SAAS,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,SAAS,CAAC,EAAE,CAAC;QAC1C,OAAO,QAAQ,CAAC;IACpB,CAAC;IAED,MAAM,MAAM,GAAsB,EAAE,CAAC;IACrC,MAAM,QAAQ,GAAsB,EAAE,CAAC;IACvC,MAAM,OAAO,GAAG,IAAI,GAAG,EAAU,CAAC;IAClC,MAAM,SAAS,GAAG,IAAI,GAAG,EAAU,CAAC;IAEpC,sEAAsE;IACtE,KAAK,IAAI,CAAC,GAAG,SAAS,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC;QAC7C,MAAM,EAAE,GAAG,SAAS,CAAC,CAAC,CAAC,CAAC;QACxB,MAAM,QAAQ,GAAG,gBAAgB,CAAC,EAAE,EAAE,OAAO,EAAE,SAAS,CAAC,CAAC;QAC1D,MAAM,QAAQ,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,OAAO,CAAC,CAAC;QAC9D,MAAM,UAAU,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,SAAS,CAAC,CAAC;QAClE,QAAQ,CAAC,IAAI,CAAC,GAAG,UAAU,CAAC,CAAC;QAC7B,IAAI,QAAQ,CAAC,MAAM,EAAE,CAAC;YAClB,MAAM,CAAC,IAAI,CAAC,GAAG,QAAQ,CAAC,CAAC;YACzB,SAAS,CAAC,MAAM,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;QAC3B,CAAC;IACL,CAAC;IAED,6BAA6B;IAC7B,IAAI,SAAS,CAAC,MAAM,GAAG,aAAa,EAAE,CAAC;QACnC,GAAG,CAAC,IAAI,CAAC,cAAc,SAAS,CAAC,MAAM,qCAAqC,aAAa,cAAc,CAAC,CAAC;QACzG,SAAS,CAAC,MAAM,GAAG,aAAa,CAAC;IACrC,CAAC;IAED,uDAAuD;IACvD,MAAM,YAAY,GAAG,IAAI,CAAC,SAAS,CAAC,QAAQ,CAAC,CAAC,MAAM,CAAC;IACrD,IAAI,YAAY,GAAG,uBAAuB,EAAE,CAAC;QACzC,MAAM,aAAa,GAAG,SAAS,CAAC,MAAM,CAAC;QACvC,OAAO,SAAS,CAAC,MAAM,GAAG,CAAC,IAAI,IAAI,CAAC,SAAS,CAAC,QAAQ,CAAC,CAAC,MAAM,GAAG,uBAAuB,EAAE,CAAC;YACvF,MAAM,OAAO,GAAG,SAAS,CAAC,GAAG,EAAG,CAAC;YACjC,GAAG,CAAC,IAAI,CAAC,uBAAuB,OAAO,CAAC,YAAY,qCAAqC,CAAC,CAAC;QAC/F,CAAC;QACD,GAAG,CAAC,IAAI,CACJ,2BAA2B,IAAI,CAAC,KAAK,CAAC,YAAY,GAAG,IAAI,CAAC,eAAe,IAAI,CAAC,KAAK,CAAC,uBAAuB,GAAG,IAAI,CAAC,sBAAsB,aAAa,OAAO,SAAS,CAAC,MAAM,YAAY,CAC5L,CAAC;IACN,CAAC;SAAM,IAAI,YAAY,GAAG,2BAA2B,EAAE,CAAC;QACpD,GAAG,CAAC,IAAI,CACJ,0BAA0B,IAAI,CAAC,KAAK,CAAC,YAAY,GAAG,IAAI,CAAC,YAAY,SAAS,CAAC,MAAM,6CAA6C,IAAI,CAAC,KAAK,CAAC,uBAAuB,GAAG,IAAI,CAAC,KAAK,CACpL,CAAC;IACN,CAAC;IAED,2BAA2B;IAC3B,KAAK,MAAM,CAAC,IAAI,QAAQ,EAAE,CAAC;QACvB,GAAG,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC,YAAY,MAAM,CAAC,CAAC,UAAU,MAAM,CAAC,CAAC,KAAK,MAAM,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC;IAC5F,CAAC;IAED,oCAAoC;IACpC,KAAK,MAAM,GAAG,IAAI,MAAM,EAAE,CAAC;QACvB,GAAG,CAAC,IAAI,CAAC,uBAAuB,GAAG,CAAC,YAAY,MAAM,GAAG,CAAC,UAAU,MAAM,GAAG,CAAC,KAAK,MAAM,GAAG,CAAC,OAAO,EAAE,CAAC,CAAC;IAC5G,CAAC;IAED,IAAI,MAAM,CAAC,MAAM,IAAI,QAAQ,CAAC,MAAM,EAAE,CAAC;QACnC,GAAG,CAAC,IAAI,CACJ,cAAc,SAAS,CAAC,MAAM,uBAAuB,MAAM,CAAC,MAAM,aAAa,QAAQ,CAAC,MAAM,aAAa,CAC9G,CAAC;IACN,CAAC;IAED,OAAO,QAAQ,CAAC;AACpB,CAAC;AAED,SAAS,gBAAgB,CAAC,EAAqB,EAAE,OAAoB,EAAE,SAAsB;IACzF,MAAM,MAAM,GAAsB,EAAE,CAAC;IACrC,MAAM,EAAE,GAAG,EAAE,CAAC,UAAU,IAAI,SAAS,CAAC;IACtC,MAAM,IAAI,GAAG,EAAE,CAAC,YAAY,IAAI,SAAS,CAAC;IAE1C,MAAM,KAAK,GAAG,CAAC,KAAa,EAAE,OAAe,EAAmB,EAAE,CAAC,CAAC;QAChE,UAAU,EAAE,EAAE;QACd,YAAY,EAAE,IAAI;QAClB,KAAK;QACL,OAAO;QACP,QAAQ,EAAE,OAAO;KACpB,CAAC,CAAC;IACH,MAAM,OAAO,GAAG,CAAC,KAAa,EAAE,OAAe,EAAmB,EAAE,CAAC,CAAC;QAClE,UAAU,EAAE,EAAE;QACd,YAAY,EAAE,IAAI;QAClB,KAAK;QACL,OAAO;QACP,QAAQ,EAAE,SAAS;KACtB,CAAC,CAAC;IAEH,qBAAqB;IACrB,IAAI,CAAC,EAAE,CAAC,UAAU,EAAE,CAAC;QACjB,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,YAAY,EAAE,SAAS,CAAC,CAAC,CAAC;IAChD,CAAC;SAAM,IAAI,EAAE,CAAC,UAAU,CAAC,MAAM,GAAG,sBAAsB,EAAE,CAAC;QACvD,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,YAAY,EAAE,WAAW,sBAAsB,QAAQ,CAAC,CAAC,CAAC;IAChF,CAAC;SAAM,IAAI,CAAC,4CAA4C,CAAC,IAAI,CAAC,EAAE,CAAC,UAAU,CAAC,EAAE,CAAC;QAC3E,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,YAAY,EAAE,6BAA6B,CAAC,CAAC,CAAC;IACpE,CAAC;SAAM,IAAI,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,UAAU,CAAC,EAAE,CAAC;QACpC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,YAAY,EAAE,WAAW,CAAC,CAAC,CAAC;IAClD,CAAC;IACD,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC,UAAU,CAAC,CAAC;IAE3B,uBAAuB;IACvB,IAAI,CAAC,EAAE,CAAC,YAAY,IAAI,CAAC,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,EAAE,CAAC;QAC9C,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,cAAc,EAAE,kBAAkB,CAAC,CAAC,CAAC;IAC3D,CAAC;SAAM,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,GAAG,wBAAwB,EAAE,CAAC;QAC3D,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,cAAc,EAAE,WAAW,wBAAwB,QAAQ,CAAC,CAAC,CAAC;IACpF,CAAC;SAAM,CAAC;QACJ,2CAA2C;QAC3C,IAAI,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC,YAAY,CAAC,IAAI,EAAE,CAAC,EAAE,CAAC;YACvC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,cAAc,EAAE,yBAAyB,CAAC,CAAC,CAAC;QAClE,CAAC;QAED,qDAAqD;QACrD,MAAM,KAAK,GAAG,EAAE,CAAC,YAAY,CAAC,WAAW,EAAE,CAAC,IAAI,EAAE,CAAC;QACnD,IAAI,UAAU,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CACP,OAAO,CAAC,cAAc,EAAE,IAAI,EAAE,CAAC,YAAY,0DAA0D,CAAC,CACzG,CAAC;QACN,CAAC;QAED,4DAA4D;QAC5D,IAAI,SAAS,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC;YACvB,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,cAAc,EAAE,2DAA2D,CAAC,CAAC,CAAC;QACtG,CAAC;QACD,SAAS,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;IACzB,CAAC;IAED,sBAAsB;IACtB,IAAI,EAAE,CAAC,WAAW,IAAI,EAAE,CAAC,WAAW,CAAC,MAAM,GAAG,sBAAsB,EAAE,CAAC;QACnE,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,aAAa,EAAE,WAAW,sBAAsB,2BAA2B,CAAC,CAAC,CAAC;IACtG,CAAC;IAED,2BAA2B;IAC3B,IAAI,EAAE,CAAC,gBAAgB,IAAI,EAAE,CAAC,gBAAgB,CAAC,MAAM,GAAG,4BAA4B,EAAE,CAAC;QACnF,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,kBAAkB,EAAE,WAAW,4BAA4B,QAAQ,CAAC,CAAC,CAAC;IAC9F,CAAC;IAED,4BAA4B;IAC5B,IAAI,CAAC,EAAE,CAAC,iBAAiB,IAAI,CAAC,EAAE,CAAC,iBAAiB,CAAC,MAAM,EAAE,CAAC;QACxD,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,mBAAmB,EAAE,kBAAkB,CAAC,CAAC,CAAC;IAChE,CAAC;SAAM,CAAC;QACJ,KAAK,MAAM,GAAG,IAAI,EAAE,CAAC,iBAAiB,EAAE,CAAC;YACrC,IAAI,CAAC,wBAAwB,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;gBACrC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,mBAAmB,EAAE,qBAAqB,GAAG,GAAG,CAAC,CAAC,CAAC;YACzE,CAAC;QACL,CAAC;IACL,CAAC;IAED,uBAAuB;IACvB,IAAI,CAAC,EAAE,CAAC,YAAY,IAAI,CAAC,EAAE,CAAC,YAAY,CAAC,MAAM,EAAE,CAAC;QAC9C,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,cAAc,EAAE,kBAAkB,CAAC,CAAC,CAAC;IAC3D,CAAC;SAAM,CAAC;QACJ,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,GAAG,6BAA6B,EAAE,CAAC;YACzD,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,cAAc,EAAE,WAAW,6BAA6B,eAAe,CAAC,CAAC,CAAC;QAChG,CAAC;QAED,gDAAgD;QAChD,MAAM,QAAQ,GAAG,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,SAAS,KAAK,OAAO,CAAC,CAAC;QACpE,IAAI,CAAC,QAAQ,EAAE,CAAC;YACZ,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,cAAc,EAAE,kCAAkC,CAAC,CAAC,CAAC;QAC3E,CAAC;QAED,6DAA6D;QAC7D,MAAM,OAAO,GAAG,IAAI,GAAG,EAAU,CAAC;QAClC,KAAK,MAAM,GAAG,IAAI,EAAE,CAAC,YAAY,EAAE,CAAC;YAChC,MAAM,MAAM,GAAG,GAAG,GAAG,CAAC,SAAS,IAAI,EAAE,KAAK,GAAG,CAAC,QAAQ,IAAI,EAAE,EAAE,CAAC;YAC/D,IAAI,GAAG,CAAC,SAAS,KAAK,OAAO,IAAI,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC;gBACnD,MAAM,CAAC,IAAI,CACP,KAAK,CACD,cAAc,EACd,wBAAwB,GAAG,CAAC,SAAS,GAAG,GAAG,CAAC,QAAQ,CAAC,CAAC,CAAC,KAAK,GAAG,CAAC,QAAQ,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CACrF,CACJ,CAAC;YACN,CAAC;YACD,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;YAEpB,iCAAiC;YACjC,IAAI,GAAG,CAAC,SAAS,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,GAAG,CAAC,SAAS,CAAC,EAAE,CAAC;gBACxD,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,cAAc,EAAE,sBAAsB,GAAG,CAAC,SAAS,GAAG,CAAC,CAAC,CAAC;YACjF,CAAC;YAED,IAAI,GAAG,CAAC,OAAO,IAAI,GAAG,CAAC,OAAO,KAAK,GAAG,IAAI,GAAG,CAAC,OAAO,KAAK,KAAK,EAAE,CAAC;gBAC9D,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,cAAc,EAAE,uBAAuB,GAAG,CAAC,OAAO,SAAS,GAAG,CAAC,SAAS,EAAE,CAAC,CAAC,CAAC;YACnG,CAAC;YAED,sDAAsD;YACtD,IAAI,GAAG,CAAC,SAAS,IAAI,iBAAiB,CAAC,GAAG,CAAC,GAAG,CAAC,SAAS,CAAC,IAAI,CAAC,GAAG,CAAC,QAAQ,EAAE,CAAC;gBACzE,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,cAAc,EAAE,GAAG,GAAG,CAAC,SAAS,gCAAgC,CAAC,CAAC,CAAC;YACzF,CAAC;YAED,oDAAoD;YACpD,IAAI,GAAG,CAAC,UAAU,IAAI,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,UAAU,CAAC,SAAS,CAAC,IAAI,GAAG,CAAC,UAAU,CAAC,SAAS,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;gBACrG,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,cAAc,EAAE,GAAG,GAAG,CAAC,SAAS,uCAAuC,CAAC,CAAC,CAAC;YAClG,CAAC;QACL,CAAC;IACL,CAAC;IAED,OAAO,MAAM,CAAC;AAClB,CAAC","sourcesContent":["import type Logger from './Logger';\nimport type AlexaResponse from '../Alexa/AlexaResponse';\n\n// Alexa limits: https://developer.amazon.com/en-US/docs/alexa/device-apis/alexa-discovery.html\nconst MAX_ENDPOINTS = 300;\nconst MAX_ENDPOINT_ID_LENGTH = 256;\nconst MAX_FRIENDLY_NAME_LENGTH = 128;\nconst MAX_DESCRIPTION_LENGTH = 128;\nconst MAX_MANUFACTURER_NAME_LENGTH = 128;\nconst MAX_CAPABILITIES_PER_ENDPOINT = 100;\n\n// AWS IoT MQTT message size limit (128 KB minus overhead)\nconst MAX_RESPONSE_SIZE_BYTES = 127 * 1024;\nconst RESPONSE_SIZE_WARNING_BYTES = 100 * 1024;\n\n// https://developer.amazon.com/en-US/docs/alexa/device-apis/alexa-discovery.html#display-categories\nconst VALID_DISPLAY_CATEGORIES = new Set([\n    'ACTIVITY_TRIGGER',\n    'AIR_CONDITIONER',\n    'AIR_FRESHENER',\n    'AIR_PURIFIER',\n    'AIR_QUALITY_MONITOR',\n    'ALEXA_VOICE_ENABLED',\n    'AUTO_ACCESSORY',\n    'BLUETOOTH_SPEAKER',\n    'CAMERA',\n    'CHRISTMAS_TREE',\n    'COFFEE_MAKER',\n    'COMPUTER',\n    'CONTACT_SENSOR',\n    'DISHWASHER',\n    'DOOR',\n    'DOORBELL',\n    'DRYER',\n    'EXTERIOR_BLIND',\n    'FAN',\n    'GAME_CONSOLE',\n    'GARAGE_DOOR',\n    'HEADPHONES',\n    'HUB',\n    'INTERIOR_BLIND',\n    'LAPTOP',\n    'LIGHT',\n    'MICROWAVE',\n    'MOBILE_PHONE',\n    'MOTION_SENSOR',\n    'MUSIC_SYSTEM',\n    'NETWORK_HARDWARE',\n    'OTHER',\n    'OVEN',\n    'PHONE',\n    'PRINTER',\n    'REMOTE',\n    'ROUTER',\n    'SCENE_TRIGGER',\n    'SCREEN',\n    'SECURITY_PANEL',\n    'SECURITY_SYSTEM',\n    'SLOW_COOKER',\n    'SMARTLOCK',\n    'SMARTPLUG',\n    'SPEAKER',\n    'STREAMING_DEVICE',\n    'SWITCH',\n    'TABLET',\n    'TEMPERATURE_SENSOR',\n    'THERMOSTAT',\n    'TV',\n    'VACUUM_CLEANER',\n    'VACUUM',\n    'VEHICLE',\n    'WASHER',\n    'WATER_HEATER',\n    'WEARABLE',\n]);\n\nconst VALID_NAMESPACES = new Set([\n    'Alexa',\n    'Alexa.BrightnessController',\n    'Alexa.ColorController',\n    'Alexa.ColorTemperatureController',\n    'Alexa.ContactSensor',\n    'Alexa.EndpointHealth',\n    'Alexa.HumiditySensor',\n    'Alexa.LockController',\n    'Alexa.ModeController',\n    'Alexa.MotionSensor',\n    'Alexa.PercentageController',\n    'Alexa.PowerController',\n    'Alexa.RangeController',\n    'Alexa.SceneController',\n    'Alexa.Speaker',\n    'Alexa.TemperatureSensor',\n    'Alexa.ThermostatController',\n]);\n\n// Multi-instance capabilities that require an instance property\nconst REQUIRES_INSTANCE = new Set(['Alexa.ModeController', 'Alexa.RangeController', 'Alexa.ToggleController']);\n\n// Alexa wake words — devices named like this can't be controlled\nconst WAKE_WORDS = ['alexa', 'echo', 'amazon', 'computer', 'ziggy'];\n\ninterface DiscoveryEndpoint {\n    endpointId: string;\n    friendlyName: string;\n    description?: string;\n    manufacturerName?: string;\n    displayCategories?: string[];\n    capabilities?: DiscoveryCapability[];\n}\n\ninterface DiscoveryCapability {\n    type?: string;\n    interface?: string;\n    instance?: string;\n    version?: string;\n    properties?: {\n        supported?: { name: string }[];\n    };\n}\n\nexport interface ValidationError {\n    endpointId: string;\n    friendlyName: string;\n    field: string;\n    message: string;\n    severity: 'error' | 'warning';\n}\n\n/**\n * Validates the Alexa Discovery response and removes invalid endpoints.\n * Returns the sanitized response.\n */\nexport function validateDiscoveryResponse(response: AlexaResponse, log: Logger): AlexaResponse {\n    // Validate response header structure\n    const header = response?.event?.header;\n    if (!header) {\n        log.error('Discovery: response has no event.header');\n        return response;\n    }\n    // @ts-expect-error\n    if (header.namespace !== 'Alexa.Discovery') {\n        log.error(`Discovery: unexpected namespace \"${header.namespace}\", expected \"Alexa.Discovery\"`);\n    }\n    if (header.name !== 'Discover.Response') {\n        log.error(`Discovery: unexpected name \"${header.name}\", expected \"Discover.Response\"`);\n    }\n    if (header.payloadVersion !== '3') {\n        log.error(`Discovery: unexpected payloadVersion \"${header.payloadVersion as unknown as string}\", expected \"3\"`);\n    }\n\n    const endpoints: DiscoveryEndpoint[] | undefined = response?.event?.payload?.endpoints;\n    if (!endpoints || !Array.isArray(endpoints)) {\n        return response;\n    }\n\n    const errors: ValidationError[] = [];\n    const warnings: ValidationError[] = [];\n    const seenIds = new Set<string>();\n    const seenNames = new Set<string>();\n\n    // Validate and filter endpoints in place (backwards to safely splice)\n    for (let i = endpoints.length - 1; i >= 0; i--) {\n        const ep = endpoints[i];\n        const epIssues = validateEndpoint(ep, seenIds, seenNames);\n        const epErrors = epIssues.filter(e => e.severity === 'error');\n        const epWarnings = epIssues.filter(e => e.severity === 'warning');\n        warnings.push(...epWarnings);\n        if (epErrors.length) {\n            errors.push(...epErrors);\n            endpoints.splice(i, 1);\n        }\n    }\n\n    // Enforce 300 endpoint limit\n    if (endpoints.length > MAX_ENDPOINTS) {\n        log.warn(`Discovery: ${endpoints.length} endpoints exceeds Alexa limit of ${MAX_ENDPOINTS}, truncating`);\n        endpoints.length = MAX_ENDPOINTS;\n    }\n\n    // Check total response size against AWS IoT MQTT limit\n    const responseSize = JSON.stringify(response).length;\n    if (responseSize > MAX_RESPONSE_SIZE_BYTES) {\n        const originalCount = endpoints.length;\n        while (endpoints.length > 1 && JSON.stringify(response).length > MAX_RESPONSE_SIZE_BYTES) {\n            const removed = endpoints.pop()!;\n            log.warn(`Discovery: removed \"${removed.friendlyName}\" to fit AWS IoT message size limit`);\n        }\n        log.warn(\n            `Discovery: response was ${Math.round(responseSize / 1024)} KB (limit: ${Math.round(MAX_RESPONSE_SIZE_BYTES / 1024)} KB), reduced from ${originalCount} to ${endpoints.length} endpoints`,\n        );\n    } else if (responseSize > RESPONSE_SIZE_WARNING_BYTES) {\n        log.warn(\n            `Discovery: response is ${Math.round(responseSize / 1024)} KB with ${endpoints.length} endpoints — approaching AWS IoT limit of ${Math.round(MAX_RESPONSE_SIZE_BYTES / 1024)} KB`,\n        );\n    }\n\n    // Log warnings (non-fatal)\n    for (const w of warnings) {\n        log.warn(`Discovery: \"${w.friendlyName}\" (${w.endpointId}): ${w.field} — ${w.message}`);\n    }\n\n    // Log errors (endpoint was removed)\n    for (const err of errors) {\n        log.warn(`Discovery: removed \"${err.friendlyName}\" (${err.endpointId}): ${err.field} — ${err.message}`);\n    }\n\n    if (errors.length || warnings.length) {\n        log.info(\n            `Discovery: ${endpoints.length} endpoint(s) valid, ${errors.length} removed, ${warnings.length} warning(s)`,\n        );\n    }\n\n    return response;\n}\n\nfunction validateEndpoint(ep: DiscoveryEndpoint, seenIds: Set<string>, seenNames: Set<string>): ValidationError[] {\n    const issues: ValidationError[] = [];\n    const id = ep.endpointId || '(empty)';\n    const name = ep.friendlyName || '(empty)';\n\n    const error = (field: string, message: string): ValidationError => ({\n        endpointId: id,\n        friendlyName: name,\n        field,\n        message,\n        severity: 'error',\n    });\n    const warning = (field: string, message: string): ValidationError => ({\n        endpointId: id,\n        friendlyName: name,\n        field,\n        message,\n        severity: 'warning',\n    });\n\n    // --- endpointId ---\n    if (!ep.endpointId) {\n        issues.push(error('endpointId', 'missing'));\n    } else if (ep.endpointId.length > MAX_ENDPOINT_ID_LENGTH) {\n        issues.push(error('endpointId', `exceeds ${MAX_ENDPOINT_ID_LENGTH} chars`));\n    } else if (!/^[\\w#;:!@\"$%&'()*+,\\-./>=<?[\\\\\\]^`{|}~ ]+$/.test(ep.endpointId)) {\n        issues.push(error('endpointId', 'contains invalid characters'));\n    } else if (seenIds.has(ep.endpointId)) {\n        issues.push(error('endpointId', 'duplicate'));\n    }\n    seenIds.add(ep.endpointId);\n\n    // --- friendlyName ---\n    if (!ep.friendlyName || !ep.friendlyName.trim()) {\n        issues.push(error('friendlyName', 'missing or empty'));\n    } else if (ep.friendlyName.length > MAX_FRIENDLY_NAME_LENGTH) {\n        issues.push(error('friendlyName', `exceeds ${MAX_FRIENDLY_NAME_LENGTH} chars`));\n    } else {\n        // Alexa rejects names that are only digits\n        if (/^\\d+$/.test(ep.friendlyName.trim())) {\n            issues.push(error('friendlyName', 'must not be only digits'));\n        }\n\n        // Wake words as device name make the device unusable\n        const lower = ep.friendlyName.toLowerCase().trim();\n        if (WAKE_WORDS.includes(lower)) {\n            issues.push(\n                warning('friendlyName', `\"${ep.friendlyName}\" is an Alexa wake word — device may not be controllable`),\n            );\n        }\n\n        // Duplicate names confuse Alexa (\"which one did you mean?\")\n        if (seenNames.has(lower)) {\n            issues.push(warning('friendlyName', 'duplicate name — Alexa will ask \"which one did you mean?\"'));\n        }\n        seenNames.add(lower);\n    }\n\n    // --- description ---\n    if (ep.description && ep.description.length > MAX_DESCRIPTION_LENGTH) {\n        issues.push(warning('description', `exceeds ${MAX_DESCRIPTION_LENGTH} chars, will be truncated`));\n    }\n\n    // --- manufacturerName ---\n    if (ep.manufacturerName && ep.manufacturerName.length > MAX_MANUFACTURER_NAME_LENGTH) {\n        issues.push(warning('manufacturerName', `exceeds ${MAX_MANUFACTURER_NAME_LENGTH} chars`));\n    }\n\n    // --- displayCategories ---\n    if (!ep.displayCategories || !ep.displayCategories.length) {\n        issues.push(error('displayCategories', 'missing or empty'));\n    } else {\n        for (const cat of ep.displayCategories) {\n            if (!VALID_DISPLAY_CATEGORIES.has(cat)) {\n                issues.push(error('displayCategories', `unknown category \"${cat}\"`));\n            }\n        }\n    }\n\n    // --- capabilities ---\n    if (!ep.capabilities || !ep.capabilities.length) {\n        issues.push(error('capabilities', 'missing or empty'));\n    } else {\n        if (ep.capabilities.length > MAX_CAPABILITIES_PER_ENDPOINT) {\n            issues.push(error('capabilities', `exceeds ${MAX_CAPABILITIES_PER_ENDPOINT} capabilities`));\n        }\n\n        // Alexa interface is required on every endpoint\n        const hasAlexa = ep.capabilities.some(c => c.interface === 'Alexa');\n        if (!hasAlexa) {\n            issues.push(error('capabilities', 'missing required Alexa interface'));\n        }\n\n        // Check for duplicate capabilities (same interface+instance)\n        const capKeys = new Set<string>();\n        for (const cap of ep.capabilities) {\n            const capKey = `${cap.interface || ''}::${cap.instance || ''}`;\n            if (cap.interface !== 'Alexa' && capKeys.has(capKey)) {\n                issues.push(\n                    error(\n                        'capabilities',\n                        `duplicate capability ${cap.interface}${cap.instance ? ` (${cap.instance})` : ''}`,\n                    ),\n                );\n            }\n            capKeys.add(capKey);\n\n            // Validate individual capability\n            if (cap.interface && !VALID_NAMESPACES.has(cap.interface)) {\n                issues.push(warning('capabilities', `unknown interface \"${cap.interface}\"`));\n            }\n\n            if (cap.version && cap.version !== '3' && cap.version !== '3.2') {\n                issues.push(error('capabilities', `unexpected version \"${cap.version}\" for ${cap.interface}`));\n            }\n\n            // ModeController and RangeController require instance\n            if (cap.interface && REQUIRES_INSTANCE.has(cap.interface) && !cap.instance) {\n                issues.push(error('capabilities', `${cap.interface} requires an instance property`));\n            }\n\n            // properties.supported must not be empty if defined\n            if (cap.properties && Array.isArray(cap.properties.supported) && cap.properties.supported.length === 0) {\n                issues.push(warning('capabilities', `${cap.interface} has empty properties.supported array`));\n            }\n        }\n    }\n\n    return issues;\n}\n"]}

package/build/lib/AlexaSmartHomeV3/Helpers/Utils.js

@@ -991,6 +991,10 @@ function hal2rgbw(hal) {
             g = 0;
             b = 0;
     }
+    // Extract the common white component (min of R,G,B = p) into the dedicated white channel
+    // const w = p;
+    // return `#${toHex(to255(r - w))}${toHex(to255(g - w))}${toHex(to255(b - w))}${toHex(to255(w))}`;
+    // Simple calculations
     return `#${toHex(to255(r))}${toHex(to255(g))}${toHex(to255(b))}${toHex(to255(255))}`;
 }
 /**