iobroker.iot 3.4.3 → 3.4.5

package/io-package.json

@@ -1,8 +1,34 @@
 {
   "common": {
     "name": "iot",
-    "version": "3.4.3",
+    "version": "3.4.5",
     "news": {
+      "3.4.5": {
+        "en": "Checked the max length of discovered devices for Alexa",
+        "de": "Überprüfte die maximale Länge der entdeckten Geräte für Alexa",
+        "ru": "Проверка максимальной длины обнаруженных устройств для Alexa",
+        "pt": "Verificado o comprimento máximo de dispositivos descobertos para Alexa",
+        "nl": "De maximale lengte van ontdekte apparaten voor Alexa gecontroleerd",
+        "fr": "Vérification de la longueur maximale des appareils découverts pour Alexa",
+        "it": "Controllata la lunghezza massima di dispositivi scoperti per Alexa",
+        "es": "Compruebe la longitud máxima de los dispositivos descubiertos para Alexa",
+        "pl": "Sprawdziliśmy maksymalną długość odkrytych urządzeń dla Alexa",
+        "uk": "Перевірити максимальну довжину відкритих пристроїв для Alexa",
+        "zh-cn": "为 Alexa 检查了已发现设备的最大长度"
+      },
+      "3.4.4": {
+        "en": "Corrected the name editing of the devices for Alexa 3",
+        "de": "Korrektur der Namensbearbeitung der Geräte für Alexa 3",
+        "ru": "Исправлено редактирование названия устройств для Alexa 3",
+        "pt": "Corrigido o nome de edição dos dispositivos para Alexa 3",
+        "nl": "De naambewerking van de apparaten voor Alexa 3 gecorrigeerd",
+        "fr": "Correction de l'édition du nom des appareils pour Alexa 3",
+        "it": "Corretto il nome di modifica dei dispositivi per Alexa 3",
+        "es": "Corregido el nombre de edición de los dispositivos para Alexa 3",
+        "pl": "Poprawił edycję nazwy urządzeń dla Alexa 3",
+        "uk": "Виправлено редагування назв пристроїв для Alexa 3",
+        "zh-cn": "校正了Alexa 3设备的名称编辑"
+      },
       "3.4.3": {
         "en": "corrected the addition of the devices for Alexa\nchanged compilation of GUI to remove deprecated packages",
         "de": "korrigierte die Ergänzung der Geräte für Alexa\ngeänderte Zusammenstellung von GUI, um deprecierte Pakete zu entfernen",
@@ -67,32 +93,6 @@
         "pl": "usunąć niektóre ostrzeżenia, które powinny być tylko logi debugowania",
         "uk": "видалення деяких попереджень, які повинні бути вилучені",
         "zh-cn": "删除一些只应该为调试日志的警告"
-      },
-      "3.2.1": {
-        "en": "fixed issue that only valid JSON could be sent to app via message state",
-        "de": "festes Problem, dass nur gültig JSON per Nachrichtenzustand an die App gesendet werden konnte",
-        "ru": "фиксированный вопрос, который может быть отправлен только действительным JSON через состояние сообщения",
-        "pt": "problema fixo que só JSON válido poderia ser enviado para aplicativo via estado de mensagem",
-        "nl": "vast probleem dat alleen geldige JSON via berichtstatus naar de app kan worden verzonden",
-        "fr": "problème corrigé que seul JSON valide pourrait être envoyé à l'application via l'état du message",
-        "it": "problema fisso che solo valido JSON potrebbe essere inviato all'app tramite lo stato del messaggio",
-        "es": "emisión fija que sólo válida JSON podría ser enviado a la aplicación a través del estado del mensaje",
-        "pl": "stałe wydanie, że tylko poprawny JSON może być wysłany do aplikacji przez stan wiadomości",
-        "uk": "виправлено проблему, що тільки дійсний JSON може бути відправлений на додаток через стан повідомлень",
-        "zh-cn": "只能通过消息状态发送到应用程序的 JSON 的固定问题"
-      },
-      "3.2.0": {
-        "en": "implemented geofence with ioBroker Visu app",
-        "de": "geofence with ioBroker Visu app",
-        "ru": "реализована геозона с приложением ioBroker Visu",
-        "pt": "geofence implementado com aplicativo ioBroker Visu",
-        "nl": "geïmplementeerd geofence met ioBroker Visu app",
-        "fr": "géofence mise en œuvre avec l'application ioBroker Visu",
-        "it": "geofence implementato con ioBroker Visu app",
-        "es": "geofence implementado con aplicación ioBroker Visu",
-        "pl": "zaimplementowany geofence z aplikacją ioBroker Visu",
-        "uk": "впроваджено геоfence з додатком ioBroker Visu",
-        "zh-cn": "使用 ioBroker Visu app 执行的地理栅栏"
       }
     },
     "titleLang": {

package/lib/alexaSmartHomeV2.js

@@ -410,13 +410,13 @@ function AlexaSH2(adapter) {
                     } else {
                         // convert a single device into a group, because at least two devices found with the same name
                         groups[friendlyNames[n]] = {
-                            applianceId: friendlyNames[n].replace(/[^a-zA-Zа-яА-Я0-9_=#;:?@&-]+/g, '_'),
+                            applianceId: friendlyNames[n].replace(/[^a-zA-Zа-яА-Я0-9_=#;:?@&-]+/g, '_').substring(0, 128),
                             applianceTypes: JSON.parse(JSON.stringify(names[friendlyNames[n]].applianceTypes)),
                             manufacturerName: 'ioBroker group',
                             modelName: (name || words['No name'][lang]).substring(0, 128),
                             version: '1',
-                            friendlyName: friendlyNames[n],
-                            friendlyDescription: `${words['Group'][lang]} ${friendlyNames[n]}`,
+                            friendlyName: friendlyNames[n].substring(0, 128),
+                            friendlyDescription: `${words['Group'][lang]} ${friendlyNames[n]}`.substring(0, 128),
                             isReachable: true,
                             actions: JSON.parse(JSON.stringify(actions)),
                             additionalApplianceDetails: {
@@ -477,18 +477,23 @@ function AlexaSH2(adapter) {
                             }
                         }
 
+                        if (JSON.stringify(groups[friendlyNames[n]].additionalApplianceDetails).length > 5000) {
+                            adapter.log.warn(`[ALEXA] "${groups[friendlyNames[n]].friendlyName}" has too long additionalApplianceDetails`);
+                            return;
+                        }
+
                         result.push(groups[friendlyNames[n]]);
                         names[friendlyNames[n]].disabled = true;
                     }
                 } else {
                     const obj = {
-                        applianceId: friendlyNames[n].replace(/[^a-zA-Zа-яА-Я0-9_=#;:?@&-]+/g, '_'),
+                        applianceId: friendlyNames[n].replace(/[^a-zA-Zа-яА-Я0-9_=#;:?@&-]+/g, '_').substring(0, 128),
                         applianceTypes: [],
                         manufacturerName: 'ioBroker',
                         modelName: (name || words['No name'][lang]).substring(0, 128),
                         version: '1',
-                        friendlyName: friendlyNames[n],
-                        friendlyDescription: friendlyDescription,
+                        friendlyName: friendlyNames[n].substring(0, 128),
+                        friendlyDescription: friendlyDescription.substring(0, 128),
                         isReachable: true,
                         actions: JSON.parse(JSON.stringify(actions)),
                         additionalApplianceDetails: {
@@ -503,6 +508,11 @@ function AlexaSH2(adapter) {
                             func,
                         },
                     };
+                    if (JSON.stringify(obj.additionalApplianceDetails).length > 5000) {
+                        adapter.log.warn(`[ALEXA] "${id}" has too long additionalApplianceDetails`);
+                        return;
+                    }
+
                     names[friendlyNames[n]] = obj;
                     smartType && names[friendlyNames[n]].applianceTypes.push(smartType);
                     result.push(obj);
@@ -2544,7 +2554,7 @@ function AlexaSH2(adapter) {
             let names = {};
             enums = [];
 
-            if (_states && _states.rows) {
+            if (_states?.rows) {
                 for (let i = 0; i < _states.rows.length; i++) {
                     if (_states.rows[i].value) {
                         states[_states.rows[i].id] = _states.rows[i].value;
@@ -2552,18 +2562,14 @@ function AlexaSH2(adapter) {
 
                         if (adapter.config.noCommon) {
                             if (
-                                _states.rows[i].value.common &&
-                                _states.rows[i].value.common.custom &&
-                                _states.rows[i].value.common.custom[adapter.namespace] &&
-                                _states.rows[i].value.common.custom[adapter.namespace].smartName &&
+                                _states.rows[i].value.common?.custom?.[adapter.namespace]?.smartName &&
                                 _states.rows[i].value.common.custom[adapter.namespace].smartName !== 'ignore'
                             ) {
                                 alexaIds.push(_states.rows[i].id);
                             }
                         } else {
                             if (
-                                _states.rows[i].value.common &&
-                                _states.rows[i].value.common.smartName &&
+                                _states.rows[i].value.common?.smartName &&
                                 _states.rows[i].value.common.smartName !== 'ignore'
                             ) {
                                 alexaIds.push(_states.rows[i].id);
@@ -2578,7 +2584,7 @@ function AlexaSH2(adapter) {
                 let rooms = [];
                 let funcs = [];
                 let smartName;
-                if (doc && doc.rows) {
+                if (doc?.rows) {
                     for (let i = 0, l = doc.rows.length; i < l; i++) {
                         if (doc.rows[i].value) {
                             let _id = doc.rows[i].id;
@@ -2644,8 +2650,7 @@ function AlexaSH2(adapter) {
                         let room = '';
                         for (let r = 0; r < rooms.length; r++) {
                             if (
-                                !rooms[r].common ||
-                                !rooms[r].common.members ||
+                                !rooms[r].common?.members ||
                                 typeof rooms[r].common.members !== 'object' ||
                                 !rooms[r].common.members.length
                             ) {
@@ -2735,11 +2740,11 @@ function AlexaSH2(adapter) {
                     }
                     if (fnA > fnB) {
                         return 1;
-                    } else if (fnA < fnB) {
+                    }
+                    if (fnA < fnB) {
                         return -1;
-                    } else {
-                        return 0;
                     }
+                    return 0;
                 });
 
                 for (let k = result.length - 1; k >= 0; k--) {
@@ -2754,6 +2759,50 @@ function AlexaSH2(adapter) {
                     }
                 }
 
+                // Check that all applianceId are unique: https://developer.amazon.com/en-US/blogs/alexa/post/Tx480XF5QCA6IN/managing-device-discovery-for-your-alexa-smart-home-skil
+                const uniqueIds = [];
+                for (let i = result.length - 1; i >= 0; i--) {
+                    if (uniqueIds.includes(result[i].applianceId)) {
+                        adapter.log.error(`[ALEXA] Duplicate applianceId: ${result[i].applianceId}`);
+                        result.splice(i, 1);
+                        continue;
+                    }
+
+                    uniqueIds.push(result[i].applianceId);
+
+                    // check the maximum length of capabilities
+                    if (result[i].actions.length > 100) {
+                        adapter.log.error(`[ALEXA] Too many actions by "${result[i].applianceId}": ${result[i].actions.length}`);
+                        result.splice(i, 1);
+                    }
+                }
+
+                // Check the maximum number of devices
+                if (result.length > 300) {
+                    adapter.log.error(`[ALEXA] Too many devices: ${result.length}`);
+                    result.splice(300);
+                }
+
+                while (JSON.stringify(result).length > 255 * 1024) {
+                    // Find the biggest one
+                    let i = -1;
+                    let size = 0;
+                    for (let j = 0; j < result.length; j++) {
+                        const s = JSON.stringify(result[j]).length;
+                        if (s > size) {
+                            size = s;
+                            i = j;
+                        }
+                    }
+
+                    if (i === -1) {
+                        break;
+                    }
+                    adapter.log.warn(`[ALEXA] Too big response. Device "${result[i].applianceId}" will be removed`);
+                    // Check the maximum size of the response
+                    result.splice(i, 1);
+                }
+
                 callback(err, result, analyseAddedId);
             });
         });

package/main.js

@@ -688,7 +688,7 @@ async function readCertificates() {
         throw new Error('Not exists');
     }
 
-    if (!certificate || !certificate.val || !privateKey || !privateKey.val) {
+    if (!certificate?.val || !privateKey?.val) {
         throw new Error('Not exists');
     } else {
         return {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "iobroker.iot",
-  "version": "3.4.3",
+  "version": "3.4.5",
   "description": "This adapter allows to communicate Amazon Alexa and Google Home with ioBroker.",
   "author": {
     "name": "bluefox",
@@ -22,26 +22,26 @@
     "url": "https://github.com/ioBroker/ioBroker.iot"
   },
   "dependencies": {
-    "@iobroker/adapter-core": "^3.2.2",
-    "@iobroker/types": "^6.0.11",
+    "@iobroker/adapter-core": "^3.2.3",
     "aws-iot-device-sdk": "^2.2.15",
     "iobroker.type-detector": "^3.0.5",
     "mime": "^3.0.0",
-    "axios": "^1.7.7",
-    "uuid": "^11.0.2"
+    "axios": "^1.7.9",
+    "uuid": "^11.0.3"
   },
   "devDependencies": {
     "@alcalzone/release-script": "^3.8.0",
     "@alcalzone/release-script-plugin-iobroker": "^3.7.2",
     "@alcalzone/release-script-plugin-license": "^3.7.0",
-    "@iobroker/build-tools": "^2.0.6",
-    "@iobroker/eslint-config": "^0.1.6",
-    "@iobroker/legacy-testing": "^2.0.0",
-    "@types/node": "^22.8.6",
+    "@iobroker/build-tools": "^2.0.12",
+    "@iobroker/eslint-config": "^1.0.0",
+    "@iobroker/legacy-testing": "^2.0.1",
+    "@iobroker/types": "^7.0.6",
+    "@types/node": "^22.10.2",
     "chai": "^4.5.0",
     "colorette": "^2.0.20",
-    "mocha": "^10.8.2",
-    "puppeteer": "^23.6.1"
+    "mocha": "^11.0.1",
+    "puppeteer": "^23.11.1"
   },
   "bugs": {
     "url": "https://github.com/ioBroker/ioBroker.iot/issues"