iobroker.ebus 3.6.2 → 3.6.6

package/main.js

@@ -1,25 +1,26 @@
-/*
+/* eslint-disable prefer-template */
+/*
  * ebus adapter für iobroker
  *
  * Created: 15.09.2016 21:31:28
  *  Author: Rene
-
+ * 
 
 */
 
-/* jshint -W097 */// jshint strict:false
+/* jshint -W097 */ // jshint strict:false
 /*jslint node: true */
 "use strict";
 
-
-
-
 const utils = require("@iobroker/adapter-core");
-const os = require('os');
-const { exec } = require("child_process");
-const { spawn } = require("child_process")
-const fs = require('fs');
-const path = require('path');
+const os = require("os");
+//const { exec } = require("child_process");
+const { spawn } = require("child_process");
+const fs = require("fs");
+const path = require("path");
+const axios = require("axios");
+const net = require("net");
+const { PromiseSocket } = require("promise-socket");
 
 const ebusdMinVersion = [25, 1];
 const ebusdVersion = [0, 0];
@@ -36,16 +37,14 @@ function startAdapter(options) {
             try {
                 //adapter.log.debug('start');
                 main();
-            }
-            catch (e) {
-                adapter.log.error("exception catch after ready [" + e + "]");
+            } catch (e) {
+                adapter.log.error(`exception catch after ready [${  e  }]`);
             }
         },
         //#######################################
         //  is called when adapter shuts down
         unload: function (callback) {
             try {
-
                 if (intervalID != null) {
                     clearInterval(intervalID);
                 }
@@ -56,6 +55,7 @@ function startAdapter(options) {
                 //to do stop intervall
                 callback();
             } catch (e) {
+                adapter.log.error(`exception catch after unload [${e}]`);
                 callback();
             }
         },
@@ -65,7 +65,7 @@ function startAdapter(options) {
         },
         //#######################################
         //
-        message: async (obj) => {
+        message: async obj => {
             if (obj) {
                 switch (obj.command) {
                     case "findParams":
@@ -90,11 +90,11 @@ function startAdapter(options) {
                         await CheckVersion("supported", obj);
                         break;
                     default:
-                        adapter.log.error("unknown message " + obj.command);
+                        adapter.log.error(`unknown message ${  obj.command}`);
                         break;
                 }
             }
-        }
+        },
         //#######################################
         //
     });
@@ -103,16 +103,10 @@ function startAdapter(options) {
     return adapter;
 }
 
-
-const axios = require("axios");
-const net = require("net");
-const { PromiseSocket } = require("promise-socket");
-
-let intervalID=null;
-let updateTimerID=null;
+let intervalID = null;
+let updateTimerID = null;
 
 async function main() {
-
     adapter.log.debug("start with interface ebusd ");
 
     FillPolledVars();
@@ -127,18 +121,16 @@ async function main() {
     if (parseInt(adapter.config.readInterval) > 0) {
         readInterval = adapter.config.readInterval;
     }
-    adapter.log.debug("read every  " + readInterval + " minutes");
+    adapter.log.debug(`read every  ${  readInterval  } minutes`);
     intervalID = setInterval(Do, readInterval * 60 * 1000);
 
     //read at adapterstart
     await Do();
-
 }
 
 let requestRunning = false;
 
 async function DoRequest() {
-
     adapter.log.debug("DoRequest ");
 
     if (!requestRunning) {
@@ -146,30 +138,23 @@ async function DoRequest() {
         await ebusd_ReadValues();
 
         await ebusd_ReceiveData();
-    }
-    else {
+    } else {
         adapter.log.debug("DoRequest: do nothing already running ");
     }
     requestRunning = false;
 }
 
 async function Do() {
-
-    adapter.log.debug("starting ... " );
+    adapter.log.debug("starting ... ");
 
     await ebusd_Command();
 
     await DoRequest();
-    
 }
 
-
 async function HandleStateChange(id, state) {
-   
-
     if (state != null && state.ack !== true) {
-
-        adapter.log.debug("handle state change " + id);
+        adapter.log.debug(`handle state change ${  id}`);
         const ids = id.split(".");
 
         if (ids[2] === "cmd") {
@@ -177,20 +162,16 @@ async function HandleStateChange(id, state) {
             StartDataRequest();
             //see issue #77: only one request possible
             //await Do();
-        }
-        //unhandled state change ebus.0.find
-        else if (ids[2] === "find") {
+        } else if (ids[2] === "find") {
+            //unhandled state change ebus.0.find
             await ebusd_find();
-        }
-        else {
-            adapter.log.warn("unhandled state change " + id);
+        } else {
+            adapter.log.warn(`unhandled state change ${  id}`);
         }
     }
 }
 
-
 function StartDataRequest() {
-
     if (updateTimerID != null) {
         //already running
         clearTimeout(updateTimerID);
@@ -201,7 +182,6 @@ function StartDataRequest() {
     adapter.log.debug("StartDataRequest");
 }
 
-
 async function DataRequest() {
     adapter.log.debug("get data after command and timeout");
     if (updateTimerID != null) {
@@ -211,12 +191,14 @@ async function DataRequest() {
     await DoRequest();
 }
 
-
 const oPolledVars = [];
 function FillPolledVars() {
-
     try {
-        if (adapter.config.PolledDPs !== undefined && adapter.config.PolledDPs != null && adapter.config.PolledDPs.length > 0) {
+        if (
+            adapter.config.PolledDPs !== undefined &&
+            adapter.config.PolledDPs != null &&
+            adapter.config.PolledDPs.length > 0
+        ) {
             adapter.log.debug("use new object list for polled vars");
 
             //2023-02-10 only active vars
@@ -225,24 +207,21 @@ function FillPolledVars() {
                     oPolledVars.push(adapter.config.PolledDPs[i]);
                 }
             }
-
-        }
-        else {
+        } else {
             //make it compatible to old versions
-            adapter.log.debug("check old comma separeted list for polled vars " + adapter.config.PolledValues);
+            adapter.log.debug(`check old comma separeted list for polled vars ${  adapter.config.PolledValues}`);
 
             if (adapter.config.PolledValues !== undefined && typeof adapter.config.PolledValues == "string") {
                 const oPolled = adapter.config.PolledValues.split(",");
 
                 if (oPolled.length > 0) {
-
                     for (let i = 0; i < oPolled.length; i++) {
                         if (oPolled[i].length > 0) {
                             //console.log('add ' + oPolled[i]);
                             const value = {
                                 circuit: "",
                                 name: oPolled[i],
-                                parameter: ""
+                                parameter: "",
                             };
                             oPolledVars.push(value);
                         }
@@ -250,33 +229,32 @@ function FillPolledVars() {
                 }
             }
         }
-    }
-    catch (e) {
-        adapter.log.error("exception in FillPolledVars [" + e + "]");
+    } catch (e) {
+        adapter.log.error(`exception in FillPolledVars [${  e  }]`);
     }
 
-    adapter.log.info("list of polled vars " + JSON.stringify(oPolledVars));
-
+    adapter.log.debug(`list of polled vars ${  JSON.stringify(oPolledVars)}`);
 }
 
 let oHistoryVars = [];
 function FillHistoryVars() {
-
     try {
-        if (adapter.config.HistoryDPs !== undefined && adapter.config.HistoryDPs != null && adapter.config.HistoryDPs.length > 0) {
+        if (
+            adapter.config.HistoryDPs !== undefined &&
+            adapter.config.HistoryDPs != null &&
+            adapter.config.HistoryDPs.length > 0
+        ) {
             adapter.log.debug("use new object list for history vars");
             oHistoryVars = adapter.config.HistoryDPs;
-        }
-        else if (adapter.config.HistoryValues !== undefined && typeof adapter.config.HistoryValues === "string")  {
+        } else if (adapter.config.HistoryValues !== undefined && typeof adapter.config.HistoryValues === "string") {
             //make it compatible to old versions
             adapter.log.debug("check old comma separeted list for history vars");
             const oHistory = adapter.config.HistoryValues.split(",");
 
             if (oHistory.length > 0) {
-
                 for (let i = 0; i < oHistory.length; i++) {
                     if (oHistory[i].length > 0) {
-                        console.log("add " + oHistory[i]);
+                        console.log(`add ${oHistory[i]}`);
                         const value = {
                             name: oHistory[i],
                         };
@@ -285,26 +263,53 @@ function FillHistoryVars() {
                 }
             }
         }
+    } catch (e) {
+        adapter.log.error(`exception in function FillHistoryVars [${e}]`);
     }
-    catch (e) {
-        adapter.log.error("exception in function FillHistoryVars [" + e + "]");
-    }
+
+    adapter.log.debug(`list of history vars ${JSON.stringify(oHistoryVars)}`);
+
+    //add a check, that complete dp without ebus.0 is used 2025-08-20
+
+    oHistoryVars.forEach((entry, index) => {
+        const hasDot = entry.name.includes(".");
+        const hasInstance = entry.name.includes("ebus.");
+        const hasValue = entry.name.includes("value");
+
+        adapter.log.debug("checking " + entry.name + " index " + index + " hasDot: " + hasDot + " hasInstance: " + hasInstance + " hasValue: " + hasValue);
+
+
+        if (!hasDot) {
+            adapter.log.warn("please check history variable: " + entry.name + " -> should contain the complete DP");
+        }
+
+        if (!hasValue) {
+            adapter.log.warn("please check history variable " + entry.name + " -> should contain 'value'");
+        }
+
+        if (hasInstance) {
+            adapter.log.warn("please check history variable " + entry.name + " -> should not contain instance name and instance number e.g. 'ebus.0' ");
+        }
+
+    });
+
+    //list of history vars [{"name":"ActualEnvironmentPower"},{"name":"YieldTotal"},{"name":"SourceTempInput"},{"name":"SourceTempOutput"},{"name":"HwcTemp"}]
+
 }
 
 let oHTTPParamsVars = [];
 function FillHTTPParamsVars() {
-    if (adapter.config.HTTPparameter !== undefined && adapter.config.HTTPparameter != null && adapter.config.HTTPparameter.length > 0) {
-
+    if (
+        adapter.config.HTTPparameter !== undefined &&
+        adapter.config.HTTPparameter != null &&
+        adapter.config.HTTPparameter.length > 0
+    ) {
         oHTTPParamsVars = adapter.config.HTTPparameter;
 
-        adapter.log.debug("use optionally HTTP parameter " + JSON.stringify(oHTTPParamsVars));
+        adapter.log.debug(`use optionally HTTP parameter ${  JSON.stringify(oHTTPParamsVars)}`);
     }
 }
 
-
-
-
-
 //===================================================================================================
 // ebusd interface
 
@@ -314,9 +319,9 @@ async function ebusd_Command() {
     if (obj !== undefined && obj != null) {
         const cmds = obj.val;
         if (cmds !== "") {
-            adapter.log.debug("got command(s): " + cmds);
+            adapter.log.debug(`got command(s): ${  cmds}`);
 
-            adapter.log.debug("connect telnet to IP " + adapter.config.targetIP + " port " + parseInt(adapter.config.targetTelnetPort));
+            adapter.log.debug(`connect telnet to IP ${  adapter.config.targetIP  } port ${  parseInt(adapter.config.targetTelnetPort)}`);
 
             try {
                 const socket = new net.Socket();
@@ -331,47 +336,43 @@ async function ebusd_Command() {
                 if (oCmds.length > 0) {
                     let received = "";
                     for (let n = 0; n < oCmds.length; n++) {
-
-                        adapter.log.debug("send " + oCmds[n]);
-                        await promiseSocket.write(oCmds[n] + "\n");
+                        adapter.log.debug(`send ${  oCmds[n]}`);
+                        await promiseSocket.write(`${oCmds[n]  }\n`);
 
                         const data = await promiseSocket.read();
 
                         if (data.includes("ERR")) {
-                            adapter.log.warn("sent " + oCmds[n] + ", received " + data + " please check ebusd logs for details!");
-                        }
-                        else {
-                            adapter.log.debug("received " + data);
+                            adapter.log.warn(`sent ${  oCmds[n]  }, received ${  data  } please check ebusd logs for details!`);
+                            
+                        } else {
+                            adapter.log.debug(`received ${  data}`);
                         }
                         received += data.toString();
                         received += ", ";
                     }
 
                     //see issue #78: remove CR, LF and last comma
-                    received = received.replace(/\r?\n|\r/g,"");
+                    received = received.replace(/\r?\n|\r/g, "");
                     received = received.slice(0, -2);
 
-                    //set result to cmdResult 
+                    //set result to cmdResult
                     await adapter.setStateAsync("cmdResult", { ack: true, val: received });
-                }
-                else {
-                    adapter.log.warn("no commands in list " + cmds + " " + JSON.stringify(oCmds));
+                } else {
+                    adapter.log.warn(`no commands in list ${  cmds  } ${  JSON.stringify(oCmds)}`);
                 }
                 await adapter.setStateAsync("cmd", { ack: true, val: "" });
 
                 promiseSocket.destroy();
-
             } catch (e) {
-                adapter.log.error("exception from tcp socket" + "[" + e + "]");
+                adapter.log.error(`exception from tcp socket` + `[${  e  }]`);
             }
         }
-    }
-    else {
-        adapter.log.debug("object cmd not found " + JSON.stringify(obj));
+    } else {
+        adapter.log.debug(`object cmd not found ${  JSON.stringify(obj)}`);
     }
 }
 
-async function ebusd_find(){
+async function ebusd_find() {
     try {
         const socket = new net.Socket();
         const promiseSocket = new PromiseSocket(socket);
@@ -385,17 +386,15 @@ async function ebusd_find(){
         const data = await promiseSocket.read();
 
         if (data.includes("ERR")) {
-            adapter.log.warn("received error! sent find, received " + data + " please check ebusd logs for details!");
-        }
-        else {
-            adapter.log.debug("received " + typeof data + " " + data);
+            adapter.log.warn(`received error! sent find, received ${  data  } please check ebusd logs for details!`);
+        } else {
+            adapter.log.debug(`received ${  typeof data  } ${  data}`);
         }
 
-        const str = new TextDecoder().decode(data); 
+        const str = new TextDecoder().decode(data);
         const datas = str.split(/\r?\n/);
 
         for (let i = 0; i < datas.length; i++) {
-
             //adapter.log.debug(JSON.stringify(datas[i]));
 
             const names = datas[i].split(",");
@@ -403,32 +402,26 @@ async function ebusd_find(){
             //circuit,name,comment
             await UpdateDP(names[0], names[1], names[2]);
 
-            let cmd = "read -f -c " + names[0] + " " + names[1] ;
+            let cmd = `read -f -c ${  names[0]  } ${  names[1]}` ;
 
-            adapter.log.debug("send cmd " + cmd);
+            adapter.log.debug(`send cmd ${  cmd}`);
 
             cmd += "\n";
             await promiseSocket.write(cmd);
 
             const result = await promiseSocket.read();
 
-            adapter.log.debug("received " + typeof result + " " + result);
+            adapter.log.debug(`received ${  typeof result  } ${  result}`);
         }
-        
 
         promiseSocket.destroy();
-
     } catch (e) {
-        adapter.log.error("exception from tcp socket in ebusd_find" + "[" + e + "]");
+        adapter.log.error(`exception from tcp socket in ebusd_find` + `[${  e  }]`);
     }
-
 }
 
-
-
 //just call http://192.168.0.123:8889/data
 
-
 /*
     http://localhost:8080/data/mc?verbose&since=1483890000&exact
 
@@ -452,7 +445,6 @@ async function ebusd_find(){
 
 */
 
-
 async function subscribeVars() {
     adapter.subscribeStates("cmd");
 
@@ -462,21 +454,20 @@ async function subscribeVars() {
 }
 
 async function CreateObject(key, obj) {
-
     const obj_new = await adapter.getObjectAsync(key);
     //adapter.log.warn("got object " + JSON.stringify(obj_new));
 
     if (obj_new != null) {
-
-        if ((obj_new.common.role != obj.common.role
-            || obj_new.common.type != obj.common.type
-            || (obj_new.common.unit != obj.common.unit && obj.common.unit != null)
-            || obj_new.common.read != obj.common.read
-            || obj_new.common.write != obj.common.write
-            || obj_new.common.name != obj.common.name)
-            && obj.type === "state"
+        if (
+            (obj_new.common.role != obj.common.role ||
+                obj_new.common.type != obj.common.type ||
+                (obj_new.common.unit != obj.common.unit && obj.common.unit != null) ||
+                obj_new.common.read != obj.common.read ||
+                obj_new.common.write != obj.common.write ||
+                obj_new.common.name != obj.common.name) &&
+            obj.type === "state"
         ) {
-            adapter.log.warn("change object " + JSON.stringify(obj) + " " + JSON.stringify(obj_new));
+            adapter.log.warn(`change object ${  JSON.stringify(obj)  } ${  JSON.stringify(obj_new)}`);
             await adapter.extendObject(key, {
                 common: {
                     name: obj.common.name,
@@ -484,61 +475,51 @@ async function CreateObject(key, obj) {
                     type: obj.common.type,
                     unit: obj.common.unit,
                     read: obj.common.read,
-                    write: obj.common.write
-                }
+                    write: obj.common.write,
+                },
             });
         }
-    }
-    else {
+    } else {
         await adapter.setObjectNotExistsAsync(key, obj);
     }
 }
 
-
 //circuit,name,comment
 async function UpdateDP(circuit, name, comment) {
-
-    const key = circuit + ".messages." + name;
-    adapter.log.debug("update check for " + key);
-
+    const key = `${circuit  }.messages.${  name}`;
+    adapter.log.debug(`update check for ${  key}`);
 
     //       ehp.messages.Injection
     //ebus.0.ehp.messages.Injection
 
     const obj = await adapter.getObjectAsync(key);
-    adapter.log.debug("update check got " + JSON.stringify(obj));
-
+    adapter.log.debug(`update check got ${  JSON.stringify(obj)}`);
 
     //update check got null
 
     if (obj != null) {
-
         if (obj.common.name != comment) {
-            adapter.log.debug("update  " + key + " " + comment);
+            adapter.log.debug(`update  ${  key  } ${  comment}`);
             await adapter.extendObject(key, {
                 common: {
                     name: comment,
                     read: true,
-                    write: false
-                }
+                    write: false,
+                },
             });
         }
-    }
-    else {
+    } else {
         await adapter.setObjectNotExistsAsync(key, {
             type: "channel",
             common: {
                 name: comment,
                 read: true,
-                write: false
-            }
+                write: false,
+            },
         });
     }
-
 }
 
-
-
 async function checkVariables() {
     adapter.log.debug("init variables ");
 
@@ -546,15 +527,15 @@ async function checkVariables() {
     let obj;
 
     key = "cmd";
-    obj= {
+    obj = {
         type: "state",
         common: {
             name: "ebusd command",
             type: "string",
             role: "text",
             read: true,
-            write: true
-        }
+            write: true,
+        },
     };
     await CreateObject(key, obj);
 
@@ -566,8 +547,8 @@ async function checkVariables() {
             type: "string",
             role: "text",
             read: true,
-            write: false
-        }
+            write: false,
+        },
     };
     await CreateObject(key, obj);
 
@@ -579,27 +560,23 @@ async function checkVariables() {
             type: "boolean",
             role: "button",
             read: false,
-            write: true
-        }
+            write: true,
+        },
     };
     await CreateObject(key, obj);
 
+    adapter.log.debug(`init common variables and ${  oHistoryVars.length  } history DP's`);
 
-
-    adapter.log.debug("init common variables and " + oHistoryVars.length + " history DP's");
-    
     if (oHistoryVars.length > 0) {
-
         if (oHistoryVars.length > 4) {
-            adapter.log.warn("too many history values " + oHistoryVars.length + " -> maximum is  4");
+            adapter.log.warn(`too many history values ${  oHistoryVars.length  } -> maximum is  4`);
         }
 
         for (let n = 1; n <= oHistoryVars.length; n++) {
-
             if (oHistoryVars[n - 1].name.length > 0) {
-                const name = "history value " + n + " as JSON " + oHistoryVars[n - 1].name;
-                key = "history.value" + n;
-                obj= {
+                const name = `history value ${  n  } as JSON ${  oHistoryVars[n - 1].name}`;
+                key = `history.value${  n}`;
+                obj = {
                     type: "state",
                     common: {
                         name: name,
@@ -607,19 +584,18 @@ async function checkVariables() {
                         role: "value",
                         unit: "",
                         read: true,
-                        write: false
+                        write: false,
                     },
-                    native: { location: key }
+                    native: { location: key },
                 };
                 await CreateObject(key, obj);
-            }
-            else {
-                adapter.log.warn("ignoring history value " + n + " (invalid name)");
+            } else {
+                adapter.log.warn(`ignoring history value ${  n  } (invalid name)`);
             }
         }
 
         key = "history.date";
-        obj= {
+        obj = {
             type: "state",
             common: {
                 name: "ebus history date / time as JSON",
@@ -627,16 +603,16 @@ async function checkVariables() {
                 role: "value",
                 unit: "",
                 read: true,
-                write: false
+                write: false,
             },
             native: {
-                location: key
-            }
+                location: key,
+            },
         };
         await CreateObject(key, obj);
     }
     key = "history.error";
-    obj= {
+    obj = {
         type: "state",
         common: {
             name: "ebus error",
@@ -644,32 +620,37 @@ async function checkVariables() {
             role: "value",
             unit: "",
             read: true,
-            write: false
+            write: false,
         },
-        native: { location: key }
+        native: { location: key },
     };
     await CreateObject(key, obj);
 }
 
-
 function VersionCheck() {
-
-    if (ebusdVersion[0] > 0 ) {
-        if (ebusdVersion[0] < ebusdMinVersion[0] || (ebusdVersion[0] == ebusdMinVersion[0] && ebusdVersion[1] < ebusdMinVersion[1])) {
-            adapter.log.info("please update ebusd, old version found: " + ebusdVersion[0] + "." + ebusdVersion[1] + " supported version is " + ebusdMinVersion[0] + "." + ebusdMinVersion[1]);
+    if (ebusdVersion[0] > 0) {
+        if (
+            ebusdVersion[0] < ebusdMinVersion[0] ||
+            (ebusdVersion[0] == ebusdMinVersion[0] && ebusdVersion[1] < ebusdMinVersion[1])
+        ) {
+            adapter.log.info(`please update ebusd, old version found: ${  ebusdVersion[0]  }.${  ebusdVersion[1]  } supported version is ${  ebusdMinVersion[0]  }.${  ebusdMinVersion[1]}`);
         }
-        if (ebusdVersion[0] > ebusdMinVersion[0] || (ebusdVersion[0] >= ebusdMinVersion[0] && ebusdVersion[1] > ebusdMinVersion[1])) {
-            adapter.log.info("unsupported ebusd version found (too new): " + ebusdVersion[0] + "." + ebusdVersion[1] + " supported version is " + ebusdMinVersion[0] + "." + ebusdMinVersion[1]);
+        if (
+            ebusdVersion[0] > ebusdMinVersion[0] ||
+            (ebusdVersion[0] >= ebusdMinVersion[0] && ebusdVersion[1] > ebusdMinVersion[1])
+        ) {
+            adapter.log.info(`unsupported ebusd version found (too new): ${  ebusdVersion[0]  }.${  ebusdVersion[1]  } supported version is ${  ebusdMinVersion[0]  }.${  ebusdMinVersion[1]}`);
         }
     }
 
     if (ebusdUpdateVersion[0] > 0 && ebusdVersion[0] > 0) {
-
-        if (ebusdUpdateVersion[0] > ebusdVersion[0] || (ebusdUpdateVersion[0] == ebusdVersion[0] && ebusdUpdateVersion[1] > ebusdVersion[1])) {
-            adapter.log.info("new ebusd version found: " + ebusdUpdateVersion[0] + "." + ebusdUpdateVersion[1] + " supported version is " + ebusdMinVersion[0] + "." + ebusdMinVersion[1]);
+        if (
+            ebusdUpdateVersion[0] > ebusdVersion[0] ||
+            (ebusdUpdateVersion[0] == ebusdVersion[0] && ebusdUpdateVersion[1] > ebusdVersion[1])
+        ) {
+            adapter.log.info(`new ebusd version found: ${  ebusdUpdateVersion[0]  }.${  ebusdUpdateVersion[1]  } supported version is ${  ebusdMinVersion[0]  }.${  ebusdMinVersion[1]}`);
 
         }
-
     }
 }
 
@@ -677,6 +658,240 @@ function VersionCheck() {
 //https://github.com/john30/ebusd/wiki/3.2.-HTTP-client
 
 async function ebusd_ReceiveData() {
+    try {
+        let sUrl = `http://${  adapter.config.targetIP  }:${  parseInt(adapter.config.targetHTTPPort)  }/data`;
+
+        //Erweiterung mit optionalen parametern
+        var paramsCnt = 0;
+        if (oHTTPParamsVars !== undefined && oHTTPParamsVars != null && oHTTPParamsVars.length > 0) {
+            for (let i = 0; i < oHTTPParamsVars.length; i++) {
+                if (oHTTPParamsVars[i].active) {
+                    if (paramsCnt == 0) {
+                        sUrl += "?";
+                    } else {
+                        sUrl += "&";
+                    }
+                    sUrl += `${oHTTPParamsVars[i].name  }=${  oHTTPParamsVars[i].value}`;
+                    paramsCnt++;
+                }
+            }
+        }
+
+        adapter.log.debug(`request data from ${  sUrl}`);
+        const buffer = await axios.get(sUrl);
+
+        adapter.log.debug(`got data ${  typeof buffer.data  } ${  JSON.stringify(buffer.data)}`);
+
+        const flattenObject = (obj, delimiter = ".", prefix = "") =>
+            Object.keys(obj).reduce((acc, k) => {
+                const pre = prefix.length ? `${prefix}${delimiter}` : "";
+                if (typeof obj[k] === "object" && obj[k] !== null && Object.keys(obj[k]).length > 0) {
+                    Object.assign(acc, flattenObject(obj[k], delimiter, pre + k));
+                } else {
+                    acc[pre + k] = obj[k];
+                }
+                return acc;
+            }, {});
+
+        let data = flattenObject(buffer.data, ".");
+
+        const historyvalues = [];
+        const historydates = [];
+
+        const oToday = new Date();
+        const month = oToday.getMonth() + 1;
+
+        historydates.push({
+            date: `${oToday.getDate()  }.${  month  }.${  oToday.getFullYear()}`,
+            time: `${oToday.getHours()  }:${  oToday.getMinutes()  }:${  oToday.getSeconds()}`
+        });
+
+        let sError = "none";
+
+        for (let key in data) {
+            const subnames = key.split(".");
+            //const namelength = subnames.length;
+            let value = data[key];
+
+            //adapter.log.debug("key " + key);
+
+            if (key.includes("[") || key.includes("]")) {
+                adapter.log.debug(`found unsupported chars in ${  key}`);
+                const start = key.indexOf("[");
+                const end = key.lastIndexOf("]");
+
+                if (start > 0 && end > 0) {
+                    const toReplace = key.slice(start, end + 1);
+                    key = key.replace(toReplace, "");
+                }
+                //adapter.log.warn("new key is " + key);
+            }
+
+            //======== version check
+            if (key.includes("global.version")) {
+                //adapter.log.info("in version, value " + value);
+                const versionInfo = value.split(".");
+                if (versionInfo.length > 1) {
+                    adapter.log.debug(`installed ebusd version is ${  versionInfo[0]  }.${  versionInfo[1]}`);
+
+                    ebusdVersion[0] = versionInfo[0];
+                    ebusdVersion[1] = versionInfo[1];
+
+                    VersionCheck();
+                }
+            }
+
+            if (key.includes("global.updatecheck")) {
+                //revision v21.2 available
+                value = value.replace("revision v", "");
+                value = value.replace(" available", "");
+
+                const versionInfo = value.split(".");
+                if (versionInfo.length > 1) {
+                    adapter.log.info(`found ebusd update version ${  versionInfo[0]  }.${  versionInfo[1]}`);
+
+                    ebusdUpdateVersion[0] = versionInfo[0];
+                    ebusdUpdateVersion[1] = versionInfo[1];
+
+                    VersionCheck();
+                }
+            }
+
+            //============ type check
+            let type = typeof value;
+
+            if (adapter.config.useBoolean4Onoff) {
+                if (type == "string" && (value == "on" || value == "off")) {
+                    adapter.log.debug(`Key ${  key  } change to boolean ${  value}`);
+                    //Key mc.messages.Status.fields.1.value could be boolean off
+
+                    type = "boolean";
+
+                    if (value == "on") {
+                        value = true;
+                    } else {
+                        value = false;
+                    }
+                }
+            }
+
+            //EVU Sperrzeit
+            if (key.includes(".hcmode2.value") || key.includes(".hcmode.value")) {
+                if (parseInt(value) === 0) {
+                    adapter.log.info(`${key  }in hcmode2 with value 0: off`);
+                    value = "off";
+                } else if (parseInt(value) === 5) {
+                    adapter.log.info(`${key  } with value 5: EVU Sperrzeit`);
+                    value = "EVU Sperrzeit";
+                } else {
+                    adapter.log.debug(`in hcmode2, value ${  value}`);
+                }
+                type = typeof value;
+            }
+
+            //lastup umrechnen
+            if (key.includes(".lastup")) {
+                if (parseInt(value) > 0) {
+                    //adapter.log.debug('Key : ' + key + ', Value : ' + newData[key] + " name " + name);
+
+                    //umrechnen...
+                    const oDate = new Date(value * 1000);
+                    //const nDate = oDate.getDate();
+                    //const nMonth = oDate.getMonth() + 1;
+                    //const nYear = oDate.getFullYear();
+                    //const nHours = oDate.getHours();
+                    //const nMinutes = oDate.getMinutes();
+                    //const nSeconds = oDate.getSeconds();
+
+                    const sDate = oDate.toLocaleString();
+
+                    value = sDate;
+                    type = typeof value;
+
+                    const oToday = new Date();
+
+                    let bSkip = false;
+
+                    if (
+                        subnames[0].includes("scan") ||
+                        subnames[0].includes("Scan") ||
+                        subnames[0].includes("ehp") ||
+                        (subnames.length > 2 && subnames[2].includes("currenterror")) ||
+                        adapter.config.DisableTimeUpdateCheck
+                    ) {
+                        bSkip = true;
+                    }
+
+                    //adapter.log.debug("_______________size " + temp);
+                    if (subnames.length > 2 && subnames[2].includes("Timer")) {
+                        bSkip = true;
+                    }
+
+                    if (!bSkip && Math.abs(oDate.getTime() - oToday.getTime()) > 1 * 60 * 60 * 1000) {
+                        const sError1 = `no update since ${  sDate  } ${  key  } `;
+                        if (sError.includes("none")) {
+                            sError = `ebus: ${  sError1}`;
+                        } else {
+                            sError += sError1;
+                        }
+                        adapter.log.warn(sError1);
+                    }
+                }
+            }
+
+            //add and update data
+            await AddObject(key, type);
+            await UpdateObject(key, value);
+
+            //push to history
+
+            for (let ii = 0; ii < oHistoryVars.length; ii++) {
+
+                //adapter.log.debug("check " + key + "==" + oHistoryVars[ii].name);
+
+                //	check uih.messages.YieldThisYear.fields.energy_1.value==ActualEnvironmentPower
+
+                /*
+                ehp.messages.ActualEnvironmentPower.fields.value.value
+                ehp.messages.YieldTotal.fields.value.value
+                ehp.messages.SourceTempInput.fields.temp.value
+                ehp.messages.SourceTempOutput.fields.temp.value
+                ehp.messages.HwcTemp.fields.temp.value
+                */
+
+
+                if (key === oHistoryVars[ii].name) {
+                    const sTemp = '{"' + key + '": "' + value + '"}';
+                    adapter.log.debug("push history " + sTemp);
+                    historyvalues[ii] = [];
+                    historyvalues[ii].push(JSON.parse(sTemp));
+                    //adapter.log.debug(JSON.stringify(historyvalues));
+                }
+            }
+        }
+
+        await adapter.setStateAsync("history.error", { ack: true, val: sError });
+
+        //adapter.log.debug(JSON.stringify(historyvalues));
+
+        adapter.log.debug("all http done");
+
+        if (historyvalues.length > 0 && historydates.length > 0) {
+            if (adapter.config.History4Vis2) {
+                await UpdateHistory_Vis2(historyvalues, historydates);
+            } else {
+                await UpdateHistory(historyvalues, historydates);
+            }
+        }
+    } catch (e) {
+        adapter.log.error(`exception in ebusd_ReceiveData [${  e  }]`);
+
+        await adapter.setStateAsync("history.error", { ack: true, val: "exception in receive" });
+    }
+}
+
+/*
+async function ebusd_ReceiveData_old() {
 
     let sUrl = "http://" + adapter.config.targetIP + ":" + parseInt(adapter.config.targetHTTPPort) + "/data";
 
@@ -722,13 +937,11 @@ async function ebusd_ReceiveData() {
 
         //adapter.log.debug("000 " + typeof oData + JSON.stringify(oData));
 
-        //adapter.log.debug("oData " + oData);
+        adapter.log.debug("oData " + oData);
 
-        const flatten = require("flat");
+        const newData = flatten.flattenDeep(oData);
 
-        const newData = flatten(oData);
-
-        //adapter.log.debug("111 " + JSON.stringify(newData));
+        adapter.log.debug("111 " + JSON.stringify(newData));
 
         const keys = Object.keys(newData);
 
@@ -925,15 +1138,6 @@ async function ebusd_ReceiveData() {
 
                     if (!bSkip && Math.abs(oDate.getTime() - oToday.getTime()) > 1 * 60 * 60 * 1000) {
 
-
-
-                        /*2024-11-20
-                        ebus: no update since 19.11.2024, 21:11:14 Scan.15.messages.Id.lastup no update since 19.11.2024, 21:11:19 Scan.23.messages.Id.lastup no update since 19.11.2024, 21:10:34 Scan.25.messages.Id.lastup no update since 19.11.2024, 21:12:04 Scan.50.messages.Id.lastup 
-
-                        */
-
-
-
                         const sError1 = "no update since " + sDate + " " + key + " ";
                         if (sError.includes("none")) {
                             sError = "ebus: " + sError1;
@@ -981,29 +1185,30 @@ async function ebusd_ReceiveData() {
     //});
 }
 
+*/
+
 async function UpdateHistory_Vis2(values, dates) {
-    adapter.log.debug("start history 4 VIS-2 " + JSON.stringify(values) + " " + JSON.stringify(dates));
+    adapter.log.debug(`start history 4 VIS-2 ${  JSON.stringify(values)  } ${  JSON.stringify(dates)}`);
 
     //not used anymore
     await adapter.setStateAsync("history.date", { ack: true, val: "" });
 
     for (let s = 0; s < values.length; s++) {
-
         const values1 = values[s];
         //adapter.log.debug(s + " " + JSON.stringify(values1));
 
         let val2Write = [];
         const ctr = s + 1;
 
-        const obj = await adapter.getStateAsync("history.value" + ctr);
+        const obj = await adapter.getStateAsync(`history.value${  ctr}`);
 
         if (obj === null || obj === undefined) {
-            adapter.log.warn("history.value" + ctr + " not found, creating DP " + JSON.stringify(obj));
-            await adapter.setStateAsync("history.value" + ctr, { ack: true, val: "[]" });
+            adapter.log.warn(`history.value${  ctr  } not found, creating DP ${  JSON.stringify(obj)}`);
+            await adapter.setStateAsync(`history.value${  ctr}`, { ack: true, val: "[]" });
         }
 
         val2Write = JSON.parse(obj.val);
-        adapter.log.debug("history.value" + ctr + " got " + JSON.stringify(val2Write));
+        adapter.log.debug(`history.value${  ctr  } got ${  JSON.stringify(val2Write)}`);
 
         for (let ss = 0; ss < values1.length; ss++) {
             const values2 = values1[ss];
@@ -1012,7 +1217,6 @@ async function UpdateHistory_Vis2(values, dates) {
             let d = 0;
 
             for (const n in values2) {
-
                 const val = values2[n];
                 const time = dates[d]["time"];
                 const date = dates[d]["date"];
@@ -1029,35 +1233,23 @@ async function UpdateHistory_Vis2(values, dates) {
 
                 const oDate = new Date(year, month, day, hours, minutes, 0, 0);
 
-                adapter.log.debug(n + " " + val + " " + oDate.toLocaleString());
+                adapter.log.debug(`${n  } ${  val  } ${  oDate.toLocaleString()}`);
 
-                val2Write.push(
-                    [
-                        oDate,
-                        val
-                    ]
-                );
+                val2Write.push([oDate, val]);
 
                 if (val2Write.length > 200) {
-
                     for (let i = val2Write.length; i > 200; i--) {
                         //adapter.log.debug("delete");
                         val2Write.shift();
                     }
                 }
-
             }
         }
-        await adapter.setStateAsync("history.value" + ctr, { ack: true, val: JSON.stringify(val2Write) });
+        await adapter.setStateAsync(`history.value${  ctr}`, { ack: true, val: JSON.stringify(val2Write) });
     }
 }
 
-
-
-
-
 async function UpdateHistory(values, dates) {
-
     if (oHistoryVars.length > 0) {
         //prüfen ob alle json gleich lang sind
         let NoOfDates = -1;
@@ -1071,13 +1263,10 @@ async function UpdateHistory(values, dates) {
                 oEbusDates = JSON.parse(obj.val);
                 //adapter.log.debug("after parse " + JSON.stringify(oEbusDates));
 
-
-
                 oEbusDates.push(dates);
                 //adapter.log.debug("after push " + JSON.stringify(oEbusDates));
                 //limit length of object...
                 if (oEbusDates.length > 200) {
-
                     for (let i = oEbusDates.length; i > 200; i--) {
                         //adapter.log.debug("delete");
                         oEbusDates.shift();
@@ -1085,22 +1274,19 @@ async function UpdateHistory(values, dates) {
                 }
                 NoOfDates = oEbusDates.length;
                 await adapter.setStateAsync("history.date", { ack: true, val: JSON.stringify(oEbusDates) });
-            }
-            catch (e) {
-                adapter.log.error("exception in UpdateHistory part1 [" + e + "]");
+            } catch (e) {
+                adapter.log.error(`exception in UpdateHistory part1 [${  e  }]`);
                 await adapter.setStateAsync("history.date", { ack: true, val: "[]" });
                 NoOfDates = 0;
             }
-        }
-        else {
+        } else {
             adapter.log.warn("history.date not found, creating DP ");
             await adapter.setStateAsync("history.date", { ack: true, val: "[]" });
             NoOfDates = 0;
         }
-        
+
         if (oHistoryVars.length > 0) {
             for (let ctr = 1; ctr <= oHistoryVars.length; ctr++) {
-
                 if (oHistoryVars[ctr - 1].name.length > 0) {
                     const ctrOkay = await UpdateHistoryValues(values, ctr, NoOfDates);
 
@@ -1109,28 +1295,22 @@ async function UpdateHistory(values, dates) {
                         NoOfDates = 0;
                         adapter.log.warn("reset history date too");
                     }
-                }
-                else {
-                    adapter.log.debug("ignoring history value " + ctr);
+                } else {
+                    adapter.log.debug(`ignoring history value ${  ctr}`);
                 }
             }
 
             adapter.log.info("all history done");
         }
-    }
-    else {
+    } else {
         adapter.log.debug("nothing to do for history");
     }
 }
 
-
-
 async function UpdateHistoryValues(values, ctr, curDateCtr) {
-
-
     let bRet = true;
 
-    const obj = await adapter.getStateAsync("history.value" + ctr);
+    const obj = await adapter.getStateAsync(`history.value${  ctr}`);
 
     if (obj !== undefined && obj != null) {
         try {
@@ -1152,39 +1332,32 @@ async function UpdateHistoryValues(values, ctr, curDateCtr) {
             //adapter.log.debug("after push cnt " + oEbusValues.length);
             //limit length of object...
             if (oEbusValues.length > 200) {
-
                 for (let i = oEbusValues.length; i > 200; i--) {
                     //adapter.log.debug("delete");
                     oEbusValues.shift();
                 }
             }
 
-            const key = "history.value" + ctr;
-            adapter.log.debug("update history " + key); 
+            const key = `history.value${  ctr}`;
+            adapter.log.debug(`update history ${  key}`);
 
             if (curDateCtr != oEbusValues.length) {
                 bRet = false;
-                await adapter.setStateAsync("history.value" + ctr, { ack: true, val: "[]" });
-                adapter.log.warn("reset history " + key + " because number of values different to date values"); 
-
-            }
-            else {
+                await adapter.setStateAsync(`history.value${  ctr}`, { ack: true, val: "[]" });
+                adapter.log.warn(`reset history ${  key  } because number of values different to date values`);
+            } else {
                 await adapter.setStateAsync(key, { ack: true, val: JSON.stringify(oEbusValues) });
             }
-
-            
-        }
-        catch (e) {
-            adapter.log.error("exception in UpdateHistory part2 [" + e + "]");
-            await adapter.setStateAsync("history.value" + ctr, { ack: true, val: "[]" });
+        } catch (e) {
+            adapter.log.error(`exception in UpdateHistory part2 [${  e  }]`);
+            await adapter.setStateAsync(`history.value${  ctr}`, { ack: true, val: "[]" });
             if (curDateCtr > 0) {
                 bRet = false;
             }
         }
-    }
-    else {
-        adapter.log.warn("history.value" + ctr + " not found, creating DP " + JSON.stringify(obj));
-        await adapter.setStateAsync("history.value" + ctr, { ack: true, val: "[]" });
+    } else {
+        adapter.log.warn(`history.value${  ctr  } not found, creating DP ${  JSON.stringify(obj)}`);
+        await adapter.setStateAsync(`history.value${  ctr}`, { ack: true, val: "[]" });
         if (curDateCtr > 0) {
             bRet = false;
         }
@@ -1193,8 +1366,6 @@ async function UpdateHistoryValues(values, ctr, curDateCtr) {
     return bRet;
 }
 
-
-
 async function AddObject(key, type) {
     //adapter.log.debug("addObject " + key);
 
@@ -1203,19 +1374,17 @@ async function AddObject(key, type) {
 
         if (obj != null) {
             //adapter.log.debug(" got Object " + JSON.stringify(obj));
-            if (obj.common.role != "value"
-                || obj.common.type != type) {
-                adapter.log.debug(" !!! need to extend for " + key);
+            if (obj.common.role != "value" || obj.common.type != type) {
+                adapter.log.debug(` !!! need to extend for ${  key}`);
                 await adapter.extendObject(key, {
                     common: {
                         type: type,
                         role: "value",
-                    }
+                    },
                 });
             }
-        }
-        else {
-            adapter.log.warn(" !!! does not exist, creating now " + key );
+        } else {
+            adapter.log.warn(` !!! does not exist, creating now ${  key}` );
 
             await adapter.setObjectNotExistsAsync(key, {
                 type: "state",
@@ -1225,38 +1394,34 @@ async function AddObject(key, type) {
                     role: "value",
                     unit: "",
                     read: true,
-                    write: false
+                    write: false,
                 },
                 native: {
-                    location: key
-                }
+                    location: key,
+                },
             });
         }
-
     } catch (e) {
-        adapter.log.error("exception in AddObject " + "[" + e + "]");
+        adapter.log.error(`exception in AddObject ` + `[${  e  }]`);
     }
 }
 
 async function UpdateObject(key, value) {
     try {
         if (value === undefined) {
-            adapter.log.warn("updateObject: not updated " + key + " value: " + value + " " + typeof value);
-        }
-        else if (value == null ) {
-            adapter.log.debug("updateObject: update to null " + key + " value: " + value);
+            adapter.log.warn(`updateObject: not updated ${  key  } value: ${  value  } ${  typeof value}`);
+        } else if (value == null ) {
+            adapter.log.debug(`updateObject: update to null ${  key  } value: ${  value}`);
             await adapter.setStateAsync(key, { ack: true, val: null });
-        }
-        else {
-            adapter.log.debug("updateObject " + key + " : " + value);
+        } else {
+            //adapter.log.debug("updateObject " + key + " : " + value);
             await adapter.setStateAsync(key, { ack: true, val: value });
-        }        
+        }
     } catch (e) {
-        adapter.log.error("exception in UpdateObject " + "[" + e + "]");
+        adapter.log.error(`exception in UpdateObject ` + `[${  e  }]`);
     }
 }
 
-
 //telnet client to write to ebusd
 //https://github.com/john30/ebusd/wiki/3.1.-TCP-client-commands
 /*
@@ -1273,37 +1438,33 @@ read -f YieldTotal,read LegioProtectionEnabled,read -f -c broadcast outsidetemp
 
 */
 
-
 //this function just triggers ebusd to read data; result will not be parsed; we just take the values from http result
 //here we need a loop over all configured read data in admin-page
 async function ebusd_ReadValues() {
-
     if (oPolledVars.length > 0) {
-
-        adapter.log.debug("to poll ctr " + oPolledVars.length + " vals:  " + JSON.stringify(oPolledVars));
+        adapter.log.debug(`to poll ctr ${  oPolledVars.length  } vals:  ${  JSON.stringify(oPolledVars)}`);
 
         try {
             const socket = new net.Socket();
             const promiseSocket = new PromiseSocket(socket);
 
             await promiseSocket.connect(parseInt(adapter.config.targetTelnetPort), adapter.config.targetIP);
-            adapter.log.debug("telnet connected to poll variables " + adapter.config.targetIP + " port " + adapter.config.targetTelnetPort);
+            adapter.log.debug(`telnet connected to poll variables ${  adapter.config.targetIP  } port ${  adapter.config.targetTelnetPort}`);
             promiseSocket.setTimeout(5000);
 
             let retries = 0;
             for (let nCtr = 0; nCtr < oPolledVars.length; nCtr++) {
-
                 let circuit = "";
                 let params = "";
                 if (oPolledVars[nCtr].circuit != null && oPolledVars[nCtr].circuit.length > 0) {
-                    circuit = "-c " + oPolledVars[nCtr].circuit + " ";
+                    circuit = `-c ${  oPolledVars[nCtr].circuit  } `;
                 }
                 if (oPolledVars[nCtr].parameter != null && oPolledVars[nCtr].parameter.length > 0) {
-                    params = " " + oPolledVars[nCtr].parameter;
+                    params = ` ${  oPolledVars[nCtr].parameter}`;
                 }
-                let cmd = "read -f " + circuit + oPolledVars[nCtr].name + params;
+                let cmd = `read -f ${  circuit  }${oPolledVars[nCtr].name  }${params}`;
 
-                adapter.log.debug("send cmd " + cmd);
+                adapter.log.debug(`send cmd ${  cmd}`);
 
                 cmd += "\n";
                 await promiseSocket.write(cmd);
@@ -1312,56 +1473,44 @@ async function ebusd_ReadValues() {
 
                 //received ERR: arbitration lost for YieldThisYear
                 if (data.includes("ERR")) {
-                    adapter.log.warn("sent " + cmd + ", received " + data + " for " + JSON.stringify(oPolledVars[nCtr]) + " please check ebusd logs for details!");
+                    adapter.log.warn(`sent ${  cmd  }, received ${  data  } for ${  JSON.stringify(oPolledVars[nCtr])  } please check ebusd logs for details!`);
 
                     /*
-                    * sent read -f YieldLastYear, received ERR: arbitration lost for {"circuit":"","name":"YieldLastYear","parameter":""}
-                    * */
+                     * sent read -f YieldLastYear, received ERR: arbitration lost for {"circuit":"","name":"YieldLastYear","parameter":""}
+                     * */
                     if (data.includes("arbitration lost")) {
-
                         retries++;
                         if (retries > adapter.config.maxretries) {
-                            adapter.log.error("max retries, skip cmd " + cmd);
+                            adapter.log.error(`max retries, skip cmd ${  cmd}`);
                             retries = 0;
-                        }
-                        else {
+                        } else {
                             nCtr--;
                             adapter.log.debug("retry to send data ");
                         }
                     }
-                }
-                else {
-                    adapter.log.debug("received " + data + " for " + JSON.stringify(oPolledVars[nCtr]));
+                } else {
+                    adapter.log.debug(`received ${  data  } for ${  JSON.stringify(oPolledVars[nCtr])}`);
                 }
             }
             promiseSocket.destroy();
             adapter.log.debug("telnet disonnected");
-
         } catch (e) {
-            adapter.log.error("exception from tcp socket in ebusd_ReadValues " + "[" + e + "]");
+            adapter.log.error(`exception from tcp socket in ebusd_ReadValues ` + `[${  e  }]`);
         }
-
-
-    }
-    else {
+    } else {
         adapter.log.debug("nothing to poll; skip telnet");
     }
-
 }
 
-
 async function FindParams(obj) {
-
-    adapter.log.debug("FindParams " + JSON.stringify(obj) + " " + JSON.stringify(obj.message) + " " + JSON.stringify(obj.message.circuit));
+    adapter.log.debug(`FindParams ${  JSON.stringify(obj)  } ${  JSON.stringify(obj.message)  } ${  JSON.stringify(obj.message.circuit)}`);
 
     const list = [];
-    
 
     try {
         //FindParams {"command":"findParams","message":{"circuit":"cc"},"from":"system.adapter.admin.0","callback":{"message":{"circuit":"cc"},"id":90,"ack":false,"time":1733690088670},"_id":39690903}
 
         if (obj.message != null) {
-
             const circuit = obj.message.circuit;
 
             const socket = new net.Socket();
@@ -1371,16 +1520,16 @@ async function FindParams(obj) {
             adapter.log.debug("telnet connected for cmd");
             promiseSocket.setTimeout(5000);
 
-            const cmd = "find -c " + circuit + " -F circuit,name\n";
+            const cmd = `find -c ${  circuit  } -F circuit,name\n`;
             await promiseSocket.write(cmd);
 
             const data = await promiseSocket.read();
 
             if (data.includes("ERR")) {
-                adapter.log.warn("received error! sent find, received " + data + " please check ebusd logs for details! " + cmd);
-            }
-            else {
-                adapter.log.debug("received " + typeof data + " " + data + " " + + cmd);
+                adapter.log.warn(`received error! sent find, received ${  data  } please check ebusd logs for details! ${  cmd}`);
+                
+            } else {
+                adapter.log.debug(`received ${  typeof data  } ${  data  } ${  + cmd}`);
             }
             /*
               received object ehp,AccelerationTestModeehp,AccelerationTestModeehp,ActualEnvironmentPowerehp,ActualEnvironmentPowerehp,ActualEnvironmentPowerPercentageehp,ActualEnvironmentPowerPercentageehp,ApplianceCodeehp,ApplianceCodeehp,Backupehp,Backupehp,BackupHoursehp,BackupHoursHcehp,BackupHoursHwcehp,BackupHysteresisehp,BackupIntegralehp,BackupModeHcehp,BackupModeHwcehp,BackupPowerCutehp,BackupStartsehp,BackupStartsHcehp,BackupStartsHwcehp,BackupTypeehp,BivalentTempehp,Bleedingehp,Bleedingehp,CirPumpehp,CirPumpehp,Code1ehp,Code1Code2Validehp,Code2ehp,Compehp,Compehp,CompControlStateehp,CompCutPressHighCountehp,CompCutPressLowCountehp,CompCutTempCountehp,CompDemandehp,CompHoursehp,CompHoursHcehp,CompHoursHwcehp,CompHysteresisehp,CompIntegralehp,CompPressHighehp,CompPressHighehp,CompPressLowehp,CompPressLowehp,CompStartsehp,CompStartsHcehp,CompStartsHwcehp,CompStateehp,CondensorTempehp,CondensorTempehp,currenterrorehp,Dateehp,DateTimeehp,DeltaTempT6T7ehp,ElectricWiringDiagramehp,ElectricWiringDiagramehp,EnergyBalancingReleaseehp,errorhistoryehp,FlowTempehp,FlowTempehp,FlowtempCoolingMinehp,FlowTempOffsetehp,Hc1Pumpehp,Hc1Pumpehp,Hc1PumpHoursehp,Hc1PumpPortehp,Hc1PumpStartsehp,Hc2Pumpehp,Hc2PumpHoursehp,HcFlowTempehp,HcFlowTempOffsetehp,HcModeDemandHoursehp,HcModeFulfilledHoursehp,HcParallelStorageFillingEnabledehp,HcPressehp,HcReturnTempehp,HcReturnTempehp,HcReturnTempOffsetehp,HeatPumpStatusehp,HeatPumpStatusehp,HeatpumpTypeehp,HwcHcValveehp,HwcHcValveehp,HwcHcValveStartsehp,HwcLaggingTimeehp,HwcLoadingDelayehp,HwcModeDemandHoursehp,HwcModeFulfilledHoursehp,HwcPumpStartsehp,HwcSwitchehp,HwcTempehp,HwcTempehp,HwcTempOffsetehp,HydraulicSchemeehp,ICLOutehp,ICLOutehp,Injectionehp,Integralehp,Mixer1DutyCycleehp,NumberCompStartsehp,OutsideTempehp,OutsideTempOffsetehp,OverpressureThresholdehp,PhaseOrderehp,PhaseOrderehp,PhaseStatusehp,PhaseStatusehp,PowerCutehp,PowerCutPreloadingehp,PressSwitchehp,PressSwitchehp,RebootCounterehp,ReturnTempMaxehp,SetModeehp,SoftwareCodeehp,Source2PumpHoursehp,Sourceehp,Sourceehp,SourceHoursehp,SourcePortehp,SourcePressehp,SourcePumpPrerunTimeehp,SourceStartsehp,SourceSwitchehp,SourceSwitchehp,SourceTempInputehp,SourceTempInputehp,SourceTempInputOffsetehp,SourceTempOutputehp,SourceTempOutputehp,SourceTempOutputOffsetehp,SourceTempOutputT8Minehp,StateSoftwareCodeehp,StateSoftwareCodeehp,Status01ehp,Status02ehp,Status16ehp,Statusehp,StatusCirPumpehp,StorageTempBottomehp,StorageTempBottomehp,StorageTempBottomOffsetehp,StorageTempTopehp,StorageTempTopehp,StorageTempTopOffsetehp,Subcoolingehp,Superheatehp,T19MaxToCompOffehp,TempInputehp,TempInputehp,TempInputOffsetehp,TempOutputehp,TempOutputehp,TempOutputOffsetehp,Timeehp,TimeBetweenTwoCompStartsMinehp,TimeCompOffMinehp,TimeCompOnMinehp,TimeOfNextPredictedPowerCutehp,TimeOfNextPredictedPowerCutehp,Weekdayehp,YieldTotalehp,YieldTotal
@@ -1389,7 +1538,6 @@ async function FindParams(obj) {
             const datas = str.split(/\r?\n/);
 
             for (let i = 0; i < datas.length; i++) {
-
                 //adapter.log.debug(JSON.stringify(datas[i]));
 
                 const names = datas[i].split(",");
@@ -1399,11 +1547,9 @@ async function FindParams(obj) {
 
                 if (names[0] == "" || names[1] == "") {
                     add = false;
-                }
-                else {
+                } else {
 
                     for (let n = 0; n < list.length; n++) {
-
                         if (list[n].circuit == names[0] && list[n].name == names[1]) {
                             add = false;
                             //already in list
@@ -1415,27 +1561,24 @@ async function FindParams(obj) {
                     const entry = {
                         active: false,
                         circuit: names[0],
-                        name: names[1]
+                        name: names[1],
                     };
 
                     list.push(entry);
                 }
             }
-        }
-        else {
+        } else {
             adapter.log.error("no circuit defined where to look for parameter, check values!");
         }
     } catch (e) {
-        adapter.log.error("exception in FindParams " + "[" + e + "]");
+        adapter.log.error(`exception in FindParams ` + `[${  e  }]`);
     }
 
-    adapter.log.info("parameters " + JSON.stringify(list));
-
+    adapter.log.info(`parameters ${  JSON.stringify(list)}`);
 
     adapter.sendTo(obj.from, obj.command, list, obj.callback);
 }
 
-
 async function CallExternalScript(script, msg) {
 
 
@@ -1456,7 +1599,7 @@ async function CallExternalScript(script, msg) {
                 adapter.sendTo(msg.from, msg.command, { error: 'script folder not found ' + folderName }, msg.callback);
                 return;
             }
-            else {
+            
 
                 adapter.log.info("folder exists " + folderName);
 
@@ -1471,8 +1614,7 @@ async function CallExternalScript(script, msg) {
 
                     return;
 
-                }
-                else {
+                } else {
 
                     adapter.log.info("file exists " + scriptfile);
 
@@ -1498,9 +1640,8 @@ async function CallExternalScript(script, msg) {
                         }, msg.callback);
                     });
                 }
-            }
-        }
-        else {
+            
+        } else {
             adapter.sendTo(msg.from, msg.command, { error: 'possible only on Linux systems, this system is  ' + os.platform() }, msg.callback);
         }
     } catch (e) {
@@ -1546,17 +1687,44 @@ async function CallExternalScript(script, msg) {
 }
 
 async function CheckVersion(version, msg) {
-
     if (version == "installable") {
-        adapter.sendTo(msg.from, msg.command, ebusdUpdateVersion[0] + "." + ebusdUpdateVersion[1], msg.callback);
-    }
-    else if (version == "current") {
-        adapter.sendTo(msg.from, msg.command, ebusdVersion[0] + "." + ebusdVersion[1], msg.callback);
-    }
-    else if (version == "supported") {
-        adapter.sendTo(msg.from, msg.command, ebusdMinVersion[0] + "." + ebusdMinVersion[1], msg.callback);
+        let version = "unknown";
+
+        if (ebusdUpdateVersion[0] > 0 && ebusdVersion[0] > 0) {
+            version = `${ebusdUpdateVersion[0]  }.${  ebusdUpdateVersion[1]}`
+        } else {
+            version = await GetLatestVersionGithub();
+        }
+        adapter.sendTo(msg.from, msg.command, version, msg.callback);
+    } else if (version == "current") {
+        adapter.sendTo(msg.from, msg.command, `${ebusdVersion[0]  }.${  ebusdVersion[1]}`, msg.callback);
+    } else if (version == "supported") {
+        adapter.sendTo(msg.from, msg.command, `${ebusdMinVersion[0]  }.${  ebusdMinVersion[1]}`, msg.callback);
     }
+}
+
+async function GetLatestVersionGithub() {
+    let latestVersion = "unknown";
+
+    try {
+        const url = "https://api.github.com/repos/john30/ebusd/releases/latest";
+        adapter.log.debug(`call ${  url}`);
+
+        let result = await axios.get(url, { timeout: 5000 });
 
+        if (result != null && result.status == 200 && result.data != null) {
+            adapter.log.info(`installable version on github ${  JSON.stringify(result.data.tag_name)  } (${  JSON.stringify(result.data.name)  })`);
+
+            latestVersion =
+                "on github " + JSON.stringify(result.data.tag_name) + "(" + JSON.stringify(result.data.name) + ")";
+        } else {
+            latestVersion = "unknown / no result";
+        }
+    } catch (e) {
+        adapter.log.error(`exception in GetLatestVersionGithub [${  e  }]`);
+        latestVersion = "unknown / error";
+    }
+    return latestVersion;
 }
 
 // If started as allInOne/compact mode => return function to create instance
@@ -1565,4 +1733,4 @@ if (module && module.parent) {
 } else {
     // or start the instance directly
     startAdapter();
-} 
+}